Another two examples examples:
https://github.com/sgrebnov/BluetoothSerial/blob/master/src/wp/Bluetooth.cs#L549
Listbyte data = JsonHelper.DeserializeListbyte(args[0]);
..
dataWriter.WriteBytes(data.ToArray())
https://github.com/apache/cordova-plugin-file/blob/master/src/wp/File.cs#L884
byte[]
Is there a determined calendar for the npm move of the plugins?
I think the scheduling of the transition is crucial for those who are
using the plugin registry directly.
--
Gorkem
-
To unsubscribe, e-mail:
We don't have one yet but we should pick dates soon.
How about:
CPR Switch to read only: Monday, May 18th
NPM fetch becomes default: Monday, May 18th
CPR offline: Monday, August 17th
Based on the following proposal:
Steve, npm fetch default only affects plugins that use same name in both
places, right?
If we create cordova-plugin-device today, and tell users to start using
cordova plugin add cordova-plugin-device, then we will get much user
feedback on npm fetching far before May 18th, right?
On Wed, Feb
Correct! For the first 3 months, all requests will hit CPR first, if CPR
fails, we will try to fetch from npm.
If users run cordova plugin add cordova-plugin-device, it would hit CPR,
fail, go to npm, succeed.
If we use the mapper module, cordova plugin add
org.apache.cordova.device would be
The File plugin should have that -- spec test 104 tests calling
FileWriter.write() with an ArrayBuffer as an argument.
The write() method in File.cs looks like it uses
JSON.JsonHelper.Deserialize to deserialize it, though -- you might have to
dig into the bridge to see exactly how and where it
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/162#discussion_r24500705
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -114,6 +116,22 @@ module.exports = function plugin(command, targets,
opts) {
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/162#issuecomment-73895354
lgtm save one nit. I think this behaviour is fine. Normal case will be to
use add --save anyways.
---
If your project is set up for it, you can reply to this email
Just checked - link is working again. Please cast some votes :)
On Mon, Feb 9, 2015 at 1:55 PM, Andrew Grieve agri...@chromium.org wrote:
I can't even svn up on it right now. Think it's just having an outage.
On Mon, Feb 9, 2015 at 11:19 AM, Alexander Sorokin (Akvelon)
Going to try and summarize my concerns with the proposal here:
On Wed, Feb 11, 2015 at 2:39 PM, Steven Gill stevengil...@gmail.com wrote:
Correct! For the first 3 months, all requests will hit CPR first, if CPR
fails, we will try to fetch from npm.
If users run cordova plugin add
The proposal contains suggestions, alternatives and comments.
https://docs.google.com/document/d/12WAXJa6jfY3BnNHGieK9QOqvZ6cl3OXmP-9DpYkcmfs/edit?usp=sharing
When will there be a final version that is the official plan?
One other question: Soon we will have optional 'save' of plugin metadata
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
ah, I missed that lstatSync throws an exception for non-string args. I
suppose that's fine. Will merge!
On Wed, Feb 11, 2015 at 2:54 PM, omefire g...@git.apache.org wrote:
Github user omefire commented on a diff in the pull request:
Leo, restore will still work. The only information stored in the saves
list is a set of plugin ids (and versions?). Restoring will go through the
steps Steve outlines above, and either download from CPR or be mapped
automatically to the npm equivalent. After the deprecation cutoff, plugins
that
Leo, the rename isn't required, as a third party author you can publish
your plugin using the plugin id to npm, and no mapping is required.
But for cordova core plugins, we think the plugin id is a bad choice for
package name for aesthetic reasons, and the fixed name mapping solution
provides us
Does travis provide Android emulators? I'd guess it'd be too slow to put on
Travis. And honestly, there's still not a lot of value in the unit tests
atm.
On Wed, Feb 11, 2015 at 3:12 PM, Murat Sutunc mura...@microsoft.com wrote:
This is great news!
I've finally got the android travis enabled
This is great news!
I've finally got the android travis enabled too. We have jshint and jasmine
test coverage on every commit now.
(https://travis-ci.org/apache/cordova-android/builds/50295748)
Now that we're passing all junit tests, I think the next step for us should be
to integrate junit
Hey everyone,
Can someone give me access to close the following jiras?
https://issues.apache.org/jira/browse/CB-8412
https://issues.apache.org/jira/browse/CB-8410
https://issues.apache.org/jira/browse/CB-8400
https://issues.apache.org/jira/browse/CB-8168
Thanks,
Murat
I've been keeping the whitelist breakout on a branch for some time now, but
since this is something that we want to get into Cordova 4.0.0, it will
have to be merged in soon.
I've rebased it against master as of this afternoon, and pushed it into a
branch - unplug-whitelist-4.0.0 -- It passes all
I think we should revert this refactor. With the new refactored tests,
they may pass but we lost a lot of the useful tests that we once had and
these new tests have no value. I don't know why you took it upon yourself
to throw away all the JUnit tests that didn't pass, but that misses the
point.
+1 Revert
And please let's stop deleting what other people wrote just because we
don't recognize it. These things should require discussion.
@purplecabbage
risingj.com
On Wed, Feb 11, 2015 at 1:53 PM, Joe Bowser bows...@gmail.com wrote:
I think we should revert this refactor. With the new
Github user Rickgbw commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-73974616
It's a very old issue. But, if is needed, I can sign...
Any thoughts on this, @shazron ?
---
If your project is set up for it, you can reply to this
I think there's a lot of value in the Unit Tests, having wrote the majority
of them initially. If I wasn't dealing with everyone in my house getting
sick, I'd check to make sure these tests were still testing what I intended
them to test, since we have a habit of losing the intent behind the
I'm reverting this now, 37 tests with 4 failures is much better than roughy
20 tests with 0 failures. (I didn't run the refactored tests, since
there's no point if critical tests are missing).
On Wed Feb 11 2015 at 2:01:51 PM Jesse purplecabb...@gmail.com wrote:
+1 Revert
And please let's
+1
The email currently says “If your app does not use the Apple Push Notification
service, no action is required”, but it probably freaks new users out. Also, it
might become a “thing” in the future.
--
tommy-carlos williams
On 12 February 2015 at 10:10:59, Shazron (shaz...@gmail.com)
Hi,
It has been a while since we did a Windows release. I specifically wanted to
start a discuss thread to release Windows due to the following issue that had
been fixed, but looks like was never released out.
The bug (https://issues.apache.org/jira/browse/CB-7985) is about not being able
to
I would agree that we should change plugin ID as well as package name, but
I don't think that affects the results.
All 3 of those use cases you mentioned I think are addressed equivalently.
Whether the plugin is added as a dependency, with save/restore, or
explicitly from the command line,
On 11 Feb 2015, at 13:09, Steven Gill wrote:
We don't have one yet but we should pick dates soon.
How about:
CPR Switch to read only: Monday, May 18th
NPM fetch becomes default: Monday, May 18th
CPR offline: Monday, August 17th
I was hoping for a longer read-only period, 6 months would be
Mapper: https://github.com/stevengill/cordova-registry-mapper
Mapper would be a dependency of cordova-lib. We would use it during cordova
plugin add/rm to map old id's to new name.
We can look at extending CPR readonly phase but I fear we may have to deal
with migrating it to a different
Done, and done'r
@purplecabbage
risingj.com
On Wed, Feb 11, 2015 at 12:13 PM, Murat Sutunc mura...@microsoft.com
wrote:
Hey everyone,
Can someone give me access to close the following jiras?
https://issues.apache.org/jira/browse/CB-8412
https://issues.apache.org/jira/browse/CB-8410
See:
https://github.com/apache/cordova-ios/blob/338ee71f966ab7fdc1ccde02e5086febbc82b70c/bin/templates/project/__PROJECT_NAME__/Classes/AppDelegate.m#L110-L135
I'd rather do this in 3.8.0, but we would break things for users, so
in 4.0 it goes.
Related issue:
On 11 Feb 2015, at 15:50, Michal Mocny wrote:
Leo, restore will still work. The only information stored in the
saves
list is a set of plugin ids (and versions?). Restoring will go
through the
steps Steve outlines above, and either download from CPR or be mapped
automatically to the npm
I agree with Steve to move forward with this. The package name
rationale was already discussed during the hangout, and we all agreed.
On Wed, Feb 11, 2015 at 3:43 PM, Steven Gill stevengil...@gmail.com wrote:
Mapper: https://github.com/stevengill/cordova-registry-mapper
Mapper would be a
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-lib/pull/165
CB-8457: Ignore version specifier when running hooks
Trims the version specifier when running hooks. This allows platform add
hooks to run when a version specific platform add command is
Sorry for the scare. Maybe I wasn't clear, but I did not delete any failing
tests. I *fixed* the failing tests by having them wait on mutexes instead
of using Thread.sleep().
What I *did* delete:
- Duplicate tests
- Massive amounts of copy paste (refactor from having one activity
per-test, to
Ah, just saw this after responding to the other thread. It was an accident.
On Wed, Feb 11, 2015 at 4:48 PM, Joe Bowser bows...@gmail.com wrote:
Responding via private list because this is about a security issue.
Andrew, your refactor deleted a very important JUnit test, the
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-73999167
Thanks Jesse!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/59#issuecomment-74001582
Are you doing anything other than adding a bunch of trace/debug log
entries?
This pull request will not be merged. Please close.
---
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
On Wed, Feb 11, 2015 at 5:00 PM, Jesse purplecabb...@gmail.com wrote:
+1 Revert
And please let's stop deleting what other people wrote just because we
don't recognize it. These things should require discussion.
Bit of a jump to conclusions, don't you think? What makes you think I don't
Great idea, let's do that.
On Wednesday, February 11, 2015, Andrew Grieve agri...@chromium.org wrote:
Sounds good.
Since we're making a 4.0 change here anyways, might be a good idea to empty
out that template file and instead have it extend a base class from
CordovaLib (this is what Android
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-73998473
Thanks Tim! This is now merged, the mirror is just slow to update. This
should close in a few minutes.
---
If your project is set up for it, you can reply to
Sounds good.
Since we're making a 4.0 change here anyways, might be a good idea to empty
out that template file and instead have it extend a base class from
CordovaLib (this is what Android does). Main reason is that the file will
be updated when swapping in new versions of CordovaLib.
On Wed,
Not specifically, yet -- I have done manual testing on it so far, and was
going to work with Andrew to put proper unit tests in before we cut 4.0.0.
On Wed, Feb 11, 2015 at 4:39 PM, Joe Bowser bows...@gmail.com wrote:
Are their JUnit tests to test the new unplugged whitelist?
On Wed Feb 11
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/35#issuecomment-73857850
Tested, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-73859774
Reviewed and tested, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/55#issuecomment-73867207
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user stefanoortisi commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-73879343
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/25
CB-8185 Use `navigator.onLine` as connection information source on browser
platform
This is fix for [CB-8185](https://issues.apache.org/jira/browse/CB-8185)
58 matches
Mail list logo
