sohami edited a comment on issue #1459: DRILL-6731: Move the BFs aggregating
work from the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#issuecomment-427254392
Thanks! If the changes looks good to you. Please give your +1 for my commits.
sohami commented on issue #1459: DRILL-6731: Move the BFs aggregating work from
the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#issuecomment-427254392
Thanks!
This is an automated message from
sohami commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222897205
##
File path:
sohami commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222897199
##
File path:
sohami commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222897205
##
File path:
sohami commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222897190
##
File path:
sohami commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222897211
##
File path:
weijietong commented on issue #1459: DRILL-6731: Move the BFs aggregating work
from the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#issuecomment-427238455
@sohami done.
This is an automated
Ben-Zvi commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222875690
##
File path:
Ben-Zvi commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222876377
##
File path:
Ben-Zvi commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222874084
##
File path:
Ben-Zvi commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222874733
##
File path:
gparai commented on issue #1489: DRILL-6770: JsonTableGroupScan should use new
MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489#issuecomment-427207684
@vdiravka yes these changes will be overridden by the Secondary Index PR
which is currently in review. For this PR, we
gparai commented on a change in pull request #1489: DRILL-6770:
JsonTableGroupScan should use new MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489#discussion_r222862324
##
File path:
kkhatua commented on issue #1491: DRILL-6084: Show Drill functions in WebUI for
autocomplete
URL: https://github.com/apache/drill/pull/1491#issuecomment-427205047
@arina-ielchiieva / @ilooner please review only the last commit, as this is
rebased off commit #1483 , which (in turn) is
kkhatua opened a new pull request #1491: DRILL-6084: Show Drill functions in
WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491
Building on top of DRILL-3988 and leveraging DRILL-5868, this allows support
for Drill functions to be now available in the WebUI.
If users
sohami commented on issue #1459: DRILL-6731: Move the BFs aggregating work from
the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#issuecomment-427195637
@weijietong - The fix is in the last commit of this branch
kkhatua commented on issue #1483: DRILL-3988: Expose Drill built-in functions &
UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#issuecomment-427191976
@arina-ielchiieva updated the PR with an additional commit.
kfaraaz commented on issue #1483: DRILL-3988: Expose Drill built-in functions &
UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#issuecomment-427165724
@kkhatua I checked there are no existing functional tests that do a DROP
FUNCTION USING ...
We need to add
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222806883
##
File path:
amansinha100 commented on a change in pull request #1489: DRILL-6770:
JsonTableGroupScan should use new MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489#discussion_r222793328
##
File path:
vdiravka commented on issue #1489: DRILL-6770: JsonTableGroupScan should use
new MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489#issuecomment-427132855
The change should solve the issue. Looks like to avoid similar in future it
would be good to get rid of using
HanumathRao commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222784716
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java
##
@@ -0,0
Sorabh Hamirwasia created DRILL-6772:
Summary: Refactor StreamingAggBatch
Key: DRILL-6772
URL: https://issues.apache.org/jira/browse/DRILL-6772
Project: Apache Drill
Issue Type:
sohami commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222782213
##
File path:
sohami commented on issue #1490: DRILL-6766: Lateral Unnest query :
IllegalStateException - rowId in right batch of lateral is smaller than rowId
in left batch being processed
URL: https://github.com/apache/drill/pull/1490#issuecomment-427126018
With this change the jar size of jdbc-all
sohami opened a new pull request #1490: DRILL-6766: Lateral Unnest query :
IllegalStateException - rowId in right batch of lateral is smaller than rowId
in left batch being processed
URL: https://github.com/apache/drill/pull/1490
This PR has 2 commits:
1) Commit 1 just fixes and adds
HanumathRao commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222781427
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
HanumathRao commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222780864
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -65,6
Agirish commented on a change in pull request #1489: DRILL-6770:
JsonTableGroupScan should use new MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489#discussion_r222780156
##
File path:
gparai opened a new pull request #1489: DRILL-6770: JsonTableGroupScan should
use new MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489
MapRDB 6.1.0 has removed support for some APIs which breaks Drill code
(Deprecation should have been used instead). This PR uses the new
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222771664
##
File path:
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222771701
##
File path:
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222771518
##
File path:
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222770729
##
File path:
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222770403
##
File path:
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222769104
##
File path:
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222760646
##
File path:
ihuzenko commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222692367
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java
##
@@ -0,0 +1,189
vvysotskyi commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222760140
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java
##
@@ -0,0
vvysotskyi commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222759782
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -127,6
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222671465
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
##
@@
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222660687
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -33,29
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222670031
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -127,6
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222669950
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -127,6
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222692650
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java
##
@@ -0,0 +1,189 @@
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222692367
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java
##
@@ -0,0 +1,189 @@
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222664472
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -65,6
Hi Vamshi,
Can you provide more information about the datastore?
—C
> On Oct 4, 2018, at 07:57, VamshiNath Reddy wrote:
>
> Hi team,
>
> I want apache drill to connect to our own plugin which is a non-sql datastore
> which is in the json format.Can you please provide a example for doing the
Hi team,
I want apache drill to connect to our own plugin which is a non-sql datastore
which is in the json format.Can you please provide a example for doing the
custom plugin to write.
Thanks,
Vamshi
priteshm commented on issue #1488: DRILL-786: Implement CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#issuecomment-427086179
@amansinha100 @HanumathRao can you also review this since you'll have
comments on the JIRA.
lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL
functions with constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-427007830
@vvysotskyi thanks for your suggestions.
I didn't know that Travis only run some of the test.
I'm sorry
vvysotskyi commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r22264
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
##
@@
vvysotskyi commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222649579
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java
##
@@ -0,0 +1,189
vvysotskyi commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222646208
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -33,29
vvysotskyi commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222626314
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -127,6
vvysotskyi commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222626091
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -127,6
vvysotskyi commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222646339
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##
@@ -65,6
vvysotskyi commented on a change in pull request #1488: DRILL-786: Implement
CROSS JOIN
URL: https://github.com/apache/drill/pull/1488#discussion_r222649212
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java
##
@@ -0,0 +1,189
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222614012
##
File path:
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222601096
##
File path:
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r55328
##
File path:
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222621009
##
File path:
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222607432
##
File path:
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222597944
##
File path:
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222618933
##
File path:
ihuzenko opened a new pull request #1488: DRILL-786: Implement CROSS JOIN
URL: https://github.com/apache/drill/pull/1488
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vdiravka commented on a change in pull request #1398: DRILL-6541: Upgrade
ZooKeeper patch version to 3.4.11 for mapr profile
URL: https://github.com/apache/drill/pull/1398#discussion_r222614476
##
File path: pom.xml
##
@@ -3018,6 +3018,13 @@
arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222602489
##
File path:
arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222602309
##
File path:
arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222602550
##
File path:
arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222602456
##
File path:
arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222602065
##
File path:
arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222601123
##
File path:
arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r222601521
##
File path:
KazydubB commented on issue #1398: DRILL-6541: Upgrade ZooKeeper patch version
to 3.4.11 for mapr profile
URL: https://github.com/apache/drill/pull/1398#issuecomment-426931750
@vdiravka the version is released, can you review please?
76 matches
Mail list logo