Re: 4.16.0 Install issues

Cool! I missed seeing this JIRA. I took a quick look and didn't see spline conversion handling between TTF and CFF. I think it may not handle specifying a TTF file for embedAsCFF=true and vice versa. But maybe we can live without it. Any volunteers to take this on? -Alex On 7/6/17, 10:01

Re: 4.16.0 Install issues

Maybe I wasn't clear enough: I don't think the version of Ant will affect the SSL issues. The SSL issues should be solvable via the JCE upgrade: http://stackoverflow.com/questions/38203971/javax-net-ssl-sslhandshakeexcep tion-received-fatal-alert-handshake-failure/38264878#38264878 I'm not

Re: 4.16.0 Install issues

Nicholas Kwiatkowski-2 wrote > - Re-creating Fontkit. Chris Dutz said he might be able to work on it, > but I havent seen anything else to that affect. At ApacheCon somebody found a lib that maybe contains a working FontKit port. Piotr created a JIRA that contains the link [1] HTH, Olaf

Re: 4.16.0 Install issues

I remember reading about needing the latest ANT, so I installed 1.10.1 and 1.9.9 on my Windows 10 machine with the latest Java 8 install and still had the SSL errors. I just read through the threads where where there was a discussion about it. There were three things talked about : - Having

Re: [FlexJS] technical debt

Hi, > Think of it like this if someone makes a commit you would not revert without > giving them an opportunity to do it first. > > So the suggestion from me is get approval for anything complex. It is the > social thing to do. !00% agree. > I see you asked directly about a standard else

Re: [FlexJS] technical debt

Sent from my iPhone > On Jul 6, 2017, at 5:22 PM, Justin Mclean wrote: > > Hi, > >> If you make a change to fix technical debt then you should also assure that >> both existing tests pass and if no tests exist then tests are added and >> proper. > > I’m all for

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

Hi, What do people feel about setting a code and branch coverage on all checkins? Say 80% coverage of changes made? Thanks, Justin

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi Alex, I googled FlexJS API reference and found the link: http://people.apache.org/~pent/asdoc-flexjs/ Thanks for pointing out that ASDOC is probably out of date. I built examples/flexjs/ASDoc; the build was successful, it created in the target folder an index.html, SummaryRenderer.js and

Re: [FlexJS] technical debt

>> Well Object is always THE base class. It may not be known what the actual base class should be and it is certainly not flexible to always create a base class just to have a one to satisfy the rule. >Nor would I suggest that. There are some cases where creating a new class with properties is

Re: [FlexJS] technical debt

Hi, > If you make a change to fix technical debt then you should also assure that > both existing tests pass and if no tests exist then tests are added and > proper. I’m all for more tests. However should this apply to any changes anyone makes for any reason OR only changes I make? I asking

Re: [FlexJS] technical debt

Hi, > That is the concern, but it may be that the developer was making a > speculative change. If I were cleaning then I would do one of two actions. > > (a) Review the history of that change and see if the associated comments > provide a reason. > (b) Ask the developer who made the change.

Re: [FlexJS][VS Code] dual issues

The AS/MXML code intelligence in VSCode instantiates certain classes from the compiler to get the data it needs. Previously, I was instantiating a FlexProject no matter which targets were specified. Now, I instantiate a FlexJSProject when I'm sure that JS should have a higher priority than SWF

Re: [FlexJS] technical debt

> On Jul 6, 2017, at 4:22 PM, Justin Mclean wrote: > > Hi, > >> - Do we care about code being commented out? I think not. > > If we know why it was commented out sure. There’s always the concern is this > code possibly needed or not? That is the concern, but it may

Re: [FlexJS] technical debt

> On Jul 6, 2017, at 4:30 PM, Justin Mclean wrote: > > Hi, > >>> IMO, even more important than technical debt is a test system and tests to >>> make sure any changes don't break anything. >> >> That would include any changes to fix “technical debt”. > > Or if fact

Re: [FlexJS] technical debt

Hi, >> IMO, even more important than technical debt is a test system and tests to >> make sure any changes don't break anything. > > That would include any changes to fix “technical debt”. Or if fact any changes right? Thanks, Justin

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > I just tried swapping SimpleCSSValuesImpl for AllCSSValuesImpl in the > develop branch in examples/flexjs/DataBindingExample and it worked for me. > > Does it still not work for you? It still does not work for me. Justin

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

Hi, BTW Sonar can give you useful test coverage statistics [1] and will even show line by line where a test is covered by tests [2] look at the red and green bars in the gutter. Thanks, Justin 1.

Re: [FlexJS][VS Code] dual issues

I agree, it will be great to get JS API code-intelligence. Just out of curiosity, what did you have to change? One work item for the future is to merge the "JS" SWC into the "SWF" SWC so there is only one SWC per library instead of the current pair like Core.SWC and CoreJS.swc. I'm trying to

Re: [FlexJS] technical debt

Hi, > - Do we care about code being commented out? I think not. If we know why it was commented out sure. There’s always the concern is this code possibly needed or not? > - Does a semicolon matter? It marked as a minor issue but it can cause issues when JS code is optimised and/or minified.

Re: [FlexJS][VS Code] dual issues

Okay, I figured out how to make VSCode switch to JS APIs instead of SWF APIs for completion and things. In the next version of the extension, when the targets compiler option is specified in asconfig.json, and the first value isn't "SWF", the extension will offer JS APIs. That includes giving you

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

I just tried swapping SimpleCSSValuesImpl for AllCSSValuesImpl in the develop branch in examples/flexjs/DataBindingExample and it worked for me. Does it still not work for you? -Alex On 6/29/17, 3:40 AM, "Harbs" wrote: >Check your basic-manifest.xml for Core. > >Do you

Re: [FlexJS] technical debt

Hi, > A large percentage of the complaints are inaccurate. The reason the technical > debt increased is largely because of the new TLF code. > > Who made these rules and how do we change them? We can make it look much > better by just changing some of the rules… The rules come from various

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi Allen, I just updated the FlexJS ASDoc link from our website. Because FlexJS does some enhanced parsing of AS, the current ASDoc tools can't generate the usual ASDoc pages, so we are currently using a FlexJS example app to display ASDoc. It is a bit ugly right now and volunteers are welcome

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

I have a subset of Mustella working on both platforms in the BasicTests that run from the checkintests target in the Ant build. There is a writeup on Mustella in the wiki https://cwiki.apache.org/confluence/display/FLEX/Mustella+Overview. I haven't gone through it to see how much does or doesn't

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

Interesting. IJ goes down a completely different code path than FB. Something to keep in mind for the future. Thanks for figuring it out. -Alex On 7/6/17, 2:15 PM, "Josh Tynjala" wrote: >Unfortunately, there is no workaround for 0.8.0. Even if we try to use

Re: [FlexJS][VS Code] dual issues

> The js-output-type, library-path and external-library-path options are probably not needed I would get rid of -js-output-type. I assume that -targets takes precedence, but just to be safe, you shouldn't use both. -js-output-type is necessary for 0.7.0, but switch entirely to -targets with

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

Unfortunately, there is no workaround for 0.8.0. Even if we try to use -js-output-type instead, it tries to call a constructor that simply doesn't exist anymore. We didn't get compiler errors to tell us that this had broken because it it used reflection to find that constructor. - Josh On Jul 6,

[FlexJS][VS Code] dual issues

Since updating to “dual”has been reporting lots of errors. When I build, both the debug and release builds build correctly, but the PROBLEMS window and the live code hinting report lots of (non) issues. I’m not sure what the source of the errors are, but here are the details: I’ve tried a few

FlexJS Tests (was Re: [FlexJS] technical debt)

Where are the instructions on how to use it? If I know how to write tests, I’d be much better about doing so… > On Jul 6, 2017, at 11:53 PM, Alex Harui wrote: > > I have put in place a test infrastructure

Re: [FlexJS] technical debt

Yup. For example: I’d say an extremely large percentage of the “technical debt” in TLF is there for a reason. Do NOT “fix” any of that… > On Jul 6, 2017, at 11:53 PM, Alex Harui wrote: > > But IMO, for right now, if "it ain't broke, don't fix it".

Re: [FlexJS] technical debt

Hi Dave, There are almost no automated tests for the FlexJS framework. I have put in place a test infrastructure, but nobody has volunteered more tests. So no test would have caught the "==" to "===" issues, and no tests are going to catch issues arising from trying to clean up technical debt,

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

Thanks for noticing that. So does that mean a workaround for 0.8.0 is to define in additional compiler options: -js-output-type=FLEXJS -Alex On 7/6/17, 11:46 AM, "Josh Tynjala" wrote: >Okay, I made a commit that seems to get things working in IntelliJ IDEA >again.

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Thanks, Yishay. I will look into these in the API reference. Just created my first panel. Somehow I only see the Apache Flex 4.14.0 API reference in http://people.apache.org/~pent/asdoc-flexjs/ when I search for FlexJS API reference. Hope this is correct page. Regards, Allen -Original

Re: [FlexJS] technical debt

Hi Alex, > On Jul 6, 2017, at 10:36 AM, Alex Harui wrote: > > IMO, even more important than technical debt is a test system and tests to > make sure any changes don't break anything. That would include any changes to fix “technical debt”. > > I could be wrong, but

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

Josh, That's great news! :) I will try it out once falcon build on server. It look like confluence need to be updated as well. Point 9 seems to be out of date in the instruction. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

I don't have code to share but as general pointers: - use Panel instead of TitleWindow - use UIUtils instead of PopupManager - user HContainer instead of HBox Hope this helps. -- View this message in context:

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

Okay, I made a commit that seems to get things working in IntelliJ IDEA again. It looks like MxmlJSC and CompJSC in flex-compiler-oem.jar no longer need to create the backend manually, and MXMLJSC or COMPJSC can figure out what to do automatically based on the value of -targets now. I was able to

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

By the way, I'd like to know what kind of extra problems you are seeing (in another thread please) because that's not an issue I've encountered with VSCode. - Josh On Thu, Jul 6, 2017 at 11:16 AM, Harbs wrote: > VS Code is reporting all kinds of issues that are not

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

The problem looks to be related to this line: compiler = COMPILER.getDeclaredConstructor(IBackend.class).newInstance(backend); It's looking for a constructor on MXMLJSC (not to be confused with MxmlJSC) that takes an IBackend as a parameter. There is no longer a constructor like that in 0.8.0.

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

The issue with IntelliJ IDEA on seems to be related to flex-compiler-oem.jar, which VSCode doesn't use at all. - Josh On Thu, Jul 6, 2017 at 11:16 AM, Harbs wrote: > VS Code is reporting all kinds of issues that are not problems since the > switch to dual. Maybe that’s

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

VS Code is reporting all kinds of issues that are not problems since the switch to dual. Maybe that’s related as well? > On Jul 6, 2017, at 9:06 PM, Josh Tynjala wrote: > > I don't see why -targets wouldn't work when it works elsewhere, but I just > tried

Re: [FlexJS] technical debt

A large percentage of the complaints are inaccurate. The reason the technical debt increased is largely because of the new TLF code. Who made these rules and how do we change them? We can make it look much better by just changing some of the rules… Harbs > On Jul 6, 2017, at 2:24 AM, Justin

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

I don't see why -targets wouldn't work when it works elsewhere, but I just tried -compiler.targets too, and that also failed. Looking at the source code for flex2.tools.MxmlJSC, I see that it's still checking for the -js-output-type option, and it isn't trying to find -targets at all. Did you

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi PKumar, Please share with me the examples on title windows, grid, panel and other controls; I need to convert them from a Flex 3 project built on Flash Builder 3.6 to HTML+JS built with FlexJS 0.8.0 in my project. Regards, Allen -Original Message- From: PKumar

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

What does IJ do with additional compiler options? Does it put them in one of the .xml files? I can see from the original post that IJ seems to be using: -load-config=/Users/joshtynjala/Library/Caches/IntelliJIdea2017.1/compile-s

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi Yishay, After adding these to css, it works now. Thanks a lot! Best Regards, Allen -Original Message- From: yishayw [mailto:yishayj...@hotmail.com] Sent: Thursday, July 06, 2017 1:15 PM To: dev@flex.apache.org Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to

Re: [FlexJS] technical debt

IMO, even more important than technical debt is a test system and tests to make sure any changes don't break anything. I could be wrong, but I think our customers would rather have us spend our time and energy on missing features like AMF right now. My 2 cents, -Alex From: Dave Fisher

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

allenyyang wrote > These changes allowed me to build demo_for_presentation. And I now can run > it by double-clicking index.html in both bin/js-debug and bin/js-release > folders. > But I am not sure that it runs correctly because the screen display always > look like the following: > > boring >

Re: [FlexJS] technical debt

Hi Justin, (I missed your double reply until I reviewed the thread before sending. This caused me to remove part of this email.) I looked at some of the major and minor Code Smells. I think that rather than accepting the ActionScript conventions that Sonar provides that most of these can be

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

I tried specifying -targets=JSFlex in the additional compiler options, but it made no difference. - Josh On Thu, Jul 6, 2017 at 9:09 AM, Alex Harui wrote: > I suspect the issue is that IJ dictates all of the settings and doesn't > use flex-config.xml, and thus no

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

I suspect the issue is that IJ dictates all of the settings and doesn't use flex-config.xml, and thus no targets are being specified. Is there a way to specify compiler.targets in additional compiler options in IJ? There is in FB. -Alex On 7/6/17, 8:34 AM, "Josh Tynjala"

Re: [FlexJS] Mobile Depends on Flash 11.4?

I have also gotten this error before. I remember that I had to manually set playerglobal.version (and maybe also playerglobal.swfversion) in my env.properties to get the build to pass. - Josh On Tue, Jul 4, 2017 at 12:14 AM, yishayw wrote: > I was having a problem

Re: 4.16.0 Install issues

Hi Nick, As for the font encoding we had discussion about that at ApacheCon [1] and I raised jira [2] [1] http://apache-flex-development.247.n4.nabble.com/ApacheCon-FlexJS-Summit-FlexJS-1-0-Discussion-Round-Summary-td61700.html [2] https://issues.apache.org/jira/browse/FLEX-35315 Piotr

Re: [FlexJS] Mobile Depends on Flash 11.4?

That should be recent enough. I can't figure out why you got that error if it used that airglobal.swc. Maybe there is a clue in the console output. -Alex On 7/5/17, 10:31 AM, "yishayw" wrote: >My AIR_HOME goes to my nightly installation which has Adobe AIR 23.0 SDK.

Re: 4.16.0 Install issues

I'm not spending any time on the installer other than occasionally pondering if there is some other workaround we could deploy. I'm waiting on Adobe to put out a 64-bit native installer. IMO, that's the least work on our part, but not sure when Adobe will push that out. The SSL errors from

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

While full support for FlexJS in IntelliJ IDEA would be great, I think it's critical that we fix this issue to at least get back to the baseline we had in 0.7. A FlexJS project required a little bit of extra configuration with 0.7, but at least we could get the compiler to work inside IntellIJ.

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi Allen, You can try other examples like FlexJSStore in the FlexJS SDK's examples folder as the source for a FlexJS project in Flash Builder. Or, create a new Flex/FlexJS project and copy the source from demo_for_presentation. HTH, -Alex On 7/6/17, 6:50 AM, "Allen YANG"

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

I will check the example shared. But if need more examples on title window, grid, panel , list and other controls. Just let me know I will share with you on GitHub. On 06-Jul-2017 7:21 PM, "allenyyang [via Apache Flex Development]" < ml+s247n62863...@n4.nabble.com> wrote: > Hi PKumar, > >

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi PKumar, You are correct that I don't need to have Maven or Ant installed if I want to just use Flash Builder as the IDE. was able to use Flash Builder 4.7 and FlexJS to build and run the examples in the wiki successfully. I just could not use FB to build Yishay's demo_for_presentation

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

As I remember Chris get to the bottom of it and resolved it. Unfortunately after contacting with Jetbrains they refuse accept pull request with fix and Chris dropped it. [1] I was thinking even then that if someone could fix it and store version of plugin somewhere with fix it would be also HUGE,

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi Allen, It looks like you’ve got VS Code and Maven working, so please don’t waste time on this unless you want to work on Flash Builder instead. VS Code and Maven are actually preferred by some developers over FB and Ant. PKumar is correct that you shouldn’t really need Ant if you’re using

Re: [FlexJS] technical debt

Hi, Dave I assume the case statement issue you referring to is is the last one in this list [1]. It not a bug but style wise it’s a little odd and probably should still be fixed. Thanks, Justin 1.

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

If you want to use FlexJS with Flash Builder 4.7 then no need to install Ant and maven. just download latest version of FlexJs via SDK installer and add new FlexJS SDK under Flash Buildrler4.7 as you add regular flex SDK. After SDK setup . You need to import runtime command into Flash Builder

Re: [FlexJS] technical debt

Hi, > You cut my previous reply which means I need to repeat. Why is that? All modern email clients support threaded messages. so people should be able to see my email and your original in context. When replying repeating the whole email is generally frowned upon. Sorry if I cut too much out

Re: [FlexJS] technical debt

Hi Justin, You cut my previous reply which means I need to repeat. You called out changes since 0.8. And I only looked at the change since in Sonar. I took about 5 minutes, a very superficial check. Lots of TD should be explored carefully hopefully by the original developer. I agree with the