Re: 4.16.0 Install issues

2017-07-06 Thread Alex Harui
Cool!  I missed seeing this JIRA.

I took a quick look and didn't see spline conversion handling between TTF
and CFF.  I think it may not handle specifying a TTF file for
embedAsCFF=true and vice versa.  But maybe we can live without it.

Any volunteers to take this on?

-Alex

On 7/6/17, 10:01 PM, "Olaf Krueger"  wrote:

>Nicholas Kwiatkowski-2 wrote
>>  - Re-creating Fontkit.  Chris Dutz said he might be able to work on it,
>> but I havent seen anything else to that affect.
>
>At ApacheCon somebody found a lib that maybe contains a working FontKit
>port.
>Piotr created a JIRA that contains the link [1]
>
>HTH,
>Olaf 
>
>[1]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues
>.apache.org%2Fjira%2Fbrowse%2FFLEX-35315=02%7C01%7C%7C8b8ed67825f84e5
>d91a008d4c4f7c56b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63635001583
>1422210=ps7%2Fd3pmBt%2FY2pFquS9vvO5Dj2rJ8EohmcV7hfgU9F8%3D=
>0
>
>
>
>
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.247.n4.nabble.com%2F4-16-0-Install-issues-tp62855p62919.
>html=02%7C01%7C%7C8b8ed67825f84e5d91a008d4c4f7c56b%7Cfa7b1b5a7b344387
>94aed2c178decee1%7C0%7C0%7C636350015831422210=qtIXbmeRpuwC3ICJcyKsmG
>V%2FQ%2B%2FhG6jTxWBU1CO%2BJ4c%3D=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.



Re: 4.16.0 Install issues

2017-07-06 Thread Alex Harui
Maybe I wasn't clear enough:

I don't think the version of Ant will affect the SSL issues.  The SSL
issues should be solvable via the JCE upgrade:

http://stackoverflow.com/questions/38203971/javax-net-ssl-sslhandshakeexcep
tion-received-fatal-alert-handshake-failure/38264878#38264878


I'm not sure if there are issues about what Java version is used by Ant.

The logic around Ant installing Mac artifacts on Windows should operate
differently with recent Ant versions.  Did that problem go away with your
Ant upgrade?

-Alex

On 7/6/17, 7:43 PM, "Nicholas Kwiatkowski" 
wrote:

>I remember reading about needing the latest ANT, so I installed 1.10.1 and
>1.9.9 on my Windows 10 machine with the latest Java 8 install and still
>had
>the SSL errors.
>
>I just read through the threads where where there was a discussion about
>it.  There were three things talked about :
> - Having Adobe move the files to another provider (not going to happen)
> - Grabbing the entire Flex 4.6 SDK and pulling the files out of there
>(eww)
> - Re-creating Fontkit.  Chris Dutz said he might be able to work on it,
>but I havent seen anything else to that affect.
>
>-Nick
>
>
>On Thu, Jul 6, 2017 at 11:44 AM, Alex Harui 
>wrote:
>
>> I'm not spending any time on the installer other than occasionally
>> pondering if there is some other workaround we could deploy.  I'm
>>waiting
>> on Adobe to put out a 64-bit native installer.  IMO, that's the least
>>work
>> on our part, but not sure when Adobe will push that out.
>>
>> The SSL errors from SourceForge have a workaround that's been posted a
>>few
>> times.  The correct solution is to write our own font encoding library.
>> Volunteers are needed.
>>
>> I thought Ant on Windows would work if you used a recent version of Ant.
>>
>> Thanks,
>> -Alex
>>
>> On 7/5/17, 6:13 PM, "Nicholas Kwiatkowski"  wrote:
>>
>> >Is anybody actually addressing the issues people have been reporting
>>about
>> >the installer and/or ANT script for Flex SDK 4.16.0?
>> >
>> >Right now I see two major issues that are preventing even people who
>>are
>> >familiar with the SDK from doing installs :
>> >
>> > - In the installer, selecting AIR 25.0 gives users a non-descript
>>"error
>> >1000".  This is due toe the md5 checking in the installer running out
>>of
>> >memory
>> > - Trying to install via ANT is also broken under Windows (any version
>>of
>> >AIR SDK).  As packaged, it always errors because it tries to install
>>the
>> >MacOS AIR SDK.  Additionally, the optional components that are
>>currently
>> >hosted on sourceforge fail to download due to some SSL errors (I've
>>tested
>> >this with the latest java sdk and ANT build).
>> >
>> >The AIR installer issue will require us to rip-and-replace the md5
>> >calculation functions.  I've started looking at it, but I don't think
>>it
>> >will be an easy feat.
>> >Fixing the ANT script for Windows trying to install the mac air dmg is
>>an
>> >easy fix (but it will require us to do a dot release to push it out)
>> >The SSL errors are because sourceforge is using SANs on their SSL
>>certs,
>> >and the current versions of ANT don't know how to read them to validate
>> >them.  This may be out of our control.  Anybody know if we can convince
>> >Adobe to either donate those chunks of code or at least to move them
>>to a
>> >different host?  It looks like the code involved is OSMF, AFE, AGLJ,
>> >rideau and Flex-Fontkit.  The alternative to a different host is for
>>us to
>> >ignore SSL errors, but that could be potentially dangerous.
>> >
>> >If nobody is working on these, I can start to take a crack at them, but
>> >honestly, the installer is extremely fragile at this point and I'm not
>> >looking forward to even trying to figure out what is going on in there
>> >again.
>> >
>> >-Nick
>>
>>



Re: 4.16.0 Install issues

2017-07-06 Thread Olaf Krueger
Nicholas Kwiatkowski-2 wrote
>  - Re-creating Fontkit.  Chris Dutz said he might be able to work on it,
> but I havent seen anything else to that affect. 

At ApacheCon somebody found a lib that maybe contains a working FontKit
port.
Piotr created a JIRA that contains the link [1]

HTH,
Olaf 

[1]https://issues.apache.org/jira/browse/FLEX-35315




--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/4-16-0-Install-issues-tp62855p62919.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: 4.16.0 Install issues

2017-07-06 Thread Nicholas Kwiatkowski
I remember reading about needing the latest ANT, so I installed 1.10.1 and
1.9.9 on my Windows 10 machine with the latest Java 8 install and still had
the SSL errors.

I just read through the threads where where there was a discussion about
it.  There were three things talked about :
 - Having Adobe move the files to another provider (not going to happen)
 - Grabbing the entire Flex 4.6 SDK and pulling the files out of there (eww)
 - Re-creating Fontkit.  Chris Dutz said he might be able to work on it,
but I havent seen anything else to that affect.

-Nick


On Thu, Jul 6, 2017 at 11:44 AM, Alex Harui 
wrote:

> I'm not spending any time on the installer other than occasionally
> pondering if there is some other workaround we could deploy.  I'm waiting
> on Adobe to put out a 64-bit native installer.  IMO, that's the least work
> on our part, but not sure when Adobe will push that out.
>
> The SSL errors from SourceForge have a workaround that's been posted a few
> times.  The correct solution is to write our own font encoding library.
> Volunteers are needed.
>
> I thought Ant on Windows would work if you used a recent version of Ant.
>
> Thanks,
> -Alex
>
> On 7/5/17, 6:13 PM, "Nicholas Kwiatkowski"  wrote:
>
> >Is anybody actually addressing the issues people have been reporting about
> >the installer and/or ANT script for Flex SDK 4.16.0?
> >
> >Right now I see two major issues that are preventing even people who are
> >familiar with the SDK from doing installs :
> >
> > - In the installer, selecting AIR 25.0 gives users a non-descript "error
> >1000".  This is due toe the md5 checking in the installer running out of
> >memory
> > - Trying to install via ANT is also broken under Windows (any version of
> >AIR SDK).  As packaged, it always errors because it tries to install the
> >MacOS AIR SDK.  Additionally, the optional components that are currently
> >hosted on sourceforge fail to download due to some SSL errors (I've tested
> >this with the latest java sdk and ANT build).
> >
> >The AIR installer issue will require us to rip-and-replace the md5
> >calculation functions.  I've started looking at it, but I don't think it
> >will be an easy feat.
> >Fixing the ANT script for Windows trying to install the mac air dmg is an
> >easy fix (but it will require us to do a dot release to push it out)
> >The SSL errors are because sourceforge is using SANs on their SSL certs,
> >and the current versions of ANT don't know how to read them to validate
> >them.  This may be out of our control.  Anybody know if we can convince
> >Adobe to either donate those chunks of code or at least to move them to a
> >different host?  It looks like the code involved is OSMF, AFE, AGLJ,
> >rideau and Flex-Fontkit.  The alternative to a different host is for us to
> >ignore SSL errors, but that could be potentially dangerous.
> >
> >If nobody is working on these, I can start to take a crack at them, but
> >honestly, the installer is extremely fragile at this point and I'm not
> >looking forward to even trying to figure out what is going on in there
> >again.
> >
> >-Nick
>
>


Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean
Hi,

> Think of it like this if someone makes a commit you would not revert without 
> giving them an opportunity to do it first.
> 
> So the suggestion from me is get approval for anything complex. It is the 
> social thing to do.

!00% agree.

> I see you asked directly about a standard else thread.

Yep let's see what other people think about the idea.

Thanks,
Justin

Re: [FlexJS] technical debt

2017-07-06 Thread Dave Fisher


Sent from my iPhone

> On Jul 6, 2017, at 5:22 PM, Justin Mclean  wrote:
> 
> Hi,
> 
>> If you make a change to fix technical debt then you should also assure that 
>> both existing tests pass and if no tests exist then tests are added and 
>> proper.
> 
> I’m all for more tests. However should this apply to any changes anyone makes 
> for any reason OR only changes I make?

It applies to making other than the most minimal changes due to a sonar report. 
Obviously trivial changes like the ; but not the === require discussion.

Think of it like this if someone makes a commit you would not revert without 
giving them an opportunity to do it first.

So the suggestion from me is get approval for anything complex. It is the 
social thing to do.

> 
> I asking because taken literally this could possible end up being a situation 
> were any changes I make are vetoed due to low test coverage but other people 
> can make changes and ignore test coverage.

I see you asked directly about a standard else thread.

Regards,
Dave


> 
> Thanks,
> Justin



Re: FlexJS Tests (was Re: [FlexJS] technical debt)

2017-07-06 Thread justin
Hi,

What do people feel about setting a code and branch coverage on all checkins? 
Say 80% coverage of changes made?

Thanks,
Justin

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread Allen YANG
Hi Alex,
I googled FlexJS API reference and found the link: 
http://people.apache.org/~pent/asdoc-flexjs/ Thanks for pointing out that ASDOC 
is probably out of date.
I built examples/flexjs/ASDoc; the build was successful, it created in the 
target folder an index.html,  SummaryRenderer.js and SummaryRenderer.as.map.  
How do I run this? If I just run index.html file the browser shows nothing.  
Sorry, this may be a dumb question.
Regards,
Allen


-Original Message-
From: Alex Harui [mailto:aha...@adobe.com.INVALID]
Sent: Thursday, July 06, 2017 6:44 PM
To: dev@flex.apache.org
Subject: Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi Allen,

I just updated the FlexJS ASDoc link from our website.  Because FlexJS does 
some enhanced parsing of AS, the current ASDoc tools can't generate the usual 
ASDoc pages, so we are currently using a FlexJS example app to display ASDoc.  
It is a bit ugly right now and volunteers are welcome to offer improvements.  
The source code is in examples/flexjs/ASDoc.

Where did you find that link to people.apache.org?   That ASDoc is
probably out of date.

Thanks,
-Alex

On 7/6/17, 12:25 PM, "Allen YANG"  wrote:

>Thanks, Yishay. I will look into these in the API reference.  Just
>created my first panel.
>Somehow I only see the Apache Flex 4.14.0 API reference in
>https://na01.safelinks.protection.outlook.com/?url=http:%2F%2Fpeople.ap
>ach
>e.org%2F~pent%2Fasdoc-flexjs%2F=02%7C01%7C%7Cea5814849fde49d0e6390
>8d4
>c4a4ce1e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63634965948824645
>7
>data=Pfq4vVvp%2FmUtR9mOfRvWI3xmugKCJxlDH%2FDm8vwI%2Fxc%3D=0
>when I search for FlexJS API reference. Hope this is correct page.
>Regards,
>Allen
>
>
>-Original Message-
>From: yishayw [mailto:yishayj...@hotmail.com]
>Sent: Thursday, July 06, 2017 2:32 PM
>To: dev@flex.apache.org
>Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to
>HTML+JS
>
>I don't have code to share but as general pointers:
>
>- use Panel instead of TitleWindow
>- use UIUtils instead of PopupManager
>- user HContainer instead of HBox
>
>Hope this helps.
>
>
>
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-
>fle
>x-development.247.n4.nabble.com%2FFlexJS-question-about-porting-an-
>Ado
>be-Flex-3-project-to-HTML-JS-tp62698p62886.html=02%7C01%7C%7Cea581
>484
>9fde49d0e63908d4c4a4ce1e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6
>363
>49659488246457=M83aDk0hR4a8n84eglO3nQuehM4IHXDol46FSVoqwBI%3D
>erv
>ed=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
>
>
>Ce message, ainsi que tous les fichiers joints à ce message, peuvent
>contenir des informations sensibles et/ ou confidentielles ne devant
>pas être divulguées. Si vous n'êtes pas le destinataire de ce message
>(ou que vous recevez ce message par erreur), nous vous remercions de le
>notifier immédiatement à son expéditeur, et de détruire ce message.
>Toute copie, divulgation, modification, utilisation ou diffusion, non
>autorisée, directe ou indirecte, de tout ou partie de ce message, est
>strictement interdite.
>
>
>This e-mail, and any document attached hereby, may contain confidential
>and/or privileged information. If you are not the intended recipient
>(or have received this e-mail in error) please notify the sender
>immediately and destroy this e-mail. Any unauthorized, direct or
>indirect, copying, disclosure, distribution or other use of the
>material or parts thereof is strictly forbidden.




Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir 
des informations sensibles et/ ou confidentielles ne devant pas être 
divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous 
recevez ce message par erreur), nous vous remercions de le notifier 
immédiatement à son expéditeur, et de détruire ce message. Toute copie, 
divulgation, modification, utilisation ou diffusion, non autorisée, directe ou 
indirecte, de tout ou partie de ce message, est strictement interdite.


This e-mail, and any document attached hereby, may contain confidential and/or 
privileged information. If you are not the intended recipient (or have received 
this e-mail in error) please notify the sender immediately and destroy this 
e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution 
or other use of the material or parts thereof is strictly forbidden.


Re: [FlexJS] technical debt

2017-07-06 Thread Greg Dove
>> Well Object is always THE base class. It may not be known what the
actual base class should be and it is certainly not flexible to always
create a base class just to have a one to satisfy the rule.

>Nor would I suggest that. There are some cases where creating a new class
with properties is going to make sense, there other in where having the
flexibility of Object make sense. You may not be aware there a big
difference between Object and something that extends Object. Objects’s are
dynamic and properties (and methods) can be added at runtime but this comes
at a performance cost. Class that extend Object are not dynamic and you
can’t do this and as a result are faster.

>> Justin - If you have clear performance results then please document them
in the wiki.

>Other people have already researched this and it’s well known AFAIK. For
example here's an old article by Alex [1] where for accessing properties
there’s a 20x performance increase. Obviously there’s a little more to it
than just that but more recent article also have similar results. Object
can be useful but it does come at a performance cost.

I'm not sure if performance concern is a priority here or not, because
although it is important in AVM, it may not be relevant in the browser
where things are untyped in any case. I vaguely recall reading something in
another thread recently that left me with the impression that javascript
output was the priority (for performance, I think) and that the primary
objectives for swf were to achieve compatibility. I think this was in
relation to some view or layout code, but I do wonder if it is a general
'guidance' that would be relevant for things like this. If it is, it would
be good to document that as an explicit piece of guidance (if it is not
already stated somewhere).



On Fri, Jul 7, 2017 at 12:19 PM, Justin Mclean 
wrote:

> Hi,
>
> > That is the concern, but it may be that the developer was making a
> speculative change. If I were cleaning then I would do one of two actions.
> >
> > (a) Review the history of that change and see if the associated comments
> provide a reason.
> > (b) Ask the developer who made the change.
>
> Both are courses of action that I would take assuming the info in the VC
> comments and/or the developer is still about. Sometimes that may not be the
> case.
>
> > Well Object is always THE base class. It may not be known what the
> actual base class should be and it is certainly not flexible to always
> create a base class just to have a one to satisfy the rule.
>
> Nor would I suggest that. There are some cases where creating a new class
> with properties is going to make sense, there other in where having the
> flexibility of Object make sense. You may not be aware there a big
> difference between Object and something that extends Object. Objects’s are
> dynamic and properties (and methods) can be added at runtime but this comes
> at a performance cost. Class that extend Object are not dynamic and you
> can’t do this and as a result are faster.
>
> > Justin - If you have clear performance results then please document them
> in the wiki.
>
> Other people have already researched this and it’s well known AFAIK. For
> example here's an old article by Alex [1] where for accessing properties
> there’s a 20x performance increase. Obviously there’s a little more to it
> than just that but more recent article also have similar results. Object
> can be useful but it does come at a performance cost.
>
> > Thanks. Do you know how to deactivate useless rules?
>
> Yes.
>
> Thanks,
> Justin
>
> 1. http://blogs.adobe.com/aharui/2007/10/actionscript_
> readwrite_perform_1.html


Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean
Hi,

> If you make a change to fix technical debt then you should also assure that 
> both existing tests pass and if no tests exist then tests are added and 
> proper.

I’m all for more tests. However should this apply to any changes anyone makes 
for any reason OR only changes I make?

I asking because taken literally this could possible end up being a situation 
were any changes I make are vetoed due to low test coverage but other people 
can make changes and ignore test coverage.

Thanks,
Justin

Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean
Hi,

> That is the concern, but it may be that the developer was making a 
> speculative change. If I were cleaning then I would do one of two actions.
> 
> (a) Review the history of that change and see if the associated comments 
> provide a reason.
> (b) Ask the developer who made the change.

Both are courses of action that I would take assuming the info in the VC 
comments and/or the developer is still about. Sometimes that may not be the 
case.

> Well Object is always THE base class. It may not be known what the actual 
> base class should be and it is certainly not flexible to always create a base 
> class just to have a one to satisfy the rule.

Nor would I suggest that. There are some cases where creating a new class with 
properties is going to make sense, there other in where having the flexibility 
of Object make sense. You may not be aware there a big difference between 
Object and something that extends Object. Objects’s are dynamic and properties 
(and methods) can be added at runtime but this comes at a performance cost. 
Class that extend Object are not dynamic and you can’t do this and as a result 
are faster.

> Justin - If you have clear performance results then please document them in 
> the wiki.

Other people have already researched this and it’s well known AFAIK. For 
example here's an old article by Alex [1] where for accessing properties 
there’s a 20x performance increase. Obviously there’s a little more to it than 
just that but more recent article also have similar results. Object can be 
useful but it does come at a performance cost.

> Thanks. Do you know how to deactivate useless rules?

Yes.

Thanks,
Justin

1. http://blogs.adobe.com/aharui/2007/10/actionscript_readwrite_perform_1.html

Re: [FlexJS][VS Code] dual issues

2017-07-06 Thread Josh Tynjala
The AS/MXML code intelligence in VSCode instantiates certain classes from
the compiler to get the data it needs. Previously, I was instantiating a
FlexProject no matter which targets were specified. Now, I instantiate a
FlexJSProject when I'm sure that JS should have a higher priority than SWF
(based on the value of -targets). This seems to be enough to get the
compiler to switch from Flash Player APIs to JS APIs in the data that it
provides, and i can see that it switches COMPILE::JS to true and COMPILE::
SWF to false.

With this change that I just made, I suspect that if we merged the pairs of
SWCs into one, VSCode might just work with no changes (except to tell it to
use the newer compiler).

- Josh


On Jul 6, 2017 4:23 PM, "Alex Harui"  wrote:

I agree, it will be great to get JS API code-intelligence.

Just out of curiosity, what did you have to change?  One work item for the
future is to merge the "JS" SWC into the "SWF" SWC so there is only one
SWC per library instead of the current pair like Core.SWC and CoreJS.swc.
I'm trying to assess the impact of doing so.  We can certainly teach the
compiler to pick different classes based on the current -target, but right
now for FB, all it knows is that one set of SWCs or the other is on the
library path.  If we merge the SWCS, there is no other way to tell the
compiler which APIs to use by default, and I'm not sure I can control that
from outside FB.

Maybe just the Maven artifacts will be merged and we'll keep the pairs of
SWCs for IDEs.

Thoughts?
-Alex

On 7/6/17, 4:12 PM, "Josh Tynjala"  wrote:

>Okay, I figured out how to make VSCode switch to JS APIs instead of SWF
>APIs for completion and things. In the next version of the extension, when
>the targets compiler option is specified in asconfig.json, and the first
>value isn't "SWF", the extension will offer JS APIs. That includes giving
>you access to native browser APIs instead of Flash Player APIs. That's
>going to be a really nice change, I think. Thanks for pointing out this
>issue!
>
>- Josh
>
>On Thu, Jul 6, 2017 at 2:35 PM, Josh Tynjala 
>wrote:
>
>> > The js-output-type, library-path and external-library-path options are
>> probably not needed
>>
>> I would get rid of -js-output-type. I assume that -targets takes
>> precedence, but just to be safe, you shouldn't use both.
>>-js-output-type is
>> necessary for 0.7.0, but switch entirely to -targets with 0.8.0.
>>
>> > It would be nice to have full support for the new compiler options
>>
>> html-template, html-output-filename, js-compiler-option,
>> js-external-library-path, js-library-path, swf-external-library-path,
>> swf-library-path, and remove-circulars should all work in the
>> compilerOptions field if you're using the latest vscode-nextgenas 0.4.4
>>and
>> asconfigc 0.5.1. I just updated asconfigc to support these options last
>> week, and I haven't made an official announcement yet, so you might have
>> missed that one.
>>
>> I think there may be one or two you'll still need to put into
>> additionalOptions, but you should be able to switch over most of them.
>>
>> > 1. I’m getting “problems” even for files which are not used in my
>> project and are not open.
>>
>> This is something I'm aware of in VSCode. The compiler seems to greedily
>> load everything that exists in a source path, even if you don't actually
>> use it. Personally I like this, but even if I were to make it an option
>> somehow, I'm not aware of a way to stop the compiler from working that
>>way
>> either.
>>
>> > 2. I’m getting lots of errors which are specific to SWF-only output:
>>
>> I just glanced through the part of VSCode that passes options to the
>> compiler for code intelligence (different from the way that asconfigc
>>runs
>> the compiler to build), and I don't think I'm actually using the value
>>of
>> -targets. It's probably defaulting to SWF. I'll play around with that to
>> see if I can improve things when -targets is specifically JSFlex.
>>
>> >   a. I’m not getting JS specific classes recognized.
>>
>> Just to be clear, are you referring to DOM classes like
>>HTMLButtonElement
>> and other browser APIs here? I just want to be sure so that I test the
>> right thing when I make changes.
>>
>> - Josh
>>
>> On Thu, Jul 6, 2017 at 2:16 PM, Harbs  wrote:
>>
>>> Since updating to “dual”has been reporting lots of errors. When I
>>>build,
>>> both the debug and release builds build correctly, but the PROBLEMS
>>>window
>>> and the live code hinting report lots of (non) issues. I’m not sure
>>>what
>>> the source of the errors are, but here are the details:
>>>
>>> I’ve tried a few variations of the asconfig file, but here’s what I
>>> currently have:
>>> {
>>> "config": "flex",
>>> "compilerOptions": {
>>> "debug": true,
>>> "js-output-type": "flexjs",
>>> "targets": ["JSFlex"],
>>> "source-map": false,
>>> 

Re: [FlexJS] technical debt

2017-07-06 Thread Dave Fisher

> On Jul 6, 2017, at 4:22 PM, Justin Mclean  wrote:
> 
> Hi,
> 
>> - Do we care about code being commented out? I think not.
> 
> If we know why it was commented out sure. There’s always the concern is this 
> code possibly needed or not?

That is the concern, but it may be that the developer was making a speculative 
change. If I were cleaning then I would do one of two actions.

(a) Review the history of that change and see if the associated comments 
provide a reason.
(b) Ask the developer who made the change.

> 
>> - Does a semicolon matter?
> 
> It marked as a minor issue but it can cause issues when JS code is optimised 
> and/or minified. It’s easy and safe to fix.

While very likely safe I think that a question needs to be asked.

> 
>> - Is “:Object” really a critical issue?
> 
> Critical no (and it's not marked as such) and in some cases it’s quite 
> useful. Like all rules there are exceptions. Using a class with named 
> properties gives you type safety and performance benefits.

Well Object is always THE base class. It may not be known what the actual base 
class should be and it is certainly not flexible to always create a base class 
just to have a one to satisfy the rule. I think again it is a question that I 
think was already answered by Alex. IIRC he did not think these warranted a 
different approach.


Justin - If you have clear performance results then please document them in the 
wiki.

> 
>> - Is refactoring “complexity” really a huge problem
> 
> If we want easy to test/easy to maintain code then it can be yes.

This is a question of long term maintenance. My experience in an Agile 
environment is that these changes must be planned otherwise they become break 
fixes. Refactoring must be very carefully done. The author may have this 
complexity there for an unmentioned reason.

> 
>> - This one: Replace == with === : has been discussed and I think your making 
>> the change suggested broke things.
> 
> It didn’t break things in any major way, the tests passed, examples worked 
> and the application I’m working on worked. I believe there was one instance 
> that caused an issue for Harbs.

OK. Well I recall that and I also recall several people doubting that the 
change was needed or necessary. Perhaps both sides could be put on a wiki page.

> 
> There are some other useful rules in there I’ll document them.

Thanks. Do you know how to deactivate useless rules?

> 
>> Probably the best approach would be to collect these into a wiki page and 
>> then determine what conventions developers consider important. Once that is 
>> done change the sonar configuration and show true technical debt. I think 
>> that this is much less risky to the project and much less distraction to the 
>> team.
> 
> Sure I’ll go with that approach.

Wonderful.

Regards,
Dave

> 
> Thanks,
> Justin



signature.asc
Description: Message signed with OpenPGP


Re: [FlexJS] technical debt

2017-07-06 Thread Dave Fisher

> On Jul 6, 2017, at 4:30 PM, Justin Mclean  wrote:
> 
> Hi,
> 
>>> IMO, even more important than technical debt is a test system and tests to 
>>> make sure any changes don't break anything.
>> 
>> That would include any changes to fix “technical debt”.
> 
> Or if fact any changes right?

If you make a change to fix technical debt then you should also assure that 
both existing tests pass and if no tests exist then tests are added and proper.

As Alex mentions various integration and automation (Selenium) tests also pass. 
In addition there is a.bonus if both Flex and FlexJS are covered.

Regards,
Dave


signature.asc
Description: Message signed with OpenPGP


Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean
Hi,

>> IMO, even more important than technical debt is a test system and tests to 
>> make sure any changes don't break anything.
> 
> That would include any changes to fix “technical debt”.

Or if fact any changes right? 

Thanks,
Justin

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-07-06 Thread Justin Mclean
Hi,

> I just tried swapping SimpleCSSValuesImpl for AllCSSValuesImpl in the
> develop branch in examples/flexjs/DataBindingExample and it worked for me.
> 
> Does it still not work for you?

It still does not work for me.

Justin


Re: FlexJS Tests (was Re: [FlexJS] technical debt)

2017-07-06 Thread Justin Mclean
Hi,

BTW Sonar can give you useful test coverage statistics [1] and will even show 
line by line where a test is covered by tests [2] look at the red and green 
bars in the gutter.

Thanks,
Justin

1. 
https://builds.apache.org/analysis/component_measures/domain/Coverage?id=org.apache.flex.flexjs.compiler%3Aflexjs-compiler-parent
2. 
https://builds.apache.org/analysis/component_measures/metric/new_overall_line_coverage/list?id=org.apache.flex.flexjs.compiler%3Aflexjs-compiler-parent

Re: [FlexJS][VS Code] dual issues

2017-07-06 Thread Alex Harui
I agree, it will be great to get JS API code-intelligence.

Just out of curiosity, what did you have to change?  One work item for the
future is to merge the "JS" SWC into the "SWF" SWC so there is only one
SWC per library instead of the current pair like Core.SWC and CoreJS.swc.
I'm trying to assess the impact of doing so.  We can certainly teach the
compiler to pick different classes based on the current -target, but right
now for FB, all it knows is that one set of SWCs or the other is on the
library path.  If we merge the SWCS, there is no other way to tell the
compiler which APIs to use by default, and I'm not sure I can control that
from outside FB.

Maybe just the Maven artifacts will be merged and we'll keep the pairs of
SWCs for IDEs.

Thoughts?
-Alex

On 7/6/17, 4:12 PM, "Josh Tynjala"  wrote:

>Okay, I figured out how to make VSCode switch to JS APIs instead of SWF
>APIs for completion and things. In the next version of the extension, when
>the targets compiler option is specified in asconfig.json, and the first
>value isn't "SWF", the extension will offer JS APIs. That includes giving
>you access to native browser APIs instead of Flash Player APIs. That's
>going to be a really nice change, I think. Thanks for pointing out this
>issue!
>
>- Josh
>
>On Thu, Jul 6, 2017 at 2:35 PM, Josh Tynjala 
>wrote:
>
>> > The js-output-type, library-path and external-library-path options are
>> probably not needed
>>
>> I would get rid of -js-output-type. I assume that -targets takes
>> precedence, but just to be safe, you shouldn't use both.
>>-js-output-type is
>> necessary for 0.7.0, but switch entirely to -targets with 0.8.0.
>>
>> > It would be nice to have full support for the new compiler options
>>
>> html-template, html-output-filename, js-compiler-option,
>> js-external-library-path, js-library-path, swf-external-library-path,
>> swf-library-path, and remove-circulars should all work in the
>> compilerOptions field if you're using the latest vscode-nextgenas 0.4.4
>>and
>> asconfigc 0.5.1. I just updated asconfigc to support these options last
>> week, and I haven't made an official announcement yet, so you might have
>> missed that one.
>>
>> I think there may be one or two you'll still need to put into
>> additionalOptions, but you should be able to switch over most of them.
>>
>> > 1. I’m getting “problems” even for files which are not used in my
>> project and are not open.
>>
>> This is something I'm aware of in VSCode. The compiler seems to greedily
>> load everything that exists in a source path, even if you don't actually
>> use it. Personally I like this, but even if I were to make it an option
>> somehow, I'm not aware of a way to stop the compiler from working that
>>way
>> either.
>>
>> > 2. I’m getting lots of errors which are specific to SWF-only output:
>>
>> I just glanced through the part of VSCode that passes options to the
>> compiler for code intelligence (different from the way that asconfigc
>>runs
>> the compiler to build), and I don't think I'm actually using the value
>>of
>> -targets. It's probably defaulting to SWF. I'll play around with that to
>> see if I can improve things when -targets is specifically JSFlex.
>>
>> >   a. I’m not getting JS specific classes recognized.
>>
>> Just to be clear, are you referring to DOM classes like
>>HTMLButtonElement
>> and other browser APIs here? I just want to be sure so that I test the
>> right thing when I make changes.
>>
>> - Josh
>>
>> On Thu, Jul 6, 2017 at 2:16 PM, Harbs  wrote:
>>
>>> Since updating to “dual”has been reporting lots of errors. When I
>>>build,
>>> both the debug and release builds build correctly, but the PROBLEMS
>>>window
>>> and the live code hinting report lots of (non) issues. I’m not sure
>>>what
>>> the source of the errors are, but here are the details:
>>>
>>> I’ve tried a few variations of the asconfig file, but here’s what I
>>> currently have:
>>> {
>>> "config": "flex",
>>> "compilerOptions": {
>>> "debug": true,
>>> "js-output-type": "flexjs",
>>> "targets": ["JSFlex"],
>>> "source-map": false,
>>> "library-path": [
>>> "lib"
>>> ],
>>> "external-library-path": [
>>> "typedefs"
>>> ]
>>> },
>>> "copySourcePathAssets": true,
>>> "additionalOptions": "-remove-circulars
>>>-js-output-optimization=skipAsCoercions
>>> -html-template=src/resources/mdl-js-index-template.html
>>> -js-external-library-path+=typedefs -js-library-path+=lib",
>>> "files":
>>> [
>>> "src/PortedPrintUI.mxml"
>>> ]
>>> }
>>>
>>> The js-output-type, library-path and external-library-path options are
>>> probably not needed, but they don’t seem to adversely effect the
>>>builds.
>>> (It would be nice to have full support for the new compiler options.)
>>>
>>> Problems:
>>> 1. I’m getting “problems” even for files which are not used in my

Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean
Hi,

> - Do we care about code being commented out? I think not.

If we know why it was commented out sure. There’s always the concern is this 
code possibly needed or not?

> - Does a semicolon matter?

It marked as a minor issue but it can cause issues when JS code is optimised 
and/or minified. It’s easy and safe to fix.

> - Is “:Object” really a critical issue?

Critical no (and it's not marked as such) and in some cases it’s quite useful. 
Like all rules there are exceptions. Using a class with named properties gives 
you type safety and performance benefits.

> - Is refactoring “complexity” really a huge problem

If we want easy to test/easy to maintain code then it can be yes.

> - This one: Replace == with === : has been discussed and I think your making 
> the change suggested broke things.

It didn’t break things in any major way, the tests passed, examples worked and 
the application I’m working on worked. I believe there was one instance that 
caused an issue for Harbs.

There are some other useful rules in there I’ll document them.

> Probably the best approach would be to collect these into a wiki page and 
> then determine what conventions developers consider important. Once that is 
> done change the sonar configuration and show true technical debt. I think 
> that this is much less risky to the project and much less distraction to the 
> team.

Sure I’ll go with that approach.

Thanks,
Justin

Re: [FlexJS][VS Code] dual issues

2017-07-06 Thread Josh Tynjala
Okay, I figured out how to make VSCode switch to JS APIs instead of SWF
APIs for completion and things. In the next version of the extension, when
the targets compiler option is specified in asconfig.json, and the first
value isn't "SWF", the extension will offer JS APIs. That includes giving
you access to native browser APIs instead of Flash Player APIs. That's
going to be a really nice change, I think. Thanks for pointing out this
issue!

- Josh

On Thu, Jul 6, 2017 at 2:35 PM, Josh Tynjala  wrote:

> > The js-output-type, library-path and external-library-path options are
> probably not needed
>
> I would get rid of -js-output-type. I assume that -targets takes
> precedence, but just to be safe, you shouldn't use both. -js-output-type is
> necessary for 0.7.0, but switch entirely to -targets with 0.8.0.
>
> > It would be nice to have full support for the new compiler options
>
> html-template, html-output-filename, js-compiler-option,
> js-external-library-path, js-library-path, swf-external-library-path,
> swf-library-path, and remove-circulars should all work in the
> compilerOptions field if you're using the latest vscode-nextgenas 0.4.4 and
> asconfigc 0.5.1. I just updated asconfigc to support these options last
> week, and I haven't made an official announcement yet, so you might have
> missed that one.
>
> I think there may be one or two you'll still need to put into
> additionalOptions, but you should be able to switch over most of them.
>
> > 1. I’m getting “problems” even for files which are not used in my
> project and are not open.
>
> This is something I'm aware of in VSCode. The compiler seems to greedily
> load everything that exists in a source path, even if you don't actually
> use it. Personally I like this, but even if I were to make it an option
> somehow, I'm not aware of a way to stop the compiler from working that way
> either.
>
> > 2. I’m getting lots of errors which are specific to SWF-only output:
>
> I just glanced through the part of VSCode that passes options to the
> compiler for code intelligence (different from the way that asconfigc runs
> the compiler to build), and I don't think I'm actually using the value of
> -targets. It's probably defaulting to SWF. I'll play around with that to
> see if I can improve things when -targets is specifically JSFlex.
>
> >   a. I’m not getting JS specific classes recognized.
>
> Just to be clear, are you referring to DOM classes like HTMLButtonElement
> and other browser APIs here? I just want to be sure so that I test the
> right thing when I make changes.
>
> - Josh
>
> On Thu, Jul 6, 2017 at 2:16 PM, Harbs  wrote:
>
>> Since updating to “dual”has been reporting lots of errors. When I build,
>> both the debug and release builds build correctly, but the PROBLEMS window
>> and the live code hinting report lots of (non) issues. I’m not sure what
>> the source of the errors are, but here are the details:
>>
>> I’ve tried a few variations of the asconfig file, but here’s what I
>> currently have:
>> {
>> "config": "flex",
>> "compilerOptions": {
>> "debug": true,
>> "js-output-type": "flexjs",
>> "targets": ["JSFlex"],
>> "source-map": false,
>> "library-path": [
>> "lib"
>> ],
>> "external-library-path": [
>> "typedefs"
>> ]
>> },
>> "copySourcePathAssets": true,
>> "additionalOptions": "-remove-circulars 
>> -js-output-optimization=skipAsCoercions
>> -html-template=src/resources/mdl-js-index-template.html
>> -js-external-library-path+=typedefs -js-library-path+=lib",
>> "files":
>> [
>> "src/PortedPrintUI.mxml"
>> ]
>> }
>>
>> The js-output-type, library-path and external-library-path options are
>> probably not needed, but they don’t seem to adversely effect the builds.
>> (It would be nice to have full support for the new compiler options.)
>>
>> Problems:
>> 1. I’m getting “problems” even for files which are not used in my project
>> and are not open.
>> 2. I’m getting lots of errors which are specific to SWF-only output:
>>   a. I’m not getting JS specific classes recognized.
>>   b. I’m getting lots of incompatible overrides (to Flash methods)
>>   c. I’m getting overriding function not marked for override errors on
>> functions that are implemented in flash (i.e. public function get
>> scaleX():Number)
>>   d. conflicts between variables and Flash getters.
>>   e. etc...
>>
>> Thanks,
>> Harbs
>
>
>


Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-07-06 Thread Alex Harui
I just tried swapping SimpleCSSValuesImpl for AllCSSValuesImpl in the
develop branch in examples/flexjs/DataBindingExample and it worked for me.

Does it still not work for you?

-Alex

On 6/29/17, 3:40 AM, "Harbs"  wrote:

>Check your basic-manifest.xml for Core.
>
>Do you see class="org.apache.flex.core.AllCSSValuesImpl”/>?
>
>> On Jun 29, 2017, at 12:54 PM, Justin Mclean 
>>wrote:
>> 
>> Hi,
>> 
>> The class is there I’m on the latest version of develop of all 3 repos
>>and I’m still getting that compile error. Did you actually try using
>>that class / compiling it?
>> 
>> Thanks,
>> Justin
>



Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean
Hi,

> A large percentage of the complaints are inaccurate. The reason the technical 
> debt increased is largely because of the new TLF code.
> 
> Who made these rules and how do we change them? We can make it look much 
> better by just changing some of the rules…

The rules come from various places - CVEs, PMD and generally accepted rules of 
good practice. I have mention several times that they needed some fine tuning.

If you click on the “…” next to a rule it will give you more information 
including in some case where it come from.

Thanks,
Justin

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread Alex Harui
Hi Allen,

I just updated the FlexJS ASDoc link from our website.  Because FlexJS
does some enhanced parsing of AS, the current ASDoc tools can't generate
the usual ASDoc pages, so we are currently using a FlexJS example app to
display ASDoc.  It is a bit ugly right now and volunteers are welcome to
offer improvements.  The source code is in examples/flexjs/ASDoc.

Where did you find that link to people.apache.org?   That ASDoc is
probably out of date.

Thanks,
-Alex

On 7/6/17, 12:25 PM, "Allen YANG"  wrote:

>Thanks, Yishay. I will look into these in the API reference.  Just
>created my first panel.
>Somehow I only see the Apache Flex 4.14.0 API reference in
>https://na01.safelinks.protection.outlook.com/?url=http:%2F%2Fpeople.apach
>e.org%2F~pent%2Fasdoc-flexjs%2F=02%7C01%7C%7Cea5814849fde49d0e63908d4
>c4a4ce1e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636349659488246457
>data=Pfq4vVvp%2FmUtR9mOfRvWI3xmugKCJxlDH%2FDm8vwI%2Fxc%3D=0 when
>I search for FlexJS API reference. Hope this is correct page.
>Regards,
>Allen
>
>
>-Original Message-
>From: yishayw [mailto:yishayj...@hotmail.com]
>Sent: Thursday, July 06, 2017 2:32 PM
>To: dev@flex.apache.org
>Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to
>HTML+JS
>
>I don't have code to share but as general pointers:
>
>- use Panel instead of TitleWindow
>- use UIUtils instead of PopupManager
>- user HContainer instead of HBox
>
>Hope this helps.
>
>
>
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.247.n4.nabble.com%2FFlexJS-question-about-porting-an-Ado
>be-Flex-3-project-to-HTML-JS-tp62698p62886.html=02%7C01%7C%7Cea581484
>9fde49d0e63908d4c4a4ce1e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363
>49659488246457=M83aDk0hR4a8n84eglO3nQuehM4IHXDol46FSVoqwBI%3D
>ed=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
>
>
>Ce message, ainsi que tous les fichiers joints à ce message, peuvent
>contenir des informations sensibles et/ ou confidentielles ne devant pas
>être divulguées. Si vous n'êtes pas le destinataire de ce message (ou que
>vous recevez ce message par erreur), nous vous remercions de le notifier
>immédiatement à son expéditeur, et de détruire ce message. Toute copie,
>divulgation, modification, utilisation ou diffusion, non autorisée,
>directe ou indirecte, de tout ou partie de ce message, est strictement
>interdite.
>
>
>This e-mail, and any document attached hereby, may contain confidential
>and/or privileged information. If you are not the intended recipient (or
>have received this e-mail in error) please notify the sender immediately
>and destroy this e-mail. Any unauthorized, direct or indirect, copying,
>disclosure, distribution or other use of the material or parts thereof is
>strictly forbidden.



Re: FlexJS Tests (was Re: [FlexJS] technical debt)

2017-07-06 Thread Alex Harui
I have a subset of Mustella working on both platforms in the BasicTests
that run from the checkintests target in the Ant build.  There is a
writeup on Mustella in the wiki
https://cwiki.apache.org/confluence/display/FLEX/Mustella+Overview.  I
haven't gone through it to see how much does or doesn't apply to FlexJS.
The BasicTests are in the flex-asjs repo in mustella/tests/basicTests.  I
basically copied the Flex SDK's BasicTests and modified it a bit to run in
FlexJS and commented out most tests because back when I did it, we didn't
have many components.  It might be interesting to comment more tests back
in and see if they run.

There are some FlexUnit tests that run as part of the Core.swc Ant build,
but only on SWF.

The Maven build runs some Selenium tests that I think are written in Java,
and I think only test JS output.

I haven't invested much time in test infrastructure or test creation since
there were some strong opinions about not liking Mustella and some
thoughts about how to make FlexUnit run on both platforms.

My personal preference is that tests should be written in MXML and/or AS
and run on both platforms.  Bonus points if existing tests can be run
unmodified or mostly unmodified.

-Alex

On 7/6/17, 2:02 PM, "Harbs"  wrote:

>Where are the instructions on how to use it? If I know how to write
>tests, I’d be much better about doing so…
>
>> On Jul 6, 2017, at 11:53 PM, Alex Harui 
>>wrote:
>> 
>> I have put in place a test infrastructure
>



Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Alex Harui
Interesting.  IJ goes down a completely different code path than FB.

Something to keep in mind for the future.  Thanks for figuring it out.

-Alex

On 7/6/17, 2:15 PM, "Josh Tynjala"  wrote:

>Unfortunately, there is no workaround for 0.8.0. Even if we try to use
>-js-output-type instead, it tries to call a constructor that simply
>doesn't
>exist anymore. We didn't get compiler errors to tell us that this had
>broken because it it used reflection to find that constructor.
>
>- Josh
>
>On Jul 6, 2017 1:47 PM, "Alex Harui"  wrote:
>
>> Thanks for noticing that.  So does that mean a workaround for 0.8.0 is
>>to
>> define in additional compiler options:
>>
>>  -js-output-type=FLEXJS
>>
>> -Alex
>>
>> On 7/6/17, 11:46 AM, "Josh Tynjala"  wrote:
>>
>> >Okay, I made a commit that seems to get things working in IntelliJ IDEA
>> >again. It looks like MxmlJSC and CompJSC in flex-compiler-oem.jar no
>> >longer
>> >need to create the backend manually, and MXMLJSC or COMPJSC can figure
>>out
>> >what to do automatically based on the value of -targets now.
>> >
>> >I was able to successfully build some projects in IntelliJ with
>>-targets
>> >set to JSFlex, SWF, and also JS.
>> >
>> >- Josh
>> >
>> >On Thu, Jul 6, 2017 at 11:21 AM, Josh Tynjala 
>> >wrote:
>> >
>> >> The problem looks to be related to this line:
>> >>
>> >> compiler = 
>>COMPILER.getDeclaredConstructor(IBackend.class).newInstance(
>> >> backend);
>> >>
>> >> It's looking for a constructor on MXMLJSC (not to be confused with
>> >> MxmlJSC) that takes an IBackend as a parameter. There is no longer a
>> >> constructor like that in 0.8.0. If I understand the dual changes
>> >>correctly,
>> >> MXMLJSC now automatically creates an IBackend based on the -targets
>> >>value.
>> >> It looks like this code does indeed still need changes to support
>>dual.
>> >>
>> >> - Josh
>> >>
>> >>
>> >> On Wed, Jul 5, 2017 at 3:09 PM, Josh Tynjala 
>> >> wrote:
>> >>
>> >>> I'm trying to create a new FlexJS 0.8.0 project in IntelliJ IDEA,
>>and
>> >>>I'm
>> >>> getting the following output when I try to build the project:
>> >>>
>> >>> Information:[HelloIDEA]: Starting Flex compiler:
>> >>> "/Applications/IntelliJ
>> >>>IDEA.app/Contents/jdk/Contents/Home/jre/bin/java"
>> >>>
>> >>>-Dapplication.home=/Users/joshtynjala/Development/Flex/
>> sdks/flexjs-0.8.0
>> >>> -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Duser.language=en
>> >>> -Duser.region=en -Xmx512m -classpath "/Applications/IntelliJ
>> >>>
>> >>>IDEA.app/Contents/plugins/flex/lib/idea-flex-compiler-
>> fix.jar:/Applicati
>> >>>ons/IntelliJ
>> >>> IDEA.app/Contents/plugins/flex/lib/flex-compiler.jar:/Users/
>> >>>
>> >>>joshtynjala/Development/Flex/sdks/flexjs-0.8.0/lib/
>> flex-compiler-oem.jar
>> >>>"
>> >>> com.intellij.flex.compiler.FlexCompiler 54900
>> >>> Information:[HelloIDEA]: mxmlc -load-config=/Users/joshtynjal
>> >>> a/Library/Caches/IntelliJIdea2017.1/compile-server/
>> >>> helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
>> >>> -load-config+=/Users/joshtynjala/Development/Flex/sdks/
>> >>> flexjs-0.8.0/ide/IDEA/intellij-config.xml
>> >>> Information:[HelloIDEA]: unknown error
>> >>> Information:[HelloIDEA]: at java.lang.Class.getConstructor
>> >>> 0(Class.java:3082)
>> >>> Information:[HelloIDEA]: at java.lang.Class.getDeclaredCon
>> >>> structor(Class.java:2178)
>> >>> Information:[HelloIDEA]: at flex2.tools.MxmlJSC.getCompile
>> >>> rInstance(MxmlJSC.java:48)
>> >>> Information:[HelloIDEA]: at
>> >>>flex2.tools.MxmlJSC.execute(MxmlJSC.java:89)
>> >>> Information:[HelloIDEA]: at flex2.tools.Tool.compile(Tool.java:68)
>> >>> Information:[HelloIDEA]: at flex2.tools.Mxmlc.mxmlc(Mxmlc.java:73)
>> >>> Information:[HelloIDEA]: at com.intellij.flex.compiler.fle
>> >>> x4.Flex4Handler.compileSwf(Flex4Handler.java:81)
>> >>> Information:[HelloIDEA]: at com.intellij.flex.compiler.Com
>> >>> pilationThread.run(CompilationThread.java:48)
>> >>> Information:[HelloIDEA]: Compilation failed
>> >>> Information:7/5/17, 2:56 PM - Compilation completed with 1 error
>>and 0
>> >>> warnings in 595ms
>> >>> Error:[HelloIDEA]: java.lang.NoSuchMethodException:
>> >>> org.apache.flex.compiler.clients.MXMLJSC.(org.apache.
>> >>> flex.compiler.driver.IBackend)
>> >>>
>> >>> I followed the steps in these instructions that worked correctly
>>with
>> >>> 0.7.0:
>> >>>
>> >>>
>> >>>https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fcwiki.a
>> >>>pache.org%2Fconfluence%2Fdisplay%2FFLEX%2FUsing%
>> 2BFlexJ=02%7C01%7C%
>> >>>7C0db52a1b085d40a0d99008d4c49f7cf7%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C
>> >>>0%7C0%7C636349636715390181=SMfsugjsJKZI9AKay2Dn0qhk7srWdH
>> %2BkTtrlo
>> >>>GXiw34%3D=0
>> >>> S+with+IntelliJ+IDEA
>> >>>
>> >>> I'm not very familiar with this part of the code, but it looks to me
>> >>>like
>> >>> the call to MxmlJSC.getCompilerInstance() can't find 

Re: [FlexJS][VS Code] dual issues

2017-07-06 Thread Josh Tynjala
> The js-output-type, library-path and external-library-path options are
probably not needed

I would get rid of -js-output-type. I assume that -targets takes
precedence, but just to be safe, you shouldn't use both. -js-output-type is
necessary for 0.7.0, but switch entirely to -targets with 0.8.0.

> It would be nice to have full support for the new compiler options

html-template, html-output-filename, js-compiler-option,
js-external-library-path, js-library-path, swf-external-library-path,
swf-library-path, and remove-circulars should all work in the
compilerOptions field if you're using the latest vscode-nextgenas 0.4.4 and
asconfigc 0.5.1. I just updated asconfigc to support these options last
week, and I haven't made an official announcement yet, so you might have
missed that one.

I think there may be one or two you'll still need to put into
additionalOptions, but you should be able to switch over most of them.

> 1. I’m getting “problems” even for files which are not used in my project
and are not open.

This is something I'm aware of in VSCode. The compiler seems to greedily
load everything that exists in a source path, even if you don't actually
use it. Personally I like this, but even if I were to make it an option
somehow, I'm not aware of a way to stop the compiler from working that way
either.

> 2. I’m getting lots of errors which are specific to SWF-only output:

I just glanced through the part of VSCode that passes options to the
compiler for code intelligence (different from the way that asconfigc runs
the compiler to build), and I don't think I'm actually using the value of
-targets. It's probably defaulting to SWF. I'll play around with that to
see if I can improve things when -targets is specifically JSFlex.

>   a. I’m not getting JS specific classes recognized.

Just to be clear, are you referring to DOM classes like HTMLButtonElement
and other browser APIs here? I just want to be sure so that I test the
right thing when I make changes.

- Josh

On Thu, Jul 6, 2017 at 2:16 PM, Harbs  wrote:

> Since updating to “dual”has been reporting lots of errors. When I build,
> both the debug and release builds build correctly, but the PROBLEMS window
> and the live code hinting report lots of (non) issues. I’m not sure what
> the source of the errors are, but here are the details:
>
> I’ve tried a few variations of the asconfig file, but here’s what I
> currently have:
> {
> "config": "flex",
> "compilerOptions": {
> "debug": true,
> "js-output-type": "flexjs",
> "targets": ["JSFlex"],
> "source-map": false,
> "library-path": [
> "lib"
> ],
> "external-library-path": [
> "typedefs"
> ]
> },
> "copySourcePathAssets": true,
> "additionalOptions": "-remove-circulars 
> -js-output-optimization=skipAsCoercions
> -html-template=src/resources/mdl-js-index-template.html
> -js-external-library-path+=typedefs -js-library-path+=lib",
> "files":
> [
> "src/PortedPrintUI.mxml"
> ]
> }
>
> The js-output-type, library-path and external-library-path options are
> probably not needed, but they don’t seem to adversely effect the builds.
> (It would be nice to have full support for the new compiler options.)
>
> Problems:
> 1. I’m getting “problems” even for files which are not used in my project
> and are not open.
> 2. I’m getting lots of errors which are specific to SWF-only output:
>   a. I’m not getting JS specific classes recognized.
>   b. I’m getting lots of incompatible overrides (to Flash methods)
>   c. I’m getting overriding function not marked for override errors on
> functions that are implemented in flash (i.e. public function get
> scaleX():Number)
>   d. conflicts between variables and Flash getters.
>   e. etc...
>
> Thanks,
> Harbs


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
Unfortunately, there is no workaround for 0.8.0. Even if we try to use
-js-output-type instead, it tries to call a constructor that simply doesn't
exist anymore. We didn't get compiler errors to tell us that this had
broken because it it used reflection to find that constructor.

- Josh

On Jul 6, 2017 1:47 PM, "Alex Harui"  wrote:

> Thanks for noticing that.  So does that mean a workaround for 0.8.0 is to
> define in additional compiler options:
>
>  -js-output-type=FLEXJS
>
> -Alex
>
> On 7/6/17, 11:46 AM, "Josh Tynjala"  wrote:
>
> >Okay, I made a commit that seems to get things working in IntelliJ IDEA
> >again. It looks like MxmlJSC and CompJSC in flex-compiler-oem.jar no
> >longer
> >need to create the backend manually, and MXMLJSC or COMPJSC can figure out
> >what to do automatically based on the value of -targets now.
> >
> >I was able to successfully build some projects in IntelliJ with -targets
> >set to JSFlex, SWF, and also JS.
> >
> >- Josh
> >
> >On Thu, Jul 6, 2017 at 11:21 AM, Josh Tynjala 
> >wrote:
> >
> >> The problem looks to be related to this line:
> >>
> >> compiler = COMPILER.getDeclaredConstructor(IBackend.class).newInstance(
> >> backend);
> >>
> >> It's looking for a constructor on MXMLJSC (not to be confused with
> >> MxmlJSC) that takes an IBackend as a parameter. There is no longer a
> >> constructor like that in 0.8.0. If I understand the dual changes
> >>correctly,
> >> MXMLJSC now automatically creates an IBackend based on the -targets
> >>value.
> >> It looks like this code does indeed still need changes to support dual.
> >>
> >> - Josh
> >>
> >>
> >> On Wed, Jul 5, 2017 at 3:09 PM, Josh Tynjala 
> >> wrote:
> >>
> >>> I'm trying to create a new FlexJS 0.8.0 project in IntelliJ IDEA, and
> >>>I'm
> >>> getting the following output when I try to build the project:
> >>>
> >>> Information:[HelloIDEA]: Starting Flex compiler:
> >>> "/Applications/IntelliJ
> >>>IDEA.app/Contents/jdk/Contents/Home/jre/bin/java"
> >>>
> >>>-Dapplication.home=/Users/joshtynjala/Development/Flex/
> sdks/flexjs-0.8.0
> >>> -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Duser.language=en
> >>> -Duser.region=en -Xmx512m -classpath "/Applications/IntelliJ
> >>>
> >>>IDEA.app/Contents/plugins/flex/lib/idea-flex-compiler-
> fix.jar:/Applicati
> >>>ons/IntelliJ
> >>> IDEA.app/Contents/plugins/flex/lib/flex-compiler.jar:/Users/
> >>>
> >>>joshtynjala/Development/Flex/sdks/flexjs-0.8.0/lib/
> flex-compiler-oem.jar
> >>>"
> >>> com.intellij.flex.compiler.FlexCompiler 54900
> >>> Information:[HelloIDEA]: mxmlc -load-config=/Users/joshtynjal
> >>> a/Library/Caches/IntelliJIdea2017.1/compile-server/
> >>> helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
> >>> -load-config+=/Users/joshtynjala/Development/Flex/sdks/
> >>> flexjs-0.8.0/ide/IDEA/intellij-config.xml
> >>> Information:[HelloIDEA]: unknown error
> >>> Information:[HelloIDEA]: at java.lang.Class.getConstructor
> >>> 0(Class.java:3082)
> >>> Information:[HelloIDEA]: at java.lang.Class.getDeclaredCon
> >>> structor(Class.java:2178)
> >>> Information:[HelloIDEA]: at flex2.tools.MxmlJSC.getCompile
> >>> rInstance(MxmlJSC.java:48)
> >>> Information:[HelloIDEA]: at
> >>>flex2.tools.MxmlJSC.execute(MxmlJSC.java:89)
> >>> Information:[HelloIDEA]: at flex2.tools.Tool.compile(Tool.java:68)
> >>> Information:[HelloIDEA]: at flex2.tools.Mxmlc.mxmlc(Mxmlc.java:73)
> >>> Information:[HelloIDEA]: at com.intellij.flex.compiler.fle
> >>> x4.Flex4Handler.compileSwf(Flex4Handler.java:81)
> >>> Information:[HelloIDEA]: at com.intellij.flex.compiler.Com
> >>> pilationThread.run(CompilationThread.java:48)
> >>> Information:[HelloIDEA]: Compilation failed
> >>> Information:7/5/17, 2:56 PM - Compilation completed with 1 error and 0
> >>> warnings in 595ms
> >>> Error:[HelloIDEA]: java.lang.NoSuchMethodException:
> >>> org.apache.flex.compiler.clients.MXMLJSC.(org.apache.
> >>> flex.compiler.driver.IBackend)
> >>>
> >>> I followed the steps in these instructions that worked correctly with
> >>> 0.7.0:
> >>>
> >>>
> >>>https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fcwiki.a
> >>>pache.org%2Fconfluence%2Fdisplay%2FFLEX%2FUsing%
> 2BFlexJ=02%7C01%7C%
> >>>7C0db52a1b085d40a0d99008d4c49f7cf7%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C
> >>>0%7C0%7C636349636715390181=SMfsugjsJKZI9AKay2Dn0qhk7srWdH
> %2BkTtrlo
> >>>GXiw34%3D=0
> >>> S+with+IntelliJ+IDEA
> >>>
> >>> I'm not very familiar with this part of the code, but it looks to me
> >>>like
> >>> the call to MxmlJSC.getCompilerInstance() can't find IBackend? Could
> >>>it be
> >>> that flex-compiler-oem.jar is missing something in its classpath?
> >>>
> >>> - Josh
> >>>
> >>
> >>
>
>


[FlexJS][VS Code] dual issues

2017-07-06 Thread Harbs
Since updating to “dual”has been reporting lots of errors. When I build, both 
the debug and release builds build correctly, but the PROBLEMS window and the 
live code hinting report lots of (non) issues. I’m not sure what the source of 
the errors are, but here are the details:

I’ve tried a few variations of the asconfig file, but here’s what I currently 
have:
{
"config": "flex",
"compilerOptions": {
"debug": true,
"js-output-type": "flexjs",
"targets": ["JSFlex"],
"source-map": false,
"library-path": [
"lib"
],
"external-library-path": [
"typedefs"
]
},
"copySourcePathAssets": true,
"additionalOptions": "-remove-circulars 
-js-output-optimization=skipAsCoercions 
-html-template=src/resources/mdl-js-index-template.html 
-js-external-library-path+=typedefs -js-library-path+=lib",
"files":
[
"src/PortedPrintUI.mxml"
]
}

The js-output-type, library-path and external-library-path options are probably 
not needed, but they don’t seem to adversely effect the builds. (It would be 
nice to have full support for the new compiler options.)

Problems:
1. I’m getting “problems” even for files which are not used in my project and 
are not open.
2. I’m getting lots of errors which are specific to SWF-only output:
  a. I’m not getting JS specific classes recognized.
  b. I’m getting lots of incompatible overrides (to Flash methods)
  c. I’m getting overriding function not marked for override errors on 
functions that are implemented in flash (i.e. public function get 
scaleX():Number)
  d. conflicts between variables and Flash getters.
  e. etc...

Thanks,
Harbs

FlexJS Tests (was Re: [FlexJS] technical debt)

2017-07-06 Thread Harbs
Where are the instructions on how to use it? If I know how to write tests, I’d 
be much better about doing so…

> On Jul 6, 2017, at 11:53 PM, Alex Harui  wrote:
> 
> I have put in place a test infrastructure



Re: [FlexJS] technical debt

2017-07-06 Thread Harbs
Yup.

For example: I’d say an extremely large percentage of the “technical debt” in 
TLF is there for a reason. Do NOT “fix” any of that…

> On Jul 6, 2017, at 11:53 PM, Alex Harui  wrote:
> 
> But IMO, for right now, if "it ain't broke, don't fix it".



Re: [FlexJS] technical debt

2017-07-06 Thread Alex Harui
Hi Dave,

There are almost no automated tests for the FlexJS framework.  I have put
in place a test infrastructure, but nobody has volunteered more tests.  So
no test would have caught the "==" to "===" issues, and no tests are going
to catch issues arising from trying to clean up technical debt, if in fact
there is as much as the current tools indicate.

Justin is welcome to write anything he wants in the wiki.  But IMO, for
right now, if "it ain't broke, don't fix it".

Thanks,
-Alex

On 7/6/17, 12:23 PM, "Dave Fisher"  wrote:

>Hi Alex,
>
>> On Jul 6, 2017, at 10:36 AM, Alex Harui 
>>wrote:
>> 
>> IMO, even more important than technical debt is a test system and tests
>>to make sure any changes don't break anything.
>
>That would include any changes to fix “technical debt”.
>
>> 
>> I could be wrong, but I think our customers would rather have us spend
>>our time and energy on missing features like AMF right now.
>
>I think that users or consumers is a better term than customers.
>
>Missing features is always great.
>
>If Justin’s itch is technical debt then I think he should at least follow
>a wiki approach and also address Harbs comment else thread. If he has
>people from his company do it then that is great too.
>
>Didn’t the blind change from “==“ to “===“ already cause tests to break?
>
>Best Regards,
>Dave
>
>> 
>> My 2 cents,
>> -Alex
>> 
>> From: Dave Fisher >
>> Reply-To: "dev@flex.apache.org"
>>>
>> Date: Thursday, July 6, 2017 at 9:24 AM
>> To: "dev@flex.apache.org"
>>>
>> Subject: Re: [FlexJS] technical debt
>> 
>> Hi Justin,
>> 
>> (I missed your double reply until I reviewed the thread before sending.
>>This caused me to remove part of this email.)
>> 
>> I looked at some of the major and minor Code Smells. I think that
>>rather than accepting the ActionScript conventions that Sonar provides
>>that most of these can be eliminated by resetting the rules to match
>>this project’s ideas about how Flex smells.
>> 
>> - Do we care about code being commented out? I think not.
>> - Does a semicolon matter?
>> - Is “:Object” really a critical issue?
>> - Is refactoring “complexity” really a huge problem - Function has a
>>complexity of 14 which is greater than 10 authorized.
>> - This one: Replace == with === : has been discussed and I think your
>>making the change suggested broke things.
>> 
>> Probably the best approach would be to collect these into a wiki page
>>and then determine what conventions developers consider important. Once
>>that is done change the sonar configuration and show true technical
>>debt. I think that this is much less risky to the project and much less
>>distraction to the team.
>> 
>> Only once Sonar rules are properly tuned is it a powerful tool for
>>assuring code quality. Until then it can be a nearly useless sink for
>>scarce developer time and a chance for “hair on fire” concern over
>>“technical debt”.
>> 
>> I agree that like it is it could be a measure of usefulness for new
>>developers in a commercial situation.
>> 
>> Regards,
>> Dave
>> 
>> On Jul 5, 2017, at 11:53 PM, Justin Mclean
>>> wrote:
>> 
>> Hi,
>> 
>> Dave I assume the case statement issue you referring to is is the last
>>one in this list [1]. It not a bug but style wise it’s a little odd and
>>probably should still be fixed.
>> 
>> Thanks,
>> Justin
>> 
>> 1. 
>>https://builds.apache.org/analysis/component_issues/index?id=org.apache.f
>>lex.flexjs.framework%3Aflexjs-framework-parent#types=CODE_SMELL|severitie
>>s=CRITICAL
>> 
>



Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Alex Harui
Thanks for noticing that.  So does that mean a workaround for 0.8.0 is to
define in additional compiler options:

 -js-output-type=FLEXJS

-Alex

On 7/6/17, 11:46 AM, "Josh Tynjala"  wrote:

>Okay, I made a commit that seems to get things working in IntelliJ IDEA
>again. It looks like MxmlJSC and CompJSC in flex-compiler-oem.jar no
>longer
>need to create the backend manually, and MXMLJSC or COMPJSC can figure out
>what to do automatically based on the value of -targets now.
>
>I was able to successfully build some projects in IntelliJ with -targets
>set to JSFlex, SWF, and also JS.
>
>- Josh
>
>On Thu, Jul 6, 2017 at 11:21 AM, Josh Tynjala 
>wrote:
>
>> The problem looks to be related to this line:
>>
>> compiler = COMPILER.getDeclaredConstructor(IBackend.class).newInstance(
>> backend);
>>
>> It's looking for a constructor on MXMLJSC (not to be confused with
>> MxmlJSC) that takes an IBackend as a parameter. There is no longer a
>> constructor like that in 0.8.0. If I understand the dual changes
>>correctly,
>> MXMLJSC now automatically creates an IBackend based on the -targets
>>value.
>> It looks like this code does indeed still need changes to support dual.
>>
>> - Josh
>>
>>
>> On Wed, Jul 5, 2017 at 3:09 PM, Josh Tynjala 
>> wrote:
>>
>>> I'm trying to create a new FlexJS 0.8.0 project in IntelliJ IDEA, and
>>>I'm
>>> getting the following output when I try to build the project:
>>>
>>> Information:[HelloIDEA]: Starting Flex compiler:
>>> "/Applications/IntelliJ
>>>IDEA.app/Contents/jdk/Contents/Home/jre/bin/java"
>>> 
>>>-Dapplication.home=/Users/joshtynjala/Development/Flex/sdks/flexjs-0.8.0
>>> -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Duser.language=en
>>> -Duser.region=en -Xmx512m -classpath "/Applications/IntelliJ
>>> 
>>>IDEA.app/Contents/plugins/flex/lib/idea-flex-compiler-fix.jar:/Applicati
>>>ons/IntelliJ
>>> IDEA.app/Contents/plugins/flex/lib/flex-compiler.jar:/Users/
>>> 
>>>joshtynjala/Development/Flex/sdks/flexjs-0.8.0/lib/flex-compiler-oem.jar
>>>"
>>> com.intellij.flex.compiler.FlexCompiler 54900
>>> Information:[HelloIDEA]: mxmlc -load-config=/Users/joshtynjal
>>> a/Library/Caches/IntelliJIdea2017.1/compile-server/
>>> helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
>>> -load-config+=/Users/joshtynjala/Development/Flex/sdks/
>>> flexjs-0.8.0/ide/IDEA/intellij-config.xml
>>> Information:[HelloIDEA]: unknown error
>>> Information:[HelloIDEA]: at java.lang.Class.getConstructor
>>> 0(Class.java:3082)
>>> Information:[HelloIDEA]: at java.lang.Class.getDeclaredCon
>>> structor(Class.java:2178)
>>> Information:[HelloIDEA]: at flex2.tools.MxmlJSC.getCompile
>>> rInstance(MxmlJSC.java:48)
>>> Information:[HelloIDEA]: at
>>>flex2.tools.MxmlJSC.execute(MxmlJSC.java:89)
>>> Information:[HelloIDEA]: at flex2.tools.Tool.compile(Tool.java:68)
>>> Information:[HelloIDEA]: at flex2.tools.Mxmlc.mxmlc(Mxmlc.java:73)
>>> Information:[HelloIDEA]: at com.intellij.flex.compiler.fle
>>> x4.Flex4Handler.compileSwf(Flex4Handler.java:81)
>>> Information:[HelloIDEA]: at com.intellij.flex.compiler.Com
>>> pilationThread.run(CompilationThread.java:48)
>>> Information:[HelloIDEA]: Compilation failed
>>> Information:7/5/17, 2:56 PM - Compilation completed with 1 error and 0
>>> warnings in 595ms
>>> Error:[HelloIDEA]: java.lang.NoSuchMethodException:
>>> org.apache.flex.compiler.clients.MXMLJSC.(org.apache.
>>> flex.compiler.driver.IBackend)
>>>
>>> I followed the steps in these instructions that worked correctly with
>>> 0.7.0:
>>>
>>> 
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.a
>>>pache.org%2Fconfluence%2Fdisplay%2FFLEX%2FUsing%2BFlexJ=02%7C01%7C%
>>>7C0db52a1b085d40a0d99008d4c49f7cf7%7Cfa7b1b5a7b34438794aed2c178decee1%7C
>>>0%7C0%7C636349636715390181=SMfsugjsJKZI9AKay2Dn0qhk7srWdH%2BkTtrlo
>>>GXiw34%3D=0
>>> S+with+IntelliJ+IDEA
>>>
>>> I'm not very familiar with this part of the code, but it looks to me
>>>like
>>> the call to MxmlJSC.getCompilerInstance() can't find IBackend? Could
>>>it be
>>> that flex-compiler-oem.jar is missing something in its classpath?
>>>
>>> - Josh
>>>
>>
>>



RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread Allen YANG
Thanks, Yishay. I will look into these in the API reference.  Just created my 
first panel.
Somehow I only see the Apache Flex 4.14.0 API reference in 
http://people.apache.org/~pent/asdoc-flexjs/ when I search for FlexJS API 
reference. Hope this is correct page.
Regards,
Allen


-Original Message-
From: yishayw [mailto:yishayj...@hotmail.com]
Sent: Thursday, July 06, 2017 2:32 PM
To: dev@flex.apache.org
Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

I don't have code to share but as general pointers:

- use Panel instead of TitleWindow
- use UIUtils instead of PopupManager
- user HContainer instead of HBox

Hope this helps.



--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-question-about-porting-an-Adobe-Flex-3-project-to-HTML-JS-tp62698p62886.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.



Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir 
des informations sensibles et/ ou confidentielles ne devant pas être 
divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous 
recevez ce message par erreur), nous vous remercions de le notifier 
immédiatement à son expéditeur, et de détruire ce message. Toute copie, 
divulgation, modification, utilisation ou diffusion, non autorisée, directe ou 
indirecte, de tout ou partie de ce message, est strictement interdite.


This e-mail, and any document attached hereby, may contain confidential and/or 
privileged information. If you are not the intended recipient (or have received 
this e-mail in error) please notify the sender immediately and destroy this 
e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution 
or other use of the material or parts thereof is strictly forbidden.


Re: [FlexJS] technical debt

2017-07-06 Thread Dave Fisher
Hi Alex,

> On Jul 6, 2017, at 10:36 AM, Alex Harui  wrote:
> 
> IMO, even more important than technical debt is a test system and tests to 
> make sure any changes don't break anything.

That would include any changes to fix “technical debt”.

> 
> I could be wrong, but I think our customers would rather have us spend our 
> time and energy on missing features like AMF right now.

I think that users or consumers is a better term than customers.

Missing features is always great.

If Justin’s itch is technical debt then I think he should at least follow a 
wiki approach and also address Harbs comment else thread. If he has people from 
his company do it then that is great too.

Didn’t the blind change from “==“ to “===“ already cause tests to break?

Best Regards,
Dave

> 
> My 2 cents,
> -Alex
> 
> From: Dave Fisher >
> Reply-To: "dev@flex.apache.org" 
> >
> Date: Thursday, July 6, 2017 at 9:24 AM
> To: "dev@flex.apache.org" 
> >
> Subject: Re: [FlexJS] technical debt
> 
> Hi Justin,
> 
> (I missed your double reply until I reviewed the thread before sending. This 
> caused me to remove part of this email.)
> 
> I looked at some of the major and minor Code Smells. I think that rather than 
> accepting the ActionScript conventions that Sonar provides that most of these 
> can be eliminated by resetting the rules to match this project’s ideas about 
> how Flex smells.
> 
> - Do we care about code being commented out? I think not.
> - Does a semicolon matter?
> - Is “:Object” really a critical issue?
> - Is refactoring “complexity” really a huge problem - Function has a 
> complexity of 14 which is greater than 10 authorized.
> - This one: Replace == with === : has been discussed and I think your making 
> the change suggested broke things.
> 
> Probably the best approach would be to collect these into a wiki page and 
> then determine what conventions developers consider important. Once that is 
> done change the sonar configuration and show true technical debt. I think 
> that this is much less risky to the project and much less distraction to the 
> team.
> 
> Only once Sonar rules are properly tuned is it a powerful tool for assuring 
> code quality. Until then it can be a nearly useless sink for scarce developer 
> time and a chance for “hair on fire” concern over “technical debt”.
> 
> I agree that like it is it could be a measure of usefulness for new 
> developers in a commercial situation.
> 
> Regards,
> Dave
> 
> On Jul 5, 2017, at 11:53 PM, Justin Mclean 
> > wrote:
> 
> Hi,
> 
> Dave I assume the case statement issue you referring to is is the last one in 
> this list [1]. It not a bug but style wise it’s a little odd and probably 
> should still be fixed.
> 
> Thanks,
> Justin
> 
> 1. 
> https://builds.apache.org/analysis/component_issues/index?id=org.apache.flex.flexjs.framework%3Aflexjs-framework-parent#types=CODE_SMELL|severities=CRITICAL
> 



signature.asc
Description: Message signed with OpenPGP


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread piotrz
Josh,

That's great news! :) I will try it out once falcon build on server. It look
like confluence need to be updated as well. Point 9 seems to be out of date
in the instruction.

Thanks,
Piotr





-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-0-8-0-not-working-in-IntelliJ-IDEA-tp62848p62887.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.


RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread yishayw
I don't have code to share but as general pointers:

- use Panel instead of TitleWindow
- use UIUtils instead of PopupManager
- user HContainer instead of HBox

Hope this helps.



--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-question-about-porting-an-Adobe-Flex-3-project-to-HTML-JS-tp62698p62886.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
Okay, I made a commit that seems to get things working in IntelliJ IDEA
again. It looks like MxmlJSC and CompJSC in flex-compiler-oem.jar no longer
need to create the backend manually, and MXMLJSC or COMPJSC can figure out
what to do automatically based on the value of -targets now.

I was able to successfully build some projects in IntelliJ with -targets
set to JSFlex, SWF, and also JS.

- Josh

On Thu, Jul 6, 2017 at 11:21 AM, Josh Tynjala  wrote:

> The problem looks to be related to this line:
>
> compiler = COMPILER.getDeclaredConstructor(IBackend.class).newInstance(
> backend);
>
> It's looking for a constructor on MXMLJSC (not to be confused with
> MxmlJSC) that takes an IBackend as a parameter. There is no longer a
> constructor like that in 0.8.0. If I understand the dual changes correctly,
> MXMLJSC now automatically creates an IBackend based on the -targets value.
> It looks like this code does indeed still need changes to support dual.
>
> - Josh
>
>
> On Wed, Jul 5, 2017 at 3:09 PM, Josh Tynjala 
> wrote:
>
>> I'm trying to create a new FlexJS 0.8.0 project in IntelliJ IDEA, and I'm
>> getting the following output when I try to build the project:
>>
>> Information:[HelloIDEA]: Starting Flex compiler:
>> "/Applications/IntelliJ IDEA.app/Contents/jdk/Contents/Home/jre/bin/java"
>> -Dapplication.home=/Users/joshtynjala/Development/Flex/sdks/flexjs-0.8.0
>> -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Duser.language=en
>> -Duser.region=en -Xmx512m -classpath "/Applications/IntelliJ
>> IDEA.app/Contents/plugins/flex/lib/idea-flex-compiler-fix.jar:/Applications/IntelliJ
>> IDEA.app/Contents/plugins/flex/lib/flex-compiler.jar:/Users/
>> joshtynjala/Development/Flex/sdks/flexjs-0.8.0/lib/flex-compiler-oem.jar"
>> com.intellij.flex.compiler.FlexCompiler 54900
>> Information:[HelloIDEA]: mxmlc -load-config=/Users/joshtynjal
>> a/Library/Caches/IntelliJIdea2017.1/compile-server/
>> helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
>> -load-config+=/Users/joshtynjala/Development/Flex/sdks/
>> flexjs-0.8.0/ide/IDEA/intellij-config.xml
>> Information:[HelloIDEA]: unknown error
>> Information:[HelloIDEA]: at java.lang.Class.getConstructor
>> 0(Class.java:3082)
>> Information:[HelloIDEA]: at java.lang.Class.getDeclaredCon
>> structor(Class.java:2178)
>> Information:[HelloIDEA]: at flex2.tools.MxmlJSC.getCompile
>> rInstance(MxmlJSC.java:48)
>> Information:[HelloIDEA]: at flex2.tools.MxmlJSC.execute(MxmlJSC.java:89)
>> Information:[HelloIDEA]: at flex2.tools.Tool.compile(Tool.java:68)
>> Information:[HelloIDEA]: at flex2.tools.Mxmlc.mxmlc(Mxmlc.java:73)
>> Information:[HelloIDEA]: at com.intellij.flex.compiler.fle
>> x4.Flex4Handler.compileSwf(Flex4Handler.java:81)
>> Information:[HelloIDEA]: at com.intellij.flex.compiler.Com
>> pilationThread.run(CompilationThread.java:48)
>> Information:[HelloIDEA]: Compilation failed
>> Information:7/5/17, 2:56 PM - Compilation completed with 1 error and 0
>> warnings in 595ms
>> Error:[HelloIDEA]: java.lang.NoSuchMethodException:
>> org.apache.flex.compiler.clients.MXMLJSC.(org.apache.
>> flex.compiler.driver.IBackend)
>>
>> I followed the steps in these instructions that worked correctly with
>> 0.7.0:
>>
>> https://cwiki.apache.org/confluence/display/FLEX/Using+FlexJ
>> S+with+IntelliJ+IDEA
>>
>> I'm not very familiar with this part of the code, but it looks to me like
>> the call to MxmlJSC.getCompilerInstance() can't find IBackend? Could it be
>> that flex-compiler-oem.jar is missing something in its classpath?
>>
>> - Josh
>>
>
>


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
By the way, I'd like to know what kind of extra problems you are seeing (in
another thread please) because that's not an issue I've encountered with
VSCode.

- Josh

On Thu, Jul 6, 2017 at 11:16 AM, Harbs  wrote:

> VS Code is reporting all kinds of issues that are not problems since the
> switch to dual. Maybe that’s related as well?
>
> > On Jul 6, 2017, at 9:06 PM, Josh Tynjala  wrote:
> >
> > I don't see why -targets wouldn't work when it works elsewhere, but I
> just
> > tried -compiler.targets too, and that also failed.
> >
> > Looking at the source code for flex2.tools.MxmlJSC, I see that it's still
> > checking for the -js-output-type option, and it isn't trying to find
> > -targets at all. Did you forget to update this class to support the dual
> > changes?
> >
> > - Josh
> >
> > On Thu, Jul 6, 2017 at 10:44 AM, Alex Harui 
> > wrote:
> >
> >> What does IJ do with additional compiler options?  Does it put them in
> one
> >> of the .xml files?  I can see from the original post that IJ seems to be
> >> using:
> >>
> >> -load-config=/Users/joshtynjala/Library/Caches/
> >> IntelliJIdea2017.1/compile-s
> >> erver/helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-
> B028A5AE-12E86E20.xml
> >> -load-config+=/Users/joshtynjala/Development/Flex/
> >> sdks/flexjs-0.8.0/ide/IDE
> >> A/intellij-config.xml
> >>
> >>
> >> Did the new output log of compiler options reflect that it recognized
> that
> >> option?  Also, I'm not sure that -targets will work, it might have to be
> >> -compiler.targets
> >>
> >> HTH,
> >> -Alex
> >>
> >> On 7/6/17, 9:23 AM, "Josh Tynjala"  wrote:
> >>
> >>> I tried specifying -targets=JSFlex in the additional compiler options,
> but
> >>> it made no difference.
> >>>
> >>> - Josh
> >>>
> >>> On Thu, Jul 6, 2017 at 9:09 AM, Alex Harui 
> >>> wrote:
> >>>
>  I suspect the issue is that IJ dictates all of the settings and
> doesn't
>  use flex-config.xml, and thus no targets are being specified.  Is
> there
>  a
>  way to specify compiler.targets in additional compiler options in IJ?
>  There is in FB.
> 
>  -Alex
> 
>  On 7/6/17, 8:34 AM, "Josh Tynjala"  wrote:
> 
> > While full support for FlexJS in IntelliJ IDEA would be great, I
> think
> > it's
> > critical that we fix this issue to at least get back to the baseline
> we
> > had
> > in 0.7. A FlexJS project required a little bit of extra configuration
>  with
> > 0.7, but at least we could get the compiler to work inside IntellIJ.
> >
> > Many Flex/ActionScript developers use IntelliJ, and while I'd love to
> > encourage them to try VSCode, I think many prefer to take their first
> > steps
> > with FlexJS in an environment they already know. Having this stop
>  working
> > (especially when there are tutorials out there claiming it works) is
>  going
> > to turn people away.
> >
> > If we can fix this issue, I want to push a 0.8.1 update because I
> think
> > getting this working again is very, very important.
> >
> > - Josh
> >
> > On Thu, Jul 6, 2017 at 12:55 AM, piotrz 
>  wrote:
> >
> >> As I remember Chris get to the bottom of it and resolved it.
> >> Unfortunately
> >> after contacting with Jetbrains they refuse accept pull request with
>  fix
> >> and
> >> Chris dropped it. [1]
> >>
> >> I was thinking even then that if someone could fix it and store
>  version
> >> of
> >> plugin somewhere with fix it would be also HUGE, cause we could gain
> >> another
> >> IDE which support FlexJS.
> >>
> >> [1]
> >>
> >> https://na01.safelinks.protection.outlook.com/?url=
>  http%3A%2F%2Fapache-fl
> >> ex-development.247.n4.nabble=02%7C01%7C%
>  7C5f4eb274ee54460f044608
> >> d4c484a74e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>  7C63634952143892612
> >> 4=3U%2FcqwvO4C8OtATk9khadreh99KxUUf
> sfJYiEptjJzs%3D=0.
> >> com/FlexJS-Step-by-step-h-baby-td58710.html
> >>
> >> Thanks,
> >> Piotr
> >>
> >>
> >>
> >> -
> >> Apache Flex PMC
> >> piotrzarzyck...@gmail.com
> >> --
> >> View this message in context: http://apache-flex-
> >> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
> >> in-IntelliJ-IDEA-tp62848p62862.html
> >> Sent from the Apache Flex Development mailing list archive at
> >> Nabble.com.
> >>
> 
> 
> >>
> >>
>
>


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
The problem looks to be related to this line:

compiler =
COMPILER.getDeclaredConstructor(IBackend.class).newInstance(backend);

It's looking for a constructor on MXMLJSC (not to be confused with MxmlJSC)
that takes an IBackend as a parameter. There is no longer a constructor
like that in 0.8.0. If I understand the dual changes correctly, MXMLJSC now
automatically creates an IBackend based on the -targets value. It looks
like this code does indeed still need changes to support dual.

- Josh

On Wed, Jul 5, 2017 at 3:09 PM, Josh Tynjala  wrote:

> I'm trying to create a new FlexJS 0.8.0 project in IntelliJ IDEA, and I'm
> getting the following output when I try to build the project:
>
> Information:[HelloIDEA]: Starting Flex compiler:
> "/Applications/IntelliJ IDEA.app/Contents/jdk/Contents/Home/jre/bin/java"
> -Dapplication.home=/Users/joshtynjala/Development/Flex/sdks/flexjs-0.8.0
> -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Duser.language=en
> -Duser.region=en -Xmx512m -classpath "/Applications/IntelliJ
> IDEA.app/Contents/plugins/flex/lib/idea-flex-compiler-fix.jar:/Applications/IntelliJ
> IDEA.app/Contents/plugins/flex/lib/flex-compiler.jar:/
> Users/joshtynjala/Development/Flex/sdks/flexjs-0.8.0/lib/flex-compiler-oem.jar"
> com.intellij.flex.compiler.FlexCompiler 54900
> Information:[HelloIDEA]: mxmlc -load-config=/Users/
> joshtynjala/Library/Caches/IntelliJIdea2017.1/compile-
> server/helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
> -load-config+=/Users/joshtynjala/Development/Flex/
> sdks/flexjs-0.8.0/ide/IDEA/intellij-config.xml
> Information:[HelloIDEA]: unknown error
> Information:[HelloIDEA]: at java.lang.Class.getConstructor0(Class.java:
> 3082)
> Information:[HelloIDEA]: at java.lang.Class.getDeclaredConstructor(Class.
> java:2178)
> Information:[HelloIDEA]: at flex2.tools.MxmlJSC.
> getCompilerInstance(MxmlJSC.java:48)
> Information:[HelloIDEA]: at flex2.tools.MxmlJSC.execute(MxmlJSC.java:89)
> Information:[HelloIDEA]: at flex2.tools.Tool.compile(Tool.java:68)
> Information:[HelloIDEA]: at flex2.tools.Mxmlc.mxmlc(Mxmlc.java:73)
> Information:[HelloIDEA]: at com.intellij.flex.compiler.
> flex4.Flex4Handler.compileSwf(Flex4Handler.java:81)
> Information:[HelloIDEA]: at com.intellij.flex.compiler.
> CompilationThread.run(CompilationThread.java:48)
> Information:[HelloIDEA]: Compilation failed
> Information:7/5/17, 2:56 PM - Compilation completed with 1 error and 0
> warnings in 595ms
> Error:[HelloIDEA]: java.lang.NoSuchMethodException:
> org.apache.flex.compiler.clients.MXMLJSC.(org.
> apache.flex.compiler.driver.IBackend)
>
> I followed the steps in these instructions that worked correctly with
> 0.7.0:
>
> https://cwiki.apache.org/confluence/display/FLEX/Using+
> FlexJS+with+IntelliJ+IDEA
>
> I'm not very familiar with this part of the code, but it looks to me like
> the call to MxmlJSC.getCompilerInstance() can't find IBackend? Could it be
> that flex-compiler-oem.jar is missing something in its classpath?
>
> - Josh
>


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
The issue with IntelliJ IDEA on seems to be related to
flex-compiler-oem.jar, which VSCode doesn't use at all.

- Josh

On Thu, Jul 6, 2017 at 11:16 AM, Harbs  wrote:

> VS Code is reporting all kinds of issues that are not problems since the
> switch to dual. Maybe that’s related as well?
>
> > On Jul 6, 2017, at 9:06 PM, Josh Tynjala  wrote:
> >
> > I don't see why -targets wouldn't work when it works elsewhere, but I
> just
> > tried -compiler.targets too, and that also failed.
> >
> > Looking at the source code for flex2.tools.MxmlJSC, I see that it's still
> > checking for the -js-output-type option, and it isn't trying to find
> > -targets at all. Did you forget to update this class to support the dual
> > changes?
> >
> > - Josh
> >
> > On Thu, Jul 6, 2017 at 10:44 AM, Alex Harui 
> > wrote:
> >
> >> What does IJ do with additional compiler options?  Does it put them in
> one
> >> of the .xml files?  I can see from the original post that IJ seems to be
> >> using:
> >>
> >> -load-config=/Users/joshtynjala/Library/Caches/
> >> IntelliJIdea2017.1/compile-s
> >> erver/helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-
> B028A5AE-12E86E20.xml
> >> -load-config+=/Users/joshtynjala/Development/Flex/
> >> sdks/flexjs-0.8.0/ide/IDE
> >> A/intellij-config.xml
> >>
> >>
> >> Did the new output log of compiler options reflect that it recognized
> that
> >> option?  Also, I'm not sure that -targets will work, it might have to be
> >> -compiler.targets
> >>
> >> HTH,
> >> -Alex
> >>
> >> On 7/6/17, 9:23 AM, "Josh Tynjala"  wrote:
> >>
> >>> I tried specifying -targets=JSFlex in the additional compiler options,
> but
> >>> it made no difference.
> >>>
> >>> - Josh
> >>>
> >>> On Thu, Jul 6, 2017 at 9:09 AM, Alex Harui 
> >>> wrote:
> >>>
>  I suspect the issue is that IJ dictates all of the settings and
> doesn't
>  use flex-config.xml, and thus no targets are being specified.  Is
> there
>  a
>  way to specify compiler.targets in additional compiler options in IJ?
>  There is in FB.
> 
>  -Alex
> 
>  On 7/6/17, 8:34 AM, "Josh Tynjala"  wrote:
> 
> > While full support for FlexJS in IntelliJ IDEA would be great, I
> think
> > it's
> > critical that we fix this issue to at least get back to the baseline
> we
> > had
> > in 0.7. A FlexJS project required a little bit of extra configuration
>  with
> > 0.7, but at least we could get the compiler to work inside IntellIJ.
> >
> > Many Flex/ActionScript developers use IntelliJ, and while I'd love to
> > encourage them to try VSCode, I think many prefer to take their first
> > steps
> > with FlexJS in an environment they already know. Having this stop
>  working
> > (especially when there are tutorials out there claiming it works) is
>  going
> > to turn people away.
> >
> > If we can fix this issue, I want to push a 0.8.1 update because I
> think
> > getting this working again is very, very important.
> >
> > - Josh
> >
> > On Thu, Jul 6, 2017 at 12:55 AM, piotrz 
>  wrote:
> >
> >> As I remember Chris get to the bottom of it and resolved it.
> >> Unfortunately
> >> after contacting with Jetbrains they refuse accept pull request with
>  fix
> >> and
> >> Chris dropped it. [1]
> >>
> >> I was thinking even then that if someone could fix it and store
>  version
> >> of
> >> plugin somewhere with fix it would be also HUGE, cause we could gain
> >> another
> >> IDE which support FlexJS.
> >>
> >> [1]
> >>
> >> https://na01.safelinks.protection.outlook.com/?url=
>  http%3A%2F%2Fapache-fl
> >> ex-development.247.n4.nabble=02%7C01%7C%
>  7C5f4eb274ee54460f044608
> >> d4c484a74e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>  7C63634952143892612
> >> 4=3U%2FcqwvO4C8OtATk9khadreh99KxUUf
> sfJYiEptjJzs%3D=0.
> >> com/FlexJS-Step-by-step-h-baby-td58710.html
> >>
> >> Thanks,
> >> Piotr
> >>
> >>
> >>
> >> -
> >> Apache Flex PMC
> >> piotrzarzyck...@gmail.com
> >> --
> >> View this message in context: http://apache-flex-
> >> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
> >> in-IntelliJ-IDEA-tp62848p62862.html
> >> Sent from the Apache Flex Development mailing list archive at
> >> Nabble.com.
> >>
> 
> 
> >>
> >>
>
>


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Harbs
VS Code is reporting all kinds of issues that are not problems since the switch 
to dual. Maybe that’s related as well?

> On Jul 6, 2017, at 9:06 PM, Josh Tynjala  wrote:
> 
> I don't see why -targets wouldn't work when it works elsewhere, but I just
> tried -compiler.targets too, and that also failed.
> 
> Looking at the source code for flex2.tools.MxmlJSC, I see that it's still
> checking for the -js-output-type option, and it isn't trying to find
> -targets at all. Did you forget to update this class to support the dual
> changes?
> 
> - Josh
> 
> On Thu, Jul 6, 2017 at 10:44 AM, Alex Harui 
> wrote:
> 
>> What does IJ do with additional compiler options?  Does it put them in one
>> of the .xml files?  I can see from the original post that IJ seems to be
>> using:
>> 
>> -load-config=/Users/joshtynjala/Library/Caches/
>> IntelliJIdea2017.1/compile-s
>> erver/helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
>> -load-config+=/Users/joshtynjala/Development/Flex/
>> sdks/flexjs-0.8.0/ide/IDE
>> A/intellij-config.xml
>> 
>> 
>> Did the new output log of compiler options reflect that it recognized that
>> option?  Also, I'm not sure that -targets will work, it might have to be
>> -compiler.targets
>> 
>> HTH,
>> -Alex
>> 
>> On 7/6/17, 9:23 AM, "Josh Tynjala"  wrote:
>> 
>>> I tried specifying -targets=JSFlex in the additional compiler options, but
>>> it made no difference.
>>> 
>>> - Josh
>>> 
>>> On Thu, Jul 6, 2017 at 9:09 AM, Alex Harui 
>>> wrote:
>>> 
 I suspect the issue is that IJ dictates all of the settings and doesn't
 use flex-config.xml, and thus no targets are being specified.  Is there
 a
 way to specify compiler.targets in additional compiler options in IJ?
 There is in FB.
 
 -Alex
 
 On 7/6/17, 8:34 AM, "Josh Tynjala"  wrote:
 
> While full support for FlexJS in IntelliJ IDEA would be great, I think
> it's
> critical that we fix this issue to at least get back to the baseline we
> had
> in 0.7. A FlexJS project required a little bit of extra configuration
 with
> 0.7, but at least we could get the compiler to work inside IntellIJ.
> 
> Many Flex/ActionScript developers use IntelliJ, and while I'd love to
> encourage them to try VSCode, I think many prefer to take their first
> steps
> with FlexJS in an environment they already know. Having this stop
 working
> (especially when there are tutorials out there claiming it works) is
 going
> to turn people away.
> 
> If we can fix this issue, I want to push a 0.8.1 update because I think
> getting this working again is very, very important.
> 
> - Josh
> 
> On Thu, Jul 6, 2017 at 12:55 AM, piotrz 
 wrote:
> 
>> As I remember Chris get to the bottom of it and resolved it.
>> Unfortunately
>> after contacting with Jetbrains they refuse accept pull request with
 fix
>> and
>> Chris dropped it. [1]
>> 
>> I was thinking even then that if someone could fix it and store
 version
>> of
>> plugin somewhere with fix it would be also HUGE, cause we could gain
>> another
>> IDE which support FlexJS.
>> 
>> [1]
>> 
>> https://na01.safelinks.protection.outlook.com/?url=
 http%3A%2F%2Fapache-fl
>> ex-development.247.n4.nabble=02%7C01%7C%
 7C5f4eb274ee54460f044608
>> d4c484a74e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
 7C63634952143892612
>> 4=3U%2FcqwvO4C8OtATk9khadreh99KxUUfsfJYiEptjJzs%3D=0.
>> com/FlexJS-Step-by-step-h-baby-td58710.html
>> 
>> Thanks,
>> Piotr
>> 
>> 
>> 
>> -
>> Apache Flex PMC
>> piotrzarzyck...@gmail.com
>> --
>> View this message in context: http://apache-flex-
>> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
>> in-IntelliJ-IDEA-tp62848p62862.html
>> Sent from the Apache Flex Development mailing list archive at
>> Nabble.com.
>> 
 
 
>> 
>> 



Re: [FlexJS] technical debt

2017-07-06 Thread Harbs
A large percentage of the complaints are inaccurate. The reason the technical 
debt increased is largely because of the new TLF code.

Who made these rules and how do we change them? We can make it look much better 
by just changing some of the rules…

Harbs

> On Jul 6, 2017, at 2:24 AM, Justin Mclean  wrote:
> 
> Hi,
> 
> If you take a look at this [1] you see that technical debt increased a bit 
> between the 0.8 and 0.9 releases. It would be good if we could reduce this.
> 
> While Sonar cube isn’t perfect, probably needs some tuning, and there are a 
> number of false positives in there it is trying to tell us something.
> 
> Thanks,
> Justin
> 
> 1. https://builds.apache.org/analysis/overview?id=20942



Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
I don't see why -targets wouldn't work when it works elsewhere, but I just
tried -compiler.targets too, and that also failed.

Looking at the source code for flex2.tools.MxmlJSC, I see that it's still
checking for the -js-output-type option, and it isn't trying to find
-targets at all. Did you forget to update this class to support the dual
changes?

- Josh

On Thu, Jul 6, 2017 at 10:44 AM, Alex Harui 
wrote:

> What does IJ do with additional compiler options?  Does it put them in one
> of the .xml files?  I can see from the original post that IJ seems to be
> using:
>
> -load-config=/Users/joshtynjala/Library/Caches/
> IntelliJIdea2017.1/compile-s
> erver/helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
> -load-config+=/Users/joshtynjala/Development/Flex/
> sdks/flexjs-0.8.0/ide/IDE
> A/intellij-config.xml
>
>
> Did the new output log of compiler options reflect that it recognized that
> option?  Also, I'm not sure that -targets will work, it might have to be
> -compiler.targets
>
> HTH,
> -Alex
>
> On 7/6/17, 9:23 AM, "Josh Tynjala"  wrote:
>
> >I tried specifying -targets=JSFlex in the additional compiler options, but
> >it made no difference.
> >
> >- Josh
> >
> >On Thu, Jul 6, 2017 at 9:09 AM, Alex Harui 
> >wrote:
> >
> >> I suspect the issue is that IJ dictates all of the settings and doesn't
> >> use flex-config.xml, and thus no targets are being specified.  Is there
> >>a
> >> way to specify compiler.targets in additional compiler options in IJ?
> >> There is in FB.
> >>
> >> -Alex
> >>
> >> On 7/6/17, 8:34 AM, "Josh Tynjala"  wrote:
> >>
> >> >While full support for FlexJS in IntelliJ IDEA would be great, I think
> >> >it's
> >> >critical that we fix this issue to at least get back to the baseline we
> >> >had
> >> >in 0.7. A FlexJS project required a little bit of extra configuration
> >>with
> >> >0.7, but at least we could get the compiler to work inside IntellIJ.
> >> >
> >> >Many Flex/ActionScript developers use IntelliJ, and while I'd love to
> >> >encourage them to try VSCode, I think many prefer to take their first
> >> >steps
> >> >with FlexJS in an environment they already know. Having this stop
> >>working
> >> >(especially when there are tutorials out there claiming it works) is
> >>going
> >> >to turn people away.
> >> >
> >> >If we can fix this issue, I want to push a 0.8.1 update because I think
> >> >getting this working again is very, very important.
> >> >
> >> >- Josh
> >> >
> >> >On Thu, Jul 6, 2017 at 12:55 AM, piotrz 
> >> wrote:
> >> >
> >> >> As I remember Chris get to the bottom of it and resolved it.
> >> >>Unfortunately
> >> >> after contacting with Jetbrains they refuse accept pull request with
> >>fix
> >> >> and
> >> >> Chris dropped it. [1]
> >> >>
> >> >> I was thinking even then that if someone could fix it and store
> >>version
> >> >>of
> >> >> plugin somewhere with fix it would be also HUGE, cause we could gain
> >> >> another
> >> >> IDE which support FlexJS.
> >> >>
> >> >> [1]
> >> >>
> >> >>https://na01.safelinks.protection.outlook.com/?url=
> >> http%3A%2F%2Fapache-fl
> >> >>ex-development.247.n4.nabble=02%7C01%7C%
> >> 7C5f4eb274ee54460f044608
> >> >>d4c484a74e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> >> 7C63634952143892612
> >> >>4=3U%2FcqwvO4C8OtATk9khadreh99KxUUfsfJYiEptjJzs%3D=0.
> >> >> com/FlexJS-Step-by-step-h-baby-td58710.html
> >> >>
> >> >> Thanks,
> >> >> Piotr
> >> >>
> >> >>
> >> >>
> >> >> -
> >> >> Apache Flex PMC
> >> >> piotrzarzyck...@gmail.com
> >> >> --
> >> >> View this message in context: http://apache-flex-
> >> >> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
> >> >> in-IntelliJ-IDEA-tp62848p62862.html
> >> >> Sent from the Apache Flex Development mailing list archive at
> >> >>Nabble.com.
> >> >>
> >>
> >>
>
>


RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread Allen YANG
Hi PKumar,
Please share with me the examples on title windows, grid, panel and other 
controls; I need to convert them from a Flex 3 project built on Flash Builder 
3.6 to HTML+JS built with FlexJS 0.8.0 in my project.
Regards,
Allen

-Original Message-
From: PKumar [mailto:prashaku...@gmail.com]
Sent: Thursday, July 06, 2017 11:08 AM
To: dev@flex.apache.org
Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

I will check the example shared. But if need more examples on title window, 
grid, panel , list and other controls. Just let me know I will share with you 
on GitHub.

On 06-Jul-2017 7:21 PM, "allenyyang [via Apache Flex Development]" <
ml+s247n62863...@n4.nabble.com> wrote:

> Hi PKumar,
>
> You are correct that I don't need to have Maven or Ant installed if I want
> to just use Flash Builder as the IDE.   was able to use Flash Builder 4.7
> and FlexJS to build and run the examples in the wiki successfully.  I
> just could not use FB to build Yishay's demo_for_presentation project
> successfully.  But I desired to get this demo working because the demo
> program is beyond "Hello World".  I just didn’t know that it would
> takes me longer time than I expected and still not fully getting it to
> work the way it should.
> After trying both FB and VS Code+Maven for a while, I think Flash
> Builder's error messages tend to be more cryptic.
>
> Hi Yishay,
> I followed Alex's suggestions and did the following steps to
> demo_for_presentation project:
> 1) In Project -> Properties -> Flex Build Path, removed airglobal,
> Core.swc and Basic.swc.
> 2) Shut down Flash Builder
> 3) Open the .actionScriptProperties file in a text editor and remove
> these two lines from excludedEntries:
>  path="${PROJECT_FRAMEWORKS}/libs/core.swc" useDefaultLinkType="false"/>
>path="${PROJECT_FRAMEWORKS}/libs/Basic.swc"
> useDefaultLinkType="false"/>
> 4) Use the file system to remove bin folder from the project folder.
> 5) Restart Flash Builder, clean and rebuild the project.
>
> These changes allowed me to build demo_for_presentation. And I now can
> run it by double-clicking index.html in both bin/js-debug and
> bin/js-release folders.
> But I am not sure that it runs correctly because the screen display
> always look like the following:
>
> boring
> my comp 0
> Button1 Button2
>
> Clicking Button1 should increment the count, but it doesn't change the
> display at all; and I believe clicking Button2 doesn't do anything
> according to the source code.  Could you help me  to correct the
> behavior of the demo program?
> I exported the fpx file on my Dropbox: https://www.dropbox.com/s/
> zknv0tj5kvvioph/demo_for_presentation.fxp?dl=0
>
> Hi Team:
> My original purpose of learning FlexJS is to convert my Flex 3 project
> so it will run without Flash Player. I am still far away from the
> goal.  If anyone could suggest what to do to rewrite my MXMLs that use
> TitleWindow and HBox that will be quite appreciated.
>
> Best regards,
> Allen
>
>
> -Original Message-
> From: PKumar [mailto:[hidden email]
> ]
> Sent: Thursday, July 06, 2017 2:26 AM
> To: [hidden email]
> 
> Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project
> to
> HTML+JS
>
> If you want to use FlexJS with Flash Builder 4.7 then no need to
> install  Ant and maven.
>
> just download latest version of FlexJs via SDK installer and add new
> FlexJS SDK under Flash Buildrler4.7 as you add regular flex SDK.
>
> After SDK setup . You need to import runtime command into Flash
> Builder so that u can compile Flex JS project.
>
> Apache Flex wiki have nice information on this. Please refer wiki.
>
> On 06-Jul-2017 5:17 AM, "allenyyang [via Apache Flex Development]" <
> [hidden email] >
> wrote:
>
> > Hi Yishay,
> >
> > After trying for quite a while, I found that we might be talking
> > about two different things.  I informed Piotr that was able to use
> > Maven and VS Code to build and run Piotr's "Hello World" example 
> > successfully.
> > But I was unable to successfully run demo_for_presentation using
> > Flash
> Builder 4.7.
> > You might be thinking that I was talking about being able to use VS
> > Code and Maven to build and run demo_for_presentation successfully;
> > which is not the case for me yet.
> >
> > So I went back to your email on 07/01 and I installed Ant and added
> > it to PATH; I also set ANT_HOME to where I installed Ant:
> > C:\apache-ant-1.10.1; and already have JAVA_HOME to its installation
> > folder: C:\Program
> > Files\Java\jdk1.8.0_131
> > At the folder demo_for_presentation where build.xml file resides, I
> > typed 'ant' in the cmd window.  I got the following error:
> > 
> > --
> > 
> >
> > Buildfile: C:\Projects\demo_for_presentation\build.xml
> >
> > 

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Alex Harui
What does IJ do with additional compiler options?  Does it put them in one
of the .xml files?  I can see from the original post that IJ seems to be
using:

-load-config=/Users/joshtynjala/Library/Caches/IntelliJIdea2017.1/compile-s
erver/helloidea_6d5abd99/_temp_/IntelliJ_IDEA/idea-B028A5AE-12E86E20.xml
-load-config+=/Users/joshtynjala/Development/Flex/sdks/flexjs-0.8.0/ide/IDE
A/intellij-config.xml


Did the new output log of compiler options reflect that it recognized that
option?  Also, I'm not sure that -targets will work, it might have to be
-compiler.targets

HTH,
-Alex

On 7/6/17, 9:23 AM, "Josh Tynjala"  wrote:

>I tried specifying -targets=JSFlex in the additional compiler options, but
>it made no difference.
>
>- Josh
>
>On Thu, Jul 6, 2017 at 9:09 AM, Alex Harui 
>wrote:
>
>> I suspect the issue is that IJ dictates all of the settings and doesn't
>> use flex-config.xml, and thus no targets are being specified.  Is there
>>a
>> way to specify compiler.targets in additional compiler options in IJ?
>> There is in FB.
>>
>> -Alex
>>
>> On 7/6/17, 8:34 AM, "Josh Tynjala"  wrote:
>>
>> >While full support for FlexJS in IntelliJ IDEA would be great, I think
>> >it's
>> >critical that we fix this issue to at least get back to the baseline we
>> >had
>> >in 0.7. A FlexJS project required a little bit of extra configuration
>>with
>> >0.7, but at least we could get the compiler to work inside IntellIJ.
>> >
>> >Many Flex/ActionScript developers use IntelliJ, and while I'd love to
>> >encourage them to try VSCode, I think many prefer to take their first
>> >steps
>> >with FlexJS in an environment they already know. Having this stop
>>working
>> >(especially when there are tutorials out there claiming it works) is
>>going
>> >to turn people away.
>> >
>> >If we can fix this issue, I want to push a 0.8.1 update because I think
>> >getting this working again is very, very important.
>> >
>> >- Josh
>> >
>> >On Thu, Jul 6, 2017 at 12:55 AM, piotrz 
>> wrote:
>> >
>> >> As I remember Chris get to the bottom of it and resolved it.
>> >>Unfortunately
>> >> after contacting with Jetbrains they refuse accept pull request with
>>fix
>> >> and
>> >> Chris dropped it. [1]
>> >>
>> >> I was thinking even then that if someone could fix it and store
>>version
>> >>of
>> >> plugin somewhere with fix it would be also HUGE, cause we could gain
>> >> another
>> >> IDE which support FlexJS.
>> >>
>> >> [1]
>> >>
>> >>https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fapache-fl
>> >>ex-development.247.n4.nabble=02%7C01%7C%
>> 7C5f4eb274ee54460f044608
>> >>d4c484a74e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>> 7C63634952143892612
>> >>4=3U%2FcqwvO4C8OtATk9khadreh99KxUUfsfJYiEptjJzs%3D=0.
>> >> com/FlexJS-Step-by-step-h-baby-td58710.html
>> >>
>> >> Thanks,
>> >> Piotr
>> >>
>> >>
>> >>
>> >> -
>> >> Apache Flex PMC
>> >> piotrzarzyck...@gmail.com
>> >> --
>> >> View this message in context: http://apache-flex-
>> >> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
>> >> in-IntelliJ-IDEA-tp62848p62862.html
>> >> Sent from the Apache Flex Development mailing list archive at
>> >>Nabble.com.
>> >>
>>
>>



RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread Allen YANG
Hi Yishay,
After adding these to css, it works now.
Thanks  a lot!
Best Regards,
Allen

-Original Message-
From: yishayw [mailto:yishayj...@hotmail.com]
Sent: Thursday, July 06, 2017 1:15 PM
To: dev@flex.apache.org
Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

allenyyang wrote
> These changes allowed me to build demo_for_presentation. And I now can
> run it by double-clicking index.html in both bin/js-debug and
> bin/js-release folders.
> But I am not sure that it runs correctly because the screen display
> always look like the following:
>
> boring
> my comp 0
> Button1 Button2
>
> Clicking Button1 should increment the count, but it doesn't change the
> display at all; and I believe clicking Button2 doesn't do anything
> according to the source code.  Could you help me  to correct the
> behavior of the demo program?

It looks like version 0.8.0 requires you to specify the states implementation.

I added the line below to main.css and button1 now changes state as expected.

global {
IStatesImpl:
ClassReference("org.apache.flex.core.SimpleStatesImpl");
}

BTW, clicking on 'my comp 0' is what causes the increment.




--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-question-about-porting-an-Adobe-Flex-3-project-to-HTML-JS-tp62698p62874.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.



Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir 
des informations sensibles et/ ou confidentielles ne devant pas être 
divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous 
recevez ce message par erreur), nous vous remercions de le notifier 
immédiatement à son expéditeur, et de détruire ce message. Toute copie, 
divulgation, modification, utilisation ou diffusion, non autorisée, directe ou 
indirecte, de tout ou partie de ce message, est strictement interdite.


This e-mail, and any document attached hereby, may contain confidential and/or 
privileged information. If you are not the intended recipient (or have received 
this e-mail in error) please notify the sender immediately and destroy this 
e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution 
or other use of the material or parts thereof is strictly forbidden.


Re: [FlexJS] technical debt

2017-07-06 Thread Alex Harui
IMO, even more important than technical debt is a test system and tests to make 
sure any changes don't break anything.

I could be wrong, but I think our customers would rather have us spend our time 
and energy on missing features like AMF right now.

My 2 cents,
-Alex

From: Dave Fisher >
Reply-To: "dev@flex.apache.org" 
>
Date: Thursday, July 6, 2017 at 9:24 AM
To: "dev@flex.apache.org" 
>
Subject: Re: [FlexJS] technical debt

Hi Justin,

(I missed your double reply until I reviewed the thread before sending. This 
caused me to remove part of this email.)

I looked at some of the major and minor Code Smells. I think that rather than 
accepting the ActionScript conventions that Sonar provides that most of these 
can be eliminated by resetting the rules to match this project’s ideas about 
how Flex smells.

- Do we care about code being commented out? I think not.
- Does a semicolon matter?
- Is “:Object” really a critical issue?
- Is refactoring “complexity” really a huge problem - Function has a complexity 
of 14 which is greater than 10 authorized.
- This one: Replace == with === : has been discussed and I think your making 
the change suggested broke things.

Probably the best approach would be to collect these into a wiki page and then 
determine what conventions developers consider important. Once that is done 
change the sonar configuration and show true technical debt. I think that this 
is much less risky to the project and much less distraction to the team.

Only once Sonar rules are properly tuned is it a powerful tool for assuring 
code quality. Until then it can be a nearly useless sink for scarce developer 
time and a chance for “hair on fire” concern over “technical debt”.

I agree that like it is it could be a measure of usefulness for new developers 
in a commercial situation.

Regards,
Dave

On Jul 5, 2017, at 11:53 PM, Justin Mclean 
> wrote:

Hi,

Dave I assume the case statement issue you referring to is is the last one in 
this list [1]. It not a bug but style wise it’s a little odd and probably 
should still be fixed.

Thanks,
Justin

1. 
https://builds.apache.org/analysis/component_issues/index?id=org.apache.flex.flexjs.framework%3Aflexjs-framework-parent#types=CODE_SMELL|severities=CRITICAL



RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread yishayw
allenyyang wrote
> These changes allowed me to build demo_for_presentation. And I now can run
> it by double-clicking index.html in both bin/js-debug and bin/js-release
> folders.
> But I am not sure that it runs correctly because the screen display always
> look like the following:
> 
> boring
> my comp 0
> Button1 Button2
> 
> Clicking Button1 should increment the count, but it doesn't change the
> display at all; and I believe clicking Button2 doesn't do anything
> according to the source code.  Could you help me  to correct the behavior
> of the demo program?

It looks like version 0.8.0 requires you to specify the states
implementation.

I added the line below to main.css and button1 now changes state as
expected.

global {
IStatesImpl:   
ClassReference("org.apache.flex.core.SimpleStatesImpl");
}
 
BTW, clicking on 'my comp 0' is what causes the increment.




--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-question-about-porting-an-Adobe-Flex-3-project-to-HTML-JS-tp62698p62874.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: [FlexJS] technical debt

2017-07-06 Thread Dave Fisher
Hi Justin,

(I missed your double reply until I reviewed the thread before sending. This 
caused me to remove part of this email.)

I looked at some of the major and minor Code Smells. I think that rather than 
accepting the ActionScript conventions that Sonar provides that most of these 
can be eliminated by resetting the rules to match this project’s ideas about 
how Flex smells.

- Do we care about code being commented out? I think not.
- Does a semicolon matter?
- Is “:Object” really a critical issue?
- Is refactoring “complexity” really a huge problem - Function has a complexity 
of 14 which is greater than 10 authorized.
- This one: Replace == with === : has been discussed and I think your making 
the change suggested broke things.

Probably the best approach would be to collect these into a wiki page and then 
determine what conventions developers consider important. Once that is done 
change the sonar configuration and show true technical debt. I think that this 
is much less risky to the project and much less distraction to the team.

Only once Sonar rules are properly tuned is it a powerful tool for assuring 
code quality. Until then it can be a nearly useless sink for scarce developer 
time and a chance for “hair on fire” concern over “technical debt”.

I agree that like it is it could be a measure of usefulness for new developers 
in a commercial situation.

Regards,
Dave

> On Jul 5, 2017, at 11:53 PM, Justin Mclean  wrote:
> 
> Hi,
> 
> Dave I assume the case statement issue you referring to is is the last one in 
> this list [1]. It not a bug but style wise it’s a little odd and probably 
> should still be fixed.
> 
> Thanks,
> Justin
> 
> 1. 
> https://builds.apache.org/analysis/component_issues/index?id=org.apache.flex.flexjs.framework%3Aflexjs-framework-parent#types=CODE_SMELL|severities=CRITICAL



signature.asc
Description: Message signed with OpenPGP


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
I tried specifying -targets=JSFlex in the additional compiler options, but
it made no difference.

- Josh

On Thu, Jul 6, 2017 at 9:09 AM, Alex Harui  wrote:

> I suspect the issue is that IJ dictates all of the settings and doesn't
> use flex-config.xml, and thus no targets are being specified.  Is there a
> way to specify compiler.targets in additional compiler options in IJ?
> There is in FB.
>
> -Alex
>
> On 7/6/17, 8:34 AM, "Josh Tynjala"  wrote:
>
> >While full support for FlexJS in IntelliJ IDEA would be great, I think
> >it's
> >critical that we fix this issue to at least get back to the baseline we
> >had
> >in 0.7. A FlexJS project required a little bit of extra configuration with
> >0.7, but at least we could get the compiler to work inside IntellIJ.
> >
> >Many Flex/ActionScript developers use IntelliJ, and while I'd love to
> >encourage them to try VSCode, I think many prefer to take their first
> >steps
> >with FlexJS in an environment they already know. Having this stop working
> >(especially when there are tutorials out there claiming it works) is going
> >to turn people away.
> >
> >If we can fix this issue, I want to push a 0.8.1 update because I think
> >getting this working again is very, very important.
> >
> >- Josh
> >
> >On Thu, Jul 6, 2017 at 12:55 AM, piotrz 
> wrote:
> >
> >> As I remember Chris get to the bottom of it and resolved it.
> >>Unfortunately
> >> after contacting with Jetbrains they refuse accept pull request with fix
> >> and
> >> Chris dropped it. [1]
> >>
> >> I was thinking even then that if someone could fix it and store version
> >>of
> >> plugin somewhere with fix it would be also HUGE, cause we could gain
> >> another
> >> IDE which support FlexJS.
> >>
> >> [1]
> >>
> >>https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fapache-fl
> >>ex-development.247.n4.nabble=02%7C01%7C%
> 7C5f4eb274ee54460f044608
> >>d4c484a74e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C63634952143892612
> >>4=3U%2FcqwvO4C8OtATk9khadreh99KxUUfsfJYiEptjJzs%3D=0.
> >> com/FlexJS-Step-by-step-h-baby-td58710.html
> >>
> >> Thanks,
> >> Piotr
> >>
> >>
> >>
> >> -
> >> Apache Flex PMC
> >> piotrzarzyck...@gmail.com
> >> --
> >> View this message in context: http://apache-flex-
> >> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
> >> in-IntelliJ-IDEA-tp62848p62862.html
> >> Sent from the Apache Flex Development mailing list archive at
> >>Nabble.com.
> >>
>
>


Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Alex Harui
I suspect the issue is that IJ dictates all of the settings and doesn't
use flex-config.xml, and thus no targets are being specified.  Is there a
way to specify compiler.targets in additional compiler options in IJ?
There is in FB.

-Alex

On 7/6/17, 8:34 AM, "Josh Tynjala"  wrote:

>While full support for FlexJS in IntelliJ IDEA would be great, I think
>it's
>critical that we fix this issue to at least get back to the baseline we
>had
>in 0.7. A FlexJS project required a little bit of extra configuration with
>0.7, but at least we could get the compiler to work inside IntellIJ.
>
>Many Flex/ActionScript developers use IntelliJ, and while I'd love to
>encourage them to try VSCode, I think many prefer to take their first
>steps
>with FlexJS in an environment they already know. Having this stop working
>(especially when there are tutorials out there claiming it works) is going
>to turn people away.
>
>If we can fix this issue, I want to push a 0.8.1 update because I think
>getting this working again is very, very important.
>
>- Josh
>
>On Thu, Jul 6, 2017 at 12:55 AM, piotrz  wrote:
>
>> As I remember Chris get to the bottom of it and resolved it.
>>Unfortunately
>> after contacting with Jetbrains they refuse accept pull request with fix
>> and
>> Chris dropped it. [1]
>>
>> I was thinking even then that if someone could fix it and store version
>>of
>> plugin somewhere with fix it would be also HUGE, cause we could gain
>> another
>> IDE which support FlexJS.
>>
>> [1]
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl
>>ex-development.247.n4.nabble=02%7C01%7C%7C5f4eb274ee54460f044608
>>d4c484a74e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63634952143892612
>>4=3U%2FcqwvO4C8OtATk9khadreh99KxUUfsfJYiEptjJzs%3D=0.
>> com/FlexJS-Step-by-step-h-baby-td58710.html
>>
>> Thanks,
>> Piotr
>>
>>
>>
>> -
>> Apache Flex PMC
>> piotrzarzyck...@gmail.com
>> --
>> View this message in context: http://apache-flex-
>> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
>> in-IntelliJ-IDEA-tp62848p62862.html
>> Sent from the Apache Flex Development mailing list archive at
>>Nabble.com.
>>



Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-06 Thread Josh Tynjala
I have also gotten this error before. I remember that I had to manually set
playerglobal.version (and maybe also playerglobal.swfversion) in my
env.properties to get the build to pass.

- Josh

On Tue, Jul 4, 2017 at 12:14 AM, yishayw  wrote:

> I was having a problem building the Mobile package. It was complaining
> about
> line 151 in Camera.as which does camera.copyToByteArray(). Looking at the
> docs [1], it looks like this method became available in flash 11.4 while
> the
> build is set to look for flash player 11.1 (under build.properties).
>
> So I changed to flash 25.0 and rebuilt, and Mobile passed. The funny thing
> is that after changing back to 11.1, the build now passes.
>
> In short, it looks to me like the flash player requirement should be
> updated
> to 11.4.
>
> What do you guys think?
>
> [1]
> http://help.adobe.com/en_US/FlashPlatform/reference/
> actionscript/3/flash/media/Camera.html#copyToByteArray()
>
>
>
>
> --
> View this message in context: http://apache-flex-
> development.247.n4.nabble.com/FlexJS-Mobile-Depends-on-
> Flash-11-4-tp62811.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>


Re: 4.16.0 Install issues

2017-07-06 Thread piotrz
Hi Nick,

As for the font encoding we had discussion about that at ApacheCon [1] and I
raised jira [2]

[1]
http://apache-flex-development.247.n4.nabble.com/ApacheCon-FlexJS-Summit-FlexJS-1-0-Discussion-Round-Summary-td61700.html
[2] https://issues.apache.org/jira/browse/FLEX-35315

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/4-16-0-Install-issues-tp62855p62869.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-06 Thread Alex Harui
That should be recent enough.  I can't figure out why you got that error
if it used that airglobal.swc.  Maybe there is a clue in the  console
output.

-Alex

On 7/5/17, 10:31 AM, "yishayw"  wrote:

>My AIR_HOME goes to my nightly installation which has Adobe AIR 23.0 SDK.
>
>
>
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.247.n4.nabble.com%2FFlexJS-Mobile-Depends-on-Flash-11-4-
>tp62811p62846.html=02%7C01%7C%7C3ea3ce11a723421b660408d4c3ce30ef%7Cfa
>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636348737727585984=d4WJ8B8Y
>RjgFrBpqUbGUpgeRi7m%2B0cJrpcMtRRPWWbk%3D=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.



Re: 4.16.0 Install issues

2017-07-06 Thread Alex Harui
I'm not spending any time on the installer other than occasionally
pondering if there is some other workaround we could deploy.  I'm waiting
on Adobe to put out a 64-bit native installer.  IMO, that's the least work
on our part, but not sure when Adobe will push that out.

The SSL errors from SourceForge have a workaround that's been posted a few
times.  The correct solution is to write our own font encoding library.
Volunteers are needed.

I thought Ant on Windows would work if you used a recent version of Ant.

Thanks,
-Alex

On 7/5/17, 6:13 PM, "Nicholas Kwiatkowski"  wrote:

>Is anybody actually addressing the issues people have been reporting about
>the installer and/or ANT script for Flex SDK 4.16.0?
>
>Right now I see two major issues that are preventing even people who are
>familiar with the SDK from doing installs :
>
> - In the installer, selecting AIR 25.0 gives users a non-descript "error
>1000".  This is due toe the md5 checking in the installer running out of
>memory
> - Trying to install via ANT is also broken under Windows (any version of
>AIR SDK).  As packaged, it always errors because it tries to install the
>MacOS AIR SDK.  Additionally, the optional components that are currently
>hosted on sourceforge fail to download due to some SSL errors (I've tested
>this with the latest java sdk and ANT build).
>
>The AIR installer issue will require us to rip-and-replace the md5
>calculation functions.  I've started looking at it, but I don't think it
>will be an easy feat.
>Fixing the ANT script for Windows trying to install the mac air dmg is an
>easy fix (but it will require us to do a dot release to push it out)
>The SSL errors are because sourceforge is using SANs on their SSL certs,
>and the current versions of ANT don't know how to read them to validate
>them.  This may be out of our control.  Anybody know if we can convince
>Adobe to either donate those chunks of code or at least to move them to a
>different host?  It looks like the code involved is OSMF, AFE, AGLJ,
>rideau and Flex-Fontkit.  The alternative to a different host is for us to
>ignore SSL errors, but that could be potentially dangerous.
>
>If nobody is working on these, I can start to take a crack at them, but
>honestly, the installer is extremely fragile at this point and I'm not
>looking forward to even trying to figure out what is going on in there
>again.
>
>-Nick



Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Josh Tynjala
While full support for FlexJS in IntelliJ IDEA would be great, I think it's
critical that we fix this issue to at least get back to the baseline we had
in 0.7. A FlexJS project required a little bit of extra configuration with
0.7, but at least we could get the compiler to work inside IntellIJ.

Many Flex/ActionScript developers use IntelliJ, and while I'd love to
encourage them to try VSCode, I think many prefer to take their first steps
with FlexJS in an environment they already know. Having this stop working
(especially when there are tutorials out there claiming it works) is going
to turn people away.

If we can fix this issue, I want to push a 0.8.1 update because I think
getting this working again is very, very important.

- Josh

On Thu, Jul 6, 2017 at 12:55 AM, piotrz  wrote:

> As I remember Chris get to the bottom of it and resolved it. Unfortunately
> after contacting with Jetbrains they refuse accept pull request with fix
> and
> Chris dropped it. [1]
>
> I was thinking even then that if someone could fix it and store version of
> plugin somewhere with fix it would be also HUGE, cause we could gain
> another
> IDE which support FlexJS.
>
> [1]
> http://apache-flex-development.247.n4.nabble.
> com/FlexJS-Step-by-step-h-baby-td58710.html
>
> Thanks,
> Piotr
>
>
>
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in context: http://apache-flex-
> development.247.n4.nabble.com/FlexJS-0-8-0-not-working-
> in-IntelliJ-IDEA-tp62848p62862.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>


Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread Alex Harui
Hi Allen,

You can try other examples like FlexJSStore in the FlexJS SDK's examples
folder as the source for a FlexJS project in Flash Builder.

Or, create a new Flex/FlexJS project and copy the source from
demo_for_presentation.

HTH,
-Alex

On 7/6/17, 6:50 AM, "Allen YANG"  wrote:

>Hi PKumar,
>
>You are correct that I don't need to have Maven or Ant installed if I
>want to just use Flash Builder as the IDE.   was able to use Flash
>Builder 4.7 and FlexJS to build and run the examples in the wiki
>successfully.  I just could not use FB to build Yishay's
>demo_for_presentation project successfully.  But I desired to get this
>demo working because the demo program is beyond "Hello World".  I just
>didn’t know that it would takes me longer time than I expected and still
>not fully getting it to work the way it should.
>After trying both FB and VS Code+Maven for a while, I think Flash
>Builder's error messages tend to be more cryptic.
>
>Hi Yishay,
>I followed Alex's suggestions and did the following steps to
>demo_for_presentation project:
>1) In Project -> Properties -> Flex Build Path, removed airglobal,
>Core.swc and Basic.swc.
>2) Shut down Flash Builder
>3) Open the .actionScriptProperties file in a text editor and remove
>these two lines from excludedEntries:
>path="${PROJECT_FRAMEWORKS}/libs/core.swc" useDefaultLinkType="false"/>
>  path="${PROJECT_FRAMEWORKS}/libs/Basic.swc" useDefaultLinkType="false"/>
>4) Use the file system to remove bin folder from the project folder.
>5) Restart Flash Builder, clean and rebuild the project.
>
>These changes allowed me to build demo_for_presentation. And I now can
>run it by double-clicking index.html in both bin/js-debug and
>bin/js-release folders.
>But I am not sure that it runs correctly because the screen display
>always look like the following:
>
>boring
>my comp 0
>Button1 Button2
>
>Clicking Button1 should increment the count, but it doesn't change the
>display at all; and I believe clicking Button2 doesn't do anything
>according to the source code.  Could you help me  to correct the behavior
>of the demo program?
>I exported the fpx file on my Dropbox:
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.dropb
>ox.com%2Fs%2Fzknv0tj5kvvioph%2Fdemo_for_presentation.fxp%3Fdl%3D0=02%
>7C01%7C%7C8345d5754e0445ae749108d4c47606dd%7Cfa7b1b5a7b34438794aed2c178dec
>ee1%7C0%7C0%7C636349458587573300=GQuPEL%2F5L%2BIbBDA92SAbKDJeeLT3Eoc
>om26fULgT0xA%3D=0
>
>Hi Team:
>My original purpose of learning FlexJS is to convert my Flex 3 project so
>it will run without Flash Player. I am still far away from the goal.  If
>anyone could suggest what to do to rewrite my MXMLs that use TitleWindow
>and HBox that will be quite appreciated.
>
>Best regards,
>Allen
>
>
>-Original Message-
>From: PKumar [mailto:prashaku...@gmail.com]
>Sent: Thursday, July 06, 2017 2:26 AM
>To: dev@flex.apache.org
>Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to
>HTML+JS
>
>If you want to use FlexJS with Flash Builder 4.7 then no need to install
>Ant and maven.
>
>just download latest version of FlexJs via SDK installer and add new
>FlexJS SDK under Flash Buildrler4.7 as you add regular flex SDK.
>
>After SDK setup . You need to import runtime command into Flash Builder
>so that u can compile Flex JS project.
>
>Apache Flex wiki have nice information on this. Please refer wiki.
>
>On 06-Jul-2017 5:17 AM, "allenyyang [via Apache Flex Development]" <
>ml+s247n62853...@n4.nabble.com> wrote:
>
>> Hi Yishay,
>>
>> After trying for quite a while, I found that we might be talking about
>> two different things.  I informed Piotr that was able to use Maven and
>> VS Code to build and run Piotr's "Hello World" example successfully.
>> But I was unable to successfully run demo_for_presentation using Flash
>>Builder 4.7.
>> You might be thinking that I was talking about being able to use VS
>> Code and Maven to build and run demo_for_presentation successfully;
>> which is not the case for me yet.
>>
>> So I went back to your email on 07/01 and I installed Ant and added it
>> to PATH; I also set ANT_HOME to where I installed Ant:
>> C:\apache-ant-1.10.1; and already have JAVA_HOME to its installation
>> folder: C:\Program
>> Files\Java\jdk1.8.0_131
>> At the folder demo_for_presentation where build.xml file resides, I
>> typed 'ant' in the cmd window.  I got the following error:
>> --
>> 
>>
>> Buildfile: C:\Projects\demo_for_presentation\build.xml
>>
>> clean:
>>
>> build_example.compilejs:
>>  [echo] Compiling demo_for_presentation.js
>>  [echo] FLEX_HOME: ${env.FLEXJS_HOME}
>>  [echo] FALCONJX_HOME: ${FALCONJX_HOME}
>>  [echo] env GOOG_HOME: ${env.GOOG_HOME}
>>  [echo] GOOG_HOME: ${GOOG_HOME}
>>  [java] Error: Could not find or load main class ${mxmlc.jvm.args}
>>  [java] Java Result: 1
>>
>> BUILD FAILED
>> 

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread PKumar
I will check the example shared. But if need more examples on title window,
grid, panel , list and other controls. Just let me know I will share with
you on GitHub.

On 06-Jul-2017 7:21 PM, "allenyyang [via Apache Flex Development]" <
ml+s247n62863...@n4.nabble.com> wrote:

> Hi PKumar,
>
> You are correct that I don't need to have Maven or Ant installed if I want
> to just use Flash Builder as the IDE.   was able to use Flash Builder 4.7
> and FlexJS to build and run the examples in the wiki successfully.  I just
> could not use FB to build Yishay's demo_for_presentation project
> successfully.  But I desired to get this demo working because the demo
> program is beyond "Hello World".  I just didn’t know that it would takes me
> longer time than I expected and still not fully getting it to work the way
> it should.
> After trying both FB and VS Code+Maven for a while, I think Flash
> Builder's error messages tend to be more cryptic.
>
> Hi Yishay,
> I followed Alex's suggestions and did the following steps to
> demo_for_presentation project:
> 1) In Project -> Properties -> Flex Build Path, removed airglobal,
> Core.swc and Basic.swc.
> 2) Shut down Flash Builder
> 3) Open the .actionScriptProperties file in a text editor and remove these
> two lines from excludedEntries:
>  path="${PROJECT_FRAMEWORKS}/libs/core.swc" useDefaultLinkType="false"/>
>path="${PROJECT_FRAMEWORKS}/libs/Basic.swc" useDefaultLinkType="false"/>
> 4) Use the file system to remove bin folder from the project folder.
> 5) Restart Flash Builder, clean and rebuild the project.
>
> These changes allowed me to build demo_for_presentation. And I now can run
> it by double-clicking index.html in both bin/js-debug and bin/js-release
> folders.
> But I am not sure that it runs correctly because the screen display always
> look like the following:
>
> boring
> my comp 0
> Button1 Button2
>
> Clicking Button1 should increment the count, but it doesn't change the
> display at all; and I believe clicking Button2 doesn't do anything
> according to the source code.  Could you help me  to correct the behavior
> of the demo program?
> I exported the fpx file on my Dropbox: https://www.dropbox.com/s/
> zknv0tj5kvvioph/demo_for_presentation.fxp?dl=0
>
> Hi Team:
> My original purpose of learning FlexJS is to convert my Flex 3 project so
> it will run without Flash Player. I am still far away from the goal.  If
> anyone could suggest what to do to rewrite my MXMLs that use TitleWindow
> and HBox that will be quite appreciated.
>
> Best regards,
> Allen
>
>
> -Original Message-
> From: PKumar [mailto:[hidden email]
> ]
> Sent: Thursday, July 06, 2017 2:26 AM
> To: [hidden email] 
> Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to
> HTML+JS
>
> If you want to use FlexJS with Flash Builder 4.7 then no need to install
>  Ant and maven.
>
> just download latest version of FlexJs via SDK installer and add new
> FlexJS SDK under Flash Buildrler4.7 as you add regular flex SDK.
>
> After SDK setup . You need to import runtime command into Flash Builder so
> that u can compile Flex JS project.
>
> Apache Flex wiki have nice information on this. Please refer wiki.
>
> On 06-Jul-2017 5:17 AM, "allenyyang [via Apache Flex Development]" <
> [hidden email] >
> wrote:
>
> > Hi Yishay,
> >
> > After trying for quite a while, I found that we might be talking about
> > two different things.  I informed Piotr that was able to use Maven and
> > VS Code to build and run Piotr's "Hello World" example successfully.
> > But I was unable to successfully run demo_for_presentation using Flash
> Builder 4.7.
> > You might be thinking that I was talking about being able to use VS
> > Code and Maven to build and run demo_for_presentation successfully;
> > which is not the case for me yet.
> >
> > So I went back to your email on 07/01 and I installed Ant and added it
> > to PATH; I also set ANT_HOME to where I installed Ant:
> > C:\apache-ant-1.10.1; and already have JAVA_HOME to its installation
> > folder: C:\Program
> > Files\Java\jdk1.8.0_131
> > At the folder demo_for_presentation where build.xml file resides, I
> > typed 'ant' in the cmd window.  I got the following error:
> > --
> > 
> >
> > Buildfile: C:\Projects\demo_for_presentation\build.xml
> >
> > clean:
> >
> > build_example.compilejs:
> >  [echo] Compiling demo_for_presentation.js
> >  [echo] FLEX_HOME: ${env.FLEXJS_HOME}
> >  [echo] FALCONJX_HOME: ${FALCONJX_HOME}
> >  [echo] env GOOG_HOME: ${env.GOOG_HOME}
> >  [echo] GOOG_HOME: ${GOOG_HOME}
> >  [java] Error: Could not find or load main class ${mxmlc.jvm.args}
> >  [java] Java Result: 1
> >
> > BUILD FAILED
> > C:\Projects\demo_for_presentation\build_example.xml:124: code: 1
> >
> > 

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread Allen YANG
Hi PKumar,

You are correct that I don't need to have Maven or Ant installed if I want to 
just use Flash Builder as the IDE.   was able to use Flash Builder 4.7 and 
FlexJS to build and run the examples in the wiki successfully.  I just could 
not use FB to build Yishay's demo_for_presentation project successfully.  But I 
desired to get this demo working because the demo program is beyond "Hello 
World".  I just didn’t know that it would takes me longer time than I expected 
and still not fully getting it to work the way it should.
After trying both FB and VS Code+Maven for a while, I think Flash Builder's 
error messages tend to be more cryptic.

Hi Yishay,
I followed Alex's suggestions and did the following steps to 
demo_for_presentation project:
1) In Project -> Properties -> Flex Build Path, removed airglobal, Core.swc and 
Basic.swc.
2) Shut down Flash Builder
3) Open the .actionScriptProperties file in a text editor and remove these two 
lines from excludedEntries:

  
4) Use the file system to remove bin folder from the project folder.
5) Restart Flash Builder, clean and rebuild the project.

These changes allowed me to build demo_for_presentation. And I now can run it 
by double-clicking index.html in both bin/js-debug and bin/js-release folders.
But I am not sure that it runs correctly because the screen display always look 
like the following:

boring
my comp 0
Button1 Button2

Clicking Button1 should increment the count, but it doesn't change the display 
at all; and I believe clicking Button2 doesn't do anything according to the 
source code.  Could you help me  to correct the behavior of the demo program?
I exported the fpx file on my Dropbox: 
https://www.dropbox.com/s/zknv0tj5kvvioph/demo_for_presentation.fxp?dl=0

Hi Team:
My original purpose of learning FlexJS is to convert my Flex 3 project so it 
will run without Flash Player. I am still far away from the goal.  If anyone 
could suggest what to do to rewrite my MXMLs that use TitleWindow and HBox that 
will be quite appreciated.

Best regards,
Allen


-Original Message-
From: PKumar [mailto:prashaku...@gmail.com]
Sent: Thursday, July 06, 2017 2:26 AM
To: dev@flex.apache.org
Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

If you want to use FlexJS with Flash Builder 4.7 then no need to install  Ant 
and maven.

just download latest version of FlexJs via SDK installer and add new FlexJS SDK 
under Flash Buildrler4.7 as you add regular flex SDK.

After SDK setup . You need to import runtime command into Flash Builder so that 
u can compile Flex JS project.

Apache Flex wiki have nice information on this. Please refer wiki.

On 06-Jul-2017 5:17 AM, "allenyyang [via Apache Flex Development]" <
ml+s247n62853...@n4.nabble.com> wrote:

> Hi Yishay,
>
> After trying for quite a while, I found that we might be talking about
> two different things.  I informed Piotr that was able to use Maven and
> VS Code to build and run Piotr's "Hello World" example successfully.
> But I was unable to successfully run demo_for_presentation using Flash 
> Builder 4.7.
> You might be thinking that I was talking about being able to use VS
> Code and Maven to build and run demo_for_presentation successfully;
> which is not the case for me yet.
>
> So I went back to your email on 07/01 and I installed Ant and added it
> to PATH; I also set ANT_HOME to where I installed Ant:
> C:\apache-ant-1.10.1; and already have JAVA_HOME to its installation
> folder: C:\Program
> Files\Java\jdk1.8.0_131
> At the folder demo_for_presentation where build.xml file resides, I
> typed 'ant' in the cmd window.  I got the following error:
> --
> 
>
> Buildfile: C:\Projects\demo_for_presentation\build.xml
>
> clean:
>
> build_example.compilejs:
>  [echo] Compiling demo_for_presentation.js
>  [echo] FLEX_HOME: ${env.FLEXJS_HOME}
>  [echo] FALCONJX_HOME: ${FALCONJX_HOME}
>  [echo] env GOOG_HOME: ${env.GOOG_HOME}
>  [echo] GOOG_HOME: ${GOOG_HOME}
>  [java] Error: Could not find or load main class ${mxmlc.jvm.args}
>  [java] Java Result: 1
>
> BUILD FAILED
> C:\Projects\demo_for_presentation\build_example.xml:124: code: 1
>
> Total time: 0 seconds
>
> Can you help me to see what's wrong?
>
> Thanks and Regards,
> Allen
> --
> ---
>
>
> -Original Message-
> From: yishayw [mailto:[hidden email]
> ]
> Sent: Wednesday, July 05, 2017 12:54 AM
> To: [hidden email]
> 
> Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project
> to
> HTML+JS
>
> yishayw wrote
> > Now assuming you have pom.xml and build.xml in your project you
> > should be able to run Maven like this:
>
> Should read:
>
>
> Now assuming you have pom.xml and build.xml in your project you should
> 

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread piotrz
As I remember Chris get to the bottom of it and resolved it. Unfortunately
after contacting with Jetbrains they refuse accept pull request with fix and
Chris dropped it. [1]

I was thinking even then that if someone could fix it and store version of
plugin somewhere with fix it would be also HUGE, cause we could gain another
IDE which support FlexJS. 

[1]
http://apache-flex-development.247.n4.nabble.com/FlexJS-Step-by-step-h-baby-td58710.html

Thanks,
Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-0-8-0-not-working-in-IntelliJ-IDEA-tp62848p62862.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.


RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread yishayw
Hi Allen,

It looks like you’ve got VS Code and Maven working, so please don’t waste time 
on this unless you want to work on Flash Builder instead. VS Code and Maven are 
actually preferred by some developers over FB and Ant.

PKumar is correct that you shouldn’t really need Ant if you’re using FB, I was 
suggesting to use Ant as a workaround, but it looks like you have some 
environment variables missing.

I suggest you export your FB project as an fxp (in FB got to file->Export Flash 
Builder Project…) and share the fxp with us. That way we can try  to analyze 
why FB’s default build is failing for you, in an effort to make it smoother for 
future developers.

Thanks,
Yishay



From: allenyyang [via Apache Flex 
Development]
Sent: Thursday, July 6, 2017 2:47 AM
To: yishayw
Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi Yishay,

After trying for quite a while, I found that we might be talking about two 
different things.  I informed Piotr that was able to use Maven and VS Code to 
build and run Piotr's "Hello World" example successfully.  But I was unable to 
successfully run demo_for_presentation using Flash Builder 4.7.  You might be 
thinking that I was talking about being able to use VS Code and Maven to build 
and run demo_for_presentation successfully; which is not the case for me yet.

So I went back to your email on 07/01 and I installed Ant and added it to PATH; 
I also set ANT_HOME to where I installed Ant: C:\apache-ant-1.10.1; and already 
have JAVA_HOME to its installation folder: C:\Program Files\Java\jdk1.8.0_131
At the folder demo_for_presentation where build.xml file resides, I typed 'ant' 
in the cmd window.  I got the following error:
--
Buildfile: C:\Projects\demo_for_presentation\build.xml

clean:

build_example.compilejs:
 [echo] Compiling demo_for_presentation.js
 [echo] FLEX_HOME: ${env.FLEXJS_HOME}
 [echo] FALCONJX_HOME: ${FALCONJX_HOME}
 [echo] env GOOG_HOME: ${env.GOOG_HOME}
 [echo] GOOG_HOME: ${GOOG_HOME}
 [java] Error: Could not find or load main class ${mxmlc.jvm.args}
 [java] Java Result: 1

BUILD FAILED
C:\Projects\demo_for_presentation\build_example.xml:124: code: 1

Total time: 0 seconds

Can you help me to see what's wrong?

Thanks and Regards,
Allen
-

-Original Message-
From: yishayw [mailto:[hidden 
email]]
Sent: Wednesday, July 05, 2017 12:54 AM
To: [hidden email]
Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

yishayw wrote
> Now assuming you have pom.xml and build.xml in your project you should
> be able to run Maven like this:

Should read:


Now assuming you have pom.xml and build.xml in your project you should be able 
to run Maven *or ant* like this:




--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-question-about-porting-an-Adobe-Flex-3-project-to-HTML-JS-tp62698p62835.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.



Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir 
des informations sensibles et/ ou confidentielles ne devant pas être 
divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous 
recevez ce message par erreur), nous vous remercions de le notifier 
immédiatement à son expéditeur, et de détruire ce message. Toute copie, 
divulgation, modification, utilisation ou diffusion, non autorisée, directe ou 
indirecte, de tout ou partie de ce message, est strictement interdite.


This e-mail, and any document attached hereby, may contain confidential and/or 
privileged information. If you are not the intended recipient (or have received 
this e-mail in error) please notify the sender immediately and destroy this 
e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution 
or other use of the material or parts thereof is strictly forbidden.


If you reply to this email, your message will be added to the discussion below:
http://apache-flex-development.247.n4.nabble.com/FlexJS-question-about-porting-an-Adobe-Flex-3-project-to-HTML-JS-tp62698p62853.html
To unsubscribe from [FlexJS] question about porting an Adobe Flex 3 project to 
HTML+JS, click 
here.

Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean
Hi,

Dave I assume the case statement issue you referring to is is the last one in 
this list [1]. It not a bug but style wise it’s a little odd and probably 
should still be fixed.

Thanks,
Justin

1. 
https://builds.apache.org/analysis/component_issues/index?id=org.apache.flex.flexjs.framework%3Aflexjs-framework-parent#types=CODE_SMELL|severities=CRITICAL

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-06 Thread PKumar
If you want to use FlexJS with Flash Builder 4.7 then no need to install
 Ant and maven.

just download latest version of FlexJs via SDK installer and add new FlexJS
SDK under Flash Buildrler4.7 as you add regular flex SDK.

After SDK setup . You need to import runtime command into Flash Builder so
that u can compile Flex JS project.

Apache Flex wiki have nice information on this. Please refer wiki.

On 06-Jul-2017 5:17 AM, "allenyyang [via Apache Flex Development]" <
ml+s247n62853...@n4.nabble.com> wrote:

> Hi Yishay,
>
> After trying for quite a while, I found that we might be talking about two
> different things.  I informed Piotr that was able to use Maven and VS Code
> to build and run Piotr's "Hello World" example successfully.  But I was
> unable to successfully run demo_for_presentation using Flash Builder 4.7.
> You might be thinking that I was talking about being able to use VS Code
> and Maven to build and run demo_for_presentation successfully; which is not
> the case for me yet.
>
> So I went back to your email on 07/01 and I installed Ant and added it to
> PATH; I also set ANT_HOME to where I installed Ant: C:\apache-ant-1.10.1;
> and already have JAVA_HOME to its installation folder: C:\Program
> Files\Java\jdk1.8.0_131
> At the folder demo_for_presentation where build.xml file resides, I typed
> 'ant' in the cmd window.  I got the following error:
> --
>
> Buildfile: C:\Projects\demo_for_presentation\build.xml
>
> clean:
>
> build_example.compilejs:
>  [echo] Compiling demo_for_presentation.js
>  [echo] FLEX_HOME: ${env.FLEXJS_HOME}
>  [echo] FALCONJX_HOME: ${FALCONJX_HOME}
>  [echo] env GOOG_HOME: ${env.GOOG_HOME}
>  [echo] GOOG_HOME: ${GOOG_HOME}
>  [java] Error: Could not find or load main class ${mxmlc.jvm.args}
>  [java] Java Result: 1
>
> BUILD FAILED
> C:\Projects\demo_for_presentation\build_example.xml:124: code: 1
>
> Total time: 0 seconds
>
> Can you help me to see what's wrong?
>
> Thanks and Regards,
> Allen
> -
>
>
> -Original Message-
> From: yishayw [mailto:[hidden email]
> ]
> Sent: Wednesday, July 05, 2017 12:54 AM
> To: [hidden email] 
> Subject: RE: [FlexJS] question about porting an Adobe Flex 3 project to
> HTML+JS
>
> yishayw wrote
> > Now assuming you have pom.xml and build.xml in your project you should
> > be able to run Maven like this:
>
> Should read:
>
>
> Now assuming you have pom.xml and build.xml in your project you should be
> able to run Maven *or ant* like this:
>
>
>
>
> --
> View this message in context: http://apache-flex-
> development.247.n4.nabble.com/FlexJS-question-about-
> porting-an-Adobe-Flex-3-project-to-HTML-JS-tp62698p62835.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
> 
>
> Ce message, ainsi que tous les fichiers joints à ce message, peuvent
> contenir des informations sensibles et/ ou confidentielles ne devant pas
> être divulguées. Si vous n'êtes pas le destinataire de ce message (ou que
> vous recevez ce message par erreur), nous vous remercions de le notifier
> immédiatement à son expéditeur, et de détruire ce message. Toute copie,
> divulgation, modification, utilisation ou diffusion, non autorisée, directe
> ou indirecte, de tout ou partie de ce message, est strictement interdite.
>
>
> This e-mail, and any document attached hereby, may contain confidential
> and/or privileged information. If you are not the intended recipient (or
> have received this e-mail in error) please notify the sender immediately
> and destroy this e-mail. Any unauthorized, direct or indirect, copying,
> disclosure, distribution or other use of the material or parts thereof is
> strictly forbidden.
>
>
> --
> If you reply to this email, your message will be added to the discussion
> below:
> http://apache-flex-development.247.n4.nabble.
> com/FlexJS-question-about-porting-an-Adobe-Flex-3-project-to-HTML-JS-
> tp62698p62853.html
> To start a new topic under Apache Flex Development, email
> ml+s247n1...@n4.nabble.com
> To unsubscribe from Apache Flex Development, click here
> 
> .
> NAML
> 
>




--
View this message in context: 

Re: [FlexJS] technical debt

2017-07-06 Thread Justin Mclean

Hi,

> You cut my previous reply which means I need to repeat.

Why is that? All modern email clients support threaded messages. so people 
should be able to see my email and your original in context. When replying 
repeating the whole email is generally frowned upon. Sorry if I cut too much 
out as finding the middle ground can sometimes be tricky.

Rereading your message perhaps rather than "The singular code smell” you meant 
"This singular code smell”? That line in your email isn’t entirely clear. 

> You called out changes since 0.8. And I only looked at the change since in 
> Sonar. I took about 5 minutes, a very superficial check.
> 
> My point in general was the the recent changes do look pretty clean.

I’m not sure I would call this clean as it added 5,300 odd code smalls (a 41% 
increase to the total) and 89 days of technical debt. [1] The new code had a 
technical debt rating of 19.5% when the technical debt of existing code was 
around 2-3% so that probably indicates something has changed.

We’re still getting a “A” for matainability as we have a lot of small files 
with smallish amount of TD [2], but that could slip into B (5-10%) or even C 
(10-20%) fairly quickly if new changes keep at the current TD rate.

Of course people have different options of what is clean and what isn’t and a 
lot of what Sonar is reporting isn't going to matter so I would certainly 
wouldn't take those numbers too literally.

Thanks,
Justin

1.https://builds.apache.org/analysis/component_issues?id=org.apache.flex.flexjs.framework%3Aflexjs-framework-parent#resolved=false|types=CODE_SMELL|sinceLeakPeriod=true
2. 
https://builds.apache.org/analysis/component_measures/domain/Maintainability?id=org.apache.flex.flexjs.framework%3Aflexjs-framework-parent



Re: [FlexJS] technical debt

2017-07-06 Thread Dave Fisher
Hi Justin,

You cut my previous reply which means I need to repeat.

You called out changes since 0.8. And I only looked at the change since in 
Sonar. I took about 5 minutes, a very superficial check.

Lots of TD should be explored carefully hopefully by the original developer.

I agree with the notion that these changes should be at the beginning of a 
cycle.

My point in general was the the recent changes do look pretty clean.

Let's see what the developers think.

Regards,
Dave

Sent from my iPhone

> On Jul 5, 2017, at 6:19 PM, Justin Mclean  wrote:
> 
> Hi,
> 
>> In the differential all 30 of the bugs are of the form:
>> 
>> Make this class “Event" override "Event.clone()” function
> 
> Which some are false positives as there’s a cloneEvent method. Note you can 
> mark them as such in the interface. I had already fixed a couple of these a 
> few weeks back.
> 
>> The singular code smell (Sonar says that flex smells very good indeed.)
> 
> Not sure where you seeing just 1 as I can see 13,100 and their are a 
> varieties of issues. Again some worth looking into and others not.
> 
> Thanks,
> Justin