Re: [RESULT][VOTE] Release Apache Flink 1.3.0 (RC3)

2017-06-06 Thread Kostas Kloudas
+1 for Gordon’s suggestion. > On Jun 6, 2017, at 2:52 PM, Ted Yu wrote: > > +1 > > bq. we can collect this list on the wiki > > Or utilize the Release Note field of JIRA for each such change. > > On Tue, Jun 6, 2017 at 5:45 AM, Till Rohrmann wrote:

Re: [RESULT][VOTE] Release Apache Flink 1.3.0 (RC3)

2017-06-06 Thread Ted Yu
+1 bq. we can collect this list on the wiki Or utilize the Release Note field of JIRA for each such change. On Tue, Jun 6, 2017 at 5:45 AM, Till Rohrmann wrote: > +1 for your suggestions Tzu-Li. > > On Tue, Jun 6, 2017 at 9:47 AM, Tzu-Li (Gordon) Tai

Re: [RESULT][VOTE] Release Apache Flink 1.3.0 (RC3)

2017-06-06 Thread Till Rohrmann
+1 for your suggestions Tzu-Li. On Tue, Jun 6, 2017 at 9:47 AM, Tzu-Li (Gordon) Tai wrote: > One suggestion for future major release announcements: > > I propose that we add a list of deprecated / breaking API changes in the > announcement of major releases. > Although

Re: [RESULT][VOTE] Release Apache Flink 1.3.0 (RC3)

2017-06-06 Thread Tzu-Li (Gordon) Tai
One suggestion for future major release announcements: I propose that we add a list of deprecated / breaking API changes in the announcement of major releases. Although @PublicEnvolving API is not guaranteed to not change across releases, it would still be nice that there’s a proper

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-06-01 Thread Robert Metzger
Hi Timo, I agree that not having the documentation available for the new features is not good. I'll do a pass over all the open documentation PRs and try to merge as many as possible. If I have the feeling, that we have enough docs, I'll release 1.3.0. For the table API, I can put a note into the

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Timo Walther
What do you think about waiting with the release announcement for Flink 1.3.1 until next week. IMHO the documentation is not in a good shape for a release annoucement right now anyway. Most of the new features of the Table API are not documented. Docs for other features are missing as well

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Aljoscha Krettek
Yes, FLINK-6783 might even have been a release blocker…. It’s a new feature that simply doesn’t work in most cases. > On 31. May 2017, at 14:51, Timo Walther wrote: > > We should also include FLINK-6783. It seems that WindowedStream::aggregate is > broken right now. > >

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Timo Walther
We should also include FLINK-6783. It seems that WindowedStream::aggregate is broken right now. Am 31.05.17 um 14:31 schrieb Timo Walther: I merged all Table API related PRs. I'm also fine with a 1.3.1 release this or next week. Am 31.05.17 um 14:08 schrieb Till Rohrmann: I would be ok to

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Timo Walther
I merged all Table API related PRs. I'm also fine with a 1.3.1 release this or next week. Am 31.05.17 um 14:08 schrieb Till Rohrmann: I would be ok to quickly release 1.3.1 once the the respective PRs have been merged. Just for your information, I'm not yet through with the testing of the

[RESULT][VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Robert Metzger
Thanks a lot for all your responses on the point Till raised. It seems that we have an agreement to release this RC as Flink 1.3.0. I'll include a note into the release announcement regarding the state descriptor issue. Thanks also for all the release testing and the votes. +1 votes: - Chesnay

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Till Rohrmann
I would be ok to quickly release 1.3.1 once the the respective PRs have been merged. Just for your information, I'm not yet through with the testing of the type serializer upgrade feature, though. Cheers, Till On Wed, May 31, 2017 at 12:14 PM, Stefan Richter < s.rich...@data-artisans.com>

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Stefan Richter
+1 for releasing now and providing a 1.3.1 release soon. > Am 31.05.2017 um 11:02 schrieb Gyula Fóra : > > Hi All, > > I also lean towards getting the release out as soon as possible given that > it had been delayed quite a bit and there is no major issue without a >

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Gyula Fóra
Hi All, I also lean towards getting the release out as soon as possible given that it had been delayed quite a bit and there is no major issue without a straightforward workaround (agreeing with Nico and Kostas). I am sure once people will start using the new features we will see more issues that

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Kostas Kloudas
Hi all, I also tend to agree with the argument that says a release should be out as soon as possible, given that 1) it improves usability/functionality and 2) at a minimum, it does not include new known bugs. The arguments are more or less aligned with Nico’s response on the matter. Focusing

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Ufuk Celebi
I agree with Robert that this could be fixed in a bugfix release, but I really don't like immediately starting a new 1.3.1 vote a day after the 1.3.0 vote ends. I think it potentially gives a bad/sloppy impression to our users. Therefore, I lean towards cancelling this RC and creating a new one

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Nico Kruber
IMHO, any release that improves things and does not break anything is worth releasing and should not be blocked on bugs that it did not cause. There will always be a next (minor/major) release that may fix this at a later time, given that the time between releases is not too high. Consider

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Fabian Hueske
Moreover it looks to me as if FLINK-6780 can be fixed without touching the API, i.e., it can be fixed in 1.3.1. Haohui, do you think that's correct? Thanks, Fabian 2017-05-31 8:56 GMT+02:00 Timo Walther : > I don't think that FLINK-6780 is a blocker, because the Table API

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-31 Thread Timo Walther
I don't think that FLINK-6780 is a blocker, because the Table API is still a new feature. FLINK-6736 was also a hard bug. However, if there will be a RC4, a fix should be included. Regards, Timo Am 31.05.17 um 02:55 schrieb Haohui Mai: Hi, We have discovered

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Haohui Mai
Hi, We have discovered https://issues.apache.org/jira/browse/FLINK-6780 which effectively makes external catalogs in the table API very difficult to use. It may not be a show stopper but in my opinion it is worth a fix before the release. Regards, Haohui On Tue, May 30, 2017 at 11:22 AM Till

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Till Rohrmann
Just some thoughts concerning the cons for cancelling RC3: - Technically, the release is already delayed since the official release date was the 26th of May - Not sure whether it's a good argument to defer fixing major bugs because they have not been introduced with 1.3.0. It's actually alarming

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Robert Metzger
The vote time is over, but I'll keep it open for a bit longer until we've decided regarding Till's issue. On Tue, May 30, 2017 at 6:10 PM, Robert Metzger wrote: > Hi Till, > good catch! That is definitively a severe issue. Probably it didn't > surface yet, because > a) the

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Robert Metzger
Hi Till, good catch! That is definitively a severe issue. Probably it didn't surface yet, because a) the code example in the documentation is using a new instance for each state descriptor b) people are using stateless serializers? c) don't have the same state descriptor on the same machine I see

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Till Rohrmann
I might have found a blocking issue [1]. The problem is that a StateDescriptor cannot be shared by multiple subtasks because they don't duplicate their serializer. As a consequence, things break if you have a stateful serializer. The problem exists since 1.0. However, given that this issue is

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Greg Hogan
+1 (binding) - verified source and binary signatures - verified source and binary checksums - verified LICENSEs - verified NOTICEs - built from source Greg > On May 26, 2017, at 12:58 PM, Robert Metzger wrote: > > Hi all, > > this is the second VOTEing release candidate

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Tzu-Li (Gordon) Tai
+1 Tests I did: New features: - Tested rescaling Kinesis Consumer + transparent shard discovery - Tested topology changes on restore: changed chain orderings, added stateful / stateless operators, remove stateful / stateless operators - Tested new Flink CEP features: loop states, quantifiers,

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Aljoscha Krettek
+1 I did: - manually check the release using the new end-to-end tests: https://github.com/apache/flink/pull/3911 . - verify that the source builds - Check the (transitive) dependencies of flink-dist compared to 1.2.x. The new deps are:

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-30 Thread Robert Metzger
Thank you all for the +1 votes so far. As far as I see it, none of the issues mentioned in the thread are blockers. I've started putting together the blog post for the release announcement. It is ready to review here: https://github.com/apache/flink-web/pull/62 On Mon, May 29, 2017 at 5:16 PM,

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-29 Thread jincheng sun
Hi Robert, +1 to release: Check items have been checked, as follows: (flink-table) 1.Check that the JAVA and SCALA logical plans are consistent. 2.Check that the SQL and Table API logical plans are consistent. 3.Check that UDF, UDTF, and UDAF are working properly in group-windows and

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-29 Thread Stefan Richter
Hi, officially, we currently do not want to support rescaling from (incremental) checkpoints, but only from savepoints. For this reason, I would not consider this a blocking issue. Unofficially, I think we are not too far away from supporting this, but there is a question mark behind the

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-29 Thread Gyula Fóra
Hi, I have found an issue with rescaling incremental checkpoints: https://issues.apache.org/jira/browse/FLINK-6762 I am not sure if this is regarded as a blocker, it depends on our assumptions about externalized checkpoints. What do you think? Cheers, Gyula Robert Metzger

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-29 Thread Robert Metzger
+1 to release: - Tested building job against staging repository - tested YARN session start and container recovery on YARN - Validated HA on YARN (per job and session mode) - Incremental checkpointing with rocksdb works - FsStatebackend with async snapshots works - Flink builds from source on

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-29 Thread Chesnay Schepler
+1 * Builds from source * start/stop scripts work * logs don't show anything suspicious on startup/shutdown * ran some example jobs * ran jobs on yarn with exactly-once & RocksDB o canceling with savepoint/resuming from savepoint o without/with rescaling * SideOutputs work *

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-28 Thread Robert Metzger
@Shaoxuan, I don't think missing documentation is a release blocker, but it's something we should fix asap and with high priority :) Since the documentation is not bundled with the release, and the docs are build off the "release-x.y" branch, we can always update them (even after the release).

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-27 Thread Chesnay Schepler
I've responded in the JIRA. In my opinion isn't a functional issue, but more about improving error messages/documentation. On 27.05.2017 18:07, Gyula Fóra wrote: Hi! I have found this issue: https://issues.apache.org/jira/browse/FLINK-6742 Not sure if it's a blocker or not (not even

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-27 Thread Gyula Fóra
Hi! I have found this issue: https://issues.apache.org/jira/browse/FLINK-6742 Not sure if it's a blocker or not (not even completely sure what causes it at the moment) Gyula Shaoxuan Wang ezt írta (időpont: 2017. máj. 27., Szo, 6:30): > Hi Robert. > Will doc update be a

Re: [VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-26 Thread Shaoxuan Wang
Hi Robert. Will doc update be a blocker for release? Release 1.3 has many updates on tableAPI and SQL, and the docs are kind of lagging. We are trying the efforts to update the doc as much as possible before the release is officially published, but I am hoping this is not a blocker for the

[VOTE] Release Apache Flink 1.3.0 (RC3)

2017-05-26 Thread Robert Metzger
Hi all, this is the second VOTEing release candidate for Flink 1.3.0 The commit to be voted on: 760eea8a (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a *)