Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

e-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java (line 74) <https://reviews.apache.org/r/50242/#comment209046> Shouldn't this return the result of super.put(object)? - Darrel Schneider On July 22, 2016, 11:26 a.m

Review Request 50276: fix 100ms delay in stopping tombstone sweeper

precheckin Thanks, Darrel Schneider

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

entImpl.release(object); } } Note the change of how the release is done (using the static method makes this code cleaner). - Darrel Schneider On July 20, 2016, 9:29 a.m., Eric Shu wrote: > > --- > This is an automatically ge

Re: Recovering large data for persisted regions

This is a known issue in GemFire. I filed a corresponding Geode ticket: GEODE-1672. The issue involves recovering large amounts of when using the heap LRU. The data get recovered asynchronously before it can be evicted by the heap LRU. So it is possible you will run out of heap during recovery. Ev

Review Request 49811: add defragmentationsInProgress stat

/offheap/OffHeapStorageJUnitTest.java 90ff3cf593b3803a0f9fb2f81ff35c4adf7a678b Diff: https://reviews.apache.org/r/49811/diff/ Testing --- OffHeapStorageJUnitTest Thanks, Darrel Schneider

Re: Review Request 49536: refactor TombstoneService and add more info to testTombstones

ps://reviews.apache.org/r/49536/#review141040 ------- On July 1, 2016, 3:13 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 49712: GEODE-1621 Fix resources not being released during cleanup when an IllegalArgumentException is thrown

ase it seems like the IllegalArgumentException would never be expected and you could get rid of all catches of it. - Darrel Schneider On July 6, 2016, 10:21 a.m., Eric Shu wrote: > > --- > This is an automatically generated e

Review Request 49713: increase default number of off-heap free lists

://reviews.apache.org/r/49713/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 49667: GEODE-1631: Removing a hardcoded apache-geode from location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49667/#review140905 --- Ship it! Ship It! - Darrel Schneider On July 5, 2016, 4:58

Re: Review Request 49409: GEODE-1573: Use snappy java implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49409/#review140464 --- Ship it! Ship It! - Darrel Schneider On July 1, 2016, 4:49

Re: Review Request 49409: GEODE-1573: Use snappy java implementation

e you should go ahead and change them to use the constructor instead of calling getDefaultInstance - Darrel Schneider On July 1, 2016, 11:53 a.m., Sai Boorlagadda wrote: > > --- > This is an auto

Review Request 49536: refactor TombstoneService and add more info to testTombstones

/com/gemstone/gemfire/internal/cache/persistence/PersistentRVVRecoveryDUnitTest.java f7c011d1301da6ab992838717419f99bd17b8653 Diff: https://reviews.apache.org/r/49536/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 49409: GEODE-1573: Use snappy java implementation

e/src/test/java/com/gemstone/gemfire/internal/compression/CompressionRegionConfigDUnitTest.java (line 89) <https://reviews.apache.org/r/49409/#comment205509> I would change all the unit tests that call getDefaultInstance to instead do new SnappyCompressor(); - Darrel Schneider

Re: Review Request 49329: GEODE-1607: ConcurrentModificationException could occur when iterating through hostedTXStates HashMap during closing cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49329/#review140048 --- Ship it! Ship It! - Darrel Schneider On June 29, 2016, 1

Re: Review Request 49329: GEODE-1607: ConcurrentModificationException could occur when iterating through hostedTXStates HashMap during closing cache

<https://reviews.apache.org/r/49329/#comment205216> Why do you release the sync BEFORE iterating the hostedTXStates? - Darrel Schneider On June 28, 2016, 10:07 a.m., Eric Shu wrote: > > --- > This is an automatically generated e-

Re: Review Request 49101: GEODE-1546: Proxy server may not be able to send message to other servers to clean up transactions initiated by a shutdown client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49101/#review139394 --- Ship it! Ship It! - Darrel Schneider On June 24, 2016, 11

Re: Review Request 49101: GEODE-1546: Proxy server may not be able to send message to other servers to clean up transactions initiated by a shutdown client

emfire/internal/cache/TXManagerImpl.java (line 1582) <https://reviews.apache.org/r/49101/#comment204480> isEmpty is better than size() == 0 - Darrel Schneider On June 22, 2016, 3:47 p.m., Eric Shu wrote: > > --- > Thi

Re: Snappy compressor (native->java)

+1 A problem with the native bits is this product feature only works on certain native platforms. On Mon, Jun 20, 2016 at 7:48 PM, Sai Boorlagadda wrote: > There were no problems on the JNI wrapper (with native bits) except that > maintaining native bits needs special development & testing effo

Re: Review Request 48432: GEODE-1494: Allowing stats to be measured with callbacks

pl.java (line 58) <https://reviews.apache.org/r/48432/#comment203265> why not final? - Darrel Schneider On June 9, 2016, 11:41 a.m., Dan Smith wrote: > > --- > This is an a

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/#review138045 --- Ship it! Ship It! - Darrel Schneider On June 15, 2016, 10

Re: M3 status?

The test failing in GEODE-840 I think is going to be classified as "flaky". It should not hold up the m3 release. On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade wrote: > GEODE-1493 > Its not assigned to anyone...Someone with gradle/build experience can pick > this upDoesn't seems to be

Re: OplogCompactor question

It will only run if it can find at least one oplog that is ready for compaction. Once "getOplogsToBeCompacted()" returns null then a new compaction task will not be scheduled until a new oplog becomes compactable (see com.gemstone.gemfire.internal.cache.PersistentOplogSet.addToBeCompacted(Oplog)).

Re: Review Request 48383: fix IllegalStateException from importNewObject

c4849be2c0863e6badf6eeaf1ccfaaf826d57584 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java 800527f2927cc775cf89426f12fc6eb6c48f77bb Diff: https://reviews.apache.org/r/48383/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 48652: GEODE-1517: Transaction could still proceed after TXManagerImpl is closing during cache close

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48652/#review137422 --- Ship it! Ship It! - Darrel Schneider On June 13, 2016, 9:58

Re: Review Request 48383: fix IllegalStateException from importNewObject

c4849be2c0863e6badf6eeaf1ccfaaf826d57584 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java 800527f2927cc775cf89426f12fc6eb6c48f77bb Diff: https://reviews.apache.org/r/48383/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 48431: GEODE-1494: Changing stats list to be a CopyOnWriteArrayList

possible a change to SampleCollector.sampleResources to no longer call getStatistics (which copies the list into an array) but to instead just iterate the list like everyone else does. You could make this change yourself or file a ticket to do it in the future. - Darrel Schneider On June 8, 2016

Review Request 48383: fix IllegalStateException from importNewObject

/gemstone/gemfire/internal/cache/EntryEventImplTest.java 800527f2927cc775cf89426f12fc6eb6c48f77bb Diff: https://reviews.apache.org/r/48383/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

--------- On June 2, 2016, 3:20 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48189/ &

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

/parallel/ParallelGatewaySenderQueue.java (line 570) <https://reviews.apache.org/r/48189/#comment201343> removed unneeded indentation - Darrel Schneider On June 2, 2016, 3:20 p.m., Darrel Schneider wrote: > > ---

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

/partitioned/PREntriesIterator.java (line 25) <https://reviews.apache.org/r/48189/#comment201340> removed the extra the - Darrel Schneider On June 2, 2016, 3:20 p.m., Darrel Schneider wrote: > > --- > This is an automatica

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

l.java (line 1028) <https://reviews.apache.org/r/48187/#comment201008> The comment talks about moving the txid to the front of the queue. I would add that is does this by removing and putting the txid back into the Linked map. - Darrel Schneider On June 2,

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/#review135999 --- Ship it! Ship It! - Darrel Schneider On June 2, 2016, 2:26

Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703 Diff: https://reviews.apache.org/r/48189/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

When did forwardXXX become ignoreXXX? I read through the email thread and couldn't find why that happened. It is best for the default on a boolean property to be false. That was the case when it was forwardXXX. But now that it has changed to ignoreXXX the default has become true. I'd vote for it be

Re: Proposal - provide a callback to compute statistics

set{Int,Long,Double}Supplier'? > > On Thu, Jun 2, 2016 at 11:04 AM, Dan Smith wrote: > > > Replies inline. > > > > On Thu, Jun 2, 2016 at 10:04 AM, Darrel Schneider > > > wrote: > > > > > It is not clear to me how the new apis behave. > > &

Re: DistributionConfig and Geode system properties

+1 to naming it "ConfigurationProperties" +1 to moving the javadocs On Thu, Jun 2, 2016 at 10:46 AM, John Blum wrote: > Perhaps the (interface) name can be simplified to ConfigurationProperties > too. Not all properties necessarily involve specifically the distributed > system configuration, b

Re: Proposal - provide a callback to compute statistics

It is not clear to me how the new apis behave. Is the supplier for a particular id/name/descriptor remembered by the Statistics instance? So if you wanted to add an intSupplier for a int statistic you would do it once by calling sampleInt? The name of these methods give the impression that calling

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47543/#review135252 --- Ship it! Ship It! - Darrel Schneider On May 26, 2016, 10:31

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

;t you "assertTrue(latch.await(15...))"? Also I'd increase this to 60 seconds. - Darrel Schneider On May 26, 2016, 3:44 p.m., Eric Shu wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

lement the TransactionMessage interface could instead extend this AbstractTransactionMessage. So instead of doing this work as part of this ticket I'd just file a jira ticket saying that these classes have code duplication and should be refactored. - Darrel Schneider On May 25, 201

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

omments on RemoteOperationMessage geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java (line 189) <https://reviews.apache.org/r/47543/#comment27> sleeps in unit tests will probably introduce a flaky test. Could you coordinate these two threa

Re: Review Request 47834: refactor decodeAddressToBytes into two methods

/TinyStoredObject.java aee1b15e46df8b44d5d22a63263ae24fb6fab6bb geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5 Diff: https://reviews.apache.org/r/47834/diff/ Testing --- precheckin Thanks, Darrel Schneider

Review Request 47855: fix race in GemFireCacheImplTest

d5e3e02bef geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GemFireCacheImplTest.java 71b7fc6aecf77244a226b4853a1f5992b4de35af Diff: https://reviews.apache.org/r/47855/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 47834: refactor decodeAddressToBytes into two methods

/OffHeapRegionEntryHelperJUnitTest.java (line 23) <https://reviews.apache.org/r/47834/#comment199695> remove unused import - Darrel Schneider On May 25, 2016, 9:59 a.m., Darrel Schneider wrote: > > --- > This is a

Review Request 47834: refactor decodeAddressToBytes into two methods

/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5 Diff: https://reviews.apache.org/r/47834/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Broken: apache/incubator-geode#604 (develop - bd892f5)

It looks like this travis failure was caused by a new unit test I added. I suspect it is failing intermittently and was not caused to fail by this checkin. Here is the unit test failure: :geode-core:test com.gemstone.gemfire.internal.cache.GemFireCacheImplTest > checkThatAsyncEventListenersUseAllTh

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

- > > (Updated May 24, 2016, 3:05 p.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Repository: geode > > > Description > --- > > This also handles when an infligh

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

eed to say anything about the old size. - Darrel Schneider On May 24, 2016, 2:36 p.m., Sai Boorlagadda wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 47796: fix callback arg parameter order

/gemstone/gemfire/internal/cache/LocalDataSetTest.java fd813ed66e4dce06185c682bf7b3693921b45d94 Diff: https://reviews.apache.org/r/47796/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 47748: change isEmpty to use size

uot;you answer needs to be consistent with pr.entryCount(Set) and not pr.isEmpty". - Darrel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47748/#review134604 -----

Re: Review Request 47748: change isEmpty to use size

-core/src/test/java/com/gemstone/gemfire/internal/cache/LocalDataSetTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47748/diff/ Testing --- precheckin Thanks, Darrel Schneider

Review Request 47745: remove sqlf code in GemFireCacheImpl

://reviews.apache.org/r/47745/diff/ Testing --- precheckin Thanks, Darrel Schneider

Review Request 47744: deliver event synchronously if it is rejected

/GemFireCacheImplTest.java 7f95cadd68ad218f32129f6369198ae4ed968454 Diff: https://reviews.apache.org/r/47744/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Stats command

I don't know of a way to analyze offline stat archives using gfsh. But the code for the old gemfire stats command is still in the geode source. It is: com.gemstone.gemfire.internal.SystemAdmin Its "main" is what the old gemfire script executed. Just keep in mind that this class is not used by geod

Re: PartitionedRegionQueryEvaluatorTest failing with NullPointerException

I filed bug GEODE-1427 for this issue On Fri, May 20, 2016 at 5:03 PM, Kirk Lund wrote: > PartitionedRegionQueryEvaluatorTest is currently failing on develop due to > a static field being set by a previous unit test. This should be fixed very > soon. > > -Kirk >

Re: Review Request 47650: GEODE-1415 Disable logging of banners in distributedTests

s never logging a banner so I would have thought this code would need to say something like "if isLoner then logBanner". But instead it is "if !isLoner then logBanner". But I didn't see any problems with the changes you are making. - D

Review Request 47618: remove assertion of dunit jvm count

://reviews.apache.org/r/47618/diff/ Testing --- precheckin Thanks, Darrel Schneider

Review Request 47568: change async event pool to use all its threads

ne/gemfire/test/fake/Fakes.java 2a1fd8e343681f5cd41fa42145d2ae2fb73fd2c3 Diff: https://reviews.apache.org/r/47568/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

#comment198417> could unit tests be added for these new TXManagerImpl methods? geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java (line 323) <https://reviews.apache.org/r/47543/#comment198409> same comments as RemoteOperationMessage

Re: Review Request 47429: change defragment to not create fragments > 2G

read as if "size" is small enough then ... - Darrel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47429/#review133673 --------

Re: Review Request 47429: change defragment to not create fragments > 2G

not need to allocate 2G chunks of off-heap memory and it was not possible without major refactoring. The problem is that we modify size fields stored at an address during defragmentation and currently that requires that the address be a valid off-heap memory address. Thanks, Darrel Schneider

Re: Review Request 47479: GEODE-1296: change conditional in getRawBytes to assert

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47479/#review133580 --- Ship it! Ship It! - Darrel Schneider On May 17, 2016, 10:22

Re: Review Request 47433: handle NOT_AVAILABLE in callers of getRawOldValue

ted e-mail. To reply, visit: https://reviews.apache.org/r/47433/#review133570 --- On May 16, 2016, 5:01 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated

Re: Review Request 47435: GEODE-1392: add tests for BlobHelper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47435/#review133475 --- Ship it! Ship It! - Darrel Schneider On May 16, 2016, 5:32

Review Request 47437: use preTearDownAssertions to call checkOrphans

: https://reviews.apache.org/r/47437/diff/ Testing --- precheckin Thanks, Darrel Schneider

Review Request 47433: handle NOT_AVAILABLE in callers of getRawOldValue

://reviews.apache.org/r/47433/diff/ Testing --- precheckin Thanks, Darrel Schneider

Review Request 47429: change defragment to not create fragments > 2G

ize fields stored at an address during defragmentation and currently that requires that the address be a valid off-heap memory address. Thanks, Darrel Schneider

Review Request 47270: remove InsufficientDiskSpaceException

/47270/diff/ Testing --- Thanks, Darrel Schneider

Re: Review Request 47254: GEODE-1183: when there're 2 cacheserver on the same jvm, it will keep recreating or reinitializing the proxy

made smart enough to not create a secondary to the same JVM as the primary. It is also questionable for it to create a secondary to a server on the same machine as the primary. Seems similiar to the canonical host stuff we have for redundant PR buckets. - Darrel Schneider On May 11, 2016, 2:2

Review Request 47264: GEODE-1252: modify bits atomically

-CREATION Diff: https://reviews.apache.org/r/47264/diff/ Testing --- precheckin Thanks, Darrel Schneider

commits to geode are no longer updating the jira ticket

I pushed some commits today and did not see them automatically add a comment to the corresponding GEODE-xxx ticket. Until this is fixed you should do this manually with a link to your git revision.

Review Request 47201: removed @Retained from getValueInVM since its result is never off-heap

/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java bedbf8148556360ae80672b836ba40fafd47df01 Diff: https://reviews.apache.org/r/47201/diff/ Testing --- precheckin Thanks, Darrel Schneider

Review Request 47194: javadocs now make clear that off-heap regions always clone

/ClientRegionFactory.java 9c7fae07ce2ec33f7549ffaee701fab7fa922f6b Diff: https://reviews.apache.org/r/47194/diff/ Testing --- Thanks, Darrel Schneider

Review Request 47191: removed DataAsAddress references

/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 46275: GEODE-1234: Provide a test hook to track transactions scheduled to be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46275/#review132303 --- Ship it! Ship It! - Darrel Schneider On May 9, 2016, 10:56

Re: Review Request 46854: GEODE-1224: Modify BucketRegion.getCloningEnabled to call this.partitionedRegion.getCloningEnabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46854/#review132300 --- Ship it! Ship It! - Darrel Schneider On May 4, 2016, 11:42

Review Request 47128: add release call when GatewaySenderEventImpl removed from tempQueue

. Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelQueueRemovalMessage.java 09f70a66c94dd4128aec76d90a9bc1beff720317 Diff: https://reviews.apache.org/r/47128/diff/ Testing --- precheckin and off-heap wan orphan tests Thanks, Darrel Schneider

Re: Review Request 46275: GEODE-1234: Provide a test hook to track transactions scheduled to be removed

Tx != null) { addAll/removeAll } - Darrel Schneider On May 6, 2016, 9:36 a.m., Eric Shu wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 46908: GEODE-92: PR with entry eviction 1 leaves 3 entries in memory with async overflow

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46908/#review131950 --- Ship it! Ship It! - Darrel Schneider On May 2, 2016, 1:40

Re: Review Request 46275: GEODE-1234: Provide a test hook to track transactions scheduled to be removed

x27;s that use the hook can enable it somehow (could be a system property) otherwise the set can be null. - Darrel Schneider On April 15, 2016, 10:25 a.m., Eric Shu wrote: > > --- > This is an automatically generated

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

> On May 2, 2016, 12:29 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 1742 > > > > > > I don't think we need

Re: Review Request 46854: GEODE-1224: Modify BucketRegion.getCloningEnabled to call this.partitionedRegion.getCloningEnabled

s test should set the server port to 0 instead of using getRandomAvailablePort. - Darrel Schneider On May 2, 2016, 9:26 a.m., Scott Jewell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46660: GEODE-1278: Catch and translate CacheCLosedException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46660/#review130665 --- Ship it! Ship It! - Darrel Schneider On April 26, 2016, 10

Review Request 46668: putAll and removeAll getEventForPosition no longer marked as retained

4360b2a7837844c3b29b8c43a2036656e2183780 Diff: https://reviews.apache.org/r/46668/diff/ Testing --- precheckin and hydra tests Thanks, Darrel Schneider

Re: @since tags in our javadocs - old gemfire vs. geode versions

+1 for having on explicit GemFire and Geode On Mon, Apr 25, 2016 at 4:43 PM, Kenneth Howe wrote: > +1 to “gemFire x.y.z” > > Adding the GemFire makes it obvious where the feature came from, no > inference > required as would happen if we left just a version number for old @since > annotations.

Review Request 46662: remove TODO OFFHEAP comments

/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 46660: GEODE-1278: Catch and translate CacheCLosedException

eded? Since state is mocked in setUp I think all its methods will return defaults (in this case null). So why explicitly say that state.getTarget() should return null? If you do need this would it be better to have this a part in setUp since it is not specific to this test method? -

Re: Review Request 46655: GEODE-1288: Correct entry expiration detection logic error

ail because it never configures the short expiration and run it once and make sure it fails in a reasonable way (with you 1 minute timeout) instead of it being declared hung? - Darrel Schneider On April 25, 2016, 12:12 p.m., Scott J

Re: Review Request 45700: Fixed BucketOperatorWrapper to invoke onFailure if bucket creation fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45700/#review129970 --- Ship it! Ship It! - Darrel Schneider On April 21, 2016, 12

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46402/#review129744 --- Ship it! Ship It! - Darrel Schneider On April 20, 2016, 6

Review Request 46417: fixed GEODE-1238

cabacbc96e0928d15a9262cf26f19a62f301196f Diff: https://reviews.apache.org/r/46417/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/#review129646 --- Ship it! Ship It! - Darrel Schneider On April 19, 2016, 2

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

Also I think you should do all the thread work in the method; don't return the thread and join on it. Instead do the join in this method. And you could call the method disconnectInNonDaemonThread. - Darrel Schneider On April 19, 2016, 12:55 p.m.,

Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656

/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java (line 962) <https://reviews.apache.org/r/45706/#comment192887> Add @Override - Darrel Schneider On April 18, 2016, 12:02 p.m., Scott Jewell wrote: > > --- > This is an aut

Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656

nner class just create a static subclass of ReferenceCountHelperImpl in this test class. You can then put instance variables on that class that you want to access from these overridden methods (the count variables) - Darrel Schneider On A

Review Request 46151: possible fix for intermittent failure of testTombstones

/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 46124: GEODE-1221 Move implemented functions to test tree

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46124/#review128590 --- Ship it! Ship It! - Darrel Schneider On April 12, 2016, 5

Re: Review Request 46110: GEODE-1218: Marking jna as not optional

> On April 12, 2016, 3:08 p.m., Darrel Schneider wrote: > > What does it mean for it to be marked as optional? > > Off-heap does not depend on jna. I know lock-memory does. > > Anthony Baker wrote: > It means the user must manually add a dependency rather than

Re: Review Request 46110: GEODE-1218: Marking jna as not optional

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46110/#review128573 --- Ship it! Ship It! - Darrel Schneider On April 12, 2016, 1

Re: Review Request 46060: fix the off-heap leak in netWrite

n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46060/#review128546 ------- On April 11, 2016, 4:05 p.m., Darrel Schneider wrote: > > --- > Th

<    1   2   3   4   5   >