Re: Where should geode example code live

2016-11-10 Thread Udo Kohlmeyer
+1 On 11/11/16 9:13 am, Jacob Barrett wrote: +1 On Thu, Nov 10, 2016 at 11:22 AM Swapnil Bawaskar wrote: +1 On Thu, Nov 10, 2016 at 11:12 AM, Kirk Lund wrote: Yep! Replace "gemfire" with "geode" On Thu, Nov 10, 2016 at 11:07 AM, Kevin Duling

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

2016-11-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155654 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 7, 2016, 10:13

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/#review155653 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 10, 2016, 9:47

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Udo Kohlmeyer
ide the normal behaviour from AbstractRegionEntry. - Udo Kohlmeyer On Nov. 10, 2016, 4:47 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Spring Data Geode 1.0.0-INCUBATING-RELEASE available!

2016-11-10 Thread Udo Kohlmeyer
Nice one John!! I look forward to seeing the Spring Security integration as well. --Udo On 11/11/16 5:15 am, John Blum wrote: I am happy to announce the release of /Spring Data/ for /Apache Geode/1.0.0-incubating, which marks the first, official GA release of /Apache Geode/ as well as the

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

2016-11-07 Thread Udo Kohlmeyer
/LocalRegion.java (lines 3269 - 3284) <https://reviews.apache.org/r/53557/#comment225104> Maybe this is better suited on the PDXInstance. Maybe a method like "isTypeOf(Class). Then at least we don't spread the PDX logic everywhere in the code. - Udo Kohlmeyer On Nov. 7, 2016, 10:13

Re: more spotless problems on Windows

2016-11-03 Thread Udo Kohlmeyer
, Udo Kohlmeyer <u...@apache.org> wrote: I think we seriously have to look at using .gitattributes for this... As I initially said, it should be a no brainer.. it should just automatically just work. --Udo On 4/11/16 9:00 am, Bruce Schuchardt wrote: It's been working on my Windows 7 m

Re: more spotless problems on Windows

2016-11-03 Thread Udo Kohlmeyer
I think we seriously have to look at using .gitattributes for this... As I initially said, it should be a no brainer.. it should just automatically just work. --Udo On 4/11/16 9:00 am, Bruce Schuchardt wrote: It's been working on my Windows 7 machine under a cygwin shell. I just ran it

Review Request 53409: GEODE-2017: Removal of nonSingleHopsCount stat in client

2016-11-03 Thread Udo Kohlmeyer
Thanks, Udo Kohlmeyer

Re: Review Request 53388: GEODE-2059 client SSL handshake attempts do not time out

2016-11-02 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53388/#review154616 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 2, 2016, 4:57 p.m

Re: jmh benchmarks

2016-11-02 Thread Udo Kohlmeyer
+2 On 3/11/16 5:17 am, Dan Smith wrote: Hi all, I'd like to add some support for running benchmarks with jmh to geode. Is this something we're interested in having? JMH is a framework for easily writing microbenchmarks. It's probably not that useful for large scale multiple member benchmarks,

Re: Tweaking the IntelliJ and Eclipse formatters

2016-10-27 Thread Udo Kohlmeyer
1) 0 2) +1 3) +1 4) 0 On 27/10/16 3:11 pm, Kirk Lund wrote: I'd like to propose making a few changes to our IntelliJ and Eclipse formatters as well as the Eclipse importorder (all in etc/): 1) increase max line length (100 is way too short) 2) make (hopefully minor) changes to make the two

Re: Code Formatting in develop

2016-10-27 Thread Udo Kohlmeyer
Kevin, Could you please get latest dev. Barry has fixed. --Udo On 27/10/16 10:41 am, Kevin Duling wrote: I just submitted a PR to geode that Travis CI rejected because of code formatting in classes I had not modified. Prior to my commit, I'd merged in the latest develop branch this morning,

Re: Review Request 53199: GEODE-2000 ClientMemberShipListener at client should see server-bind-address in event memberId

2016-10-26 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53199/#review153926 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 26, 2016, 6:30

Re: Review Request 53150: GEODE-2024 Deadlock creating a new distributed lock service Grantor while transactions are in progress

2016-10-26 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53150/#review153925 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 25, 2016, 4:13

Re: [DISCUSS] Graduation

2016-10-25 Thread Udo Kohlmeyer
+1 On 25/10/16 5:43 pm, Joey McAllister wrote: +1 On Tue, Oct 25, 2016 at 5:42 PM Anthony Baker wrote: +1 On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik wrote: Unless somebody objects strongly to my #2 and #3 proposals I'm going to kick of this thread

Re: Coding practices/standards

2016-10-24 Thread Udo Kohlmeyer
al.io> wrote: +1 On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt < bschucha...@pivotal.io> wrote: +1 Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit : +1 On 20/10/16 4:56 pm, Mark Bretl wrote: +1 as well... - Pulled changes - Executed './gradlew clean build' and was successful. - M

Re: Coding practices/standards

2016-10-21 Thread Udo Kohlmeyer
formatter is applied? Thanks, --Mark On Fri, Oct 21, 2016 at 9:03 AM, Kenneth Howe <kh...@pivotal.io> wrote: +1 On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt < bschucha...@pivotal.io> wrote: +1 Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit : +1 On 20/10/16 4:56 pm, Mark Bre

Re: C++ Coding Standards

2016-10-21 Thread Udo Kohlmeyer
+1 - I'm not a C++ dev but I'm all for consistency. On 21/10/16 8:43 am, Jacob Barrett wrote: Considering the team just formally adopted some standards and enforcement for the Java sources I would like to open the discussion for formally adopting similar standards for the C++ sources. I

Re: Coding practices/standards

2016-10-20 Thread Udo Kohlmeyer
shed a branch to my Geode repo that contains this change: https://github.com/jaredjstewart/incubator-geode/ tree/spotlessPlugin < https://github.com/jaredjstewart/incubator-geode/ tree/spotlessPlugin On Oct 12, 2016, at 2:27 PM, Darrel Schneider < dschnei...@pivotal.io wrote: I like Dan'

Re: Removal of nonSingleHopCount stat from client

2016-10-20 Thread Udo Kohlmeyer
statistics and I hear that people generally have stats turned off in clients anyway. Le 10/19/2016 à 12:55 PM, Udo Kohlmeyer a écrit : Hi there Guys, I've created https://issues.apache.org/jira/browse/GEODE-2017 to track the removal of the nonSingleHopCount stat from the client, as it is potenti

Re: Review Request 53034: GEODE-1927 backward compatibility support

2016-10-19 Thread Udo Kohlmeyer
a new category, then awesome! - Udo Kohlmeyer On Oct. 19, 2016, 9:16 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Removal of nonSingleHopCount stat from client

2016-10-19 Thread Udo Kohlmeyer
Hi there Guys, I've created https://issues.apache.org/jira/browse/GEODE-2017 to track the removal of the nonSingleHopCount stat from the client, as it is potentially a redundant stat. From the implementation it only increments on "singleHop" enabled pools when an operation requires more

Review Request 52933: GEODE-1874: setNextNeighbor method allocates a HashSet on every p2p message received

2016-10-17 Thread Udo Kohlmeyer
ache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java aafb498 Diff: https://reviews.apache.org/r/52933/diff/ Testing --- precheckin - Done comms regression - in progress Thanks, Udo Kohlmeyer

Re: GEODE-1466: geode.properties

2016-10-13 Thread Udo Kohlmeyer
If such a change is to be introduced.. maybe we call it `SYSTEM_PREFIX` or something more generic that we could use within the Geode. Then we could hopefully cover many to most `gemfire` vs `geode` renaming. But I agree with @Anthony, if we aren't 100% certain about a change then we should

Re: Review Request 52836: GEODE-2000 ClientMemberShipListener at client should return hostname on which cacheserver is listening(i.e. server-bind-address)

2016-10-13 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52836/#review152567 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 13, 2016, 4:26

Re: Coding practices/standards

2016-10-12 Thread Udo Kohlmeyer
+1 - adding checkstyle to precheckin. If the developer uses the provided templates ( eclipse + intellij) then most of the formatting issues should be handled before precheckin. Also, if a developer has a questionable coding style, that should lessen as that developer will have resolve the

Re: Deprecate DynamicRegionFactory

2016-10-11 Thread Udo Kohlmeyer
+1 - I see no real benefit for this. On 12/10/16 1:10 pm, William Markito wrote: +1 - We always discouraged people using dynamic regions On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith wrote: I'd like to reopen the discussion about deprecating DynamicRegionFactory. This is

Re: Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

2016-10-11 Thread Udo Kohlmeyer
/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java a7c7b48 Diff: https://reviews.apache.org/r/52725/diff/ Testing --- Pre-checkin started Thanks, Udo Kohlmeyer

Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

2016-10-10 Thread Udo Kohlmeyer
://reviews.apache.org/r/52725/diff/ Testing --- Pre-checkin started Thanks, Udo Kohlmeyer

Re: Review Request 52641: GEODE-1914 removed old versions of dtds

2016-10-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52641/#review152094 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 7, 2016, 7:13 p.m

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Udo Kohlmeyer
I believe that a backwards compatibility framework is required. Even if just to confirm the compatibility between supported Geode versions. If this framework were to be used/extended by any user of the Geode ecosystem, then it becomes their responsibility to maintain that extension. --Udo

Re: Review Request 52524: GEODE-1927 backward compatibility support

2016-10-05 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52524/#review151587 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 4, 2016, 7:36 p.m

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151255 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 3, 2016, 11:20

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

2016-10-03 Thread Udo Kohlmeyer
tSSLConfigForComponent(SecurableCommunicationChannel.WEB)); - Udo Kohlmeyer On Oct. 3, 2016, 5:52 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

2016-09-28 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52172/#review150770 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 28, 2016, 4:08

Review Request 52363: GEODE-1947: Renaming SSL_HTTP_SERVICE_REQUIRE_AUTHENTICATION to SSL_WEB_SERVICE_REQUIRE_AUTHENTICATION

2016-09-28 Thread Udo Kohlmeyer
nal/beans/BeanUtilFuncs.java 92d2f62 geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java 8b760df Diff: https://reviews.apache.org/r/52363/diff/ Testing --- Thanks, Udo Kohlmeyer

Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread Udo Kohlmeyer
this feature on hold until can be brought current. Anthony On Sep 22, 2016, at 3:31 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: +1 to removing until updated to newer version Do we know if anyone in the big-bad world is using it? --Udo On 23/09/2016 8:15 AM, William Markito

Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread Udo Kohlmeyer
+1 to removing until updated to newer version Do we know if anyone in the big-bad world is using it? --Udo On 23/09/2016 8:15 AM, William Markito wrote: Folks, We're still building the Hibernate cache module [1] but it's compatible only with a very old version (3.5) and given that the API

Re: Review Request 51696: GEODE-1777 CI failure: RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[

2016-09-08 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51696/#review148270 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 7, 2016, 4:25

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

2016-09-08 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148269 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 8, 2016, 3:45

Re: securing geode components

2016-09-08 Thread Udo Kohlmeyer
As GEODE-420 deals with SSL comms configuration and GEODE-1648 with Authentication I think we need to be careful in what is feasible and what is logical. For SSL comms it was decided that the following components are relevant [1]

Re: Review Request 51612: GEODE-1834: initilize the socketcreator with the correct ssl settings

2016-09-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51612/#review147929 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 2, 2016, 6:38

Re: Review Request 51666: GEODE-1792: Configuration consistency in SSL configuration

2016-09-06 Thread Udo Kohlmeyer
ning. Thanks, Udo Kohlmeyer

Re: M3 is done, what's next?

2016-09-04 Thread Udo Kohlmeyer
+1 for package renaming +1 for sooner than later On 3/09/2016 2:46 AM, Dan Smith wrote: +1 For renaming the packages. It would be really nice to graduate ASAP! Is there anything else from a code perspective that we need to do before graduation? If so we should also get that in 1.0. It would

Re: Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51385/#review146696 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 24, 2016, 6:30

Re: Review Request 51227: GEODE-420: Locator SSL

2016-08-22 Thread Udo Kohlmeyer
://reviews.apache.org/r/51227/diff/ Testing --- precheckin - completed. All green. regression testing to follow Thanks, Udo Kohlmeyer

Re: Review Request 51227: GEODE-420: Locator SSL

2016-08-21 Thread Udo Kohlmeyer
gradle/java.gradle 36d88dc Diff: https://reviews.apache.org/r/51227/diff/ Testing --- precheckin - completed. All green. regression testing to follow Thanks, Udo Kohlmeyer

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-08-21 Thread Udo Kohlmeyer
uickly become unmanageable. - Udo Kohlmeyer On Aug. 10, 2016, 9:25 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 51227: GEODE-420: Locator SSL

2016-08-18 Thread Udo Kohlmeyer
/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71 geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9 gradle/java.gradle 36d88dc Diff: https://reviews.apache.org/r/51227/diff/ Testing --- Thanks, Udo

Re: Revised SSL properties failure scenario advice.

2016-08-12 Thread Udo Kohlmeyer
ot set for multi-key keystore On Wed, Aug 10, 2016 at 4:34 PM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: +1 for ssl-default-alias and failing Le 8/10/2016 à 3:36 PM, Udo Kohlmeyer a écrit : Hi there guys, As per the proposal for the revision of the SSL configuration <

Revised SSL properties failure scenario advice.

2016-08-10 Thread Udo Kohlmeyer
Hi there guys, As per the proposal for the revision of the SSL configuration , I'm nearing the completion of this feature. What I have come across is some scenarios where a system is configured with a multi-key

Re: Javadoc warnings

2016-07-21 Thread Udo Kohlmeyer
Hmmm... Can you please get your team in check I get the following since updating :P :D :D :D /Users/ukohlmeyer/projects/gemfire/open/geode-core/src/main/java/org/apache/geode/security/GeodePermission.java:49: warning - @return tag has no arguments.

Re: Review Request 49729: Used static instance of logger while logging

2016-07-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49729/#review141092 --- Ship it! Ship It! - Udo Kohlmeyer On July 6, 2016, 9:39 p.m

Docker testing support for Geode

2016-06-23 Thread Udo Kohlmeyer
Hi there, Whilst thinking about how to improve our testing capability (the provisioning of machines and VMs), I was pointed at this project. https://github.com/palantir/docker-compose-rule I wonder if this is something that we can look at. Maybe some extension of this, could help with our

Re: update website for WAN, CQ and native client

2016-06-22 Thread Udo Kohlmeyer
+1, to me "Multi-site" is too rigid. People might forget that this is a inter-cluster comms channel. Which would allow them to have many clusters running in the same DC, sharing data between them, satisfying the data requirements for different systems/applications. On 22/06/2016 4:54 AM,

Re: Review Request 48556: Fixing spark connector build issue due to ConfigurationProperties name change

2016-06-14 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48556/#review137554 --- Ship it! Ship It! - Udo Kohlmeyer On June 10, 2016, 3:12

Re: Review Request 48665: GEODE-1542 shared/unordered tcp/ip connection times out, initiating suspicion

2016-06-14 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48665/#review137552 --- Ship it! Ship It! - Udo Kohlmeyer On June 13, 2016, 10:50

Re: Partitioned Region With Overflow Behavior Question

2016-06-11 Thread Udo Kohlmeyer
Hi there Avinash, Firstly I would change the critical-heap-percentage to something closer to 70 or 80. This setting is a "stop-the-world" percentage, where the amount of data inserted is greater than what can be evicted. Also I would make sure that the CMSOccupancyPercentage is 3-5% less

GEODE-1377: DistributedSystemConfigProperties

2016-06-09 Thread Udo Kohlmeyer
Hi there Guys, As per a previous thread, I've moved all the javadoc from DistributedSystem to DistributedSystemConfigProperties. I have also now renamed DistributedSystemConfigProperties to ConfigurationProperties. Please make sure that for all new tests and development that you reference

Re: build error with development branch...

2016-06-02 Thread Udo Kohlmeyer
Maybe try 1.8.0_92... I know it works On 3/06/2016 7:47 am, Dan Smith wrote: Hmm, does that -ea mean it's an early access build? I would recommend running with a later version of java 8. -Dan On Thu, Jun 2, 2016 at 2:41 PM, Anilkumar Gingade wrote: If gradle is using

Re: build error with development branch...

2016-06-02 Thread Udo Kohlmeyer
I think that you getting this because vm1.invokeAsync(... seems to need to return something but it does not. Maybe remove the 'AsynInvocation vm1Invoke =' part... As it serves no purpose here. --Udo On 3/06/2016 6:58 am, Anilkumar Gingade wrote: Hi Devs, Anyone seeing this issue:

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

2016-06-02 Thread Udo Kohlmeyer
DistributedSystemConfigProperties. - Udo Kohlmeyer On June 2, 2016, 5:07 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

2016-06-02 Thread Udo Kohlmeyer
To reply, visit: > https://reviews.apache.org/r/48176/ > --- > > (Updated June 2, 2016, 5:07 p.m.) > > > Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith. > > > Repository: geode > > &

Re: DistributionConfig and Geode system properties

2016-06-02 Thread Udo Kohlmeyer
) Add @since Geode 1.0 to this interface, as well as some javadocs describing to users what's contained in this interface. 3) DistributedSystem has a ton of javadocs describing each property and what it does. I wonder if those javadocs should move to the constants in this interface instead? -Dan On Wed, Jun 1

DistributionConfig and Geode system properties

2016-06-01 Thread Udo Kohlmeyer
Hi there, As per GEODE-1377 I've refactored DistributionConfig to extract all public system properties into a public DistributedSystemConfigProperties interface. With that refactor I've touched a significant amount of classed and I, in

Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

2016-05-31 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47908/#review135740 --- Ship it! Ship It! - Udo Kohlmeyer On May 26, 2016, 8:34 p.m

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

2016-05-31 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48095/#review135739 --- Ship it! Ship It! - Udo Kohlmeyer On May 31, 2016, 10:15

Re: Review Request 47245: GEODE-1327 java.util.ConcurrentModificationException while updating log message

2016-05-22 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47245/#review134303 --- Ship it! Ship It! - Udo Kohlmeyer On May 11, 2016, 5:55 p.m

Re: Review Request 47501: GEODE-1387 CI Failure: LocatorLauncherRemoteFileIntegrationTest.testStatusUsingWorkingDirectory

2016-05-18 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47501/#review133818 --- Ship it! Ship It! - Udo Kohlmeyer On May 17, 2016, 11:49

Re: Review Request 47504: GEODE-1133 SeparateClassloaderTestRunner has to be re-implemented

2016-05-18 Thread Udo Kohlmeyer
if it is genuinely not used anymore, I'm happy that we remove it. - Udo Kohlmeyer On May 18, 2016, 12:01 a.m., Jianxia Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47323: GEODE-732 Unable to create PDXInstance from valid JSON using JSONFormatter

2016-05-12 Thread Udo Kohlmeyer
it. - Udo Kohlmeyer On May 12, 2016, 8:10 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

2016-05-12 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47195/#review133006 --- Ship it! Ship It! - Udo Kohlmeyer On May 12, 2016, 10:45

Re: Unable to run single dunit

2016-05-04 Thread Udo Kohlmeyer
When I did this, I had to "wrap" the class with '*' The command is then. ./gradlew -DdistributedTest.single=*ListAndDescribeDiskStoreCommandsDUnitTest* On 5/05/2016 7:38 am, Kirk Lund wrote: This used to work quite well for me. Why am I not able to run a single dunit on the command-line now?

Re: Review Request 46940: GEODE-1329 auto-reconnect attempts cease if kicked out during boot-up of the cache

2016-05-03 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46940/#review131540 --- Ship it! Ship It! - Udo Kohlmeyer On May 3, 2016, 3:43 p.m

Re: Review Request 46801: GEDOE-1321 GMSHealthMonitor: java.lang.IllegalStateException: Timer already cancelled

2016-05-02 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46801/#review131370 --- Ship it! Ship It! - Udo Kohlmeyer On April 29, 2016, 4:47

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

2016-05-02 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131367 --- Ship it! Ship It! - Udo Kohlmeyer On May 2, 2016, 4:36 p.m

Re: [DISCUSS] What to do with the partial HDFS related code on develop?

2016-04-27 Thread Udo Kohlmeyer
+1 On 28/04/2016 7:16 am, Dan Smith wrote: This is done. The HDFS related changes are gone from develop and are now on their own feature branch - feature/GEODE-10. -Dan On Sat, Mar 19, 2016 at 2:05 AM, wrote: +1 a possible HDFS integration should also be an

Re: @since tags in our javadocs - old gemfire vs. geode versions

2016-04-26 Thread Udo Kohlmeyer
, Apr 25, 2016 at 6:36 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: I must be honest that I've never been a supporter of the @since tag. Imo, release notes and features should be the paper trail that we provide. Also, how would we handle a scenario where a class is denoted with @since

Re: Review Request 46590: GEODE-1237 remove the check for network-partition-detection uniformity

2016-04-25 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46590/#review130494 --- Ship it! Ship It! - Udo Kohlmeyer On April 22, 2016, 10:29

Re: [DISCUSS] Geode Examples (GEODE-33)

2016-04-21 Thread Udo Kohlmeyer
Hey William, I'm assuming that these examples would both be in Java and Native Client (where applicable)? --Udo On 21/04/2016 3:14 pm, William Markito wrote: Hey folks, Here is a proposal for the initial README.md file and structure for Geode examples subproject. Ideally each item on the

Re: [DISCUSS] Geode Examples (GEODE-33)

2016-04-21 Thread Udo Kohlmeyer
Looks good. I think that PDX is both and Intermediate and Advanced topic. As PDX can be a simple tool to use, like ReflectionBasedSerialization or custom PDXSeraliazation. But PDX can also be more complex with one using the PDXInstanceFactory. --Udo On 21/04/2016 3:14 pm, William Markito

Re: Review Request 46474: GEODE-33 - Initial structure for geode-examples with list of examples

2016-04-21 Thread Udo Kohlmeyer
g/r/46474/#comment193491> I think this could be both an Intermediate topic and Advanced. Basic PDX usage like ReflectionBased and PdxSerializer is Intermediate topic. But you can then have Advanced topic where you then work with the PDXInstanceFactory. - Udo Kohlmeyer On Ap

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Udo Kohlmeyer
after itself - Udo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129833 --- On April 21, 2016, 1:58 a.m.

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Udo Kohlmeyer
3a97b7c361c2082c44d76604460f630adaed12aa geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANConfigurationJUnitTest.java 84eb365ef3d698af6007757886edfa5cc5dabf2f Diff: https://reviews.apache.org/r/46457/diff/ Testing --- precheckin running Thanks, Udo Kohlmeyer

Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Udo Kohlmeyer
/WANConfigurationJUnitTest.java 84eb365ef3d698af6007757886edfa5cc5dabf2f Diff: https://reviews.apache.org/r/46457/diff/ Testing --- precheckin running Thanks, Udo Kohlmeyer

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

2016-04-13 Thread Udo Kohlmeyer
/main/java/com/gemstone/gemfire/management/internal/RestAgent.java a91df05 geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java a8921d7 Diff: https://reviews.apache.org/r/45993/diff/ Testing --- battery tests rest.bt Thanks, Udo

Re: Review Request 46108: GEODE-1216 Fix the scalability of remove member

2016-04-12 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46108/#review128541 --- Ship it! Ship It! - Udo Kohlmeyer On April 12, 2016, 6:51

Re: Review Request 46056: GEODE-1178 Unexpected DistributedSystemDisconnectedException caused by RejectedExecutionException

2016-04-12 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46056/#review128521 --- Ship it! Ship It! - Udo Kohlmeyer On April 12, 2016, 3:51

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

2016-04-11 Thread Udo Kohlmeyer
- On April 10, 2016, 9:59 p.m., Udo Kohlmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45993/ >

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

2016-04-11 Thread Udo Kohlmeyer
ps://reviews.apache.org/r/45993/#review128137 ------- On April 10, 2016, 9:59 p.m., Udo Kohlmeyer wrote: > > --- > This is an automatically generated e-mail.

Review Request 45994: GEODE-1200 : Deprecating InetAddressUtil

2016-04-10 Thread Udo Kohlmeyer
, Udo Kohlmeyer

Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

2016-04-10 Thread Udo Kohlmeyer
--- battery tests rest.bt Thanks, Udo Kohlmeyer

Re: Review Request 45844: GEODE-1187 If a server launched by Gfsh goes into auto-reconnect the server's PID file is deleted

2016-04-07 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45844/#review127639 --- Ship it! Ship It! - Udo Kohlmeyer On April 6, 2016, 11:39

Http Service Bind Address - default behaviour

2016-04-04 Thread Udo Kohlmeyer
Hi there, I would just like to confirm some "simple" functionality regarding the HTTP Service bind address. If no bind address has been provided for the Http Service, should the default be to bind to the system bind-address or server-bind-address? --Udo

Re: Review Request 45599: GEODE-1160 TransactionWriter is unexpectedly triggered if updating data entries with using PDX serializer

2016-04-04 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45599/#review126843 --- Ship it! Ship It! - Udo Kohlmeyer On April 1, 2016, 7:22

Re: Review Request 45503: GEODE-962: RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure

2016-04-01 Thread Udo Kohlmeyer
che.org/r/45503/#review126209 --- On March 30, 2016, 8:22 p.m., Udo Kohlmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: unit tests

2016-03-30 Thread Udo Kohlmeyer
Hi there Dor, Haven't heard back from you. Assuming that your issue has been resolved. --Udo On 29/03/2016 5:15 pm, Dor Ben Dov wrote: Hi, When I compile without the skip tests flags it fails, does it happens to you also ? Dor This message and the information contained herein is

Re: Review Request 45058: GEODE-1107 CI failure: RestAPIsWithSSLDUnitTest.testSimpleSSL

2016-03-29 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45058/#review125993 --- Ship it! Ship It! - Udo Kohlmeyer On March 24, 2016, 10 p.m

Re: Review Request 45449: GEODE-923 In test changed "System.currentTimeMillis" to "System.nanoTime()" as Connection mgr uses nantime

2016-03-29 Thread Udo Kohlmeyer
tionManagerJUnitTest.java (line 286) <https://reviews.apache.org/r/45449/#comment188900> Maybe we could print out the time unit. "Elapsed time(ms): " would be more helpful - Udo Kohlmeyer On M

  1   2   >