Re: Build failed in Jenkins: guacamole-server-coverity #9

2018-01-28 Thread Mike Jumper
On Jan 28, 2018 11:20, "Apache Jenkins Server" wrote: See Changes: [mjumper] GUACAMOLE-352: Add utility function for checking whether a keysym exists [mjumper] GUACAMOLE-352:

[GitHub] guacamole-server pull request #138: GUACAMOLE-352: Add support for typing us...

2018-01-28 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/138 GUACAMOLE-352: Add support for typing using dead keys within RDP. This change leverages the existing mapping of dead keys within Guacamole's RDP keymaps to type using dead keys

[GitHub] guacamole-server pull request #137: GUACAMOLE-313: Add "guaclog" utility for...

2018-01-26 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/137 GUACAMOLE-313: Add "guaclog" utility for producing human-readable interpretations of keys pressed in session recordings This change adds a new utility, "guaclog"

[GitHub] guacamole-server pull request #136: GUACAMOLE-313: Add support for logging m...

2018-01-26 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/136 GUACAMOLE-313: Add support for logging mouse cursor information This change adds low-level support for logging mouse cursor position and state within session recordings (built upon

[GitHub] guacamole-server pull request #134: GUACAMOLE-489: Lock both wrapped sockets...

2018-01-26 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/134 GUACAMOLE-489: Lock both wrapped sockets when performing operations through a tee socket. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] guacamole-server pull request #135: GUACAMOLE-490: Take channel mask into ac...

2018-01-26 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/135 GUACAMOLE-490: Take channel mask into account when rendering image streams to buffers. You can merge this pull request into a Git repository by running: $ git pull https

Re: [DISCUSS] Guacamole CI Builds

2018-01-24 Thread Mike Jumper
On Tue, Sep 26, 2017 at 5:56 AM, Nick Couchman <vn...@apache.org> wrote: > On Tue, Sep 26, 2017 at 2:45 AM, Mike Jumper <mike.jum...@guac-dev.org> > wrote: > ... > > > > 2) Personally I don't have an affinity for one CI system or another - if > > > ASF pr

[GitHub] guacamole-website pull request #56: Document frequently asked questions.

2018-01-23 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/56 Document frequently asked questions. [As discussed on the user@ list](https://lists.apache.org/thread.html/556f4473cd20cf9e504f313eb328c214ab7236404919de003ed1e5df

Re: RDS Broker (load balance) support

2018-01-23 Thread Mike Jumper
On Tue, Jan 23, 2018 at 12:33 PM, Kris Keller wrote: > My team currently runs a custom version of the guacamole server based off > of version 0.9.9. We recently merged in commits from GUACAMOLE-40< > https://issues.apache.org/jira/browse/GUACAMOLE-40> to get support

[DISCUSS] Migration to some sane versioning methodology

2018-01-23 Thread Mike Jumper
Hello all, Guacamole has been in never-ending 0.9.x mode for a while, with a few huge releases still receiving no more than a patch number bump. I think we should look to migrating to a version numbering scheme which forces us to assign numbers more rigorously based on compatibility and the

[GitHub] guacamole-server pull request #133: GUACAMOLE-484: Ensure disconnect reason ...

2018-01-22 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/133 GUACAMOLE-484: Ensure disconnect reason code is checked for orderly RDP disconnect. This change shifts the RDP disconnect handling logic down such that the disconnect reason code

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r162830292 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -185,16 +185,6

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r162829956 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -185,16 +185,6

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r162824042 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -185,16 +185,6

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r162797362 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -328,20 +273,40

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r162797317 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -185,16 +185,6

[GitHub] guacamole-server pull request #126: GUACAMOLE-456: use Docker multi-stage bu...

2018-01-19 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/126#discussion_r162736330 --- Diff: Dockerfile --- @@ -76,13 +68,63 @@ COPY src/guacd-docker/bin /opt/guacd/bin/ COPY . "$BUILD_DIR" # Build

[ANNOUNCE] Apache Guacamole 0.9.14 released

2018-01-19 Thread Mike Jumper
The Apache Guacamole community is proud to announce the release of Apache Guacamole 0.9.14. Apache Guacamole is a clientless remote desktop gateway which supports standard protocols like VNC, RDP, and SSH. We call it "clientless" because no plugins or client software are required; once Guacamole

[GitHub] guacamole-website pull request #55: Release 0.9.14.

2018-01-18 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/55 Release 0.9.14. This change marks 0.9.14 as released, and updates the top-level symbolic links to the latest documentation. We'll still need to hold off on actually

[RESULT] [VOTE] Release Apache Guacamole 0.9.14 (RC1)

2018-01-18 Thread Mike Jumper
On Sun, Jan 14, 2018 at 2:06 PM, Mike Jumper <mike.jum...@guac-dev.org> wrote: > Hello all, > > The first release candidate for Apache Guacamole 0.9.14 has been uploaded > and is ready for VOTE. The draft release notes (along with links to > artifacts, signatures/c

[GitHub] guacamole-client pull request #229: GUACAMOLE-161: Do not rely on receiving ...

2018-01-17 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/229 GUACAMOLE-161: Do not rely on receiving keyup for Caps Lock on Mac. As noted by @flangelo in #209, Caps Lock will only result in keydown events on Mac OS X (keyup events

[GitHub] guacamole-client pull request #225: GUACAMOLE-96: Allow extensions to decora...

2018-01-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/225#discussion_r162236186 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/DecoratingDirectory.java --- @@ -0,0 +1,133 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-01-15 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r161638782 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/PromptEntry.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #227: GUACAMOLE-232: Handle known platform/bro...

2018-01-15 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/227#discussion_r161623546 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -55,6 +55,47 @@ Guacamole.Keyboard = function(element

[GitHub] guacamole-client pull request #227: GUACAMOLE-232: Handle known platform/bro...

2018-01-15 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/227#discussion_r161620053 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -55,6 +55,47 @@ Guacamole.Keyboard = function(element

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-15 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r161587484 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java --- @@ -113,56

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-15 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r161586442 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java --- @@ -113,56

[GitHub] guacamole-client pull request #228: GUACAMOLE-352: Work around lack of key e...

2018-01-14 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/228 GUACAMOLE-352: Work around lack of key events for dead keys. Some platforms (but not all) will not send traditional keydown/keypress/keyup events for [dead keys](https

[GitHub] guacamole-client pull request #227: GUACAMOLE-161: Handle known platform/bro...

2018-01-14 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/227 GUACAMOLE-161: Handle known platform/browser keyboard quirks semantically. This change adds a new private set of boolean flags within `Guacamole.Keyboard` which tracks whether certain

[GitHub] guacamole-client pull request #226: GUACAMOLE-447: Add UIKit key constants s...

2018-01-14 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/226 GUACAMOLE-447: Add UIKit key constants sometimes (incorrectly) used by iOS Safari. See: https://lists.apache.org/thread.html/8efe6e11b9ff53bd041eb970e7c672a9bc05264eb6ffe2f1736d

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161414160 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/RadiusConnectionService.java --- @@ -0,0 +1,276

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161414054 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/RadiusConnectionService.java --- @@ -0,0 +1,276

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161414061 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/RadiusConnectionService.java --- @@ -0,0 +1,276

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161413713 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/RadiusChallengeResponseField.java --- @@ -0,0

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161413598 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/RadiusStateField.java --- @@ -0,0 +1,63

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161413980 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/RadiusGuacamoleProperties.java --- @@ -0,0 +1,191

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161414113 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/RadiusConnectionService.java --- @@ -0,0 +1,276

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161413619 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/RadiusStateField.java --- @@ -0,0 +1,63

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161414028 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/RadiusConnectionService.java --- @@ -0,0 +1,276

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161413644 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/RadiusChallengeResponseField.java --- @@ -0,0

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161413652 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/RadiusChallengeResponseField.java --- @@ -0,0

[GitHub] guacamole-client pull request #122: GUACAMOLE-197: Implement Support for RAD...

2018-01-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/122#discussion_r161413608 --- Diff: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/RadiusStateField.java --- @@ -0,0 +1,63

[VOTE] Release Apache Guacamole 0.9.14 (RC1)

2018-01-14 Thread Mike Jumper
Hello all, The first release candidate for Apache Guacamole 0.9.14 has been uploaded and is ready for VOTE. The draft release notes (along with links to artifacts, signatures/checksums, and updated documentation) can be found here: http://guacamole.apache.org/releases/0.9.14/ The git tag for

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r161386520 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/PromptEntry.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r161386317 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -176,32 +176,22

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r161386315 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -176,32 +176,22

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r161386296 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -176,32 +176,22

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r161386337 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java --- @@ -113,56

[GitHub] guacamole-client pull request #204: GUACAMOLE-234: Migration from JLDAP to A...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/204#discussion_r161386243 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -124,10

[GitHub] guacamole-client pull request #224: GUACAMOLE-113: Implement hotkey for send...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/224#discussion_r161386051 --- Diff: guacamole/src/main/webapp/app/client/controllers/clientController.js --- @@ -522,21 +539,44 @@ angular.module('client').controller

[GitHub] guacamole-client pull request #224: GUACAMOLE-113: Implement hotkey for send...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/224#discussion_r161386127 --- Diff: guacamole/src/main/webapp/app/client/controllers/clientController.js --- @@ -522,21 +539,44 @@ angular.module('client').controller

[GitHub] guacamole-client pull request #224: GUACAMOLE-113: Implement hotkey for send...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/224#discussion_r161386102 --- Diff: guacamole/src/main/webapp/app/client/controllers/clientController.js --- @@ -64,16 +65,23 @@ angular.module('client').controller

[GitHub] guacamole-client pull request #224: GUACAMOLE-113: Implement hotkey for send...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/224#discussion_r161386085 --- Diff: guacamole/src/main/webapp/app/client/controllers/clientController.js --- @@ -522,21 +539,44 @@ angular.module('client').controller

[GitHub] guacamole-client pull request #224: GUACAMOLE-113: Implement hotkey for send...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/224#discussion_r161385948 --- Diff: guacamole/src/main/webapp/app/client/controllers/clientController.js --- @@ -64,16 +65,23 @@ angular.module('client').controller

[GitHub] guacamole-client pull request #225: GUACAMOLE-96: Allow extensions to decora...

2018-01-13 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/225 GUACAMOLE-96: Allow extensions to decorate each other's objects. Part of the core requirements of implementing the TOTP authentication extension is the ability to add and manage TOTP

[GitHub] guacamole-website pull request #54: Add draft release notes for first RC of ...

2018-01-12 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/54 Add draft release notes for first RC of 0.9.14. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper/guacamole-website

[GitHub] guacamole-server pull request #132: GUACAMOLE-470: Make terminal colors conf...

2018-01-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/132#discussion_r161150191 --- Diff: src/terminal/display.c --- @@ -246,7 +246,8 @@ int __guac_terminal_set(guac_terminal_display* display, int row, int col, int co

[GitHub] guacamole-server pull request #132: GUACAMOLE-470: Make terminal colors conf...

2018-01-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/132#discussion_r161148689 --- Diff: src/terminal/terminal.c --- @@ -255,52 +257,203 @@ void* guac_terminal_thread(void* data) { } -guac_terminal

[GitHub] guacamole-server pull request #132: GUACAMOLE-470: Make terminal colors conf...

2018-01-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/132#discussion_r161141682 --- Diff: src/terminal/terminal.c --- @@ -255,52 +257,203 @@ void* guac_terminal_thread(void* data) { } -guac_terminal

[GitHub] guacamole-server pull request #132: GUACAMOLE-470: Make terminal colors conf...

2018-01-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/132#discussion_r161149994 --- Diff: src/terminal/terminal.c --- @@ -255,52 +257,203 @@ void* guac_terminal_thread(void* data) { } -guac_terminal

[GitHub] guacamole-server pull request #132: GUACAMOLE-470: Make terminal colors conf...

2018-01-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/132#discussion_r161148445 --- Diff: src/terminal/display.c --- @@ -317,6 +319,9 @@ guac_terminal_display* guac_terminal_display_alloc(guac_client* client

[GitHub] guacamole-server pull request #132: GUACAMOLE-470: Make terminal colors conf...

2018-01-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/132#discussion_r161150916 --- Diff: src/terminal/terminal.c --- @@ -255,52 +257,203 @@ void* guac_terminal_thread(void* data) { } -guac_terminal

[GitHub] guacamole-website pull request #53: Add documentation for 0.9.14.

2018-01-09 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/53 Add documentation for 0.9.14. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper/guacamole-website doc-0.9.14

[GitHub] guacamole-website pull request #52: Add "Security Reports" page listing the ...

2018-01-08 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/52 Add "Security Reports" page listing the vulnerabilities fixed in particular Guacamole releases. This change adds a new "Security Reports" page which provides

[SECURITY] CVE-2017-3158: Buffer overflow in SSH/telnet terminal emulator

2018-01-08 Thread Mike Jumper
CVE-2017-3158: Buffer overflow in SSH/telnet terminal emulator Versions affected: Apache Guacamole prior to 0.9.11-incubating Description: A race condition in Guacamole's terminal emulator could allow writes of blocks of printed data to overlap. Such overlapping writes could cause packet data to

[GitHub] guacamole-manual pull request #73: GUACAMOLE-210: Document usage of OpenID C...

2018-01-07 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/73 GUACAMOLE-210: Document usage of OpenID Connect authentication extension. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike

[GitHub] guacamole-manual pull request #72: GUACAMOLE-394: Document ability to view u...

2018-01-05 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/72 GUACAMOLE-394: Document ability to view user login times. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper/guacamole

[GitHub] guacamole-client pull request #217: GUACAMOLE-394: Add interface for browsin...

2018-01-04 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/217#discussion_r159721258 --- Diff: guacamole/src/main/webapp/app/rest/types/Connection.js --- @@ -104,6 +104,15 @@ angular.module('rest').factory('Connection

[GitHub] guacamole-client pull request #222: GUACAMOLE-237: Move to new getUserMedia ...

2018-01-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/222#discussion_r159355456 --- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js --- @@ -183,14 +183,19 @@ Guacamole.RawAudioRecorder = function

[GitHub] guacamole-client pull request #222: GUACAMOLE-237: Move to new getUserMedia ...

2018-01-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/222#discussion_r159355068 --- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js --- @@ -183,14 +183,19 @@ Guacamole.RawAudioRecorder = function

[GitHub] guacamole-client pull request #222: GUACAMOLE-237: Move to new getUserMedia ...

2018-01-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/222#discussion_r159355010 --- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js --- @@ -183,14 +183,19 @@ Guacamole.RawAudioRecorder = function

[GitHub] guacamole-client pull request #222: GUACAMOLE-237: Move to new getUserMedia ...

2018-01-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/222#discussion_r159270872 --- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js --- @@ -183,14 +183,19 @@ Guacamole.RawAudioRecorder = function

[GitHub] guacamole-client pull request #222: GUACAMOLE-237: Move to new getUserMedia ...

2018-01-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/222#discussion_r159271643 --- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js --- @@ -183,14 +183,19 @@ Guacamole.RawAudioRecorder = function

[GitHub] guacamole-manual pull request #71: GUACAMOLE-394: Document schema of new gua...

2018-01-02 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/71 GUACAMOLE-394: Document schema of new guacamole_user_history table. This change adds documentation covering the schema of the new `guacamole_user_history` table added by apache

[GitHub] guacamole-manual pull request #69: GUACAMOLE-423: Bump version numbers in ma...

2018-01-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/69#discussion_r159164640 --- Diff: src/chapters/jdbc-auth.xml --- @@ -227,20 +227,13 @@ Type 'help;' or '\h' for help. Type '\c' to clear the current input statement

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2018-01-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r159164126 --- Diff: src/chapters/jdbc-auth.xml --- @@ -97,9 +97,54 @@ depends on the version of Java you have installed

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2018-01-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r159161723 --- Diff: src/chapters/jdbc-auth.xml --- @@ -97,9 +97,51 @@ depends on the version of Java you have installed

Re: I need help.

2017-12-29 Thread Mike Jumper
Could you upload the source for what you're working with somewhere that you could link to (GitHub, etc.)? The code provided is extremely difficult to read. - Mike On Dec 28, 2017 22:30, "Go Target" wrote: > Dear : > > I created a lab. I am using sample code : > > public

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r159112121 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +343,61 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r159112218 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +343,61 @@ Type "help" for help. to run any database upgra

Re: [DISCUSS] Java Version 1.6 Support

2017-12-13 Thread Mike Jumper
On Wed, Dec 13, 2017 at 8:37 AM, Nick Couchman wrote: > On Wed, Dec 13, 2017 at 7:25 AM, carl harris > wrote: > ... > > I've worked on lots of library projects, producing code that is intended > > to be incorporated on the class path of someone else's

[GitHub] guacamole-client pull request #216: Spanish translation for guacamole client

2017-12-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/216#discussion_r156449473 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/guac-manifest.json --- @@ -21,7 +21,8

[GitHub] guacamole-client pull request #217: GUACAMOLE-394: Add interface for browsin...

2017-12-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/217 GUACAMOLE-394: Add interface for browsing user access history. Analogous to the connection history REST endpoint, these changes add a new user history endpoint which lists the start

Re: Debug logging in Guacamole?

2017-12-11 Thread Mike Jumper
input event logging to Guacamole's existing session recording functionality on the "input-log" branch of my GitHub forks of guacamole-client and guacamole-server: https://github.com/mike-jumper/guacamole-client/tree/input-log https://github.com/mike-jumper/guacamole-server/tree/input-log Yo

Re: INFO : Print automatically by appending string in Ghostscript

2017-12-10 Thread Mike Jumper
On Dec 10, 2017 22:12, "Amarjeet Singh" wrote: I have tested it in Edge, Chrome, Firefox and IE . Adobe Acrobat Reader is required in the client machine to view it in iframe which lacks inbuilt PDF Viewer ( only in Internet Explorer ) And if the user lacks a PDF viewer,

Re: INFO : Print automatically by appending string in Ghostscript

2017-12-10 Thread Mike Jumper
On Dec 10, 2017 21:07, "Amarjeet Singh" wrote: Thanks Mike. I have done that. I have appended the name action. Now, It automatically opens the print menu of the browser when we click on Guacamole Printer to print documents instead of downloading the documents. Finally did

Re: guacd: Exposing filesystem to non-owner users

2017-12-10 Thread Mike Jumper
On Sun, Dec 10, 2017 at 7:04 AM, Or Cohen <o...@strigo.io> wrote: > On Sun, Dec 10, 2017 at 2:09 AM, Mike Jumper <mike.jum...@guac-dev.org> > wrote: > > > On Thu, Dec 7, 2017 at 6:44 AM, Or Cohen <o...@strigo.io> wrote: > > > > I was thinking of adding

Re: INFO : Print automatically by appending string in Ghostscript

2017-12-09 Thread Mike Jumper
On Sat, Dec 9, 2017 at 10:02 PM, Amarjeet Singh wrote: > I want to append the Print Named Action in the same PostScript file that is > being received via RDP to the file descriptor. > To append, you would write() your PostScript immediately prior to closing the file

Re: [DISCUSS] Java Version 1.6 Support

2017-12-09 Thread Mike Jumper
On Tue, Oct 31, 2017 at 6:18 AM, Nick Couchman wrote: > This has come up in a couple of PRs, so I wanted to throw this out for > discussion. Currently most of the Guacamole client code is targeted at > Java 1.6 compatibility (via entries in the pom.xml files). There have been

Re: guacd: Exposing filesystem to non-owner users

2017-12-09 Thread Mike Jumper
On Thu, Dec 7, 2017 at 6:44 AM, Or Cohen wrote: > Hi, > > I have a use-case where I need to enable other users to access the > filesystem object. Looking at the (server) code, I saw that it's not shared > with users that are not the owners and that it's intentional. > I also saw

Re: INFO : Print automatically by appending string in Ghostscript

2017-12-09 Thread Mike Jumper
On Sat, Dec 9, 2017 at 12:07 PM, Amarjeet Singh wrote: > How can I append print named action in the post script file before > ghostscript converts it into pdf ? > > The GhostScript process created to handle each print job reads its input from a pipe, while the Guacamole

[GitHub] guacamole-server pull request #128: GUACAMOLE-307: The "size" instruction ca...

2017-12-08 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/128 GUACAMOLE-307: The "size" instruction can also apply to buffers, not just layers. When running the guacenc utility against Guacamole session recordings, the followi

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r155416624 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +321,60 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r155416513 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +321,60 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r155417320 --- Diff: src/chapters/jdbc-auth.xml --- @@ -413,12 +509,29 @@ postgresql-password: some_password

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r155415572 --- Diff: src/chapters/jdbc-auth.xml --- @@ -97,9 +97,29 @@ depends on the version of Java you have installed

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r155416928 --- Diff: src/chapters/jdbc-auth.xml --- @@ -413,12 +509,29 @@ postgresql-password: some_password

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r155416416 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +321,60 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-server pull request #127: GUACAMOLE-423: Bump version number to 0....

2017-12-06 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/127 GUACAMOLE-423: Bump version number to 0.9.14 Note that this change also: * Updates the libtool version info for libguac * With the exception of the `guacctl` utility

[GitHub] guacamole-client pull request #214: GUACAMOLE-423: Bump version numbers for ...

2017-12-06 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/214 GUACAMOLE-423: Bump version numbers for all modified components to 0.9.14. Absolutely everything has been modified for 0.9.14, with the slight exception of guacamole-common which

<    2   3   4   5   6   7   8   >