Re: hbaseblog content

2011-12-13 Thread Jonathan Gray
The data is on a server being held hostage at a data center in Los Angeles. I need to pay off my balance with them so I can get it back. Oops. So, I will eventually be able to get the data back. I have other data I need to recover off that server so will definitely get the server back in the

Re: Rename book to manual, redux

2011-12-05 Thread Jonathan Gray
+1 On Mon, Dec 5, 2011 at 6:29 PM, Nicolas Spiegelberg nspiegelb...@fb.com wrote: +1 On 12/5/11 4:28 PM, Doug Meil doug.m...@explorysmedical.com wrote: Hi folks- Sorry to reopen this, but hopefully only briefly.  I'm fine with renaming it something else not book, but in taking a few samples

Re: rename book to manual?

2011-12-02 Thread Jonathan Gray
+1 On Dec 2, 2011, at 6:29 PM, Todd Lipcon t...@cloudera.com wrote: Just an idle thought on a Friday evening: I always find it confusing that we have two hbase books. - There's the wonderful one that Doug primarily maintains in SVN: http://hbase.apache.org/book.html - and the other

RE: SILT - nice keyvalue store paper

2011-10-23 Thread Jonathan Gray
Very nice experiment, Akash. Keep getting your hands dirty and digging! :) I think your results might change if you bump the test up to 1000 threads or so. 100 threads can still perform okay when there's a global lock but the contention at 1000 threads will kill you and that's when CSLM

RE: [unit tests] small tests vs. others

2011-10-20 Thread Jonathan Gray
+1 on small/medium/large. -Original Message- From: Todd Lipcon [mailto:t...@cloudera.com] Sent: Thursday, October 20, 2011 1:49 PM To: dev@hbase.apache.org Subject: Re: [unit tests] small tests vs. others +1 on separating into small/medium/large. One of the requirements of small

RE: HBase releases...

2011-10-17 Thread Jonathan Gray
: vrodio...@carrieriq.com From: Jonathan Gray [jg...@fb.com] Sent: Thursday, October 13, 2011 7:12 PM To: dev@hbase.apache.org Subject: RE: HBase releases... Vladimir, I appreciate the contributions of your company and welcome your personal input around

RE: HBase releases...

2011-10-13 Thread Jonathan Gray
+1 on all of this below. I'm all for frequent releases. Big features move to branches and the author is required to keep it up against whatever the current trunk is. And by forcing ourselves to keep features/improvements into trunk rather than into the currently active branch, we will

RE: HBase releases...

2011-10-13 Thread Jonathan Gray
Engineer Carrier IQ, www.carrieriq.com e-mail: vrodio...@carrieriq.com From: Jonathan Gray [jg...@fb.com] Sent: Thursday, October 13, 2011 4:35 PM To: dev@hbase.apache.org Subject: RE: HBase releases... +1 on all of this below. I'm all

RE: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-27 Thread Jonathan Gray
+1 for 0.92 -Original Message- From: Todd Lipcon [mailto:t...@cloudera.com] Sent: Tuesday, July 26, 2011 11:27 PM To: dev@hbase.apache.org Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94? +1 to the idea of putting it in. I'm going to try to do a code review

RE: Converting byte[] to ByteBuffer

2011-07-11 Thread Jonathan Gray
In my experience, CPU usage on HBase is very high for highly concurrent applications. You can expect the CMS GC to chew up 2-3 cores at sufficient throughput and the remaining cores to be spent in CSLM/MemStore, KeyValue comparators, queues, etc. -Original Message- From: Jason

RE: Converting byte[] to ByteBuffer

2011-07-10 Thread Jonathan Gray
There are plenty of arguments in both directions for caching above the DB, in the DB, or under the DB/in the FS. I have significant interest in supporting large heaps and reducing GC issues within the HBase RegionServer and I am already running with local fs reads. I don't think a faster dfs

RE: prefix compression

2011-06-02 Thread Jonathan Gray
for comparison, and never call functions like getBuffer), getRowKeyOffset(), getRowKeyLength() expecting that to show us a byte array range with a row key in it. I think Jonathan Gray has some code hacked together for this, but last I heard it wasn't in shippable state... Jonathan, you out

RE: hbase 0.90.2 Release Candidate 0 available for download

2011-04-07 Thread Jonathan Gray
+1 Have been running with most of the stuff in 0.90.2 on a significant workload. -Original Message- From: saint@gmail.com [mailto:saint@gmail.com] On Behalf Of Stack Sent: Sunday, March 27, 2011 3:52 PM To: HBase Dev List Subject: ANN: hbase 0.90.2 Release Candidate 0

RE: gauging cost of region movement

2011-03-21 Thread Jonathan Gray
This is an interesting direction, and definitely file a JIRA as this could be an additional metric in the future, but it's not exactly what I had in mind. One of the hardest parts of load balancing based on request count and other dynamic/transient measures is that you can get some pretty

RE: gauging cost of region movement

2011-03-21 Thread Jonathan Gray
Also, using more stable measures of request count will help, such as 30 minute rolling averages. -Original Message- From: Jonathan Gray [mailto:jg...@fb.com] Sent: Monday, March 21, 2011 4:23 PM To: dev@hbase.apache.org Subject: RE: gauging cost of region movement

RE: retrieving HRegion's in AssignmentManager

2011-03-14 Thread Jonathan Gray
You can't do a HashMap with a byte[] as the Key, unfortunately. You'll have to use a TreeMap (where you can specify a comparator), use a wrapping class, or you could even make it a HashSet or TreeSet with RegionLoad as the only type (and then write a comparator for RegionLoad which compares

RE: what's the roadmap of secondary index of hbase?

2011-03-01 Thread Jonathan Gray
Right. Rather than another table, you use another column family in the primary table a la Megastore and Lily. -Original Message- From: Ted Yu [mailto:yuzhih...@gmail.com] Sent: Tuesday, March 01, 2011 9:42 AM To: dev@hbase.apache.org; apurt...@apache.org Subject: Re: what's the

RE: what's the roadmap of secondary index of hbase?

2011-02-28 Thread Jonathan Gray
I've started a wiki page: http://wiki.apache.org/hadoop/Hbase/SecondaryIndexing I gave a basic description of the idea I had and the open questions. Let's get all our thoughts in there. -Original Message- From: saint@gmail.com [mailto:saint@gmail.com] On Behalf Of Stack

RE: what's the roadmap of secondary index of hbase?

2011-02-25 Thread Jonathan Gray
I've started my write-up. Hopefully will have it posted by Monday night. There's also some people at FB who may want to work on this. There are a few different ways that secondary indexing can go so there might be an opportunity to work on a few different mechanisms if many people are

RE: Online modify table schema (e.g. AddColumnFamily, DeleteColumnFamily, etc) and other features

2011-01-20 Thread Jonathan Gray
I have following questions about some features which are needed in my applications. 1. The current HBase release(0.89, 0.90 ~) does not support to modify table schema online. If I want add or delete a ColumnFamily, I must disable/offline the table firstly. Is there a plan to

RE: The fourth hbase 0.90.0 release candidate is available for download X

2011-01-14 Thread Jonathan Gray
+1 on RC3. Been running this in pre-production without issue for a while. -Original Message- From: saint@gmail.com [mailto:saint@gmail.com] On Behalf Of Stack Sent: Friday, January 07, 2011 5:03 PM To: HBase Dev List Subject: ANN: The fourth hbase 0.90.0 release candidate is

RE: incrementColumnValue, WAL and timestamp

2011-01-12 Thread Jonathan Gray
I think there are some hacky fixes in there to prevent duplicate timestamps. With the new seqid, this should not be an issue. I think we should then be able to generate a single now() value and use it everywhere (MemStore, HLog). Duplicate timestamps won't be a problem as the seqid ordering

RE: question about Hregion.incrementColumnValue

2011-01-10 Thread Jonathan Gray
How does doing currentTimeMillis() twice in a row guarantee different timestamps? And in this case, we're talking about the MemStore vs. HLog not HFile. There is another section of the code where there is a timestamp+1 to avoid duplicates but this is something else. -Original

RE: No minor compactions on a table built only on bulk loads

2011-01-10 Thread Jonathan Gray
It's not really a bug. I think the assumption is that if you are at the level of doing your own bulk loads, you should also manage when you want to compact and split. I know in cases where I've done this, I would usually know at certain points I would want to trigger major compactions. At

RE: Trend Micro HBase summit Jan 11 - 14

2011-01-05 Thread Jonathan Gray
I'll be in town 13th/14th and would be happy to stop by for a bit. -Original Message- From: saint@gmail.com [mailto:saint@gmail.com] On Behalf Of Stack Sent: Wednesday, January 05, 2011 1:00 PM To: dev@hbase.apache.org; apurt...@apache.org Subject: Re: Trend Micro HBase

RE: provide a 0.20-append tarball?

2010-12-22 Thread Jonathan Gray
guidelines. But that is the legal situation, not the community situation which is of course more complex. My stand on this is the one I have always taken. I need a HBase that works, well, and with no data loss. -ryan On Wed, Dec 22, 2010 at 2:55 AM, Jonathan Gray jg...@fb.com wrote

Re: Review Request: HBASE-3256: Coprocessors: Coprocessor host and observer for HMaster

2010-12-20 Thread Jonathan Gray
, Andrew Purtell, and Jonathan Gray. Summary --- This patch adds a new MasterObserver interface with pre/post hooks provided for operations defined in org.apache.hadoop.hbase.ipc.HMasterInterface. In order to accommodate the new MasterObserver interface, I've also refactored out

Re: Review Request: hbase-3362 If .META. offline between OPENING and OPENED, then wrong server location in .META. is possible

2010-12-16 Thread Jonathan Gray
/ --- (Updated 2010-12-15 16:14:27) Review request for hbase and Jonathan Gray. Summary --- M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java Removed stale comments and TODOs. Added a 'version' datamenber, the znode edit version which we keep across

Re: Review Request: hbase-3362 If .META. offline between OPENING and OPENED, then wrong server location in .META. is possible

2010-12-16 Thread Jonathan Gray
and Jonathan Gray. Summary --- M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java Removed stale comments and TODOs. Added a 'version' datamenber, the znode edit version which we keep across open process. Refactored the setting of OPENING out

RE: Build failed in Hudson: hbase-0.90 #27

2010-12-14 Thread Jonathan Gray
Somehow there's a ZK session expiration that I've not seen before... 2010-12-14 22:20:25,284 ERROR [Thread-282-EventThread] zookeeper.ClientCnxn$EventThread(532): Error while calling watcher java.lang.RuntimeException: Fatal ZK error, why=unittest-0x12ce6f79fca0009 unittest-0x12ce6f79fca0009

Re: Review Request: Allow Observers to completely override base function

2010-12-14 Thread Jonathan Gray
://review.cloudera.org/r/1295/ --- (Updated 2010-12-14 18:16:21) Review request for hbase, Jonathan Gray and Mingjie Lai. Summary --- Currently an observer can act as a filter or translator but cannot stop a subsequent call

RE: Please welcome two new hbase committers, Gary Helmling and Nicolas Spiegelberg

2010-12-02 Thread Jonathan Gray
Hip, hip, hray! Congrats guys! Keep up all the great work! Nicolas and Gary, you guys can pick the type of beer we buy for the Hackathon ;) JG -Original Message- From: jdcry...@gmail.com [mailto:jdcry...@gmail.com] On Behalf Of Jean- Daniel Cryans Sent: Thursday, December 02,

[ANNOUNCE] HBase Hackathon: Coprocessor Edition, December 13th @ Facebook

2010-12-02 Thread Jonathan Gray
What? HBase Hackathon: Coprocessor Edition When? December 13, 2010 @ 11AM Where? Facebook, Palo Alto Sign up here: http://www.meetup.com/hackathon/calendar/15597555/ Lunch, dinner, and beers will be provided. From meetup announcement... With HBase 0.90 near release, it's time to shift

Re: Review Request: Master passes IP and not hostname back to region server

2010-11-30 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1262/#review2012 --- Ship it! A little confused by the discrepancy between String host /

Re: Review Request: Master passes IP and not hostname back to region server

2010-11-30 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1262/#review2013 --- Ship it! A little confused by the discrepancy between String host /

Re: Review Request: Add option to cache blocks on hfile write and evict blocks on hfile close

2010-11-30 Thread Jonathan Gray
the behavior). - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1261/#review2010 --- On 2010-11-29 23:22:38, Jonathan Gray

Re: Review Request: Add option to cache blocks on hfile write and evict blocks on hfile close

2010-11-30 Thread Jonathan Gray
the reason why we'd want to keep things in the LRU. It would make more sense not to evict on a split, but evict every other time, since a split will probably reopen the same hfiles and need those blocks again. Jonathan Gray wrote: I think it makes sense to have undocumented

Review Request: Need to retain DeadServers to ensure we don't allow previously expired RS instances to rejoin cluster

2010-11-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1259/ --- Review request for hbase and stack. Summary --- We currently let go of

HBase Coprocessor Hackathon on December 13th @ Facebook

2010-11-29 Thread Jonathan Gray
HBase Devs, We're in the final stages of planning an all-day HBase Hackathon on 12/13 at Facebook. The focus will be on Coprocessors although we'll probably also spend some time talking about what's next for HBase (0.92 and beyond). The Trend Micro team will be available on the 13th which is

Re: Review Request: Need to retain DeadServers to ensure we don't allow previously expired RS instances to rejoin cluster

2010-11-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1259/ --- (Updated 2010-11-29 11:43:07.682958) Review request for hbase and stack.

Review Request: Add option to cache blocks on hfile write and evict blocks on hfile close

2010-11-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1261/ --- Review request for hbase, stack and khemani. Summary --- This issue is

Re: Review Request: hbase-3267 close_region shell command breaks region

2010-11-24 Thread Jonathan Gray
: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1250/ --- (Updated 2010-11-24 15:09:00) Review request for hbase and Jonathan Gray. Summary --- So, things

Re: Review Request: hbase-3267 close_region shell command breaks region

2010-11-24 Thread Jonathan Gray
) Review request for hbase and Jonathan Gray. Summary --- So, things are different in the new master. Close region should close region. Not close and then reopen. To close and reopen elsewhere, thats an unassign or a move (both of which were missing from shell but which

Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-11-11 Thread Jonathan Gray
-2990. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/#review1906 --- On 2010-11-10 17:04:39, Jonathan Gray wrote

Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-11-11 Thread Jonathan Gray
--- On 2010-11-10 17:04:39, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/ --- (Updated 2010-11-10 17:04

Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-11-11 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/ --- (Updated 2010-11-11 09:53:02.338546) Review request for hbase, stack and

Re: Review Request: hbase-3227 Edit of log messages before branching...

2010-11-11 Thread Jonathan Gray
and Jonathan Gray. Summary --- Removed redundancy, corrected some of the english in log messages, changed at least one to DEBUG. This addresses bug hbase-3227. http://issues.apache.org/jira/browse/hbase-3227 Diffs - trunk/src/main/java/org/apache/hadoop/hbase

Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-11-11 Thread Jonathan Gray
generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/#review1914 --- On 2010-11-11 09:53:02, Jonathan Gray wrote: --- This is an automatically generated e-mail

Re: Review Request: HBASE-3211 Key only filter

2010-11-10 Thread Jonathan Gray
:26, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1208/ --- (Updated 2010-11-10 15:19:26) Review request

Re: Review Request: HBASE-3211 Key only filter

2010-11-10 Thread Jonathan Gray
-10 15:19:26, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1208/ --- (Updated 2010-11-10 15:19:26) Review

Re: Review Request: HBASE-3211 Key only filter

2010-11-10 Thread Jonathan Gray
: http://review.cloudera.org/r/1208/#review1893 --- On 2010-11-10 15:19:26, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-11-10 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/ --- (Updated 2010-11-10 16:53:29.452432) Review request for hbase, stack and

Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-11-10 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/ --- (Updated 2010-11-10 16:55:42.907573) Review request for hbase, stack and

Re: Review Request: HBASE-3211 Key only filter

2010-11-10 Thread Jonathan Gray
that the program must call modifyKeyValue() to get the transformed data. Maybe this is too much of a one-off case... Jonathan Gray wrote: Not sure I completely follow. You're saying the modification would happen outside the filter? No one needs to call modifyKeyValue() to get

Review Request: HBASE-3168 Sanity date and time check when a region server joins the cluster

2010-11-09 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1193/ --- Review request for hbase and stack. Summary --- This is patch from Jeff

Re: Review Request: HBASE-3168 Sanity date and time check when a region server joins the cluster

2010-11-09 Thread Jonathan Gray
of this, there's more to do. As-is, the RS will keep looping trying to do startup even if it gets IOE. We just retry in loop w/ a sleep. Need to do explicit catch / check if instance of ClockSkew exception and then just shut down instead of keep trying. - Jonathan On 2010-11-09 16:30:53, Jonathan Gray

Re: Review Request: hbase-3112 Enable and disable of table needs a bit of loving in new master

2010-11-08 Thread Jonathan Gray
: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1187/ --- (Updated 2010-11-08 11:47:12) Review request for hbase and Jonathan Gray. Summary --- Renamed

Re: Review Request: hbase-3112 Enable and disable of table needs a bit of loving in new master

2010-11-08 Thread Jonathan Gray
) Review request for hbase and Jonathan Gray. Summary --- Renamed ZKTableDisable as ZKTable, making it a generic zk util for managing 'tables'. Added enabing/disabling states to table the current set of enabled/disabled only. M src/main/java/org/apache/hadoop/hbase/zookeeper

Re: Review Request: HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too

2010-11-08 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1188/#review1851 --- Ship it! looks good to me - Jonathan On 2010-11-08 15:44:51,

Re: Review Request: HBASE-2896: Retain assignment information between cluster shutdown/startup

2010-11-06 Thread Jonathan Gray
generated e-mail. To reply, visit: http://review.cloudera.org/r/1186/#review1833 --- On 2010-11-06 14:38:34, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: HBASE-3048: Unify major/minor compactions

2010-11-06 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1185/ --- (Updated 2010-11-06 15:50:30.615330) Review request for hbase, stack, Kannan

Re: Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-11-01 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ --- (Updated 2010-10-31 23:06:55.505816) Review request for hbase and stack.

Re: Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-11-01 Thread Jonathan Gray
/#comment5665 should be are in transition not are not - Jonathan On 2010-10-31 23:06:55, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143

Re: Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-11-01 Thread Jonathan Gray
--- On 2010-11-01 11:47:35, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143

Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-11-01 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/ --- (Updated 2010-11-01 16:31:36.124095) Review request for hbase, stack and

Re: Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-11-01 Thread Jonathan Gray
, visit: http://review.cloudera.org/r/1143/#review1755 --- On 2010-11-01 11:47:35, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request: HBASE-3154: HBase RPC should support timeout (Hairong's patch)

2010-10-31 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1142/ --- Review request for hbase, stack and Kannan Muthukkaruppan. Summary ---

Re: Review Request: HBASE-3154: HBase RPC should support timeout (Hairong's patch)

2010-10-31 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1142/ --- (Updated 2010-10-31 12:45:13.758266) Review request for hbase, stack and Kannan

Re: Review Request: Add TimeRange support into Increment to optimize for counters that are partitioned on time

2010-10-31 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1132/#review1731 --- On 2010-10-29 19:42:21, Jonathan Gray wrote

Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-10-31 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ --- Review request for hbase and stack. Summary --- Does cleanup of RIT

Re: Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-10-31 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ --- (Updated 2010-10-31 17:05:24.252151) Review request for hbase and stack.

Re: Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-10-31 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ --- (Updated 2010-10-31 22:17:45.677862) Review request for hbase and stack.

Re: Review Request: Cleanup of RIT timeouts and server shutdown handling

2010-10-31 Thread Jonathan Gray
good. Needs stack cluster testing. - Jonathan On 2010-10-31 22:17:45, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143

HBase 0.90 down to 30 jiras

2010-10-30 Thread Jonathan Gray
Hey guys, Only 30 JIRAs left open against 0.90! Everyone give them another run-down and post an update on open JIRAs that are assigned to you or that you opened.

Review Request: HBASE-3163 If we timeout PENDING_CLOSE and send another closeRegion RPC, need to handle NSRE from RS (comes as a RemoteException)

2010-10-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1130/ --- Review request for hbase and stack. Summary --- Unwraps RemoteExceptions

Review Request: HBASE-2253: Show Block cache hit ratio for requests where cacheBlocks=true

2010-10-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1131/ --- Review request for hbase, stack and Jean-Daniel Cryans. Summary ---

Re: Review Request: Add TimeRange support into Increment to optimize for counters that are partitioned on time

2010-10-29 Thread Jonathan Gray
19:42:21, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1132/ --- (Updated 2010-10-29 19:42:21) Review

Re: Review Request: TestRollingRestart

2010-10-28 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090/ --- (Updated 2010-10-28 12:00:06.042321) Review request for hbase and stack.

Re: Review Request: TestRollingRestart

2010-10-28 Thread Jonathan Gray
which handler for which server is running. Jonathan Gray wrote: Will make your changes from below on commit. Thanks for review Stack! Okay. This is enough changes to warrant another post to RB. Let me do the changes from your review, bring in your logging changes, and put up new diff

Re: Review Request: Add separate handling of PENDING_OPEN/PENDING_CLOSE in timeout monitor and additional testing

2010-10-26 Thread Jonathan Gray
:25:36, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1087/ --- (Updated 2010-10-25 23:25:36) Review

Re: Review Request: TestRollingRestart

2010-10-26 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090/ --- (Updated 2010-10-26 00:01:59.924660) Review request for hbase and stack.

RE: hbase monitoring through stargate

2010-10-26 Thread Jonathan Gray
If monitoring is inside firewall, then why do you have to open ports? Requiring all monitoring to go through port 80 seems rather odd. Your ops guys don't support ganglia, jmx, etc. on standard or custom ports? -Original Message- From: Ted Yu [mailto:yuzhih...@gmail.com] Sent:

Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)

2010-10-25 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/ --- Review request for hbase, stack and khemani. Summary --- This is a

Review Request: TestRollingRestart

2010-10-25 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090/ --- Review request for hbase and stack. Summary --- First go at a

Re: Review Request: TestRollingRestart

2010-10-25 Thread Jonathan Gray
--- On 2010-10-25 10:15:12, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090

Re: Review Request: TestRollingRestart

2010-10-25 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090/ --- (Updated 2010-10-25 14:02:19.371332) Review request for hbase and stack.

Re: Review Request: Increment multiple columns in a row at once

2010-10-25 Thread Jonathan Gray
will not get multiple matches per column. On 2010-10-24 21:41:48, Jonathan Gray wrote: public long upsert(ListKeyValue kvs) { Should this be private? If it were private then would you have removed the this.readLock.lock() locking? it's called from outside MemStore so needs to be public

Re: Review Request: Increment multiple columns in a row at once

2010-10-25 Thread Jonathan Gray
a bit and accidently duplicating a timestamp inside the snapshot. Jonathan Gray wrote: what do you mean by optional? there shouldn't be any real difference. this code is basically the exact same code that was there but now pulled into a method that can be reused. Ryan Rawson wrote

Re: Review Request: Increment multiple columns in a row at once

2010-10-25 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1088/ --- (Updated 2010-10-25 15:06:49.931026) Review request for hbase, stack and

Re: Review Request: HBASE-2753 remove sorting from Result

2010-10-25 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1092/#review1661 --- Ship it! looks good to me - Jonathan On 2010-10-25 15:24:13, Ryan

Re: Review Request: Add separate handling of PENDING_OPEN/PENDING_CLOSE in timeout monitor and additional testing

2010-10-25 Thread Jonathan Gray
should commit :) trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java http://review.cloudera.org/r/1087/#comment5542 Should we remove this code from inside of ServerShutdownHandler now? Not a big deal but being done twice. - Jonathan On 2010-10-25 16:29:36, Jonathan Gray

RE: serverManager.deadServers

2010-10-25 Thread Jonathan Gray
When a server is shutdown on the master, it is added to the deadServers list. This is so if we somehow get a report from this region server, we know to reject it (YouAreDeadException). That happens when an RS goes into a long GC pause, for example. -Original Message- From: Ted Yu

Review Request: Add separate handling of PENDING_OPEN/PENDING_CLOSE in timeout monitor and additional testing

2010-10-24 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1087/ --- Review request for hbase and stack. Summary --- Adds new handling of the

Re: Review Request: Increment multiple columns in a row at once

2010-10-24 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1088/#review1641 --- On 2010-10-24 19:29:07, Jonathan Gray wrote

Re: Review Request: Unit test and fix for multi-threaded executor service

2010-10-23 Thread Jonathan Gray
23:27:28, Jonathan Gray wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1064/ --- (Updated 2010-10-22 23:27:28) Review

Re: Review Request: Review compaction heuristic and move compaction code out so standalone and independently testable

2010-10-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1078/ --- (Updated 2010-10-22 23:39:07.148296) Review request for hbase, stack, Nicolas,

Re: Review Request: Review compaction heuristic and move compaction code out so standalone and independently testable

2010-10-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1078/#review1634 --- On 2010-10-22 23:39:07, Jonathan Gray wrote: --- This is an automatically

Re: Review Request: Review compaction heuristic and move compaction code out so standalone and independently testable

2010-10-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1078/ --- (Updated 2010-10-23 00:39:51.093557) Review request for hbase, stack, Nicolas,

Re: Review Request: Review compaction heuristic and move compaction code out so standalone and independently testable

2010-10-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1078/ --- (Updated 2010-10-23 00:48:28.858137) Review request for hbase, stack, Nicolas,

Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg

2010-10-22 Thread Jonathan Gray
: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1057/ --- (Updated 2010-10-22 11:59:16) Review request for hbase, Jean-Daniel Cryans and Jonathan Gray. Summary

  1   2   >