[jira] [Created] (HIVE-20845) Fix TestJdbcWithDBTokenStoreNoDoAs flakiness

Peter Vary created HIVE-20845: - Summary: Fix TestJdbcWithDBTokenStoreNoDoAs flakiness Key: HIVE-20845 URL: https://issues.apache.org/jira/browse/HIVE-20845 Project: Hive Issue Type: Test

Re: Ptests not working

Likely not ptest issue, but restarted ptest anyway. It says: (pending—Waiting for next available executor on Hadoop ) So maybe Apache infra issue? > On Oct 31, 2018, at 01:20, Jesus Camacho Rodriguez > wrote: > > It seems we are not getting executors…

Re: [ANNOUNCE] New PMC Member : Zoltan

Congratulations Zoltan! Well deserved! > On Oct 31, 2018, at 06:16, Prasanth Jayachandran > wrote: > > Congratulations! > >> On Oct 30, 2018, at 10:15 PM, Deepak Jaiswal >> wrote: >> >> Congratulations Zoltan! >> >> On 10/30/18, 10:08 PM, "Ashutosh Chauhan" wrote: >> >>Hello Hive co

[jira] [Created] (HIVE-20836) Fix TestJdbcDriver2.testYarnATSGuid flakiness

Peter Vary created HIVE-20836: - Summary: Fix TestJdbcDriver2.testYarnATSGuid flakiness Key: HIVE-20836 URL: https://issues.apache.org/jira/browse/HIVE-20836 Project: Hive Issue Type: Test

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210036 --- Ship it! Ship It! - Peter Vary On okt. 25, 2018, 1:36 du

Re: Review Request 69155: HIVE-20760: Reducing memory overhead due to multiple HiveConfs

is not true, if we overwrite something the size will be smaller? - Peter Vary On okt. 25, 2018, 8:31 de, Barnabas Maidics wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

[jira] [Created] (HIVE-20777) Yetus should use the selected branch to check against not the master

Peter Vary created HIVE-20777: - Summary: Yetus should use the selected branch to check against not the master Key: HIVE-20777 URL: https://issues.apache.org/jira/browse/HIVE-20777 Project: Hive

Re: [ANNOUNCE] New committer: Nishant Bangarwa

Congratulations Nishant! > On Oct 19, 2018, at 07:42, Sankar Hariappan > wrote: > > Congrats Nishant! > > Best regards > Sankar > > > > > > > > > > On 15/10/18, 12:45 PM, "Ashutosh Chauhan" wrote: > >> Apache Hive's Project Management Committee (PMC) has invited Nishant >> Bangarwa

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

g/r/68975/#comment294283> I am not really a big fun of printing a stacktrace and rethrowing an error, unless I am quite sure that the exception rethrown is not printed later. Otherwise this could be quite confusing. - Peter Vary On okt. 18,

Re: skip batching of tests

You should go to the ptest server itself and modify /usr/local/hiveptest/profiles/master-mr2.properties to change the configuration > On Oct 17, 2018, at 11:36, Prasanth Jayachandran > wrote: > > Hi > > master-mr2.properties has to be updated on the ptest servers and restarted > afaik (atlea

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

/metadata/SessionHiveMetaStoreClient.java Lines 1020-1031 (patched) <https://reviews.apache.org/r/68975/#comment293845> This code path is repeated like 5 times in this file. Not this patch, but should not be a better way to handle this in a follow-up? - Peter Vary On okt. 10, 2018

Re: [ANNOUNCE] New committer: Janaki Lahorani

Congratulations Janaki! > On Oct 9, 2018, at 20:20, Deepak Jaiswal wrote: > > Congratulations Janaki. > > On 10/9/18, 8:52 AM, "Vihang Karajgaonkar" > wrote: > >Congratulations Janaki! > >On Tue, Oct 9, 2018 at 8:27 AM Andrew Sherman > >wrote: > >> Congratulations Janaki! >>

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

ass, it might be a good idea to merge with close. - Peter Vary On szept. 26, 2018, 1:08 du, denys kuzmenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 68828: HIVE-20601 : EnvironmentContext null in ALTER_PARTITION event in DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68828/#review209069 --- Ship it! Ship It! - Peter Vary On szept. 24, 2018, 8:42 du

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

th-resources) - If we decide to keep tryAcquire - can we do it as a wrapper around the tryLock method - Peter Vary On szept. 19, 2018, 9:37 de, denys kuzmenko wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

eviews.apache.org/r/68683/ > --- > > (Updated szept. 17, 2018, 5:55 du) > > > Review request for hive, Zoltan Haindrich, Zoltan Haindrich, Naveen Gangam, > and Peter Vary. > > > Bugs: HIVE-20535 > htt

Re: Review Request 61663: WebUI query plan graphs

<https://reviews.apache.org/r/61663/#comment292719> After committing the change, please do not forget to update the configuration Wiki. :) - Peter Vary On szept. 7, 2018, 3:24 du, Karen Coppage wrote: > > --- > This is an au

Re: Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

. Thanks, Peter ql/src/test/queries/clientnegative/create_unknown_permanent_udf.q Lines 1 (patched) <https://reviews.apache.org/r/68523/#comment291769> What is the difference between the create_function_nonexistent_class.q and this new test? Do we need both? - Peter Vary On a

Re: Review Request 68496: Optimized & cleaned up HBaseQTest runner

any reason to create a new patch. Please remove. itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java Line 129 (original) <https://reviews.apache.org/r/68496/#comment291423> nit: Unnecessary change. If we decide for any reason to create a new patch.

Re: [ANNOUNCE] New PMC Member : Peter Vary

t 11:25 AM, Ashutosh Chauhan < > hashut...@apache.org > > > > > > > wrote: > > > > > > > > > > On behalf of the Hive PMC I am delighted to announce Peter Vary is > > > > joining > > > > > Hive PMC. > > > > > Thanks Peter for all your contributions till now. Looking forward > to > > > many > > > > > more. > > > > > > > > > > Welcome, Peter! > > > > > > > > > > Thanks, > > > > > Ashutosh > > > > > > > > > > > >

Re: [ANNOUNCE] New committer: Slim Bouguerra

Congratulations Slim! > On Jul 30, 2018, at 02:00, Ashutosh Chauhan wrote: > > Apache Hive's Project Management Committee (PMC) has invited Slim Bouguerra > to become a committer, and we are pleased to announce that he has accepted. > > Slim, welcome, thank you for your contributions, and we lo

Re: [ANNOUNCE] New PMC Member : Vineet Garg

Congratulations Vineet! > On Jul 30, 2018, at 01:59, Ashutosh Chauhan wrote: > > On behalf of the Hive PMC I am delighted to announce Vineet Garg is joining > Hive PMC. > Thanks Vineet for all your contributions till now. Looking forward to many > more. > > Welcome, Vineet! > > Thanks, > Ashut

Re: [ANNOUNCE] New PMC Member : Vihang Karajgaonkar

Congratulations Vihang! > On Jul 29, 2018, at 22:32, Vineet Garg wrote: > > Congratulations Vihang! > >> On Jul 26, 2018, at 11:27 AM, Ashutosh Chauhan wrote: >> >> On behalf of the Hive PMC I am delighted to announce Vihang Karajgaonkar >> is joining Hive PMC. >> Thanks Vihang for all your

Re: [ANNOUNCE] New PMC Member : Sahil Takiar

Congratulations Sahil! > On Jul 29, 2018, at 22:32, Vineet Garg wrote: > > Congratulations Sahil! > >> On Jul 26, 2018, at 11:28 AM, Ashutosh Chauhan wrote: >> >> On behalf of the Hive PMC I am delighted to announce Sahil Takiar is >> joining Hive PMC. >> Thanks Sahil for all your contributio

Re: [VOTE] Apache Hive 3.1.0 Release Candidate 1

Never done this before, but here is what I did: - Built from source, added my usual configs, and run some basic query tests - Downloaded the artifacts from the URL Vineet provided - Checked sha and asc signatures - Checked that the source tar.gz contains the same files that my repository If this c

[jira] [Created] (HIVE-20217) bucket7.q test results should be sorted

Peter Vary created HIVE-20217: - Summary: bucket7.q test results should be sorted Key: HIVE-20217 URL: https://issues.apache.org/jira/browse/HIVE-20217 Project: Hive Issue Type: Test

[jira] [Created] (HIVE-20183) Inserting from bucketed table can cause data loss, if the source table contains empty buckets

Peter Vary created HIVE-20183: - Summary: Inserting from bucketed table can cause data loss, if the source table contains empty buckets Key: HIVE-20183 URL: https://issues.apache.org/jira/browse/HIVE-20183

[jira] [Created] (HIVE-20179) When Tez jar-s are not on classpath HS2 keeps too long to start

Peter Vary created HIVE-20179: - Summary: When Tez jar-s are not on classpath HS2 keeps too long to start Key: HIVE-20179 URL: https://issues.apache.org/jira/browse/HIVE-20179 Project: Hive

Re: Review Request 67801: HIVE-19337 Partition whitelist regex doesn't work (and never did)

. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java Line 307 (original), 307 (patched) <https://reviews.apache.org/r/67801/#comment288745> Thanks, for catching this! Do we have tests to confirm that we use this correctly now, and it will not regress? - Peter Vary

[jira] [Created] (HIVE-20034) Roll back MetaStore exception handling changes for backward compatibility

Peter Vary created HIVE-20034: - Summary: Roll back MetaStore exception handling changes for backward compatibility Key: HIVE-20034 URL: https://issues.apache.org/jira/browse/HIVE-20034 Project: Hive

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

to upload the patch to the Jira, so Pre-Commit will run. (I often forget myself :) ) - Peter Vary On jún. 27, 2018, 2:02 du, Oleksiy Sayankin wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

> On jún. 27, 2018, 12:53 du, Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > > Lines 526 (patched) > > <https://reviews.apache.org/r/67753/diff/2/?file=2046288#file2046288line526> > > > >

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

> On jún. 27, 2018, 12:53 du, Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > > Lines 526 (patched) > > <https://reviews.apache.org/r/67753/diff/2/?file=2046288#file2046288line526> > > > >

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

iginal), 47 (patched) <https://reviews.apache.org/r/67753/#comment288331> this is exactly the same as in the default config, so we will still have a conglict here :) We might want to try: jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db_test_meta_create_objects;create=true

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

really need this? AFAIK setting locationUri should be enough - Peter Vary On jún. 27, 2018, 10:42 de, Oleksiy Sayankin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[jira] [Created] (HIVE-19976) Fix TestMiniDruidKafkaCliDriver[druidkafkamini_basic] is flakiness

Peter Vary created HIVE-19976: - Summary: Fix TestMiniDruidKafkaCliDriver[druidkafkamini_basic] is flakiness Key: HIVE-19976 URL: https://issues.apache.org/jira/browse/HIVE-19976 Project: Hive

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

alue("a2") .setLocation(metaStore.getWarehouseRoot() + "/external/a2") .addToTable(client, metaStore.getConf()); - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apac

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

e1c3dcb47f Diff: https://reviews.apache.org/r/67485/diff/5/ Changes: https://reviews.apache.org/r/67485/diff/4-5/ Testing --- Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and drop) Thanks, Peter Vary

Re: New committer announcement : Marta Kuczora

Well done Marta! Congratulations! > On Jun 20, 2018, at 21:06, Ashutosh Chauhan wrote: > > Apache Hive's Project Management Committee (PMC) has invited Marta Kuczora > to become a committer, and we are pleased to announce that he has accepted. > > Marta, welcome, thank you for your contribution

Re: [ANNOUNCE] New committer: Adam Szita

Well done Adam! Congratulations! > On Jun 20, 2018, at 21:02, Ashutosh Chauhan wrote: > > Apache Hive's Project Management Committee (PMC) has invited Adam Szita > to become a committer, and we are pleased to announce that he has accepted. > > Adam, welcome, thank you for your contributions, an

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

Ms for very large tables. Do you have any testing results > > which shows that this implementation is not any worse than what we already > > have in terms of the memory footprint? > > Peter Vary wrote: > I was able to run tests with a HMS using 4G memory dropping 1 million

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

https://reviews.apache.org/r/67485/diff/3-4/ Testing --- Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and drop) Thanks, Peter Vary

[jira] [Created] (HIVE-19922) TestMiniDruidKafkaCliDriver[druidkafkamini_basic started] to fail

Peter Vary created HIVE-19922: - Summary: TestMiniDruidKafkaCliDriver[druidkafkamini_basic started] to fail Key: HIVE-19922 URL: https://issues.apache.org/jira/browse/HIVE-19922 Project: Hive

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

https://reviews.apache.org/r/67485/diff/2-3/ Testing --- Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and drop) Thanks, Peter Vary

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review204700 --- On jún. 7, 2018, 10:31 de, Peter Vary wrote: > > --- > This is an

[jira] [Created] (HIVE-19870) HCatalog dynamic partition query can fail, if the table path is managed by Sentry

Peter Vary created HIVE-19870: - Summary: HCatalog dynamic partition query can fail, if the table path is managed by Sentry Key: HIVE-19870 URL: https://issues.apache.org/jira/browse/HIVE-19870 Project

[jira] [Created] (HIVE-19855) TestStatsUpdaterThread.testQueueingWithThreads fails often

Peter Vary created HIVE-19855: - Summary: TestStatsUpdaterThread.testQueueingWithThreads fails often Key: HIVE-19855 URL: https://issues.apache.org/jira/browse/HIVE-19855 Project: Hive Issue Type

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

://reviews.apache.org/r/67485/diff/1-2/ Testing --- Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and drop) Thanks, Peter Vary

Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b71eda4 Diff: https://reviews.apache.org/r/67485/diff/1/ Testing --- Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and drop) Thanks, Peter Vary

Review Request 67484: HIVE-19782 Flash out TestObjectStore.testDirectSQLDropParitionsCleanup

-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java 7984af6 Diff: https://reviews.apache.org/r/67484/diff/1/ Testing --- Run the TestObjectStore.java tests Thanks, Peter Vary

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

3/ Changes: https://reviews.apache.org/r/67351/diff/2-3/ Testing --- Run several performance tests with Sasha's performance tool. These optimisations shave of ~10% of the runtime Thanks, Peter Vary

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

artition does not exists. So usually we return null here which means we do not really fetching any partition data. > On June 5, 2018, 7:37 p.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > >

[jira] [Created] (HIVE-19816) TestWorkloadManager.testAsyncSessionInitFailures is flaky

Peter Vary created HIVE-19816: - Summary: TestWorkloadManager.testAsyncSessionInitFailures is flaky Key: HIVE-19816 URL: https://issues.apache.org/jira/browse/HIVE-19816 Project: Hive Issue Type

[jira] [Created] (HIVE-19795) Fix test flakyness masked by HIVE-19730

Peter Vary created HIVE-19795: - Summary: Fix test flakyness masked by HIVE-19730 Key: HIVE-19795 URL: https://issues.apache.org/jira/browse/HIVE-19795 Project: Hive Issue Type: Test

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

esp. mentioning that the advantage of > > using this method and when its better to use it. Added javadoc - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/673

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

ons shave of ~10% of the runtime Thanks, Peter Vary

[jira] [Created] (HIVE-19783) Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

Peter Vary created HIVE-19783: - Summary: Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations Key: HIVE-19783 URL: https://issues.apache.org/jira/browse/HIVE-19783 Project: Hive

[jira] [Created] (HIVE-19782) Flash out TestObjectStore.testDirectSQLDropParitionsCleanup

Peter Vary created HIVE-19782: - Summary: Flash out TestObjectStore.testDirectSQLDropParitionsCleanup Key: HIVE-19782 URL: https://issues.apache.org/jira/browse/HIVE-19782 Project: Hive Issue

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

/ Testing --- Run the new tests Thanks, Peter Vary

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

be protected? Can we use package private instead? Valid point :) Fixed. Thanks! - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67399/#review204139 --- On June 1, 2018, 10:23 a.m., Peter

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

.java 9912213 Diff: https://reviews.apache.org/r/67399/diff/2/ Changes: https://reviews.apache.org/r/67399/diff/1-2/ Testing --- Run the new tests Thanks, Peter Vary

Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

tests Thanks, Peter Vary

Re: [DISCUSS] Release of standalone-metastore

What do you think about adding a ne profile, which adds a possibility to compile the code with one command, until we separate standalone metastore to a new project? Like -Pitests, but -Pmetastore. So "mvn clean install -Pmetastore,itests" will compile everything. Alan Gates ezt írta (időpont: 201

Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

~10% of the runtime Thanks, Peter Vary

Re: Pull Request for Proxy Settings

Hi Ekrem, This is the documented way of contributing to Hive: https://cwiki.apache.org/confluence/display/Hive/HowToContribute Could you please provide your contribution according to that? Thanks, Peter > On May 14, 2018, at 2:

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review203340 --- Ship it! +1 pending tests - Peter Vary On May 16, 2018, 5

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

well? Thanks for the review! - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/#review203055 ------- On May 11, 2018, 2:13 p.m., Peter Vary wrote: > > ---

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

views.apache.org/r/67073/ > --- > > (Updated May 15, 2018, 11:18 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > --- > > Adding support to retain the time part

Re: [VOTE] Stricter commit guidelines

+1 - Hoping for something like this for a long while! Thanks for taking this up all! > On May 15, 2018, at 5:44 PM, Jesus Camacho Rodriguez > wrote: > > Forgot to mention the length of the vote in original message. > > Let's leave the vote open for a shorter period than usual, for instance 48

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review203121 --- Ship it! +1 pending tests - Peter Vary On May 14, 2018, 8

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On May 11, 2018, 10:32 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 2334 (patched) > > <https://reviews.apache.org/r/66290/diff/8/?file=2019613#file2019613line2334> > > > > Is it possible to end up with ove

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

generated e-mail. To reply, visit: > https://reviews.apache.org/r/67073/ > --- > > (Updated May 10, 2018, 9:55 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar. > > > Re

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

> On May 11, 2018, 10:08 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java > > Lines 74 (patched) > > <https://reviews.apache.org/r/67073/diff/1/?file=2019552#file2019552line74> > > > > Do we think

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

pache/hadoop/hive/metastore/ObjectStore.java b0a805f Diff: https://reviews.apache.org/r/66800/diff/4/ Changes: https://reviews.apache.org/r/66800/diff/3-4/ Testing --- Run the TestDropPartition tests, also checked the database manually, that no object left in the database Thanks, Peter Vary

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

Removed the last checkTimeout-s from every method. Added a few ones where they are needed - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/#review202

[jira] [Created] (HIVE-19503) Create a test that checks that every table is empty after a dropTable happened with directSql

Peter Vary created HIVE-19503: - Summary: Create a test that checks that every table is empty after a dropTable happened with directSql Key: HIVE-19503 URL: https://issues.apache.org/jira/browse/HIVE-19503

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

op/hive/ql/exec/mr/HadoopJobExecHelper.java Lines 433 (patched) <https://reviews.apache.org/r/66290/#comment284965> Why not reuse ss variable instead of SessionState.get() again? - Peter Vary On May 10, 2018, 10:51 p.m., Bharathkrishna

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

s as a first input: checkArgGroups(arguments, 0, inputTypes, STRING_GROUP, DATE_GROUP, VOID_GROUP); What happens when the first input is string? - Peter Vary On May 10, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote: > >

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

Diff: https://reviews.apache.org/r/66800/diff/3/ Changes: https://reviews.apache.org/r/66800/diff/2-3/ Testing --- Run the TestDropPartition tests, also checked the database manually, that no object left in the database Thanks, Peter Vary

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

r.java Lines 430-439 (patched) <https://reviews.apache.org/r/66290/#comment284558> Why did you moved this inside the if statement? - Peter Vary On May 7, 2018, 5:58 p.m., Bharathkrishna Guruvayoor Murali wrote: > > -

Re: Review Request 66935: HIVE-18977: Listing partitions returns different results with JDO and direct SQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66935/#review202350 --- Ship it! Ship It! - Peter Vary On May 3, 2018, 1:53 p.m

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

/metastore/ObjectStore.java 1abd99d Diff: https://reviews.apache.org/r/66800/diff/2/ Changes: https://reviews.apache.org/r/66800/diff/1-2/ Testing --- Run the TestDropPartition tests, also checked the database manually, that no object left in the database Thanks, Peter Vary

Review Request 66800: HIVE-6980 Drop table by using direct sql

/1/ Testing --- Run the TestDropPartition tests, also checked the database manually, that no object left in the database Thanks, Peter Vary

Re: ptest queue

I would vote for version 3. It would solve the big patch problem, and removes the unnecessary test runs too. Thanks, Peter > On Apr 25, 2018, at 11:01 AM, Adam Szita wrote: > > Hi all, > > I had a patch (HIVE-19077) committed with the original aim being the > prevention of wasting resources w

Re: how to extract metadata of hive tables in speed

n dump it after being used. It can’t keep a > session or connection and don’t have a Cli. The initialization take all the > time. Therefore, I only can use the thrift API to do my job. Thank you for > your precious suggestions! > > Best regards, > Hou >> 在 2018年4月24日，下午7:

Re: Review Request 66774: HIVE-19285: Add logs to the subclasses of MetaDataOperation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66774/#review201906 --- Ship it! Ship It! - Peter Vary On April 24, 2018, 6:35 p.m

Re: Review Request 66774: HIVE-19285: Add logs to the subclasses of MetaDataOperation

apache/hive/service/cli/operation/GetPrimaryKeysOperation.java Lines 113 (patched) <https://reviews.apache.org/r/66774/#comment283422> nit: formatting? - Peter Vary On April 24, 2018, 10:34 a.m., Marta Kuczora wrote: > > --

Re: how to extract metadata of hive tables in speed

eted directory: > /tmp/hive/kousouda/6c7e97ad-c9dd-4c5e-9636-ab9d4e47d76f on fs with scheme hdfs > 18/04/24 15:47:12 INFO session.SessionState: Deleted directory: > /tmp/hive/java/kousouda/6c7e97ad-c9dd-4c5e-9636-ab9d4e47d76f on fs with > scheme file > 18/04/24 15:47:12 INFO

Re: Review Request 66188: HIVE-18986 Table rename will run java.lang.StackOverflowError in dataNucleus if the table contains large number of columns

> On March 22, 2018, 11:03 a.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 154-158 (original), 154-158 (patched) > > <https://reviews.apache.org/r/66188/diff/2/?file=1984629#file1984629line1

Re: Review Request 64632: HIVE-18247: Use DB auto-increment for indexes

())" - this might be more interesting - is there a way to check if we are affected, or we just hope the tests are covering all the scenarios? - Does this have a measurable performance impact? - Do you know a good way to test this kind of changes on multiple backend databases? Thanks, Peter - Peter

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On March 27, 2018, 12:53 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > > Line 712 (original), 712 (patched) > > <https://reviews.apache.org/r/66290/diff/1/?file=1988690#file1988690line712> > > > > Is it possi

Re: how to extract metadata of hive tables in speed

so slow, > Or it is because I forget to start some server which can respond immediately? > >> 在 2018年4月23日，下午3:06，Peter Vary 写道： >> >> Hi, >> >> Alexander Kolbasov has a project which might interest you (keeping in mind, >> that this is not p

Re: how to extract metadata of hive tables in speed

Hi, Alexander Kolbasov has a project which might interest you (keeping in mind, that this is not production ready - more like a proof of concept): https://github.com/akolb1/gometastore/blob/master/hmstool/doc/hmstool.md Also you can use HMS thrift API directly to access the MetaStore, or if you c

Re: Review Request 66585: HIVE-19104 When test MetaStore is started with retry the instances should be independent

Run the previously failed tests Thanks, Peter Vary

Review Request 66585: HIVE-19104 When test MetaStore is started with retry the instances should be independent

Diff: https://reviews.apache.org/r/66585/diff/1/ Testing --- Run the previously failed tests Thanks, Peter Vary

Re: Apache Hive 3.0.0 release preparation

Hi Team, I am new to the Hive release process and it is not clear to me how the failing tests are handled. Do we plan to fix the failing tests before release? Or it is accepted to cut a new major release with known test issues. Thanks, Peter > On Apr 5, 2018, at 8:25 PM, Vineet Garg wrote: >

Re: Review Request 66359: HIVE-19076: Fix NPE and TApplicationException in function related HiveMetastore methods

Also if the checks take more time, then we miss some runtime.... - Peter Vary On April 5, 2018, 1:43 p.m., Marta Kuczora wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Created] (HIVE-19104) When test MetaStore is started with retry the instances should be independent

Peter Vary created HIVE-19104: - Summary: When test MetaStore is started with retry the instances should be independent Key: HIVE-19104 URL: https://issues.apache.org/jira/browse/HIVE-19104 Project: Hive

Re: Review Request 66356: HIVE-19075: Fix NPE when trying to drop or get DB with null name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66356/#review200187 --- Ship it! Ship It! - Peter Vary On March 29, 2018, 9:54 a.m

Re: Review Request 66312: HIVE-19060: Fix the TestAppendPartitions.testAppendPartitionNullPartValues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66312/#review200050 --- Ship it! Ship It! - Peter Vary On March 27, 2018, 3:34 p.m

<    1   2   3   4   5   6   7   8   9   >