Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > <https://reviews.apache.org/r/59984/diff/1/?file=1747770#file1747770line137> > >

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > <https://reviews.apache.org/r/59984/diff/1/?file=1747770#file1747770line137> > >

Re: Review Request 59998: HIVE-16867

and Filter, since lot of repeated code in two branches. - Ashutosh Chauhan On June 21, 2017, 3:44 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 59998: HIVE-16867

> On June 21, 2017, 2:03 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/except_distinct.q.out > > Lines 421-425 (original), 413-417 (patched) > > <https://reviews.apache.org/r/59998/diff/1/?file=1747966#file1747966line421> > > >

Re: Review Request 59998: HIVE-16867

This seems to be undoing recently introduced hive.optimize.countdistinct optimization, which is surprising since that optimization runs before this. Is this expected? This may result in loss of performance. - Ashutosh Chauhan On June 21, 2017, 9:06 a.m., Jesús Camacho Rod

Re: Review Request 57614: Auto-gather column stats - phase 2

l/src/test/results/clientpositive/columnstats_tbllvl.q.out Line 109 (original), 110-111 (patched) <https://reviews.apache.org/r/57614/#comment252887> Another one: HIVE-15903 should have made this happen. - Ashutosh Chauhan On June 20, 2017, 10 p.m., pengcheng xiong wrote: >

Re: Review Request 57614: Auto-gather column stats - phase 2

ed) <https://reviews.apache.org/r/57614/#comment253110> No ColumnStatsDesc in explain. - Ashutosh Chauhan On June 20, 2017, 10 p.m., pengcheng xiong wrote: > > --- > This is an automatically ge

Re: Review Request 57614: Auto-gather column stats - phase 2

> On June 22, 2017, 7:08 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/smb_join_partition_key.q > > Lines 1 (patched) > > <https://reviews.apache.org/r/57614/diff/2/?file=1754754#file1754754line1> > > > > decimals should b

Re: Review Request 57614: Auto-gather column stats - phase 2

#comment253325> Join order changed. ql/src/test/results/clientpositive/stats3.q.out Lines 58 (patched) <https://reviews.apache.org/r/57614/#comment253326> This should say invalidating stats.

Re: Review Request 57614: Auto-gather column stats - phase 2

nsert.q.out Line 165 (original), 198 (patched) <https://reviews.apache.org/r/57614/#comment253347> vectorization turned off. - Ashutosh Chauhan On June 20, 2017, 10 p.m., pengcheng xiong wrote: > > --- > This is an autom

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

ey) from src group by value; ql/src/test/results/clientpositive/llap/metadataonly1.q.out Line 256 (original), 256-257 (patched) <https://reviews.apache.org/r/59468/#comment249095> Earlier plan was better. When metadataonly optimizer can kick in that should. - Ashutosh Chauhan On M

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

9468/#comment249138> This change may not be needed if we run Count distinct optimization after this has alreday run. ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java Lines 75 (patched) <https://reviews.apache.org/r/59468/#comment249141> Also, lets ca

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

<https://reviews.apache.org/r/59468/#comment249605> Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. - Ashutosh Chauhan On May 27, 2017, 2:20 a.m., pengcheng xiong wrote: > >

[Announce] New PMC member : Daniel Dai

The Project Management Committee (PMC) for Apache Hive has invited Daniel Dai to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Daniel! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Chaoyu Tang

The Project Management Committee (PMC) for Apache Hive has invited Chaoyu Tang to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Chaoyu! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Yongzhi Chen

The Project Management Committee (PMC) for Apache Hive has invited Yongzhi Chen to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Yongzhi! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Aihua Xu

The Project Management Committee (PMC) for Apache Hive has invited Aihua to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Aihua! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Vaibhav Gumashta

The Project Management Committee (PMC) for Apache Hive has invited Vaibhav Gumashta to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Vaibhav! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Sergio Pena

The Project Management Committee (PMC) for Apache Hive has invited Sergio Pena to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Sergio! Thanks, Ashutosh on behalf of Hive PMC

Re: Review Request 56140: Can't order by an unselected column

e currently rewritten to avoid this missing feature. - Ashutosh Chauhan On May 1, 2017, 5:30 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 56140: Can't order by an unselected column

> On May 3, 2017, 4:24 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/cp_sel.q.out > > Line 46 (original), 50 (patched) > > <https://reviews.apache.org/r/56140/diff/8/?file=1704004#file1704004line50> > > > > Is this expected? >

Re: Review Request 59610: Support numeric as same as decimal

(original), 137 (patched) <https://reviews.apache.org/r/59610/#comment249748> This will make Numeric reserved keyword, which is ok, but we need to note that in Release Notes field of jira and mark incompatible change flag in jira. - Ashutosh Chauhan On May 26, 2017, 5:43 p.m., pen

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

ply, visit: > https://reviews.apache.org/r/59697/ > --- > > (Updated June 1, 2017, 7:46 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > hive-167

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

-- On June 1, 2017, 7:46 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59697/ > ------- > > (Upda

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

(original), 3-5 (patched) <https://reviews.apache.org/r/59468/#comment249839> yes.. you are correct. My bad. - Ashutosh Chauhan On May 27, 2017, 2:20 a.m., pengcheng xiong wrote: > > --- > This is an automatically g

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

optimizer is not kicking in for tpcds queries. Is that expected? - Ashutosh Chauhan On June 1, 2017, 7:46 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59808: Enhance HiveFilterSetOpTransposeRule to remove union branches

-43 (patched) <https://reviews.apache.org/r/59808/#comment252021> Metadataonly optimizer should have kicked in and turned this to null scan. Seems like it didn't. Can you confirm with explain extended? - Ashutosh Chauhan On June 10, 2017, 9:57 p.m., pengcheng xiong

Re: Review Request 59808: Enhance HiveFilterSetOpTransposeRule to remove union branches

Also, add hive.optimize.metadataonly=true; That should quick in some of these queries. ql/src/test/results/clientpositive/perf/query4.q.out Lines 240-275 (original) <https://reviews.apache.org/r/59808/#comment251377> Pretty cool ! - Ashutosh Chauhan On

Re: [VOTE] Should we release hive-storage 2.4.0rc0?

Downloaded tar ball. Shasum matches. Build from src. All looks good. +1 On Fri, Apr 28, 2017 at 11:39 AM, Pengcheng Xiong wrote: > I downloaded the tarball, extracted, installed it. It works well with Hive > 2.3 (candidate). Thus, +1 on this. Thanks a lot for your work! > >

Re: Review Request 56140: Can't order by an unselected column

rect. For an order by there should necessarily be a RS in plan, otherwise we can get sorting in map only plan. ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out Lines 580-588 (original) <https://reviews.apache.org/r/56140/#comment246734> Order by must have RS. - Ashutosh

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

tched) <https://reviews.apache.org/r/59468/#comment249420> No mGby2 in plan. Probably removed by ReduceSinkDedup since keys are same for 2 Gbys. As I suggested earlier second Gby should have constant key and then it should show up here. - Ashutosh Chauhan On May

Re: Review Request 59624: HIVE-16757 remove use of deperecated RelNode.getRows()

izer/calcite/stats/HiveRelMdRowCount.java Line 75 (original), 75 (patched) <https://reviews.apache.org/r/59624/#comment249736> Should this instead be mq.getRowCount(join); That is waht javadoc of RelNode::estimateRowCount() is suggesting? - Ashutosh Chauhan On May 29, 2017, 7:54

Re: Review Request 62228: HIVE-17495: CachedStore: prewarm improvements, refactoring and caching some aggregate stats

partition is added or deleted. Did I miss that? - Ashutosh Chauhan On Sept. 11, 2017, 9:25 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62392: HIVE-17535: Support CBO for queries without source table

g/r/62392/#comment261931> better to use protected. ql/src/test/results/clientpositive/decimal_precision2.q.out Line 40 (original), 40 (patched) <https://reviews.apache.org/r/62392/#comment261932> This doesn't look correct. query had BD qualifier so this should be decimal. - Ashutosh Cha

Re: Review Request 62280: HIVE-16827: Merge stats task and column stats task into a single task

3 (patched) <https://reviews.apache.org/r/62280/#comment262102> We can collect stats for non-native tables. Any reason for this? - Ashutosh Chauhan On Sept. 14, 2017, 8:06 p.m., Zoltan Haindrich wrote: > > --- > This is an automatically

Re: Review Request 62280: HIVE-16827: Merge stats task and column stats task into a single task

omment262075> Is this change expected? ql/src/test/results/clientpositive/outer_reference_windowed.q.out Line 132 (original), 138 (patched) <https://reviews.apache.org/r/62280/#comment262084> Is this change expected? - Ashutosh Chauhan On Sept. 14, 2017, 8:06 p.m., Zoltan Haindrich wrote: &

Re: Review Request 62424: HIVE-17536 StatsUtil::getBasicStatForTable doesn't distinguish b/w absence of statistics or zero stats

ve had a good estimate. Looks estimate became worse. Also, Basic stats: COMPLETE, is that correct? ql/src/test/results/clientpositive/decimal_udf.q.out Line 41 (original), 41 (patched) <https://reviews.apache.org/r/62424/#comment262114> Is this changed for better? - Ashu

New committer : Barna Zsombor Klara

The Project Management Committee (PMC) for Apache Hive has invited Barna Zsombor Klara to become a committer and we are pleased to announce that he has accepted. Barna, thank you for your contributions, and we look forward your further interactions with the community! Welcome, Barna! Thanks,

Re: Review Request 62309: HIVE-17465 Fix filters cardinality for AND predicates

lso, new estimates are suspiciously too low. ql/src/test/results/clientpositive/join47.q.out Line 562 (original), 562 (patched) <https://reviews.apache.org/r/62309/#comment261650> Expected ? - Ashutosh Chauhan On Sept. 13, 2017, 10:14

Re: Review Request 62408: HIVE-17519 Transpose column stats display

g/r/62408/#comment262008> Make it protected. - Ashutosh Chauhan On Sept. 19, 2017, 2:11 p.m., Zoltan Haindrich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 62855: HIVE-16677

/DruidStorageHandlerUtils.java Lines 394 (patched) <https://reviews.apache.org/r/62855/#comment264604> We can just return if insert into has empty segments. Easier to read that way. - Ashutosh Chauhan On Oct. 10, 2017, 2:45 p.m., Jesús Camacho Rodríguez

Re: Review Request 62776: HIVE-16511 CBO looses inner casts on constants of complex type

add comments for need of this map. - Ashutosh Chauhan On Oct. 4, 2017, 6:04 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 62981: HIVE-17672: Upgrade Calcite version to 1.14

reply, visit: > https://reviews.apache.org/r/62981/ > --- > > (Updated Oct. 13, 2017, 4:52 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-17672 > https://issues.apache.org/jira/browse/HIVE-17672 > > > Repository: hive-git

Re: Review Request 62228: HIVE-17495: CachedStore: prewarm improvements, refactoring and caching some aggregate stats

ws.apache.org/r/62228/#comment261429> inspector expected. metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/StringColumnStatsAggregator.java Line 204 (original), 197 (patched) <https://reviews.apache.org/r/62228/#comment261430>

[Announce] New committer: Anishek Agarwal

The Project Management Committee (PMC) for Apache Hive has invited Anishek Agarwal to become a committer and we are pleased to announce that he has accepted. Welcome, Anishek! Thanks, Ashutosh

[Announce] New committer: Sankar Hariappan

The Project Management Committee (PMC) for Apache Hive has invited Sankar Harriapan to become a committer and we are pleased to announce that he has accepted. Welcome, Sankar! Thanks, Ashutosh

Re: Review Request 61188: HIVE-16614

ince we only allow local time zone. - Ashutosh Chauhan On Aug. 23, 2017, 9:02 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

ly for stats state. This change looks incorrect. ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer_2.q.out Line 325 (original), 325 (patched) <https://reviews.apache.org/r/61165/#comment260500> This doesn't look correct. Estimated stats with state: COMPLETE.

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

trouble some. Lets arbitartily pick start of 1970 (unix epoch) and end of unix epoch (2038). Can set same for ts. ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java Lines 1036 (patched) <https://reviews.apache.org/r/61165/#comment260496> todo needed - Ashutosh Chauhan On S

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

for new patch before reviewing this? - Ashutosh Chauhan On Aug. 31, 2017, 10:02 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

patched) <https://reviews.apache.org/r/61165/#comment260081> State change expected? - Ashutosh Chauhan On Aug. 27, 2017, 11:11 p.m., Vineet Garg wrote: > > --- > Thi

Re: Review Request 62280: HIVE-16827: Merge stats task and column stats task into a single task

(original), 375 (patched) <https://reviews.apache.org/r/62280/#comment264508> basic_stats should be true. - Ashutosh Chauhan On Oct. 3, 2017, 8:06 a.m., Zoltan Haindrich wrote: > > --- > This is an automatically gen

Re: Review Request 62776: HIVE-16511 CBO looses inner casts on constants of complex type

> On Oct. 4, 2017, 9:18 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out > > Line 5616 (original), 5616 (patched) > > <https://reviews.apache.org/r/62776/diff/1/?file=1846209#file1846209line5616> > &

Re: Review Request 62776: HIVE-16511 CBO looses inner casts on constants of complex type

olding rules as both calcite as well as hive rules. Any reason that's not happening here? - Ashutosh Chauhan On Oct. 4, 2017, 6:04 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 62280: HIVE-16827: Merge stats task and column stats task into a single task

to just flip the state flag and keep whatever stats we have. ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java Lines 171 (patched) <https://reviews.apache.org/r/62280/#comment264633> I think statsAggregator can never be null at this point. Throw exception?

Re: Review Request 63133: HIVE-17054

Lines 1517 (patched) <https://reviews.apache.org/r/63133/#comment265741> sorry misread the plan. - Ashutosh Chauhan On Oct. 19, 2017, 12:52 a.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically g

Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out > > Line 160 (original), 160 (patched) > > <https://reviews.apache.org/r/63442/diff/2/?file=1886244#file1886244line160> > > > >

Re: Review Request 63774: HIVE-15436

1418-1439 (patched) <https://reviews.apache.org/r/63774/#comment268475> Lets not add public methods which are not used. Unnecessarily increases api surface area. - Ashutosh Chauhan On Nov. 13, 2017, 11:09 p.m., Jesús Camacho Rodríguez

Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out > > Line 160 (original), 160 (patched) > > <https://reviews.apache.org/r/63442/diff/2/?file=1886244#file1886244line160> > > > >

Re: Review Request 63845: HIVE-15018

<https://reviews.apache.org/r/63845/#comment268937> current db? ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java Lines 266 (patched) <https://reviews.apache.org/r/63845/#comment268939> nit: ws - Ashutosh Chauhan On Nov. 15, 2017, 5:52 p

Re: Review Request 63893: HIVE-14487

> On Nov. 17, 2017, 11:22 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 1488 (original), 1488 (patched) > > <https://reviews.apache.org/r/63893/diff/2/?file=1896941#file1896941line1488> > > > &

Re: Review Request 63893: HIVE-14487

object. ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java Lines 341 (patched) <https://reviews.apache.org/r/63893/#comment269225> We don't store comments for regular tables in property? Is this special for (materialized) views? - Ashutosh Chauhan On Nov. 17, 2017,

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

iginal), 1826 (patched) <https://reviews.apache.org/r/63470/#comment267033> Lets move this test to minilllaplocal only. - Ashutosh Chauhan On Nov. 1, 2017, 6:23 p.m., Vineet Garg wrote: > > --- > This is an automatical

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

ched) <https://reviews.apache.org/r/63470/#comment267548> Follow-up to transform Gby->LSJ to LSJ ? - Ashutosh Chauhan On Nov. 6, 2017, 7:53 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

ttps://reviews.apache.org/r/63470/#comment267155> Lets move this to test to llaplocal only. ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out Lines 209-212 (original), 220-223 (patched) <https://reviews.apache.org/r/63470/#comment267156> This Gby is wasteful.

Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

e we set stats with complete. However, for column stats it should be None. - Ashutosh Chauhan On Nov. 9, 2017, 5:39 p.m., Zoltan Haindrich wrote: > > --- > This is an automatica

[Announce] New committer: Tao Li

The Project Management Committee (PMC) for Apache Hive has invited Tao Li to become a committer and we are pleased to announce that he has accepted. Welcome, Tao! Thanks, Ashutosh

Re: ptest not picking patches

There was an apache infra issue which was making jenkins to not submit patches to ptest server. https://issues.apache.org/jira/browse/INFRA-15358 Also jenkins was restarted overnight. On Wed, Nov 1, 2017 at 11:15 AM, Chris Drome wrote: > Me as well for HIVE-17853. > >

Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

l/plan/Statistics.java Lines 178 (patched) <https://reviews.apache.org/r/63442/#comment267336> Can just remove it. - Ashutosh Chauhan On Oct. 31, 2017, 2:29 p.m., Zoltan Haindrich wrote: > > --- > This is an automatically gener

Re: Review Request 64282: HIVE-18173: Improve plans for correlated subqueries with non-equi predicate

out Lines 230-234 (original), 230-239 (patched) <https://reviews.apache.org/r/64282/#comment271352> New plan is worse then before. ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out Lines 281-285 (original), 281-288 (patched) <https://reviews.apache.org/r/64282/#comment271353>

Re: Review Request 64282: HIVE-18173: Improve plans for correlated subqueries with non-equi predicate

c/test/results/clientpositive/llap/subquery_in.q.out Lines 1029-1034 (original) <https://reviews.apache.org/r/64282/#comment271518> This query is now returning empty result set. Looks incorrect. - Ashutosh Chauhan On Dec. 6, 2017, 6:30 a.m., Vinee

Re: Review Request 64282: HIVE-18173: Improve plans for correlated subqueries with non-equi predicate

1029-1037 (original) <https://reviews.apache.org/r/64282/#comment271564> still wrong result set. - Ashutosh Chauhan On Dec. 6, 2017, 11:58 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 64510: HIVE-18068

<https://reviews.apache.org/r/64510/#comment272014> Does this predicate got simplified to false? - Ashutosh Chauhan On Dec. 11, 2017, 9:45 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 63343: HIVE-17766

orts null-safe join, can you also add test for: select * from tx1 u left semi join tx2 v on u.b <=> v.b; - Ashutosh Chauhan On Oct. 28, 2017, 8:06 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an

Re: Review Request 63394: HIVE-15016: Run tests with Hadoop 3.0.0-beta1

e need this as well? Proabably not. shims/0.23/pom.xml Line 67 (original), 73 (patched) <https://reviews.apache.org/r/63394/#comment266773> This shall not be needed. standalone-metastore/pom.xml Line 179 (original), 179 (patched) <https://reviews

Re: Review Request 62280: HIVE-16827: Merge stats task and column stats task into a single task

4> Empty table should have Basic stats true. ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out Lines 501 (patched) <https://reviews.apache.org/r/62280/#comment266265> Basic stats missing here? - Ashutosh Chauhan On Oct. 3, 2017, 8:06 a.m., Zoltan Haindrich wrote: > > -

Re: Review Request 62280: HIVE-16827: Merge stats task and column stats task into a single task

> On Oct. 10, 2017, 11:49 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java > > Lines 160 (patched) > > <https://reviews.apache.org/r/62280/diff/4/?file=1842752#file1842752line160> > > > > we want to jus

Re: pre-commit not working?

yes.. it does look like those jenkins node aren't reachable anymore. Interestingly, Hadoop precommit tests aren't affected. Not sure whats going on. Thanks, Ashutosh On Mon, Oct 23, 2017 at 5:40 PM, Prasad Nagaraj Subramanya < prasadn...@gmail.com> wrote: > Looks like the Jenkins node with

Re: [VOTE] Apache Hive 2.3.1 Release Candidate 0

- Built from sources. - Ran few unit tests. - Checked md5sum. Everything looks good. +1 Thanks Jesus for putting this release together. Ashutosh On Thu, Oct 19, 2017 at 8:06 PM, Jesus Camacho Rodriguez < jcama...@apache.org> wrote: > Apache Hive 2.3.1 Release Candidate 0 is available here: >

Re: Review Request 67125: HIVE-19418 add background stats updater similar to compactor

738 (patched) <https://reviews.apache.org/r/67125/#comment285970> I think this timeunit should be in minutes since this task need to run more frequently than that. That will make this config less error-prone. Default value : 1 hour. -

Re: Review Request 67125: HIVE-19418 add background stats updater similar to compactor

> On May 23, 2018, 9:43 p.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 2424 (patched) > > <https://reviews.apache.org/r/67125/diff/1/?file=2022633#file2022633line2424> > &g

[ANNOUNCE] New committer: Adam Szita

Apache Hive's Project Management Committee (PMC) has invited Adam Szita to become a committer, and we are pleased to announce that he has accepted. Adam, welcome, thank you for your contributions, and we look forward your further interactions with the community! Ashutosh Chauhan (on behalf

New committer announcement : Marta Kuczora

Apache Hive's Project Management Committee (PMC) has invited Marta Kuczora to become a committer, and we are pleased to announce that he has accepted. Marta, welcome, thank you for your contributions, and we look forward your further interactions with the community! Ashutosh Chauhan (on behalf

Re: build failures due to glassfish?

Depending on snapshot version is in general a bad idea. This gives another reason to eliminate those snapshot dependencies from our builds. On Wed, May 2, 2018 at 11:41 AM, Sergey Shelukhin wrote: > I see this in HiveQA runs: > > Could not transfer artifact

Re: Requesting write permission on Hive wiki page

Hi Adam, Thanks for your interest in updating our docs. I just granted you write access on cwiki. Thanks, Ashutosh On Fri, Apr 27, 2018 at 6:58 AM, Adam Szita wrote: > Hi, > > I'd like to request an edit permission for the Hive Confluence page please. > My user ID is: szita

Re: Review Request 63124: HIVE-16603

/metastore/ObjectStore.java Lines 3955-3956 (original), 4003-4004 (patched) <https://reviews.apache.org/r/63124/#comment265712> These calls should be done outside of for() loop, else its called multiple times for each FK. - Ashutosh Chauhan On Oct. 18, 2017, 8:59 p.m., Jesús Camacho Rod

Re: Review Request 63133: HIVE-17054

to be in complete mode or there needs to be another reducer following this. - Ashutosh Chauhan On Oct. 19, 2017, 12:52 a.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 63343: HIVE-17766

atched) <https://reviews.apache.org/r/63343/#comment266418> No need for this test. - Ashutosh Chauhan On Oct. 26, 2017, 9:26 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is a

Re: Review Request 64490: HIVE-14498

> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote: > > metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql > > Lines 9-17 (patched) > > <https://reviews.apache.org/r/64490/diff/4/?file=1918818#file1918818line9> > > > > Instead of this st

[Announce] New committer: Deepak Jaiswal

The Project Management Committee (PMC) for Apache Hive has invited Deepak Jaiswal to become a committer and we are pleased to announce that he has accepted. Welcome, Deepak! Thanks, Ashutosh

Re: Review Request 65148: HIVE-18452 work around HADOOP-15171

1381 (patched) <https://reviews.apache.org/r/65148/#comment274698> Default should be false until Hadoop bug is fixed, since otherwise we will hit bug in default config. - Ashutosh Chauhan On Jan. 13, 2018, 3:19 a.m., Sergey Shelukhin

Re: Review Request 65172: HIVE-18450

.org/r/65172/#comment275202> with instead of and in sentence ? - Ashutosh Chauhan On Jan. 15, 2018, 11:52 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 65173: HIVE-18386

/org/apache/hive/service/server/HiveServer2.java Line 192 (original), 192 (patched) <https://reviews.apache.org/r/65173/#comment274717> SessionHive should be well formed object here which can be passed in to callee. I see previous method is also using it. Any reason to not do that. -

Re: Review Request 65173: HIVE-18386

> On Jan. 17, 2018, 11:10 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java > > Line 157 (original), 183 (patched) > > <https://reviews.apache.org/r/65173/diff/3/?file=1941302#file1941302line185> >

Re: Review Request 65173: HIVE-18386

/HiveMaterializedViewsRegistry.java Line 157 (original), 183 (patched) <https://reviews.apache.org/r/65173/#comment274921> Callers of this has conf as well. - Ashutosh Chauhan On Jan. 17, 2018, 10:52 p.m., Jesús Camacho Rodríguez

Re: Review Request 65342: HIVE-18546

length. Should throw exception saying "TxnList too long" ? - Ashutosh Chauhan On Jan. 25, 2018, 5:49 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 65296: HIVE-18259

/org/apache/hadoop/hive/metastore/MaterializationsCacheCleanerTask.java Lines 54 (patched) <https://reviews.apache.org/r/65296/#comment276240> LOG.info - Ashutosh Chauhan On Jan. 23, 2018, 8:56 p.m., Jesús Camacho Rodríguez

Re: Review Request 65342: HIVE-18546

for txnlist and throw if its bigger? standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MCreationMetadata.java Lines 22 (patched) <https://reviews.apache.org/r/65342/#comment276446> Good to javadoc for class. - Ashutosh Chauhan On Jan. 31, 2018, 12:07 p.m., Jesús

Re: Review Request 65431: HIVE-16605 : NOT NULL constraint enforcement

148-149 (patched) <https://reviews.apache.org/r/65431/#comment276475> We need -ve test for this as well where query fails because of constraint violation. - Ashutosh Chauhan On Jan. 31, 2018, 8:42 a.m., Vineet Garg wrote: > > ---

Re: Review Request 65342: HIVE-18546

> On Feb. 2, 2018, 1:31 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 1238 (patched) > > <https://reviews.apache.org/r/65342/diff/3/?file=1950838#file1950838line1243> > > > >

<    5   6   7   8   9   10   11   12   13   14   >