[Impala-CR](cdh5-trunk) IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests

2016-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3315 Change subject: IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests .. IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs

[Impala-CR](cdh5-trunk) IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling

2016-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling .. IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling The Sorter's memory

[Impala-CR](cdh5-trunk) IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling

2016-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling .. Patch Set 9: Verified+1 Passed a private core build: http://sandbox.jenkins.cloudera.com/job

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

2016-06-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 2: Does pip provide stable URLs? I can find direct download links but they have

[Impala-CR](cdh5-trunk) IMPALA-3441: check for malformed Avro data

2016-06-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441: check for malformed Avro data .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/3072/8/testdata/workloads/functional-query/queries

[Impala-CR](cdh5-trunk) IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling

2016-06-03 Thread Tim Armstrong (Code Review)
-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3646: Handle corrupt RLE literal or repeat counts of 0.

2016-06-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3646: Handle corrupt RLE literal or repeat counts of 0. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3299

[Impala-CR](cdh5-trunk) IMPALA-3646: Handle corrupt RLE literal or repeat counts of 0.

2016-06-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3646: Handle corrupt RLE literal or repeat counts of 0. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3299/1/be/src/util/rle-test.cc

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

2016-06-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 2: Code-Review+1 Ping - I don't have a better solution to the problem of it trying

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. .. Patch Set 21: Verified+1 GVMs are temporarily not working. I ran an equivalent private

[Impala-CR](cdh5-trunk) IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling .. IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling The Sorter's memory management logic

[Impala-CR](cdh5-trunk) IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/2908/6/be/src/runtime/sorter.cc

[Impala-CR](cdh5-trunk) IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3282/5/be/src/exec

[Impala-CR](cdh5-trunk) IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks .. Patch Set 5: This passed an exhaustive build aside from one test. I fixed

[Impala-CR](cdh5-trunk) IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3282 Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks .. IMPALA-3567: Part 1: groundwork to make Join

[Impala-CR](cdh5-trunk) Allow compiler to use SSE3 and SSSE3 instructions.

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Allow compiler to use SSE3 and SSSE3 instructions. .. Patch Set 1: Good points. My inclination is that it's not worth the trouble to try to fail gracefully

[Impala-CR](cdh5-trunk) Allow compiler to use SSE3 and SSSE3 instructions.

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Allow compiler to use SSE3 and SSSE3 instructions. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3291/1/be/CMakeLists.txt File

[Impala-CR](cdh5-trunk) Allow compiler to use SSE3 and SSSE3 instructions.

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Allow compiler to use SSE3 and SSSE3 instructions. .. Patch Set 1: Compiling with SSE enabled, I don't feel confident that we'll actually get to the CpuInfo

[Impala-CR](cdh5-trunk) IMPALA-1346/1590: fix sorter buffer mgmt when spilling

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1346/1590: fix sorter buffer mgmt when spilling .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/2908/5//COMMIT_MSG Commit Message

[Impala-CR](cdh5-trunk) IMPALA-3441: check for malformed Avro data

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441: check for malformed Avro data .. Patch Set 6: (6 comments) Code is looking good, just need to figure out perf before +1 I think http

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. .. Patch Set 21: Code-Review+2 Rebase. Ran EC2 stress test several times with TPC* queries

Re: [Impala-CR](cdh5-trunk) IMPALA-3441: check for malformed Avro data

2016-06-01 Thread Tim Armstrong
t;dhe...@cloudera.com> > Gerrit-Reviewer: Skye Wanderman-Milne <s...@cloudera.com> > Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> > Gerrit-HasComments: No >

[Impala-CR](cdh5-trunk) IMPALA-1346/1590: fix sorter buffer mgmt when spilling

2016-06-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1346/1590: fix sorter buffer mgmt when spilling .. Patch Set 5: Rebased. -- To view, visit http://gerrit.cloudera.org:8080/2908 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. .. Patch Set 20: I'll see if I can get some time on the stress cluster tomorrow -- To view

[Impala-CR](cdh5-trunk) IMPALA-3181: Add noexcept to some functions

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3181: Add noexcept to some functions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3256 To unsubscribe, visit http

[Impala-CR](cdh5-trunk) IMPALA-3633: cancel fragment if coordinator is gone

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3633: cancel fragment if coordinator is gone .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/3238 To unsubscribe

[Impala-CR](cdh5-trunk) IMPALA-3647: track runtime filter memory in separate tracker

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3647: track runtime filter memory in separate tracker .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/3247

[Impala-CR](cdh5-trunk) IMPALA-3633: cancel fragment if coordinator is gone

2016-05-31 Thread Tim Armstrong (Code Review)
Gerrit-Change-Id: I62ab6f4df7c0ee60c6aa6291513f9f0cbfac3fe7 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com&g

[Impala-CR](cdh5-trunk) IMPALA-1440: test for insert mem limit

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1440: test for insert mem limit .. Patch Set 2: Yeah it can go over. That's part of a larger problem with QueryMaintenance that Michael has been

[Impala-CR](cdh5-trunk) IMPALA-3647: track runtime filter memory in separate tracker

2016-05-31 Thread Tim Armstrong (Code Review)
Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-31 Thread Tim Armstrong (Code Review)
: I9c619e81fd1b8ac50e257172c8bce101a112b52a Gerrit-PatchSet: 19 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-31 Thread Tim Armstrong (Code Review)
: I9c619e81fd1b8ac50e257172c8bce101a112b52a Gerrit-PatchSet: 20 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. .. Patch Set 16: (9 comments) http://gerrit.cloudera.org:8080/#/c/2826/16/be/src/runtime

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3645: Free probe expressions' local allocations

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3645: Free probe expressions' local allocations .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3253/1/testdata/workloads

[Toolchain-CR] Kudu: Add snapshot of master

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Kudu: Add snapshot of master .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3141 To unsubscribe, visit http

[Impala-CR](cdh5-trunk) IMPALA-3632: Add script for runnig cppclean over the BE code.

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3632: Add script for runnig cppclean over the BE code. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3237/1/CMakeLists.txt File

[Impala-CR](cdh5-trunk) IMPALA-1440: test for insert mem limit

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1440: test for insert mem limit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3245/1/testdata/workloads/functional-query/queries

[Impala-CR](cdh5-trunk) IMPALA-1440: test for insert mem limit

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-1440: test for insert mem limit .. IMPALA-1440: test for insert mem limit This patch adds test coverage for partitioned inserts where the memory limit

[Impala-CR](cdh5-trunk) IMPALA-3441: check for malformed Avro data

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441: check for malformed Avro data .. Patch Set 5: Do you know where the extra time is being spent? E.g. is it in ReadZLong? -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-1440: test for insert mem limit

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1440: test for insert mem limit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3245/1/testdata/workloads/functional-query/queries

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/2826/14/be/src/runtime

Re: Bug IMPALA-1921

2016-05-31 Thread Tim Armstrong
Hi Shirish, Sorry for the slow reply - looks like we missed it between our release activities and the long weekend. I created a task for a couple of missing builtins: https://issues.cloudera.org/browse/IMPALA-3651 Let me know if that's of interest. Typically that's the kind of initial ramp-up

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3246 Change subject: IMPALA-3611: track unused Disk IO buffer memory .. IMPALA-3611: track unused Disk IO buffer memory Track I/O buffers

[Impala-CR](cdh5-trunk) IMPALA-3647: track runtime filter memory in separate tracker

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3247 Change subject: IMPALA-3647: track runtime filter memory in separate tracker .. IMPALA-3647: track runtime filter memory in separate

[Impala-CR](cdh5-trunk) PREVIEW: Use mmap instead of malloc for buffer pool

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: PREVIEW: Use mmap instead of malloc for buffer pool .. Abandoned cleaning up preview patches -- To view, visit http://gerrit.cloudera.org:8080/3046 To unsubscribe

[Impala-CR](cdh5-trunk) WIP only: port backend exec to use buffer pool

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: WIP only: port backend exec to use buffer pool .. Abandoned cleaning up preview patches -- To view, visit http://gerrit.cloudera.org:8080/3047 To unsubscribe, visit

[Impala-CR](cdh5-trunk) Split LLVM bitcode into multiple modules

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Split LLVM bitcode into multiple modules .. Patch Set 3: Will wait to rebase onto Michael's lazy materialization patch. -- To view, visit http

[Impala-CR](cdh5-trunk) Split LLVM bitcode into multiple modules

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: Split LLVM bitcode into multiple modules .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/2924 To unsubscribe, visit http://gerrit.cloudera.org:8080

[Impala-CR](cdh5-trunk) Refactor cross-compiled modules to reduce IR size

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: Refactor cross-compiled modules to reduce IR size .. Abandoned Will wait to rebase onto Michael's lazy materialization patch. -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-1440: test for insert mem limit

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3245 Change subject: IMPALA-1440: test for insert mem limit .. IMPALA-1440: test for insert mem limit This patch adds test coverage

[Impala-CR](cdh5-trunk) IMPALA-3639: expr-test fails on ASAN

2016-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3639: expr-test fails on ASAN .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3241/1/be/src/exprs/expr-test.cc File

[Impala-CR](cdh5-trunk) IMPALA-3066: Lazy materialization of LLVM module bitcode.

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3066: Lazy materialization of LLVM module bitcode. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3220/1/be/src/codegen/llvm

[Impala-CR](cdh5-trunk) IMPALA-3066: Lazy materialization of LLVM module bitcode.

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3066: Lazy materialization of LLVM module bitcode. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3220 To unsubscribe

[Impala-CR](cdh5-trunk) download_requirements should download kudu-python and virtualenv

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 2: I'm not sure. It calls python setup.py, which does the building. I spent some

[Impala-CR](cdh5-trunk) Stress test should count failure to repartition as a memory limit exceeded error

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Stress test should count failure to repartition as a memory limit exceeded error .. Patch Set 3: Code-Review+2 rebase -- To view, visit http

[Impala-CR](cdh5-trunk) Stress test should count failure to repartition as a memory limit exceeded error

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Stress test should count failure to repartition as a memory limit exceeded error .. Patch Set 1: (1 comment) Michael: not quite sure what you mean

[Impala-CR](cdh5-trunk) Stress test should count failure to repartition as a memory limit exceeded error

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Stress test should count failure to repartition as a memory limit exceeded error .. Patch Set 2: Code-Review+2 Fix comment -- To view, visit http

[Impala-CR](cdh5-trunk) Stress test should count failure to repartition as a memory limit exceeded error

2016-05-27 Thread Tim Armstrong (Code Review)
://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie67fabb8d4c0ffc65ac06f35e4a0a5c7a73baddd Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Ger

[Impala-CR](cdh5-trunk) IMPALA-1346/1590: fix sorter buffer mgmt when spilling

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1346/1590: fix sorter buffer mgmt when spilling .. Patch Set 4: Rebased on the latest sorter cleanup patch. -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-1346/1590: fix sorter buffer mgmt when spilling

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-1346/1590: fix sorter buffer mgmt when spilling .. IMPALA-1346/1590: fix sorter buffer mgmt when spilling The Sorter's memory management logic failed

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-27 Thread Tim Armstrong (Code Review)
: I9c619e81fd1b8ac50e257172c8bce101a112b52a Gerrit-PatchSet: 17 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. .. Patch Set 14: (64 comments) http://gerrit.cloudera.org:8080/#/c/2826/14/be/src/runtime/sorted

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-27 Thread Tim Armstrong (Code Review)
: I9c619e81fd1b8ac50e257172c8bce101a112b52a Gerrit-PatchSet: 16 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3344: Simplify sorter and document/enforce invariants.

2016-05-27 Thread Tim Armstrong (Code Review)
: I9c619e81fd1b8ac50e257172c8bce101a112b52a Gerrit-PatchSet: 15 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3633: cancel fragment if coordinator is gone

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3633: cancel fragment if coordinator is gone .. IMPALA-3633: cancel fragment if coordinator is gone The bug is that return_val.status is an optional field

[Impala-CR](cdh5-trunk) IMPALA-3633: cancel fragment if coordinator is gone

2016-05-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3238 Change subject: IMPALA-3633: cancel fragment if coordinator is gone .. IMPALA-3633: cancel fragment if coordinator is gone The bug

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3619: disable IR symbols by default

2016-05-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3619: disable IR symbols by default .. Patch Set 1: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/3223 To unsubscribe, visit http

Re: Project name proposal: Impala should be named "Impala"

2016-05-26 Thread Tim Armstrong
odd Lipcon > . cws Carl Steinbach > . brock Brock Noland > > Committers > . tarmstrong Tim Armstrong > . abehm Alex Behm > . tarasbob Taras Bobrovytsky > . casey Casey Ching > . mgrund Martin Grund > . dhecht Daniel Hecht > . kwho Michael Ho > . mjacobs Matthew Jacobs >

Re: Project name proposal: Impala should be named "Impala"

2016-05-26 Thread Tim Armstrong
I agree with Jim's suggestion. I'm not on the PPMC. Who *is* on the PPMC? On Thu, May 26, 2016 at 10:34 AM, Jim Apple wrote: > Following the naming guide > (http://www.apache.org/foundation/marks/naming.html), the PPMC needs > to vote on a name for Impala before the

Re: IMPALA-3223

2016-05-26 Thread Tim Armstrong
We obviously need to get Impala to work with non-CDH hadoop components, but it seems sane to me that we support only specific versions of the native dependencies. I think the native-toolchain maybe needs some more thought - particularly downloading source and binaries from S3, but if you were

Re: RFC: Remove thirdparty

2016-05-26 Thread Tim Armstrong
On Wed, May 25, 2016 at 8:42 PM, Michael Ho wrote: > Hi, > > Following up on the discussion about IMPALA-3223, I'd like to send out > an email about the removal of thirdparty. In particular, the following > changes > will happen in stages. Please voice your comment before I

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3619: disable IR symbols by default

2016-05-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3619: disable IR symbols by default .. Patch Set 1: Code-Review-2 I started the GVM just to speed up the merge if we decide to go forward. -- To view

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3619: disable IR symbols by default

2016-05-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3619: disable IR symbols by default .. Patch Set 1: I think it would be good to get this into the release: it makes it harder to ask people to run

[Impala-CR](cdh5-trunk) IMPALA-2550: Clean up RPC structures in ImpalaInternalService

2016-05-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3202/6//COMMIT_MSG Commit Message

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3619: disable IR symbols by default

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3223 Change subject: IMPALA-3619: disable IR symbols by default .. IMPALA-3619: disable IR symbols by default These come with significant

[Impala-CR](cdh5-trunk) IMPALA-3619: disable IR symbols by default

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-3619: disable IR symbols by default .. Abandoned meant to push to 5.8 branch -- To view, visit http://gerrit.cloudera.org:8080/3222 To unsubscribe, visit http

[Impala-CR](cdh5-trunk) IMPALA-3619: disable IR symbols by default

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3222 Change subject: IMPALA-3619: disable IR symbols by default .. IMPALA-3619: disable IR symbols by default These come with significant

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3582: increase thrift patch level for buffer leak fix .. Patch Set 2: Code-Review+2 Verified+1 Rebase. Carry +2 from review and +1 verification from

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3582: increase thrift patch level for buffer leak fix .. IMPALA-3582: increase thrift patch level for buffer leak fix Change-Id

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
://gerrit.cloudera.org:8080/3215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iee9f59dc69f612328d142e294f4d741df832 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Tim Armstrong <tarm

Re: IMPALA-3223

2016-05-25 Thread Tim Armstrong
I think it's definitely easier to move everything out of /thirdparty for logistical reasons, rather than trying to trim it more surgically. Most of the intermediate solutions to building Apache Impala are harder if we have to special-case some parts of thirdparty. E.g. I was able to build Apache

[Impala-CR](cdh5-trunk) IMPALA-3066: Lazy materialization of LLVM module bitcode.

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3066: Lazy materialization of LLVM module bitcode. .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/3220/1/be/src/codegen/llvm

Re: Apache CWiki access

2016-05-25 Thread Tim Armstrong
Me too! On Wed, May 25, 2016 at 1:17 PM, Jim Apple wrote: > I cannot seem to edit > https://cwiki.apache.org/confluence/display/IMPALA/Impala+Home > > My wiki username is jbapple/Jim Apple. May I have edit auth? > > Thanks, > Jim >

[Impala-CR](cdh5-trunk) Refactor RuntimeState and ExecEnv dependencies

2016-05-25 Thread Tim Armstrong (Code Review)
: I3b246ad9c3681d649e7bfc969c7fa885c6242d84 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) Refactor RuntimeState and ExecEnv dependencies

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Refactor RuntimeState and ExecEnv dependencies .. Patch Set 6: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/3108 To unsubscribe

[Impala-CR](cdh5-trunk) download_requirements should download kudu-python and virtualenv

2016-05-25 Thread Tim Armstrong (Code Review)
-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-CR](cdh5-trunk) download_requirements should download kudu-python and virtualenv

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 1: (3 comments) I'm doing a cdh packaging run now. http://gerrit.cloudera.org

[Impala-CR](cdh5-trunk) download_requirements should download kudu-python and virtualenv

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3217 Change subject: download_requirements should download kudu-python and virtualenv .. download_requirements should download kudu-python

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3582: increase thrift patch level for buffer leak fix .. Patch Set 1: Code-Review-2 I've set it to -2 so it wont merge, but I'll let the GVM complete

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3582: increase thrift patch level for buffer leak fix .. Patch Set 1: Code-Review+2 Carry +2 from cdh5-trunk -- To view, visit http

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3597: mislabelled cache levels on debug webpage

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3597: mislabelled cache levels on debug webpage .. Patch Set 2: Code-Review+1 Rebase, carry +1 -- To view, visit http://gerrit.cloudera.org:8080/3210

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3597: mislabelled cache levels on debug webpage

2016-05-25 Thread Tim Armstrong (Code Review)
:8080/3210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I638f518b6f460bea6724c1b1efd4c4aefecf5219 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3215 Change subject: IMPALA-3582: increase thrift patch level for buffer leak fix .. IMPALA-3582: increase thrift patch level for buffer leak

[Impala-CR](cdh5-trunk) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-3582: increase thrift patch level for buffer leak fix .. Abandoned Wrong branch -- To view, visit http://gerrit.cloudera.org:8080/3214 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3582: increase thrift patch level for buffer leak fix

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3214 Change subject: IMPALA-3582: increase thrift patch level for buffer leak fix .. IMPALA-3582: increase thrift patch level for buffer leak

[Impala-CR](cdh5-trunk) IMPALA-3597: mislabelled cache levels on debug webpage

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-3597: mislabelled cache levels on debug webpage .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3209 To unsubscribe, visit http

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3597: mislabelled cache levels on debug webpage

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3210 Change subject: IMPALA-3597: mislabelled cache levels on debug webpage .. IMPALA-3597: mislabelled cache levels on debug webpage Change

[Impala-CR](cdh5-trunk) IMPALA-3597: mislabelled cache levels on debug webpage

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3209 Change subject: IMPALA-3597: mislabelled cache levels on debug webpage .. IMPALA-3597: mislabelled cache levels on debug webpage Change

[Toolchain-CR] IMPALA-3582: TBinaryProtocol buffers consume unbounded memory

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3582: TBinaryProtocol buffers consume unbounded memory .. Patch Set 6: Toolchain build succeeded (aside from an out-of-disk space from a previous job

[Toolchain-CR] IMPALA-3582: TBinaryProtocol buffers consume unbounded memory

2016-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3582: TBinaryProtocol buffers consume unbounded memory .. IMPALA-3582: TBinaryProtocol buffers consume unbounded memory This patch removes

<    5   6   7   8   9   10   11   12   13   14   >