Re: putting types in the diamond....

2016-10-08 Thread A. Soroka
(It was actually Java 7 that introduced the "diamond operator".) I don't know that we have a guideline. I personally like to have policy in hand for questions like these, but I'm not sure we can in this case. Let me give another example, taken directly from the codebase: private final

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 > Unless there is a good reason to make the 2 permissions methods static I would prefer to leave them alone. I had some reason (explained above) but since seems less clear to you, I will remove

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511823 --- Diff: jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java --- @@ -299,7 +299,7 @@ public String toString() throws

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511824 --- Diff: jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java --- @@ -312,7 +312,7 @@ private Boolean cacheGet(final CacheKey

putting types in the diamond....

2016-10-08 Thread Claude Warren
I know that in Java 8 the old {code} Map m = new HashMap(); {code} can now be written as {code} Map m = new HashMap<>(); {code} But why? I suppose in the above it is simple to figure out what is being constructed however if the declaration of the var and the constructor are separated is it not

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread Claudenw
Github user Claudenw commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511612 --- Diff: jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java --- @@ -312,7 +312,7 @@ private Boolean cacheGet(final

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 The bulk of changes to `jena-permissions` are using `<>` instead of writing out type parameters, but there are also a few more substantive syntax and other changes there. --- If your project is set up

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511008 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/validation/DataValidator.java --- @@ -101,33 +95,6 @@ protected JsonObject

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511001 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -162,10 +162,6 @@ } }

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511004 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -371,19 +367,6 @@ else if ( ! dir.isDirectory())

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510986 --- Diff: jena-base/src/test/java/org/apache/jena/atlas/lib/TestHex.java --- @@ -85,7 +85,7 @@ private static void testStr2Val(String str, int expected) {

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511000 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -371,19 +367,6 @@ else if ( ! dir.isDirectory())

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510977 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterTopN.java --- @@ -74,7 +74,7 @@ public QueryIterTopN(QueryIterator qIter,

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/176 I didn't review jena-permissions or jena-jdbc-* or jena-spatial. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510973 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java --- @@ -227,11 +220,6 @@ else if ( ch <= 0x7FFF ) } //int

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510971 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java --- @@ -154,11 +152,6 @@ else if ( (x & 0xF8) == 0xF0 ) }

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 I will try to fix these things sometime tomorrow in another commit, especially if I can fix #151. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510373 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterTopN.java --- @@ -74,7 +74,7 @@ public QueryIterTopN(QueryIterator qIter,

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510665 --- Diff: jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestQuery.java --- @@ -261,18 +260,10 @@ public void query_describe_conneg() {

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510358 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java --- @@ -227,11 +220,6 @@ else if ( ch <= 0x7FFF ) } //int

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510610 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/async/AsyncPool.java --- @@ -53,7 +53,7 @@ public AsyncTask submit(Runnable task,

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510619 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -162,10 +162,6 @@ } }

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510444 --- Diff: jena-base/src/test/java/org/apache/jena/atlas/io/AbstractTestPeekInputStream.java --- @@ -140,7 +139,7 @@ { PeekInputStream in =

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510625 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/validation/DataValidator.java --- @@ -101,33 +95,6 @@ protected JsonObject

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510455 --- Diff: jena-base/src/test/java/org/apache/jena/atlas/lib/cache/TestCacheSimple.java --- @@ -43,7 +43,6 @@ public void testFixedSize() { @Test

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510331 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java --- @@ -154,11 +152,6 @@ else if ( (x & 0xF8) == 0xF0 ) } }

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510652 --- Diff: jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestAdmin.java --- @@ -309,11 +310,6 @@ } } -

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510645 --- Diff: jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/FileSender.java --- @@ -79,8 +79,8 @@ public void send(String method) {

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510433 --- Diff: jena-base/src/test/java/org/apache/jena/atlas/lib/TestHex.java --- @@ -85,7 +85,7 @@ private static void testStr2Val(String str, int expected) {

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510609 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -371,19 +367,6 @@ else if ( ! dir.isDirectory())

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558791#comment-15558791 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I can't get the deadlocking to occur, but by running tests in the order you give, I can see the three failures in `TestRemoteEndpointConnectionWithResultSetTypes`. I don't see anything special about

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558735#comment-15558735 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558723#comment-15558723 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on the issue:

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558636#comment-15558636 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Wow, this is getting quite weird. I don't get any of that stuff. I will get on this and find out why. Deadlock is really unexpected! --- If your project is set up for it, you can reply to this email

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558621#comment-15558621 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/151 I pulled this PR into a clean copy of Jena (I did `git pull https://github.com/apache/jena/ pull/151/head` in to a branch I get test failures in jena-jdbc-driver-remote: with maven: ```

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 Absolutely. Would you rather I just left it here and we can pick it up at the right moment, or close this PR and reopen it post-release? --- If your project is set up for it, you can reply to this

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/176 Can this wait until after the 3.1.1 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 A few more commits to come this afternoon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Test interface in jena-iri?

2016-10-08 Thread A. Soroka
Browsing about in jena-iri, I found an interface org.apache.jena.iri.impl.Test. It is empty and nothing implements it and nothing uses it. Anyone know what it is for? Maybe we can prune it for 3.1.1? --- A. Soroka The University of Virginia Library

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/176 Minor cleanup Just removing dead code and variables that don't get used, adding `static` here or there to clarify tests a bit, that sort of thing. Pruning. You can merge this pull request into a Git

[jira] [Commented] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread Jean-Marc Vanel (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558410#comment-15558410 ] Jean-Marc Vanel commented on JENA-1242: --- Indeed this does the job :

[jira] [Commented] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558372#comment-15558372 ] Andy Seaborne commented on JENA-1242: - {{org.apache.jena.riot.system.IRIResolver}} (there's an old out

[jira] [Commented] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558365#comment-15558365 ] A. Soroka commented on JENA-1242: - bq. my experience is that there are many public datasets with imperfect

[jira] [Commented] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread Jean-Marc Vanel (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558362#comment-15558362 ] Jean-Marc Vanel commented on JENA-1242: --- Many thanks for the clarification. Is there in Jena API an

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558343#comment-15558343 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82506306 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI,

[jira] [Commented] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558339#comment-15558339 ] Andy Seaborne commented on JENA-1242: - It is {{file:///}} after resolving. {{file:}} URLs are not very

[jira] [Commented] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread Jean-Marc Vanel (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558322#comment-15558322 ] Jean-Marc Vanel commented on JENA-1242: --- Sorry, I actually rewrote my test for the report, and

[jira] [Commented] (JENA-1241) Enable Travis-CI for Jena

2016-10-08 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558319#comment-15558319 ] A. Soroka commented on JENA-1241: - Yeah, one nice thing about this is that we are giving people the

[jira] [Commented] (JENA-1241) Enable Travis-CI for Jena

2016-10-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558309#comment-15558309 ] Andy Seaborne commented on JENA-1241: - Seems reasonable to support people working on their own

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558305#comment-15558305 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505814 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI,

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558294#comment-15558294 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505751 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI,

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558287#comment-15558287 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505725 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI, Query

[jira] [Comment Edited] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558267#comment-15558267 ] Andy Seaborne edited comment on JENA-1242 at 10/8/16 4:34 PM: -- What is

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558258#comment-15558258 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Just as an example, I could imagine supporting fluent methods that would let people use Jena's language selection machinery (i.e. `Lang`) instead of using HTTP `Accept` directly. --- If your project

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558248#comment-15558248 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Like I said, I'm fine with making a new fluent API. Can you describe some of the things you see as common in particular to a semweb app? `HttpOp` as it stands doesn't appear to do anything particular to

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558243#comment-15558243 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505343 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI,

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558241#comment-15558241 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/151 To some extent, yes a fluent API is duplication - as I said I only made a quick sketch - but the principle of `HttpOp` is to make the use of general HTTP mechanism provided in forms that wrap up common

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505236 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI, Query

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558236#comment-15558236 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558217#comment-15558217 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82504994 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI,

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558215#comment-15558215 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82504973 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI,

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558203#comment-15558203 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82504834 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI, Query

[jira] [Commented] (JENA-1241) Enable Travis-CI for Jena

2016-10-08 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558195#comment-15558195 ] A. Soroka commented on JENA-1241: - 1. I think you are asking about getting duplicate notifications for

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558186#comment-15558186 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 And as a point of info, I didn't actually end up changing the `HttpOp` API all that much, just `HttpAuthenticator` => `HttpClient`. The additional parameters for `HttpContext` turned out to already be

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558184#comment-15558184 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I'm totally fine with a "high-level" rethink, but at some point, aren't we just duplicating this: https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fluent.html ? --- If your project

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558179#comment-15558179 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on the issue:

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558180#comment-15558180 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 As for the fix, specifically I went to `HttpOp` and made sure that any HTTP clients built there get closed properly. HTTP clients that get passed in don't get closed because that's the job of the client

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/151 Should we take a step back and reconsider whether updating the current API in HttpOp is the right thing to do. Maybe we ought to * introduce a different style more fluid * reconsider a

[jira] [Created] (JENA-1242) SPARQL update: delete a triple fails silently on named graph file:/XX

2016-10-08 Thread Jean-Marc Vanel (JIRA)
Jean-Marc Vanel created JENA-1242: - Summary: SPARQL update: delete a triple fails silently on named graph file:/XX Key: JENA-1242 URL: https://issues.apache.org/jira/browse/JENA-1242 Project: Apache

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558176#comment-15558176 ] ASF GitHub Bot commented on JENA-576: - Github user ajs6f commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Sorry, @afs , I'm working on this now but not keeping this conversation up to date. In fact, my most recent comment I now believe to have been wrong. See

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558166#comment-15558166 ] ASF GitHub Bot commented on JENA-576: - Github user afs commented on the issue:

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/151 For information, what's the fix? I've unmerged this all from my local copy and will start again when we agree it's ready. If it's easier, maybe drop this and open a new PR when ready? --- If

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/175#discussion_r82504509 --- Diff: .travis.yml --- @@ -0,0 +1,18 @@ +language: java +sudo: false +script: mvn -Pdev verify +jdk: + - oraclejdk8 + - openjdk8

[jira] [Commented] (JENA-1241) Enable Travis-CI for Jena

2016-10-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558164#comment-15558164 ] Andy Seaborne commented on JENA-1241: - We already have a Jenkins job that runs on each git commit.

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/175#discussion_r82504448 --- Diff: .travis.yml --- @@ -0,0 +1,18 @@ +language: java +sudo: false +script: mvn -Pdev verify +jdk: + - oraclejdk8 + - openjdk8

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/175#discussion_r82504407 --- Diff: .travis.yml --- @@ -0,0 +1,18 @@ +language: java +sudo: false +script: mvn -Pdev verify +jdk: + - oraclejdk8 + - openjdk8

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/175#discussion_r82504373 --- Diff: .travis.yml --- @@ -0,0 +1,18 @@ +language: java +sudo: false +script: mvn -Pdev verify +jdk: + - oraclejdk8 + - openjdk8

[GitHub] jena pull request #171: Using library code in a few classes

2016-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [jira] [Commented] (JENA-1241) Enable Travis-CI for Jena

2016-10-08 Thread A. Soroka
Folks-- This is just a minor addition to the services around our build. Travis-CI is really nice and free for projects without special needs (like us). It incurs no obligation on our part, no agreement, no commitment, and the only maintenance is to keep a single, simple dot-file in the root of

[jira] [Created] (JENA-1241) Enable Travis-CI for Jena

2016-10-08 Thread A. Soroka (JIRA)
A. Soroka created JENA-1241: --- Summary: Enable Travis-CI for Jena Key: JENA-1241 URL: https://issues.apache.org/jira/browse/JENA-1241 Project: Apache Jena Issue Type: Improvement

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/175 Added .travis.yml https://issues.apache.org/jira/browse/JENA-1241 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena TravisCI Alternatively

[jira] [Commented] (JENA-1241) Enable Travis-CI for Jena

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558014#comment-15558014 ] ASF GitHub Bot commented on JENA-1241: -- GitHub user ajs6f opened a pull request:

  1   2   >