Re: Review Request 39394: LENS-830: Checkstyle version should be picked from project version

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39394/#review103917
---



pom.xml (line 550)
<https://reviews.apache.org/r/39394/#comment162025>

Can you verify mvn versions:set works without issues? Also verify mvn 
release:prepare --dry-run works without issues?


- Amareshwari Sriramadasu


On Oct. 16, 2015, 12:16 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39394/
> ---
> 
> (Updated Oct. 16, 2015, 12:16 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-830
> https://issues.apache.org/jira/browse/LENS-830
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 
> 
> Diff: https://reviews.apache.org/r/39394/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

[Amareshwari Sriramadasu]

> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 
> > 89
> > <https://reviews.apache.org/r/39576/diff/2/?file=1103857#file1103857line89>
> >
> > Why is this required? There can be more than one session per user.
> 
> Raju Bairishetti wrote:
> This map os used for mapping from session handle to user. this was aed to 
> know who is closing the session. right now we are not mentioning username 
> while closing session. I can combine session_map ans sessionhandletousermap 
> if required.
> 
> Amareshwari Sriramadasu wrote:
> Please remove this. I dont see any usefulness with this. The caller of 
> the api could be different from user who opened.
> 
> Raju Bairishetti wrote:
> I feel it is required as we need username for for updating(decrementing) 
> number of sessions for user while closing a session.

getSession(sessionHandle).getLoggedInUser() would give the user of a session. 
Why is a map required?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review103916
---


On Oct. 23, 2015, 5:51 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -------
> 
> (Updated Oct. 23, 2015, 5:51 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Failing the open session operation if user creates more sessions than 
> configured limit.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f202603 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 0821fe7 
>   lens-server/src/main/resources/lensserver-default.xml 1e6bd10 
>   lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 
> def5683 
>   
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java
>  8e22837 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  18a8c8d 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> bc1463f 
>   
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
>  3055ce5 
>   
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java
>  6f7c216 
>   src/site/apt/admin/config.apt 3a0678f 
> 
> Diff: https://reviews.apache.org/r/39576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Raju Bairishetti
> 
>

Re: Review Request 39439: LENS-835 : Optimizing fact subquery by removing non aggregated expression columns from group by clause

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39439/#review103915
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 19, 2015, 2:07 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39439/
> ---
> 
> (Updated Oct. 19, 2015, 2:07 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-835
> https://issues.apache.org/jira/browse/LENS-835
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently the fact keys used in SQL are part of group by clause by default. 
> If single row functions e.g case, having fact keys part of it and used in an 
> aggregate expression such keys need to be removed from fact subquery group by 
> clause.
> Eg. sum(case when fact.key1 = '123' then msr1 when fact.key2 = '345' then 
> msr2 end)
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  2d81ff2 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  77ab302 
> 
> Diff: https://reviews.apache.org/r/39439/diff/
> 
> 
> Testing
> ---
> 
> Updated unit tests. mvn clean install is running fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules . SUCCESS [36.932s]
> [INFO] Lens .. SUCCESS [54.867s]
> [INFO] Lens API .. SUCCESS [1:06.700s]
> [INFO] Lens API for server and extensions  SUCCESS [50.545s]
> [INFO] Lens Cube . SUCCESS [7:46.586s]
> [INFO] Lens DB storage ... SUCCESS [36.905s]
> [INFO] Lens Query Library  SUCCESS [31.101s]
> [INFO] Lens Hive Driver .. SUCCESS [4:36.710s]
> [INFO] Lens Driver for JDBC .. SUCCESS [1:01.830s]
> [INFO] Lens Elastic Search Driver  SUCCESS [35.007s]
> [INFO] Lens Server ... SUCCESS 
> [21:58.491s]
> [INFO] Lens client ... SUCCESS [1:08.860s]
> [INFO] Lens CLI .. SUCCESS [5:50.915s]
> [INFO] Lens Examples . SUCCESS [24.718s]
> [INFO] Lens Distribution . SUCCESS [3:59.018s]
> [INFO] Lens ML Lib ... SUCCESS 
> [24:14.233s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [19.281s]
> [INFO] Lens Regression ... SUCCESS [36.204s]
> [INFO] Lens UI ... SUCCESS [43.419s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:17:53.867s
> [INFO] Finished at: Mon Oct 19 17:20:57 IST 2015
> [INFO] Final Memory: 181M/1820M
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39419/#review103931
---


I see the issue is still open, but review request is closed. So, reopened.

Gabor, Do you still see errors on generated doc? 
Raju/Gabor, Is that resulting in build failure in java-8?

- Amareshwari Sriramadasu


On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39419/
> ---
> 
> (Updated Oct. 19, 2015, 1:33 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-824 Fix all javadoc warnings/errors
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  971e794930e67a25404b4da75d596cfd26a7e17e 
>   lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java 
> e6152b87cf008b4b4fcb57985c56d1449272b23d 
>   lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java 
> 92a936a91b7882e4de0b71b6aa9e4f3707770dce 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  4c8b525b118c280fe81e7e8ae3c6e98aab312a32 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  deb857213dc2e113d98f3cf854d0f84813455170 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  9dfde0db7edad0c30528425479af8d4d64e894a7 
>   
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 
> cc627cfcbcb266cf8586195d56742ab6ec8cbfba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  3ea75246cb2b72376395e04eacacca1f88f8e347 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  22497ca31d710de0dcf3aef2a2a73f814e042f33 
>   pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 
> 
> Diff: https://reviews.apache.org/r/39419/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39483: LENS-838 : Literals with escaped quotes are not honoured in columnarSQLRewriter

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39483/#review103914
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 20, 2015, 4:40 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39483/
> ---
> 
> (Updated Oct. 20, 2015, 4:40 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-838
> https://issues.apache.org/jira/browse/LENS-838
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently literal escape "\'" is not being rewritten properly in fact filter 
> pushdown subquery.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  2d81ff2 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  77ab302 
> 
> Diff: https://reviews.apache.org/r/39483/diff/
> 
> 
> Testing
> ---
> 
> Added unit test for the same. mvn clean test is running fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [3.214s]
> [INFO] Lens .. SUCCESS [3.849s]
> [INFO] Lens API .. SUCCESS [23.475s]
> [INFO] Lens API for server and extensions  SUCCESS [21.289s]
> [INFO] Lens Cube . SUCCESS [5:29.531s]
> [INFO] Lens DB storage ... SUCCESS [20.594s]
> [INFO] Lens Query Library  SUCCESS [18.317s]
> [INFO] Lens Hive Driver .. SUCCESS [2:55.668s]
> [INFO] Lens Driver for JDBC .. SUCCESS [39.508s]
> [INFO] Lens Elastic Search Driver  SUCCESS [20.276s]
> [INFO] Lens Server ... SUCCESS [8:16.843s]
> [INFO] Lens client ... SUCCESS [38.174s]
> [INFO] Lens CLI .. SUCCESS [59.223s]
> [INFO] Lens Examples . SUCCESS [9.262s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.492s]
> [INFO] Lens Distribution . SUCCESS [9.412s]
> [INFO] Lens ML Lib ... SUCCESS [1:26.900s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.188s]
> [INFO] Lens Regression ... SUCCESS [14.860s]
> [INFO] Lens UI ... SUCCESS [28.267s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:23.342s
> [INFO] Finished at: Tue Oct 20 16:38:12 UTC 2015
> [INFO] Final Memory: 196M/1690M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 39606: LENS-843 : Columns in having clause not getting push down

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39606/#review103912
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 23, 2015, 6:11 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39606/
> ---
> 
> (Updated Oct. 23, 2015, 6:11 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-843
> https://issues.apache.org/jira/browse/LENS-843
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> For aggregate columns not being projected but part of having clause are not 
> getting pushed down.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  2d81ff2 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  77ab302 
> 
> Diff: https://reviews.apache.org/r/39606/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. mvn clean install working fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules . SUCCESS [11.676s]
> [INFO] Lens .. SUCCESS [20.239s]
> [INFO] Lens API .. SUCCESS [40.179s]
> [INFO] Lens API for server and extensions  SUCCESS [34.746s]
> [INFO] Lens Cube . SUCCESS [7:55.199s]
> [INFO] Lens DB storage ... SUCCESS [28.959s]
> [INFO] Lens Query Library  SUCCESS [26.757s]
> [INFO] Lens Hive Driver .. SUCCESS [4:38.749s]
> [INFO] Lens Driver for JDBC .. SUCCESS [58.672s]
> [INFO] Lens Elastic Search Driver  SUCCESS [28.183s]
> [INFO] Lens Server ... SUCCESS 
> [26:57.251s]
> [INFO] Lens client ... SUCCESS [1:01.795s]
> [INFO] Lens CLI .. SUCCESS [1:30.578s]
> [INFO] Lens Examples . SUCCESS [15.974s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [5.639s]
> [INFO] Lens Distribution . SUCCESS [22.021s]
> [INFO] Lens ML Lib ... SUCCESS [3:17.458s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [16.127s]
> [INFO] Lens Regression ... SUCCESS [28.530s]
> [INFO] Lens UI ... SUCCESS [33.597s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 39650: LENS-846: Not all filters on fact is getting push down

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39650/#review103997
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 (line 1001)
<https://reviews.apache.org/r/39650/#comment162186>

How is this joining with AND is working? Can you include tests with some 
child filters being on OR ?



lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 (line )
<https://reviews.apache.org/r/39650/#comment162185>

Can you add test with only filter being present on fact.time and it is not 
selected


- Amareshwari Sriramadasu


On Oct. 26, 2015, 11:22 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39650/
> ---
> 
> (Updated Oct. 26, 2015, 11:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-846
> https://issues.apache.org/jira/browse/LENS-846
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> For optimization all fact filters should be pushed down to fact subquery. 
> Currently this is not happening.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  c6797aa 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  31c7dad 
> 
> Diff: https://reviews.apache.org/r/39650/diff/
> 
> 
> Testing
> ---
> 
> JDBC tests are running fine. Will update all test result shortly.
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 39651: LENS-845: Take regex rename arguments in columnar sql rewriter

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/#review103996
---



lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml (line 38)
<https://reviews.apache.org/r/39651/#comment162184>

Can you override this in tests to take more mapping and a test for new 
mapping provided ?



lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 (line 137)
<https://reviews.apache.org/r/39651/#comment162183>

Is this required?


- Amareshwari Sriramadasu


On Oct. 26, 2015, 11:16 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39651/
> ---
> 
> (Updated Oct. 26, 2015, 11:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-845
> https://issues.apache.org/jira/browse/LENS-845
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> right now, the replacement strings are hard coded.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  c6797aa441cf160d45cda74a7ccf9facd3084488 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  a26acde14c3f71c60cacb9e99290827eb82f5525 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> e94c2f35f998796dd6e40d440db75305c56b9f1d 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  31c7dadec795141769d12448c9381a6a73482f61 
> 
> Diff: https://reviews.apache.org/r/39651/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104152
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 (line 180)
<https://reviews.apache.org/r/39680/#comment162426>

We can remove new HashMap<>()



lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml (line 33)
<https://reviews.apache.org/r/39680/#comment162425>

Move to tests?


Can you include unit test?

- Amareshwari Sriramadasu


On Oct. 27, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 8:08 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104162
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
(line 705)
<https://reviews.apache.org/r/39680/#comment162442>

JDBC_DB_URI is added twice and JDBC_DRIVER_CLASS is removed


- Amareshwari Sriramadasu


On Oct. 27, 2015, 12:38 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 12:38 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 777f73a7bf9f30c0035b90689de9a83c908a1402 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  9041709554d67ca1b047e6db24be9cd52127ac5d 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> jdbc driver test cases and checkstyle passed
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39686/
---

Review request for lens.


Bugs: LENS-849
https://issues.apache.org/jira/browse/LENS-849


Repository: lens


Description
---

Added regression test with fix. Also fixed comparison in TestQuery for non-join 
queries.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
f81f3d5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 705f19b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
b2a15a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 2707c4c 

Diff: https://reviews.apache.org/r/39686/diff/


Testing
---

All lens-cube tests succeeded


Thanks,

Amareshwari Sriramadasu

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104171
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 (line 195)
<https://reviews.apache.org/r/39680/#comment162452>

Seems a wrong property setting even earlier


- Amareshwari Sriramadasu


On Oct. 27, 2015, 2:53 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 2:53 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  825a039d1de808e85a9909b18865c1989c486743 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 777f73a7bf9f30c0035b90689de9a83c908a1402 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
>  21e5f50dcbcabe4d93b9cfac45191f8f4c129a1e 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  9041709554d67ca1b047e6db24be9cd52127ac5d 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
>   src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
>   src/site/apt/admin/jdbcdriver-config.apt 
> 7b42309fb2a3c0d3478c6d0f472f782c69f76f85 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> jdbc driver test cases and checkstyle passed
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39651: LENS-845: Take regex rename arguments in columnar sql rewriter

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/#review104001
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 26, 2015, 12:26 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39651/
> ---
> 
> (Updated Oct. 26, 2015, 12:26 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-845
> https://issues.apache.org/jira/browse/LENS-845
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> right now, the replacement strings are hard coded.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  c6797aa441cf160d45cda74a7ccf9facd3084488 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  a26acde14c3f71c60cacb9e99290827eb82f5525 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> e94c2f35f998796dd6e40d440db75305c56b9f1d 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  31c7dadec795141769d12448c9381a6a73482f61 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 1dc0a85b485232ebb3513f910899d34323042605 
> 
> Diff: https://reviews.apache.org/r/39651/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39686/
---

(Updated Oct. 27, 2015, 2:04 p.m.)


Review request for lens.


Bugs: LENS-849
https://issues.apache.org/jira/browse/LENS-849


Repository: lens


Description
---

Added regression test with fix. Also fixed comparison in TestQuery for non-join 
queries.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
f81f3d5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 705f19b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
b2a15a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 2707c4c 

Diff: https://reviews.apache.org/r/39686/diff/


Testing
---

All lens-cube tests succeeded


Thanks,

Amareshwari Sriramadasu

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104166
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 (line 113)
<https://reviews.apache.org/r/39680/#comment162445>

Can we use the constant strings from config? Otherwise let us create 
constants.



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 (line 124)
<https://reviews.apache.org/r/39680/#comment162444>

Remove this


- Amareshwari Sriramadasu


On Oct. 27, 2015, 1:37 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 1:37 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 777f73a7bf9f30c0035b90689de9a83c908a1402 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  9041709554d67ca1b047e6db24be9cd52127ac5d 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
>   src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
>   src/site/apt/admin/jdbcdriver-config.apt 
> 7b42309fb2a3c0d3478c6d0f472f782c69f76f85 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> jdbc driver test cases and checkstyle passed
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

[Amareshwari Sriramadasu]

> On Nov. 4, 2015, 3:51 p.m., Puneet Gupta wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, 
> > line 1249
> > 
> >
> > What happens to skipped(open) sessions ? do we need to close them later 
> > once query execution is over ?
> 
> Deepak Barr wrote:
> I think we can rely of hive server to clean it up eventually.
> 
> Puneet Gupta wrote:
> Not sure if that will be OK. Can someone comment form Hive perspective..
> Will lot open(skipped) hive sessions form lens create issues while 
> creating new Hive sessions?
> What is the timeout for Hive sessions in production? 
> 
> Incase its Not Ok form Hive prespective, we might have to inititiate 
> periodic cleanup on lens side. (If not periodic, it can also be triggeregd 
> when any query is purged. Not very relaible though)
> Only other problem would be server restart. Where do we store the open 
> hive sessions details ? We  might have to serailize that info too. 
> 
> We an take this up separately also if required and close this issue.

Hive does not do any cleanup of sessions. This will lead to session leaks and 
Memory pile up on hive. We should take care of closing the hive sessions when 
all its queries are completed.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39911/#review105069
---


On Nov. 8, 2015, 6:58 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39911/
> ---
> 
> (Updated Nov. 8, 2015, 6:58 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> OperationHandle-HiveSession mapping is maintained for all active operations. 
> Now, hive session will only be closed when there are no active operations 
> running on that session.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> c96ef20 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> c37b0ed 
> 
> Diff: https://reviews.apache.org/r/39911/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 1. Created session.
> 2. Fired a query.
> 3. Deleted the session before query finishes. 
> 4. Query keeps running and finishes eventually.
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 39390: LENS-828: Add derived cube validation

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39390/#review106843
---



lens-api/src/main/resources/lens-errors.conf (line 287)
<https://reviews.apache.org/r/39390/#comment165653>

Let us start the numbers from 3100 or 3500, sothat query errors can be 
separated from metastore errors?


- Amareshwari Sriramadasu


On Nov. 10, 2015, 6:54 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39390/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-828
> https://issues.apache.org/jira/browse/LENS-828
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> All fields should be present in parent cube. 
> 
> Otherwise, we're seeing NPE at runtime.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> a582dc266ae98c240489d2fe78fde0887601545e 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 73a584f507444ceceb265e8439fab45d0de7a1b3 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> 98fb92e6f87773ff658fab501b164553e9d4d58d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  daf7434c02f489ea31e31c2a35bad79a290fc527 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
> e7012f7fab56cb2067c1c6a36cd566fb4dc0cae9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  7d5ed0f94f946716f10e22bacf2bbaf6f30cb145 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  4c8b525b118c280fe81e7e8ae3c6e98aab312a32 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 1ed81ebb6a0c907106951f73b6ca40f1a2f8e303 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  ca0fe56876302ac6790f9369a595d3cc97c8da39 
> 
> Diff: https://reviews.apache.org/r/39390/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.900s]
> [INFO] Lens .. SUCCESS [2.773s]
> [INFO] Lens API .. SUCCESS [20.629s]
> [INFO] Lens API for server and extensions  SUCCESS [21.576s]
> [INFO] Lens Cube . SUCCESS [5:09.811s]
> [INFO] Lens DB storage ... SUCCESS [20.171s]
> [INFO] Lens Query Library  SUCCESS [17.719s]
> [INFO] Lens Hive Driver .. SUCCESS [3:10.593s]
> [INFO] Lens Driver for JDBC .. SUCCESS [38.401s]
> [INFO] Lens Elastic Search Driver  SUCCESS [18.199s]
> [INFO] Lens Server ... SUCCESS [8:17.249s]
> [INFO] Lens client ... SUCCESS [37.602s]
> [INFO] Lens CLI .. SUCCESS [2:34.233s]
> [INFO] Lens Examples . SUCCESS [8.640s]
> [INFO] Lens Distribution . SUCCESS [8.454s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.825s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.091s]
> [INFO] Lens Regression ... SUCCESS [15.420s]
> [INFO] Lens UI ... SUCCESS [25.177s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:32.375s
> [INFO] Finished at: Fri Oct 16 11:15:05 UTC 2015
> [INFO] Final Memory: 194M/2045M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39419/#review104675
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39419/
> ---
> 
> (Updated Oct. 19, 2015, 1:33 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-824 Fix all javadoc warnings/errors
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  971e794930e67a25404b4da75d596cfd26a7e17e 
>   lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java 
> e6152b87cf008b4b4fcb57985c56d1449272b23d 
>   lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java 
> 92a936a91b7882e4de0b71b6aa9e4f3707770dce 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  4c8b525b118c280fe81e7e8ae3c6e98aab312a32 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  deb857213dc2e113d98f3cf854d0f84813455170 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  9dfde0db7edad0c30528425479af8d4d64e894a7 
>   
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 
> cc627cfcbcb266cf8586195d56742ab6ec8cbfba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  3ea75246cb2b72376395e04eacacca1f88f8e347 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  22497ca31d710de0dcf3aef2a2a73f814e042f33 
>   pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 
> 
> Diff: https://reviews.apache.org/r/39419/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review104567
---



lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java (lines 
153 - 157)
<https://reviews.apache.org/r/39809/#comment162798>

Can you add new properties in cube xsd ?



lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java (line 66)
<https://reviews.apache.org/r/39809/#comment162797>

What are these changes for?


- Amareshwari Sriramadasu


On Oct. 30, 2015, 11:24 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> ---
> 
> (Updated Oct. 30, 2015, 11:24 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 2796cd9805e470923164ae3d7a96de7cdc94b920 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  9ea43bba0244555678499799edfba444822b73fd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 
> 67932da900ebe8f92f1dbeb612ca2479b3f62a35 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> f67fc260bf9b5964189df2a5e083bd40e8f90062 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> d7484d83dc0a3f7810ab2109ec882b19b940803b 
> 
> Diff: https://reviews.apache.org/r/39809/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.265s]
> [INFO] Lens .. SUCCESS [3.315s]
> [INFO] Lens API .. SUCCESS [27.409s]
> [INFO] Lens API for server and extensions  SUCCESS [21.902s]
> [INFO] Lens Cube . SUCCESS [5:15.658s]
> [INFO] Lens DB storage ... SUCCESS [28.398s]
> [INFO] Lens Query Library  SUCCESS [20.105s]
> [INFO] Lens Hive Driver .. SUCCESS [2:56.316s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.170s]
> [INFO] Lens Server ... SUCCESS [8:26.874s]
> [INFO] Lens client ... SUCCESS [35.698s]
> [INFO] Lens CLI .. SUCCESS [54.384s]
> [INFO] Lens Examples . SUCCESS [8.477s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.456s]
> [INFO] Lens Distribution . SUCCESS [9.226s]
> [INFO] Lens ML Lib ... SUCCESS [1:23.078s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.365s]
> [INFO] Lens Regression ... SUCCESS [15.631s]
> [INFO] Lens UI ... SUCCESS [28.731s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:16.273s
> [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
> [INFO] Final Memory: 198M/2047M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39897: LENS-860 : Updating committer documentation

[Amareshwari Sriramadasu]

> On Nov. 3, 2015, 1:23 p.m., Raju Bairishetti wrote:
> > src/site/apt/developer/commit.apt, line 38
> > <https://reviews.apache.org/r/39897/diff/1/?file=1114507#file1114507line38>
> >
> > IMHO, If invited as PMC then role should be only PMC. We can specify 
> > roles as PMC & Committer only if invited for **both** PMC & Committer.

PMC would be already a committer or a new committer, so should be fine.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/#review104905
---


On Nov. 3, 2015, 12:28 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> ---
> 
> (Updated Nov. 3, 2015, 12:28 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Have updated the documentation
> 
> 
> Diffs
> -
> 
>   src/site/apt/developer/commit.apt f908925 
> 
> Diff: https://reviews.apache.org/r/39897/diff/
> 
> 
> Testing
> ---
> 
> No code changes to test.
> 
> 
> Thanks,
> 
> Amruth Sampath
> 
>

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39911/#review105035
---


Can you add unit test?

- Amareshwari Sriramadasu


On Nov. 3, 2015, 6:43 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39911/
> ---
> 
> (Updated Nov. 3, 2015, 6:43 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> OperationHandle-HiveSession mapping is maintained for all active operations. 
> Now, hive session will only be closed when there are no active operations 
> running on that session.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> c96ef20 
> 
> Diff: https://reviews.apache.org/r/39911/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 1. Created session.
> 2. Fired a query.
> 3. Deleted the session before query finishes. 
> 4. Query keeps running and finishes eventually.
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 39653: LENS-844: querying a measure with dim attributes not queryable with it gives wrong error

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39653/#review104568
---



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 71)
<https://reviews.apache.org/r/39653/#comment162799>

Dont we have to the table name out here?



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 155)
<https://reviews.apache.org/r/39653/#comment162801>

I think the error of the TIME_DIM_UNSUPPORTED should also say : "Queried 
data not available for time dimensions: %s" 

I feel this is a better message than saying 'not supported'



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 203)
<https://reviews.apache.org/r/39653/#comment162800>

returning null ?



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
(line 272)
<https://reviews.apache.org/r/39653/#comment162802>

    system.out ? Can we remove?


- Amareshwari Sriramadasu


On Oct. 26, 2015, 3:05 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39653/
> ---
> 
> (Updated Oct. 26, 2015, 3:05 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-844
> https://issues.apache.org/jira/browse/LENS-844
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> a582dc266ae98c240489d2fe78fde0887601545e 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
>  bcd42dc573a7619d6e74ec57f00446f6aa3c8c10 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 73a584f507444ceceb265e8439fab45d0de7a1b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  9ea43bba0244555678499799edfba444822b73fd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  f81f3d5975d8604743050d1a5c106039007f871f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
> 7a92b3b17b87c6d8f71ca5d54b0a77de8ff60caa 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 705f19b5a32a2c47342b435d5ef59be31bf6cd71 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  0fea9f1bb4a266b680a252786ebd9e931d1b0c09 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62 
> 
> Diff: https://reviews.apache.org/r/39653/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

[Amareshwari Sriramadasu]

> On Oct. 25, 2015, 3:40 a.m., Amareshwari Sriramadasu wrote:
> > I see the issue is still open, but review request is closed. So, reopened.
> > 
> > Gabor, Do you still see errors on generated doc? 
> > Raju/Gabor, Is that resulting in build failure in java-8?
> 
> Raju Bairishetti wrote:
> We have fixed all the javadoc errors earlier. We may get new javadoc 
> errors as many patches were in. 
> 
> Right now, build won't be failed as we are not generating the javadocs as 
> part of build. We need to fix all warnings & errors before adding javadoc to 
> build cycle.

Raju/Gabor, Are you planning to do more work on this jira? If so, what is 
pending? Capturing in a review comment would make sense. If not, we should get 
this in.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39419/#review103931
---


On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39419/
> ---
> 
> (Updated Oct. 19, 2015, 1:33 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-824 Fix all javadoc warnings/errors
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  971e794930e67a25404b4da75d596cfd26a7e17e 
>   lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java 
> e6152b87cf008b4b4fcb57985c56d1449272b23d 
>   lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java 
> 92a936a91b7882e4de0b71b6aa9e4f3707770dce 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  4c8b525b118c280fe81e7e8ae3c6e98aab312a32 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  deb857213dc2e113d98f3cf854d0f84813455170 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  9dfde0db7edad0c30528425479af8d4d64e894a7 
>   
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 
> cc627cfcbcb266cf8586195d56742ab6ec8cbfba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  3ea75246cb2b72376395e04eacacca1f88f8e347 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  22497ca31d710de0dcf3aef2a2a73f814e042f33 
>   pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 
> 
> Diff: https://reviews.apache.org/r/39419/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39390: LENS-828: Add derived cube validation

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39390/#review105368
---



lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java (line 88)
<https://reviews.apache.org/r/39390/#comment163929>

Can we map the error with 403 error code and put error message in 
lens-errors.conf ?


- Amareshwari Sriramadasu


On Oct. 16, 2015, 11:51 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39390/
> ---
> 
> (Updated Oct. 16, 2015, 11:51 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-828
> https://issues.apache.org/jira/browse/LENS-828
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> All fields should be present in parent cube. 
> 
> Otherwise, we're seeing NPE at runtime.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> 98fb92e6f87773ff658fab501b164553e9d4d58d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  daf7434c02f489ea31e31c2a35bad79a290fc527 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
> e7012f7fab56cb2067c1c6a36cd566fb4dc0cae9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  7d5ed0f94f946716f10e22bacf2bbaf6f30cb145 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 705f19b5a32a2c47342b435d5ef59be31bf6cd71 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  4c8b525b118c280fe81e7e8ae3c6e98aab312a32 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 1ed81ebb6a0c907106951f73b6ca40f1a2f8e303 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  ca0fe56876302ac6790f9369a595d3cc97c8da39 
> 
> Diff: https://reviews.apache.org/r/39390/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.900s]
> [INFO] Lens .. SUCCESS [2.773s]
> [INFO] Lens API .. SUCCESS [20.629s]
> [INFO] Lens API for server and extensions  SUCCESS [21.576s]
> [INFO] Lens Cube . SUCCESS [5:09.811s]
> [INFO] Lens DB storage ... SUCCESS [20.171s]
> [INFO] Lens Query Library  SUCCESS [17.719s]
> [INFO] Lens Hive Driver .. SUCCESS [3:10.593s]
> [INFO] Lens Driver for JDBC .. SUCCESS [38.401s]
> [INFO] Lens Elastic Search Driver  SUCCESS [18.199s]
> [INFO] Lens Server ... SUCCESS [8:17.249s]
> [INFO] Lens client ... SUCCESS [37.602s]
> [INFO] Lens CLI .. SUCCESS [2:34.233s]
> [INFO] Lens Examples . SUCCESS [8.640s]
> [INFO] Lens Distribution . SUCCESS [8.454s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.825s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.091s]
> [INFO] Lens Regression ... SUCCESS [15.420s]
> [INFO] Lens UI ... SUCCESS [25.177s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:32.375s
> [INFO] Finished at: Fri Oct 16 11:15:05 UTC 2015
> [INFO] Final Memory: 194M/2045M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39897: LENS-860 : Updating committer documentation

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/#review105360
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Nov. 4, 2015, 8:22 a.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> ---
> 
> (Updated Nov. 4, 2015, 8:22 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Have updated the documentation
> 
> 
> Diffs
> -
> 
>   pom.xml 5e8f046 
>   src/site/apt/developer/commit.apt f908925 
> 
> Diff: https://reviews.apache.org/r/39897/diff/
> 
> 
> Testing
> ---
> 
> No code changes to test.
> 
> 
> Thanks,
> 
> Amruth Sampath
> 
>

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review105363
---



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 144)
<https://reviews.apache.org/r/39576/#comment163923>

Can we throw this as LensException and go through exceptionMapper for 
progating the error, as done for other api ? This should be fine as this a new 
exception being thrown.

We need to add the error message to lens-errors.conf and add error to 
LensCommonErrorCode


- Amareshwari Sriramadasu


On Oct. 31, 2015, 12:24 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> ---
> 
> (Updated Oct. 31, 2015, 12:24 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Failing the open session operation if user creates more sessions than 
> configured limit.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf a582dc2 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7ee0749 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 0821fe7 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 
> def5683 
>   
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java
>  8e22837 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  ca0fe56 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  18a8c8d 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> bc1463f 
>   
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
>  3055ce5 
>   
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java
>  6f7c216 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/39576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Raju Bairishetti
> 
>

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review105366
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Nov. 2, 2015, 9:35 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> ---
> 
> (Updated Nov. 2, 2015, 9:35 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 5d7630d8176a4a527a335dbceb12dee2bc0d51c8 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 2796cd9805e470923164ae3d7a96de7cdc94b920 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  9ea43bba0244555678499799edfba444822b73fd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 
> 67932da900ebe8f92f1dbeb612ca2479b3f62a35 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> f67fc260bf9b5964189df2a5e083bd40e8f90062 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> d7484d83dc0a3f7810ab2109ec882b19b940803b 
> 
> Diff: https://reviews.apache.org/r/39809/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.265s]
> [INFO] Lens .. SUCCESS [3.315s]
> [INFO] Lens API .. SUCCESS [27.409s]
> [INFO] Lens API for server and extensions  SUCCESS [21.902s]
> [INFO] Lens Cube . SUCCESS [5:15.658s]
> [INFO] Lens DB storage ... SUCCESS [28.398s]
> [INFO] Lens Query Library  SUCCESS [20.105s]
> [INFO] Lens Hive Driver .. SUCCESS [2:56.316s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.170s]
> [INFO] Lens Server ... SUCCESS [8:26.874s]
> [INFO] Lens client ... SUCCESS [35.698s]
> [INFO] Lens CLI .. SUCCESS [54.384s]
> [INFO] Lens Examples . SUCCESS [8.477s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.456s]
> [INFO] Lens Distribution . SUCCESS [9.226s]
> [INFO] Lens ML Lib ... SUCCESS [1:23.078s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.365s]
> [INFO] Lens Regression ... SUCCESS [15.631s]
> [INFO] Lens UI ... SUCCESS [28.731s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:16.273s
> [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
> [INFO] Final Memory: 198M/2047M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39894: LENS-858: Fixes no cubes available even when there are.

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39894/#review105435
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Nov. 3, 2015, 10:18 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39894/
> ---
> 
> (Updated Nov. 3, 2015, 10:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-858: Fixes no cubes available even when there are.
> 
> 
> Diffs
> -
> 
>   lens-ui/app/components/CubeTreeComponent.js e348898 
> 
> Diff: https://reviews.apache.org/r/39894/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 39842: Ability to load different instances of same driver class

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39842/#review105437
---


Overall changes looked clean and nice. I really enjoyed reviewing the changes :)
Looking forward for the updated patch with documentation and testcases added.


lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java (line 
38)
<https://reviews.apache.org/r/39842/#comment164038>

Will it be possible to define driver types as constant strings or enum?


- Amareshwari Sriramadasu


On Nov. 2, 2015, 4:08 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39842/
> ---
> 
> (Updated Nov. 2, 2015, 4:08 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-123
> https://issues.apache.org/jira/browse/LENS-123
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Ability to load multiple drivers on lens server. 
> 
> As of now only one driver instance of each type (hive,jdbc,es,etc) can be 
> loaded by lens server. Hence lens can not support for example, two jdbc 
> instances, one for MySql and one for Vertica or just two different MySQl 
> deployments. This can be a big limitation for some deployments.  
> 
> Made below changes in fix 
> 1. Based on the approaches discussed in JIRA(LENS-123), the below folder 
> structure was picked.  (Please refer to the discussion on JIRA if required - 
> last few comments )
> -conf
> --drivers 
> ---hive 
> driver1
> -hivedriver-site.xml
> driver2
> -hivedriver-site.xml
> ---jdbc
> driver1
> -jdbcdriver-site.xml
> driver2
> -jdbcdriver-site.xml
> Note: drivers configuration is read from "drivers" directory under conf 
> location. Conf loaction is set while starting the server as -Dconfig.location 
> = "" 
> 
> 2. Added an abstract class  
> "org.apache.lens.server.api.driver.AbstractLensDriver". This has common 
> implemenation for getting lens driver's fully qualified name and some methods 
> for getting driver specific resource paths. All existing driver 
> implementations extend this class. In future, we can also add common 
> functionality here(if required) without affecting existing driver 
> implementations that extend this abstract class.
> 
> 3. Updated driver interface 
> -configure method now takes driver name and type configuration parameters.
> -added getFullyQualifiedName() method to identify the driver uniquely. 
> 
> 4. Value of lens.server.drivers property in lens-site.xml (and 
> default-lens-site) updated to include driver type and driver class name 
> (earlier only driver class name was present).
> hive:org.apache.lens.driver.hive.HiveDriver,jdbc:org.apache.lens.driver.jdbc.JDBCDriver
> 
> 5. Updated LensServerDAO to use driver qualified name instead of driver class 
> name. The table column name is chnaged to drivername form driverclass 
> 
> 6. The driver instance was earlier referred to by its class name 
> (Example:org.apache.lens.driver.hive.HiveDriver) everywhere in code. This is 
> now changed to driver's fully qualified name which has the driver type and 
> driver name (Example :hive/hive1)
> 
> 7. All metrics were also relying on driver class name. This is also changed 
> to driver's fully qualified name.
> 
> 8. Updated driver folder struture for test cases and lens server build (as 
> per point1).
> 
> 9. Query execution service will fail to start if no drivers are found. (This 
> is a change from previous flow . We can discuss this if req.)  
> 
> 
> Pending ( will upload this soon)
> 1. Adding test cases to test multiple drivers
> 2. updating documentation
> 
> Future Enhancements(that can be taken up as a separate JIRA)
> 1.Multiple versions of a datasource to be supported ( say Hive and Hive on 
> spark use different versions of Hive. This will not work as of now as we have 
> common Hive jars as part of war classpath. We need to have driver specific 
> jars which can have different version. For this, the jars and other hive 
> version specific resources should be picked from driver's folder by a 
> separate class loader).
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/LensPreparedQuery.java 
> 9595ce9 
>   lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 204ecee 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQ

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39895/#review105048
---



lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java (line 795)
<https://reviews.apache.org/r/39895/#comment163416>

Why is this change done?



lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 (lines 168 - 172)
<https://reviews.apache.org/r/39895/#comment163417>

What is done here? I see similar code in other methods also. Can be 
separated into another method ?


- Amareshwari Sriramadasu


On Nov. 3, 2015, 2 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39895/
> ---
> 
> (Updated Nov. 3, 2015, 2 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will do further cleanup and refactoring. Putting this up for an early review.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 450d17202d7a06214ecd997d4bab68fe8351ab3e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> ea9badd8f0c20644ca2b6e82586fa33f599b781e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java 
> 067a37a29b536a9ff03aae12a396e7bb99f9ba0f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  15a98dd941bd7b4cb68369fb553d6722956430d6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> 90058260b36879bbc149c3c33198d3daf1179b36 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> d7484d83dc0a3f7810ab2109ec882b19b940803b 
> 
> Diff: https://reviews.apache.org/r/39895/diff/
> 
> 
> Testing
> ---
> 
> Tested for some queries in the test cases themselves. Need to add proper 
> asserts.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39895/#review105051
---


Can you add tests with some fields selected being expressions, functions around 
selected fields (for dimattributes) ?

- Amareshwari Sriramadasu


On Nov. 3, 2015, 2 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39895/
> ---
> 
> (Updated Nov. 3, 2015, 2 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will do further cleanup and refactoring. Putting this up for an early review.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 450d17202d7a06214ecd997d4bab68fe8351ab3e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> ea9badd8f0c20644ca2b6e82586fa33f599b781e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java 
> 067a37a29b536a9ff03aae12a396e7bb99f9ba0f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  15a98dd941bd7b4cb68369fb553d6722956430d6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> 90058260b36879bbc149c3c33198d3daf1179b36 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> d7484d83dc0a3f7810ab2109ec882b19b940803b 
> 
> Diff: https://reviews.apache.org/r/39895/diff/
> 
> 
> Testing
> ---
> 
> Tested for some queries in the test cases themselves. Need to add proper 
> asserts.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39430: Create a single jar for shipping with hive queries

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39430/#review103096
---



lens-ship-jars/pom.xml (line 70)
<https://reviews.apache.org/r/39430/#comment160983>

Can we include open csv aswell, which is right now coming as transitive 
dependency from lens-query-lib?


- Amareshwari Sriramadasu


On Oct. 19, 2015, 4:46 a.m., Srikanth Sundarrajan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39430/
> ---
> 
> (Updated Oct. 19, 2015, 4:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-831
> https://issues.apache.org/jira/browse/LENS-831
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently a number of jars have to be shipped along with each query apart 
> from user extension jars for udf, serde etc. This has two side effects:
> 
> 1. Number of ClassLoader on the hive server increases (potentially causing 
> PermGen OOM issues)
> 2. Number of jar localization events in the node manager when executing a 
> task.
> 
> The proposal is to bundle these and create a single shaded jar and make it 
> available in the binary distribution.
> 
> 
> Diffs
> -
> 
>   lens-dist/pom.xml bc94209 
>   lens-dist/src/main/assembly/bin-dist.xml 8707af9 
>   lens-ship-jars/LICENSE PRE-CREATION 
>   lens-ship-jars/pom.xml PRE-CREATION 
>   lens-ship-jars/src/site/apt/index.apt PRE-CREATION 
>   pom.xml 7140038 
>   src/site/apt/lenshome/install-and-run.apt 491bbee 
> 
> Diff: https://reviews.apache.org/r/39430/diff/
> 
> 
> Testing
> ---
> 
> Verified that the shippable jar is created correctly and the same is being 
> added to the binary distribution package
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>

Re: Review Request 39394: LENS-830: Checkstyle version should be picked from project version

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39394/#review103107
---


Can you verify mvn versions:set works without issues? Also verify mvn 
release:prepare --dry-run works without issues?

- Amareshwari Sriramadasu


On Oct. 16, 2015, 12:16 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39394/
> ---
> 
> (Updated Oct. 16, 2015, 12:16 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-830
> https://issues.apache.org/jira/browse/LENS-830
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 
> 
> Diff: https://reviews.apache.org/r/39394/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39161: LENS-292 : Query result retention policy

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39161/#review103121
---



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 74)
<https://reviews.apache.org/r/39161/#comment161064>

Can we rename variable to QUERY_RESULT_PURGER_ERROR_COUNTER


- Amareshwari Sriramadasu


On Oct. 19, 2015, 11:33 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39161/
> ---
> 
> (Updated Oct. 19, 2015, 11:33 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-292
> https://issues.apache.org/jira/browse/LENS-292
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added query result purge policy on both Driver persisted and Lens persisted 
> resultset. Default retention of 1 day. Purging can be turned off with a 
> setting.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java cbcc76c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f202603 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  deb8572 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
> PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 1e6bd10 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryResultPurger.java
>  PRE-CREATION 
>   src/site/apt/admin/config.apt 3a0678f 
> 
> Diff: https://reviews.apache.org/r/39161/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.785 
> s]
> [INFO] Lens ... SUCCESS [  5.339 
> s]
> [INFO] Lens API ... SUCCESS [ 28.950 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 28.187 
> s]
> [INFO] Lens Cube .. SUCCESS [07:05 
> min]
> [INFO] Lens DB storage  SUCCESS [ 28.169 
> s]
> [INFO] Lens Query Library . SUCCESS [ 22.031 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:13 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 49.452 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.865 
> s]
> [INFO] Lens Server  SUCCESS [10:58 
> min]
> [INFO] Lens client  SUCCESS [ 47.198 
> s]
> [INFO] Lens CLI ... SUCCESS [03:44 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.516 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.779 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:00 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.212 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.624 
> s]
> [INFO] Lens UI  SUCCESS [  3.415 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 32:45 min
> [INFO] Finished at: 2015-10-07T23:19:44+05:30
> [INFO] Final Memory: 218M/2795M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Review Request 39434: LENS-832 : Fix recovery for Queued queries

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39434/
---

Review request for lens.


Bugs: LENS-832
https://issues.apache.org/jira/browse/LENS-832


Repository: lens


Description
---

The fix is to set proper driver query in drivercontext for the selected driver.


Diffs
-

  
lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
 12fb4ce 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
 44978f2 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 7b15a3c 

Diff: https://reviews.apache.org/r/39434/diff/


Testing
---


Thanks,

Amareshwari Sriramadasu

Re: Review Request 39434: LENS-832 : Fix recovery for Queued queries

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39434/
---

(Updated Oct. 19, 2015, 10:26 a.m.)


Review request for lens.


Bugs: LENS-832
https://issues.apache.org/jira/browse/LENS-832


Repository: lens


Description
---

The fix is to set proper driver query in drivercontext for the selected driver.


Diffs
-

  
lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
 12fb4ce 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
 44978f2 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 7b15a3c 

Diff: https://reviews.apache.org/r/39434/diff/


Testing (updated)
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.886s]
[INFO] Lens .. SUCCESS [2.778s]
[INFO] Lens API .. SUCCESS [23.153s]
[INFO] Lens API for server and extensions  SUCCESS [20.496s]
[INFO] Lens Cube . SUCCESS [5:05.028s]
[INFO] Lens DB storage ... SUCCESS [19.749s]
[INFO] Lens Query Library  SUCCESS [15.540s]
[INFO] Lens Hive Driver .. SUCCESS [2:47.901s]
[INFO] Lens Driver for JDBC .. SUCCESS [36.542s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.866s]
[INFO] Lens Server ... SUCCESS [8:27.025s]
[INFO] Lens client ... SUCCESS [35.727s]
[INFO] Lens CLI .. SUCCESS [2:34.637s]
[INFO] Lens Examples . SUCCESS [8.422s]
[INFO] Lens Distribution . SUCCESS [8.488s]
[INFO] Lens ML Lib ... SUCCESS [1:18.345s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.884s]
[INFO] Lens Regression ... SUCCESS [15.112s]
[INFO] Lens UI ... SUCCESS [26.721s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:08.217s
[INFO] Finished at: Mon Oct 19 09:41:52 UTC 2015
[INFO] Final Memory: 187M/1611M
[INFO] 


Thanks,

Amareshwari Sriramadasu

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review101906
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 (line 429)
<https://reviews.apache.org/r/39127/#comment159406>

I feel instead of adding this public method, setting priority after 
deciding would have been better.


Can we add a unit test ?

- Amareshwari Sriramadasu


On Oct. 8, 2015, 1:18 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> ---
> 
> (Updated Oct. 8, 2015, 1:18 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
> https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> small bug
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  0c980a20953efc6c2d7cc17c97b1552c64a8eb5f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.175s]
> [INFO] Lens .. SUCCESS [2.947s]
> [INFO] Lens API .. SUCCESS [23.439s]
> [INFO] Lens API for server and extensions  SUCCESS [20.441s]
> [INFO] Lens Cube . SUCCESS [6:11.745s]
> [INFO] Lens DB storage ... SUCCESS [22.402s]
> [INFO] Lens Query Library  SUCCESS [18.196s]
> [INFO] Lens Hive Driver .. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.347s]
> [INFO] Lens Server ... SUCCESS [8:17.698s]
> [INFO] Lens client ... SUCCESS [34.376s]
> [INFO] Lens CLI .. SUCCESS [2:36.033s]
> [INFO] Lens Examples . SUCCESS [9.886s]
> [INFO] Lens Distribution . SUCCESS [8.592s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [11.178s]
> [INFO] Lens UI ... SUCCESS [22.051s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38758/#review101900
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 8, 2015, 12:26 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38758/
> ---
> 
> (Updated Oct. 8, 2015, 12:26 p.m.)
> 
> 
> Review request for lens, Ajay Yadava, Amareshwari Sriramadasu, Amruth 
> Sampath, Bala Nathan, Rajat Khandelwal, Raju Bairishetti, and Yash Sharma.
> 
> 
> Bugs: LENS-782
> https://issues.apache.org/jira/browse/LENS-782
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-782 UI for Saved/Parametrized queries + Bug fixes/Enhancements
> 
> 
> Diffs
> -
> 
>   lens-ui/app/actions/AdhocQueryActions.js 8c2d109 
>   lens-ui/app/adapters/AdhocQueryAdapter.js 98f9b49 
>   lens-ui/app/adapters/BaseAdapter.js 81b9ddc 
>   lens-ui/app/app.js 3e389a7 
>   lens-ui/app/components/AdhocQueryComponent.js 66ddf75 
>   lens-ui/app/components/AppComponent.js d7a38f9 
>   lens-ui/app/components/CubeSchemaComponent.js 593c54a 
>   lens-ui/app/components/CubeTreeComponent.js 241c12f 
>   lens-ui/app/components/DatabaseComponent.js 09ee2eb 
>   lens-ui/app/components/HeaderComponent.js 5ec3397 
>   lens-ui/app/components/LoaderComponent.js ba11c64 
>   lens-ui/app/components/LoginComponent.js cf95af9 
>   lens-ui/app/components/LogoutComponent.js 3fc1627 
>   lens-ui/app/components/QueryBoxComponent.js 6d5843c 
>   lens-ui/app/components/QueryDetailResultComponent.js b969a4a 
>   lens-ui/app/components/QueryOperationsComponent.js a17a636 
>   lens-ui/app/components/QueryParamRowComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryParamsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js fabe383 
>   lens-ui/app/components/QueryResultsComponent.js 6e4b8c2 
>   lens-ui/app/components/RequireAuthenticationComponent.js 9a755b0 
>   lens-ui/app/components/RequireAuthenticationComponent.js 9a755b0 
>   lens-ui/app/components/SavedQueriesComponent.js PRE-CREATION 
>   lens-ui/app/components/SavedQueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js dcc8737 
>   lens-ui/app/components/TableSchemaComponent.js 67dc25a 
>   lens-ui/app/components/TableTreeComponent.js 026e443 
>   lens-ui/app/constants/AdhocQueryConstants.js 3c4f93a 
>   lens-ui/app/constants/AppConstants.js 48cd93e 
>   lens-ui/app/dispatcher/AppDispatcher.js 31b267c 
>   lens-ui/app/stores/AdhocQueryStore.js 7420270 
>   lens-ui/app/stores/CubeStore.js 8b20b95 
>   lens-ui/app/stores/DatabaseStore.js 9f4490b 
>   lens-ui/app/stores/SavedQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js 299d9e8 
>   lens-ui/app/stores/UserStore.js 47da021 
>   lens-ui/app/styles/css/global.css 131ab46 
>   lens-ui/app/styles/css/login.css b400cfb 
>   lens-ui/app/styles/css/query-component.css a82165e 
>   lens-ui/app/styles/css/tree.css 402c9a0 
>   lens-ui/app/styles/less/globals.less c0704dc 
>   lens-ui/app/utils/ErrorParser.js PRE-CREATION 
>   lens-ui/index.html 9c20fe9 
>   lens-ui/package.json 920b120 
>   lens-ui/pom.xml 69bcee5 
>   lens-ui/server.js e812018 
>   lens-ui/webpack.config.js ab4021f 
>   pom.xml dd26713 
> 
> Diff: https://reviews.apache.org/r/38758/diff/
> 
> 
> Testing
> ---
> 
> just JavaScript.
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 39373: LENS-341: Update docs with java8 compatibility

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39373/#review102872
---



README.md (line 10)
<https://reviews.apache.org/r/39373/#comment160682>

This need not be specified in readme. as end users wont generate docs. 
Specifying this in contribute doc is enough.


- Amareshwari Sriramadasu


On Oct. 16, 2015, 2:49 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39373/
> ---
> 
> (Updated Oct. 16, 2015, 2:49 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Updated docs with java8 compatibility.
> 
> 
> Diffs
> -
> 
>   README.md d8657c1 
>   src/site/apt/developer/contribute.apt 5b6fbaf 
> 
> Diff: https://reviews.apache.org/r/39373/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Raju Bairishetti
> 
>

Re: Review Request 39344: LENS-827:Expression pushdown for query optimisation in JDBC

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39344/#review102862
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 15, 2015, 4:57 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39344/
> ---
> 
> (Updated Oct. 15, 2015, 4:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-827
> https://issues.apache.org/jira/browse/LENS-827
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently Columnar rewriter skips rewrite in case of expressions used in 
> select query. This ticket is to add the improvement in the rewriter to 
> rewrite them and pushdown to fact subquery.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  8a98c57 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  6b5fb6a 
> 
> Diff: https://reviews.apache.org/r/39344/diff/
> 
> 
> Testing
> ---
> 
> Added new test case, fixed existing test case where expression rewrite was 
> skipped. mvn clean install workd fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.305s]
> [INFO] Lens .. SUCCESS [3.134s]
> [INFO] Lens API .. SUCCESS [24.012s]
> [INFO] Lens API for server and extensions  SUCCESS [20.975s]
> [INFO] Lens Cube . SUCCESS [5:00.782s]
> [INFO] Lens DB storage ... SUCCESS [19.993s]
> [INFO] Lens Query Library  SUCCESS [15.316s]
> [INFO] Lens Hive Driver .. SUCCESS [2:47.214s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.914s]
> [INFO] Lens Elastic Search Driver  SUCCESS [16.264s]
> [INFO] Lens Server ... SUCCESS [7:48.097s]
> [INFO] Lens client ... SUCCESS [35.349s]
> [INFO] Lens CLI .. SUCCESS [2:37.148s]
> [INFO] Lens Examples . SUCCESS [8.553s]
> [INFO] Lens Distribution . SUCCESS [8.560s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.260s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.114s]
> [INFO] Lens Regression ... SUCCESS [12.911s]
> [INFO] Lens UI ... SUCCESS [25.987s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:26.819s
> [INFO] Finished at: Thu Oct 15 16:20:31 UTC 2015
> [INFO] Final Memory: 195M/2032M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 39373: LENS-341: Update docs with java8 compatibility

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39373/#review102873
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 16, 2015, 6:04 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39373/
> ---
> 
> (Updated Oct. 16, 2015, 6:04 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Updated docs with java8 compatibility.
> 
> 
> Diffs
> -
> 
>   README.md d8657c1 
>   src/site/apt/developer/contribute.apt 5b6fbaf 
> 
> Diff: https://reviews.apache.org/r/39373/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Raju Bairishetti
> 
>

Re: Review Request 39434: LENS-832 : Fix recovery for Queued queries

[Amareshwari Sriramadasu]

> On Oct. 20, 2015, 6:59 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java,
> >  line 2331
> > <https://reviews.apache.org/r/39434/diff/1/?file=1100863#file1100863line2331>
> >
> > there's a wrapper `setSelectedDriverQuery` for it. Can we use that?

Looked at it. calling ctx.setSelectedDriverQuery(ctx.getSelectedDriverQuery()) 
- looked like a no-op and could be easily misunderstood.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39434/#review103221
---


On Oct. 19, 2015, 10:26 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39434/
> ---
> 
> (Updated Oct. 19, 2015, 10:26 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-832
> https://issues.apache.org/jira/browse/LENS-832
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The fix is to set proper driver query in drivercontext for the selected 
> driver.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
>  12fb4ce 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  44978f2 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  7b15a3c 
> 
> Diff: https://reviews.apache.org/r/39434/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.886s]
> [INFO] Lens .. SUCCESS [2.778s]
> [INFO] Lens API .. SUCCESS [23.153s]
> [INFO] Lens API for server and extensions  SUCCESS [20.496s]
> [INFO] Lens Cube . SUCCESS [5:05.028s]
> [INFO] Lens DB storage ... SUCCESS [19.749s]
> [INFO] Lens Query Library  SUCCESS [15.540s]
> [INFO] Lens Hive Driver .. SUCCESS [2:47.901s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.542s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.866s]
> [INFO] Lens Server ... SUCCESS [8:27.025s]
> [INFO] Lens client ... SUCCESS [35.727s]
> [INFO] Lens CLI .. SUCCESS [2:34.637s]
> [INFO] Lens Examples . SUCCESS [8.422s]
> [INFO] Lens Distribution . SUCCESS [8.488s]
> [INFO] Lens ML Lib ... SUCCESS [1:18.345s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.884s]
> [INFO] Lens Regression ... SUCCESS [15.112s]
> [INFO] Lens UI ... SUCCESS [26.721s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------
> [INFO] Total time: 24:08.217s
> [INFO] Finished at: Mon Oct 19 09:41:52 UTC 2015
> [INFO] Final Memory: 187M/1611M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 39161: LENS-292 : Query result retention policy

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39161/#review103002
---



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 131)
<https://reviews.apache.org/r/39161/#comment160851>

Can we increment an error counter for failures? Should we catch all 
Exception for thread not to die?



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 135)
<https://reviews.apache.org/r/39161/#comment160852>

We should not call fs.close() here. fs.close() will make all other clients 
to file system also get closed. So, any application should not call fs.close 
otherthan shutting down.



lens-server/src/main/resources/lensserver-default.xml (line 283)
<https://reviews.apache.org/r/39161/#comment160850>

Default value here and the code seems different



lens-server/src/test/java/org/apache/lens/server/query/TestQueryResultPurger.java
 (line 80)
<https://reviews.apache.org/r/39161/#comment160849>

20 seconds is too much time for the test to finish, can  we change purge 
interval to 1 second for test and wait for 2 seconds?


- Amareshwari Sriramadasu


On Oct. 16, 2015, 7:43 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39161/
> ---
> 
> (Updated Oct. 16, 2015, 7:43 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-292
> https://issues.apache.org/jira/browse/LENS-292
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added query result purge policy on both Driver persisted and Lens persisted 
> resultset. Default retention of 1 day. Purging can be turned off with a 
> setting.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java cbcc76c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f202603 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  d57812f 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
> PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 1e6bd10 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryResultPurger.java
>  PRE-CREATION 
>   src/site/apt/admin/config.apt 3a0678f 
> 
> Diff: https://reviews.apache.org/r/39161/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.785 
> s]
> [INFO] Lens ... SUCCESS [  5.339 
> s]
> [INFO] Lens API ... SUCCESS [ 28.950 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 28.187 
> s]
> [INFO] Lens Cube .. SUCCESS [07:05 
> min]
> [INFO] Lens DB storage  SUCCESS [ 28.169 
> s]
> [INFO] Lens Query Library . SUCCESS [ 22.031 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:13 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 49.452 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.865 
> s]
> [INFO] Lens Server  SUCCESS [10:58 
> min]
> [INFO] Lens client  SUCCESS [ 47.198 
> s]
> [INFO] Lens CLI ... SUCCESS [03:44 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.516 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.779 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:00 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.212 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.624 
> s]
> [INFO] Lens UI  SUCCESS [  3.415 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 32:45 min
> [INFO] Finished at: 2015-10-07T23:19:44+05:30
> [INFO] Final Memory: 218M/2795M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 39286: LENS-817 : No need to persist metadata class information in DB after LENS-576 fix

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39286/#review102729
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 13, 2015, 6:32 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39286/
> ---
> 
> (Updated Oct. 13, 2015, 6:32 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Removed the persistence of metadata class along with other references.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
>  8308198 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
> 8a2ac19 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  d57812f 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> 708afe5 
> 
> Diff: https://reviews.apache.org/r/39286/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested the query status and resultset related APIs after the query is 
> purged to DB.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.592 
> s]
> [INFO] Lens ... SUCCESS [  3.872 
> s]
> [INFO] Lens API ... SUCCESS [ 28.298 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 27.500 
> s]
> [INFO] Lens Cube .. SUCCESS [07:04 
> min]
> [INFO] Lens DB storage  SUCCESS [ 26.356 
> s]
> [INFO] Lens Query Library . SUCCESS [ 22.843 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:13 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 50.457 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 21.378 
> s]
> [INFO] Lens Server  SUCCESS [10:52 
> min]
> [INFO] Lens client  SUCCESS [ 47.565 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 12.484 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.654 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:01 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.704 
> s]
> [INFO] Lens Regression  SUCCESS [ 18.117 
> s]
> [INFO] Lens UI  SUCCESS [ 46.465 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:24 min
> [INFO] Finished at: 2015-10-13T19:33:57+05:30
> [INFO] Final Memory: 206M/2383M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks

This config is removed now and the setting and unsetting here can be removed as 
well.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102735
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 183)
<https://reviews.apache.org/r/39191/#comment160485>

Can you reset hive.exec.driver.run.hooks to be empty string?


- Amareshwari Sriramadasu


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39311: LENS-820: Add relative end time for facts

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39311/#review102736
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 14, 2015, 11:38 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39311/
> ---
> 
> (Updated Oct. 14, 2015, 11:38 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-820
> https://issues.apache.org/jira/browse/LENS-820
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> added property
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> a6cff417ee88b2ab3799e86d314b56035b7e304c 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39311/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.519s]
> [INFO] Lens .. SUCCESS [3.301s]
> [INFO] Lens API .. SUCCESS [23.379s]
> [INFO] Lens API for server and extensions  SUCCESS [21.752s]
> [INFO] Lens Cube . SUCCESS [5:25.540s]
> [INFO] Lens DB storage ... SUCCESS [19.670s]
> [INFO] Lens Query Library  SUCCESS [15.986s]
> [INFO] Lens Hive Driver .. SUCCESS [2:47.367s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.821s]
> [INFO] Lens Elastic Search Driver  SUCCESS [16.156s]
> [INFO] Lens Server ... SUCCESS [8:05.578s]
> [INFO] Lens client ... SUCCESS [36.839s]
> [INFO] Lens CLI .. SUCCESS [2:34.421s]
> [INFO] Lens Examples . SUCCESS [8.540s]
> [INFO] Lens Distribution . SUCCESS [8.020s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.947s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.896s]
> [INFO] Lens Regression ... SUCCESS [12.341s]
> [INFO] Lens UI ... SUCCESS [26.619s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:06.662s
> [INFO] Finished at: Wed Oct 14 11:27:13 UTC 2015
> [INFO] Final Memory: 194M/2045M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39315: LENS-821:Filters with comma in IN filters not replacing table alias properly

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39315/#review102611
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 14, 2015, 12:11 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39315/
> ---
> 
> (Updated Oct. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-821
> https://issues.apache.org/jira/browse/LENS-821
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Cube queries with filters with comma in IN list for eg. column IN 
> ('test,123', 'test,345') not replacing table alias in fact subquery properly.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
> 
> Diff: https://reviews.apache.org/r/39315/diff/
> 
> 
> Testing
> ---
> 
> Added unit test for the fix. mvn clean install is working fine.
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules . SUCCESS [19.350s]
> [INFO] Lens .. SUCCESS [23.089s]
> [INFO] Lens API .. SUCCESS [45.152s]
> [INFO] Lens API for server and extensions  SUCCESS [42.298s]
> [INFO] Lens Cube . SUCCESS [7:22.998s]
> [INFO] Lens DB storage ... SUCCESS [33.203s]
> [INFO] Lens Query Library  SUCCESS [26.143s]
> [INFO] Lens Hive Driver .. SUCCESS [4:23.919s]
> [INFO] Lens Driver for JDBC .. SUCCESS [1:07.686s]
> [INFO] Lens Elastic Search Driver  SUCCESS [31.795s]
> [INFO] Lens Server ... SUCCESS 
> [19:26.345s]
> [INFO] Lens client ... SUCCESS [1:02.367s]
> [INFO] Lens CLI .. SUCCESS [8:22.527s]
> [INFO] Lens Examples . SUCCESS [32.166s]
> [INFO] Lens Distribution . SUCCESS [32.780s]
> [INFO] Lens ML Lib ... SUCCESS [4:02.491s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [13.711s]
> [INFO] Lens Regression ... SUCCESS [23.502s]
> [INFO] Lens UI ... SUCCESS [16.484s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 51:29.337s
> [INFO] Finished at: Wed Oct 14 17:41:05 IST 2015
> [INFO] Final Memory: 196M/1665M
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 39161: LENS-292 : Query result retention policy

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39161/#review102732
---



lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 958)
<https://reviews.apache.org/r/39161/#comment160474>

Can you name config to reflect the time unit as well ?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 1134)
<https://reviews.apache.org/r/39161/#comment160477>

Shutdown the executor in stop ?



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 40)
<https://reviews.apache.org/r/39161/#comment160480>

Please add a unit test for the purger.



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 49)
<https://reviews.apache.org/r/39161/#comment160479>

make it final



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(lines 62 - 63)
<https://reviews.apache.org/r/39161/#comment160481>

Can these moved to init?



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 75)
<https://reviews.apache.org/r/39161/#comment160482>

Can we have a different retention for hdfs output path? Once the result is 
formatted and pesristed by server, hdfs outputs can be purged earlier than 
final results.



lens-server/src/main/resources/lensserver-default.xml (line 288)
<https://reviews.apache.org/r/39161/#comment160483>

Can you update apt files as well?


- Amareshwari Sriramadasu


On Oct. 13, 2015, 11:48 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39161/
> ---
> 
> (Updated Oct. 13, 2015, 11:48 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-292
> https://issues.apache.org/jira/browse/LENS-292
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added query result purge policy on both Driver persisted and Lens persisted 
> resultset. Default retention of 1 day. Purging can be turned off with a 
> setting.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f202603 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  73179e1 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
> PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 1e6bd10 
> 
> Diff: https://reviews.apache.org/r/39161/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.785 
> s]
> [INFO] Lens ... SUCCESS [  5.339 
> s]
> [INFO] Lens API ... SUCCESS [ 28.950 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 28.187 
> s]
> [INFO] Lens Cube .. SUCCESS [07:05 
> min]
> [INFO] Lens DB storage  SUCCESS [ 28.169 
> s]
> [INFO] Lens Query Library . SUCCESS [ 22.031 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:13 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 49.452 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.865 
> s]
> [INFO] Lens Server  SUCCESS [10:58 
> min]
> [INFO] Lens client  SUCCESS [ 47.198 
> s]
> [INFO] Lens CLI ... SUCCESS [03:44 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.516 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.779 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:00 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.212 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.624 
> s]
> [INFO] Lens UI  SUCCESS [  3.415 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 32:45 min
> [INFO] Finished at: 2015-10-07T23:19:44+05:30
> [INFO] Final Memory: 218M/2795M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > <https://reviews.apache.org/r/39191/diff/3/?file=1097957#file1097957line451>
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks
> 
> Amareshwari Sriramadasu wrote:
> This config is removed now and the setting and unsetting here can be 
> removed as well.
> 
> Gabor Liptak wrote:
> Removed as in I should delete both set/TODO lines?

Yes. Please go ahead.
The config is already removed from server side, by a different jira.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 15, 2015, 1:25 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 15, 2015, 1:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Review Request 39221: LENS-533 : Update critical metrics on monitoring doc

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39221/
---

Review request for lens.


Bugs: LENS-533
https://issues.apache.org/jira/browse/LENS-533


Repository: lens


Description
---

Added critical metrics section


Diffs
-

  src/site/apt/admin/monitoring.apt 9429394 

Diff: https://reviews.apache.org/r/39221/diff/


Testing
---

Verified by running mvn site:run


Thanks,

Amareshwari Sriramadasu

Review Request 39081: LENS-446 : Remove server params from session and driver configurations

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39081/
---

Review request for lens.


Bugs: LENS-446
https://issues.apache.org/jira/browse/LENS-446


Repository: lens


Description
---

Changes include :
- Removing server configuration properties from session and driver configs
- Updated tests to verify show params and the query configuration - not to 
contain the server properties.


Diffs
-

  lens-server/src/main/java/org/apache/lens/server/LensApplication.java a446ab6 
  lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 4d333c6 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 73179e1 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
d0677cc 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
ea75ffb 
  
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
 8fffbc9 

Diff: https://reviews.apache.org/r/39081/diff/


Testing
---

Tested on local cli.

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.930s]
[INFO] Lens .. SUCCESS [2.949s]
[INFO] Lens API .. SUCCESS [25.002s]
[INFO] Lens API for server and extensions  SUCCESS [22.247s]
[INFO] Lens Cube . SUCCESS [5:13.181s]
[INFO] Lens DB storage ... SUCCESS [20.544s]
[INFO] Lens Query Library  SUCCESS [18.042s]
[INFO] Lens Hive Driver .. SUCCESS [2:50.267s]
[INFO] Lens Driver for JDBC .. SUCCESS [36.073s]
[INFO] Lens Elastic Search Driver  SUCCESS [16.794s]
[INFO] Lens Server ... SUCCESS [8:21.674s]
[INFO] Lens client ... SUCCESS [37.459s]
[INFO] Lens CLI .. SUCCESS [2:34.216s]
[INFO] Lens Examples . SUCCESS [10.152s]
[INFO] Lens Distribution . SUCCESS [9.089s]
[INFO] Lens ML Lib ... SUCCESS [1:22.334s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.921s]
[INFO] Lens Regression ... SUCCESS [11.227s]
[INFO] Lens UI ... SUCCESS [24.311s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:20.336s
[INFO] Finished at: Wed Oct 07 11:07:20 UTC 2015
[INFO] Final Memory: 195M/2046M
[INFO] 


Thanks,

Amareshwari Sriramadasu

Re: Review Request 39081: LENS-446 : Remove server params from session and driver configurations

[Amareshwari Sriramadasu]

> On Oct. 7, 2015, 11:48 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensServerConf.java, line 
> > 52
> > <https://reviews.apache.org/r/39081/diff/1/?file=1092314#file1092314line52>
> >
> > conf was loaded with only lens-site.xml. Not loading 
> > lensserver-default.xml properties. That means we are not skipping server 
> > params from lensserver-default.xml. Do we need to skip server params from 
> > lensserver-default.xml?

lensserver-default.xml would have only server params. and drivers should not 
require any of them.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39081/#review101757
-----------


On Oct. 7, 2015, 11:16 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39081/
> ---
> 
> (Updated Oct. 7, 2015, 11:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-446
> https://issues.apache.org/jira/browse/LENS-446
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include :
> - Removing server configuration properties from session and driver configs
> - Updated tests to verify show params and the query configuration - not to 
> contain the server properties.
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> a446ab6 
>   lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 
> 4d333c6 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  73179e1 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> d0677cc 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> ea75ffb 
>   
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
>  8fffbc9 
> 
> Diff: https://reviews.apache.org/r/39081/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cli.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.930s]
> [INFO] Lens .. SUCCESS [2.949s]
> [INFO] Lens API .. SUCCESS [25.002s]
> [INFO] Lens API for server and extensions  SUCCESS [22.247s]
> [INFO] Lens Cube . SUCCESS [5:13.181s]
> [INFO] Lens DB storage ... SUCCESS [20.544s]
> [INFO] Lens Query Library  SUCCESS [18.042s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.267s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.073s]
> [INFO] Lens Elastic Search Driver  SUCCESS [16.794s]
> [INFO] Lens Server ... SUCCESS [8:21.674s]
> [INFO] Lens client ... SUCCESS [37.459s]
> [INFO] Lens CLI .. SUCCESS [2:34.216s]
> [INFO] Lens Examples . SUCCESS [10.152s]
> [INFO] Lens Distribution . SUCCESS [9.089s]
> [INFO] Lens ML Lib ... SUCCESS [1:22.334s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.921s]
> [INFO] Lens Regression ... SUCCESS [11.227s]
> [INFO] Lens UI ... SUCCESS [24.311s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> ----
> [INFO] Total time: 24:20.336s
> [INFO] Finished at: Wed Oct 07 11:07:20 UTC 2015
> [INFO] Final Memory: 195M/2046M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review102412
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 12, 2015, 8:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> ---
> 
> (Updated Oct. 12, 2015, 8:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
> https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> small bug
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  2cb3736d45d51fd2172e99ca086843fc6ce50079 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
>  3d38eab9a37410468694a8954e45f497f23d1072 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  847d12a7e25e2db68d5f7fba910aa1027882ec27 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/priority/MockQueryPriorityDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  caee12f4a39388c39eac656949e9c16bf4dfdea7 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> e266ef223e463791e26b6a7a59818e7495bc0235 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>  3bb90efc9c2a859d1c339e6b21a4048a2bef 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6218882facf93216211c50d264e2e6e9cf64a122 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.175s]
> [INFO] Lens .. SUCCESS [2.947s]
> [INFO] Lens API .. SUCCESS [23.439s]
> [INFO] Lens API for server and extensions  SUCCESS [20.441s]
> [INFO] Lens Cube . SUCCESS [6:11.745s]
> [INFO] Lens DB storage ... SUCCESS [22.402s]
> [INFO] Lens Query Library  SUCCESS [18.196s]
> [INFO] Lens Hive Driver .. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.347s]
> [INFO] Lens Server ... SUCCESS [8:17.698s]
> [INFO] Lens client ... SUCCESS [34.376s]
> [INFO] Lens CLI .. SUCCESS [2:36.033s]
> [INFO] Lens Examples . SUCCESS [9.886s]
> [INFO] Lens Distribution . SUCCESS [8.592s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [11.178s]
> [INFO] Lens UI ... SUCCESS [22.051s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review102408
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 (line 207)
<https://reviews.apache.org/r/39127/#comment160043>

Can we avoid opening up the constructor?


- Amareshwari Sriramadasu


On Oct. 12, 2015, 8:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> ---
> 
> (Updated Oct. 12, 2015, 8:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
> https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> small bug
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  2cb3736d45d51fd2172e99ca086843fc6ce50079 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
>  3d38eab9a37410468694a8954e45f497f23d1072 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  847d12a7e25e2db68d5f7fba910aa1027882ec27 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/priority/MockQueryPriorityDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  caee12f4a39388c39eac656949e9c16bf4dfdea7 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> e266ef223e463791e26b6a7a59818e7495bc0235 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>  3bb90efc9c2a859d1c339e6b21a4048a2bef 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6218882facf93216211c50d264e2e6e9cf64a122 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.175s]
> [INFO] Lens .. SUCCESS [2.947s]
> [INFO] Lens API .. SUCCESS [23.439s]
> [INFO] Lens API for server and extensions  SUCCESS [20.441s]
> [INFO] Lens Cube . SUCCESS [6:11.745s]
> [INFO] Lens DB storage ... SUCCESS [22.402s]
> [INFO] Lens Query Library  SUCCESS [18.196s]
> [INFO] Lens Hive Driver .. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.347s]
> [INFO] Lens Server ... SUCCESS [8:17.698s]
> [INFO] Lens client ... SUCCESS [34.376s]
> [INFO] Lens CLI .. SUCCESS [2:36.033s]
> [INFO] Lens Examples . SUCCESS [9.886s]
> [INFO] Lens Distribution . SUCCESS [8.592s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [11.178s]
> [INFO] Lens UI ... SUCCESS [22.051s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102403
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 69)
<https://reviews.apache.org/r/39191/#comment160035>

I think it should be @BeforeTest instead of @BeforeClass


- Amareshwari Sriramadasu


On Oct. 12, 2015, 11:27 p.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 12, 2015, 11:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38758/#review101611
---



lens-ui/package.json (line 3)
<https://reviews.apache.org/r/38758/#comment159044>

If the version is hardcoded this way, and not reading through 
${project.version} variable, it will be difficult during releases to increment 
versions as maven release plugin wont update release version numbers that are 
hardcoded.

See if you can apply mvn resource filter and update version through 
variable.


- Amareshwari Sriramadasu


On Oct. 6, 2015, 6:06 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38758/
> ---
> 
> (Updated Oct. 6, 2015, 6:06 a.m.)
> 
> 
> Review request for lens, Ajay Yadava, Amareshwari Sriramadasu, Amruth 
> Sampath, Bala Nathan, Rajat Khandelwal, Raju Bairishetti, and Yash Sharma.
> 
> 
> Bugs: LENS-782
> https://issues.apache.org/jira/browse/LENS-782
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-782 UI for Saved/Parametrized queries + Bug fixes/Enhancements
> 
> 
> Diffs
> -
> 
>   lens-ui/app/actions/AdhocQueryActions.js 8c2d109 
>   lens-ui/app/adapters/AdhocQueryAdapter.js 98f9b49 
>   lens-ui/app/adapters/BaseAdapter.js 81b9ddc 
>   lens-ui/app/app.js 3e389a7 
>   lens-ui/app/components/AdhocQueryComponent.js 66ddf75 
>   lens-ui/app/components/AppComponent.js d7a38f9 
>   lens-ui/app/components/CubeSchemaComponent.js 593c54a 
>   lens-ui/app/components/CubeTreeComponent.js 241c12f 
>   lens-ui/app/components/DatabaseComponent.js 09ee2eb 
>   lens-ui/app/components/HeaderComponent.js 5ec3397 
>   lens-ui/app/components/LoaderComponent.js ba11c64 
>   lens-ui/app/components/LoginComponent.js cf95af9 
>   lens-ui/app/components/LogoutComponent.js 3fc1627 
>   lens-ui/app/components/QueryBoxComponent.js 6d5843c 
>   lens-ui/app/components/QueryDetailResultComponent.js b969a4a 
>   lens-ui/app/components/QueryOperationsComponent.js a17a636 
>   lens-ui/app/components/QueryParamRowComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryParamsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js fabe383 
>   lens-ui/app/components/QueryResultsComponent.js 6e4b8c2 
>   lens-ui/app/components/RequireAuthenticationComponent.js 9a755b0 
>   lens-ui/app/components/RequireAuthenticationComponent.js 9a755b0 
>   lens-ui/app/components/SavedQueriesComponent.js PRE-CREATION 
>   lens-ui/app/components/SavedQueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js dcc8737 
>   lens-ui/app/components/TableSchemaComponent.js 67dc25a 
>   lens-ui/app/components/TableTreeComponent.js 026e443 
>   lens-ui/app/constants/AdhocQueryConstants.js 3c4f93a 
>   lens-ui/app/constants/AppConstants.js 48cd93e 
>   lens-ui/app/dispatcher/AppDispatcher.js 31b267c 
>   lens-ui/app/stores/AdhocQueryStore.js 7420270 
>   lens-ui/app/stores/CubeStore.js 8b20b95 
>   lens-ui/app/stores/DatabaseStore.js 9f4490b 
>   lens-ui/app/stores/SavedQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js 299d9e8 
>   lens-ui/app/stores/UserStore.js 47da021 
>   lens-ui/app/styles/css/global.css 131ab46 
>   lens-ui/app/styles/css/login.css b400cfb 
>   lens-ui/app/styles/css/query-component.css a82165e 
>   lens-ui/app/styles/css/tree.css 402c9a0 
>   lens-ui/app/styles/less/globals.less c0704dc 
>   lens-ui/app/utils/ErrorParser.js PRE-CREATION 
>   lens-ui/index.html 9c20fe9 
>   lens-ui/package.json 920b120 
>   lens-ui/server.js e812018 
>   lens-ui/webpack.config.js ab4021f 
> 
> Diff: https://reviews.apache.org/r/38758/diff/
> 
> 
> Testing
> ---
> 
> just JavaScript.
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 39039: LENS-792: StatusPoller logs are useless

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39039/#review101618
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 6, 2015, 7:29 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39039/
> ---
> 
> (Updated Oct. 6, 2015, 7:29 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-792
> https://issues.apache.org/jira/browse/LENS-792
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Endless loop of the following:
> 
> 
> {noformat}
> 28 Sep 2015 11:27:34 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:27:34 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:28:20 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:28:20 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:29:06 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:29:06 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:29:52 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:29:52 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:30:38 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:30:38 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:31:29 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:31:29 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:32:21 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:32:21 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:33:12 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:33:12 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:34:03 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:34:03 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Updating 
> status for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:34:59 [6a61d6b0-66a9-4b39-8f3a-ba2a722fb737] [StatusPoller] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Polling status 
> for 6a61d6b0-66a9-4b39-8f3a-ba2a722fb737
> 28 Sep 2015 11:34:59 [6a61d6b0-66

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

[Amareshwari Sriramadasu]

> On Oct. 6, 2015, 6:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 3
> > <https://reviews.apache.org/r/38758/diff/2/?file=1084763#file1084763line3>
> >
> > If the version is hardcoded this way, and not reading through 
> > ${project.version} variable, it will be difficult during releases to 
> > increment versions as maven release plugin wont update release version 
> > numbers that are hardcoded.
> > 
> > See if you can apply mvn resource filter and update version through 
> > variable.

Meanwhile can we understand the following?
what does the version number here signify? Why is it required? When should the 
version change for UI?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38758/#review101611
---


On Oct. 6, 2015, 6:06 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38758/
> ---
> 
> (Updated Oct. 6, 2015, 6:06 a.m.)
> 
> 
> Review request for lens, Ajay Yadava, Amareshwari Sriramadasu, Amruth 
> Sampath, Bala Nathan, Rajat Khandelwal, Raju Bairishetti, and Yash Sharma.
> 
> 
> Bugs: LENS-782
> https://issues.apache.org/jira/browse/LENS-782
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-782 UI for Saved/Parametrized queries + Bug fixes/Enhancements
> 
> 
> Diffs
> -
> 
>   lens-ui/app/actions/AdhocQueryActions.js 8c2d109 
>   lens-ui/app/adapters/AdhocQueryAdapter.js 98f9b49 
>   lens-ui/app/adapters/BaseAdapter.js 81b9ddc 
>   lens-ui/app/app.js 3e389a7 
>   lens-ui/app/components/AdhocQueryComponent.js 66ddf75 
>   lens-ui/app/components/AppComponent.js d7a38f9 
>   lens-ui/app/components/CubeSchemaComponent.js 593c54a 
>   lens-ui/app/components/CubeTreeComponent.js 241c12f 
>   lens-ui/app/components/DatabaseComponent.js 09ee2eb 
>   lens-ui/app/components/HeaderComponent.js 5ec3397 
>   lens-ui/app/components/LoaderComponent.js ba11c64 
>   lens-ui/app/components/LoginComponent.js cf95af9 
>   lens-ui/app/components/LogoutComponent.js 3fc1627 
>   lens-ui/app/components/QueryBoxComponent.js 6d5843c 
>   lens-ui/app/components/QueryDetailResultComponent.js b969a4a 
>   lens-ui/app/components/QueryOperationsComponent.js a17a636 
>   lens-ui/app/components/QueryParamRowComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryParamsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js fabe383 
>   lens-ui/app/components/QueryResultsComponent.js 6e4b8c2 
>   lens-ui/app/components/RequireAuthenticationComponent.js 9a755b0 
>   lens-ui/app/components/RequireAuthenticationComponent.js 9a755b0 
>   lens-ui/app/components/SavedQueriesComponent.js PRE-CREATION 
>   lens-ui/app/components/SavedQueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js dcc8737 
>   lens-ui/app/components/TableSchemaComponent.js 67dc25a 
>   lens-ui/app/components/TableTreeComponent.js 026e443 
>   lens-ui/app/constants/AdhocQueryConstants.js 3c4f93a 
>   lens-ui/app/constants/AppConstants.js 48cd93e 
>   lens-ui/app/dispatcher/AppDispatcher.js 31b267c 
>   lens-ui/app/stores/AdhocQueryStore.js 7420270 
>   lens-ui/app/stores/CubeStore.js 8b20b95 
>   lens-ui/app/stores/DatabaseStore.js 9f4490b 
>   lens-ui/app/stores/SavedQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js 299d9e8 
>   lens-ui/app/stores/UserStore.js 47da021 
>   lens-ui/app/styles/css/global.css 131ab46 
>   lens-ui/app/styles/css/login.css b400cfb 
>   lens-ui/app/styles/css/query-component.css a82165e 
>   lens-ui/app/styles/css/tree.css 402c9a0 
>   lens-ui/app/styles/less/globals.less c0704dc 
>   lens-ui/app/utils/ErrorParser.js PRE-CREATION 
>   lens-ui/index.html 9c20fe9 
>   lens-ui/package.json 920b120 
>   lens-ui/server.js e812018 
>   lens-ui/webpack.config.js ab4021f 
> 
> Diff: https://reviews.apache.org/r/38758/diff/
> 
> 
> Testing
> ---
> 
> just JavaScript.
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review102049
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 (line 430)
<https://reviews.apache.org/r/39127/#comment159578>

Can you update unit test to assert on query context's priority?


- Amareshwari Sriramadasu


On Oct. 8, 2015, 1:18 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> ---
> 
> (Updated Oct. 8, 2015, 1:18 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
> https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> small bug
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  0c980a20953efc6c2d7cc17c97b1552c64a8eb5f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.175s]
> [INFO] Lens .. SUCCESS [2.947s]
> [INFO] Lens API .. SUCCESS [23.439s]
> [INFO] Lens API for server and extensions  SUCCESS [20.441s]
> [INFO] Lens Cube . SUCCESS [6:11.745s]
> [INFO] Lens DB storage ... SUCCESS [22.402s]
> [INFO] Lens Query Library  SUCCESS [18.196s]
> [INFO] Lens Hive Driver .. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.347s]
> [INFO] Lens Server ... SUCCESS [8:17.698s]
> [INFO] Lens client ... SUCCESS [34.376s]
> [INFO] Lens CLI .. SUCCESS [2:36.033s]
> [INFO] Lens Examples . SUCCESS [9.886s]
> [INFO] Lens Distribution . SUCCESS [8.592s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [11.178s]
> [INFO] Lens UI ... SUCCESS [22.051s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39131: LENS -750 : Handle SemanticException from HiveDriver instead of throwing 500 Internal Server Error

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39131/#review102050
---



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
(line 517)
<https://reviews.apache.org/r/39131/#comment159579>

Can you do the same changes for explain, estimate, executeAsync?

Shall we have handleHiveSQLException method throws proper LensException?


- Amareshwari Sriramadasu


On Oct. 8, 2015, 1:45 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39131/
> ---
> 
> (Updated Oct. 8, 2015, 1:45 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added a Hive Error code for handling semantic exceptions
> 
> 
> Earlier, if someone queries a native table that does not exist -
> 
> 
> 
> d482699c-f3cd-49d7-a8a5-dd8437ec4ee3
> 
> 1001
> Internal Server Error.
> org.apache.lens.server.api.error.LensException: Error executing 
> query
> .
> .
> .
> 
> ---
> 
> After the fix- 
> 
> 
> 
> 81753012-99e8-4695-ac60-33ee1e9db289
> 
> 4001
> Semantic Error : Error while compiling statement: FAILED: 
> SemanticException [Error 10001]: Line 1:31 Table not found 
> 'test_data44'
> org.apache.lens.server.api.error.LensException: 
> SEMANTIC_ERROR[Error while compiling statement: FAILED: SemanticException 
> [Error 10001]: Line 1:31 Table not found 'test_data44']
> .
> .
> .
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf a582dc2 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/LensHiveErrorCode.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39131/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.394 
> s]
> [INFO] Lens ... SUCCESS [  4.437 
> s]
> [INFO] Lens API ... SUCCESS [ 29.879 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 26.698 
> s]
> [INFO] Lens Cube .. SUCCESS [07:06 
> min]
> [INFO] Lens DB storage  SUCCESS [ 26.526 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.488 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:14 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 54.033 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 21.722 
> s]
> [INFO] Lens Server  SUCCESS [11:19 
> min]
> [INFO] Lens client  SUCCESS [ 46.726 
> s]
> [INFO] Lens CLI ... SUCCESS [03:45 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.543 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.677 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:05 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  2.966 
> s]
> [INFO] Lens Regression  SUCCESS [ 16.229 
> s]
> [INFO] Lens UI  SUCCESS [ 42.657 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:51 min
> [INFO] Finished at: 2015-10-06T23:01:26+05:30
> [INFO] Final Memory: 216M/3028M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review96493
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Aug. 21, 2015, 12:51 p.m., Rajat Khandelwal wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37346/
 ---
 
 (Updated Aug. 21, 2015, 12:51 p.m.)
 
 
 Review request for lens.
 
 
 Bugs: LENS-693
 https://issues.apache.org/jira/browse/LENS-693
 
 
 Repository: lens
 
 
 Description
 ---
 
 Query Result Mail is not working when finished queries is set to zero as the 
 queries are immediately going to the DB.
 
 Did some refactoring in order to use inheritence instead of instanceof.
 
 
 Diffs
 -
 
   lens-api/src/main/java/org/apache/lens/api/LensConf.java 
 3b1ad87ffe16b572437b92d90c793ea1881c2e0d 
   lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 
 6a9f4558afc3a8430b43dcc65d73c813575a334d 
   lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 
 a2e10c6560aaa551a15408b2937c3d495b51af5f 
   lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 
 3ecf0c229494dd82a531bc5a310e3b056a86d451 
   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
 7a5b177538e4a8c946422ff905c6c048d828b6ab 
   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
 31c343a7b72c13ff9eb9b01038574297629e381b 
   
 lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java
  00e1e53444ca76fa5096efc69fc4bdfdd16d116a 
   
 lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
  78b3320977f9b46b2719ba80190fa77e87ecc729 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java
  3b761268645acf150d149e51f69521bf164c61ee 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java
  bbde1705fec7fb946708b17d57eb5ad74fcb7cef 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
  6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
  beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1 
   
 lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
  b28669e9070578e5121eb4b1c59e8e3ac7cb83de 
   
 lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
  b65a5f4ac661f060b51d5ee1c899dfd93aa8be90 
   
 lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11 
   
 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
  c29a1ac4be7c44c13e3d1e964b18c240adb61d5f 
   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
 af42eb06e2c030a7040b970e982cab782b2bb251 
   
 lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
 0945598eed81515702402e9933b2592186209508 
   
 lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
  82ce205c8d54c6665262ee3baf8c521203743eb5 
 
 Diff: https://reviews.apache.org/r/37346/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Rajat Khandelwal
 

Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review96687
---



lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java (line 181)
https://reviews.apache.org/r/37716/#comment152308

Seems queue number is added for queries in RUNNING state instead of queued 
state



lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
 (line 189)
https://reviews.apache.org/r/37716/#comment152309

what is queue number in driver status?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 618)
https://reviews.apache.org/r/37716/#comment152310

why would a launched query have queue number?


- Amareshwari Sriramadasu


On Aug. 27, 2015, 1:34 p.m., Akshay Goyal wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37716/
 ---
 
 (Updated Aug. 27, 2015, 1:34 p.m.)
 
 
 Review request for lens and Amareshwari Sriramadasu.
 
 
 Bugs: LENS-753
 https://issues.apache.org/jira/browse/LENS-753
 
 
 Repository: lens
 
 
 Description
 ---
 
 Queue number for queries in submitted queue
 
 
 Diffs
 -
 
   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
 7a5b177 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
  f78b7c3 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
  6cecf7e 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
  beaa72f 
   
 lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java
  344ff10 
   
 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
  c29a1ac 
   
 lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java
  e3505bb 
   
 lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java
  f9e7701 
   
 lens-server/src/main/java/org/apache/lens/server/query/collect/MutableQueryCollection.java
  e6e777c 
   
 lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java
  cdbd2ad 
   
 lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java
  7b43a38 
   
 lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java
  7a81e83 
   
 lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java
  51fcf00 
 
 Diff: https://reviews.apache.org/r/37716/diff/
 
 
 Testing
 ---
 
 [INFO] 
 
 [INFO] Reactor Summary:
 [INFO] 
 [INFO] Lens Checkstyle Rules . SUCCESS [1.847s]
 [INFO] Lens .. SUCCESS [2.853s]
 [INFO] Lens API .. SUCCESS [24.281s]
 [INFO] Lens API for server and extensions  SUCCESS [21.248s]
 [INFO] Lens Cube . SUCCESS [5:16.136s]
 [INFO] Lens DB storage ... SUCCESS [19.132s]
 [INFO] Lens Query Library  SUCCESS [14.881s]
 [INFO] Lens Hive Driver .. SUCCESS [2:49.676s]
 [INFO] Lens Driver for JDBC .. SUCCESS [38.935s]
 [INFO] Lens Elastic Search Driver  SUCCESS [16.642s]
 [INFO] Lens Server ... SUCCESS [5:35.820s]
 [INFO] Lens client ... SUCCESS [36.048s]
 [INFO] Lens CLI .. SUCCESS [2:35.600s]
 [INFO] Lens Examples . SUCCESS [8.941s]
 [INFO] Lens Distribution . SUCCESS [8.296s]
 [INFO] Lens ML Lib ... SUCCESS [1:21.192s]
 [INFO] Lens ML Ext Distribution .. SUCCESS [2.212s]
 [INFO] Lens Regression ... SUCCESS [11.972s]
 [INFO] 
 
 [INFO] BUILD SUCCESS
 [INFO] 
 
 [INFO] Total time: 21:06.610s
 [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
 [INFO] Final Memory: 193M/1887M
 [INFO] 
 
 
 
 Thanks,
 
 Akshay Goyal
 

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review97258
---



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 487)
<https://reviews.apache.org/r/37346/#comment153095>

One in-memory result that is not fetched should not block other queries to 
be purged. Can you check if that can happen?


- Amareshwari Sriramadasu


On Aug. 27, 2015, 12:47 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> ---
> 
> (Updated Aug. 27, 2015, 12:47 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Query Result Mail is not working when finished queries is set to zero as the 
> queries are immediately going to the DB.
> 
> Did some refactoring in order to use inheritence instead of instanceof.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/LensConf.java 
> 3b1ad87ffe16b572437b92d90c793ea1881c2e0d 
>   lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 
> 6a9f4558afc3a8430b43dcc65d73c813575a334d 
>   lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 
> a2e10c6560aaa551a15408b2937c3d495b51af5f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 
> 3ecf0c229494dd82a531bc5a310e3b056a86d451 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
> 9614caa3ef3d111b5d1728f6df854623b9effbfb 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 7a5b177538e4a8c946422ff905c6c048d828b6ab 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 31c343a7b72c13ff9eb9b01038574297629e381b 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java
>  00e1e53444ca76fa5096efc69fc4bdfdd16d116a 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  78b3320977f9b46b2719ba80190fa77e87ecc729 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java
>  3b761268645acf150d149e51f69521bf164c61ee 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java
>  929a3026da9d9789b64ab1f04fdd063db3443432 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java
>  bbde1705fec7fb946708b17d57eb5ad74fcb7cef 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
>  6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
>  b28669e9070578e5121eb4b1c59e8e3ac7cb83de 
>   
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
>  b65a5f4ac661f060b51d5ee1c899dfd93aa8be90 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  c29a1ac4be7c44c13e3d1e964b18c240adb61d5f 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> af42eb06e2c030a7040b970e982cab782b2bb251 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> 0945598eed81515702402e9933b2592186209508 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>  82ce205c8d54c6665262ee3baf8c521203743eb5 
> 
> Diff: https://reviews.apache.org/r/37346/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.439s]
> [INFO] Lens .. SUCCESS [3.146s]
> [INFO] Lens API .. SUCCESS [21.540s]
> [INFO] Lens API for server and extensions  SUCCESS [19.002s]
> [INFO] Lens Cube . SUCCESS [5:06.032s]
> [INFO] Lens DB storage ... SUCCESS [19.632s]
> [INFO] Lens Query 

Re: Review Request 37530: LENS-629 - A new improved web client

[Amareshwari Sriramadasu]

> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 12
> > <https://reviews.apache.org/r/37530/diff/2/?file=1041996#file1041996line12>
> >
> > How are these dependencies downloaded?
> > 
> > Can you also update license of each of the dependency here for us to 
> > check with apache compatibility.
> 
> Ankeet Maini wrote:
> These dependencies are downloaded by npm (Node Package Manager). These 
> are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, 
> BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, 
> Unknown, WTFPL)*
> 
> Rajat Khandelwal wrote:
> Which one is unknown?
> 
> Also, I think earlier versions of lgpl are not compatible with apache. 
> Can you check wrt the actual version?

You can check http://www.apache.org/legal/resolved.html for compatability with 
apache license. With respect to the same, out of the licenses mentioned above  
Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, MIT, MIT/X11, ISC 
(licence is similar to BSD), 

The following can be included (Category-B), some of these might require a 
mention in NOTICE (if they are getting bundled) : CC-BY (See 
http://www.apache.org/legal/resolved.html#cc-sa), MPL, 

All versions of GPL and LGPL can not be included - see 
http://www.apache.org/legal/resolved.html#category-x.
After going through attached licenses.txt, I see that the only dependency with 
GPL and LGPL license is : tough-cookie@2.0.0 [license(s): BSD-3-Clause, GPL, 
LGPL, MPL]. The package is with more than one license and BSD-3-Clause and MPL 
are accepted licenses. Verified the same at 
https://www.npmjs.com/package/tough-cookie and 
https://github.com/SalesforceEng/tough-cookie/blob/master/LICENSE. 

Not seeing any issue with dependency licenses. 
Ankeet Maini, Can you please attach the licenses.txt at 
https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens. You 
can put a new section licensing with UI module and mention the same.

If we are planning to provide a convienient binary distribution for UI, we need 
to add appropriate LICENSE and NOTICE files with respect to above licenses 
listed.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
---


On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------
> 
> (Updated Aug. 24, 2015, 6:45 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore d0fa424 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   le

Re: Review Request 37530: LENS-629 - A new improved web client

[Amareshwari Sriramadasu]

> On Aug. 19, 2015, 5:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/app/adapters/AdhocQueryAdapter.js, line 9
> > <https://reviews.apache.org/r/37530/diff/2/?file=1041958#file1041958line9>
> >
> > Not accepting adhoc queries on dimensions?
> > 
> > do we need metastore/dimensions as well ?
> 
> Ankeet Maini wrote:
> When I fetch cubes, its measures and dimensions come as well, and are 
> discoverable and people can query them. Not sure if I understand your 
> question completely!
> 
> Amareshwari Sriramadasu wrote:
> Parallel to Cubes (which have measures and dim-attributes), we have 
> Dimensions which have dimension tables. I'm talking about querying them 
> directly.
> 
> Ankeet Maini wrote:
> As per the current implementation and AFAIK we can query the dimensions 
> via native table, because for every dimension created a native table would've 
> been created.
> 
> Amareshwari Sriramadasu wrote:
> We can query dimensions similar to cubes with cube select. See example 
> queries 
> https://github.com/apache/incubator-lens/blob/master/lens-examples/src/main/resources/dimension-queries.sql.
>  It would good to explore and query dimensions as well through ui.
> 
> Rajat Khandelwal wrote:
> Yes, on the left side you're showing cubes which on click show the 
> queryable fields. Dimensions(not dim tables or native tables) also have 
> queryable fields. 
> 
> Secondly, native tables basically take away the abstractions provided to 
> the user. They are only for debugging purposes, we're not supposed to build 
> any feature depending on the "functionality" of native tables. Native tables 
> are not a "functionality", they are a back-door pass.

Native tables are for debugging purpose only if logical tables are created on 
top them. Without any cubes/dimensions created, users can query native tables 
and make use of features provided by lens wrt query life cycle. 
For the same reason, querying native tables should not be discouraged. To 
distinguish between existing native tables and physical tables of logical 
abstraction, native tables api can take a flag to specify whether it should 
include physical tables or not.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95819
---


On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Aug. 24, 2015, 6:45 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore d0fa424 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>  

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37648/#review97901
---


I dont see the failing test commented. Can you please take care of that?

- Amareshwari Sriramadasu


On Sept. 4, 2015, 2:27 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37648/
> ---
> 
> (Updated Sept. 4, 2015, 2:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> When two drivers give two different errors, it results in Internal server 
> error with LensMultiCauseException.It should compare both errors and give 
> more approriate one to end user. The error codes are organized in sequential 
> order. Error code with higher value is being thrown.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java 164195b 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 7a5b177 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java afc76e5 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 397bd82 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRangeException.java
>  dd3bb72 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
>  65b96d7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 1fe74e2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 9c0f936 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> 98e38d5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  4bd7cc8 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  69fbcc5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> dfe0c32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 16429f0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 486c6b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  3ef9652 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> 826a59d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
> d8515d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 5444e71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> fb1c89e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 9120a70 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> b34c217 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  ca07a0d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 6150b14 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
>  3c3aa9c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 
> e5540d2 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
>  2083ef9 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/ESClientException.java
>  c2254f1 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/InvalidQueryException.java
>  8127cba 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensErrorInfo.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
>  c3ec099 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java
>  603d7cb 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensMultiCauseException.java
>  af9e33a 
>   
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java
>  917eba3 
>   
> lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java
>  366b306 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  c29a1ac 
>   
> lens-server/src/m

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

[Amareshwari Sriramadasu]

> On Sept. 7, 2015, 8:27 a.m., Amareshwari Sriramadasu wrote:
> > I dont see the failing test commented. Can you please take care of that?

Failing test is not related to the patch, so suggesting to comment 
testExplainFailure and should be fixed as part of LENS-769


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37648/#review97901
---


On Sept. 4, 2015, 2:27 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37648/
> ---
> 
> (Updated Sept. 4, 2015, 2:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> When two drivers give two different errors, it results in Internal server 
> error with LensMultiCauseException.It should compare both errors and give 
> more approriate one to end user. The error codes are organized in sequential 
> order. Error code with higher value is being thrown.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java 164195b 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 7a5b177 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java afc76e5 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 397bd82 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRangeException.java
>  dd3bb72 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
>  65b96d7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 1fe74e2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 9c0f936 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> 98e38d5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  4bd7cc8 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  69fbcc5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> dfe0c32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 16429f0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 486c6b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  3ef9652 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> 826a59d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
> d8515d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 5444e71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> fb1c89e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 9120a70 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> b34c217 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  ca07a0d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 6150b14 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
>  3c3aa9c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 
> e5540d2 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
>  2083ef9 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/ESClientException.java
>  c2254f1 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/InvalidQueryException.java
>  8127cba 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensErrorInfo.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
>  c3ec099 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java
>  603d7cb 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensMultiCauseException.java
>  af9e33a 
>   
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java
>  917eba3 
>   
> lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpExc

Re: Review Request 37934: LENS-742 Saved query and parameterization

[Amareshwari Sriramadasu]

savedqueries



lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java
 (line 147)
<https://reviews.apache.org/r/37934/#comment153996>

let us make this path to be savedqueries/{id}



lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java
 (line 173)
<https://reviews.apache.org/r/37934/#comment153997>

let us make this path to be savedqueries/{id}. POST on id will be executing 
the query.



lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java
 (line 46)
<https://reviews.apache.org/r/37934/#comment154000>

Please move this to LensConfConstants and add it in lensserver-default.xml.



lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
 (line 105)
<https://reviews.apache.org/r/37934/#comment154002>

Please go ahead and remove @localhost, if it needs to be removed.



lens-server/src/test/resources/lens-site.xml (lines 141 - 152)
<https://reviews.apache.org/r/37934/#comment154003>

Need to be removed?


- Amareshwari Sriramadasu


On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 4, 2015, 5:25 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/

Re: Review Request 37934: LENS-742 Saved query and parameterization

[Amareshwari Sriramadasu]

> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java,
> >  line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it 
> > should be lens-api package.
> 
> Amruth Sampath wrote:
> The ParameterDataType and ParameterCollectionType throws some exceptions 
> which are extending from LensException (so that error code mapping is done 
> automatically). 
> 
> Moving this to lens-api would mean LensException is not vissible anymore. 
> Should I rather create wrapper around these exceptions @ lens-server-api?

Exceptions cannot be thrown from REST api request/response elements. If you 
want to pass payload to clients, have a look at 
FieldsCannotBeQueriedTogetherException to see how payload can be passed. If no 
sending payload is required, leaving the exceptions in server-api and server 
side classes throwing exception is good enough - clients would get appropriate 
error with error code mapped correctly.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
---


On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 4, 2015, 5:25 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/

Re: Review Request 37934: LENS-742 Saved query and parameterization

[Amareshwari Sriramadasu]

> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java,
> >  line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it 
> > should be lens-api package.
> 
> Amruth Sampath wrote:
> The ParameterDataType and ParameterCollectionType throws some exceptions 
> which are extending from LensException (so that error code mapping is done 
> automatically). 
> 
> Moving this to lens-api would mean LensException is not vissible anymore. 
> Should I rather create wrapper around these exceptions @ lens-server-api?
> 
> Amareshwari Sriramadasu wrote:
> Exceptions cannot be thrown from REST api request/response elements. If 
> you want to pass payload to clients, have a look at 
> FieldsCannotBeQueriedTogetherException to see how payload can be passed. If 
> no sending payload is required, leaving the exceptions in server-api and 
> server side classes throwing exception is good enough - clients would get 
> appropriate error with error code mapped correctly.
> 
> Amruth Sampath wrote:
> Sure. My problem is the classes like ParameterDataType and 
> ParameterCollectionType was itself throwing exceptions that were extending 
> LensException. Would it be better if I not extend from LensException for 
> these and wrap it up in lens-server?

Sure. Go ahead and put up the changes, will review them again.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
---


On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------
> 
> (Updated Sept. 4, 2015, 5:25 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37648/#review97930
---

Ship it!



lens-client/src/main/java/org/apache/lens/client/LensStatement.java (lines 148 
- 154)
<https://reviews.apache.org/r/37648/#comment154039>

Remove commented code?


- Amareshwari Sriramadasu


On Sept. 7, 2015, 4:32 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37648/
> ---
> 
> (Updated Sept. 7, 2015, 4:32 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> When two drivers give two different errors, it results in Internal server 
> error with LensMultiCauseException.It should compare both errors and give 
> more approriate one to end user. The error codes are organized in sequential 
> order. Error code with higher value is being thrown.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java 164195b 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 7a5b177 
>   lens-cli/src/test/java/org/apache/lens/cli/ExecuteQueryCommandIT.java 
> b3fcccb 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 7a437a1 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java afc76e5 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 397bd82 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRangeException.java
>  dd3bb72 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
>  65b96d7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 1fe74e2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 9c0f936 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> 98e38d5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  4bd7cc8 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  69fbcc5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> dfe0c32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 16429f0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 486c6b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  3ef9652 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> 826a59d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
> d8515d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 5444e71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> fb1c89e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 9120a70 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> b34c217 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  ca07a0d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 6150b14 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
>  3c3aa9c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 
> e5540d2 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
>  2083ef9 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/ESClientException.java
>  c2254f1 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/InvalidQueryException.java
>  8127cba 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensErrorInfo.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
>  c3ec099 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java
>  603d7cb 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensMultiCauseException.java
>  af9e33a 
>   
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java
>  91

Re: Review Request 37434: LENS-710 : Allow column name mapping for few/all columns in underlying storage tables

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37434/
---

(Updated Sept. 8, 2015, 1:53 p.m.)


Review request for lens.


Bugs: LENS-710
https://issues.apache.org/jira/browse/LENS-710


Repository: lens


Description
---

Changes include :
- Adds column mapping property 
- JDBCDriver replaces columns in the query according to the map.
- added tests for the same.


Diffs (updated)
-

  lens-api/src/main/resources/cube-0.1.xsd 0a981dd 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 9ceb9f3 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 3415a1e 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
720825a 

Diff: https://reviews.apache.org/r/37434/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.886s]
[INFO] Lens .. SUCCESS [3.232s]
[INFO] Lens API .. SUCCESS [25.549s]
[INFO] Lens API for server and extensions  SUCCESS [22.334s]
[INFO] Lens Cube . SUCCESS [5:15.508s]
[INFO] Lens DB storage ... SUCCESS [19.137s]
[INFO] Lens Query Library  SUCCESS [15.456s]
[INFO] Lens Hive Driver .. SUCCESS [2:52.008s]
[INFO] Lens Driver for JDBC .. SUCCESS [36.722s]
[INFO] Lens Elastic Search Driver  SUCCESS [15.131s]
[INFO] Lens Server ... SUCCESS [5:39.518s]
[INFO] Lens client ... SUCCESS [34.684s]
[INFO] Lens CLI .. SUCCESS [2:36.422s]
[INFO] Lens Examples . SUCCESS [8.852s]
[INFO] Lens Distribution . SUCCESS [8.160s]
[INFO] Lens ML Lib ... SUCCESS [1:19.079s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.086s]
[INFO] Lens Regression ... SUCCESS [10.369s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 21:07.038s
[INFO] Finished at: Thu Aug 13 10:37:33 UTC 2015
[INFO] Final Memory: 193M/1835M
[INFO] 


Thanks,

Amareshwari Sriramadasu

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37648/#review97738
---



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 224)
<https://reviews.apache.org/r/37648/#comment153749>

I think this still needs to be try clause, as it was earlier to finally 
close the stream.



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 483)
<https://reviews.apache.org/r/37648/#comment153750>

Error message construction is not changed to read from LensAPIException 
here.


- Amareshwari Sriramadasu


On Sept. 3, 2015, 6:26 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37648/
> ---
> 
> (Updated Sept. 3, 2015, 6:26 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> When two drivers give two different errors, it results in Internal server 
> error with LensMultiCauseException.It should compare both errors and give 
> more approriate one to end user. The error codes are organized in sequential 
> order. Error code with higher value is being thrown.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java 164195b 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 7a5b177 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java afc76e5 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 397bd82 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRangeException.java
>  dd3bb72 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
>  65b96d7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 1fe74e2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 9c0f936 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> 98e38d5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  4bd7cc8 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  69fbcc5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> dfe0c32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 16429f0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 486c6b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  3ef9652 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> 826a59d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
> d8515d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 5444e71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> fb1c89e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 9120a70 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> b34c217 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  ca07a0d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 6150b14 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
>  3c3aa9c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 
> e5540d2 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
>  2083ef9 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/ESClientException.java
>  c2254f1 
>   
> lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/InvalidQueryException.java
>  8127cba 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensErrorInfo.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
>  c3ec099 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java
>  603d7cb 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensMultiCauseException.java
>  af9

Re: Review Request 37934: LENS-742 Saved query and parameterization

[Amareshwari Sriramadasu]

On Sept. 9, 2015, 10:46 a.m., Amruth Sampath wrote:
> > Overall changes look fine.
> > Can you add one section in user doc explaining the feature ?
> 
> Amruth Sampath wrote:
> Sure. Where is the user doc?

src/site/api/user/index.apt


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
---


On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 8, 2015, 6:11 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  720825a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 5d77eb7 
>   lens-server/src/main/resources/lensserver-default.xml 5d33eda 
>   
> lens-server/src/test/java/org/apache/lens/s

Re: Review Request 37934: LENS-742 Saved query and parameterization

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
 (line 26)
<https://reviews.apache.org/r/37934/#comment154454>

Why is this extending Throwable? and not extedning LensException for giving 
the error out?



lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
 (line 89)
<https://reviews.apache.org/r/37934/#comment154455>

Please add javadoc for all methods and explaining params.



lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
 (line 92)
<https://reviews.apache.org/r/37934/#comment154456>

Have the variable names same as param names, sothat auto generated docs 
match.

Please verify autugenerated docs for the new resource by running

'mvn enunciate:docs' - all docs are fine.



lens-server/src/main/resources/lensserver-default.xml (line 769)
<https://reviews.apache.org/r/37934/#comment154457>

Update config.apt by running tests in lens-api



lens-server/src/test/resources/lens-site.xml (line 143)
<https://reviews.apache.org/r/37934/#comment154458>

Update description to HSQL


Overall changes look fine.
Can you add one section in user doc explaining the feature ?

- Amareshwari Sriramadasu


On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 8, 2015, 6:11 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  720825a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server

Re: Review Request 38402: LENS-752 : Support flattening of columns selected through bridge-tables(many-to-many relationships)

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38402/#review99170
---



lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java (line 582)
<https://reviews.apache.org/r/38402/#comment156075>

We should make this function configurable and can pass different function 
names from drivers.


- Amareshwari Sriramadasu


On Sept. 15, 2015, 12:48 p.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38402/
> ---
> 
> (Updated Sept. 15, 2015, 12:48 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include :
> - Ability to specify if the destination link in a join chain has 
> many-many-relationship
> - Ability to configure at query to say flatten the fields coming from 
> bridge-table relations
> - Enhance cube query rewriter (mainly the join clause) to add join for bridge 
> table to flatten them
> 
> Pending :
> - Add a test with multi fact query
> - Update documentation with feature addition
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 58f68f5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 
> e394e20 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> bf27b99 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java 
> 1a37e80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TableReference.java 
> 31fd97b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> aab2488 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> c7f1e2a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 7f56292 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> cb63fad 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> ed472f6 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  f9be6e6 
> 
> Diff: https://reviews.apache.org/r/38402/diff/
> 
> 
> Testing
> ---
> 
> Added testcases for bridge tables and queries on them.
> 
> All tests in lens-cube module pass. Will update full test results once done.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 38402: LENS-752 : Support flattening of columns selected through bridge-tables(many-to-many relationships)

[Amareshwari Sriramadasu]

> On Sept. 15, 2015, 2 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line 
> > 579
> > <https://reviews.apache.org/r/38402/diff/1/?file=1073797#file1073797line579>
> >
> > blankness of `bridgeFromClause`

from clause would never be empty. This is for appending userfilter if it is not 
null


> On Sept. 15, 2015, 2 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, lines 
> > 586-587
> > <https://reviews.apache.org/r/38402/diff/1/?file=1073797#file1073797line586>
> >
> > only null check needed.

why? we should check if the column are queried from that table as well.


> On Sept. 15, 2015, 2 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line 
> > 585
> > <https://reviews.apache.org/r/38402/diff/1/?file=1073797#file1073797line585>
> >
> > Among the approaches: 
> > 
> > 1. Relying on a flag to append "select" or "join"
> > 2. Making a list and later doing "select" + StringUtils.join("join", 
> > list)
> > 
> > the second seems more intuitive. And would be easier to debug later on.

Did not understand the comment fully.

It is not simply prepending select or join to alist. If join needs to be 
converted to select from a bridge table - it becomes a full fledged query with 
select, from, groupby, filters and optionally more joins.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38402/#review99024
---


On Sept. 15, 2015, 12:48 p.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38402/
> ---
> 
> (Updated Sept. 15, 2015, 12:48 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include :
> - Ability to specify if the destination link in a join chain has 
> many-many-relationship
> - Ability to configure at query to say flatten the fields coming from 
> bridge-table relations
> - Enhance cube query rewriter (mainly the join clause) to add join for bridge 
> table to flatten them
> 
> Pending :
> - Add a test with multi fact query
> - Update documentation with feature addition
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 58f68f5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 
> e394e20 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> bf27b99 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java 
> 1a37e80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TableReference.java 
> 31fd97b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> aab2488 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> c7f1e2a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 7f56292 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> cb63fad 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> ed472f6 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  f9be6e6 
> 
> Diff: https://reviews.apache.org/r/38402/diff/
> 
> 
> Testing
> ---
> 
> Added testcases for bridge tables and queries on them.
> 
> All tests in lens-cube module pass. Will update full test results once done.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 37934: LENS-742 Saved query and parameterization

[Amareshwari Sriramadasu]

> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/lens-errors.conf, lines 105-108
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105>
> >
> > Why do we need to remove it?
> 
> Amruth Sampath wrote:
> There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited 
> to this.
> 
> Rajat Khandelwal wrote:
> syntax error was supposed to be for syntax errors in queries. But now 
> invalid queries are not accepted so I guess removing should be fine.
> 
> Amareshwari Sriramadasu wrote:
> Reopening this comment. SYNTAX_ERROR still comes from queries with 
> invalid syntax and the mapping should not be removed.

The one removed here is removal of existing error from cube error codes, itself.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
---


On Sept. 11, 2015, 8:01 a.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 11, 2015, 8:01 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 5428041 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  fb11f93 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   lens-server/enunciate.xml 94b5199 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 

Re: Review Request 38212: LENS-392: Look ahead not working when not all process time partitions on lower granularity are present

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/#review99009
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Sept. 14, 2015, 1:05 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38212/
> ---
> 
> (Updated Sept. 14, 2015, 1:05 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-392
> https://issues.apache.org/jira/browse/LENS-392
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> e.g. for a monthly query with look ahead = 1, if next month partition is not 
> present, it looks for process time partitions for all days of the next month. 
> And all of them might not be present. So we should proceed with whichever 
> ones are present.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 
> fc2d85b89e9809a61c982ca78a7d18ffacee76f6 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 
> d52f1686254ab0b9c977af84731888778edacb8a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> f5f8d4c8ec4177b2d83f5f567386a0422958c69d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java
>  1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
>  2caea569a6af1f717bef49491b024441808b5448 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 7f5629200f82f92e00fccd423097666383b06e18 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> 7e5184c472b230cbee0c633191283a0368a82949 
> 
> Diff: https://reviews.apache.org/r/38212/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.285s]
> [INFO] Lens .. SUCCESS [2.853s]
> [INFO] Lens API .. SUCCESS [21.064s]
> [INFO] Lens API for server and extensions  SUCCESS [20.780s]
> [INFO] Lens Cube . SUCCESS [5:27.193s]
> [INFO] Lens DB storage ... SUCCESS [18.947s]
> [INFO] Lens Query Library  SUCCESS [16.214s]
> [INFO] Lens Hive Driver .. SUCCESS [2:54.010s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.208s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.168s]
> [INFO] Lens Server ... SUCCESS [5:37.934s]
> [INFO] Lens client ... SUCCESS [38.626s]
> [INFO] Lens CLI .. SUCCESS [2:39.371s]
> [INFO] Lens Examples . SUCCESS [8.829s]
> [INFO] Lens Distribution . SUCCESS [9.163s]
> [INFO] Lens ML Lib ... SUCCESS [1:21.146s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.040s]
> [INFO] Lens Regression ... SUCCESS [10.560s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:25.417s
> [INFO] Finished at: Mon Sep 14 12:59:16 UTC 2015
> [INFO] Final Memory: 194M/2078M
> [INFO] 
> 
> 
> Added a test case
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98819
---



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 618)
<https://reviews.apache.org/r/37716/#comment155424>

Set queue number as null for launched queries?


- Amareshwari Sriramadasu


On Sept. 14, 2015, 7:42 a.m., Akshay Goyal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> ---
> 
> (Updated Sept. 14, 2015, 7:42 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
> https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 44c0c62 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
>  f78b7c3 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
>  6cecf7e 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  beaa72f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java
>  344ff10 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  23cc748 
>   
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java
>  e3505bb 
>   
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java
>  f9e7701 
>   
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java
>  cdbd2ad 
>   
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java
>  7b43a38 
>   
> lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java
>  7a81e83 
>   
> lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java
>  51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.847s]
> [INFO] Lens .. SUCCESS [2.853s]
> [INFO] Lens API .. SUCCESS [24.281s]
> [INFO] Lens API for server and extensions  SUCCESS [21.248s]
> [INFO] Lens Cube . SUCCESS [5:16.136s]
> [INFO] Lens DB storage ... SUCCESS [19.132s]
> [INFO] Lens Query Library  SUCCESS [14.881s]
> [INFO] Lens Hive Driver .. SUCCESS [2:49.676s]
> [INFO] Lens Driver for JDBC .. SUCCESS [38.935s]
> [INFO] Lens Elastic Search Driver  SUCCESS [16.642s]
> [INFO] Lens Server ... SUCCESS [5:35.820s]
> [INFO] Lens client ... SUCCESS [36.048s]
> [INFO] Lens CLI .. SUCCESS [2:35.600s]
> [INFO] Lens Examples . SUCCESS [8.941s]
> [INFO] Lens Distribution . SUCCESS [8.296s]
> [INFO] Lens ML Lib ... SUCCESS [1:21.192s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.212s]
> [INFO] Lens Regression ... SUCCESS [11.972s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:06.610s
> [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
> [INFO] Final Memory: 193M/1887M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>

Re: Review Request 38920: LENS-797: Improve CLI documentation to mention the helpful role of pressing tab while writing commands

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38920/#review101448
---



lens-cli/src/test/resources/cli-intro.apt (line 74)
<https://reviews.apache.org/r/38920/#comment158832>

May be we should add, "for example" in the beginning of this illustration 
here.



lens-cli/src/test/resources/cli-intro.apt (line 84)
<https://reviews.apache.org/r/38920/#comment158833>

This is not a bug. For optional all parametters, mentioining of -- will be 
required.


- Amareshwari Sriramadasu


On Oct. 1, 2015, 9:11 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38920/
> ---
> 
> (Updated Oct. 1, 2015, 9:11 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-797
> https://issues.apache.org/jira/browse/LENS-797
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://lens.apache.org/user/cli.html doesn't mention that pressing  can 
> be interactive. I've seen users looking up commands every time and even 
> saving commands in text files for quicker access. We should mention that 
> commands need not be remembered and CLI can help you find the command and its 
> arguments any time.
> 
> 
> Diffs
> -
> 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
>  279521113204d614c0807d9ba679ebe36221883d 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
> 0afdd61a955d6a0a18c68f678145904722dd0c90 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
> 1de24a49bf2242170f229235379bc2cffaae060c 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
>  cd7de556febd4fc2ae684390793298e2f713ff9b 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
>  74efed9159906478d91e75623186a81a7532acb0 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
> 6d7d9ebd9937c85c603f9a1bf2822af6763a1ede 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensLogResourceCommands.java
>  c43a5ffa556c2a8566013fd1258462c9f602c235 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java
>  df425810365fc1c328392809c6ff7a72c2c7a8b2 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> b6e3fcf1d9348b39e8bcc694cd769d4a5faf9971 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 
> ca73af76672fb7708bc12ddc503c0877701dbd90 
>   lens-cli/src/test/resources/cli-intro.apt 
> b5773abe880b7b523f614c6b4da50848e19155f3 
>   src/site/apt/user/cli.apt be93b8cfe982fcf60b13dbd3abaa15879537c3fd 
> 
> Diff: https://reviews.apache.org/r/38920/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 38857: LENS-796 : Slow response times for /metastore/nativetables API

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38857/#review101452
---

Ship it!


Looks fine to me.


lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (line 1224)
<https://reviews.apache.org/r/38857/#comment158841>

We might have to again split this up when we take up LENS-750. But I'm fine 
taking a decision as part of LENS-750


- Amareshwari Sriramadasu


On Oct. 1, 2015, 6:52 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38857/
> ---
> 
> (Updated Oct. 1, 2015, 6:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently, To obtain list of native tables, CubeMetastoreService does the 
> following -
> 1. Fetches the list of tables ( one MetastoreClient call)
> 2. Filters out the cube tables from the list. The filtering happens by 
> looking at the table properties from the Table object. This table object is 
> obtained with another Metastore call. So, If there are 'n' tables, there will 
> be 'n' metastore calls.
> 
> Instead of this, we can directly fetch the list of table objects for our list 
> of table names in a single API call using 
> getMetaStoreClient().getTableObjectsByName() method.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  37cebfe 
> 
> Diff: https://reviews.apache.org/r/38857/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.745 
> s]
> [INFO] Lens ... SUCCESS [  4.601 
> s]
> [INFO] Lens API ... SUCCESS [ 31.397 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 28.560 
> s]
> [INFO] Lens Cube .. SUCCESS [07:04 
> min]
> [INFO] Lens DB storage  SUCCESS [ 27.465 
> s]
> [INFO] Lens Query Library . SUCCESS [ 23.361 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:14 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 50.792 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 20.551 
> s]
> [INFO] Lens Server  SUCCESS [11:11 
> min]
> [INFO] Lens client  SUCCESS [ 48.547 
> s]
> [INFO] Lens CLI ... SUCCESS [03:45 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.595 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 13.176 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:03 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.752 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.811 
> s]
> [INFO] Lens UI  SUCCESS [ 50.811 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:53 min
> [INFO] Finished at: 2015-09-29T22:48:22+05:30
> [INFO] Final Memory: 175M/3158M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 38666: LENS-772 : Fix time and size based rolling for logs

[Amareshwari Sriramadasu]

> On Sept. 23, 2015, 9:28 a.m., Raju Bairishetti wrote:
> > tools/conf-pseudo-distr/server/logback.xml, line 103
> > <https://reviews.apache.org/r/38666/diff/2/?file=1083082#file1083082line103>
> >
> > Wy we are not using timeBasedFileNamingAndTriggeringPolicy here?

Stats logs are rolled one file per hour and uploaded. Simple 
TimeBasedRollingPolicy will do here.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100179
---


On Sept. 23, 2015, 9:02 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> ---
> 
> (Updated Sept. 23, 2015, 9:02 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Updated logback.xml
> 
> 
> Diffs
> -
> 
>   tools/conf-pseudo-distr/client/logback.xml d142348 
>   tools/conf-pseudo-distr/server/logback.xml c27bea2 
>   tools/conf/client/logback.xml d142348 
>   tools/conf/server/logback.xml c27bea2 
> 
> Diff: https://reviews.apache.org/r/38666/diff/
> 
> 
> Testing
> ---
> 
> Verified rolling is fine with the changes.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

[Amareshwari Sriramadasu]

> On Sept. 22, 2015, 10:23 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java,
> >  line 779
> > <https://reviews.apache.org/r/37346/diff/9/?file=1080331#file1080331line779>
> >
> > Let us change the name to lens.server.query.purger.interval

If the name is lens.server.query.purge.interval, it seems it is still linked to 
single query. Instead shall we rename it to 
lens.server.querypurger.sleep.interval ? Please update apt file as well.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review99966
---


On Sept. 22, 2015, 2:46 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> ---
> 
> (Updated Sept. 22, 2015, 2:46 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include:
> 
> 1. The configuration `lens.server.max.finished.queries` has been taken off. 
> Now All queries are purged as soon as they are purgable. The logic of 
> purgability of a query is that:
> 1.  if the query failed, it's purgable
> 2.  if the query doesn't have a result, it's purgable
> 3.  If it has a result, then result class is asked whether it's purgable 
> or not. This is the second layer of the logic. Current logic in that layer is 
> as follows:
> 1.  If the result is persistent, it's purgable
> 2.  If the result is in memory, it's not purgable initially, but 
> after all the rows have been accessed by someone, it becomes purgable. The 
> rows can be accessed in the following ways:
> 1.  While sending Email notification, in memory result is 
> appended in the email. Hence rows are accessed.
> 2.  Explicit call by a user for reading result set (/resultset 
> REST API, but not the /httpresultset API, http results are not available for 
> in memory results.)
> 
> 
> 2. There is a new configuration `lens.server.purge.interval`. The value is 
> supposed to be in milliseconds. This is the frequency of purger thread. 
> 3. Purger thread had a bug in which it had a queue of finished queries which 
> were inserted according to their finish time. Purging of later queries was 
> dependent on purging of earlier queries. If a later query becomes purgable, 
> it's not purged untill all the queries before it become purgable and are 
> purged. To fix this, purger thread now runs periodically and scans the whole 
> queue, purges whichever ones are purgable. 
> 4. FinishedLensQuery is a model object, but has a field which is not a field 
> in corresponding database. That field is removed from equals check
> 5. `instanceof` Checks have been converted to polymorphism:
> 1. For http result set availability.
> 2. For forming email message of the result of a finished query. 
> 6. Email notifications are now sent irrespective of whether the query has 
> been purged or not. Earlier there was a bug that if a query is purged, email 
> notification for that isn't sent. 
> 7. Taking care of LENS-783
> 8. Modularizing testing of email notifications
> 9. Made more util methods in RestAPITestUtil which became re-usable in server 
> tests like TestQueryService.
> 10. Added Test cases for query purging.
> 11. The way we're taking care of purge happening before event handlers are 
> done with context is by utilizing garbage collection. We pass context to the 
> QueryEnded event object. Now whenever the event happens, it has access to the 
> context. It has access even when purger has purged the query(since the object 
> will only go obsolete if no one has a handle to it). In purging, the context 
> is removed from various query collections, but context object is intact. 
> Whenever all event handlers for the QueryEnded event are done, both the event 
> object and the query context object will be garbage collected.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/LensConf.java 
> 3b1ad87ffe16b572437b92d90c793ea1881c2e0d 
>   lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 
> 6a9f4558afc3a8430b43dcc65d73c813575a334d 
>   lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 
> af439ff58002b06e2631585d35dfe9754ce84d4e 
>   lens-api/src/main/java/org/apache/lens/api/query/Persisten

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review100149
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Sept. 23, 2015, 6:29 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> ---
> 
> (Updated Sept. 23, 2015, 6:29 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include:
> 
> 1. The configuration `lens.server.max.finished.queries` has been taken off. 
> Now All queries are purged as soon as they are purgable. The logic of 
> purgability of a query is that:
> 1.  if the query failed, it's purgable
> 2.  if the query doesn't have a result, it's purgable
> 3.  If it has a result, then result class is asked whether it's purgable 
> or not. This is the second layer of the logic. Current logic in that layer is 
> as follows:
> 1.  If the result is persistent, it's purgable
> 2.  If the result is in memory, it's not purgable initially, but 
> after all the rows have been accessed by someone, it becomes purgable. The 
> rows can be accessed in the following ways:
> 1.  While sending Email notification, in memory result is 
> appended in the email. Hence rows are accessed.
> 2.  Explicit call by a user for reading result set (/resultset 
> REST API, but not the /httpresultset API, http results are not available for 
> in memory results.)
> 
> 
> 2. There is a new configuration `lens.server.purge.interval`. The value is 
> supposed to be in milliseconds. This is the frequency of purger thread. 
> 3. Purger thread had a bug in which it had a queue of finished queries which 
> were inserted according to their finish time. Purging of later queries was 
> dependent on purging of earlier queries. If a later query becomes purgable, 
> it's not purged untill all the queries before it become purgable and are 
> purged. To fix this, purger thread now runs periodically and scans the whole 
> queue, purges whichever ones are purgable. 
> 4. FinishedLensQuery is a model object, but has a field which is not a field 
> in corresponding database. That field is removed from equals check
> 5. `instanceof` Checks have been converted to polymorphism:
> 1. For http result set availability.
> 2. For forming email message of the result of a finished query. 
> 6. Email notifications are now sent irrespective of whether the query has 
> been purged or not. Earlier there was a bug that if a query is purged, email 
> notification for that isn't sent. 
> 7. Taking care of LENS-783
> 8. Modularizing testing of email notifications
> 9. Made more util methods in RestAPITestUtil which became re-usable in server 
> tests like TestQueryService.
> 10. Added Test cases for query purging.
> 11. The way we're taking care of purge happening before event handlers are 
> done with context is by utilizing garbage collection. We pass context to the 
> QueryEnded event object. Now whenever the event happens, it has access to the 
> context. It has access even when purger has purged the query(since the object 
> will only go obsolete if no one has a handle to it). In purging, the context 
> is removed from various query collections, but context object is intact. 
> Whenever all event handlers for the QueryEnded event are done, both the event 
> object and the query context object will be garbage collected.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/LensConf.java 
> 3b1ad87ffe16b572437b92d90c793ea1881c2e0d 
>   lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 
> 6a9f4558afc3a8430b43dcc65d73c813575a334d 
>   lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 
> af439ff58002b06e2631585d35dfe9754ce84d4e 
>   lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 
> a2e10c6560aaa551a15408b2937c3d495b51af5f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 
> 3ecf0c229494dd82a531bc5a310e3b056a86d451 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
> 3c8531feb40276e076622b32f15c2f3d7ee782b2 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver

Re: Review Request 38666: LENS-772 : Fix time and size based rolling for logs

[Amareshwari Sriramadasu]

> On Sept. 23, 2015, 7:16 a.m., Raju Bairishetti wrote:
> > Can you make changes in **conf-pseudo-distr** as well?

Done!


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100161
---


On Sept. 23, 2015, 9:02 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> ---
> 
> (Updated Sept. 23, 2015, 9:02 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Updated logback.xml
> 
> 
> Diffs
> -
> 
>   tools/conf-pseudo-distr/client/logback.xml d142348 
>   tools/conf-pseudo-distr/server/logback.xml c27bea2 
>   tools/conf/client/logback.xml d142348 
>   tools/conf/server/logback.xml c27bea2 
> 
> Diff: https://reviews.apache.org/r/38666/diff/
> 
> 
> Testing
> ---
> 
> Verified rolling is fine with the changes.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 38666: LENS-772 : Fix time and size based rolling for logs

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/
---

(Updated Sept. 23, 2015, 9:02 a.m.)


Review request for lens.


Bugs: LENS-772
https://issues.apache.org/jira/browse/LENS-772


Repository: lens


Description
---

Updated logback.xml


Diffs (updated)
-

  tools/conf-pseudo-distr/client/logback.xml d142348 
  tools/conf-pseudo-distr/server/logback.xml c27bea2 
  tools/conf/client/logback.xml d142348 
  tools/conf/server/logback.xml c27bea2 

Diff: https://reviews.apache.org/r/38666/diff/


Testing
---

Verified rolling is fine with the changes.


Thanks,

Amareshwari Sriramadasu

Re: Review Request 37530: LENS-629 - A new improved web client

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99921
---



pom.xml (line 111)
<https://reviews.apache.org/r/37530/#comment156932>

I think we are already using 1.8, this would be conflicting.


- Amareshwari Sriramadasu


On Sept. 21, 2015, 12:14 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 21, 2015, 12:14 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js PRE-CREATION 
>   lens-ui/app/stores/UserStore.js PRE-CREATION 
>   lens-ui/app/styles/css/global.css PRE-CREATION 
>   lens-ui/app/styles/css/login.css PRE-CREATION 
>   lens-ui/app/styles/css/query-component.css PRE-CREATION 
>   lens-ui/app/styles/css/tree.css PRE-CREATION 
>   lens-ui/app/styles/less/globals.less PRE-CREATION 
>   lens-ui/config.json PRE-CREATION 
>   lens-ui/index.html PRE-CREATION 
>   lens-ui/package.json PRE-CREATION 
>   lens-ui/pom.xml PRE-CREATION 
>   lens-ui/server.js PRE-CREATION 
>   lens-ui/webpack.config.js PRE-CREATION 
>   pom.xml adba544 
> 
> Diff: https://reviews.apache.org/r/37530/diff/
> 
> 
> Testing
> ---
> 
> No server code added/modified. Just JavaScript!
> 
> 
> File Attachments
> 
> 
> License details of NPM packages
>   
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review99966
---



lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 779)
<https://reviews.apache.org/r/37346/#comment157016>

Let us change the name to lens.server.query.purger.interval



lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java
 (line 60)
<https://reviews.apache.org/r/37346/#comment157017>

Let us make this abstract



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 875)
<https://reviews.apache.org/r/37346/#comment157020>

seems variables got exchanged



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 903)
<https://reviews.apache.org/r/37346/#comment157025>

If we are purging immediately, please take care of StatsUpdater also.


- Amareshwari Sriramadasu


On Sept. 22, 2015, 9:25 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> ---
> 
> (Updated Sept. 22, 2015, 9:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include:
> 
> 1. The configuration `lens.server.max.finished.queries` has been taken off. 
> Now All queries are purged as soon as they are purgable. The logic of 
> purgability of a query is that:
> 1.  if the query failed, it's purgable
> 2.  if the query doesn't have a result, it's purgable
> 3.  If it has a result, then result class is asked whether it's purgable 
> or not. This is the second layer of the logic. Current logic in that layer is 
> as follows:
> 1.  If the result is persistent, it's purgable
> 2.  If the result is in memory, it's not purgable initially, but 
> after all the rows have been accessed by someone, it becomes purgable. The 
> rows can be accessed in the following ways:
> 1.  While sending Email notification, in memory result is 
> appended in the email. Hence rows are accessed.
> 2.  Explicit call by a user for reading result set (/resultset 
> REST API, but not the /httpresultset API, http results are not available for 
> in memory results.)
> 
> 
> 2. There is a new configuration `lens.server.purge.interval`. The value is 
> supposed to be in milliseconds. This is the frequency of purger thread. 
> 3. Purger thread had a bug in which it had a queue of finished queries which 
> were inserted according to their finish time. Purging of later queries was 
> dependent on purging of earlier queries. If a later query becomes purgable, 
> it's not purged untill all the queries before it become purgable and are 
> purged. To fix this, purger thread now runs periodically and scans the whole 
> queue, purges whichever ones are purgable. 
> 4. FinishedLensQuery is a model object, but has a field which is not a field 
> in corresponding database. That field is removed from equals check
> 5. `instanceof` Checks have been converted to polymorphism:
> 1. For http result set availability.
> 2. For forming email message of the result of a finished query. 
> 6. Email notifications are now sent irrespective of whether the query has 
> been purged or not. Earlier there was a bug that if a query is purged, email 
> notification for that isn't sent. 
> 7. Taking care of LENS-783
> 8. Modularizing testing of email notifications
> 9. Made more util methods in RestAPITestUtil which became re-usable in server 
> tests like TestQueryService.
> 10. Added Test cases for query purging.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/LensConf.java 
> 3b1ad87ffe16b572437b92d90c793ea1881c2e0d 
>   lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 
> 6a9f4558afc3a8430b43dcc65d73c813575a334d 
>   lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 
> af439ff58002b06e2631585d35dfe9754ce84d4e 
>   lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 
> a2e10c6560aaa551a15408b2937c3d495b51af5f 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 
> 3ecf0c229494dd82a531bc5a310e3b056a86d451 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
> 3c8531feb40276e076622b32f15c2f3d7ee782b2 
>   lens-cli/src/main/java/org/apache/lens/

Re: Review Request 37530: LENS-629 - A new improved web client

[Amareshwari Sriramadasu]

> On Aug. 19, 2015, 5:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/app/adapters/AdhocQueryAdapter.js, line 9
> > <https://reviews.apache.org/r/37530/diff/2/?file=1041958#file1041958line9>
> >
> > Not accepting adhoc queries on dimensions?
> > 
> > do we need metastore/dimensions as well ?
> 
> Ankeet Maini wrote:
> When I fetch cubes, its measures and dimensions come as well, and are 
> discoverable and people can query them. Not sure if I understand your 
> question completely!
> 
> Amareshwari Sriramadasu wrote:
> Parallel to Cubes (which have measures and dim-attributes), we have 
> Dimensions which have dimension tables. I'm talking about querying them 
> directly.
> 
> Ankeet Maini wrote:
> As per the current implementation and AFAIK we can query the dimensions 
> via native table, because for every dimension created a native table would've 
> been created.
> 
> Amareshwari Sriramadasu wrote:
> We can query dimensions similar to cubes with cube select. See example 
> queries 
> https://github.com/apache/incubator-lens/blob/master/lens-examples/src/main/resources/dimension-queries.sql.
>  It would good to explore and query dimensions as well through ui.
> 
> Rajat Khandelwal wrote:
> Yes, on the left side you're showing cubes which on click show the 
> queryable fields. Dimensions(not dim tables or native tables) also have 
> queryable fields. 
> 
> Secondly, native tables basically take away the abstractions provided to 
> the user. They are only for debugging purposes, we're not supposed to build 
> any feature depending on the "functionality" of native tables. Native tables 
> are not a "functionality", they are a back-door pass.
> 
> Amareshwari Sriramadasu wrote:
> Native tables are for debugging purpose only if logical tables are 
> created on top them. Without any cubes/dimensions created, users can query 
> native tables and make use of features provided by lens wrt query life cycle. 
> For the same reason, querying native tables should not be discouraged. To 
> distinguish between existing native tables and physical tables of logical 
> abstraction, native tables api can take a flag to specify whether it should 
> include physical tables or not.
> 
> Ankeet Maini wrote:
> I can definitely take this up in the next cut!

Sure. you can park an improvement issue for the same.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95819
---


On Sept. 18, 2015, 10:28 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 18, 2015, 10:28 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE

Re: Review Request 37530: LENS-629 - A new improved web client

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99666
---



lens-ui/README.markdown (lines 35 - 36)
<https://reviews.apache.org/r/37530/#comment156627>

Does this require changes after mavenizing now ?



lens-ui/pom.xml (line 40)
<https://reviews.apache.org/r/37530/#comment156628>

Please dont define versions here. Move all version definitions to parent pom



lens-ui/pom.xml (line 50)
<https://reviews.apache.org/r/37530/#comment156629>

Move version definition to parent pom



lens-ui/pom.xml (lines 58 - 59)
<https://reviews.apache.org/r/37530/#comment156630>

Can these be defined in parent pom?



pom.xml (lines 550 - 552)
<https://reviews.apache.org/r/37530/#comment156625>

Can these folders be moved to target/ ? Otherwise, how will they get 
cleaned up in next build?


- Amareshwari Sriramadasu


On Sept. 19, 2015, 8:44 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 19, 2015, 8:44 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js PRE-CREATION 
>   lens-ui/app/stores/UserStore.js PRE-CREATION 
>   lens-ui/app/styles/css/global.css PRE-CREATION 
>   lens-ui/app/styles/css/login.css PRE-CREATION 
>   lens-ui/app/styles/css/query-component.css PRE-CREATION 
>   lens-ui/app/styles/css/tree.css PRE-CREATION 
>   lens-ui/app/styles/less/globals.less PRE-CREATION 
>   lens-ui/config.json PRE-CREATION 
>   lens-ui/index.html PRE-CREATION 
>   lens-ui/package.json PRE-CREATION 
>   lens-ui/pom.xml PRE-CREATION 
>   lens-ui/server.js PRE-CREATION 
>   lens-ui/webpack.config.js PRE-CREATION 
>   pom.xml adba544 
> 
> Diff: https://reviews.apache.org/r/37530/diff/
> 
> 
> Testing
> ---
> 
> No server code added/modified. Just JavaScript!
> 
> 
> File Attachments
> 
> 
> License details of NPM packages
>   
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 38521: LENS-607: Fix Test failures in java8

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review99668
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 (line 95)
<https://reviews.apache.org/r/38521/#comment156631>

Isn't ArrayList ordered anymore?


- Amareshwari Sriramadasu


On Sept. 19, 2015, 6:48 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38521/
> ---
> 
> (Updated Sept. 19, 2015, 6:48 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-607
> https://issues.apache.org/jira/browse/LENS-607
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Iterators in java7 and java8 are returning elements in different order. All 
> most all failures are because of this case.
> 
> Changes:
> TestBaseCubeQueries: Changed driver supported storages to single storage 
> instead of multiple
> TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
> from the actaul query part and verified join part and remaining query part 
> separately.
> TestStorageUtil: Multiple sets can answer the given partitions. Changed 
> asserts accordingly.
> TestTimeRangeResolver: Changed asserts to cover all the errors.
> 
> *ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
> (Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to 
> LinkedHashMap) to return the elements in insertion order.
> 
> TestColumnSQLRewriter: Changed the order of columns in queries.
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 39441c9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 0f76c76 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> a58f5fe 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  bde4edd 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  493b8d6 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
> 81f515b 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> cb27d50 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 
> 7be9793 
>   pom.xml adba544 
> 
> Diff: https://reviews.apache.org/r/38521/diff/
> 
> 
> Testing
> ---
> 
> Tested on both java7 and java8. Build is successful. Will post the build 
> artifact summary soon.
> 
> c1mng0pxdty3:lens raju.bairishetti$ java -version
> **java version "1.8.0_40"**
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 
> s]
> [INFO] Lens ... SUCCESS [  5.806 
> s]
> [INFO] Lens API ... SUCCESS [ 31.562 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 23.200 
> s]
> [INFO] Lens Cube .. SUCCESS [06:19 
> min]
> [INFO] Lens DB storage  SUCCESS [ 23.015 
> s]
> [INFO] Lens Query Library . SUCCESS [ 18.249 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [03:11 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 
> s]
> [INFO] Lens Server  SUCCESS [12:38 
> min]
> [INFO] Lens client  SUCCESS [ 44.951 
> s]
> [INFO] Lens CLI ... SUCCESS [04:57 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.491 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 19.483 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:35 
> min]
> [INFO] Lens ML Ext Distribu

Review Request 38524: LENS-113 : Document how to add feature documentation

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38524/
---

Review request for lens and Srikanth Sundarrajan.


Bugs: LENS-113
https://issues.apache.org/jira/browse/LENS-113


Repository: lens


Description
---

Adds section in contributor guide for adding feature documentation. Any 
suggestions on improving the documentation are welcome.


Diffs
-

  src/site/apt/developer/contribute.apt ef3854a 

Diff: https://reviews.apache.org/r/38524/diff/


Testing
---

Tested by running mvn site:run and verified doc.


Thanks,

Amareshwari Sriramadasu

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

[Amareshwari Sriramadasu]

> On Sept. 24, 2015, 2:18 a.m., Puneet Gupta wrote:
> > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java,
> >  line 210
> > 
> >
> > we can use writeObject() and readObject() instead. That way the actual 
> > seraliziation flow will get covered too.

I dont think writeObject and readObject will allow custom serialization. Don't 
we have to explicitly read and write outputformatter even in querycontext as 
well, I see the formatter is just made non-transient?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38617/#review100339
---


On Sept. 23, 2015, 6:12 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38617/
> ---
> 
> (Updated Sept. 23, 2015, 6:12 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The fix involves serializing QueryOutputFormatter
> 
> 
> Diffs
> -
> 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java
>  ae5af03 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java
>  e28c17b 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java
>  PRE-CREATION 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java
>  35d7a00 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java
>  ef8aeed 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  bed79ac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java
>  0a6cc6b 
>   
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
>  1e9a182 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  3bc9a4a 
> 
> Diff: https://reviews.apache.org/r/38617/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested with all cases of lens persisted,driver persisted and inmemory 
> result sets.
> 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  3.019 
> s]
> [INFO] Lens ... SUCCESS [  4.462 
> s]
> [INFO] Lens API ... SUCCESS [ 29.054 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 25.465 
> s]
> [INFO] Lens Cube .. SUCCESS [07:00 
> min]
> [INFO] Lens DB storage  SUCCESS [ 30.185 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.199 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:09 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 51.156 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.259 
> s]
> [INFO] Lens Server  SUCCESS [08:06 
> min]
> [INFO] Lens client  SUCCESS [ 47.492 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 12.575 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.408 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:06 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.021 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.657 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29:48 min
> [INFO] Finished at: 2015-09-22T14:45:48+05:30
> [INFO] Final Memory: 228M/3007M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

[Amareshwari Sriramadasu]

> On Sept. 25, 2015, 12:56 a.m., Amareshwari Sriramadasu wrote:
> > lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java,
> >  line 63
> > <https://reviews.apache.org/r/38617/diff/3/?file=1083971#file1083971line63>
> >
> > I dont see any difference between above method and this. Can you see if 
> > anything needs change or method can be removed?
> 
> Deepak Barr wrote:
> The name of the second column name is different.

Hard to find. Thanks! Shall we rename methods to reflect what they are, instead 
of current names?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38617/#review100508
---


On Sept. 24, 2015, 12:10 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38617/
> ---
> 
> (Updated Sept. 24, 2015, 12:10 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The fix involves serializing QueryOutputFormatter
> 
> 
> Diffs
> -
> 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java
>  ae5af03 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java
>  e28c17b 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java
>  PRE-CREATION 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java
>  35d7a00 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java
>  ef8aeed 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  bed79ac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java
>  0a6cc6b 
>   
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
>  1e9a182 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  3bc9a4a 
> 
> Diff: https://reviews.apache.org/r/38617/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested with all cases of lens persisted,driver persisted and inmemory 
> result sets.
> 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  3.019 
> s]
> [INFO] Lens ... SUCCESS [  4.462 
> s]
> [INFO] Lens API ... SUCCESS [ 29.054 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 25.465 
> s]
> [INFO] Lens Cube .. SUCCESS [07:00 
> min]
> [INFO] Lens DB storage  SUCCESS [ 30.185 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.199 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:09 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 51.156 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.259 
> s]
> [INFO] Lens Server  SUCCESS [08:06 
> min]
> [INFO] Lens client  SUCCESS [ 47.492 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 12.575 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.408 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:06 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.021 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.657 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29:48 min
> [INFO] Finished at: 2015-09-22T14:45:48+05:30
> [INFO] Final Memory: 228M/3007M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38617/#review100538
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Sept. 24, 2015, 12:10 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38617/
> ---
> 
> (Updated Sept. 24, 2015, 12:10 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The fix involves serializing QueryOutputFormatter
> 
> 
> Diffs
> -
> 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java
>  ae5af03 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java
>  e28c17b 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java
>  PRE-CREATION 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java
>  35d7a00 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java
>  ef8aeed 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  bed79ac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java
>  0a6cc6b 
>   
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
>  1e9a182 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  3bc9a4a 
> 
> Diff: https://reviews.apache.org/r/38617/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested with all cases of lens persisted,driver persisted and inmemory 
> result sets.
> 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  3.019 
> s]
> [INFO] Lens ... SUCCESS [  4.462 
> s]
> [INFO] Lens API ... SUCCESS [ 29.054 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 25.465 
> s]
> [INFO] Lens Cube .. SUCCESS [07:00 
> min]
> [INFO] Lens DB storage  SUCCESS [ 30.185 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.199 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:09 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 51.156 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.259 
> s]
> [INFO] Lens Server  SUCCESS [08:06 
> min]
> [INFO] Lens client  SUCCESS [ 47.492 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 12.575 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.408 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:06 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.021 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.657 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29:48 min
> [INFO] Finished at: 2015-09-22T14:45:48+05:30
> [INFO] Final Memory: 228M/3007M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38617/#review100508
---



lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java
 (line 63)
<https://reviews.apache.org/r/38617/#comment157732>

I dont see any difference between above method and this. Can you see if 
anything needs change or method can be removed?


- Amareshwari Sriramadasu


On Sept. 24, 2015, 12:10 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38617/
> ---
> 
> (Updated Sept. 24, 2015, 12:10 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The fix involves serializing QueryOutputFormatter
> 
> 
> Diffs
> -
> 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java
>  ae5af03 
>   
> lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java
>  e28c17b 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java
>  PRE-CREATION 
>   
> lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java
>  35d7a00 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java
>  ef8aeed 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  bed79ac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java
>  0a6cc6b 
>   
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
>  1e9a182 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  3bc9a4a 
> 
> Diff: https://reviews.apache.org/r/38617/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested with all cases of lens persisted,driver persisted and inmemory 
> result sets.
> 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  3.019 
> s]
> [INFO] Lens ... SUCCESS [  4.462 
> s]
> [INFO] Lens API ... SUCCESS [ 29.054 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 25.465 
> s]
> [INFO] Lens Cube .. SUCCESS [07:00 
> min]
> [INFO] Lens DB storage  SUCCESS [ 30.185 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.199 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:09 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 51.156 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.259 
> s]
> [INFO] Lens Server  SUCCESS [08:06 
> min]
> [INFO] Lens client  SUCCESS [ 47.492 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 12.575 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.408 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:06 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.021 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.657 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29:48 min
> [INFO] Finished at: 2015-09-22T14:45:48+05:30
> [INFO] Final Memory: 228M/3007M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Amareshwari Sriramadasu]

> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179>
> >
> > I think we already have error code for parsing, can we use that here?
> 
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)

SYNTAX_ERROR is for query, and expression parsing is for metastore. Please 
confirm if my statement is correct.
Shall we create a metastore error code (>3100) and pass it from parseExpr ?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
---


On Dec. 4, 2015, 11:39 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> ---
> 
> (Updated Dec. 4, 2015, 11:39 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
> b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  418ef5a7b64f717618c3b16fe3755141c07beb76 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> c9ba561bc8da1abb59898619620bbd47ec43028c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40899/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.226s]
> [INFO] Lens .. SUCCESS [1.371s]
> [INFO] Lens API .. SUCCESS [7.419s]
> [INFO] Lens API for server and extensions  SUCCESS [9.282s]
> [INFO] Lens Cube . SUCCESS [5:14.939s]
> [INFO] Lens DB storage ... SUCCESS [11.174s]
> [INFO] Lens Query Library  SUCCESS [5.068s]
> [INFO] Lens Hive Driver .. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver  SUCCESS [5.523s]
> [INFO] Lens Server ... SUCCESS 
> [10:04.272s]
> [INFO] Lens client ... SUCCESS [23.400s]
> [INFO] Lens CLI .. SUCCESS [40.574s]
> [INFO] Lens Examples . SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.338s]
> [INFO] Lens Distribution . SUCCESS [8.315s]
> [INFO] Lens ML Lib ... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.877s]
> [INFO] Lens Regression ... SUCCESS [2.549s]
> [INFO] Lens UI ... SUCCESS [26.262s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 40751: LENS - 882: provide option from CLI as well to list queries by driver

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40751/#review109334
---



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 221)
<https://reviews.apache.org/r/40751/#comment168809>

Javadoc needs update



lens-client/src/main/java/org/apache/lens/client/LensStatement.java (line 385)
<https://reviews.apache.org/r/40751/#comment168811>

javadoc needs update


- Amareshwari Sriramadasu


On Dec. 7, 2015, 8:41 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40751/
> ---
> 
> (Updated Dec. 7, 2015, 8:41 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-882
> https://issues.apache.org/jira/browse/LENS-882
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> After this change,  a CLI user will be able to find a list of queries that 
> ran on a particular driver.
> eg. lens-shell>query list --driver org.apache.lens.driver.hive.HiveDriver
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 48b3ebb 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 5fd04c4 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 40e6d76 
>   src/site/apt/user/cli.apt c266c6d 
> 
> Diff: https://reviews.apache.org/r/40751/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> INFO] 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.401 
> s]
> [INFO] Lens ... SUCCESS [  4.075 
> s]
> [INFO] Lens API ... SUCCESS [ 19.117 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 16.010 
> s]
> [INFO] Lens Cube .. SUCCESS [04:54 
> min]
> [INFO] Lens DB storage  SUCCESS [ 15.088 
> s]
> [INFO] Lens Query Library . SUCCESS [ 11.770 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [02:24 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 29.353 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 14.007 
> s]
> [INFO] Lens Server  SUCCESS [12:05 
> min]
> [INFO] Lens client  SUCCESS [ 29.389 
> s]
> [INFO] Lens CLI ... SUCCESS [ 44.601 
> s]
> [INFO] Lens Examples .. SUCCESS [  6.650 
> s]
> [INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  0.863 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 10.363 
> s]
> [INFO] Lens ML Lib  SUCCESS [01:21 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.111 
> s]
> [INFO] Lens Regression  SUCCESS [ 10.240 
> s]
> [INFO] Lens UI  SUCCESS [  3.515 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:26 min
> [INFO] Finished at: 2015-11-26T18:04:55+05:30
> [INFO] Final Memory: 143M/857M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>