[jira] [Updated] (LUCENE-8056) Intersects for GeoExactCircle does not trigger in some cases

2017-11-22 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8056: - Attachment: LUCENE_8056.patch Test attached > Intersects for GeoExactCircle does not trigger in

[jira] [Created] (LUCENE-8057) Bounds not properly computed for exact circles

2017-11-22 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8057: Summary: Bounds not properly computed for exact circles Key: LUCENE-8057 URL: https://issues.apache.org/jira/browse/LUCENE-8057 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-8057) Bounds not properly computed for exact circles

2017-11-22 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8057: - Attachment: LUCENE_8057.patch Attached a very simple test. It seems that latitude bounds are not

[jira] [Created] (LUCENE-8061) Factory method to create Bbox from bounds object

2017-11-22 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8061: Summary: Factory method to create Bbox from bounds object Key: LUCENE-8061 URL: https://issues.apache.org/jira/browse/LUCENE-8061 Project: Lucene - Core Issu

[jira] [Updated] (LUCENE-8061) Factory method to create Bbox from bounds object

2017-11-22 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8061: - Attachment: LUCENE_8061.patch Attached the new factory method. > Factory method to create Bbox

[jira] [Created] (LUCENE-8063) Polygons with holes don't compute bounds properly in certain situations

2017-11-23 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8063: Summary: Polygons with holes don't compute bounds properly in certain situations Key: LUCENE-8063 URL: https://issues.apache.org/jira/browse/LUCENE-8063 Project: Luce

[jira] [Updated] (LUCENE-8063) Polygons with holes don't compute bounds properly in certain situations

2017-11-23 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8063: - Attachment: LUCENE_8063_test.patch LUCENE_8063_fix.patch Attached a random test f

[jira] [Commented] (LUCENE-8063) Polygons with holes don't compute bounds properly in certain situations

2017-11-23 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264570#comment-16264570 ] Ignacio Vera commented on LUCENE-8063: -- I have a closer look and it seems I am allow

[jira] [Commented] (LUCENE-8063) Polygons with holes don't compute bounds properly in certain situations

2017-11-24 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265058#comment-16265058 ] Ignacio Vera commented on LUCENE-8063: -- I am not strict enough when building holes,

[jira] [Created] (LUCENE-8064) Random shape generator generates invalid polygons with holes

2017-11-24 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8064: Summary: Random shape generator generates invalid polygons with holes Key: LUCENE-8064 URL: https://issues.apache.org/jira/browse/LUCENE-8064 Project: Lucene - Core

[jira] [Updated] (LUCENE-8064) Random shape generator generates invalid polygons with holes

2017-11-24 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8064: - Attachment: LUCENE_8064.patch > Random shape generator generates invalid polygons with holes > --

[jira] [Commented] (LUCENE-8063) Polygons with holes don't compute bounds properly in certain situations

2017-11-24 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265292#comment-16265292 ] Ignacio Vera commented on LUCENE-8063: -- I think there is only one case where the tes

[jira] [Created] (LUCENE-8065) Exact circle failing test

2017-11-24 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8065: Summary: Exact circle failing test Key: LUCENE-8065 URL: https://issues.apache.org/jira/browse/LUCENE-8065 Project: Lucene - Core Issue Type: Bug C

[jira] [Updated] (LUCENE-8065) Exact circle failing test

2017-11-24 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8065: - Attachment: LUCENE_8065.patch > Exact circle failing test > - > >

[jira] [Created] (LUCENE-8066) Another aproach to Exact circle

2017-11-25 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8066: Summary: Another aproach to Exact circle Key: LUCENE-8066 URL: https://issues.apache.org/jira/browse/LUCENE-8066 Project: Lucene - Core Issue Type: Improveme

[jira] [Updated] (LUCENE-8066) Another aproach to Exact circle

2017-11-25 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8066: - Attachment: LUCENE-8066.patch > Another aproach to Exact circle > ---

[jira] [Updated] (LUCENE-8066) Another approach to Exact circle

2017-11-25 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8066: - Summary: Another approach to Exact circle (was: Another aproach to Exact circle) > Another appr

[jira] [Commented] (LUCENE-8066) Another approach to Exact circle

2017-11-25 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265823#comment-16265823 ] Ignacio Vera commented on LUCENE-8066: -- Yes, the circle is divided into sectors and

[jira] [Created] (LUCENE-8067) Reorganize GeoExatCircle tests

2017-11-26 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8067: Summary: Reorganize GeoExatCircle tests Key: LUCENE-8067 URL: https://issues.apache.org/jira/browse/LUCENE-8067 Project: Lucene - Core Issue Type: Test

[jira] [Updated] (LUCENE-8067) Reorganize GeoExatCircle tests

2017-11-26 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8067: - Attachment: LUCENE_8067.patch This patch places all GeoExactCircle tests in its own class. I have

[jira] [Updated] (LUCENE-8067) Reorganize GeoExactCircle tests

2017-11-27 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8067: - Summary: Reorganize GeoExactCircle tests (was: Reorganize GeoExatCircle tests) > Reorganize Geo

[jira] [Commented] (LUCENE-8067) Reorganize GeoExactCircle tests

2017-11-27 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266755#comment-16266755 ] Ignacio Vera commented on LUCENE-8067: -- That's fine. I think we need one more iterat

[jira] [Created] (LUCENE-8070) GeoExactCircle should not create circles that they do not fit in spheroid

2017-11-30 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8070: Summary: GeoExactCircle should not create circles that they do not fit in spheroid Key: LUCENE-8070 URL: https://issues.apache.org/jira/browse/LUCENE-8070 Project: L

[jira] [Updated] (LUCENE-8070) GeoExactCircle should not create circles that they do not fit in spheroid

2017-11-30 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8070: - Attachment: LUCENE-8070.patch LUCENE-8070-test.patch Attached is a test showing t

[jira] [Updated] (LUCENE-8070) GeoExactCircle should not create circles that they do not fit in spheroid

2017-11-30 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8070: - Component/s: modules/spatial3d > GeoExactCircle should not create circles that they do not fit in

[jira] [Updated] (LUCENE-8070) GeoExactCircle should not create circles that they do not fit in spheroid

2017-11-30 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8070: - Attachment: LUCENE-8070.patch New patch. I did not create a method but add a new variable to Plan

[jira] [Created] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-11-30 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8071: Summary: GeoExactCircle should create circles with right number of planes Key: LUCENE-8071 URL: https://issues.apache.org/jira/browse/LUCENE-8071 Project: Lucene - C

[jira] [Updated] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-11-30 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8071: - Attachment: LUCENE-8071.patch LUCENE-8071-test.patch Attached the test and propos

[jira] [Updated] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-12-01 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8071: - Attachment: (was: LUCENE-8071.patch) > GeoExactCircle should create circles with right numbe

[jira] [Updated] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-12-01 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8071: - Attachment: LUCENE-8071.patch > GeoExactCircle should create circles with right number of planes

[jira] [Updated] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-12-01 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8071: - Attachment: testPointsWithIn.patch Thanks for committing [~karl wright], Fair to say that the sh

[jira] [Updated] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-12-01 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8071: - Attachment: (was: testPointsWithIn.patch) > GeoExactCircle should create circles with right

[jira] [Updated] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-12-01 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8071: - Attachment: testPointsWithIn.patch > GeoExactCircle should create circles with right number of p

[jira] [Comment Edited] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

2017-12-01 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274624#comment-16274624 ] Ignacio Vera edited comment on LUCENE-8071 at 12/1/17 5:06 PM:

[jira] [Created] (LUCENE-8076) Planet should take into account the scale of the ellipsoid

2017-12-03 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8076: Summary: Planet should take into account the scale of the ellipsoid Key: LUCENE-8076 URL: https://issues.apache.org/jira/browse/LUCENE-8076 Project: Lucene - Core

[jira] [Updated] (LUCENE-8076) Planet should take into account the scale of the ellipsoid

2017-12-03 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8076: - Attachment: LUCENE-8076.patch Attached patch with proposed fix and test. Note that in my patch I

[jira] [Created] (LUCENE-8080) GeoExactCircle improvement

2017-12-06 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8080: Summary: GeoExactCircle improvement Key: LUCENE-8080 URL: https://issues.apache.org/jira/browse/LUCENE-8080 Project: Lucene - Core Issue Type: Improvement

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-06 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: LUCENE-8080-test.patch LUCENE-8080.patch Attached is the patch with t

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-06 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: LUCENE-8080.patch > GeoExactCircle improvement > -- > >

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-06 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: (was: LUCENE-8080.patch) > GeoExactCircle improvement > -

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-06 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: LUCENE-8080.patch sorry about that, I regenerated the patch. > GeoExactCircle impro

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-06 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: (was: LUCENE-8080.patch) > GeoExactCircle improvement > -

[jira] [Commented] (LUCENE-8080) GeoExactCircle improvement

2017-12-07 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281572#comment-16281572 ] Ignacio Vera commented on LUCENE-8080: -- Hi [~daddywri], My assumption is that the c

[jira] [Issue Comment Deleted] (LUCENE-8080) GeoExactCircle improvement

2017-12-07 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Comment: was deleted (was: Hi [~daddywri], My assumption is that the circle center is always wit

[jira] [Commented] (LUCENE-8080) GeoExactCircle improvement

2017-12-07 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281680#comment-16281680 ] Ignacio Vera commented on LUCENE-8080: -- My assumption is that the circle center is a

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-08 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: LUCENE-8080-test.patch LUCENE-8080.patch Hi [~karl wright], Thanks f

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-08 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: (was: LUCENE-8080.patch) > GeoExactCircle improvement > -

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-08 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: (was: LUCENE-8080-test.patch) > GeoExactCircle improvement >

[jira] [Updated] (LUCENE-8080) GeoExactCircle improvement

2017-12-08 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8080: - Attachment: LUCENE-8080.patch I agree that falling back to standard polygon approach is not the i

[jira] [Created] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets

2017-12-08 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8086: Summary: G3d wrapper: Improve circles for non spherical planets Key: LUCENE-8086 URL: https://issues.apache.org/jira/browse/LUCENE-8086 Project: Lucene - Core

[jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets

2017-12-08 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284008#comment-16284008 ] Ignacio Vera commented on LUCENE-8086: -- Thanks for the quick review, I don't think I

[jira] [Created] (LUCENE-8088) Random shape generator imeout

2017-12-10 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8088: Summary: Random shape generator imeout Key: LUCENE-8088 URL: https://issues.apache.org/jira/browse/LUCENE-8088 Project: Lucene - Core Issue Type: Bug

[jira] [Updated] (LUCENE-8088) Random shape generator imeout

2017-12-10 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8088: - Attachment: LUCENE-8088.patch > Random shape generator imeout > - > >

[jira] [Updated] (LUCENE-8088) Random shape generator timeout

2017-12-10 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8088: - Summary: Random shape generator timeout (was: Random shape generator imeout) > Random shape gen

[jira] [Created] (LUCENE-8089) Method in PlanetModel to describe type of ellipsoid

2017-12-10 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8089: Summary: Method in PlanetModel to describe type of ellipsoid Key: LUCENE-8089 URL: https://issues.apache.org/jira/browse/LUCENE-8089 Project: Lucene - Core I

[jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets

2017-12-11 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285697#comment-16285697 ] Ignacio Vera commented on LUCENE-8086: -- Hi [~karl wright], Can you review the follo

[jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets

2017-12-11 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285910#comment-16285910 ] Ignacio Vera commented on LUCENE-8086: -- I guess we do not want to expose this comple

[jira] [Created] (LUCENE-8095) Improve javadocs for GeoCircle implementations

2017-12-13 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-8095: Summary: Improve javadocs for GeoCircle implementations Key: LUCENE-8095 URL: https://issues.apache.org/jira/browse/LUCENE-8095 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-8095) Improve javadocs for GeoCircle implementations

2017-12-13 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-8095: - Attachment: LUCENE-8095.patch Patch attached. One important thing it contains is that I have rena

[jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets

2017-12-13 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289094#comment-16289094 ] Ignacio Vera commented on LUCENE-8086: -- Hi [~dsmiley], Here are my comments: 1) Th

[jira] [Commented] (LUCENE-7955) New GeoShape: GeoDegeneratePath

2017-09-05 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154850#comment-16154850 ] Ignacio Vera commented on LUCENE-7955: -- Thanks for the update [~daddywri]. There i

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-06 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156557#comment-16156557 ] Ignacio Vera commented on LUCENE-7951: -- [~dsmiley], I am ok with the pull request bu

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-07 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156980#comment-16156980 ] Ignacio Vera commented on LUCENE-7951: -- The following error is thrown by precommit i

[jira] [Comment Edited] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-07 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156980#comment-16156980 ] Ignacio Vera edited comment on LUCENE-7951 at 9/7/17 1:59 PM: -

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-07 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158156#comment-16158156 ] Ignacio Vera commented on LUCENE-7951: -- Hi [~dsmiley], Updating the configuration f

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-08 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158689#comment-16158689 ] Ignacio Vera commented on LUCENE-7951: -- I put a new version where planetModel and di

[jira] [Commented] (LUCENE-7965) Geo3d test failure

2017-09-09 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159823#comment-16159823 ] Ignacio Vera commented on LUCENE-7965: -- I see that was a real bug and a good catch.

[jira] [Commented] (LUCENE-7955) New GeoShape: GeoDegeneratePath

2017-09-10 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160254#comment-16160254 ] Ignacio Vera commented on LUCENE-7955: -- Hi [~daddywri], Thanks for this development

[jira] [Updated] (LUCENE-7955) New GeoShape: GeoDegeneratePath

2017-09-10 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7955: - Attachment: LUCENE-7955-test.patch Attached the side effect of end points as point. When a shape

[jira] [Commented] (LUCENE-7955) New GeoShape: GeoDegeneratePath

2017-09-10 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160306#comment-16160306 ] Ignacio Vera commented on LUCENE-7955: -- Looks great, thanks! Once more thing, it wou

[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes

2017-09-10 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-test.patch Hi [~kwri...@metacarta.com], I attach a new version of the ra

[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes

2017-09-11 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-test.patch sorry about this [~kwri...@metacarta.com], I have the feeling

[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes

2017-09-11 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-test.patch I have recreated the patch from scratch and it is generated us

[jira] [Commented] (LUCENE-7906) Spatial relationship between Geoshapes

2017-09-11 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161222#comment-16161222 ] Ignacio Vera commented on LUCENE-7906: -- I think something did not go as expected: l

[jira] [Created] (LUCENE-7967) GeoDegeneratePoint in Pole

2017-09-12 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-7967: Summary: GeoDegeneratePoint in Pole Key: LUCENE-7967 URL: https://issues.apache.org/jira/browse/LUCENE-7967 Project: Lucene - Core Issue Type: Bug

[jira] [Updated] (LUCENE-7967) GeoDegeneratePoint in Pole

2017-09-12 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7967: - Attachment: LUCENE-7967.patch Test attached > GeoDegeneratePoint in Pole > -

[jira] [Commented] (LUCENE-7967) GeoDegeneratePoint in Pole

2017-09-12 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162772#comment-16162772 ] Ignacio Vera commented on LUCENE-7967: -- There is no hurry so please just have a look

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-13 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164335#comment-16164335 ] Ignacio Vera commented on LUCENE-7951: -- Now all test are green. Note what I have to

[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes

2017-09-14 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-Generator_update.patch Hi [~daddywri], I have realized there is somethin

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-14 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165907#comment-16165907 ] Ignacio Vera commented on LUCENE-7951: -- Hi [~dsmiley], I would like to share some t

[jira] [Commented] (LUCENE-7906) Spatial relationship between Geoshapes

2017-09-14 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165923#comment-16165923 ] Ignacio Vera commented on LUCENE-7906: -- Agree. Thanks! > Spatial relationship betwe

[jira] [Created] (LUCENE-7970) Improve generation of circle plane

2017-09-14 Thread Ignacio Vera (JIRA)
Ignacio Vera created LUCENE-7970: Summary: Improve generation of circle plane Key: LUCENE-7970 URL: https://issues.apache.org/jira/browse/LUCENE-7970 Project: Lucene - Core Issue Type: Impro

[jira] [Updated] (LUCENE-7970) Improve generation of circle plane

2017-09-14 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7970: - Attachment: LUCENE-7970.patch Hi [~daddywri], I attached a test with my expections. The test per

[jira] [Comment Edited] (LUCENE-7970) Improve generation of circle plane

2017-09-14 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166119#comment-16166119 ] Ignacio Vera edited comment on LUCENE-7970 at 9/14/17 11:45 AM: ---

[jira] [Comment Edited] (LUCENE-7970) Improve generation of circle plane

2017-09-14 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166119#comment-16166119 ] Ignacio Vera edited comment on LUCENE-7970 at 9/14/17 11:46 AM: ---

[jira] [Updated] (LUCENE-7970) Improve generation of circle plane

2017-09-14 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7970: - Attachment: LUCENE-7970-proposed.patch Attached is the changes I have done. I changed the way the

[jira] [Commented] (LUCENE-7970) Improve generation of circle plane

2017-09-15 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167836#comment-16167836 ] Ignacio Vera commented on LUCENE-7970: -- [~karl wright], that is ok. It seems a very

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-20 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172931#comment-16172931 ] Ignacio Vera commented on LUCENE-7951: -- I have merge the Geo3dAreaRptTest into Geo3d

[jira] [Comment Edited] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-20 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172931#comment-16172931 ] Ignacio Vera edited comment on LUCENE-7951 at 9/20/17 10:40 AM: ---

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-20 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173045#comment-16173045 ] Ignacio Vera commented on LUCENE-7951: -- There test generates points of a shape by c

[jira] [Comment Edited] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-20 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173045#comment-16173045 ] Ignacio Vera edited comment on LUCENE-7951 at 9/20/17 11:35 AM: ---

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-20 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173086#comment-16173086 ] Ignacio Vera commented on LUCENE-7951: -- sure, I will add a test for this particular

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-20 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173092#comment-16173092 ] Ignacio Vera commented on LUCENE-7951: -- Actually there is already a test: In Geo3dS

[jira] [Commented] (LUCENE-7951) New wrapper classes for Geo3d

2017-09-20 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173178#comment-16173178 ] Ignacio Vera commented on LUCENE-7951: -- The problem is that in the test you do not h

[jira] [Updated] (LUCENE-7970) Improve generation of circle plane

2017-09-21 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7970: - Attachment: LUCENE_7970.patch Hi [~karl wright], Not sure if we have something to do here as I t

[jira] [Comment Edited] (LUCENE-7970) Improve generation of circle plane

2017-09-21 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174442#comment-16174442 ] Ignacio Vera edited comment on LUCENE-7970 at 9/21/17 1:02 PM:

[jira] [Commented] (LUCENE-7970) Improve generation of circle plane

2017-09-21 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174740#comment-16174740 ] Ignacio Vera commented on LUCENE-7970: -- (1) I was having problems with the maths so

[jira] [Commented] (LUCENE-7970) Improve generation of circle plane

2017-09-21 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175991#comment-16175991 ] Ignacio Vera commented on LUCENE-7970: -- Thanks [~karl wright], For the documentatio

[jira] [Updated] (LUCENE-7970) Add a Geo3d shape that models an exact circle, even when the planet model is not a sphere

2017-09-22 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7970: - Attachment: LUCENE-7970_testBearingPoint.patch Hi [~daddywri] Attached is a random test to check

[jira] [Commented] (LUCENE-7970) Add a Geo3d shape that models an exact circle, even when the planet model is not a sphere

2017-09-24 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178583#comment-16178583 ] Ignacio Vera commented on LUCENE-7970: -- Hi [~daddywri], Thanks for the patch and th

<    1   2   3   4   5   6   7   >