[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10713:
---
Attachment: SOLR-10713.patch
Nah, you brought up good points. I'm pretty familiar with git,
[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017819#comment-16017819
]
Jason Gerlowski commented on SOLR-10713:
I'd contend the "nightmarish" description you gave above-
[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017765#comment-16017765
]
Jason Gerlowski commented on SOLR-10713:
You're right that some of the file formats I take issue
[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10713:
---
Attachment: SOLR-10713.patch
Good call; updated patch to cover *.err files.
> git should
[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10713:
---
Attachment: SOLR-10713.patch
Patch updates .gitignore to not track the filetypes mentioned
[
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10713:
---
Description:
During the course of experimenting/testing Solr, it's common to accumulate a
Jason Gerlowski created SOLR-10713:
--
Summary: git should ignore common output files (*.pid, *.out)
Key: SOLR-10713
URL: https://issues.apache.org/jira/browse/SOLR-10713
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-7314:
--
Attachment: SOLR-7314.patch
Added a patch for the constants specifically mentioned above.
If
[
https://issues.apache.org/jira/browse/SOLR-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009356#comment-16009356
]
Jason Gerlowski commented on SOLR-7314:
---
I think this is worth doing. When users are forced to
[
https://issues.apache.org/jira/browse/SOLR-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990751#comment-15990751
]
Jason Gerlowski commented on SOLR-10587:
If you're not happy with the move of the log message, I
[
https://issues.apache.org/jira/browse/SOLR-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10587:
---
Attachment: SOLR-10587.patch
Updated patch addresses your comments. I trimmed down the
[
https://issues.apache.org/jira/browse/SOLR-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10587:
---
Attachment: SOLR-10587.patch
> Ban defaultSearchField in schema for luceneMatchVersion
[
https://issues.apache.org/jira/browse/SOLR-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990276#comment-15990276
]
Jason Gerlowski commented on SOLR-10587:
Attached patch makes the required changes to
[
https://issues.apache.org/jira/browse/SOLR-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10558:
---
Attachment: SOLR-10558.patch
I've attached a small patch showing one way this change could be
[
https://issues.apache.org/jira/browse/SOLR-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982808#comment-15982808
]
Jason Gerlowski commented on SOLR-10535:
{{ant -Dtests.filter="@nightly and not(@awaitsfix or
[
https://issues.apache.org/jira/browse/SOLR-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982689#comment-15982689
]
Jason Gerlowski edited comment on SOLR-10535 at 4/25/17 10:45 AM:
--
Ran
[
https://issues.apache.org/jira/browse/SOLR-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982689#comment-15982689
]
Jason Gerlowski edited comment on SOLR-10535 at 4/25/17 10:44 AM:
--
Ran
[
https://issues.apache.org/jira/browse/SOLR-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10535:
---
Attachment: SOLR-10535.patch
Ran the script Christine uploaded, with some tweaks to have it
[
https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10456:
---
Attachment: SOLR-10456.patch
Updates patch to remove conflicts with most recent master.
>
[
https://issues.apache.org/jira/browse/SOLR-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski closed SOLR-10457.
--
Resolution: Duplicate
> setSoTimeout should be deprecated in favor of SolrClientBuilder methods
[
https://issues.apache.org/jira/browse/SOLR-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10457:
---
Fix Version/s: (was: trunk)
> setSoTimeout should be deprecated in favor of
[
https://issues.apache.org/jira/browse/SOLR-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski reopened SOLR-10457:
Reopening in an attempt to remove the inaccurate "Fix Version". (I can't see
how to edit the
[
https://issues.apache.org/jira/browse/SOLR-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964808#comment-15964808
]
Jason Gerlowski commented on SOLR-10457:
This duplicates
[
https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10456:
---
Attachment: SOLR-10456.patch
> timeout-related setters should be deprecated in favor of
[
https://issues.apache.org/jira/browse/SOLR-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski closed SOLR-10457.
--
Resolution: Duplicate
> setSoTimeout should be deprecated in favor of SolrClientBuilder methods
[
https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10456:
---
Description:
Now that builders are in place for {{SolrClients}}, the setters used in each
[
https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10456:
---
Summary: timeout-related setters should be deprecated in favor of
SolrClientBuilder methods
Jason Gerlowski created SOLR-10470:
--
Summary: setParallelCacheRefreshes should be deprecated in favor
of SolrClientBuilder methods
Key: SOLR-10470
URL: https://issues.apache.org/jira/browse/SOLR-10470
Jason Gerlowski created SOLR-10469:
--
Summary: setParallelUpdates should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10469
URL: https://issues.apache.org/jira/browse/SOLR-10469
Jason Gerlowski created SOLR-10468:
--
Summary: setZkClientTimeout should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10468
URL: https://issues.apache.org/jira/browse/SOLR-10468
Jason Gerlowski created SOLR-10466:
--
Summary: setDefaultCollection should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10466
URL: https://issues.apache.org/jira/browse/SOLR-10466
Jason Gerlowski created SOLR-10467:
--
Summary: setZkConnectTimeout should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10467
URL: https://issues.apache.org/jira/browse/SOLR-10467
Jason Gerlowski created SOLR-10465:
--
Summary: setIdField should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10465
URL: https://issues.apache.org/jira/browse/SOLR-10465
Project:
Jason Gerlowski created SOLR-10464:
--
Summary: setCollectionCacheTT should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10464
URL: https://issues.apache.org/jira/browse/SOLR-10464
Jason Gerlowski created SOLR-10463:
--
Summary: setRetryExpiryTime should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10463
URL: https://issues.apache.org/jira/browse/SOLR-10463
Jason Gerlowski created SOLR-10462:
--
Summary: setPollQueueTime should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10462
URL: https://issues.apache.org/jira/browse/SOLR-10462
Jason Gerlowski created SOLR-10460:
--
Summary: setUseMultiPartPost should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10460
URL: https://issues.apache.org/jira/browse/SOLR-10460
Jason Gerlowski created SOLR-10461:
--
Summary: setAliveCheckInterval should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10461
URL: https://issues.apache.org/jira/browse/SOLR-10461
Jason Gerlowski created SOLR-10459:
--
Summary: setRequestWriter should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10459
URL: https://issues.apache.org/jira/browse/SOLR-10459
Jason Gerlowski created SOLR-10458:
--
Summary: setFollowRedirects should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10458
URL: https://issues.apache.org/jira/browse/SOLR-10458
Jason Gerlowski created SOLR-10457:
--
Summary: setSoTimeout should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10457
URL: https://issues.apache.org/jira/browse/SOLR-10457
Project:
Jason Gerlowski created SOLR-10456:
--
Summary: setConnectionTImeout should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10456
URL: https://issues.apache.org/jira/browse/SOLR-10456
Jason Gerlowski created SOLR-10455:
--
Summary: setParser should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10455
URL: https://issues.apache.org/jira/browse/SOLR-10455
Project: Solr
Jason Gerlowski created SOLR-10454:
--
Summary: setBaseURL should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10454
URL: https://issues.apache.org/jira/browse/SOLR-10454
Project:
Jason Gerlowski created SOLR-10453:
--
Summary: setBasicAuthHeader should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10453
URL: https://issues.apache.org/jira/browse/SOLR-10453
Jason Gerlowski created SOLR-10452:
--
Summary: setQueryParams should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-10452
URL: https://issues.apache.org/jira/browse/SOLR-10452
Project:
[
https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957858#comment-15957858
]
Jason Gerlowski commented on SOLR-8975:
---
So I've taken a few (failed) cracks at this. I believe in
[
https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527057#comment-15527057
]
Jason Gerlowski commented on SOLR-8975:
---
As an additional question/comment, the attached patch takes
[
https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8975:
--
Attachment: SOLR-8975.patch
I made these changes with respect to {{HttpSolrClient}}, in hopes of
[
https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510829#comment-15510829
]
Jason Gerlowski commented on SOLR-8975:
---
I've started work on this in earnest, after an embarassingly
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506475#comment-15506475
]
Jason Gerlowski commented on SOLR-8097:
---
I created SOLR-9535 to address the recent concern brought up
[
https://issues.apache.org/jira/browse/SOLR-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506469#comment-15506469
]
Jason Gerlowski edited comment on SOLR-9535 at 9/20/16 1:10 PM:
Attaching a
[
https://issues.apache.org/jira/browse/SOLR-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-9535:
--
Attachment: SOLR-9535.patch
Attaching a patch making this change in CloudSolrClient.
After some
Jason Gerlowski created SOLR-9535:
-
Summary: SolrClients should have protected constructors
Key: SOLR-9535
URL: https://issues.apache.org/jira/browse/SOLR-9535
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487748#comment-15487748
]
Jason Gerlowski commented on SOLR-8097:
---
I'll create a separate issue for changing the appropriate
[
https://issues.apache.org/jira/browse/SOLR-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286621#comment-15286621
]
Jason Gerlowski commented on SOLR-8774:
---
Af first glance, this seems like a feature that would go
[
https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283920#comment-15283920
]
Jason Gerlowski commented on SOLR-8975:
---
Sitting down to start working on this now. A few
[
https://issues.apache.org/jira/browse/SOLR-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282645#comment-15282645
]
Jason Gerlowski commented on SOLR-8462:
---
Sure; I'll take a look at it this weekend.
> Improve error
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237870#comment-15237870
]
Jason Gerlowski commented on SOLR-8097:
---
I created SOLR-8975 for this work, with a short description.
Jason Gerlowski created SOLR-8975:
-
Summary: SolrClient setters should be deprecated in favor of
SolrClientBuilder methods
Key: SOLR-8975
URL: https://issues.apache.org/jira/browse/SOLR-8975
Project:
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237634#comment-15237634
]
Jason Gerlowski commented on SOLR-8097:
---
I thought about doing that as a part of my patch, but it
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
Uploading a patch that has everything except the renames. (See my
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228430#comment-15228430
]
Jason Gerlowski edited comment on SOLR-8097 at 4/6/16 3:10 PM:
---
So, I've got
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228430#comment-15228430
]
Jason Gerlowski commented on SOLR-8097:
---
So, I've got an updated patch that does everything except
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227040#comment-15227040
]
Jason Gerlowski commented on SOLR-8097:
---
Yep, working on updating the patch now. It looks like
[
https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221754#comment-15221754
]
Jason Gerlowski commented on SOLR-8830:
---
Can anyone give me a little guidance on where to direct my
[
https://issues.apache.org/jira/browse/SOLR-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214997#comment-15214997
]
Jason Gerlowski commented on SOLR-8642:
---
Sorry to hear that this is causing so much trouble for you
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214974#comment-15214974
]
Jason Gerlowski commented on SOLR-8110:
---
Maybe I'm missing something, but how would a
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
Ok, this removes all* uses of the now-deprecated constructors.
The
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207360#comment-15207360
]
Jason Gerlowski commented on SOLR-8097:
---
I didn't forget, but I was unsure whether that should be
[
https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8830:
--
Attachment: SOLR-8830.patch
Might've been going down the wrong path before. I realized that
[
https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204077#comment-15204077
]
Jason Gerlowski commented on SOLR-8830:
---
Short non-update here:
Spent a little time looking into
[
https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197679#comment-15197679
]
Jason Gerlowski commented on SOLR-8830:
---
Is this problem only limited to updates, or is this a
[
https://issues.apache.org/jira/browse/SOLR-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8808:
--
Attachment: SOLR-8808.patch
Uploaded patch contains changes to SolrClient.java. It also adds a
[
https://issues.apache.org/jira/browse/SOLR-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8836:
--
Attachment: SOLR-8836.patch
Looking into Solr's error messages more, I think the error-message
[
https://issues.apache.org/jira/browse/SOLR-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192487#comment-15192487
]
Jason Gerlowski commented on SOLR-8808:
---
+1 for this JIRA.
SolrJ code tends to take a laissez-faire
[
https://issues.apache.org/jira/browse/SOLR-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192483#comment-15192483
]
Jason Gerlowski commented on SOLR-8801:
---
+1. Patch looks good to me. Seems like a simple but
[
https://issues.apache.org/jira/browse/SOLR-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8836:
--
Attachment: SOLR-8836.patch
A simple patch demonstrating a fix for the issue. With this fix,
Jason Gerlowski created SOLR-8836:
-
Summary: /update should return BAD REQUEST when invalid JSON
provided
Key: SOLR-8836
URL: https://issues.apache.org/jira/browse/SOLR-8836
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
Thanks for the review Anshum. Made all the changes you suggested
[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188416#comment-15188416
]
Jason Gerlowski edited comment on SOLR-8765 at 3/10/16 1:15 AM:
IMO, Id
[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188416#comment-15188416
]
Jason Gerlowski edited comment on SOLR-8765 at 3/10/16 12:57 AM:
-
IMO, Id
[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188416#comment-15188416
]
Jason Gerlowski commented on SOLR-8765:
---
IMO, Id rather have {{SolrIdentifierValidator}} throw NAE
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
Updates patch on top of recent changes in master. Tests pass
[
https://issues.apache.org/jira/browse/SOLR-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8766:
--
Attachment: SOLR-8766.patch
This patch scrubs any/all tags from solrconfig.xml.
> remove the
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
> Implement a builder pattern for constructing a Solrj client
>
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179287#comment-15179287
]
Jason Gerlowski commented on SOLR-8097:
---
Hmm, still seeing some test failures with this patch.
[
https://issues.apache.org/jira/browse/SOLR-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8398:
--
Attachment: SOLR-8398.patch
Updates patch to apply-cleanly on top of latest master.
> Remove
[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176577#comment-15176577
]
Jason Gerlowski commented on SOLR-8765:
---
I've been poking around in that code a bit recently, so I
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176410#comment-15176410
]
Jason Gerlowski commented on SOLR-8097:
---
bq. we need to continue testing the current SolrJ
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
Oops, the carelessness of {{git add -A}} (and the user who ran it)
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
bq. Let's carry on with adding tests, javadocs, deprecation, and
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
Adds tests for each builder. Removes abstract-class approach.
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-8097:
--
Attachment: SOLR-8097.patch
Puts patch on top of latest trunk/master. Fixes some of Anshum's
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170749#comment-15170749
]
Jason Gerlowski edited comment on SOLR-8097 at 2/27/16 10:45 PM:
-
So,
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170749#comment-15170749
]
Jason Gerlowski commented on SOLR-8097:
---
So, looking close at these builder classes, I'm not sure
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170695#comment-15170695
]
Jason Gerlowski edited comment on SOLR-8097 at 2/27/16 9:40 PM:
Thanks for
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170695#comment-15170695
]
Jason Gerlowski commented on SOLR-8097:
---
Thanks for the review Anshum. Sorry it took me a few days
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170695#comment-15170695
]
Jason Gerlowski edited comment on SOLR-8097 at 2/27/16 6:40 PM:
Thanks for
[
https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170676#comment-15170676
]
Jason Gerlowski commented on SOLR-8097:
---
Gonna revert my different name (updateLeadersOnly) as Anshum
601 - 700 of 874 matches
Mail list logo
