Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/214
In what case are you seeing an exception? Could you please provide some
code to reproduce? Ideally, an integration test or a console app that can be
copied and pasted.
---
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/215
Thanks!
---
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
> We could potentially use some automation to overwrite the main Lucene.Net
website and add a new subfolder for each version of docs right from the
[Lucene.Net
Release](ht
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
I use the Releases section to find the commit to use, as these are frozen
points in time. This is a little tricky because the core library was ported
from
[4.8.0](https://github.com/apache
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
> have fixed up a bunch of xref's
To save a bunch of manual work, I created the
https://github.com/apache/lucenenet/tree/master/src/dotnet/tools/JavaDocToMarkdownConverter
t
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
@SilentCC
Both of those classes were moved into
[Lucene.Net.Queries](https://www.nuget.org/packages/Lucene.Net.Queries/). See
the [Lucene 4.0 Migration
Guide](https
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
@SilentCC
Both of those classes were moved into
[Lucene.Net.Queries](https://www.nuget.org/packages/Lucene.Net.Queries/). See
the [Lucene 4.0 Migration
Guide](https
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
Thanks Shannon.
### Docs Build
There seems to be an issue with building the docs now.
, therefore it doesn't make much sense to list it with the new pre-release
packages. We might
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
> > Not sure exactly what you mean by this. But, you might consider doing a
local build build -pv:4.8.0-beta5, and then you can reference the NuGet
package locally so you ca
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
Jens,
I have upgraded the project
[here](https://github.com/NightOwl888/lucenenet/tree/replicator) to work on
.NET Standard 1.5, cleaned up the doc comments, and fixed the member
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
Thanks Shannon. There are basically 5 tasks I'd like to get done before the
next beta release:
1. Finish up Replicator
2. Upgrade to the new `.csproj` format/VS2017
3. Support
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
FYI - I have started cleaning up the documentation comments already so I
can merge this. Just wanted you to know so we aren't duplicating efforts.
Thanks again for the contribution
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
Hi Jens,
I'd like to get this merged so I can start working on upgrading to the new
`.csproj` format and adding support for the [now released .NET Standard
2.0](https://github.com
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
> Actually way back the first time I began to look into Lucene on .NET I
did come across a few other attempts on just that, but I guess they died off in
favor for this, and to some ext
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
> I don't know how you would get that idea? I have been usiing IoC/DI for
years, often but not always paired with a IoC Container.
My bad. To me it seems natural to want to put
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
> Holy crap... I am glad I am not under that umbrella, in an age of
continuous delivery and continuous deployment that sounds like poison... o.O...
It's both a blessing and a cu
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
Jens, thanks for the feedback.
While I generally agree with your points, we are unfortunately obligated to
work within the confines of the Apache organization, which comes with its
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
BTW - I tried running the code generation after copying and pasting the
repo over to a different directory, and I am getting a null reference exception
for some reason.
```
Done
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
During the building of a tool to get the `.html` pages converted, I can
break the types of links we have into 3 categories:
1. Code links
2. Repo links
3. Namespace links
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
> Happy to contribute if that'd help at all.
There are definitely [a lot of
things](https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md#other-ways-to-help)
you could
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
@AndyPook
Good point on the `context` parameter. After [taking a closer
look](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.8.1/lucene/replicator/src/java/org
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
@jeme
I got a chance to get a deeper look of this structure, and I found a
comment on that blog post that holds the answer to what I think is the part we
are struggling
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/210
As you can see your commit is here:
https://github.com/apache/lucenenet/commits/master
What you do with the branch on your GitHub account is up to you.
Personally, I usually just
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/209
> Another thing is that we don't really hide much complexity for the
developer but instead take away his freedom to decide when and where indexes
etc. should be initialized or at le
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
FYI - The CLI tool and docs have been merged to master.
https://github.com/apache/lucenenet/tree/cli/src/tools/lucene-cli/docs
---
If your project is set up for it, you can reply
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
Thanks. I ended up dividing them into separate documents because it was too
easy to scroll by the end of the command you are looking at into the next
command, so that was not needed anyway
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
@Shazwazza - Ok, you have explained how to link from one document to
another in Markdown. How would you do an anchor within the same document so
that it works in DocFx?
I went
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
Actually, I was referring to the new "tools" folder under "src" (to keep
the docs near the source code the same as they would be by converting the HTML
pages from
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
Much appreciated - keep up the good work ð
I am almost to the point where I will start documenting the [new CLI
tool](https://github.com/NightOwl888/lucenenet/tree/cli/src/tools
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/207
Looks nice. Although, I tend to favor the "all methods are verbs" and "all
properties are nouns or adjectives" methodology. For example, I would expect a
method named
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/207
What about naming? Do you think it would be more intuitive to call it
`AcquireReference()` and make the class named `Reference` instead of
`ReferenceContext`? Seems like that would be a bit
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
I have added some comments inline.
I also [asked a
question](https://stackoverflow.com/questions/44670354/how-do-you-create-code-references-with-custom-link-text-in-documentation
Github user NightOwl888 commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/206#discussion_r125003467
--- Diff: apidocs/docs.ps1 ---
@@ -49,10 +49,17 @@ If ($FileExists -eq $False) {
if ($Clean -eq 1) {
Remove-Item (Join-Path -Path
Github user NightOwl888 commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/206#discussion_r12420
--- Diff: apidocs/api/index.md ---
@@ -129,6 +128,9 @@ index for all the files contained in a directory.
SearchFiles.java
prompts
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
@Shazwazza - Added another minor issue to the above list. Any chance you
will be able to answer some of these questions soon? In particular, I would
like to know if there is a spec
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/158
Please close this issue now. I have confirmed that this is no longer a
problem in Lucene.Net 4.8.0.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/208
@vvdb
I would like to add this fix to the next release. Are you planning to
submit another pull request?
---
If your project is set up for it, you can reply to this email and have
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
@Shazwazza
Thanks again. I took a look and documentation generated perfectly. The
documentation and code samples look great.
I have done all of the grunt work to update
GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/207
API: Added ReferenceManager.AcquireContext()
Opening this as a pull request so the team can discuss this approach vs the
previous `ExecuteSearch` method (that was inadvertently removed from
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/206
@Shazwazza
Thanks for this!
> it's also possible to add markdown articles using docfx but I've removed
these for now until we might want them.
We definitely w
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/205
> I am currently working around this using reflection, so for me it's fine.
Peter, could you please post your workaround here in case other users need
it?
---
If your project is
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/205
> OK. So I should remove the `[Ignore]` attribute then?
Yes. We should only use the `[Ignore]` attribute in cases where the test
takes > 30 minutes and must be run ma
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/205
@pvginkel
Could you add a test to this PR in the [TestDirectory
class](https://github.com/pvginkel/lucenenet/blob/synchronized-stale-files/src/Lucene.Net.Tests/Store/TestDirectory.cs
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/205
@synhershko
Not without cancelling the vote and starting over (for the 3rd time) - we
have only 12 hours left on the current vote. I suspect there will be several
issues
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/203
@davhdavh
> 1. The assemblies are not strong-named in either debug or release build.
Per Itamar (the project manager), [Lucene.Net will not be strong-named
going
forw
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/203
@davhdavh - I have now added the XML documentation to the packages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/203
Nope, there is still a lot of broken XML in the documentation comments (see
above) that are preventing the process from being complete. It would take a
single person the better part of a week
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/204
Cool - certainly will be better than sending files one by one :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/203
I also apologize for the delayed response.
> Is there anything I can help with?
Yes, there is. I have been working on cleaning the API up and making it
more .NET-l
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
I did some more digging, and it seems for NUnit 3.5 they have [moved the
output of the tests](https://github.com/nunit/nunit3-vs-adapter/issues/301) to
write to the output of the test itself
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
To be clear, this happens when you check the DEBUG box in the
`Lucene.Net.TestFramework` project. I confirmed that checking the box makes the
setting true. So, apparently somehow the output
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
Hi @conniey,
I am starting to go through the tests now on the #203 branch to see if I
can fix some of them. However, I can't seem to work out how to turn on
verbosity. This used
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
> Building the sources directly is totally not an option since it would
require anyone who wants to try NET Standart version to link the whole source
tree into their projects and find a
GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/203
API Work - Stabilization
This is a branch of #191 and supersedes that pull request. To build this
branch, see the instructions on #191.
The plan is to work on the API here to keep
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/200
> It would be cool to get #191 merged so we can get TeamCity working with
the new layout, not sure what is between us and that though.
I know there is at least:
- Te
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/200
Hi, does this have anything to do with #194? We should probably revert that
change, since it causes a conflict with #191 (which we are actively working on).
We really should
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
@conniey
I have nearly finished Highlighter on this branch
https://github.com/NightOwl888/lucenenet/tree/netcoremigration-highlighter
There is still 1 failing test
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
Update
===
Build
---
I fixed the build issue by adding a NuGet.config file (thanks for the
suggestion @conniey). I also pushed a commit to fix the physical directory
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
@conniey
FYI I have pushed QueryParser.Xml to master. This branch can now be brought
up to date by either merging master, or if you prefer you can update one chunk
at a time
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/197
See
https://github.com/apache/lucenenet/commit/e8735ed9622ab56eaf86bae6394f93f3fb058d30
for an example.
If it is something that needs to go in right away (such as this) you could
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/198
Thanks for informing - this was something that slipped in by accident. Ever
since I first noticed that VS2012 can't compile these features, I have been
trying to keep them out of the code
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/197
Not sure why this happened - probably a botched merge of some kind. I'll
pull this into master.
For future reference, it would work smoother on my end if you just add
`fixes #197
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
Yes, it is currently at MyGet here:
https://www.myget.org/F/spatial4n/api/v2.
@synhershko has given me access to push the `Spatial4n.Core` package to
NuGet
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
@Metamorphus - Yea, that would be great. I can take care of the other 2
folders and their tests. Just let me know when you have the Highlight tests
implemented and where I can grab them
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
> @NightOwl888 Thanks for the detailed explanation. I'll get my first touch
to it at weekend, but I anticipate a lot of problems, since I'm only a junior
developer (e.g. I'm not even famil
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
@conniey
FYI - I have completed Lucene.Net.Spatial and it has been added to the
master branch. The 2 Spatial4n NuGet dependencies are currently hosted on MyGet
here: https
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/174
Spatial is now complete.
The NuGet packages are currently on this MyGet feed:
https://www.myget.org/F/spatial4n/api/v2
---
If your project is set up for it, you can reply
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
> @NightOwl888 seems like the code for Highlighter is too obsolete. It uses
classes, which since 4.8 don't exist anymore (e.g. TermEnum) and needs
MemoryIndex to be ported to full .NET. Sh
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
>
> 1. From command line: dotnet restore
> 2. Open Lucene.Net.Portable.sln
> 3. Right-click -> Build Solution (Ctrl+Shift+B)
>
> Do you still ge
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
Here's the file...
[restore.zip](https://github.com/apache/lucenenet/files/610313/restore.zip)
NOTE: Despite what I said earlier about not wasting effort on .NET 3.5, we
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
Prescott,
Thanks. Iâd appreciate it. It would be better if we could consolidate all
development on Visual Studio 2015 Community so others that want to contribute
donât have
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/195
No offense, but since @conniey has already provided a [working solution to
the ICU bitness
issue](https://github.com/apache/lucenenet/pull/191#issuecomment-262379449),
this seems like a step
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
Thanks Connie. I am having my first stab at working with this branch, but I
am having a few problems getting set up.
First of all, I don't have a copy of Visual Studio 2013 developer
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
> @NightOwl888 I apologise for the delayed response. Thanks for the ideas
with pros and cons. I've been busy at work with another project but will start
working on the script today. A
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
@Metamorphus
Porting Highlighter is the plan, although to my knowledge nobody is
currently working on it. It has lagged behind primarily because it depends on
the BreakIterator
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
BTW - your test suite status indicates that you haven't yet merged
Lucene.Net.Grouping here. It might be a good idea to ensure there are no issues
with it in .NET core (https://github.com
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
> @NightOwl888 @synhershko I am looking through the PR and reducing any
unnecessary changes. To make this PR smaller, I was wondering if it would be a
good idea to split my changes from NU
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/193
Oops, looks like the first attempt to push was rejected and I posted the
wrong commit before. The new test class override rollback point is:
https://github.com/apache/lucenenet/commit
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/193
I have now merged these changes to master.
Do note that there is a new commit where the test class override stubs can
be reverted (if needed):
https://github.com/apache/lucenenet
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
> >There are 2 different PriorityQueue types in Lucene.Net
> Is there a reason for this? Can we stay with one?
Yes, there is a reason for that â that i
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/174
If there are no objections (meaning nobody else beat me to it), I would
like to begin working on this.
Observations:
- Spatial4n has dependencies on GeoAPI 1.7.2
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/191
FYI - There are 2 branches that still need to be integrated before this is
up to date with master:
- https://github.com/NightOwl888/lucenenet/tree/core-tests
- https://github.com
Github user NightOwl888 commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/190#discussion_r82028685
--- Diff: src/Lucene.Net.Core/Support/DataInputStream.cs ---
@@ -0,0 +1,323 @@
+using System;
+using System.IO;
+
+namespace
Github user NightOwl888 commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/190#discussion_r82028284
--- Diff: Lucene.Net.sln ---
@@ -59,14 +60,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") =
"Lucene.Net.Suggest", &q
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/174
@eladmarg
There are a couple of snags that could make that idea difficult:
1. Whitespace differences (different number of tabs/spaces, different line
break chars, etc)
2
GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/190
Ported Analysis.Stempel
All 16 tests are passing.
I ended up porting over `DataInputStream` and `DataOutputStream` and their
corresponding interfaces from Java to save time
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/188
@synhershko
> I say let's first release, then see who uses this. Once we see a lot of
usage, we may reconsider the implementation. WDYT?
In that case this is ready to
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/189
Nope, I have permissions issues:
```
F:\Projects\lucenenet>git push upstream master
Enter passphrase for key '/c/Users/Shad/.ssh/id_rsa':
ERROR: Sorry, but @apache
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/189
I haven't tried pushing to the repo, but it doesn't look like I have
permissions in the GitHub control panel to merge pull requests.
It should only take a couple of minutes to fix
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/189
Yep, definitely a smaller diff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/186
Okay, this one has rebased successfully without any issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/188
> which of the sub-project not ported yet?
AFAIK, these are the pieces that are missing that are not currently being
worked on, but you should send an email to `
GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/188
Fixed 64 Failing Tests and Finished Facet Implementation
Fixed the 64 failing Facet tests, refactored the public API to be more .NET
friendly (changing methods to properties and vice versa
GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/187
Fixed 76 QueryParser Failing Tests
This fixes 76 of the 77 failing tests in QueryParser. The remaining one is
a matter of completing the test implementation (or removing it entirely
GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/186
Ported Misc (mostly), Suggest, and Memory
This pull request contains Lucene.Net.Misc, Lucene.Net.Suggest, and
Lucene.Net.Memory. There is also some cleanup of the compiler warnings
1 - 100 of 126 matches
Mail list logo
