[GitHub] madlib pull request #345: Typos

2019-01-10 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/madlib/pull/345 Typos Hi, a few typos found. Not a native speaker, so happy if someone else takes a more careful look at these changes. Cheers Bruno You can merge this pull request into a Git

[GitHub] madlib pull request #344: Add kd-tree option to knn.

2019-01-07 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/344 Add kd-tree option to knn. This commits add the a partial kd-tree implementation to be used for knn operations. This function is designed to work independently in case some future

[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...

2019-01-03 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/343#discussion_r245023325 --- Diff: src/ports/postgres/modules/regress/linear.py_in --- @@ -185,10 +221,12 @@ def _validate_args(schema_madlib, source_table, out_table,

[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...

2019-01-03 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/343#discussion_r245022983 --- Diff: src/ports/postgres/modules/regress/linear.py_in --- @@ -134,11 +170,11 @@ def linregr_train(schema_madlib, source_table, out_table,

[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...

2018-12-27 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/343 Linear Regression: Support for JSON and special characters JIRA: MADLIB-1284 - Modified code in linear.py_in to support special characters and JSON data type - Written

[GitHub] madlib pull request #342: Minibatch Preprocessor for Deep learning

2018-12-21 Thread reductionista
Github user reductionista commented on a diff in the pull request: https://github.com/apache/madlib/pull/342#discussion_r243694232 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -51,6 +51,105 @@ m4_changequote(`')

[GitHub] madlib pull request #342: Minibatch Preprocessor for Deep learning

2018-12-19 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/342 Minibatch Preprocessor for Deep learning The minibatch preprocessor we currently have in MADlib is bloated for DL tasks. This feature adds a simplified version of creating buffers, and

[GitHub] madlib pull request #341: Minibatch Preprocessor for Deep learning

2018-12-19 Thread njayaram2
Github user njayaram2 closed the pull request at: https://github.com/apache/madlib/pull/341 ---

[GitHub] madlib pull request #341: Minibatch Preprocessor for Deep learning

2018-12-19 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/341 Minibatch Preprocessor for Deep learning The minibatch preprocessor we currently have in MADlib is bloated for DL tasks. This feature adds a simplified version of creating buffers, and

[GitHub] madlib pull request #340: Validation: Support other 'relkind' for input tabl...

2018-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/340 ---

[GitHub] madlib pull request #339: Build: Add PG11 Support

2018-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/339 ---

[GitHub] madlib pull request #340: Validation: Support other 'relkind' for input tabl...

2018-12-11 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/340 Validation: Support other 'relkind' for input tables JIRA: MADLIB-1287 Within `validate_args.py_in:table_exists()` we checked if a table existed within `pg_class` but limited the input

[GitHub] madlib pull request #339: Build: Add PG11 Support

2018-11-29 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/339#discussion_r237604025 --- Diff: src/ports/postgres/modules/kmeans/kmeans.sql_in --- @@ -766,15 +766,30 @@ BEGIN proc_fn_dist := fn_dist || '(DOUBLE

[GitHub] madlib pull request #339: Build: Add PG11 Support

2018-11-28 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/339#discussion_r237326034 --- Diff: src/ports/postgres/modules/utilities/utilities.py_in --- @@ -407,6 +407,15 @@ def set_client_min_messages(new_level): return

[GitHub] madlib pull request #339: Build: Add PG11 Support

2018-11-26 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/339 Build: Add PG11 Support JIRA: MADLIB-1283 PG11 support required a number of minor changes in the code. - Change TRUE/FALSE to true/false - Use TupleDescAttr function instead of

[GitHub] madlib pull request #338: Install/Dev check: Add new test cases for some mod...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/338 ---

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/334 ---

[GitHub] madlib pull request #338: Install/Dev check: Add new test cases for some mod...

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/338#discussion_r234052747 --- Diff: src/ports/postgres/modules/pmml/test/pmml.ic.sql_in --- @@ -0,0 +1,119 @@ +/*

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051398 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -487,10 +487,16 @@ class MiniBatchDocumentation:

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051252 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -487,10 +487,16 @@ class MiniBatchDocumentation:

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051503 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -487,10 +487,16 @@ class MiniBatchDocumentation:

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051175 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -508,8 +514,13 @@ class MiniBatchDocumentation:

[GitHub] madlib pull request #338: Install/Dev check: Add new test cases for some mod...

2018-11-15 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/338 Install/Dev check: Add new test cases for some modules Some modules such as array_ops and pmml did not have any install check files, while stemmer did not have any test files. This commit adds

[GitHub] madlib pull request #337: Madpack: Add UDO and UDOC automation

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/337 ---

[GitHub] madlib pull request #337: Madpack: Add UDO and UDOC automation

2018-11-12 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/337#discussion_r232721653 --- Diff: src/madpack/diff_udo.sql --- @@ -0,0 +1,81 @@ +-- +--

[GitHub] madlib pull request #337: Madpack: Add UDO and UDOC automation

2018-11-09 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/337#discussion_r232279216 --- Diff: src/madpack/create_changelist.py --- @@ -237,6 +325,13 @@ print "Something went wrong! The changelist might be wrong/corrupted."

[GitHub] madlib pull request #337: Madpack: Add UDO and UDOC automation

2018-11-08 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/337#discussion_r231972206 --- Diff: src/madpack/diff_udo.sql --- @@ -0,0 +1,81 @@ +-- +--

[GitHub] madlib pull request #337: Madpack: Add UDO and UDOC automation

2018-11-08 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/337#discussion_r231953942 --- Diff: src/madpack/create_changelist.py --- @@ -237,6 +325,13 @@ print "Something went wrong! The changelist might be wrong/corrupted."

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/332 ---

[GitHub] madlib pull request #337: Madpack: Add UDO and UDOC automation

2018-10-26 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/337 Madpack: Add UDO and UDOC automation JIRA: MADLIB-1281 - Add scripts for detecting changed/dropped UDOs and UDOCs. - Expand the create_changelist.py file to consume these scripts

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-10-25 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/332#discussion_r228394441 --- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 --- @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-10-25 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/332#discussion_r228394202 --- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 --- @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-10-24 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/332#discussion_r227919519 --- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 --- @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-10-24 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/332#discussion_r227918905 --- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 --- @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-10-23 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/334 Minibatch Preprocessor: Update online doc The online doc is outdated. This commit adds two new parameters that have been introduced since the last time the doc was edited. You can merge this

[GitHub] madlib pull request #333: Update version numbers to 1.16-dev

2018-10-23 Thread orhankislal
Github user orhankislal closed the pull request at: https://github.com/apache/madlib/pull/333 ---

[GitHub] madlib pull request #333: Update version numbers to 1.16-dev

2018-10-19 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/333 Update version numbers to 1.16-dev You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib release/new-version Alternatively you can

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-10-19 Thread jingyimei
GitHub user jingyimei opened a pull request: https://github.com/apache/madlib/pull/332 Update Dockerfile to use ubuntu 16.04 This commit adds a new dockerfile to bake postgres 10.5 on ubuntu 16.04. Also updates docker_start.sh and README to pull the new docker image instead

[GitHub] madlib pull request #331: Build: Include preflight and postflight scripts fo...

2018-10-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/331 ---

[GitHub] madlib pull request #331: Build: Include preflight and postflight scripts fo...

2018-10-09 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/331 Build: Include preflight and postflight scripts for mac Commit #441f16bd55d2a26e4dd59df6129c6092f099cbca introduced a bug where the preflight and postflight scripts for mac were not getting

[GitHub] madlib pull request #329: Release/prep 1.15.1

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/329 ---

[GitHub] madlib pull request #325: Madpack/ic func schema

2018-10-04 Thread orhankislal
Github user orhankislal closed the pull request at: https://github.com/apache/madlib/pull/325 ---

[GitHub] madlib pull request #330: Margins: Copy summary table instead of renaming

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/330 ---

[GitHub] madlib pull request #330: Margins: Copy summary table instead of renaming

2018-10-03 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/330#discussion_r222415826 --- Diff: src/ports/postgres/modules/regress/marginal.py_in --- @@ -522,9 +520,8 @@ def margins_mlogregr(schema_madlib, source_table, out_table,

[GitHub] madlib pull request #330: Margins: Copy summary table instead of renaming

2018-10-03 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/330#discussion_r222418291 --- Diff: src/ports/postgres/modules/regress/marginal.py_in --- @@ -522,9 +520,8 @@ def margins_mlogregr(schema_madlib, source_table, out_table,

[GitHub] madlib pull request #330: Margins: Copy summary table instead of renaming

2018-10-03 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/330 Margins: Copy summary table instead of renaming JIRA: MADLIB-1274 Margins summary table gets dropped since its schema remains pg_temp. This commit fixed the issue by copying the

[GitHub] madlib pull request #327: Upgrade: Fix issue with upgrading RPM to 1.15.1

2018-10-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/327 ---

[GitHub] madlib pull request #328: Graph: Add id of nodes with 0 in-degree

2018-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/328 ---

[GitHub] madlib pull request #326: Install/Dev check: Add new test cases for some mod...

2018-10-02 Thread njayaram2
Github user njayaram2 closed the pull request at: https://github.com/apache/madlib/pull/326 ---

[GitHub] madlib pull request #327: Upgrade: Fix issue with upgrading RPM to 1.15.1

2018-10-01 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/327 Upgrade: Fix issue with upgrading RPM to 1.15.1 JIRA: MADLIB-1278 During RPM upgrade, rpm_post.sh is run first, followed by rpm_post_uninstall.sh. So we must do all the uninstallation

[GitHub] madlib pull request #326: Install/Dev check: Add new test cases for some mod...

2018-10-01 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/326#discussion_r221714858 --- Diff: src/ports/postgres/modules/pmml/test/pmml.ic.sql_in --- @@ -0,0 +1,119 @@ +/*

[GitHub] madlib pull request #326: Install/Dev check: Add new test cases for some mod...

2018-10-01 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/326#discussion_r221712133 --- Diff: methods/stemmer/src/pg_gp/test/porter_stemmer.sql_in --- @@ -0,0 +1,38 @@ +/*

[GitHub] madlib pull request #326: Install/Dev check: Add new test cases for some mod...

2018-10-01 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/326 Install/Dev check: Add new test cases for some modules Some modules such as array_ops and pmml did not have any install check files, while stemmer did not have any test files. This commit adds

[GitHub] madlib pull request #325: Madpack/ic func schema

2018-09-27 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/325 Madpack/ic func schema IC/DC was prone to failure if the user were creating tables in the madlib schema. This commit fixes the potential issue by removing the madlib from the search path

[GitHub] madlib pull request #324: Madpack/ic func schema

2018-09-27 Thread orhankislal
Github user orhankislal closed the pull request at: https://github.com/apache/madlib/pull/324 ---

[GitHub] madlib pull request #324: Madpack/ic func schema

2018-09-27 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/324 Madpack/ic func schema IC/DC was prone to failure if the user were creating tables in the madlib schema. This commit fixes the potential issue by removing the madlib from the search path

[GitHub] madlib pull request #322: Madpack devcheck schema

2018-09-27 Thread orhankislal
Github user orhankislal closed the pull request at: https://github.com/apache/madlib/pull/322 ---

[GitHub] madlib pull request #323: Build: Add single quote while setting AppendOnly g...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/323 ---

[GitHub] madlib pull request #323: Build: Add single quote while setting AppendOnly g...

2018-09-24 Thread jingyimei
GitHub user jingyimei opened a pull request: https://github.com/apache/madlib/pull/323 Build: Add single quote while setting AppendOnly guc Commit 3db98babe3326fb5e2cd16d0639a2bef264f4b04 added a context manager for setting appendonly to false for all madlib modules. The commit

[GitHub] madlib pull request #322: Madpack devcheck schema

2018-09-24 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/322 Madpack devcheck schema You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib madpack-devcheck-schema Alternatively you can review

[GitHub] madlib pull request #321: RF: Increase the dataset size of dev-check test

2018-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/321 ---

[GitHub] madlib pull request #321: RF: Increase the dataset size of dev-check test

2018-09-21 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/321 RF: Increase the dataset size of dev-check test You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib rf-devc-fix Alternatively

[GitHub] madlib pull request #319: Allocator: Remove 16-byte alignment for pointers i...

2018-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/319 ---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/320 ---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread d
Github user d commented on a diff in the pull request: https://github.com/apache/madlib/pull/320#discussion_r218152329 --- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake --- @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/318 ---

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-16 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217953051 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,239 @@ +#!/usr/bin/python +#

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-14 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217842978 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,239 @@ +#!/usr/bin/python +#

[GitHub] madlib pull request #316: Build: Disable AppendOnly if available

2018-09-13 Thread reductionista
Github user reductionista commented on a diff in the pull request: https://github.com/apache/madlib/pull/316#discussion_r217537741 --- Diff: src/ports/postgres/modules/utilities/control.py_in --- @@ -158,6 +159,61 @@ class MinWarning(ContextDecorator):

[GitHub] madlib pull request #319: Allocator: Remove 16-byte alignment for pointers i...

2018-09-13 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/319#discussion_r217520030 --- Diff: src/ports/greenplum/dbconnector/dbconnector.hpp --- @@ -32,6 +32,24 @@ extern "C" { #include "Compatibility.hpp" +#if

[GitHub] madlib pull request #319: Allocator: Remove 16-byte alignment for pointers i...

2018-09-13 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/319#discussion_r217498702 --- Diff: src/ports/greenplum/dbconnector/dbconnector.hpp --- @@ -32,6 +32,24 @@ extern "C" { #include "Compatibility.hpp" +#if

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-13 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/320#discussion_r217489096 --- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake --- @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)

[GitHub] madlib pull request #316: Build: Disable AppendOnly if available

2018-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/316 ---

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-13 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217361584 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/python +#

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-12 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/320#discussion_r217260823 --- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake --- @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)

[GitHub] madlib pull request #316: Build: Disable AppendOnly if available

2018-09-12 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/316#discussion_r217260530 --- Diff: src/ports/postgres/modules/utilities/control.py_in --- @@ -158,6 +159,61 @@ class MinWarning(ContextDecorator):

[GitHub] madlib pull request #316: Build: Disable AppendOnly if available

2018-09-12 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/316#discussion_r217260262 --- Diff: src/ports/postgres/modules/utilities/control.py_in --- @@ -158,6 +159,61 @@ class MinWarning(ContextDecorator):

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-12 Thread d
GitHub user d opened a pull request: https://github.com/apache/madlib/pull/320 Fix false positive for Postgres 10+ We used to mistake 9.3.24 as a higher version than Postgres 10 and stop matching it to the correct "port". This patch fixes that. You can merge this pull request

[GitHub] madlib pull request #319: Allocator: Remove 16-byte alignment for pointers i...

2018-09-12 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/319 Allocator: Remove 16-byte alignment for pointers in GP6 Findings: 1. MADlib performs a 16-byte alignment for pointers returned by palloc. 2. Postgres prepends a small (16 byte usually) header

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-12 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217152555 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/python +#

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-12 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217143101 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/python +#

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-10 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r216443402 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,132 @@ +#!/usr/bin/python +#

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-10 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r216438294 --- Diff: src/madpack/diff_udf.sql --- @@ -142,9 +142,12 @@ DROP TABLE IF EXISTS functions_madlib_new_version; SELECT

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/315 ---

[GitHub] madlib pull request #317: Fixed trailing whitespace in many sql_in files

2018-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/317 ---

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215464110 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread fmcquillan99
Github user fmcquillan99 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215462116 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215149356 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215149235 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -264,12 +260,17 @@ def knn(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215148966 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215148640 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name,

[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/313 ---

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-04 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/318 Madpack: Add a script for automating changelist creation You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214485090 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214487281 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214484071 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214485621 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214487426 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214482318 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -264,12 +260,17 @@ def knn(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214415305 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -122,5 +122,13 @@ select

  1   2   3   4   5   6   7   >