[jira] [Commented] (MESOS-1181) Improve cpplint rule coverage

2014-04-09 Thread Bernd Mathiske (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963937#comment-13963937 ] Bernd Mathiske commented on MESOS-1181: --- Here is an idea to enable runtime/explicit.

Re: Mesos Wire Protocol Documentation

2014-04-09 Thread Vladimir Vivien
Ben, Thank you for clarifying. I thought the low-level api being referred in the video had to do with communication between master and framework|executor for scheduling. But, it's really administrative. I thought that would have been an opportunity for a Go binding that did not require the C++

Re: Mesos Wire Protocol Documentation

2014-04-09 Thread Kevin Lyda
On Wed, Apr 9, 2014 at 11:39 AM, Vladimir Vivien vladimir.viv...@gmail.com wrote: Thank you for clarifying. I thought the low-level api being referred in the video had to do with communication between master and framework|executor for scheduling. But, it's really administrative. I thought

Re: Mesos Wire Protocol Documentation

2014-04-09 Thread Vladimir Vivien
@Kevin, Yes, Go binding is pure go, but requires the C library which handles the logic/communication with master etc. Similar approach with the Java binding (and probably the Python one). Nevertheless, it works. On Wed, Apr 9, 2014 at 7:18 AM, Kevin Lyda ke...@ie.suberic.net wrote: On Wed,

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-09 Thread Ritwik Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20106/#review39876 --- Ship it! Ship It! - Ritwik Yadav On April 8, 2014, 10:09 p.m.,

Re: Review Request 20140: Updated killTask to only send TASK_LOST when a strict registry is in use.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20140/#review39879 --- Patch looks great! Reviews applied: [20140] All tests passed. -

Re: Mesos Wire Protocol Documentation

2014-04-09 Thread Kevin Lyda
I assume the C library for communication is part of Mesos. Sadly the RPC part of protobufs is not widely used in the public uses of them. Kevin On Wed, Apr 9, 2014 at 12:37 PM, Vladimir Vivien vladimir.viv...@gmail.com wrote: @Kevin, Yes, Go binding is pure go, but requires the C library which

Re: Review Request 20139: Move OOM log message to appear only on actual OOM

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20139/#review39883 --- Patch looks great! Reviews applied: [20139] All tests passed. -

Review Request 20157: Update to use system version of boost with override option.

2014-04-09 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20157/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1167

[jira] [Commented] (MESOS-1167) Update system check (boost)

2014-04-09 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964199#comment-13964199 ] Timothy St. Clair commented on MESOS-1167: -- https://reviews.apache.org/r/20157/

Re: Review Request 20137: Added cgroups::memory::oom_control and cgroups::memory::listen.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20137/#review39890 --- Patch looks great! Reviews applied: [20137] All tests passed. -

Re: Review Request 20157: Update to use system version of boost with override option.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20157/#review39894 --- Bad patch! Reviews applied: [20157] Failed command: git apply

Re: Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/#review39896 --- Bad patch! Reviews applied: [20026] Failed command: git apply

Re: Review Request 20157: Update to use system version of boost with override option.

2014-04-09 Thread Timothy St. Clair
On April 9, 2014, 3:47 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [20157] Failed command: git apply --index 20157.patch Error: error: cannot apply binary patch to '3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz' without full index line error:

[GitHub] mesos pull request: Update mesos-frameworks.md

2014-04-09 Thread grandlogic
GitHub user grandlogic opened a pull request: https://github.com/apache/mesos/pull/13 Update mesos-frameworks.md Added JobServer to the list of job schedulers that are implemented as Mesos Framework. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] mesos pull request: Update mesos-frameworks.md

2014-04-09 Thread grandlogic
Github user grandlogic commented on the pull request: https://github.com/apache/mesos/pull/13#issuecomment-39927070 Added JobServer to list of batch scheduler implemented as Mesos Framework. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Review Request 20137: Added cgroups::memory::oom_control and cgroups::memory::listen.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20137/#review39898 --- src/linux/cgroups.cpp

[jira] [Created] (MESOS-1202) Make it easy to apply GitHub pull requests

2014-04-09 Thread Vinod Kone (JIRA)
Vinod Kone created MESOS-1202: - Summary: Make it easy to apply GitHub pull requests Key: MESOS-1202 URL: https://issues.apache.org/jira/browse/MESOS-1202 Project: Mesos Issue Type: Bug

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/ --- (Updated April 9, 2014, 10:05 a.m.) Review request for mesos, Benjamin Hindman

[GitHub] mesos pull request: Update mesos-frameworks.md

2014-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/mesos/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 20157: Update to use system version of boost with override option.

2014-04-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20157/#review39910 --- Hey Tim, my understanding was that we would have the default

Review Request 20015: Added history to metrics library.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs:

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-09 Thread Ben Mahler
On April 9, 2014, 11:42 a.m., Ritwik Yadav wrote: Ship It! Ritwik Yadav wrote: I am sorry for this message. I haven't used Review Board before and I thought Ship It! message was analogous to LGTM and if I clicked on the Ship It! button it would push the changes. Apparently, it

Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.

2014-04-09 Thread Ben Mahler
On April 9, 2014, 11:42 a.m., Ritwik Yadav wrote: Ship It! Ritwik Yadav wrote: I am sorry for this message. I haven't used Review Board before and I thought Ship It! message was analogous to LGTM and if I clicked on the Ship It! button it would push the changes. Apparently, it

[jira] [Updated] (MESOS-1160) Support flattening from Try into Future.

2014-04-09 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1160: --- Description: We should consider adding support for constructing a FutureT from a TryT, the

Re: Review Request 20015: Added history to metrics library.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/#review39916 --- Bad patch! Reviews applied: [18718, 20015] Failed command: git

Re: Mesos Wire Protocol Documentation

2014-04-09 Thread Benjamin Mahler
I thought the low-level api being referred in the video had to do with communication between master and framework|executor for scheduling. But, it's really administrative. I thought that would have been an opportunity for a Go binding that did not require the C++ libraries. Vladimir, the

Re: Review Request 20047: Reused statistics for calculating statistics from TimeSeries.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20047/ --- (Updated April 9, 2014, 11:01 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 20157: Update to use system version of boost with override option.

2014-04-09 Thread Timothy St. Clair
On April 9, 2014, 5:40 p.m., Ben Mahler wrote: Hey Tim, my understanding was that we would have the default configuration build against the bundled 3rd party libraries only. For those interested in building packages, we would provide the optional ability to build against system

[jira] [Resolved] (MESOS-682) Master should properly consolidate slaves and deactivated maps

2014-04-09 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler resolved MESOS-682. --- Resolution: Fixed Ok, reading closely through what happened here, this situation will be

Re: Review Request 20015: Added history to metrics library.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/#review39919 --- Bad patch! Reviews applied: [18718, 20015] Failed command: make

Re: Review Request 20157: Update to use system version of boost with override option.

2014-04-09 Thread Ben Mahler
On April 9, 2014, 5:40 p.m., Ben Mahler wrote: Hey Tim, my understanding was that we would have the default configuration build against the bundled 3rd party libraries only. For those interested in building packages, we would provide the optional ability to build against system

Re: Review Request 20015: Added history to metrics library.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/ --- (Updated April 9, 2014, 11:15 a.m.) Review request for mesos, Benjamin

Re: Mesos Wire Protocol Documentation

2014-04-09 Thread Vetoshkin Nikita
BTW, there is also somehow related ticket https://issues.apache.org/jira/browse/MESOS-930 On Wed, Apr 9, 2014 at 9:54 PM, Benjamin Mahler benjamin.mah...@gmail.comwrote: I thought the low-level api being referred in the video had to do with communication between master and

Review Request 20173: Mesos-1202: Make it easy to apply GitHub pull requests

2014-04-09 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20173/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1202

Re: Review Request 20015: Added history to metrics library.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/#review39923 --- Patch looks great! Reviews applied: [18718, 20015] All tests

[jira] [Assigned] (MESOS-1202) Make it easy to apply GitHub pull requests

2014-04-09 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned MESOS-1202: --- Assignee: Jake Farrell Make it easy to apply GitHub pull requests

Re: Review Request 20173: Mesos-1202: Make it easy to apply GitHub pull requests

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20173/#review39922 --- If you haven't already, can you test this with both RB and GH

[jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964553#comment-13964553 ] Timothy St. Clair commented on MESOS-1199: -- [~bmahler] I put a tink-toy example

[jira] [Comment Edited] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964553#comment-13964553 ] Timothy St. Clair edited comment on MESOS-1199 at 4/9/14 7:06 PM:

Review Request 20018: Added statistics to Metrics

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs:

[jira] [Commented] (MESOS-1036) Implement a library for exposing statistical metrics.

2014-04-09 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964570#comment-13964570 ] Dominic Hamon commented on MESOS-1036: -- Statistical bits added in

[jira] [Updated] (MESOS-982) Relax slave (re-)registration retries and add a backoff mechanism.

2014-04-09 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-982: - Assignee: Yan Xu (was: Vinod Kone) Relax slave (re-)registration retries and add a backoff mechanism.

[jira] [Comment Edited] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964553#comment-13964553 ] Timothy St. Clair edited comment on MESOS-1199 at 4/9/14 7:35 PM:

[jira] [Commented] (MESOS-1181) Improve cpplint rule coverage

2014-04-09 Thread Adam B (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964585#comment-13964585 ] Adam B commented on MESOS-1181: --- Specifically, {{// NOLINT(runtime/explicit)}} so we still

Re: Review Request 20018: Added statistics to Metrics

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/#review39925 --- Bad patch! Reviews applied: [18718, 20015, 20018] Failed command:

Re: Review Request 19982: Adjusted constructors of net::IP and net::MAC.

2014-04-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19982/ --- (Updated April 9, 2014, 7:42 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 20127: Made os::system async signal safe.

2014-04-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20127/ --- (Updated April 9, 2014, 7:43 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 20018: Added statistics to Metrics.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/ --- (Updated April 9, 2014, 12:43 p.m.) Review request for mesos, Benjamin

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review39921 --- I would like us to further explore removing the explicit 'add' and

Re: Review Request 20141: Added containerizer.proto.

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20141/#review39926 --- src/Makefile.am https://reviews.apache.org/r/20141/#comment72693

Re: Review Request 20137: Added cgroups::memory::oom_control and cgroups::memory::listen.

2014-04-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20137/#review39927 --- src/linux/cgroups.hpp

Review Request 20178: Using implicit flattening to create Future objects from Try objects.

2014-04-09 Thread Ritwik Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20178/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1160

[jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964654#comment-13964654 ] Timothy St. Clair commented on MESOS-1199: -- Raw pipes fail in the case of parent

[jira] [Comment Edited] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964654#comment-13964654 ] Timothy St. Clair edited comment on MESOS-1199 at 4/9/14 9:02 PM:

[jira] [Comment Edited] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964654#comment-13964654 ] Timothy St. Clair edited comment on MESOS-1199 at 4/9/14 9:02 PM:

Review Request 20179: Added test for slave stopping before containerizer launches.

2014-04-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20179/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos-git

[jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964674#comment-13964674 ] Ian Downes commented on MESOS-1199: --- [~vinodkone] It likely can be reduced

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/ --- (Updated April 9, 2014, 2:30 p.m.) Review request for mesos, Benjamin Hindman

[jira] [Updated] (MESOS-982) Relax slave (re-)registration retries and add a backoff mechanism.

2014-04-09 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu updated MESOS-982: - Description: Slaves will currently retry registration every 1 second, until registration succeeds. We should

Re: Review Request 19982: Adjusted constructors of net::IP and net::MAC.

2014-04-09 Thread Jie Yu
On April 9, 2014, 9:32 p.m., Vinod Kone wrote: Just to be sure, this new IP address format is not being used by libprocess yet? Yes, it's only used by the routing library. I will cleanup libprocess/mesos later as it's a bug (tracked in https://issues.apache.org/jira/browse/MESOS-1201).

[jira] [Commented] (MESOS-982) Relax slave (re-)registration retries and add a backoff mechanism.

2014-04-09 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964695#comment-13964695 ] Yan Xu commented on MESOS-982: -- It appears that this has become an independent improvement

Re: Review Request 20179: Added test for slave stopping before containerizer launches.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20179/#review39936 --- Patch looks great! Reviews applied: [20179] All tests passed. -

Re: Review Request 20127: Made os::system async signal safe.

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20127/#review39935 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 20127: Made os::system async signal safe.

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20127/#review39939 --- Also attach the bug? - Vinod Kone On April 9, 2014, 7:43 p.m.,

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Dominic Hamon
On April 9, 2014, 1:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/include/process/metrics/metric.hpp, line 15 https://reviews.apache.org/r/18718/diff/21/?file=553931#file553931line15 Have you considered just calling this 'value'? Snapshot sounds a bit opaque as to what this

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/ --- (Updated April 9, 2014, 2:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 20119: Updated policy for building against system dependencies.

2014-04-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20119/#review39943 --- Here are the three uses cases I see being addressed here: (1) Use

Re: Review Request 19951: Change cgroups::assign to assign all threads.

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19951/#review39948 --- Ship it! Ian, can you commit this? src/tests/cgroups_tests.cpp

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Ben Mahler
On April 9, 2014, 8:02 p.m., Ben Mahler wrote: I would like us to further explore removing the explicit 'add' and 'remove' functions, as it would provide a huge benefit to users of Metrics. They would no longer need to manually manage lifecycle of the Metrics. Is there a concrete use

Re: Review Request 20119: Updated policy for building against system dependencies.

2014-04-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20119/#review39944 --- Ship it! I think this is a good semantics for now even if we

Re: Review Request 20178: Using implicit flattening to create Future objects from Try objects.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20178/#review39954 --- Patch looks great! Reviews applied: [20178] All tests passed. -

Re: Review Request 19857: Consolidated slave re-registration Timers into a single Timer.

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19857/#review39953 --- src/master/master.hpp

[jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964755#comment-13964755 ] Benjamin Mahler commented on MESOS-1199: [~tknaup] can you run {{perf top}} on the

[jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964768#comment-13964768 ] Tobi Knaup commented on MESOS-1199: --- [~bmahler] here you go:

Re: Review Request 19007: Added log implementation for state storage.

2014-04-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19007/#review39958 --- Ship it! src/state/log.cpp

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/#review39956 --- Ship it! src/master/constants.hpp

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/ --- (Updated April 9, 2014, 4:16 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Dominic Hamon
On April 9, 2014, 1:02 p.m., Ben Mahler wrote: I would like us to further explore removing the explicit 'add' and 'remove' functions, as it would provide a huge benefit to users of Metrics. They would no longer need to manually manage lifecycle of the Metrics. Is there a concrete use

Re: [VOTE] Release Apache Mesos 0.18.0 (rc6)

2014-04-09 Thread Vinod Kone
Till might have better context but I think this is related to https://issues.apache.org/jira/browse/MESOS-799. On Wed, Apr 2, 2014 at 11:21 AM, Ross Allen r...@mesosphere.io wrote: I haven't tried building one of these packages before, and I ran into an issue with Python when configuring the

Re: Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-09 Thread Vinod Kone
On April 9, 2014, 11:28 p.m., Vinod Kone wrote: This review looks like it could really use a split, one for the api change and one for clone? also re-add the depends on to make reviewbot happy. i hate that post-review auto removes the field on review updates :( couldn't figure out a fix

Re: Review Request 20178: Using implicit flattening to create Future objects from Try objects.

2014-04-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20178/#review39965 --- Ship it! I will clean up the indentation for you!

[jira] [Resolved] (MESOS-1160) Support flattening from Try into Future.

2014-04-09 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler resolved MESOS-1160. Resolution: Fixed Fix Version/s: 0.19.0 Assignee: Ritwik Yadav {noformat}

Re: [jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Benjamin Mahler
Ian, process::reap always uses waitpid() as we didn't implement the thread-per-pid wait() optimization. On Wed, Apr 9, 2014 at 4:41 PM, Ian Downes (JIRA) j...@apache.org wrote: [

Re: [jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Ian Downes
Sorry, I wasn't clear. Yes, waitpid() is always called with WNOHANG but if the caller is not the parent (i.e., slave restart) waitpid returns and errno is set to ECHILD. The code then tries to construct the Process object for the pid to determine if it's still running. It's this part that I'm

Re: Review Request 20018: Added statistics to Metrics.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/#review39967 --- Bad patch! Reviews applied: [18718, 20015] Failed command: git

Re: Review Request 18718: Added simple metrics API.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/ --- (Updated April 9, 2014, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 20015: Added history to metrics library.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/ --- (Updated April 9, 2014, 5:17 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 20015: Added history to metrics library.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/ --- (Updated April 9, 2014, 5:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 20018: Added statistics to Metrics.

2014-04-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/ --- (Updated April 9, 2014, 5:31 p.m.) Review request for mesos, Benjamin Hindman,

[RESULT] [VOTE] Release Apache Mesos 0.18.0 (rc6)

2014-04-09 Thread Vinod Kone
Hi all, The vote for Mesos 0.18.0 (rc6) has passed with the following votes. +1 (Binding) -- Niklas Neilsen Brenden Matthews Jie Yu +1 (Non-binding) -- Till Toenshoff Adam Bordelon Tim St Clair There were no 0 or -1 votes. Please find

Re: Review Request 20052: Replace CHECK with Failure for exec in MesosContainerizer

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20052/#review39970 --- Ship it! Ship it modulo adding a comment per benh. - Vinod Kone

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2052

2014-04-09 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2052/changes Changes: [bmahler] Used implicit Try - Future flattening in the Slave. -- [...truncated 28454 lines...] I0410 01:20:56.474951 9459 master.cpp:738]

Re: Review Request 20018: Added statistics to Metrics.

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/#review39974 --- Patch looks great! Reviews applied: [18718, 20015, 20018] All

Re: Review Request 20173: Mesos-1202: Make it easy to apply GitHub pull requests

2014-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20173/#review39976 --- Patch looks great! Reviews applied: [20173] All tests passed. -

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2053

2014-04-09 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2053/changes

Re: Review Request 20173: Mesos-1202: Make it easy to apply GitHub pull requests

2014-04-09 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20173/ --- (Updated April 10, 2014, 3:31 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 20070: Added 'mesos-usage' for use by external containerizers.

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20070/#review39971 --- Ship it! src/usage/main.cpp

Re: [RESULT] [VOTE] Release Apache Mesos 0.18.0 (rc6)

2014-04-09 Thread Vinod Kone
just in case my previous email from @twitter didn't reach. On Wed, Apr 9, 2014 at 5:44 PM, Vinod Kone vi...@twitter.com wrote: Hi all, The vote for Mesos 0.18.0 (rc6) has passed with the following votes. +1 (Binding) -- Niklas Neilsen Brenden Matthews Jie

Re: Review Request 20173: Mesos-1202: Make it easy to apply GitHub pull requests

2014-04-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20173/#review39980 --- support/apply-review.sh

  1   2   >