---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/
---
Review request for mesos.
Repository: mesos-git
Description
---
I
[
https://issues.apache.org/jira/browse/MESOS-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930007#comment-13930007
]
Archana kumari commented on MESOS-1076:
---
I am trying to upload a patch for this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/#review36762
---
Patch looks great!
Reviews applied: [18966]
All tests passed.
-
On March 11, 2014, 7:14 a.m., Mesos ReviewBot wrote:
Patch looks great!
Reviews applied: [18966]
All tests passed.
So should I ship it now?
- Archana
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19024/
---
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19024/#review36766
---
Bad patch!
Reviews applied: [19024]
Failed command: make -j3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19024/
---
(Updated March 11, 2014, 9:37 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19024/#review36768
---
Bad patch!
Reviews applied: [19024]
Failed command: make -j3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/
---
(Updated March 11, 2014, 12:32 p.m.)
Review request for mesos, Adam B, Ben
On March 10, 2014, 9:06 p.m., Timothy St. Clair wrote:
So I looked over the patch, and it appears there will be a new install
target but it doesn't appear to be shared or versioned?
e.g. (no) -version-info 0:0:0 -release $(PACKAGE_VERSION) -shared
Is there a reason?
Clear
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/
---
(Updated March 11, 2014, 12:42 p.m.)
Review request for mesos, Adam B, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/
---
(Updated March 11, 2014, 12:48 p.m.)
Review request for mesos, Adam B, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/#review36779
---
Patch looks great!
Reviews applied: [18946]
All tests passed.
-
Hi,
I met an error while installing mesos. When I run 'make' command, it shows:
make[2]: ../3rdparty/libprocess/3rdparty/protobuf-2.4.1/src/protoc: Command not
found
make[2]: ***
[../3rdparty/libprocess/3rdparty/protobuf-2.4.1/src/google/protobuf/descriptor.pb.h]
Error 127
make[2]: Leaving
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930445#comment-13930445
]
Timothy St. Clair commented on MESOS-1031:
--
On [~bmahler]'s suggestion I looked
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930445#comment-13930445
]
Timothy St. Clair edited comment on MESOS-1031 at 3/11/14 3:18 PM:
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930473#comment-13930473
]
Niklas Quarfot Nielsen commented on MESOS-1031:
---
Only using the process
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/#review36782
---
Ship it!
Ship It!
- Niklas Nielsen
On March 11, 2014, 5:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19024/
---
(Updated March 11, 2014, 3:45 p.m.)
Review request for mesos, Benjamin
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930475#comment-13930475
]
Timothy St. Clair commented on MESOS-1031:
--
That's why I mentioned PID
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19024/#review36783
---
Bad patch!
Reviews applied: [19024]
Failed command: make -j3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/#review36785
---
Ship it!
Ship It!
- Timothy St. Clair
On March 11, 2014, 12:48
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930495#comment-13930495
]
Niklas Quarfot Nielsen commented on MESOS-1031:
---
Really like namespaces. We
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/#review36793
---
src/slave/containerizer/isolators/cgroups/cpushare.cpp
[
https://issues.apache.org/jira/browse/MESOS-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930551#comment-13930551
]
Timothy St. Clair commented on MESOS-1076:
--
Did you run:
On March 11, 2014, 12:14 a.m., Mesos ReviewBot wrote:
Patch looks great!
Reviews applied: [18966]
All tests passed.
Archana kumari wrote:
So should I ship it now?
Ship its are given by your reviewers :) A project member will commit the patch
when it is ready:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19009/#review36794
---
src/state/in_memory.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19008/#review36796
---
Ship it!
Ship It!
- Dominic Hamon
On March 10, 2014, 8:44 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/#review36797
---
Ship it!
Modulo Dominic's comment.
- Niklas Nielsen
On March
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930565#comment-13930565
]
Timothy St. Clair commented on MESOS-1031:
--
What *deployment platforms* are you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/#review36800
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19009/#review36801
---
src/state/in_memory.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19007/#review36798
---
src/state/log.cpp
https://reviews.apache.org/r/19007/#comment67989
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19003/#review36802
---
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
Can you tell us your setup (OS, gcc version) and all the commands you used
to run the build?
On Tue, Mar 11, 2014 at 7:45 AM, HUO Jing huoj...@ihep.ac.cn wrote:
Hi,
I met an error while installing mesos. When I run 'make' command, it shows:
make[2]:
[
https://issues.apache.org/jira/browse/MESOS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930578#comment-13930578
]
Bernd Mathiske commented on MESOS-1055:
---
https://reviews.apache.org/r/18823/
Add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/
---
(Updated March 11, 2014, 4:59 p.m.)
Review request for mesos and Vinod Kone.
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930586#comment-13930586
]
Niklas Quarfot Nielsen commented on MESOS-1031:
---
I was referring to Mac OS X
Till Toenshoff created MESOS-1079:
-
Summary: Mesos python egg build failure on OS X Mavericks (Xcode
5.1)
Key: MESOS-1079
URL: https://issues.apache.org/jira/browse/MESOS-1079
Project: Mesos
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930678#comment-13930678
]
Timothy St. Clair commented on MESOS-1031:
--
+1 I think as long as there is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/#review36820
---
src/slave/containerizer/isolators/cgroups/cpushare.cpp
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930678#comment-13930678
]
Timothy St. Clair edited comment on MESOS-1031 at 3/11/14 6:06 PM:
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930678#comment-13930678
]
Timothy St. Clair edited comment on MESOS-1031 at 3/11/14 6:17 PM:
[
https://issues.apache.org/jira/browse/MESOS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930707#comment-13930707
]
Till Toenshoff commented on MESOS-1079:
---
Some more information on this subject.
On March 11, 2014, 4:43 p.m., Dominic Hamon wrote:
src/state/in_memory.cpp, line 65
https://reviews.apache.org/r/19009/diff/1/?file=515967#file515967line65
why convert from hashset to vector?
As opposed to? The Storage interface is defined to return a vector for names()
(see
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19009/
---
(Updated March 11, 2014, 6:28 p.m.)
Review request for mesos, Benjamin Hindman
On March 11, 2014, 4:51 p.m., Dominic Hamon wrote:
src/state/in_memory.cpp, line 67
https://reviews.apache.org/r/19009/diff/1/?file=515967#file515967line67
s/values/keys/
:)
- Ben
---
This is an automatically generated
[
https://issues.apache.org/jira/browse/MESOS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930757#comment-13930757
]
Timothy St. Clair commented on MESOS-1073:
--
Could you please post a link re:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18718/
---
(Updated March 11, 2014, 11:46 a.m.)
Review request for mesos, Benjamin
[
https://issues.apache.org/jira/browse/MESOS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930760#comment-13930760
]
Dominic Hamon commented on MESOS-1073:
--
Here are the release notes:
Adam B created MESOS-1080:
-
Summary: cpplint.py doesn't analyze hpp files
Key: MESOS-1080
URL: https://issues.apache.org/jira/browse/MESOS-1080
Project: Mesos
Issue Type: Bug
Reporter:
[
https://issues.apache.org/jira/browse/MESOS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930773#comment-13930773
]
Till Toenshoff commented on MESOS-1079:
---
The proper fix here would be that Apple
If you're just loading a .jar then I suppose you are ok, but I'm not sure
if this is a wise design for running arbitrary .jars. You'll be able to
share the JVM overhead but you'll also be sharing the same JVM runtime, is
that well supported?
What happens if both your executor .jar and the task
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
---
Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36826
---
support/cpplint.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
---
(Updated March 11, 2014, 12:15 p.m.)
Review request for mesos, Bernd Mathiske,
[
https://issues.apache.org/jira/browse/MESOS-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930820#comment-13930820
]
Adam B commented on MESOS-1080:
---
Up for review: https://reviews.apache.org/r/19060/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
---
(Updated March 11, 2014, 12:24 p.m.)
Review request for mesos, Bernd Mathiske,
On March 11, 2014, 12:05 p.m., Dominic Hamon wrote:
support/cpplint.py, line 3573
https://reviews.apache.org/r/19060/diff/1/?file=516611#file516611line3573
we should also start putting test sources alongside the sources they
test if we want this method to do anything useful.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36830
---
Patch looks great!
Reviews applied: [19060]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36835
---
I also did chmod a+x for support/mesos-style.py, and it showed up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18718/#review36837
---
Patch looks great!
Reviews applied: [18718]
All tests passed.
-
On March 6, 2014, 4:20 p.m., Benjamin Hindman wrote:
Before I dive too deep into this review, can you give an overview of your
proposed next steps? In particular:
(1) What's the concurrency story here? It appears as though multiple actors
adding or removing metrics could causing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18823/#review36840
---
Ship it!
Looks good to me
include/mesos/resources.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19070/
---
Review request for mesos.
Bugs: MESOS-471
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/
---
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen,
[
https://issues.apache.org/jira/browse/MESOS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930971#comment-13930971
]
Till Toenshoff commented on MESOS-1079:
---
https://reviews.apache.org/r/19068/
Mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review36842
---
src/slave/containerizer/mesos_containerizer.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/
---
(Updated March 11, 2014, 9:36 p.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/
---
(Updated March 11, 2014, 9:38 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19009/#review36845
---
Ship it!
src/state/in_memory.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/#review36847
---
Patch looks great!
Reviews applied: [19068]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/#review36849
---
3rdparty/libprocess/include/process/collect.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19008/#review36851
---
Ship it!
Ship It!
- Benjamin Hindman
On March 11, 2014, 3:44
On March 11, 2014, 6:07 p.m., Ben Mahler wrote:
src/slave/containerizer/isolators/cgroups/cpushare.cpp, lines 60-61
https://reviews.apache.org/r/18966/diff/1/?file=515048#file515048line60
Please be sure to update the places where these are used as well as the
argument type in
Adam B created MESOS-1081:
-
Summary: Master should not deactivate authenticated
framework/slave on new AuthenticateMessage unless new authentication succeeds.
Key: MESOS-1081
URL:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19071/
---
Review request for mesos.
Repository: mesos-git
Description
---
Fixed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19071/
---
(Updated March 11, 2014, 10:19 p.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19071/
---
(Updated March 11, 2014, 10:19 p.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/
---
(Updated March 11, 2014, 3:20 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/
---
(Updated March 11, 2014, 10:28 p.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/#review36857
---
src/linux/cgroups.hpp
On March 11, 2014, 1:26 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/include/process/collect.hpp, lines 43-48
https://reviews.apache.org/r/18311/diff/5/?file=506398#file506398line43
After the inclusion of Future::after I'm not sure that this will be as
useful since if you've
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/
---
(Updated March 11, 2014, 10:35 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19072/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-764
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/
---
(Updated March 11, 2014, 10:36 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19073/
---
Review request for mesos.
Repository: mesos-git
Description
---
Fixed a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19077/
---
Review request for mesos, Till Toenshoff and Vinod Kone.
Bugs: MESOS-750
On March 11, 2014, 10:29 p.m., Dominic Hamon wrote:
src/linux/cgroups.hpp, line 405
https://reviews.apache.org/r/18966/diff/3/?file=516748#file516748line405
there's almost certainly a cgroups.cpp change missing here.
what kind of change are you hinting towards
- Archana
On March 11, 2014, 10:29 p.m., Dominic Hamon wrote:
src/linux/cgroups.hpp, line 405
https://reviews.apache.org/r/18966/diff/3/?file=516748#file516748line405
there's almost certainly a cgroups.cpp change missing here.
Archana kumari wrote:
what kind of change are you hinting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19077/
---
(Updated March 11, 2014, 4 p.m.)
Review request for mesos, Till Toenshoff and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/
---
(Updated March 12, 2014, 12:56 a.m.)
Review request for mesos and Vinod Kone.
hi vinod/till
i am not setting any aliases for this option.
i thought i was using clang, but i may be wrong, in which case the os must
be implicitly picking up the gcc-4.8 that i manually installed on
mavericks. i went through several iterations of trying to build, so i may
have changed stuff on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/#review36869
---
Ship it!
Ship It!
- Dominic Hamon
On March 11, 2014, 4:05 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/#review36894
---
Patch looks great!
Reviews applied: [18946]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18381/
---
(Updated March 11, 2014, 6:51 p.m.)
Review request for mesos and Vinod Kone.
On March 6, 2014, 4:07 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 2485-2486
https://reviews.apache.org/r/18381/diff/2/?file=511057#file511057line2485
Good point. If someone can spoof the pid in the authenticate message
then it might deactivate a legitimate framework.
[
https://issues.apache.org/jira/browse/MESOS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yan Xu updated MESOS-1083:
--
Description:
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36882
---
Looks good. I wonder if a more explicit dependency documentation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19085/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-764
1 - 100 of 133 matches
Mail list logo
