Re: golang binding, mesos-go -- approach?

2014-12-19 Thread Vladimir Vivien
Hi Bala, There's not a separate mailing list as of yet. There's plenty of documentation on the project's site ( http://github.com/mesos/mesos-go). If you run into trouble, you can create a github issue. If you have specific question regarding usage of the binding, post here for now (or reach out

Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Dave Lester
Hi All, To push forward one portion of the conversation re: Mesos extension hosting and a shared registry (MESOS-1759 https://issues.apache.org/jira/browse/MESOS-1759), I'd like to suggest that we begin using the existing Mesos GitHub org (https://github.com/mesos/) for community frameworks and

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Dec. 19, 2014, 6:22 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Till Toenshoff
On Dec. 18, 2014, 2:43 a.m., Adam B wrote: src/authentication/authenticator.hpp, line 59 https://reviews.apache.org/r/27760/diff/7/?file=766647#file766647line59 Do we really want to reference the 'master' here? Authenticator could conceivably be used by anything that wants to

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Till Toenshoff
On Dec. 6, 2014, 12:05 a.m., Niklas Nielsen wrote: src/authentication/cram_md5/authenticator.hpp, line 22 https://reviews.apache.org/r/27760/diff/7/?file=766648#file766648line22 Why was this not a problem before? I don't see size_t in your review elsewhere? size_t is being used

Re: Review Request 28723: Added protobuf protocol for communicating persisted resources between master and slave.

2014-12-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28723/ --- (Updated Dec. 19, 2014, 6:39 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 28723: Added protobuf protocol for communicating persisted resources between master and slave.

2014-12-19 Thread Jie Yu
On Dec. 18, 2014, 2:36 a.m., Ben Mahler wrote: src/messages/messages.proto, lines 270-273 https://reviews.apache.org/r/28723/diff/1/?file=782815#file782815line270 Hm.. could you add some design description to this review or the ticket? I can't remember why we'd want to

Re: Review Request 28723: Added protobuf protocol for communicating persisted resources between master and slave.

2014-12-19 Thread Jie Yu
On Dec. 19, 2014, 1:42 a.m., Ben Mahler wrote: src/messages/messages.proto, lines 248-251 https://reviews.apache.org/r/28723/diff/1/?file=782815#file782815line248 Per our discussion, we should probably call out that these are resources that must be explicitly released by the

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review65649 --- Patch looks great! Reviews applied: [27760] All tests passed. -

Re: Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Adam Bordelon
Great idea. I have been suggesting this to others when appropriate. It's also worth pointing out the successful history of the Mesos GitHub org: Spark's pre-incubator github home was https://github.com/mesos/spark Your project could be next! On Fri, Dec 19, 2014 at 10:17 AM, Dave Lester

Re: Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Dominic Hamon
I think this is a reasonable start, but I'm not sure if you're suggesting we make the mesos org the home for the community frameworks/modules, or that we will maintain forks of those frameworks and modules in the mesos org. On Fri, Dec 19, 2014 at 10:17 AM, Dave Lester daveles...@gmail.com wrote:

Re: Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Dave Lester
I'd suggest making the GH org home to community frameworks/modules. On Fri, Dec 19, 2014 at 11:04 AM, Dominic Hamon dha...@twopensource.com wrote: I think this is a reasonable start, but I'm not sure if you're suggesting we make the mesos org the home for the community frameworks/modules, or

Re: Review Request 28671: Virtualize Socket Implementation interface.

2014-12-19 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28671/#review65652 --- 3rdparty/libprocess/src/poll_socket.cpp

Re: Review Request 29226: Add construction and conversion from / to timeval for Duration.

2014-12-19 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29226/#review65654 --- 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp

Re: Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Chris Aniszczyk
+1 seems like a simple start and should aid discovery On Fri, Dec 19, 2014 at 1:07 PM, Dave Lester daveles...@gmail.com wrote: I'd suggest making the GH org home to community frameworks/modules. On Fri, Dec 19, 2014 at 11:04 AM, Dominic Hamon dha...@twopensource.com wrote: I think this is

Re: Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Dominic Hamon
That's going to cause issues for any companies that use existing github orgs and have internal restrictions on how they can share their open source work. On Fri, Dec 19, 2014 at 11:07 AM, Dave Lester daveles...@gmail.com wrote: I'd suggest making the GH org home to community frameworks/modules.

Re: Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Chris Aniszczyk
If it's optional I don't see a problem On Fri, Dec 19, 2014 at 1:13 PM, Dominic Hamon dha...@twopensource.com wrote: That's going to cause issues for any companies that use existing github orgs and have internal restrictions on how they can share their open source work. On Fri, Dec 19, 2014

Re: Usage of Mesos GitHub org for community plugins and modules

2014-12-19 Thread Dominic Hamon
Of course it will be optional, any solution should be. But using github org specifically limits the people that can use it. A standalone registry removes the barrier to entry. As I said, it's a great start but deeper thought is probably needed for a final solution. On Fri, Dec 19, 2014 at 11:22

Re: Review Request 28671: Virtualize Socket Implementation interface.

2014-12-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28671/ --- (Updated Dec. 19, 2014, 7:57 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28671: Virtualize Socket Implementation interface.

2014-12-19 Thread Joris Van Remoortere
On Dec. 19, 2014, 7:09 p.m., Dominic Hamon wrote: 3rdparty/libprocess/src/poll_socket.cpp, line 5 https://reviews.apache.org/r/28671/diff/2/?file=796971#file796971line5 relative paths in includes worry me. Please find a way around this. Thanks for catching this. My editor seems to

Re: Review Request 29226: Add construction and conversion from / to timeval for Duration.

2014-12-19 Thread Joris Van Remoortere
On Dec. 19, 2014, 7:11 p.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp, line 93 https://reviews.apache.org/r/29226/diff/1/?file=796956#file796956line93 tv_sec and tv_usec are the right types to use, just in case they're not long int on

Re: Review Request 28697: [WIP] Add ReservationType and ReservationInfo for dynamic reservations.

2014-12-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/#review65670 --- Ship it! This looks good Michael, one thing that I think is

Re: Review Request 28697: [WIP] Add ReservationType and ReservationInfo for dynamic reservations.

2014-12-19 Thread Ben Mahler
On Dec. 19, 2014, 8:23 p.m., Ben Mahler wrote: This looks good Michael, one thing that I think is important to highlight about this approach is that we no longer know the static reservation for a dynamically reserved resource. This is ok for now because a dynamically reserved

Re: Review Request 29226: Add construction and conversion from / to timeval for Duration.

2014-12-19 Thread Dominic Hamon
On Dec. 19, 2014, 11:11 a.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp, line 93 https://reviews.apache.org/r/29226/diff/1/?file=796956#file796956line93 tv_sec and tv_usec are the right types to use, just in case they're not long int on

Re: Review Request 29226: Add construction and conversion from / to timeval for Duration.

2014-12-19 Thread Joris Van Remoortere
On Dec. 19, 2014, 7:11 p.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp, line 93 https://reviews.apache.org/r/29226/diff/1/?file=796956#file796956line93 tv_sec and tv_usec are the right types to use, just in case they're not long int on

Assignment to MESOS-2180/Contributor

2014-12-19 Thread Sheena Artrip
I would like to be added as a mesos contributor so that I may be assigned to JIRA issue https://issues.apache.org/jira/browse/MESOS-2180 Thank you --- Sheena Artrip sheena.art...@gmail.com sheenobu.net 404-641-0482

Re: Review Request 29226: Add construction and conversion from / to timeval for Duration.

2014-12-19 Thread Dominic Hamon
On Dec. 19, 2014, 11:11 a.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp, line 93 https://reviews.apache.org/r/29226/diff/1/?file=796956#file796956line93 tv_sec and tv_usec are the right types to use, just in case they're not long int on

Re: Assignment to MESOS-2180/Contributor

2014-12-19 Thread Timothy Chen
Hi Sheena, Just added you to the contributor list, please try now. Tim On Fri, Dec 19, 2014 at 1:21 PM, Sheena Artrip sheena.art...@gmail.com wrote: I would like to be added as a mesos contributor so that I may be assigned to JIRA issue https://issues.apache.org/jira/browse/MESOS-2180 Thank

Review Request 29270: Fixed syntax of tar command in getting started documentation

2014-12-19 Thread Sheena Artrip
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29270/ --- Review request for mesos. Bugs: MESOS-2180

Re: Assignment to MESOS-2180/Contributor

2014-12-19 Thread Sheena Artrip
Got it. Thank you --- Sheena Artrip sheena.art...@gmail.com sheenobu.net 404-641-0482 On Fri, Dec 19, 2014 at 4:43 PM, Timothy Chen tnac...@gmail.com wrote: Hi Sheena, Just added you to the contributor list, please try now.

Re: Review Request 29219: Added Network Isolator flags to configuration.md.

2014-12-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29219/#review65689 --- Ship it! docs/configuration.md

Re: Review Request 29227: Updated help text for max_executors_per_slave flag for master.

2014-12-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29227/#review65690 --- Ship it! Ship It! - Till Toenshoff On Dec. 19, 2014, 12:55

Re: Review Request 29219: Added Network Isolator flags to configuration.md.

2014-12-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29219/ --- (Updated Dec. 19, 2014, 5:02 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 29173: [WIP] Add dynamic reservation information to LaunchTasksMessage.

2014-12-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29173/#review65679 --- Hey Michael, jie and I went over this and since Jie needs this as

Re: Review Request 29270: Fixed syntax of tar command in getting started documentation

2014-12-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29270/#review65692 --- Patch looks great! Reviews applied: [29270] All tests passed. -

Re: Review Request 29173: [WIP] Add dynamic reservation information to LaunchTasksMessage.

2014-12-19 Thread Jie Yu
On Dec. 19, 2014, 10:13 p.m., Ben Mahler wrote: src/messages/messages.proto, lines 178-179 https://reviews.apache.org/r/29173/diff/1/?file=794998#file794998line178 Jie and I took a look at this API. Here are some thoughts: From your other patches, it looks like

Review Request 29274: Added Resource::Operation to mesos.proto.

2014-12-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29274/ --- Review request for mesos, Ben Mahler and switched to 'mcypark'. Repository:

Re: Review Request 28218: Add more logging into replicated log recovery.

2014-12-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28218/ --- (Updated Dec. 19, 2014, 10:36 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 29219: Added Network Isolator flags to configuration.md.

2014-12-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29219/#review65698 --- Patch looks great! Reviews applied: [29227, 29219] All tests

Re: Review Request 29274: Added Resource::Operation to mesos.proto.

2014-12-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29274/#review65699 --- Ship it! Per your suggestion, mind dropping in the TODOs to remove

Re: Review Request 28218: Add more logging into replicated log recovery.

2014-12-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28218/ --- (Updated Dec. 19, 2014, 11:16 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 28781: Maintained persisted resources in master memory.

2014-12-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28781/#review65702 --- It looks like this patch will change when we make the

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review65703 --- Ship it! Looks great! Just a few more comments/log messages to

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Ben Mahler
On Dec. 19, 2014, 11:21 p.m., Adam B wrote: src/master/master.cpp, lines 3980-3981 https://reviews.apache.org/r/27760/diff/7-8/?file=766650#file766650line3980 We use @param in at least a couple of src/linux/ c++ files, and may do more with doxygen in the future, so how about:

Re: Review Request 29274: Added Resource::Operation to mesos.proto.

2014-12-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29274/#review65709 --- Patch looks great! Reviews applied: [29274] All tests passed. -

Review Request 29283: Moved allocator specific declaration into allocator tests.

2014-12-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29283/ --- Review request for mesos, Adam B and Till Toenshoff. Repository: mesos-git

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Dec. 20, 2014, 12:41 a.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review65710 --- Ship it! Ship It! - Adam B On Dec. 19, 2014, 4:41 p.m., Till

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review65711 --- src/master/master.cpp

Re: Review Request 29283: Moved allocator specific declaration into allocator tests.

2014-12-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29283/#review65712 --- Ship it! Ship It! - Till Toenshoff On Dec. 20, 2014, 12:37

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Till Toenshoff
On Dec. 20, 2014, 12:48 a.m., Ben Mahler wrote: src/master/master.cpp, lines 3922-3923 https://reviews.apache.org/r/27760/diff/9/?file=797824#file797824line3922 I'd hold off on adding these @params, since they don't belong in .cpp files IIUC, and we don't use them generally. This

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Till Toenshoff
On Dec. 19, 2014, 11:21 p.m., Adam B wrote: Looks great! Just a few more comments/log messages to reword. Thanks a bunch for taking care of the proper wording, much appreciated! On Dec. 19, 2014, 11:21 p.m., Adam B wrote: src/master/master.cpp, lines 3980-3981

Re: Review Request 29283: Moved allocator specific declaration into allocator tests.

2014-12-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29283/#review65715 --- Ship it! LGTM. What's the motivation for this change? - Adam B

Re: Review Request 29283: Moved allocator specific declaration into allocator tests.

2014-12-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29283/#review65716 --- Patch looks great! Reviews applied: [29283] All tests passed. -

Re: Review Request 29283: Moved allocator specific declaration into allocator tests.

2014-12-19 Thread Alexander Rukletsov
On Dec. 20, 2014, 1:17 a.m., Adam B wrote: LGTM. What's the motivation for this change? Limit the scope of allocator-related includes. With allocator modules coming soon, allocator tests will require at least modules API and allocator modules. - Alexander

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2014-12-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review65719 --- Patch looks great! Reviews applied: [27760] All tests passed. -

Review Request 29290: Created IP address abstraction for different protocol families

2014-12-19 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29290/ --- Review request for mesos, Ben Mahler and Dominic Hamon. Bugs: MESOS-1919

Re: Review Request 29288: stout: Created IP address abstraction for different protocol families

2014-12-19 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/ --- (Updated Dec. 20, 2014, 3:38 a.m.) Review request for mesos and Dominic Hamon.

Review Request 29288: stout: Created IP address abstraction for different protocol families

2014-12-19 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/ --- Review request for mesos, Ben Mahler and Dominic Hamon. Bugs: MESOS-1919

Review Request 29289: libprocess: Created IP address abstraction for different protocol families

2014-12-19 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/ --- Review request for mesos, Ben Mahler and Dominic Hamon. Bugs: MESOS-1919

Re: Review Request 29289: libprocess: Created IP address abstraction for different protocol families

2014-12-19 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/ --- (Updated Dec. 20, 2014, 3:38 a.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 29290: Created IP address abstraction for different protocol families

2014-12-19 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29290/ --- (Updated Dec. 20, 2014, 3:39 a.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 29290: Created IP address abstraction for different protocol families

2014-12-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29290/#review65726 --- Patch looks great! Reviews applied: [29288, 29289, 29290] All