[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 I added this endpoint to the README with the latest commit and also tested on full dev with Kerberos enabled. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 What do you think @ottobackwards? Are you good with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] metron issue #658: METRON-1048 Removed SimpleHBaseEnrichmentWriterLoggingTes...

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/658 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] metron issue #657: METRON-1048 Intermittent Test Failure for SimpleHBaseEnri...

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/657 Nevermind, LoggerFactory is static. For what it's worth, adding `org.mockito.Mockito.reset(logger);` to setUp() worked for me. --- If your project is set up for it, you can reply to this

[GitHub] metron issue #657: METRON-1048 Intermittent Test Failure for SimpleHBaseEnri...

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/657 Why not just move line 60 (`logger = mock(Logger.class);`) to the setup method? Since you're testing interactions with this mock it would be better to have a new one for every test. -

[GitHub] metron pull request #635: METRON-1018: Integration tests should reference fl...

2017-07-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/635#discussion_r128045457 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-17 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r127832531 --- Diff: metron-interface/metron-alerts/src/app/service/data-source.ts --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] metron issue #647: METRON-1031: Management UI Cannot Start Topologies in Ker...

2017-07-17 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/647 +1 validated with instructions in the PR description. Nice work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] metron issue #599: METRON-975: Normalize logging and switch to common idiom ...

2017-07-17 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/599 @mmiklavc looks like there are some merge conflicts. If you don't mind resolving those I will get this reviewed. --- If your project is set up for it, you can reply to this email and have

[GitHub] metron issue #645: METRON-1029: Topology worker opts are not being set when ...

2017-07-17 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/645 Their status will "Active" but you'll see Kerberos errors in the Storm UI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] metron issue #645: METRON-1029: Topology worker opts are not being set when ...

2017-07-17 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/645 Without it, the enrichment and indexing topologies don't work on a Kerberized environment because the Storm worker childopts property needs the "-Djava.security.auth.login.confi

[GitHub] metron issue #359: METRON-569: Change acking to prevent duplicate tuples in ...

2017-07-17 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/359 @DomenicPuzio, this has been resolved by https://github.com/apache/metron/pull/603. Can we close this PR? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron pull request #647: METRON-1031: Management UI Cannot Start Topologies...

2017-07-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/647#discussion_r127555429 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/metron.j2 --- @@ -37,3

[GitHub] metron pull request #654: METRON-1044: Disabled writers are not acking messa...

2017-07-14 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/654 METRON-1044: Disabled writers are not acking messages ## Contributor Comments The PR fixes a bug in the indexing topology where a disabled writer will cause messages to fail. This happens

[GitHub] metron pull request #654: METRON-1044: Disabled writers are not acking messa...

2017-07-14 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #654: METRON-1044: Disabled writers are not acking messa...

2017-07-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/654#discussion_r127531933 --- Diff: metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java --- @@ -118,6 +118,20 @@ public void

[GitHub] metron pull request #654: METRON-1044: Disabled writers are not acking messa...

2017-07-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/654#discussion_r127527166 --- Diff: metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java --- @@ -118,6 +118,20 @@ public void

[GitHub] metron pull request #647: METRON-1031: Management UI Cannot Start Topologies...

2017-07-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/647#discussion_r127473184 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormCLIWrapper.java --- @@ -75,37 +81,50 @@ public int

[GitHub] metron pull request #647: METRON-1031: Management UI Cannot Start Topologies...

2017-07-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/647#discussion_r127466486 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormCLIWrapper.java --- @@ -75,37 +81,50 @@ public int

[GitHub] metron pull request #654: METRON-1044: Disabled writers are not acking messa...

2017-07-13 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/654 METRON-1044: Disabled writers are not acking messages ## Contributor Comments The PR fixes a bug in the indexing topology where a disabled writer will cause messages to fail. This happens

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 Hive provides a list of supported databases: https://cwiki.apache.org/confluence/display/Hive/AdminManual+MetastoreAdmin#AdminManualMetastoreAdmin-Local/EmbeddedMetastoreDatabase(Derby) --- If

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 Here's the challenge with all this. Maybe we can collaborate on the right approach. The REST app requires a relational database and setting that up is a prerequisite, unless you wa

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 @ottobackwards it's in metron-rest README but I can expand it a little bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 The comment "This is needed when configuring MySQL for Metron REST because this property must be" is actually incorrect now that I go back and look at it. The schema-mysql.sql was

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 Spring provides a mechanism for running sql scripts for different databases on startup. This is useful for initializing tables and such. We provide 2 right now: schema-h2.sql and schema

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 The latest commit enforces a maximum page size. A value of 1000 is set by default. As it currently stands, you would need to add this property to the rest_application.yml file manually if it

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126789624 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126789223 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -77,132

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126788288 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py

[GitHub] metron pull request #646: METRON-1030: Metron JDBC platform REST option shou...

2017-07-11 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/646 METRON-1030: Metron JDBC platform REST option should accept a blank value ## Contributor Comments Ambari should allow the metron_jdbc_platform option to be set to '' which it curr

[GitHub] metron pull request #645: METRON-1029: Topology worker opts are not being se...

2017-07-11 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/645 METRON-1029: Topology worker opts are not being set when Kerberos is enabled ## Contributor Comments This PR properly sets the topology worker opts property for enrichment and indexing

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-07-10 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/620 I just added some comments related to abstracting the search service. Much improved with the latest commits. I think we're almost there. --- If your project is set up for it, you can rep

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126534924 --- Diff: metron-interface/metron-alerts/src/app/utils/elasticsearch-utils.ts --- @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126534489 --- Diff: metron-interface/metron-alerts/src/app/service/elasticsearch-localstorage-impl.ts --- @@ -0,0 +1,291 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126532937 --- Diff: metron-interface/metron-alerts/src/app/service/data-source.ts --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126532195 --- Diff: metron-interface/metron-alerts/src/app/model/search-request.ts --- @@ -0,0 +1,7 @@ +export class SearchRequest { + _source: string

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126531609 --- Diff: metron-interface/metron-alerts/src/app/alerts/saved-searches/saved-searches.component.ts --- @@ -0,0 +1,124 @@ +import { Component, OnInit

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126531076 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/query-builder.ts --- @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126530918 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/query-builder.ts --- @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-10 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 The core issue is that both Solr and Elasticsearch depend on Lucene. Our version of Elasticsearch (2.3.3) is old so there are lots of Lucene class version conflicts when adding Solr as a

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-10 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 @ottobackwards just created a discuss thread on the general approach here. @cestella you're absolutely correct. We need a way for solr and ES to coexist. A precedent has already bee

[GitHub] metron pull request #636: METRON-1022: Elasticsearch REST endpoint

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/636#discussion_r126511864 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/ElasticsearchWriter.java --- @@ -60,96 +61,8

[GitHub] metron pull request #636: METRON-1022: Elasticsearch REST endpoint

2017-07-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/636#discussion_r126511838 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/ElasticsearchServiceImpl.java --- @@ -0,0 +1,74

[GitHub] metron pull request #636: METRON-1022: Elasticsearch REST endpoint

2017-07-06 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/636 METRON-1022: Elasticsearch REST endpoint ## Contributor Comments The PR adds a simple Elasticsearch REST endpoint that can execute simple queries. This will serve as the foundation for

[GitHub] metron pull request #635: METRON-1018: Integration tests should reference fl...

2017-07-06 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/635#discussion_r125913966 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java

[GitHub] metron pull request #635: METRON-1018: Integration tests should reference fl...

2017-07-06 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/635#discussion_r125910236 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java

[GitHub] metron pull request #635: METRON-1018: Integration tests should reference fl...

2017-07-06 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/635 METRON-1018: Integration tests should reference flux yaml and property files deployed by Ambari ## Contributor Comments This PR makes a couple of improvements to our integration tests

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-06 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/634 METRON-1017: Ambari components should be separate ## Contributor Comments This PR separates the various configurations in Ambari into different *-env.xml files. Doing this allows us to

[GitHub] metron issue #624: METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

2017-06-30 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/624 +1. Really nice job guys. Looking forward to working builds again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

2017-06-30 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r125037580 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -61,6 +62,7

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124927666 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -61,6 +62,7

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-29 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/624 Was also able to successfully run all integration tests and verified full dev works. The latest travis failure is an intermittent Kafka failure that I've seen before. Was this an

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-06-29 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/620 Here's an idea to get us started. A search request could look like: ``` { "query": "ip_src_addr:192.168.66.1", "from": 0, "size&qu

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124869167 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-29 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/624 I'm spinning it up now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-06-29 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/620 If you want to make it specific to 'Alert' then I'm fine with that. I'm not crazy about 'AlertsDTO', would prefer to keep the search result contex

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-06-28 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/620 Just tested again and I am able to now remove the first filter and properly filter on values with special characters (referrer field for example). I did another pass and found some trivial issues

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124629201 --- Diff: metron-interface/metron-alerts/src/app/shared/metron-table/metron-table-pagination/metron-table-pagination.component.scss --- @@ -0,0 +1,30

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124629155 --- Diff: metron-interface/metron-alerts/src/app/shared/metron-table/metron-table-pagination/metron-table-pagination.component.html --- @@ -0,0 +1,20

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124628897 --- Diff: metron-interface/metron-alerts/src/app/shared/list-group/list-group.component.scss --- @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124628855 --- Diff: metron-interface/metron-alerts/src/app/shared/list-group/list-group.component.html --- @@ -0,0 +1,19

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124628476 --- Diff: metron-interface/metron-alerts/src/app/shared/collapse/collapse.component.html --- @@ -0,0 +1,31 @@ + + + {{ data.getName

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124628520 --- Diff: metron-interface/metron-alerts/src/app/shared/collapse/collapse.component.scss --- @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124627945 --- Diff: metron-interface/metron-alerts/src/app/service/cluster-metadata.service.ts --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124627626 --- Diff: metron-interface/metron-alerts/src/app/service/alert.service.ts --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124627529 --- Diff: metron-interface/metron-alerts/src/app/service/alert.service.ts --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124627293 --- Diff: metron-interface/metron-alerts/src/app/model/query-builder.ts --- @@ -0,0 +1,160 @@ +import {Filter} from './filter';

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124627204 --- Diff: metron-interface/metron-alerts/src/app/model/query-builder.ts --- @@ -0,0 +1,160 @@ +import {Filter} from './filter';

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124626694 --- Diff: metron-interface/metron-alerts/src/app/app.component.scss --- @@ -0,0 +1,25 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124626493 --- Diff: metron-interface/metron-alerts/src/app/alerts/saved-searches/saved-searches.component.scss --- @@ -0,0 +1,22 @@ +/** + * Licensed to

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124626347 --- Diff: metron-interface/metron-alerts/src/app/alerts/save-search/save-search.component.scss --- @@ -0,0 +1,22 @@ +/** + * Licensed to the

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124625631 --- Diff: metron-interface/metron-alerts/src/app/alerts/configure-rows/configure-rows.component.html --- @@ -0,0 +1,45

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124625676 --- Diff: metron-interface/metron-alerts/src/app/alerts/configure-rows/configure-rows.component.scss --- @@ -0,0 +1,85 @@ +/** + * Licensed to

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124625253 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/alerts-list.component.ts --- @@ -0,0 +1,371 @@ +import {Component, OnInit

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124623755 --- Diff: metron-interface/metron-alerts/e2e/matchers/custom-matchers.d.ts --- @@ -0,0 +1,5 @@ +declare module jasmine { + interface Matchers

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124623532 --- Diff: metron-interface/metron-alerts/scripts/package.json --- @@ -0,0 +1,21 @@ +{ + "name": "metron-management-ui-web-serve

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-06-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r124622851 --- Diff: metron-interface/metron-alerts/scripts/prepend_license_header.sh --- @@ -0,0 +1,42 @@ +#!/bin/bash +# +# Licensed to the Apache

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123374060 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123370264 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368840 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368823 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368910 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368861 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/enrichment.properties.j2

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-06-20 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/620 Ok I will assume anything related to Alert Status is a not-yet-functional portion. I am testing in full dev. For the 2 you are not able to reproduce: - Add the "referrer&q

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-06-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/620 I was able to get this running in "dev" mode against full dev based on instructions in the README. This is a great start. I've noticed several bugs while initially e

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-08 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/613 METRON-990: Clean up and organize flux properties ## Contributor Comments This PR is mainly a refactor of the enrichment and indexing flux files along with their matching property files

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-08 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #613: METRON-990: Clean up and organize flux properties

2017-06-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/613 Still working on updating the integration tests with the new properties. Will have them fixed shortly. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-07 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/613 METRON-990: Clean up and organize flux properties ## Contributor Comments This PR is mainly a refactor of the enrichment and indexing flux files along with their matching property files. The

[GitHub] metron pull request #603: METRON-569: Enrichment topology duplicates message...

2017-06-05 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/603#discussion_r120115152 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/JoinBolt.java --- @@ -141,11 +141,12 @@ public void execute

[GitHub] metron pull request #604: added env file source to script

2017-06-01 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/604 added env file source to script ## Contributor Comments Fixes a minor bug in the management UI init script. That scripts now matches the REST init script. Tested in full dev

[GitHub] metron pull request #603: METRON-569: Enrichment topology duplicates message...

2017-06-01 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/603 METRON-569: Enrichment topology duplicates messages ## Contributor Comments This issue was discovered a while ago but a PR with a fix was never accepted. In summary, the JoinBolt is acking

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-26 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118775252 --- Diff: metron-interface/metron-config/scripts/package.json --- @@ -9,7 +9,8 @@ "http-proxy-middleware": "0.17.4",

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-26 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118698559 --- Diff: metron-interface/metron-config/scripts/package.json --- @@ -9,7 +9,8 @@ "http-proxy-middleware": "0.17.4",

[GitHub] metron issue #583: METRON-949 Change from error to warning message for Metro...

2017-05-25 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/583 Makes sense @anandsubbu. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-25 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118479511 --- Diff: metron-interface/metron-config/scripts/package.json --- @@ -9,7 +9,8 @@ "http-proxy-middleware": "0.17.4",

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-24 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118377557 --- Diff: metron-interface/metron-config/scripts/package.json --- @@ -9,7 +9,8 @@ "http-proxy-middleware": "0.17.4",

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-24 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118376710 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/management_ui_commands.py

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-24 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118375618 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/quicklinks/quicklinks.json --- @@ -37,6

[GitHub] metron issue #593: METRON-958: PCAP Query job throws exception when no files...

2017-05-20 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/593 +1 worked as advertised. I tested this in full dev using a topic with an '_' character in the name. A query within the time range returned results and a query outside of the time rang

<    1   2   3   4   5   6   >