[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132808269 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwa

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132808241 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwa

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132808147 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwa

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132808084 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softwa

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132807655 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to th

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 Thanks Matt. I will go through and reply later tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I will also post the review issues that I do not think have been touched on yet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132801000 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132797108 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwar

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132799099 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softwar

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132800554 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132797485 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwar

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132801955 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/VFSBundleClassLoader.java --- @@ -0,0 +1,515 @@ +/* + * Licensed to the Apache So

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132798637 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwar

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132795983 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwar

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132801851 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/VFSBundleClassLoader.java --- @@ -0,0 +1,515 @@ +/* + * Licensed to the Apache So

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132796537 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Softwar

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 Okay, @ottobackwards , after all this I really wanted to just say "it's good" :-) but I did have a few more concerns, especially with ExtensionManager.java. I want to emphasize that this i

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 in fact, you will see more in the management ui, since the extension parsers all have default configurations and will be present :) --- If your project is set up for it, you can reply to this

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 The management ui works with zookeeper. You will be able to work with it. Adding support for installing extensions through the UI is a follow on, but I am not sure that I can do it --- If y

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/530 Ok, that's fine. Just thinking out loud. I'm considering your comments about core changes vs the work in METRON-942. So with the combination of this PR and 942, where does this leave the management

Re: [DISCUSS] Code Reformatting next steps

We can wait until 777 goes in, but any smaller PRs should just roll with it. I’ve found (after doing it wrong a couple times) that if you just do the simple update merge: #in local git repo branch METRON-XXX, with additional git remote ‘apache’ git fetch apache git merge apache/master

Re: [DISCUSS] Code Reformatting next steps

Regarding Matt's point, I can pretty easily split the manual vs automatic changes. I won't have time today, but I (probably) can Sunday. Commits should be relatively low velocity then, so it should mostly naturally occur. Regarding PRs, I'm personally okay with best effort, and just correcting a

Re: [DISCUSS] Code Reformatting next steps

What do we do for PR’s? I don’t think I should run this on 777 for example while it is under review. But, I don’t think running it as a last commit before landing is correct either. Will it be: PR as is ( if you haven’t reformatted, don’t ) Follow on PR with only reformatting ?? On August 11,

Re: [DISCUSS] Code Reformatting next steps

Regarding METRON-1087, I’m in favor of freezing commits for a day, to let Justin re-run the script for METRON-1087 over all of current master, and commit it. Perhaps, for assurance, this commit should only include the fully-automated “vast majority”; the couple dozen files that needed manual fix

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 We discussed this higher up in the pr and decided not to --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: Metron Alerts bombing in Travis?

>> the obvious concern I have being the repeatability of the build. I can't agree with you more Yarn exactly does this. Yarn is a wrapper around npm which ensures the repeatability of a build. I will start a discussion on dev list outlining these points. I hope you would pitch in on the thread

Re: Metron Alerts bombing in Travis?

I just merged Raghu's PR into master, so we should be good to go. On Fri, Aug 11, 2017 at 12:53 PM, Justin Leet wrote: > I disagree with the hardcoded versions being bad, the obvious concern I > have being the repeatability of the build. > > I'd also like to note that we release source as the Ap

[GitHub] metron pull request #691: METRON-1104: Build Failure - Due to Bootstrap vers...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #691: METRON-1104: Build Failure - Due to Bootstrap version cha...

Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/691 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] metron issue #691: METRON-1104: Build Failure - Due to Bootstrap version cha...

Github user justinleet commented on the issue: https://github.com/apache/metron/pull/691 Same here, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] metron issue #691: METRON-1104: Build Failure - Due to Bootstrap version cha...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/691 I'm +1 on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/530 Does it make sense to create a feature branch for these PR's? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] metron pull request #688: METRON-1094: MaaS will not start due to classpath ...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron pull request #689: METRON-1102: Add support for ingesting cybox URI o...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #688: METRON-1094: MaaS will not start due to classpath error r...

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/688 +1 by inspection. Thank you for the contribution @cestella --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

Re: Metron Alerts bombing in Travis?

I disagree with the hardcoded versions being bad, the obvious concern I have being the repeatability of the build. I'd also like to note that we release source as the Apache release artifacts, anything else we put out is convenience. Say we have a situation where we rely on library Foo version 2.

[GitHub] metron pull request #691: METRON-1104: Build Failure - Due to Bootstrap vers...

GitHub user iraghumitra opened a pull request: https://github.com/apache/metron/pull/691 METRON-1104: Build Failure - Due to Bootstrap version change ## Contributor Comments Hardcoding the version of bootstrap version to 4.0.0-alpha.6 Bootstrap's latest version (4beta)

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mmiklavc keep in mind that the proper scope for the document is building new parsers that are 'part' of metron for METRON-777. METRON-942 has the capability to actually install and dep

Re: Metron Alerts bombing in Travis?

I agree that we can have a separate discussion about moving to yarn. Hardcoding all the versions in package.json is a bad idea considering that JS world releases happen very frequently and it's easy to miss on a good feature. All the ASF projected that I know of have moved to yarn and not hard cod

Re: Metron Alerts bombing in Travis?

Yes, I agree Justin. I think we need to have another (maybe separate?) discussion on changing the dependency tool set and discuss pros and cons. On Fri, Aug 11, 2017 at 10:45 AM Justin Leet wrote: > I'm honestly not very familiar with this stuff, but this seems more like a > "how we use it issu

Re: Metron Alerts bombing in Travis?

I'm honestly not very familiar with this stuff, but this seems more like a "how we use it issue", rather than an issue with the tech itself. Do we have a more compelling reason, or set of reasons, beyond just fixing to specific version of our dependencies? On Fri, Aug 11, 2017 at 10:37 AM, Nick A

Re: Metron Alerts bombing in Travis?

And I suggest that as a short-term (or medium-term) fix, separate from moving wholesale to another dependency mechanism. On Fri, Aug 11, 2017 at 10:36 AM Nick Allen wrote: > Would it make sense to just 'fix' at a specific version all NPM > dependencies, instead of allowing any version after x.

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/690 METRON-1091 Package STELLAR shell as stand alone This PR adds metron-deployment/packaging/archive, and the metron-stellar-shell module. This module packages a stellar shell environment tha

Re: Metron Alerts bombing in Travis?

Would it make sense to just 'fix' at a specific version all NPM dependencies, instead of allowing any version after x.y.z ? On Fri, Aug 11, 2017 at 10:34 AM Casey Stella wrote: > I agree; we should have a long-term JIRA for moving to yarn (so confusing > *sigh*) and a tactical JIRA + PR to fix

Re: Metron Alerts bombing in Travis?

I agree; we should have a long-term JIRA for moving to yarn (so confusing *sigh*) and a tactical JIRA + PR to fix the build. We should prioritize review of that tactical JIRA. Casey On Fri, Aug 11, 2017 at 10:19 AM, Otto Fowler wrote: > Can you create a jira for moving to yarn please. > > > On

Re: Metron Alerts bombing in Travis?

Can you create a jira for moving to yarn please. On August 11, 2017 at 10:17:40, Otto Fowler (ottobackwa...@gmail.com) wrote: Are there any other NPM modules where we are exposed to this risk? On August 11, 2017 at 10:11:22, RaghuMitra Kandikonda ( raghumitra@gmail.com) wrote: Ok, Bootstr

Re: Metron Alerts bombing in Travis?

Are there any other NPM modules where we are exposed to this risk? On August 11, 2017 at 10:11:22, RaghuMitra Kandikonda ( raghumitra@gmail.com) wrote: Ok, Bootstrap made a release 10hrs ago and they removed few files that we were using hence the issue. We need to update package.json in metr

Re: Metron Alerts bombing in Travis?

Ok, Bootstrap made a release 10hrs ago and they removed few files that we were using hence the issue. We need to update package.json in metron-alerts to use bootstrap '4.0.0-alpha.6' not any version after that. So the change would be metron-alerts/package.json:25 change bootstrap from '^4.0.0-alpha

Re: Metron Alerts bombing in Travis?

Where are the bootstrap files? the @import ~bootstrap/….. looks like it is failing? On August 11, 2017 at 09:51:03, RaghuMitra Kandikonda ( raghumitra@gmail.com) wrote: I am running a clean install now, I will keep you posted. -Raghu Mitra On Fri, Aug 11, 2017 at 7:02 PM, Casey Stella w

Re: Metron Alerts bombing in Travis?

I am running a clean install now, I will keep you posted. -Raghu Mitra On Fri, Aug 11, 2017 at 7:02 PM, Casey Stella wrote: > Yes, I'm getting it locally too, here's more context: > > [INFO] ERROR in multi script-loader!./~/jquery/dist/jquery.js > script-loader!./~/tether/dist/js/tether.js > sc

[GitHub] metron issue #688: METRON-1094: MaaS will not start due to classpath error r...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/688 @anandsubbu I normally run `maas_service.sh` as root on full-dev and we tested it run as `metron` earlier. Are you seeing errors around running as non-hdfs? --- If your project is set up for it,

Re: Metron Alerts bombing in Travis?

Yes, I'm getting it locally too, here's more context: [INFO] ERROR in multi script-loader!./~/jquery/dist/jquery.js script-loader!./~/tether/dist/js/tether.js script-loader!./~/ace-builds/src-noconflict/ace.js [INFO] Module not found: Error: Can't resolve '/Users/cstella/Documents/workspace/metron

Re: Metron Alerts bombing in Travis?

Deleting my caches did NOT resolve the issue. On August 11, 2017 at 09:24:22, zeo...@gmail.com (zeo...@gmail.com) wrote: Master is failing with that right now. https://travis-ci.org/apache/metron#L2637 Jon On Fri, Aug 11, 2017 at 9:21 AM Otto Fowler wrote: > Has anyone seen this error in tr

Re: [DISCUSS] Code Reformatting next steps

https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines is updated to reflect the code style standards. It also includes instructions for setting up warnings and autoformatting in both IntelliJ and Eclipse. However, the current standard is to not update files that don't match th

Re: Metron Alerts bombing in Travis?

Master is failing with that right now. https://travis-ci.org/apache/metron#L2637 Jon On Fri, Aug 11, 2017 at 9:21 AM Otto Fowler wrote: > Has anyone seen this error in travis? I am going to delete my caches and > try again : > > > [ERROR] npm ERR! Linux 4.4.0-83-generic > > [ERROR] npm ERR! a

Metron Alerts bombing in Travis?

Has anyone seen this error in travis? I am going to delete my caches and try again : [ERROR] npm ERR! Linux 4.4.0-83-generic [ERROR] npm ERR! argv "/home/travis/build/ottobackwards/metron/metron-interface/metron-alerts/node/node" "/home/travis/build/ottobackwards/metron/metron-interface/metron-

Re: [DISCUSS] Code Reformatting next steps

We should add something to the PR template about this. Did we change the contributor’s guide? Also, are there common steps to take with Intellij, so that we all do the same thing for mass reformats? On August 11, 2017 at 08:14:21, Justin Leet (justinjl...@gmail.com) wrote: Now that METRON-746 <

[GitHub] metron pull request #528: METRON-838 Incorrect set of ts in FireEye parser

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/528 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[DISCUSS] Code Reformatting next steps

Now that METRON-746 is in, we have a consistent code formatting setup where (for the most part) it can be autoapplied. Barring one existing PR, the main thing is just picking a module, doing the format, and testing it out. Obviously, I'd like to avoid co

[GitHub] metron issue #685: METRON-1087: Adjust license headers to be comments instea...

Github user justinleet commented on the issue: https://github.com/apache/metron/pull/685 Kicking Travis. If it fails again, I'll look into it, but it's not like I did anything complicated in the merge. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] metron pull request #685: METRON-1087: Adjust license headers to be comments...

GitHub user justinleet reopened a pull request: https://github.com/apache/metron/pull/685 METRON-1087: Adjust license headers to be comments instead of Javadoc ## Contributor Comments This does three things: 1. Changes Javadoc to just plain comment. 2. Fixes headers that

[GitHub] metron pull request #685: METRON-1087: Adjust license headers to be comments...

Github user justinleet closed the pull request at: https://github.com/apache/metron/pull/685 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #685: METRON-1087: Adjust license headers to be comments instea...

Github user justinleet commented on the issue: https://github.com/apache/metron/pull/685 @mmiklavc Updated, if you want to take another glance. I updated all new files to be comments. There is one thing that looks like a change, but is just an upstream change from a merge conflict res

[GitHub] metron pull request #685: METRON-1087: Adjust license headers to be comments...

Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/685#discussion_r132669235 --- Diff: metron-platform/metron-hbase/src/test/java/org/apache/metron/hbase/mock/MockHTable.java --- @@ -16,7 +16,7 @@ * limitations under the Lic