[GitHub] sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-13 Thread GitBox
sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187832127 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/SchedulerRunner.java ##

[GitHub] sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-13 Thread GitBox
sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187832341 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/SchedulingPolicy.java ##

[GitHub] jeongyooneo commented on a change in pull request #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-14 Thread GitBox
jeongyooneo commented on a change in pull request #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/17#discussion_r187842301 ## File path: pom.xml ## @@ -63,6 +63,7 @@ limitations under the License.

[GitHub] sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-13 Thread GitBox
sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187831191 ## File path:

[GitHub] sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-13 Thread GitBox
sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187832401 ## File path:

[GitHub] sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-13 Thread GitBox
sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187831164 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/CompositeSchedulingPolicy.java

[GitHub] seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-14 Thread GitBox
seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187789194 ## File path: examples/beam/src/test/java/edu/snu/nemo/examples/beam/AlternatingLeastSquareITCase.java ## @@

[GitHub] sanha opened a new pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-15 Thread GitBox
sanha opened a new pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18 JIRA: [NEMO-45: Distributed Nemo-Spark](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-45) **Major changes:** - Enabled distributed Spark source

[GitHub] skystar-p commented on issue #15: [NEMO-53] Make SchedulingPolicy Stackable

2018-05-15 Thread GitBox
skystar-p commented on issue #15: [NEMO-53] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#issuecomment-389077464 @seojangho Thanks for the TODO comment! This is an automated message

[GitHub] seojangho closed pull request #15: [NEMO-53] Make SchedulingPolicy Stackable

2018-05-15 Thread GitBox
seojangho closed pull request #15: [NEMO-53] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jeongyooneo commented on issue #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
jeongyooneo commented on issue #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#issuecomment-387659309 @sanha I've addressed most of the comments. The following two I haven't resolved will be addressed via another issue of refactoring

[GitHub] jeongyooneo commented on issue #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
jeongyooneo commented on issue #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#issuecomment-387659309 @sanha I've addressed the comments except the following two. These will be addressed via another issue of refactoring `TaskDataHandler`-based

[GitHub] seojangho commented on issue #5: [NEMO-27] Element Wise Block Write

2018-05-07 Thread GitBox
seojangho commented on issue #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#issuecomment-387290444 @sanha Please resolve the conflict. This is an automated message from the Apache

[GitHub] sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187041521 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskGroupExecutor.java ## @@ -145,303

[GitHub] sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187039736 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/transform/CollectTransform.java

[GitHub] sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187041677 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskGroupExecutor.java ## @@ -145,303

[GitHub] sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187041511 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskGroupExecutor.java ## @@ -145,303

[GitHub] sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187041188 ## File path: examples/beam/src/test/java/edu/snu/nemo/examples/beam/policy/DataSkewPolicyParallelismFive.java ##

[GitHub] sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187039938 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/transform/CollectTransform.java

[GitHub] sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining

2018-05-09 Thread GitBox
sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187038660 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/OutputCollectorImpl.java

[GitHub] seojangho commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-12 Thread GitBox
seojangho commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187788995 ## File path:

[GitHub] seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-12 Thread GitBox
seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187789144 ## File path: common/src/main/java/edu/snu/nemo/common/test/ExampleTestUtil.java ## @@ -42,11 +42,12 @@

[GitHub] seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-12 Thread GitBox
seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187789194 ## File path: examples/beam/src/test/java/edu/snu/nemo/examples/beam/AlternatingLeastSquareITCase.java ## @@

[GitHub] seojangho commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-12 Thread GitBox
seojangho commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187789042 ## File path: tests/src/test/java/edu/snu/nemo/tests/runtime/master/scheduler/FaultToleranceTest.java

[GitHub] seojangho commented on issue #15: [NEMO-52] Make SchedulingPolicy Stackable

2018-05-12 Thread GitBox
seojangho commented on issue #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#issuecomment-388602102 @skystar-p Thanks for the work. Please check my comments. This is an

[GitHub] johnyangk opened a new pull request #16: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-13 Thread GitBox
johnyangk opened a new pull request #16: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/16 JIRA: [NEMO-66: Move /tests/scheduler into

[GitHub] johnyangk closed pull request #16: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-13 Thread GitBox
johnyangk closed pull request #16: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/16 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] johnyangk commented on issue #16: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-13 Thread GitBox
johnyangk commented on issue #16: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/16#issuecomment-388680715 Will reopen. This is an automated message

[GitHub] sanha commented on issue #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
sanha commented on issue #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#issuecomment-390082967 @jeongyooneo Thanks for the review! I addressed them. This is an automated message

[GitHub] johnyangk commented on a change in pull request #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-18 Thread GitBox
johnyangk commented on a change in pull request #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/17#discussion_r189181291 ## File path:

[GitHub] johnyangk commented on issue #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-18 Thread GitBox
johnyangk commented on issue #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/17#issuecomment-390116743 @jeongyooneo Thanks for the comment. While separating the `testplans` package into two as per your suggestion,

[GitHub] jeongyooneo commented on issue #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on issue #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#issuecomment-390085833 @sanha Thanks for the work! I've approved the review. This is an automated

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187887234 ## File path: examples/spark/src/test/java/edu/snu/nemo/examples/spark/SparkITCase.java ## @@ -28,6 +28,8

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187887025 ## File path: examples/beam/src/test/java/edu/snu/nemo/examples/beam/MapReduceITCase.java ## @@ -26,6 +26,8

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r188491236 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/block/FileBlock.java ## @@

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187887739 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187886807 ## File path: examples/beam/src/test/java/edu/snu/nemo/examples/beam/BroadcastITCase.java ## @@ -27,6 +27,8

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r173355240 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/BlockManagerWorker.java ##

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r188486902 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/BlockManagerWorker.java ##

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187885969 ## File path: common/src/main/java/edu/snu/nemo/common/test/ExampleTestUtil.java ## @@ -42,12 +41,12 @@

[GitHub] jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

2018-05-17 Thread GitBox
jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise Block Write URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r188490277 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/block/Block.java ## @@

[GitHub] johnyangk opened a new pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-18 Thread GitBox
johnyangk opened a new pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20 JIRA: [NEMO-76: Rename TaskGroup to Task](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-76) **Major changes:** - Appropriately renames

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455609 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455592 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189454865 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -32,48

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456580 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456596 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455280 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -89,15

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456094 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java ## @@ -260,39

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456710 ## File path: tests/src/test/java/edu/snu/nemo/tests/runtime/executor/TaskExecutorTest.java ## @@ -88,11

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189454073 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/physical/PhysicalPlanGenerator.java

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455003 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -32,48

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456732 ## File path: tests/src/test/java/edu/snu/nemo/tests/runtime/executor/TaskExecutorTest.java ## @@ -145,7

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456590 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189453902 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/metric/MetricData.java ## @@ -25,7

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455580 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455394 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/Executor.java ## @@ -87,36

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456068 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java ## @@ -131,36

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455257 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -32,48

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455496 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -565,8

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455518 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -565,8

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456665 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455614 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455429 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -76,24

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455467 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@

[GitHub] johnyangk commented on issue #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
johnyangk commented on issue #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#issuecomment-390528099 @jeongyooneo I've addressed your comments except the ones for TaskDataHandler and 'pipelined' tasks, which I'd like to address while working on

[GitHub] johnyangk commented on issue #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-16 Thread GitBox
johnyangk commented on issue #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/17#issuecomment-389438175 @jeongyooneo I've resolved the conflicts with the master branch. Pleas take a look. :)

[GitHub] johnyangk opened a new pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
johnyangk opened a new pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21 JIRA: [NEMO-46: Make the operations on ExecutorRegistry atomic](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-46)

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r18975 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java

[GitHub] johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#issuecomment-391575534 @jeongyooneo Good catch. I've update the branch to reflect your comments.

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-23 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190471382 ## File path:

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-23 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r189497103 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/SparkLauncher.java ##

[GitHub] jeongyooneo closed pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo closed pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453736 ## File path:

[GitHub] bgchun commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
bgchun commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#issuecomment-391582976 @johnyangk Do we have good tests to check the code in the `runtime.master` package?

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453736 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453736 ## File path:

[GitHub] sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190481637 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/SparkLauncher.java ## @@

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190494100 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/SparkLauncher.java ##

[GitHub] wonook closed pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
wonook closed pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190495764 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/SparkSession.java ##

[GitHub] sanha commented on issue #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
sanha commented on issue #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#issuecomment-391627991 @wonook Thanks! Your comments are addressed. This is an automated message from the

[GitHub] sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190483000 ## File path:

[GitHub] seojangho opened a new pull request #22: [Nemo-68] Restrict the number of parallel connections between executors

2018-05-22 Thread GitBox
seojangho opened a new pull request #22: [Nemo-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22 JIRA: [NEMO-68: Restrict the number of parallel connections between

[GitHub] seojangho opened a new pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-22 Thread GitBox
seojangho opened a new pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23 JIRA: [NEMO-67: Support Beam CoGroupByKey transform](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-67)

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190579092 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190522859 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r18975 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java

[GitHub] wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-25 Thread GitBox
wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23#discussion_r190807947 ## File path:

[GitHub] wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-25 Thread GitBox
wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23#discussion_r190808251 ## File path:

[GitHub] johnyangk commented on a change in pull request #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test

2018-05-15 Thread GitBox
johnyangk commented on a change in pull request #17: [NEMO-66] Move /tests/scheduler into /runtime/master/scheduler/test URL: https://github.com/apache/incubator-nemo/pull/17#discussion_r188474874 ## File path: pom.xml ## @@ -63,6 +63,7 @@ limitations under the License.

[GitHub] johnyangk opened a new pull request #19: [NEMO-47] Use primitive types for AlternatingLeastSquare

2018-05-16 Thread GitBox
johnyangk opened a new pull request #19: [NEMO-47] Use primitive types for AlternatingLeastSquare URL: https://github.com/apache/incubator-nemo/pull/19 JIRA: [NEMO-47: Use primitive types for AlternatingLeastSquare](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-47)

[GitHub] sanha closed pull request #19: [NEMO-47] Use primitive types for AlternatingLeastSquare

2018-05-20 Thread GitBox
sanha closed pull request #19: [NEMO-47] Use primitive types for AlternatingLeastSquare URL: https://github.com/apache/incubator-nemo/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jeongyooneo commented on issue #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on issue #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#issuecomment-390543343 @johnyangk Of course! This is an automated message from the Apache Git

[GitHub] johnyangk commented on issue #19: [NEMO-47] Use primitive types for AlternatingLeastSquare

2018-05-20 Thread GitBox
johnyangk commented on issue #19: [NEMO-47] Use primitive types for AlternatingLeastSquare URL: https://github.com/apache/incubator-nemo/pull/19#issuecomment-390532737 @jeongyooneo @wonook @seojangho @sanha Ping.  This is

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189775205 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189782362 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189782160 ## File path:

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189774748 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189777512 ## File path:

  1   2   3   4   5   6   7   8   9   10   >