[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-23 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: build.gradle This file is not complete, and the classpath issue needs a major

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-23 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346992#comment-15346992 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, Thank you for the feedback. To note: - I

[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-23 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: ANT_GRADLE_COMPARISON.txt This is a file that shows the old ant commands

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-23 Thread Taher Alkhateeb
look forward to your feedback. Taher Alkhateeb On Wed, Jun 22, 2016 at 11:12 PM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > Hi Jacques, > > Thank you for the explanation. OK, between your feedback and the votes > from other members, I'll keep them. Working on int

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
Hi Jacques, Thank you for the explanation. OK, between your feedback and the votes from other members, I'll keep them. Working on integration in gradle ... Cheers Taher Alkhateeb On Wed, Jun 22, 2016 at 11:08 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Taher, &

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
it and choose their own implementation strategies. Do you agree? Feedback? Taher Alkhateeb On Wed, Jun 22, 2016 at 4:01 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > I wonder though why this was introduced. If we have no feedback from any > member of the community I think we ca

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
g the same thing but faster. Is this a typo by you or are you actually using this target? The reason I ask is because I actually wanted to delete the entire TestListContainer.java and related files in the future. But now of course I hesitate. Thanks in advance for your feedback. Regards, Taher

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
will update you soon. On Wed, Jun 22, 2016 at 11:38 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 22/06/2016 à 10:05, Julien NICOLAS a écrit : > >> >> >> On 22/06/2016 09:53, Julien NICOLAS wrote: >> >>> >>> >>> On 21/06

Re: XML autocompletion issue

2016-06-21 Thread Taher Alkhateeb
Hi Jacques, Since you mentioned regressions may I suggest that we slow down a little bit our work on trunk for a few days as we work on Gradle to avoid crossing wires. We can focus instead on work at the applications level or for anyone interested to work on gradle itself. Cheers! Taher

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Taher Alkhateeb
, for example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext' instead of load-extseed. If you would like to add the other load data tasks, please specify which ones. Appreciate your early responses. Taher Alkhateeb On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb <slidingfil

[jira] [Created] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-21 Thread Taher Alkhateeb (JIRA)
Taher Alkhateeb created OFBIZ-7534: -- Summary: Migrate OFBiz from Apache Ant to Gradle build system Key: OFBIZ-7534 URL: https://issues.apache.org/jira/browse/OFBIZ-7534 Project: OFBiz Issue

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Taher Alkhateeb
consider dropping it for a while and jump along for help. I will post another email soon with the JIRA details and list of questions I need answer for. Again, thank you, you guys rock, I love OFBiz and this community! Regards, Taher Alkhateeb On Tue, Jun 21, 2016 at 12:49 PM, Nicolas Malin

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Taher Alkhateeb
issues. With that being said, we will not make the switch before a thorough and full testing. That is why we ask everyone who is willing to please help us out to make this transition smooth by testing and providing feedback and comments. Taher Alkhateeb On Tuesday, 21 June 2016, Deepak Dixit

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Taher Alkhateeb
Hi Pierre Sharan and all, In reply to your question Pierre, I will create a JIRA to which people can contribute. Although I worked very hard on this feature, I really need help with thorough testing and feedback. I look forward to your help if you'd like to contribute. Regards, Taher Alkhateeb

Re: Christian Geisert joins the OFBiz PMC

2016-06-20 Thread Taher Alkhateeb
Gongratulations Christian. Wishing you all the best. Taher Alkhateeb On Jun 20, 2016 12:00 PM, "Nicolas Malin" <nicolas.ma...@nereide.fr> wrote: > Welcome Christian ! :) > Nicolas > > > Le 20/06/2016 10:57, Pranay Pandey a écrit : > >> Many cong

Re: We miss a QA team, we face too much regressions

2016-06-17 Thread Taher Alkhateeb
think the order logic is overly complex and should also be eventually simplified. I am drifting too much aren't I? Okay I will zip it :) Taher Alkhateeb On Jun 17, 2016 11:16 AM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> wrote: > Thanks Taher, > > The d

Re: We miss a QA team, we face too much regressions

2016-06-17 Thread Taher Alkhateeb
Hi Gil, For me it's a simple rule, lots of unit tests, less integration tests, even less functional tests (selenium). But I think all are useful if done in proper quantity I like this diagram in a way summarizes it -> http://i.stack.imgur.com/fjQvQ.png Taher Alkhateeb On Fri, Jun 17, 2016 a

Re: We miss a QA team, we face too much regressions

2016-06-16 Thread Taher Alkhateeb
org/wiki/Functional_testing So yeah we can add them, but I don't think we can do that to the raw unit-tests (at least in the context discussed in the other proposal thread) Taher Alkhateeb On Thu, Jun 16, 2016 at 10:40 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wro

Re: Proposal to delete stale java files

2016-06-16 Thread Taher Alkhateeb
thak > HotWax Systems > http://www.hotwaxsystems.com > > > On Jun 16, 2016, at 8:23 PM, Taher Alkhateeb <slidingfilame...@gmail.com> > wrote: > > > > Hi Mridul, > > > > Thank you for the detailed and well thought out feedback. > > > > I am

Re: Proposal to delete stale java files

2016-06-16 Thread Taher Alkhateeb
onally, I feel that most of these files may need to be upgraded and > needs code refactoring probably because they might usually be left out as > they do not compile by default with OFBiz. > > -- > Thanks & Regards, > Mridul Pathak > HotWax Systems > http://www.hotwax

Re: Proposal to delete stale java files

2016-06-16 Thread Taher Alkhateeb
and adding stuff to it, and you are not adding it to component-load.xml? Why is it that you cannot add it there? Regards, Taher Alkhateeb On Thu, Jun 16, 2016 at 3:55 PM, Mridul Pathak < mridul.pat...@hotwaxsystems.com> wrote: > Introducing new directory “reference” seems reasonable

Re: Proposal to delete stale java files

2016-06-16 Thread Taher Alkhateeb
the build scripts and classpath settings will be more complex. Regards, Taher Alkhateeb On Thu, Jun 16, 2016 at 1:24 PM, Divesh Dutta < divesh.du...@hotwaxsystems.com> wrote: > Thanks Pierre and Jacques for your views. I agree with Jacques that we > should not create new repos

RE: Proposal to delete stale java files

2016-06-15 Thread Taher Alkhateeb
component. -- Thanks & Regards, Mridul Pathak Senior Manager HotWax Systems http://www.hotwaxsystems.com > On Jun 15, 2016, at 3:01 PM, Taher Alkhateeb <slidingfilame...@gmail.com> > wrote: > > Hi Mridul, > > How about reference/paymentext and reference/whatever-else-y

Re: Proposal to delete stale java files

2016-06-15 Thread Taher Alkhateeb
the directory tree. My 2 cents. Regards, Taher Alkhateeb On Wed, Jun 15, 2016 at 12:27 PM, Mridul Pathak < mridul.pat...@hotwaxsystems.com> wrote: > Hi Taher, > > Sure, I’ll take care of deleting rest of the files as well. > > Also, we could name these specialpurpose component(

RE: Proposal to delete stale java files

2016-06-15 Thread Taher Alkhateeb
a README file that says this component does not compile and it holds this stuff. This way it is easy to isolate that component from the build system. Thank you all again for your contributions. Taher Alkhateeb -Original Message- From: Mridul Pathak [mailto:mridul.pat...@hotwaxsystems.com

Re: Proposal to delete stale java files

2016-06-14 Thread Taher Alkhateeb
we must pay to keep the project running. You just cannot think in a mess. It's a human thing! My 2 cents, Taher Alkhateeb On Tue, Jun 14, 2016 at 8:01 PM, Pierre Smits <pierre.sm...@gmail.com> wrote: > As the majority of the referenced java files are related to 3rd party > solutions i

Re: Proposal to delete stale java files

2016-06-14 Thread Taher Alkhateeb
Hi Jacopo, Does that mean we should keep them? Mind you some of them have incorrect code (not importing EntityQuery for example). I'm not sure we want to keep dead code in trunk, unless people are using it? Regards, Taher Alkhateeb On Tue, Jun 14, 2016 at 5:18 PM, Jacopo Cappellato

Proposal to delete stale java files

2016-06-14 Thread Taher Alkhateeb
/JasperReportsXmlViewHandler.java Regards, Taher Alkhateeb

Re: Java default options in ant targets

2016-06-10 Thread Taher Alkhateeb
Agreed, it shows you how scary threads are. I remember the first time I read it i went like ... damn i've been programming explosives and mine fields for years without even knowing it. On Jun 10, 2016 8:34 PM, "Jacopo Cappellato" < jacopo.cappell...@hotwaxsystems.com> wrote: > On Thu, Jun 9, 2016

Re: Proposal to modify the testing framework for OFBiz

2016-06-10 Thread Taher Alkhateeb
. Regards, Taher Alkhateeb On Wed, Jun 8, 2016 at 6:00 PM, Taher Alkhateeb <slidingfilame...@gmail.com> wrote: > Hi Everyone, > > Thank you all for your support, JIRA created in > https://issues.apache.org/jira/browse/OFBIZ-7254 > > I will start working on it and try to implem

Re: Java default options in ant targets

2016-06-10 Thread Taher Alkhateeb
. Essentially you have more overhead and slower startup time in -server to allow for better optimization of the application as a whole. I'm not sure how this relates to correctness? Regards, Taher Alkhateeb On Fri, Jun 10, 2016 at 2:33 PM, Jacques Le Roux < jacques.le.r...@les7arts.com>

Re: Java default options in ant targets

2016-06-10 Thread Taher Alkhateeb
d hardware as server to avoid the overhead. The only exception, again, is windows 32. Again not sure but I suspect we do not have a lot of new hardware Windows 32 servers running OFBiz, but I could be wrong of course. Regards, Taher Alkhateeb On Thu, Jun 9, 2016 at 8:28 PM, Jacques Le Roux <

Re: Taher Alkhateeb joins the OFBiz PMC

2016-06-10 Thread Taher Alkhateeb
Thank you Jacopo and everyone. It's an honor to be part of such a wonderful group of people. I look forward to helping the project however I can. Cheers Taher Alkhateeb On Fri, Jun 10, 2016 at 9:48 AM, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: > Le 10/06/2016 08:05, Jacopo C

Re: Proposal to modify the testing framework for OFBiz

2016-06-08 Thread Taher Alkhateeb
Hi Everyone, Thank you all for your support, JIRA created in https://issues.apache.org/jira/browse/OFBIZ-7254 I will start working on it and try to implement ASAP to get my focus back on refactoring. Cheers! Taher Alkhateeb On Wed, Jun 8, 2016 at 4:58 PM, Deepak Dixit <deepak

[jira] [Created] (OFBIZ-7254) provide a new unit testing framework for OFBiz

2016-06-08 Thread Taher Alkhateeb (JIRA)
Taher Alkhateeb created OFBIZ-7254: -- Summary: provide a new unit testing framework for OFBiz Key: OFBIZ-7254 URL: https://issues.apache.org/jira/browse/OFBIZ-7254 Project: OFBiz Issue Type

Re: Proposal to modify the testing framework for OFBiz

2016-06-08 Thread Taher Alkhateeb
information: http://www.jamesshore.com/Blog/Red-Green-Refactor.html https://en.wikipedia.org/wiki/Test-driven_development Regards, Taher Alkhateeb On Wed, Jun 8, 2016 at 1:07 PM, Divesh Dutta <divesh.du...@hotwaxsystems.com > wrote: > Hi Taher, > > What I understand from your

Re: [DISCUSSION] Setting Up Mentoring

2016-06-08 Thread Taher Alkhateeb
Great Initiative, I'm already signed up and I look forward to helping anyone interested. On Wed, Jun 8, 2016 at 11:36 AM, Sharan-F wrote: > Hi Everyone > > I've created a page on the wiki to try and organise the mentoring. We have > a > list of people who volunteered to

Re: Proposal to modify the testing framework for OFBiz

2016-06-08 Thread Taher Alkhateeb
and running them. Regards, Taher Alkhateeb On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Hi Taher, > > There is one thing that I want to confirm based my understanding, as long > as I know, we can run tests independently as well e.g.

Proposal to modify the testing framework for OFBiz

2016-06-08 Thread Taher Alkhateeb
you guys think? Ideas? Suggestions? Approvals and thumbs up? Regards, Taher Alkhateeb

Re: My experience with refactoring the framework

2016-06-08 Thread Taher Alkhateeb
Hi Divesh, Fantastic! Thank you very much for joining. Feel free to contact me directly if you need anything. Cheers, Taher Alkhateeb On Tue, Jun 7, 2016 at 3:14 PM, Divesh Dutta <divesh.du...@hotwaxsystems.com > wrote: > Thanks Taher for the links. Me , Mridul and Pranay have pi

[jira] [Closed] (OFBIZ-6783) Refactor the start component

2016-06-07 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb closed OFBIZ-6783. -- Resolution: Fixed Fix Version/s: Upcoming Branch This issue might be reopened in case

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-06-07 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319049#comment-15319049 ] Taher Alkhateeb commented on OFBIZ-6783: Committed all changes in r1747288. This concludes

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-06-07 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318225#comment-15318225 ] Taher Alkhateeb commented on OFBIZ-6783: Hi Jacques, I always feel extra assured after you pitch

Re: My experience with refactoring the framework

2016-06-07 Thread Taher Alkhateeb
iously and continue doing this for say 12 months or more, then the code would reach a level of clarity that ALLOWS YOU TO THINK of new ideas and ways to improve. You cannot think in a mess! I hope you can join and help out. Take a look at the wiki. Taher Alkhateeb On Tue, Jun 7, 2016 at 9:57 AM, Divesh

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-06-06 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316627#comment-15316627 ] Taher Alkhateeb commented on OFBIZ-6783: Hi Jacopo, Makes perfect sense. I will do

Re: [DISCUSSION] Mentoring to Share Knowledge and Improve Code

2016-06-06 Thread Taher Alkhateeb
(JIRA, ML, Wiki). We also need a little area (Wiki?) to coordinate team efforts, list links and Github repos if we use them. Etc ... Taher Alkhateeb On Mon, Jun 6, 2016 at 1:46 PM, Sharan-F <sharan.f...@gmail.com> wrote: > Hi All > > One of the things that came up in the Committers Sur

RE: My experience with refactoring the framework

2016-06-06 Thread Taher Alkhateeb
really unfortunate not to engage these individuals because of communication barriers. My 2 cents! Taher Alkhateeb -Original Message- From: Sharan-F [mailto:sharan.f...@gmail.com] Sent: 06 June 2016 10:57 To: dev@ofbiz.apache.org Subject: Re: My experience with refactoring the framework Hi

My experience with refactoring the framework

2016-06-05 Thread Taher Alkhateeb
of my head, and maybe help trigger thoughts for other people. Cheers! Taher Alkhateeb

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-06-05 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch In this final patch, I did everything above plus: - refactor

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-06-04 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch I promise this is the last one :) In this patch I update

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-06-04 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch one more patch to do everything above but also: - replace

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-06-04 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch Ok, I made one more change but it suddenly made the code much

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-06-04 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch Hello folks, Another patch for refactoring the start component

Re: buildbot failure in on ofbiz-trunk

2016-06-03 Thread Taher Alkhateeb
Gd Ok so this means ofbiz is working correctly after fixing a regression which freezes the system. Now whoever commited something that breaks the system please fix it (has to do with invoices). Cheers, Taher Allhateeb On Jun 3, 2016 7:39 PM, wrote: > The Buildbot has

[jira] [Commented] (OFBIZ-7167) The HTML rendering of tests is no longer working when tests fail

2016-06-03 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314375#comment-15314375 ] Taher Alkhateeb commented on OFBIZ-7167: I will leave this JIRA open until you confirm Jacques

[jira] [Commented] (OFBIZ-7167) The HTML rendering of tests is no longer working when tests fail

2016-06-03 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314370#comment-15314370 ] Taher Alkhateeb commented on OFBIZ-7167: Hi Jacques, Fixed in r1746737. I simply need to catch

[jira] [Commented] (OFBIZ-7167) The HTML rendering of tests is no longer working when tests fail

2016-06-03 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314303#comment-15314303 ] Taher Alkhateeb commented on OFBIZ-7167: OK, got the offending bit

[jira] [Commented] (OFBIZ-7167) The HTML rendering of tests is no longer working when tests fail

2016-06-03 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314260#comment-15314260 ] Taher Alkhateeb commented on OFBIZ-7167: Jacques .. you are awesome! Ok, this narrows it down, I

[jira] [Commented] (OFBIZ-7167) The HTML rendering of tests is no longer working when tests fail

2016-06-03 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314178#comment-15314178 ] Taher Alkhateeb commented on OFBIZ-7167: Hi Jacques, OK, so can you confirm that we have 2

Re: Tests issues

2016-06-03 Thread Taher Alkhateeb
Hi Jacques, Nice work! so it's just the issue of HTML not rendering on failed tests. Ok, I'll jump in and try to see what's up. Cheers Taher Alkhateeb On Fri, Jun 3, 2016 at 4:47 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Taher, > > Took me a while to

Re: Tests issues

2016-06-03 Thread Taher Alkhateeb
this narrows it down to one of the commits in between. Regards, Taher Alkhateeb On Fri, Jun 3, 2016 at 12:01 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Oops, I mean I hate to revert things :) > > Jacques > > > Le 02/06/2016 à 20:30, Jacques Le Roux a écri

Re: Tests issues

2016-06-02 Thread Taher Alkhateeb
and instead dig out whatever the culprit is. There is too much work that went into the start component. I'll go full force in this direction for now. Regards, Taher Alkhateeb On Thu, Jun 2, 2016 at 4:35 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Arun, > > As you ch

RE: Question on multiple starting ofbiz

2016-06-02 Thread Taher Alkhateeb
, Taher Alkhateeb -Original Message- From: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] Sent: 02 June 2016 14:26 To: dev@ofbiz.apache.org Subject: Re: Question on multiple starting ofbiz Hi Taher, Before going down in this, I believe there is something you need to work on first

RE: Question on multiple starting ofbiz

2016-06-02 Thread Taher Alkhateeb
hings are very clear now. The start sequence only executes once per JVM. This makes locks and all kinds of elaborate checking unnecessary. I will start cleaning that up! Cheers Taher Alkhateeb -Original Message- From: Gareth Carter [mailto:gareth.car...@stannah.co.uk] Sent: 02 Jun

Question on multiple starting ofbiz

2016-06-02 Thread Taher Alkhateeb
: - Checking if a classloader is set or not - Applying locks on StartupLoaders to prevent multiple threads from altering them Is this code unnecessary? Should I assume that OFBiz never calls the startup sequence more than once? Regards, Taher Alkhateeb

Re: OFBiz Committers Survey - Results

2016-06-01 Thread Taher Alkhateeb
and efforts and allow us to understand the reason behind everyone's views on where we should going. Regards, Taher Alkhateeb Impressive work indeed, thanks Sharan! Jacques Le 01/06/2016 à 11:51, Ashish Vijaywargiya a écrit : > You prepared wonderful document Sharan. Thanks for all your work

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-31 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307303#comment-15307303 ] Taher Alkhateeb commented on OFBIZ-6783: Okay fixed everything and committed in r1746236 I think

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-31 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307283#comment-15307283 ] Taher Alkhateeb commented on OFBIZ-6783: Hi Jacopo, The patch you provided breaks in eclipse. I

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-31 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307272#comment-15307272 ] Taher Alkhateeb commented on OFBIZ-6783: Nice catch Jacopo, I always forget to do a second grep

RE: proposal to remove cobertura and sonar from ofbiz

2016-05-30 Thread Taher Alkhateeb
hesitate to commit before I get one or two feedbacks. Thank you in advance for your help. Taher Alkhateeb From: Taher Alkhateeb [mailto:slidingfilame...@gmail.com] Sent: 27 May 2016 11:49 To: OFBIZ Development Mailing List Subject: Re: proposal to remove cobertura and sonar from ofbiz

Re: Custom ClassLoader in OFBiz

2016-05-30 Thread Taher Alkhateeb
sual, I'll put the attachments in JIRA before committing to make sure everyone is aligned on this. Regards, Taher Alkhateeb On Mon, May 30, 2016 at 1:00 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Hi Taher, > > as mentioned in previous posts by Jacques and you

[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-05-30 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306405#comment-15306405 ] Taher Alkhateeb commented on OFBIZ-6986: By the way, I think

Re: Custom ClassLoader in OFBiz

2016-05-29 Thread Taher Alkhateeb
ased-OFBiz-framework-td1929599.html and https://sourceforge.net/projects/ofbiz-osgi/ But the implementation I'm thinking of is different in that each component is a bundle, not the whole framework. What do you think? Taher Alkhateeb On Sun, May 29, 2016 at 2:25 PM, Jacques Le Roux < jacqu

Custom ClassLoader in OFBiz

2016-05-28 Thread Taher Alkhateeb
an exception. I guess my question is: Why does ofbiz have a custom ClassLoader? Why bypassing the bootstrapping loader and even then, why not use one of the standard JDK implementations in the ClassLoader hierarchy. I really appreciate your insights on this. Taher Alkhateeb

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-05-27 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch This patch has reference to the thread http

Re: proposal to remove cobertura and sonar from ofbiz

2016-05-27 Thread Taher Alkhateeb
cobertura is the best coverage tool to use with ofbiz and I am definitely interested in reintroducing it in the future. I won't commit anything to give time for everyone to test and/or contribute more to this thread. Cheers Taher Alkhateeb On Fri, May 27, 2016 at 10:00 AM, Sharan-F <shara

Re: proposal to remove cobertura and sonar from ofbiz

2016-05-27 Thread Taher Alkhateeb
> > Jacques > > > Le 26/05/2016 à 19:24, Taher Alkhateeb a écrit : > >> Hi Adam >> >> Ok your objection is a good enough "no" for me to back off. I will try to >> think of a way to work on the integration as you suggested. >> >>

Re: proposal to remove cobertura and sonar from ofbiz

2016-05-26 Thread Taher Alkhateeb
lace. I am trying as much as I can to "cut out" code until some one says no like your good self. I will fix the build.xml to ensure correct behavior in cobertura. Taher Alkhateeb On Thursday, 26 May 2016, Adam Heath <doo...@brainfood.com> wrote: > Let me restate, do not remov

Re: Framework & Code Re-Factoring: Maintaining Quality

2016-05-26 Thread Taher Alkhateeb
activity and when you write beautiful clear code you are showing appreciation and respect to your fellow programmers. I don't know how to put that last part in the guidelines :) but this is definitely from the heart. Taher Alkhateeb On Thursday, 26 May 2016, Sharan-F <sharan.f...@gmail.com>

proposal to remove cobertura and sonar from ofbiz

2016-05-26 Thread Taher Alkhateeb
would not use the existing code anyway, I would just wipe it all out and start fresh. I'm not sure whether we need to vote on this? Appreciate your feedback. Taher Alkhateeb

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-25 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300278#comment-15300278 ] Taher Alkhateeb commented on OFBIZ-6783: I agree totally, things should be fixed, but one thing

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-25 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300171#comment-15300171 ] Taher Alkhateeb commented on OFBIZ-6783: I'm a bit lost now. First, the test case above &quo

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-25 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299782#comment-15299782 ] Taher Alkhateeb commented on OFBIZ-6783: Hi jacques, Is this behavior non existent pre patch

Re: Deleting CommonsDaemonStart.java

2016-05-24 Thread Taher Alkhateeb
interface. This is the main reason why I am now able to refactor so much after I eliminated those damn args that were jumping in my face everywhere I look. Cheers Taher Alkhateeb On Tue, May 24, 2016 at 10:34 PM, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: > Hi Taher, &g

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-24 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298099#comment-15298099 ] Taher Alkhateeb commented on OFBIZ-6783: Thank you Jacopo and Gil for your valuable feedback. I

RE: Deleting CommonsDaemonStart.java

2016-05-22 Thread Taher Alkhateeb
on this would help though. Thank you for your help! Taher Alkhateeb -Original Message- From: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] Sent: 17 May 2016 10:54 To: dev@ofbiz.apache.org Subject: Re: Deleting CommonsDaemonStart.java I second this approach

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-05-22 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch one more patch added, this adds further fine tuning

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-05-21 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch I just realized that the loaders and adminPortThread

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-21 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294984#comment-15294984 ] Taher Alkhateeb commented on OFBIZ-6783: Note: For testing purposes and for best results, we need

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-05-21 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch This is the latest version of the above mentioned patch

[jira] [Updated] (OFBIZ-6783) Refactor the start component

2016-05-20 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6783: --- Attachment: OFBIZ-6783.patch This is a new big patch, and all tests run from my side. I made

Changing the core API design

2016-05-20 Thread Taher Alkhateeb
Is anyone interested in working on this? already working on this? or think I'm going in the right direction? I'd love to hear some thoughts or even chat up on IRC or something. I appreciate hearing your thoughts. Taher Alkhateeb

Re: OFBiz Committers Survey

2016-05-19 Thread Taher Alkhateeb
Sharan the ranking for importance I assume 1 is highest importance. If not I need to retake the survey On May 19, 2016 7:46 PM, "Sharan-F" wrote: > Thanks guys for responding so quickly. > > It is only 10 questions so I think it's straightforward and very quick to > do. >

Re: OFBiz Committers Survey

2016-05-19 Thread Taher Alkhateeb
Done here too On May 19, 2016 7:23 PM, "Nicolas Malin" wrote: > done, > > thks Sharan for this initiative > > Nicolas > > Le 19/05/2016 15:24, Sharan-F a écrit : > >> Hi Everyone >> >> I've sent out the survey today so all our committers (including emeritus >> and >>

Re: svn commit: r1744537 - /ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java

2016-05-19 Thread Taher Alkhateeb
: StartupCommandUtil Taher Alkhateeb On May 19, 2016 3:48 PM, "Pierre Smits" <pierre.sm...@gmail.com> wrote: Hi Taher, Shouldn't the '+6' element in the {code} HelpFormatter.DEFAULT_WIDTH {code} code change be something that users want to configure? Best regards, Pierre Smits

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-19 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290813#comment-15290813 ] Taher Alkhateeb commented on OFBIZ-6783: done in r1744547. > Refactor the start compon

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-19 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290729#comment-15290729 ] Taher Alkhateeb commented on OFBIZ-6783: Ok, committed in r1744537. The screen width for commons

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-19 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290671#comment-15290671 ] Taher Alkhateeb commented on OFBIZ-6783: Yeah I see why you got confused by that. So

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-19 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290661#comment-15290661 ] Taher Alkhateeb commented on OFBIZ-6783: Also another commit in r1744528 to clarify the usage

[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-19 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290652#comment-15290652 ] Taher Alkhateeb commented on OFBIZ-6783: Hmmm, definitely worth investigating. It is my intention

<    9   10   11   12   13   14   15   16   17   18   >