Hi Habs,
El dom., 2 sept. 2018 a las 11:42, Harbs () escribió:
> I found the problem.
>
> Carlos, I don’t know why you changed the tokens in the config files, but
> changing them made them unrecognized and caused the FlexUnit tests to fail.
>
>
I thought the tokens you refer was not correctly
It looks like the merge from MXRoyale has problems.
DataContainerView has none of the changes that were done in MXRoyale (among
other things)
DataContainerView got all the methods that were originally in
DataContainerBase, but those changes did not survive the merge…
Fun, fun… ;-)
Harbs
>
Now that I’m able to compile, I started testing the current state…
Why was DataContainerBase changed?
DataContainerBase.removeAllItemRenderers no longer exists.
DataItemRendererFactoryForArrayList.dataProviderChangeHandler calls
dataGroup.removeAllItemRenderers() on a List which now fails with
I found the problem.
Carlos, I don’t know why you changed the tokens in the config files, but
changing them made them unrecognized and caused the FlexUnit tests to fail.
I reverted those changes. I don’t know what effects these changes had on the
Maven build.
Harbs
> On Sep 2, 2018, at
Both the develop branch and the merge branch are failing while building Basic.
The tests are failing:
The revert-refactor branch (which I have been mostly using lately) compiles
with no issues.
[echo] Compiling FlexUnitRoyaleApplication.swf
[echo] ROYALE_HOME: /Apache/royale-asjs
Carlos,
I will work on Monday on that. I'm going to take the simplest blog example
and analyze why it is not displaying.
DataGroup has definitely some conflicts, but I tried Data Binding blog
example and it didn't work. - In that case I got some errors - you can
check on your own if you have
Hi Alex, Piotr,
I merged few latest changes and I did and try integration branch.
Maven build pass localy wich is good! :)
But unfortunately some things are not right and Jewel Example doesn't work.
Don't know about MXRoyale, that Alex can report if changes work or not.
Some of the problems are
Please remember that an integration branch contains changes from two branches
and when files get moved around, it is possible for changes to get out of sync.
What is in the develop branch may not be the "latest".
Thanks,
-Alex
On 8/31/18, 8:08 AM, "Piotr Zarzycki" wrote:
I just merged
Ok Piotr, I think that's better, I'll see as soon as I end here
Thanks! :)
El vie., 31 ago. 2018 a las 17:08, Piotr Zarzycki (<
piotrzarzyck...@gmail.com>) escribió:
> I just merged to that branch latest changes from develop. Once you finish
> whatever you are doing, switch there and play with
I just merged to that branch latest changes from develop. Once you finish
whatever you are doing, switch there and play with it yourself. There is
nothing to discuss blindly before you didn't touch that branch.
Thanks,
Piotr
pt., 31 sie 2018 o 17:01 Piotr Zarzycki
napisał(a):
> Carlos,
>
> I
Carlos,
I cannot change it because itemRendererParent field is type of
IItemRendererParent
[1] and that interface doesn't contains that method. Link [1] is pointing
to develop branch, but that interfaces looks
exactly the same in integration branch.
[1]
Piotr,
what I'm saying is that the whole fiel is created by me, and you have a
line of code that is different to what I have in develop. So something is
wrong in the merge to the integration branch. The line of code I'm posting
is the right one and the one you should have in the integration
Carlos,
Are you using this branch ?
https://github.com/apache/royale-asjs/tree/feature/Merge_MXRoyale_To_Develop
Above branch need to be tested and my previous link pointing to sources
from that branch.
Thanks,
Piotr
pt., 31 sie 2018 o 15:39 Carlos Rovira napisał(a):
> Hi Piotr,
>
> I don't
Hi Piotr,
I don't have that line:
itemRendererParent.removeItemRenderer(processedRow);
I have this in develop:
itemRendererParent.removeElement(processedRow);
How is this possible? is very strange :?
The item renderer is removed in the loop, the last line is to remove the
row (tr) element
No this is not that line. That's the next one which is commented right now.
[1]. Uncomment line to see error. Maven is failing with error which is
valid[2]
[1]
Piotr,
let me see if I understand the problem. That line:
itemRendererParent.removeItemRenderer(ir);
is making compilation fail?
That would be very strange since my compilation succeeded. and seems the
line is ok. If so it could be a similar problem to the one we saw recently
in witch
Hi Piotr,
thanks! :)
as I have some things on my plate, as I finish and upload I'll give a try,
hopefully tomorrow. Since Harbs can test until Monday I think I have some
room to fix some important points that I'd like to go in this release:
* DateField : DateChooser popup doesn't close when
Hi Carlos,
Ok understand. Thanks for explanation. If you could look into that how to
achieve that without build fail that would be great.
Piotr
pt., 31 sie 2018 o 15:11 Carlos Rovira napisał(a):
> Hi Piotr,
>
> Table component uses TBodyContentArea as IContentView instead of DataGroup,
> so
Hi Piotr,
Table component uses TBodyContentArea as IContentView instead of DataGroup,
so the IItemRendererParent needs its own implementation.
Inside TBody(), we have each item render as a TableRow (), that
has inside a TableCell () and then the TableItemRenderer.
So when adding, removing, and so
I’ll try to work on it on Sunday.
> On Aug 31, 2018, at 3:29 PM, Piotr Zarzycki wrote:
>
> Guys,
>
> ANT and Maven build on branch is working right now. Please test your stuff.
>
> Carlos,
>
> Please take a look into RemoveTableItemRendererForArrayListData because I
> have commented out that
Guys,
ANT and Maven build on branch is working right now. Please test your stuff.
Carlos,
Please take a look into RemoveTableItemRendererForArrayListData because I
have commented out that line. Probably something won't work. Let me know
how it's looks like.
If you won't have time next wee let
Harbs,
Can you jump to feature/Merge_MXRoyale_To_Develop and try build there? It
will help me with all of that. This branch contains merged develop and
MXRoyale.
I'm assuming you are using ANT.
As for that line in DataGridView I have change it to DataGridColumnList.
Please make changes if needed
The build passes for me on the latest develop branch using ant.
Are you building with ant or maven?
> On Aug 31, 2018, at 2:13 PM, Harbs wrote:
>
> Scratch that.
>
> It does have an itemRenderer property and it inherits from
> IItemRendererProvider
>
>> On Aug 31, 2018, at 1:18 PM, Harbs >
Scratch that.
It does have an itemRenderer property and it inherits from IItemRendererProvider
> On Aug 31, 2018, at 1:18 PM, Harbs wrote:
>
> That change should be reverted. I added it to try and fix an issue with
> Express, but Express data grids don’t mix with Basic columns.
>
>> On Aug
Hi Carlos,
Question to one of your class. Why are you doing two times removing [1] and
couple of lines later you are doing removeElement ? It shouldn't event work
because there is no method removeElement in that interface.
[1]
That change should be reverted. I added it to try and fix an issue with
Express, but Express data grids don’t mix with Basic columns.
> On Aug 31, 2018, at 12:37 PM, Piotr Zarzycki
> wrote:
>
> Hi Harbs,
>
> Some time ago you have added interface IDataGridColumnList [1]. It is used
> here
Hi Harbs,
Some time ago you have added interface IDataGridColumnList [1]. It is used
here [2], couple of lines later there is assignment
list.itemRenderer = dataGridColumn.itemRenderer;
But that interface doesn't have itemRenderer property and build is
failing - locally. How actually it is
Piotr,
for me its ok, but only want to point something important. I think we all
invested many emails, hours in discussing about this. I think all positions
are clear. I think we can discuss if things to bring to the plate are new,
but I'm afraid it could not be. My position is that we all can
Hi Carlos,
Please do not move anything more. I think I had enough problems with
current situations. I will deal with all of that as is.
My suggestion is to restart discussion about all of that stuff after
release.
Thanks,
Piotr
On Fri, Aug 31, 2018, 12:18 AM Carlos Rovira
wrote:
> Hi,
>
> as
Hi,
as we discussed, the package names was the revert we said to do, so when we
do a refactor of that package names, will be more consistent.
Regarding movement of pieces, in the case of DataGroup I can move it from
Core to Basic and create a version for Jewel.
Let me know if this is ok for you.
I was also thinking that this release won't have that changes, but
unfortunately they are there. I had big headache to make it working.
Thank you Alex. I will try to deal with all of that.
czw., 30 sie 2018 o 19:12 Alex Harui napisał(a):
> I fixed the Maven build in feature/MXRoyale and merged
I fixed the Maven build in feature/MXRoyale and merged it into the integration
branch. However, the Maven build in the integration branch is still failing.
It appears to be because DataGroup got moved from Basic to Core. The Ant build
should be failing there too. I was under the impression
Great! Thanks Alex!
czw., 30 sie 2018 o 18:05 Alex Harui napisał(a):
> I will fix the Maven build in feature/MXRoyale then you can pull those
> changes into the integration branch.
>
> -Alex
>
> On 8/30/18, 7:42 AM, "Piotr Zarzycki" wrote:
>
> Hi Carlos,
>
> Nope. I build repo only
Hi Carlos,
Nope. I build repo only using ANT. Do you know how to fix that ? Probably I
missed some conflicts, not sure why Maven complaining. :) If you won't have
time I will look into that tomorrow.
Thanks,
Piotr
czw., 30 sie 2018 o 16:24 Carlos Rovira
napisał(a):
> Hi Piotr,
>
> I switched
Hi Piotr,
I switched to the feature/Merge_MXRoyale_To_Develop
then try to pass maven and fails just at the begining
I saw that has 2 rat check fails, so I fixed it
but now I'm seeing more problems
Hi Piotr,
of course, I'll try all Jewel examples and report if I find some isuue.
Thanks!
El jue., 30 ago. 2018 a las 15:33, Piotr Zarzycki (<
piotrzarzyck...@gmail.com>) escribió:
> Hi Alina,
>
> I'm working on preparation to release next version of Royale. One of the
> steps were to merge
Hi Alina,
I'm working on preparation to release next version of Royale. One of the
steps were to merge everything what is in MXRoyale branch to develop. I
just finished it and everything what was in MXRoyale and develop now is
being merged to special branch feature/Merge_MXRoyale_To_Develop.
Hi Piotr,
the recommended way is to create a integration branch, moreover since
MXRoyale has gone many time in its own way. Then solve conflicts in that
branch until you see is stable and all is compiling and working fine as
expected, then merge into develop the integration branch.
Good luck! :)
Master and agent have their own root folders for projects. I think Agent is
running in c:\Jenkins\workspace and master may be running in wherever APPDATA
is pointing. In theory, royale-compiler and royale-typedefs should be able to
be built off master, and the other builds should be able to
You should not have to merge develop into feature/MXRoyale. I would discourage
doing so as it could break Alina or me or anyone else using those nightlies.
Try to merge from feature/MXRoyale to develop, deal with conflicts, then see if
tourdeflex works. If it does, then you can claim success.
If I would like to merge feature/MXRoyale to develop, should I first merge
develop into that branch and than go back to the develop with the results ?
Thanks,
Piotr
wt., 28 sie 2018 o 18:49 Piotr Zarzycki
napisał(a):
> I see failing mustellaresultsparser [1] [2] It's pointing for some
>
I see failing mustellaresultsparser [1] [2] It's pointing for some reason
to c:/jenkins/workspace instead those one in Program Files. How this path
is appear there ? What actually is ${env.APPDATA} ?
*[1]
Hi Harbs,
Please give me some sign here once you will be done with all your changes!
Thanks,
Piotr
pon., 27 sie 2018 o 20:12 Harbs napisał(a):
> I have found that there’s an error with ACE on multiple machines. I was
> only able to get it to build by first running ant on the typedefs repo and
I have found that there’s an error with ACE on multiple machines. I was only
able to get it to build by first running ant on the typedefs repo and then the
asjs repo succeeded.
On my Mac, it worked fine, so I’m not really sure what triggered the problem.
Maybe this is related to the failures
Hi Alex,
Thanks for the input! I will try to merge tomorrow MXRoyale branch to
develop than. We can make another release once you push more stuff related
to Tour De Flex.
Piotr
pon., 27 sie 2018 o 19:25 Alex Harui napisał(a):
> I thought I'd sent an email about this, but I can't find it so I
I thought I'd sent an email about this, but I can't find it so I guess not.
For some reason, some weeks ago, the builds began to fail on apacheroyaleci.
The only way I was able to fix it was to create a Jenkins agent and move builds
that needed the screen (to run tests) to that agent. In
I will start experimenting with release process tomorrow. Depends how much
issues I will have I hope to start properly everything before the end of
the week.
I'm still wondering whether MXRoyale branch is good for merge.
Thanks,
Piotr
On Mon, Aug 27, 2018, 5:55 PM Carlos Rovira wrote:
>
That's great Piotr!, Let's see if this fixes it now.
I'd near to finish work and ComboBox/DropDownList, this and some issues on
Tablet/List will be great to have in 0.9.3 to make people starting to use
have solved this important issues. Hope I could get this working before
starting the release
I have switched two build on jenkins to "master" royale-asjs_jsonly and
royale-asjs - It seems that this fixes issue with build. - Not sure if it
can stay like that.
I'm working right now to fix build for module Icons.
Thanks,
Piotr
pon., 27 sie 2018 o 15:06 Piotr Zarzycki
napisał(a):
> I'm
I'm going to commit some changes to build.xml, if it won't work I will
revert it.
pon., 27 sie 2018 o 14:12 Piotr Zarzycki
napisał(a):
> I looked into the current failing build [1]. It complaining that "Basedir
> c:\jenkins\workspace\royale-typedefs does not exist" and it would be
> correct,
I looked into the current failing build [1]. It complaining that "Basedir
c:\jenkins\workspace\royale-typedefs does not exist" and it would be
correct, because "royale-typedefs" is being build to that folder "C:\Program
Files (x86)\Jenkins\workspace\royale-typedefs".
Does anyone changed that and
I'm going to notify Infra about problem with build on b.a.o. Locally
everything is perfectly fine. I will attach dev list and write email on
us...@infra.apache.org.
Thanks,
Piotr
pt., 24 sie 2018 o 16:05 Carlos Rovira napisał(a):
> Great Piotr!,
>
> as you said discussion is not over, but I
Great Piotr!,
as you said discussion is not over, but I think we discussed almost lots of
things and plans was left for releases "post 0.9.3". In fact I revert
package name changes that was the only point that was making us not release
0.9.3. So I think we are at this point safe to release 0.9.3,
Hi Om,
I have no objections to that. The question whether from the technical point
of view Maven which is I believe big part of release process won't
complain. We will see.
Thanks for confirmation,
Piotr
pt., 24 sie 2018 o 00:25 OmPrakash Muppirala
napisał(a):
> Yes, since 0.9.3 was already
Yes, since 0.9.3 was already pushed out via npm [1], it would be best if we
skip to 0.9.4
Thanks,
Om
[1] https://www.npmjs.com/package/@apache-royale/royale-js
On Thu, Aug 23, 2018 at 1:53 PM Piotr Zarzycki
wrote:
> Hi Guys,
>
> It's been a while since last version of Royale was released. I
301 - 355 of 355 matches
Mail list logo
