Re: Review Request 72882: SENTRY-2558: Issue in creating full snapshot when the storage descriptor for a table is null.

> On Sept. 17, 2020, 3:44 p.m., Na Li wrote: > > Ship It! Thanks for the review. Will merge the change after the unit tests are green. - kalyan kumar --- This is an automatically generated e-mail. To reply, visit:

Review Request 72882: SENTRY-2558: Issue in creating full snapshot when the storage descriptor for a table is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72882/ --- Review request for sentry and Na Li. Bugs: SENTRY-2558

Re: Review Request 72704: SENTRY-2422: HMS synchronization is causing multiple entries of the same ID in SENTRY_HMS_NOTIFICATION_ID

> On July 24, 2020, 4 p.m., kalyan kumar kalvagadda wrote: > > Lina, > > > > Do you why are we ssting this issue? Notication should be processed by one > > sentry lender and there is only one thread the processes the notfications > > and updates the database. > > Na Li wrote: > Kalyan, >

Re: Review Request 72704: SENTRY-2422: HMS synchronization is causing multiple entries of the same ID in SENTRY_HMS_NOTIFICATION_ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72704/#review221367 --- Ship it! Change looks good, you need to understand that this

Re: Review Request 72704: SENTRY-2422: HMS synchronization is causing multiple entries of the same ID in SENTRY_HMS_NOTIFICATION_ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72704/#review221362 --- Lina, Do you why are we ssting this issue? Notication should be

Review Request 72706: SENTRY-2557: Queries are running too slow after when there are more than 4k roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72706/ --- Review request for sentry and Na Li. Repository: sentry Description ---

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/#review219106 --- Ship it! Ship It! - kalyan kumar kalvagadda On Dec. 22,

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

> On Dec. 20, 2019, 11:07 p.m., Vihang Karajgaonkar wrote: > > sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/SimpleCacheProviderBackend.java > > Lines 97 (patched) > > > > > >

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/#review219091 ---

Re: Review Request 71901: SENTRY-2540: Only use SELECT action for filter SHOW DATABASES and SHOW TABLES command based on configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71901/#review219044 --- Ship it! Ship It! - kalyan kumar kalvagadda On Dec. 13,

Re: Review Request 71901: SENTRY-2540: Only use SELECT action for filter SHOW DATABASES and SHOW TABLES command based on configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71901/#review219015 --- Code change looks good. Please add unit tests to cover the same.

Re: Review Request 71532: SENTRY-2533: The UDF in_file should be blacked default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71532/#review218205 --- Ship it! Code change looks good. - kalyan kumar kalvagadda

Re: Review Request 71039: SENTRY-2528: Format exception when fetching a full snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71039/#review216448 ---

Re: Review Request 70337: SENTRY-2511: Debug level logging on HMSPaths significantly affects performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70337/#review214210 --- Ship it! Looks good. - kalyan kumar kalvagadda On March 29,

Re: Review Request 70004: SENTRY-2496 Support multi-field attribute based document level controls for Solr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70004/#review213169 --- Ship it! Ship It! - kalyan kumar kalvagadda On Feb. 21,

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/ --- (Updated Feb. 23, 2019, 5:28 a.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

> On Feb. 22, 2019, 8:58 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 507 (patched) > > > > > > should this be removed if it has no authz obj? >

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

> On Feb. 22, 2019, 8:46 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 689 (original), 694 (patched) > > > > > > Kalyan, do you mean "If we use the

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

> On Feb. 22, 2019, 6:48 p.m., Haley Reeve wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 689 (original), 694 (patched) > > > > > > Why the change from sets to

Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/ --- Review request for sentry, Arjun Mishra, Haley Reeve, and Na Li. Bugs:

Re: Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/#review213031 --- Ship it! Ship It! - kalyan kumar kalvagadda On Feb. 20,

Re: Review Request 70004: SENTRY-2496 Support multi-field attribute based document level controls for Solr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70004/#review212989 ---

Re: Review Request 70013: SENTRY-2501: Add cache for HMS server filtering hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70013/#review212980 --- Ship it! Ship It! - kalyan kumar kalvagadda On Feb. 19,

Re: Review Request 70013: SENTRY-2501: Add cache for HMS server filtering hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70013/#review212962 ---

Re: Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/#review212960 ---

Re: Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/#review212959 ---

Re: Review Request 69975: SENTRY-2495: Support Conjunctive Matching in Solr QueryDocAuthorizationComponent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69975/#review212872 --- Ship it! Ship It! - kalyan kumar kalvagadda On Feb. 15,

Re: Review Request 69619: SENTRY-2482: Sentry Solr to support multi-attribute document level security

> On Feb. 12, 2019, 8:38 p.m., kalyan kumar kalvagadda wrote: > > Tristan Stevens, > > > > This patch has two enhancements > > 1. Subset Match Filtering/ > > 2. User Attribute Filter > > > > Having multiple enhacements in single commit is not easy to understand. Can > > you seperate them to

Re: Review Request 69619: SENTRY-2482: Sentry Solr to support multi-attribute document level security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69619/#review212760 --- Tristan Stevens, This patch has two enhancements 1. Subset

Re: Review Request 69941: SENTRY-2494: Fix TestRollingFileWithoutDeleteAppender test case testFileNamePattern

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69941/#review212703 --- Ship it! Ship It! - kalyan kumar kalvagadda On Feb. 11,

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212577 --- Ship it! - kalyan kumar kalvagadda On Feb. 5, 2019, 12:01

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

> On Feb. 5, 2019, 11:13 p.m., Arjun Mishra wrote: > > Left last bits of comments. Please fix them and shit it Ok. I will fix them and push the changes. - kalyan kumar --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

> On Feb. 5, 2019, 8:25 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > > Line 124 (original), 124 (patched) > > >

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212505 ---

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/ --- (Updated Feb. 5, 2019, 12:01 a.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/ --- (Updated Feb. 1, 2019, 10:22 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

> On Feb. 1, 2019, 4:34 p.m., Arjun Mishra wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 468 (original), 472 (patched) > > > > > > Log here? added log to

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

> On Feb. 1, 2019, 4:48 p.m., Arjun Mishra wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > > Line 199 (original), 203 (patched) > > > > > > Why

Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/ --- Review request for sentry, Arjun Mishra, Haley Reeve, and Na Li. Bugs:

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/#review212291 --- Fix it, then Ship it! Please consider the cosmetic comments

Re: Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69841/#review212388 --- Looks good. Wiating for the tests to pass to give a +2. - kalyan

Re: Review Request 69840: SENTRY-2491: Sentry High availability unit tests run into deadlock sometimes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69840/#review212387 --- Ship it! Ship It! - kalyan kumar kalvagadda On Jan. 28,

Re: Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

> On Jan. 28, 2019, 1:55 a.m., kalyan kumar kalvagadda wrote: > > Idea here is to make sure that hive client knows the details of the user > > who is sending the request. In this specific case, hive should know the > > details of the user who running sentry service. Using > >

Re: Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69841/#review212365 --- Idea here is to make sure that hive client knows the details of

Re: Review Request 69840: SENTRY-2491: Sentry High availability unit tests run into deadlock sometimes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69840/#review212353 --- Fix it, then Ship it! Wait for the test to complete.

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/#review212296 ---

Re: Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69832/#review212289 --- Fix it, then Ship it! Fix it and ship it.

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

> On Sept. 4, 2018, 6:32 p.m., Arjun Mishra wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 74 (patched) > > > > > > This condition should be

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

> On Sept. 5, 2018, 8:27 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 74 (patched) > > > > > > we should seperate the logic for

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68622/ --- (Updated Jan. 24, 2019, 6:38 p.m.) Review request for sentry and Arjun Mishra.

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

- kalyan kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68622/#review208319 --- On Jan. 24, 2019, 6:38 p.m., kalyan kumar

Re: Review Request 69353: SENTRY-2454: Add new sentry store api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/ --- (Updated Dec. 18, 2018, 11:23 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69561: SENTRY-2480: Change processDropDatabase to call removeAllPaths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69561/#review211257 --- Ship it! Looks good. Wait for the tests to complete. - kalyan

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211244 --- Arjun, Fix for SENTRY-2249 solves this issue. There is no new

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211207 --- Arjun, Fix for SENTRY-2249 solves this issue. There is no new

Re: Review Request 69353: SENTRY-2454: Add new sentry store api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/ --- (Updated Dec. 11, 2018, 12:28 a.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211168 ---

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

> On Dec. 7, 2018, 7:40 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3932 (patched) > > > > > > If column

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- (Updated Dec. 7, 2018, 3:14 p.m.) Review request for sentry and Sergio Pena.

Review Request 69517: SENTRY-2475: Add the list of authorizables to the export file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69517/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2475

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/ --- (Updated Dec. 7, 2018, 12:05 a.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

> On Dec. 6, 2018, 5:15 p.m., Sergio Pena wrote: > > I'd like to see the part of the SentryPolicyStoreProcessor with this patch > > to give me a bette idea of how both classes will work together. I saw that > > the previous export method requires role -> privileges mapping, but this > >

Re: Review Request 69484: SENTRY-2460: Export sentry permission information to HDFS location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69484/ --- (Updated Dec. 6, 2018, 9:19 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- (Updated Dec. 6, 2018, 8:23 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- (Updated Dec. 5, 2018, 11:23 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- (Updated Dec. 5, 2018, 10:19 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69484: SENTRY-2460: Export sentry permission information to HDFS location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69484/ --- (Updated Dec. 5, 2018, 10:18 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 69415: SENTRY-2463: Revoking ALL or * should revoke any other privilege on the entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69415/#review210983 --- I understand there is a gap here but we should be carefull in

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210980 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 29,

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 29, 2018, 10:14 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

> On Nov. 29, 2018, 6:44 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 176 (patched) > > > > > > do you want

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 29, 2018, 6:32 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 29, 2018, 6:29 p.m.) Review request for sentry, Arjun Mishra, Na

Review Request 69484: SENTRY-2460: Export sentry permission information to HDFS location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69484/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2460

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210939 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

> On Nov. 20, 2018, 5:20 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Line 36 (original), 45 (patched) > > > > > >

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 21, 2018, 7:48 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

> On Nov. 1, 2018, 1:35 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 37 (patched) > > > > > > This is

Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2454

Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2452

Re: Review Request 69260: SENTRY-2441: When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69260/ --- (Updated Nov. 6, 2018, 6:08 p.m.) Review request for sentry, Arjun Mishra, Na

Review Request 69260: SENTRY-2441: When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69260/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/#review210333 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 2,

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/#review210331 --- Sergio, I remeber we taking about supporting multiple versions

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/#review210253 --- pom.xml Lines 216-231 (patched)

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Oct. 31, 2018, 11:28 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69201: SENTRY-2436 Add annotations for classes that are used in binding as public

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69201/#review210239 --- Xinran, What is the purpose of such annotation? - kalyan kumar

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

> On Oct. 22, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > > Lines 153 (patched) > > > > > > is there an optimal value

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Oct. 31, 2018, 12:58 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69204: SENTRY-2437: When granting privileges a single transaction per grant causes long delays

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69204/#review210171 --- Fix it, then Ship it! With this change you are able to

Re: Review Request 69175: SENTRY-2433: Dropping object privileges does not include update of dropping user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69175/#review210139 --- Fix it, then Ship it! Fix it and ship it.

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69122/#review209972 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 24,

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69122/#review209932 ---

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

> On Oct. 22, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > > Lines 152 (patched) > > > > > > how can we make this

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/ --- (Updated Oct. 22, 2018, 2:42 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

> On Oct. 19, 2018, 7:12 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 187 (patched) > > > > > > should this

Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/ --- (Updated Oct. 19, 2018, 4:53 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68968/ --- (Updated Oct. 18, 2018, 5:38 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

> On Oct. 9, 2018, 6:19 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > > Lines 124 (patched) > > > > > > Can we have one

  1   2   3   4   5   >