[jira] [Commented] (SLING-9060) Improve Redirect handling for Resources that can be served from alternative URLs

2020-04-09 Thread Ian Boston (Jira)
[ https://issues.apache.org/jira/browse/SLING-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079086#comment-17079086 ] Ian Boston commented on SLING-9060: --- For completeness,  it was decided not to pursue this issue

[jira] [Resolved] (SLING-9060) Improve Redirect handling for Resources that can be served from alternative URLs

2020-04-09 Thread Ian Boston (Jira)
[ https://issues.apache.org/jira/browse/SLING-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston resolved SLING-9060. --- Resolution: Won't Fix > Improve Redirect handling for Resources that can be served from alternat

Re: Redirect Provider

2020-02-17 Thread Ian Boston
Hi, After discussing internally I have updated the patch to use and interface, that hopefully will unblock the -1. The PR and issue has been reopened. Best Regards Ian On Fri, 14 Feb 2020 at 15:06, Ian Boston wrote: > Hi, > The API PR attracted a -1 which I understand and respect. >

[jira] [Reopened] (SLING-9060) Improve Redirect handling for Resources that can be served from alternative URLs

2020-02-17 Thread Ian Boston (Jira)
[ https://issues.apache.org/jira/browse/SLING-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston reopened SLING-9060: --- Trying again to find a compromise. > Improve Redirect handling for Resources that can be served f

Re: Redirect Provider

2020-02-14 Thread Ian Boston
, 10 Feb 2020 at 16:28, Ian Boston wrote: > > Let me know whether that is enough or it needs expansions. > > +1, works. > > Interestingly it did need all occurrences of bundles pointing to SNAPSHOT > Sling API bundles to be updated, and for those bundles to depend on

[jira] [Resolved] (SLING-9060) Improve Redirect handling for Resources that can be served from alternative URLs

2020-02-14 Thread Ian Boston (Jira)
[ https://issues.apache.org/jira/browse/SLING-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston resolved SLING-9060. --- Resolution: Won't Fix API PR was voted -1 Closing as wont fix Will look for alternatives

Re: Redirect Provider

2020-02-10 Thread Ian Boston
had to be fixed before the tests would pass. Thanks for the comments on the PRs. I have tried to address them with more commits. Best Regards Ian On Sat, 8 Feb 2020 at 12:18, Robert Munteanu wrote: > Hi Ian, > > On Sat, 2020-02-08 at 09:48 +, Ian Boston wrote: > > Hi, > > The P

Re: Redirect Provider

2020-02-08 Thread Ian Boston
be great). Best Regards Ian On Sat, 8 Feb 2020 at 09:23, Ian Boston wrote: > Hi, > Opened [1] to track the work. > Best Regards > Ian > > 1 https://issues.apache.org/jira/browse/SLING-9060 > > On Wed, 5 Feb 2020 at 22:12, Ian Boston wrote: > >> Hi, >> O

[jira] [Commented] (SLING-9060) Improve Redirect handling for Resources that can be served from alternative URLs

2020-02-08 Thread Ian Boston (Jira)
[ https://issues.apache.org/jira/browse/SLING-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032861#comment-17032861 ] Ian Boston commented on SLING-9060: --- PRs  https://github.com/apache/sling-org-apache-sling-api/pull/17

[jira] [Assigned] (SLING-9060) Improve Redirect handling for Resources that can be served from alternative URLs

2020-02-08 Thread Ian Boston (Jira)
[ https://issues.apache.org/jira/browse/SLING-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston reassigned SLING-9060: - Assignee: Ian Boston > Improve Redirect handling for Resources that can be served f

Re: Redirect Provider

2020-02-08 Thread Ian Boston
Hi, Opened [1] to track the work. Best Regards Ian 1 https://issues.apache.org/jira/browse/SLING-9060 On Wed, 5 Feb 2020 at 22:12, Ian Boston wrote: > Hi, > Ok. > > o.a.s.api.redirect for the API, and a patch to the Get servlet to use the > API. > Will do PRs shortly. >

[jira] [Created] (SLING-9060) Improve Redirect handling for Resources that can be served from alternative URLs

2020-02-08 Thread Ian Boston (Jira)
Ian Boston created SLING-9060: - Summary: Improve Redirect handling for Resources that can be served from alternative URLs Key: SLING-9060 URL: https://issues.apache.org/jira/browse/SLING-9060 Project

Re: Redirect Provider

2020-02-05 Thread Ian Boston
Hi, Ok. o.a.s.api.redirect for the API, and a patch to the Get servlet to use the API. Will do PRs shortly. Best Regards Ian On Tue, 4 Feb 2020 at 14:13, Bertrand Delacretaz wrote: > On Tue, Feb 4, 2020 at 1:58 PM Ian Boston wrote: > > ...New package, agreed, n

Re: Redirect Provider

2020-02-04 Thread Ian Boston
Hi, New package, agreed, no ripples. o.a.s.api.response ? request & resource already exist, but no response. Best Regards Ian On Tue, 4 Feb 2020 at 10:14, Bertrand Delacretaz wrote: > On Tue, Feb 4, 2020 at 9:54 AM Radu Cotescu wrote: > > ...After Carsten’s detailed reasoning I guess it

Re: Redirect Provider

2020-02-04 Thread Ian Boston
> > AdaptTo makes both, implementation and usage much cleaner > > Carsten > > On 31.01.2020 04:15, Ian Boston wrote: > > Hi, > > I started with that service pattern, as you have suggested, but Carsten > > asked we used a provider with the adaptTo pattern. He can exp

Re: Redirect Provider

2020-01-31 Thread Ian Boston
Hi, I started with that service pattern, as you have suggested, but Carsten asked we used a provider with the adaptTo pattern. He can explain. He does that better. It made sense to me when he did. Best Regards Ian On Fri, 31 Jan 2020 at 12:02, Radu Cotescu wrote: > Hi Ian, > > I posted a

Re: Redirect Provider

2020-01-31 Thread Ian Boston
be used to allow setting headers for responses that then > continue through normal processing. (I know, the same can be achieved > using a servlet filter.) > > No hard opinions, just soft thoughts ;) > > Regards > Julian > > On Fri, Jan 31, 2020 at 11:00 AM Ian Bo

Re: Redirect Provider

2020-01-31 Thread Ian Boston
Jan 2020 at 08:49, Bertrand Delacretaz wrote: > Hi, > > On Fri, Jan 31, 2020 at 9:11 AM Ian Boston wrote: > .. > > 1 https://gist.github.com/ieb/5f217e2c160afb7bb4098bca99896621 > ... > > The RedirectResolver gets an HttpServletRequest, shouldn't that be a > Slin

Re: Redirect Provider

2020-01-31 Thread Ian Boston
Hi, Agreed. We should have the deprecation conversation in a separate thread. No rush. Here is a gist[1] of what is being proposed. It has had some input already from Carsten and Robert. On reflection we changed the signature of the provider to pass in an implementation of a class

Redirect Provider

2020-01-29 Thread Ian Boston
Hi, I have been talking with Carsten and Robert offline about a better solution to replace the URIProvider which to be frank, isn't really working for us. For those that don't know, its used inside the Slng Default Get servlet to allow that servlet to return a redirect instead of sending a stream

[jira] [Commented] (SLING-7510) UriProvider throws unchecked IllegalArgumentException that must be handled by consumers

2018-06-04 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499929#comment-16499929 ] Ian Boston commented on SLING-7510: --- The API was created being pragmatic rather than perfectionist

Re: Oak Server Bundle for 1.9 and 1.10

2018-02-28 Thread Ian Boston
Hi, On 28 February 2018 at 12:51, Robert Munteanu <romb...@apache.org> wrote: > Hi Ian, > > On Wed, 2018-02-28 at 11:39 +0100, Ian Boston wrote: > > Hi, > > This time last year we had a server bundle that worked against Oak > > 1.6 and > > in November 201

Oak Server Bundle for 1.9 and 1.10

2018-02-28 Thread Ian Boston
Hi, This time last year we had a server bundle that worked against Oak 1.6 and in November 2017 a bundle that worked against Oak 1.8. This caused some difficulties in Sling as there was a reasonable length of time between the 1.6 release and a 1.8 release with a lot of development on Oak 1.7

[jira] [Commented] (SLING-7350) StreamRendererServlet redirects HEAD requests to external uri if available

2018-02-14 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363637#comment-16363637 ] Ian Boston commented on SLING-7350: --- I have looked at this again and although the patch fixes

[jira] [Commented] (SLING-7350) StreamRendererServlet redirects HEAD requests to external uri if available

2018-01-03 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309646#comment-16309646 ] Ian Boston commented on SLING-7350: --- Patch LGTM. Could you open a pull request please

[jira] [Closed] (SLING-7156) SlingTldLocationsCache makes invalid assumptions about bundle entry URL's

2017-12-04 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston closed SLING-7156. - Released in Scripting JSP 2.3.4 > SlingTldLocationsCache makes invalid assumptions about bundle entry UR

[jira] [Closed] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-12-04 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston closed SLING-3317. - > Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, > 100% CPU

[RESULT] [VOTE] Release Apache Sling Scripting JSP version 2.3.4

2017-12-04 Thread Ian Boston
Hi, The vote has passed with the following result : +1 (binding): Carsten, Ian, Karl I will copy and release to the Sling dist directory and promote the artifacts to the central Maven repository. Best Regards Ian

Re: [VOTE] Release Apache Sling Scripting JSP version 2.3.4

2017-12-04 Thread Ian Boston
+1 Best Regards Ian On 30 November 2017 at 15:08, Karl Pauls <karlpa...@gmail.com> wrote: > +1 > > regards, > > Karl > > On Thu, Nov 30, 2017 at 3:54 PM, Carsten Ziegeler <cziege...@apache.org> > wrote: > > +1 > > > > > > Ian Boston

[VOTE] Release Apache Sling Scripting JSP version 2.3.4

2017-11-30 Thread Ian Boston
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12341395 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1822/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Resolved] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-11-29 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston resolved SLING-3317. --- Resolution: Fixed > Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, &g

[jira] [Commented] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-11-29 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270640#comment-16270640 ] Ian Boston commented on SLING-3317: --- Fixed by upgrading to 6.0.30, verified the fix in that version

[jira] [Assigned] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-11-29 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston reassigned SLING-3317: - Assignee: Ian Boston > Concurrent access to WeakHashMap in ConcurrentCache causes infinite l

[jira] [Commented] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-11-27 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266764#comment-16266764 ] Ian Boston commented on SLING-3317: --- [~takahito.kikuchi] has pointed out off list that bug is fixed

Re: Configuration Status dump.

2017-11-10 Thread Ian Boston
trand Delacretaz wrote > > Hi Ian, > > > > On Fri, Nov 10, 2017 at 1:44 PM, Ian Boston <i...@tfd.co.uk> wrote: > >> ...AFAICT at the moment the url is buried under a javascript button > which > >> builds > >> http://localhost:8080/system/console/st

Configuration Status dump.

2017-11-10 Thread Ian Boston
Hi, Is there a URL where its possible to get Sling to reliably download (using curl) a full configuration status dump zip (suitable authn/authz) AFAICT at the moment the url is buried under a javascript button which builds

Re: [VOTE] Apache Sling Servlets Get 2.1.30

2017-11-08 Thread Ian Boston
+1 Ian On 6 November 2017 at 13:28, Karl Pauls wrote: > I would like to call a vote on the following release, > > Apache Sling Servlets Get 2.1.30 > > We solved 1 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12342139 > > Staging

Re: [VOTE] Release Apache Sling Event Support version 4.2.10

2017-11-08 Thread Ian Boston
+1 Ian On 6 November 2017 at 16:10, Timothee Maret wrote: > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12341680 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1807/ > > You

[RESULT] [VOTE] Release Apache Sling API 2.16.4, JCR Resource Resolver 3.0.6, Default GET Servlets 2.1.28

2017-11-06 Thread Ian Boston
Hi, Thank you for voting. The vote has passed with the following result : +1 (binding): Carsten, Antonio, Karl, Ian I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Best Regards Ian

Re: [VOTE] Release Apache Sling API 2.16.4, JCR Resource Resolver 3.0.6, Default GET Servlets 2.1.29

2017-11-06 Thread Ian Boston
+1 Ian On 3 November 2017 at 10:39, Karl Pauls <karlpa...@gmail.com> wrote: > +1 > > regards, > > Karl > > On Fri, Nov 3, 2017 at 10:40 AM, Antonio Sanso <asa...@adobe.com.invalid> > wrote: > > +1 > > > > On Nov 2, 2017, at 5:49 P

Re: [VOTE] Release Apache Sling Service User Mapper 1.3.6

2017-11-02 Thread Ian Boston
+1 On 2 November 2017 at 16:15, Karl Pauls wrote: > I would like to call a vote on the following release, > > Apache Sling Service User Mapper 1.3.6 > > We solved 2 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12341841 > > Staging

[VOTE] Release Apache Sling API 2.16.4, JCR Resource Resolver 3.0.6, Default GET Servlets 2.1.29

2017-11-02 Thread Ian Boston
Hi, I would like to call a vote on the following release, Apache Sling API 2.16.4 Apache Sling JCR Resource Resolver 3.0.6 Apache Sling Default GET Servlets 2.1.29 We solved 11 issue in this release: *https://issues.apache.org/jira/projects/SLING/versions/12338864

[jira] [Reopened] (SLING-6609) Fix JSR305 annotations for ValueMap.get

2017-11-02 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston reopened SLING-6609: --- mvn clean javadoc:javadoc fails, due to this commit blocking releasing the bundle. Could you fix please

[jira] [Updated] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-10-25 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston updated SLING-3317: -- Fix Version/s: Scripting JSP 2.3.4 > Concurrent access to WeakHashMap in ConcurrentCache cau

[jira] [Commented] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-10-25 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218232#comment-16218232 ] Ian Boston commented on SLING-3317: --- Seeing this behaviour regularly with Oracle JDK 1.8.144

Re: What to do with github.com/apache/sling (was [git] Migration to git repositories sort of complete)

2017-10-23 Thread Ian Boston
help.github.com/articles/renaming-a-repository/ The other option is to transfer ownership of the repository. Git will also redirect. https://help.github.com/articles/about-repository-transfers/ Best Regards Ian On 23 October 2017 at 13:48, Robert Munteanu <romb...@apache.org> wrote: > On Su

[jira] [Resolved] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-23 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston resolved SLING-7140. --- Resolution: Fixed Fix Version/s: (was: Resource Resolver 1.5.32) Sling API Change made

Re: What to do with github.com/apache/sling (was [git] Migration to git repositories sort of complete)

2017-10-22 Thread Ian Boston
Hi, Good solution. One small modification to help anyone get to the old tree. Rather than switching the main branch and making it empty, if you branch trunk to a new branch "archive" and then make trunk empty as you suggest, it will be possible to point anyone who gets a 404 to the new "archive"

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-22 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214260#comment-16214260 ] Ian Boston commented on SLING-7140: --- Agreed. The version change in the ResourceResolver didn't feel

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-21 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213961#comment-16213961 ] Ian Boston commented on SLING-7140: --- FYI: here are all the commits related to this issue. https

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-21 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213959#comment-16213959 ] Ian Boston commented on SLING-7140: --- Did you see this commit ? https://github.com/apache/sling-org

[jira] [Commented] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-10-20 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212729#comment-16212729 ] Ian Boston commented on SLING-3317: --- Incorporating the patch into Servlets JSP 2.2.6 without and keeping

Re: What to do with github.com/apache/sling (was [git] Migration to git repositories sort of complete)

2017-10-20 Thread Ian Boston
/sling/network/members 2 https://github.com/447327642/sling On 20 October 2017 at 12:11, Robert Munteanu <romb...@apache.org> wrote: > Hi Ian, > > On Fri, 2017-10-20 at 11:04 +0100, Ian Boston wrote: > > BTW, > > Deleting github:apache/sling will 404 every reference to c

[jira] [Commented] (SLING-3317) Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2017-10-20 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212461#comment-16212461 ] Ian Boston commented on SLING-3317: --- SLING-3984 is not relevant here as this stack trace occurs when

Re: [git] Migration to git repositories sort of complete (was: Migration to git starting, please hold commits in 30 minutes from now)

2017-10-20 Thread Ian Boston
Thu, 2017-10-19 at 11:44 +0100, Ian Boston wrote: > > Hi, > > Some more appear to be empty. > > eg > > sling-org-apache-sling-api > > That's a good catch, somehow I missed it from the list. > > I made the following calculations: > > 1. we have 258 repositorie

[jira] [Updated] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-19 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston updated SLING-7140: -- Fix Version/s: Resource Resolver 1.5.32 API 2.16.4 JCR Resource

[jira] [Resolved] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-19 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Boston resolved SLING-7140. --- Resolution: Fixed > Support redirects to URLs provided by the underlying datast

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-19 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210903#comment-16210903 ] Ian Boston commented on SLING-7140: --- Applied in 2 commits due to the SVN to Git migration. https

Re: [git] Migration to git repositories sort of complete (was: Migration to git starting, please hold commits in 30 minutes from now)

2017-10-19 Thread Ian Boston
October 2017 at 08:55, Ian Boston <i...@tfd.co.uk> wrote: > Perfect. > Thanks > Best Regards > Ian > > On 19 October 2017 at 08:34, Robert Munteanu <romb...@apache.org> wrote: > >> On Thu, 2017-10-19 at 07:30 +0100, Ian Boston wrote: >> > Hi, &g

Re: RTC for Sling API change.

2017-10-19 Thread Ian Boston
Hi, I'll take the CTR route as there are no immediate objections to this, and the concept has already had lots of attention. Best Regards Ian On 18 October 2017 at 13:35, Ian Boston <i...@tfd.co.uk> wrote: > Hi, > I would like to commit the changes in SLING-7140 at [1]. The API Cha

Re: [git] Migration to git repositories sort of complete (was: Migration to git starting, please hold commits in 30 minutes from now)

2017-10-19 Thread Ian Boston
Perfect. Thanks Best Regards Ian On 19 October 2017 at 08:34, Robert Munteanu <romb...@apache.org> wrote: > On Thu, 2017-10-19 at 07:30 +0100, Ian Boston wrote: > > Hi, > > Thanks for working into the early hours to do this. > > > > So, IIUC, a pull request/

Re: [git] Migration to git repositories sort of complete (was: Migration to git starting, please hold commits in 30 minutes from now)

2017-10-19 Thread Ian Boston
Hi, Thanks for working into the early hours to do this. So, IIUC, a pull request/patch that was originally against the whole SVN repo now has to work out which parts are in Git and which parts and in SVN. For those parts that are in git, apply there are remove from the SVN patch. Once everything

RTC for Sling API change.

2017-10-18 Thread Ian Boston
Hi, I would like to commit the changes in SLING-7140 at [1]. The API Change adds 2 new interfaces to the Sling API bundle, hence the RTC, even though Sling might be more CTR. For those that have been involved in the ongoing discussions surrounding this issue, the patch no longer has any

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-10-18 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209242#comment-16209242 ] Ian Boston commented on SLING-7140: --- New Pull request created that has no dependencies on any changes

Re: [git] Migration scheduled for 18 Oct, 22:00 CEST and final notes

2017-10-18 Thread Ian Boston
Hi, Does that mean, every repo will have 1 pom.xml file and no more than one ? If so, what will be the steps for creating a new module in say contrib/extensions be ? Currently its mkdir edit/build/test commit. Do we now have to contact infra before we can create a new module ? Also, I assume

Re: Prototype of building github pull requests with Jenkins

2017-10-17 Thread Ian Boston
Hi, On 17 October 2017 at 12:12, Robert Munteanu <romb...@apache.org> wrote: > On Tue, 2017-10-17 at 12:08 +0100, Ian Boston wrote: > > Hi, > > Could travis be used ? > > > > https://github.com/apache/sling/blob/trunk/.travis.yml > > > >

Re: Prototype of building github pull requests with Jenkins

2017-10-17 Thread Ian Boston
Hi, Could travis be used ? https://github.com/apache/sling/blob/trunk/.travis.yml I dont think that need personal access tokens or a special technical uses as it uses OAuth. >From memory the main problem with Travis + Sling is a) the size of the log file (fixed for Sling see yml file) and b)

Re: Depending on Oak 1.7.x

2017-10-17 Thread Ian Boston
5e2f9 > > 94ccbba7236a5051f77ec734bb2a@%3Cdev.felix.apache.org%3E > > Chetan Mehrotra > > > > > > On Mon, Oct 16, 2017 at 7:49 AM, Ian Boston <i...@tfd.co.uk> wrote: > > > Hi, > > > My first proposal used javax.net.URI. It could do that

Re: Depending on Oak 1.7.x

2017-10-17 Thread Ian Boston
ency to Oak. What am I missing? > > Regards > Julian > > > On Mon, Oct 16, 2017 at 4:49 PM, Ian Boston <i...@tfd.co.uk> wrote: > > Hi, > > My first proposal used javax.net.URI. It could do that again. No Oak API > > required. > > Best Regards > >

Re: Depending on Oak 1.7.x

2017-10-16 Thread Ian Boston
t a direct dependency to Oak is Sling JCR Resource. Hence > I fail to follow your argument about why your alternative solution > would be better. > > Regards > Julian > > > On Mon, Oct 16, 2017 at 2:07 PM, Ian Boston <i...@tfd.co.uk> wrote: > > Hi, > > I

Re: Depending on Oak 1.7.x

2017-10-16 Thread Ian Boston
e acceptable IMHO. > > Regards > Julian > > > > On Fri, Oct 13, 2017 at 6:37 PM, Ian Boston <i...@tfd.co.uk> wrote: > > Hi, > > The bundles are > > > > Sling API > > Sling ResourceResolver > > Sling JCR Resource > > Sling GET Servlet

Re: Depending on Oak 1.7.x

2017-10-13 Thread Ian Boston
on > Oak API and do unstable releases for them i.e. only odd version > release. This would allow implementing parts in Sling which rely on > new features implement in Oak trunk Chetan Mehrotra > > > On Fri, Oct 13, 2017 at 8:25 PM, Ian Boston <i...@tfd.co.uk> wrote: > &g

Re: Upgrade to Oak 1.7.9

2017-10-13 Thread Ian Boston
-dev. Best Regards Ian On 13 October 2017 at 14:26, Ian Boston <i...@tfd.co.uk> wrote: > Hi, > > On 13 October 2017 at 13:25, Oliver Lietz <apa...@oliverlietz.de> wrote: > >> On Friday 13 October 2017 13:00:53 Ian Boston wrote: >> > On 13 October 2017 at 11:

Re: Depending on Oak 1.7.x

2017-10-13 Thread Ian Boston
s close to 1.8.0 (see other thread), I have asked oak-dev to clarify it it is or not. If its not, I also dont want to slip down that slope. Best Regards Ian > > Remains the tricky question: how do we build on cutting edge Oak > features? Branches could be one option (especially once we're

Re: Upgrade to Oak 1.7.9

2017-10-13 Thread Ian Boston
Hi, On 13 October 2017 at 13:25, Oliver Lietz <apa...@oliverlietz.de> wrote: > On Friday 13 October 2017 13:00:53 Ian Boston wrote: > > On 13 October 2017 at 11:16, Robert Munteanu <romb...@apache.org> wrote: > > > Hi Ian, > > Hi, > > > > On

Re: Upgrade to Oak 1.7.9

2017-10-13 Thread Ian Boston
Hi, On 13 October 2017 at 13:24, Oliver Lietz <apa...@oliverlietz.de> wrote: > On Friday 13 October 2017 10:51:31 Ian Boston wrote: > > Hi, > > Hi, > > > I would like to upgrade Sling to depend on Oak 1.7.9 as it was just > > released. The patch be the same

Re: Upgrade to Oak 1.7.9

2017-10-13 Thread Ian Boston
On 13 October 2017 at 11:16, Robert Munteanu <romb...@apache.org> wrote: > Hi Ian, > > On Fri, 2017-10-13 at 10:51 +0100, Ian Boston wrote: > > Hi, > > I would like to upgrade Sling to depend on Oak 1.7.9 as it was just > > released. The patch be the same as

Re: Depending on Oak 1.7.x

2017-10-13 Thread Ian Boston
ies to an “unstable” Oak release. For example, if such a release > passes all Oak tests and all Sling tests, maybe that’s acceptable. > > -MR > > > On October 12, 2017 at 8:34:50 AM, Ian Boston (i...@tfd.co.uk) wrote: > > Hi, > Here is a patch to make Sling work with Oak 1.

Upgrade to Oak 1.7.9

2017-10-13 Thread Ian Boston
Hi, I would like to upgrade Sling to depend on Oak 1.7.9 as it was just released. The patch be the same as [1] with 1.7.8 replaced by 1.7.9. Any objections ? Best Regards Ian 1 https://github.com/apache/sling/compare/trunk...ieb: upgradeToOak178?expand=1

Re: Depending on Oak 1.7.x

2017-10-12 Thread Ian Boston
after 1.7.8. We might wait till 1.7.10 comes out as IIUC this will include OAK-6575. wdyt, mege when 1.7.10 is out and upgrade to a stable 1.8 when its cut ? Best Regards Ian 1 https://github.com/apache/sling/compare/trunk...ieb:upgradeToOak178?expand=1 On 11 October 2017 at 11:38, Ian Boston &l

Re: Sling build broken for me.

2017-10-12 Thread Ian Boston
Hi, On 12 October 2017 at 11:52, Robert Munteanu <romb...@apache.org> wrote: > Hi Ian, > > On Thu, 2017-10-12 at 11:26 +0100, Ian Boston wrote: > > Hi, > > 2 observations going through the upgrade process from Oak 1.6 to Oak > > 1.7/1.8 using the full build to

Re: Sling build broken for me.

2017-10-12 Thread Ian Boston
wrote: > > On Wed, 2017-10-11 at 16:04 +0200, Karl Pauls wrote: > >> On Wed, Oct 11, 2017 at 3:46 PM, Ian Boston <i...@tfd.co.uk> wrote: > >> > Hi, > >> > > >> > On 11 October 2017 at 11:21, Robert Munteanu <romb...@apache.org> > >

Re: Sling build broken for me.

2017-10-11 Thread Ian Boston
Hi, On 11 October 2017 at 11:21, Robert Munteanu <romb...@apache.org> wrote: > Hi Ian, > > On Wed, 2017-10-11 at 10:47 +0100, Ian Boston wrote: > > Hi, > > Could be me. > > I do mvn clean install on a clean Sling checkout with a clean maven > > r

Re: Depending on Oak 1.7.x

2017-10-11 Thread Ian Boston
On 11 October 2017 at 11:25, Robert Munteanu <romb...@apache.org> wrote: > On Wed, 2017-10-11 at 11:16 +0100, Ian Boston wrote: > > Hi, > > Switching to depend on Oak 1.7 requires upgrading oak-server to use > > 1.7 or > > later. > > There has been some

Re: Depending on Oak 1.7.x

2017-10-11 Thread Ian Boston
make a call whether or > >not they want to actually run on Oak 1.7.x or wait for Oak 1.8 (which is > >advisable). IMO having this dependency doesn't imply on which version it > >will ultimately run. > > > >Cheers, > >Stefan > > > >On 11/10/17 11:54, &

Depending on Oak 1.7.x

2017-10-11 Thread Ian Boston
Hi, Oak 1.7.x is Oak unstable release branch working towards 1.8. I have a feature in SLING-7140 that is blocked by an API change in Oak present in 1.8-SNAPSHOT and available as an unmerged but tested patch to Oak 1.6.x. The Oak team are unwilling merge the patch to 1.6 and have asked that Sling

Sling build broken for me.

2017-10-11 Thread Ian Boston
Hi, Could be me. I do mvn clean install on a clean Sling checkout with a clean maven repo and I get failiures to download slingfeature:9-SNAPSHOT required by an IT test sample. This happens before the reactor starts. If I fix that by using slingfeature:9 I then get 11 test failures in commons.log

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-09-29 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185731#comment-16185731 ] Ian Boston commented on SLING-7140: --- Configuration information https://gist.github.com/ieb

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-09-29 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185711#comment-16185711 ] Ian Boston commented on SLING-7140: --- Pull request: https://github.com/apache/sling/pull/252

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-09-29 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185668#comment-16185668 ] Ian Boston commented on SLING-7140: --- Update from testing, also reported in Oak Tested against Sling

Re: [git] Which git system do we want to use?

2017-09-20 Thread Ian Boston
Hi, If we can implement automation ontop of the pull request using travis etc, then that would be a benefit of going for a github centric workflow. I dont if this is appropriate for Apache projects in general, or Slings workflow, but do know it works exceedingly well for other projects, even

[jira] [Created] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

2017-09-19 Thread Ian Boston (JIRA)
Ian Boston created SLING-7140: - Summary: Support redirects to URLs provided by the underlying datastore. Key: SLING-7140 URL: https://issues.apache.org/jira/browse/SLING-7140 Project: Sling

Re: OAK-6575 - Support for external binary URLs.

2017-09-19 Thread Ian Boston
Hi, On 19 September 2017 at 11:00, Julian Sedding <jsedd...@gmail.com> wrote: > Hi Ian > > On Tue, Sep 19, 2017 at 10:42 AM, Ian Boston <i...@tfd.co.uk> wrote: > > With the upcoming changes in Jackrabbit we will already have the > URIProvider service(s

Re: OAK-6575 - Support for external binary URLs.

2017-09-19 Thread Ian Boston
Hi Julian, (this time to the list as well, hit reply rather than reply all) On 19 September 2017 at 08:51, Julian Sedding <jsedd...@gmail.com> wrote: > Hi Ian > > Thanks for trying to use HelperData. > > On Mon, Sep 18, 2017 at 5:30 PM, Ian Boston <i...@tfd.co.uk> w

Re: OAK-6575 - Support for external binary URLs.

2017-09-18 Thread Ian Boston
Hi, On 18 September 2017 at 14:49, Julian Sedding <jsedd...@gmail.com> wrote: > On Mon, Sep 18, 2017 at 2:58 PM, Ian Boston <i...@tfd.co.uk> wrote: > > Hi, > > > > On 18 September 2017 at 13:51, Carsten Ziegeler <cziege...@apache.org> > > wrote:

Re: OAK-6575 - Support for external binary URLs.

2017-09-18 Thread Ian Boston
Hi, On 18 September 2017 at 14:17, Carsten Ziegeler <cziege...@apache.org> wrote: > Ian Boston wrote > > Hi, > > > > On 18 September 2017 at 13:51, Carsten Ziegeler <cziege...@apache.org> > > wrote: > > > >> Julian Sedding wrote

Re: OAK-6575 - Support for external binary URLs.

2017-09-18 Thread Ian Boston
Hi, On 18 September 2017 at 13:51, Carsten Ziegeler wrote: > Julian Sedding wrote > > Hi Ian > > > > Would it make sense to remove the AdapterFactory implementation and > > instead pass along the URIProvider service(s) using the > > o.a.s.jcr.resource.internal.HelperData

Re: OAK-6575 - Support for external binary URLs.

2017-09-18 Thread Ian Boston
instead? According to > its javadoc, it is "used to pass several services/data to the > resource". > > I assume the AdapterFactory is used because you don't have access to > the OSGi service registry in JcrNodeResource where you need the > URIProvider. > > Regards >

Re: OAK-6575 - Support for external binary URLs.

2017-09-18 Thread Ian Boston
. The component is lazy now. Best Regards Ian On 18 September 2017 at 06:15, Carsten Ziegeler <cziege...@apache.org> wrote: > Ian Boston wrote > > Hi, > > Here is an updated patch. > > > > https://github.com/apache/sling/compare/trunk...ieb:OAK- > 6575-3-1?expand=1 &

Re: OAK-6575 - Support for external binary URLs.

2017-09-14 Thread Ian Boston
Hi, On 14 Sep 2017 12:22 am, "Julian Reschke" <julian.resc...@gmx.de> wrote: On 2017-09-14 01:29, Ian Boston wrote: > Hi, > Here is an updated patch. > > https://github.com/apache/sling/compare/trunk...ieb:OAK-6575-3-1?expand=1 > > Best Regards > Ian &

  1   2   3   4   5   6   7   8   9   10   >