Re: Review Request 27110: SQOOP-1620: Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Abraham Elmahrek
On Oct. 26, 2014, 10:39 p.m., Gwen Shapira wrote: Hate to contradict Veena, but I don't think this is ready yet. For one thing, the integration tests this patch touches are failing on my machine, and the validator looks broken as well. Veena Basavaraj wrote: hehe, I did not run

Re: Review Request 27110: SQOOP-1620: Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Abraham Elmahrek
On Oct. 25, 2014, 12:41 a.m., Veena Basavaraj wrote: test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java, line 95 https://reviews.apache.org/r/27110/diff/3/?file=733158#file733158line95 please please extract this logic to common method,

Re: Review Request 27110: SQOOP-1620: Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27110/ --- (Updated Oct. 27, 2014, 8:22 a.m.) Review request for Sqoop. Bugs:

Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service

2014-10-27 Thread richard zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/ --- (Updated Oct. 27, 2014, 8:37 a.m.) Review request for Sqoop. Repository:

Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service

2014-10-27 Thread richard zhou
On Oct. 22, 2014, 7:19 p.m., Jarek Cecho wrote: core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java, lines 28-34 https://reviews.apache.org/r/26678/diff/5/?file=728669#file728669line28 If the type is neither of KERBEROS nor SIMPLE can we try to

Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service

2014-10-27 Thread richard zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/ --- (Updated Oct. 27, 2014, 9:08 a.m.) Review request for Sqoop. Repository:

[jira] [Commented] (SQOOP-1383) Sqoop2: MSSQL Export not working

2014-10-27 Thread Oleksiy Sayankin (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185039#comment-14185039 ] Oleksiy Sayankin commented on SQOOP-1383: - The main idea of the fix is to give

[jira] [Commented] (SQOOP-1409) Update only export from Avro Data Files doesn't work

2014-10-27 Thread Keegan Witt (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185133#comment-14185133 ] Keegan Witt commented on SQOOP-1409: So are we moving forward with this? Or are we

[jira] [Comment Edited] (SQOOP-1383) Sqoop2: MSSQL Export not working

2014-10-27 Thread Oleksiy Sayankin (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185039#comment-14185039 ] Oleksiy Sayankin edited comment on SQOOP-1383 at 10/27/14 1:57 PM:

Re: Review Request 27110: SQOOP-1620: Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27110/#review58615 --- Ship it! Tests pass. [+1 LGTM](http://www.lgtm.in/p/O1M5aqWKn)

[jira] [Commented] (SQOOP-1403) Upsert export for SQL Server

2014-10-27 Thread Keegan Witt (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185428#comment-14185428 ] Keegan Witt commented on SQOOP-1403: I'm pretty sure failures are unrelated (seems to

[jira] [Updated] (SQOOP-1513) Refactor LinkRequestHandler

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1513: --- Description: see the attache PDF in parent ticket for details. Refactor LinkRequestHandler

Review Request 27236: SQOOP-1513: Link rest api changes

2014-10-27 Thread Veena Basavaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27236/ --- Review request for Sqoop. Repository: sqoop-sqoop2 Description --- see

[jira] [Updated] (SQOOP-1444) Sqoop2: Validations: Remove all references to the original Validation infastructure

2014-10-27 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-1444: -- Fix Version/s: (was: from/to) 1.99.4 Sqoop2: Validations:

[jira] [Updated] (SQOOP-1242) Shell option errors not displayed and client error not printed

2014-10-27 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-1242: -- Fix Version/s: (was: 1.99.4) 2.0.0 Shell option errors not

[jira] [Updated] (SQOOP-1135) Sqoop2: Rename queries in Derby repository to have the same naming scheme

2014-10-27 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-1135: -- Fix Version/s: (was: 1.99.4) 2.0.0 Sqoop2: Rename queries in

[jira] [Updated] (SQOOP-965) Help option for shell command functions

2014-10-27 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-965: - Fix Version/s: (was: 1.99.4) 2.0.0 Help option for shell command

[jira] [Updated] (SQOOP-1063) Sqoop2: Export sub directories option

2014-10-27 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-1063: -- Fix Version/s: (was: 1.99.4) 2.0.0 Sqoop2: Export sub

Re: Review Request 27196: SQOOP-1515: Version api cleanup

2014-10-27 Thread Jarek Cecho
On Oct. 25, 2014, 3:08 p.m., Veena Basavaraj wrote: connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java, line 58 https://reviews.apache.org/r/27196/diff/1/?file=733346#file733346line58 the sqoop connector says /**

[jira] [Updated] (SQOOP-1517) Test CommandLineClient to accomodate the JSON API refactoring

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1517: --- Summary: Test CommandLineClient to accomodate the JSON API refactoring (was:

Re: Review Request 27196: SQOOP-1515: Version api cleanup

2014-10-27 Thread Jarek Cecho
On Oct. 25, 2014, 3:23 p.m., Jarek Cecho wrote: common/pom.xml, line 27 https://reviews.apache.org/r/27196/diff/1/?file=733341#file733341line27 We're currently using 2.0.0 on head of sqoop2 branch, to iterate that it's our goal. What is the reason to change it to 1.99.4? Veena

[jira] [Updated] (SQOOP-1626) In built Connectors Version needs to be fixed

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1626: --- Issue Type: Bug (was: Sub-task) Parent: (was: SQOOP-1509) In built Connectors

[jira] [Created] (SQOOP-1626) In built Connectors Version needs to be fixed

2014-10-27 Thread Veena Basavaraj (JIRA)
Veena Basavaraj created SQOOP-1626: -- Summary: In built Connectors Version needs to be fixed Key: SQOOP-1626 URL: https://issues.apache.org/jira/browse/SQOOP-1626 Project: Sqoop Issue Type:

Re: Review Request 27196: SQOOP-1515: Version api cleanup

2014-10-27 Thread Veena Basavaraj
On Oct. 25, 2014, 8:08 a.m., Veena Basavaraj wrote: connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java, line 58 https://reviews.apache.org/r/27196/diff/1/?file=733346#file733346line58 the sqoop connector says /**

Re: Review Request 27196: SQOOP-1515: Version api cleanup

2014-10-27 Thread Veena Basavaraj
On Oct. 25, 2014, 8:08 a.m., Veena Basavaraj wrote: connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java, line 58 https://reviews.apache.org/r/27196/diff/1/?file=733346#file733346line58 the sqoop connector says /**

[jira] [Updated] (SQOOP-1626) In built Connectors Version needs to be fixed

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1626: --- Description: related to SQOOP-1515 see RB for details https://reviews.apache.org/r/27196/

[jira] [Updated] (SQOOP-1626) Built-in Connectors Version needs to be fixed

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1626: --- Summary: Built-in Connectors Version needs to be fixed (was: In built Connectors Version

Re: Review Request 27236: SQOOP-1513: Link rest api changes

2014-10-27 Thread Veena Basavaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27236/ --- (Updated Oct. 27, 2014, 10:58 a.m.) Review request for Sqoop. Repository:

Re: Review Request 27196: SQOOP-1515: Version api cleanup

2014-10-27 Thread Veena Basavaraj
- Veena --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27196/#review58503 --- On Oct. 25, 2014, 9:09 a.m., Veena Basavaraj wrote:

Re: Review Request 27196: SQOOP-1515: Version api cleanup

2014-10-27 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27196/#review58640 --- Ship it! Please upload the final version of the patch to the JIRA,

[jira] [Commented] (SQOOP-1383) Sqoop2: MSSQL Export not working

2014-10-27 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185515#comment-14185515 ] Abraham Elmahrek commented on SQOOP-1383: - There is a ticket open for a MySQL

[jira] [Updated] (SQOOP-1515) VersionRequestHandler - fixes

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1515: --- Attachment: SQOOP-1515.patch VersionRequestHandler - fixes -

[jira] [Commented] (SQOOP-1515) VersionRequestHandler - fixes

2014-10-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185520#comment-14185520 ] ASF subversion and git services commented on SQOOP-1515: Commit

Re: Review Request 27110: SQOOP-1620: Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Abraham Elmahrek
On Oct. 27, 2014, 4:39 p.m., Gwen Shapira wrote: connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java, line 34 https://reviews.apache.org/r/27110/diff/4/?file=733994#file733994line34 WTF :) I'll trust you (and the unit

[jira] [Commented] (SQOOP-1403) Upsert export for SQL Server

2014-10-27 Thread Venkat Ranganathan (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185523#comment-14185523 ] Venkat Ranganathan commented on SQOOP-1403: --- I did build and validate it before

[jira] [Created] (SQOOP-1627) Builds are broken with Hadoop100 profile

2014-10-27 Thread Venkat Ranganathan (JIRA)
Venkat Ranganathan created SQOOP-1627: - Summary: Builds are broken with Hadoop100 profile Key: SQOOP-1627 URL: https://issues.apache.org/jira/browse/SQOOP-1627 Project: Sqoop Issue Type:

Re: Review Request 27236: SQOOP-1513: Link rest api changes

2014-10-27 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27236/#review58644 ---

Re: Review Request 27110: SQOOP-1620: Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Abraham Elmahrek
On Oct. 27, 2014, 4:39 p.m., Gwen Shapira wrote: connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java, line 34 https://reviews.apache.org/r/27110/diff/4/?file=733994#file733994line34 WTF :) I'll trust you (and the unit

[jira] [Commented] (SQOOP-1515) VersionRequestHandler - fixes

2014-10-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185595#comment-14185595 ] Hudson commented on SQOOP-1515: --- FAILURE: Integrated in Sqoop2-hadoop200 #561 (See

Re: Review Request 27236: SQOOP-1513: Link rest api changes

2014-10-27 Thread Abraham Elmahrek
On Oct. 27, 2014, 6:37 p.m., Abraham Elmahrek wrote: server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java, lines 44-46 https://reviews.apache.org/r/27236/diff/2/?file=734322#file734322line44 I don't see any thing about a '/links' api in the attached doc. Veena

[jira] [Created] (SQOOP-1628) Fix the Connector/Driver/Version to only support GET method

2014-10-27 Thread Veena Basavaraj (JIRA)
Veena Basavaraj created SQOOP-1628: -- Summary: Fix the Connector/Driver/Version to only support GET method Key: SQOOP-1628 URL: https://issues.apache.org/jira/browse/SQOOP-1628 Project: Sqoop

[jira] [Commented] (SQOOP-1515) VersionRequestHandler - fixes

2014-10-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185609#comment-14185609 ] Hudson commented on SQOOP-1515: --- FAILURE: Integrated in Sqoop2-hadoop100 #625 (See

Review Request 27241: SQOOP-1628:Fix the Connector/Driver/Version to only support GET method

2014-10-27 Thread Veena Basavaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27241/ --- Review request for Sqoop. Repository: sqoop-sqoop2 Description --- see

Re: Work on 1.99.4 release has started

2014-10-27 Thread Jarek Jarcec Cecho
I can see that our usual release process [1] is instructing us to announce the intent of the release two weeks in advance before cutting the release branch. I see a lot of value in the goal as the two weeks are there to enable community to finish ongoing work and include it in the release. We

Re: Review Request 27236: SQOOP-1513: Link rest api changes

2014-10-27 Thread Veena Basavaraj
On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java, line 806 https://reviews.apache.org/r/27236/diff/2/?file=734314#file734314line806 Maybe add an index on name? Maybe cool for a

Re: Review Request 27236: SQOOP-1513: Link rest api changes

2014-10-27 Thread Veena Basavaraj
On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java, lines 44-46 https://reviews.apache.org/r/27236/diff/2/?file=734322#file734322line44 I don't see any thing about a '/links' api in the attached doc. Veena

Re: Review Request 27241: SQOOP-1628:Fix the Connector/Driver/Version to only support GET method

2014-10-27 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27241/#review58665 --- Ship it! Ship It! - Abraham Elmahrek On Oct. 27, 2014, 7:22

[jira] [Commented] (SQOOP-1628) Fix the Connector/Driver/Version to only support GET method

2014-10-27 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185669#comment-14185669 ] Abraham Elmahrek commented on SQOOP-1628: - [~vybs], please attach a patch to this

Re: Work on 1.99.4 release has started

2014-10-27 Thread Gwen Shapira
That makes a lot of sense. Kafka community cut the 0.8.2 branch on Sept 30, the first RC candidate was published last week and the release is happening today. Important bug fixes from trunk were committed to 0.8.2 branch up until the vote on RC started. So there's definitely some experience

[jira] [Updated] (SQOOP-1516) Add ConfigRequestHandler ( for from/to/driver types )

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1516: --- Issue Type: Bug (was: Sub-task) Parent: (was: SQOOP-1509) Add

[jira] [Updated] (SQOOP-1516) Add ConfigRequestHandler REST api support ( for from/to/driver/ link types )

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1516: --- Description: See the main ticket SQOOP-1509 that has the design details. This is an

[jira] [Updated] (SQOOP-1516) Add ConfigRequestHandler REST api support ( for from/to/driver/ link types )

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1516: --- Summary: Add ConfigRequestHandler REST api support ( for from/to/driver/ link types ) (was:

Re: Review Request 27242: SQOOP-1605: Sqoop2: Misc From/to cleanups

2014-10-27 Thread Veena Basavaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27242/#review58666 --- Ship it! yay! thanks for removing all the todo's!

Re: Work on 1.99.4 release has started

2014-10-27 Thread Abraham Elmahrek
+1 to this idea. On Mon, Oct 27, 2014 at 12:37 PM, Gwen Shapira gshap...@cloudera.com wrote: That makes a lot of sense. Kafka community cut the 0.8.2 branch on Sept 30, the first RC candidate was published last week and the release is happening today. Important bug fixes from trunk were

[jira] [Updated] (SQOOP-1628) Fix the Connector/Driver/Version to only support GET method

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1628: --- Attachment: SQOOP-1628.patch Fix the Connector/Driver/Version to only support GET method

Re: Review Request 27242: SQOOP-1605: Sqoop2: Misc From/to cleanups

2014-10-27 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27242/#review58669 --- Ship it! [+1](http://www.lgtm.in/u/krJ1) - Gwen Shapira On Oct.

[jira] [Created] (SQOOP-1629) Add unique constraint on the Config table for names

2014-10-27 Thread Veena Basavaraj (JIRA)
Veena Basavaraj created SQOOP-1629: -- Summary: Add unique constraint on the Config table for names Key: SQOOP-1629 URL: https://issues.apache.org/jira/browse/SQOOP-1629 Project: Sqoop Issue

[jira] [Updated] (SQOOP-1628) Sqoop2: Ensure Connector/Driver/Version only support GET method

2014-10-27 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-1628: Summary: Sqoop2: Ensure Connector/Driver/Version only support GET method (was: Fix the

[jira] [Created] (SQOOP-1630) Add Index on LINK name, JOB name, Connector name, Config name fields for better performance on findByName

2014-10-27 Thread Veena Basavaraj (JIRA)
Veena Basavaraj created SQOOP-1630: -- Summary: Add Index on LINK name, JOB name, Connector name, Config name fields for better performance on findByName Key: SQOOP-1630 URL:

[jira] [Assigned] (SQOOP-1518) Update the Rest api Wiki with examples.

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj reassigned SQOOP-1518: -- Assignee: Veena Basavaraj Update the Rest api Wiki with examples.

[jira] [Assigned] (SQOOP-1630) Add Index on LINK name, JOB name, Connector name, Config name fields for better performance on findByName

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj reassigned SQOOP-1630: -- Assignee: Veena Basavaraj Add Index on LINK name, JOB name, Connector name, Config

[jira] [Assigned] (SQOOP-1511) Refactor SubmissionRequestHandler

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj reassigned SQOOP-1511: -- Assignee: Veena Basavaraj Refactor SubmissionRequestHandler

[jira] [Commented] (SQOOP-1605) Sqoop2: Misc From/to cleanups

2014-10-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185693#comment-14185693 ] ASF subversion and git services commented on SQOOP-1605: Commit

[jira] [Assigned] (SQOOP-1510) Refactor JobRequestHandler to take From/To/ Driver Config

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj reassigned SQOOP-1510: -- Assignee: Veena Basavaraj Refactor JobRequestHandler to take From/To/ Driver Config

[jira] [Updated] (SQOOP-1630) Add Index on LINK name, JOB name, Connector name, Config name fields for better performance on findByName

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1630: --- Issue Type: Task (was: Sub-task) Parent: (was: SQOOP-1509) Add Index on LINK

[jira] [Commented] (SQOOP-1620) Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185702#comment-14185702 ] Sqoop QA bot commented on SQOOP-1620: - Here are the results of testing the latest

[jira] [Commented] (SQOOP-1628) Sqoop2: Ensure Connector/Driver/Version only support GET method

2014-10-27 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185703#comment-14185703 ] Sqoop QA bot commented on SQOOP-1628: - Here are the results of testing the latest

[jira] [Commented] (SQOOP-1605) Sqoop2: Misc From/to cleanups

2014-10-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185705#comment-14185705 ] Hudson commented on SQOOP-1605: --- FAILURE: Integrated in Sqoop2-hadoop100 #626 (See

[jira] [Commented] (SQOOP-1628) Sqoop2: Ensure Connector/Driver/Version only support GET method

2014-10-27 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185713#comment-14185713 ] Abraham Elmahrek commented on SQOOP-1628: - +1 committed. Forgot to add the Jira

[jira] [Updated] (SQOOP-1509) Sqoop2: Sqoop2 Rest API refactoring

2014-10-27 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated SQOOP-1509: Fix Version/s: (was: 1.99.4) 2.0.0 Sqoop2: Sqoop2 Rest API refactoring

[jira] [Updated] (SQOOP-1509) Sqoop2: Sqoop2 Rest API refactoring

2014-10-27 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated SQOOP-1509: Priority: Major (was: Blocker) Sqoop2: Sqoop2 Rest API refactoring

Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service

2014-10-27 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/#review58676 --- This looks great to me. Just a POM question and I think we're good!

[jira] [Updated] (SQOOP-1620) Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-1620: Attachment: SQOOP-1620.3.patch Sqoop2: FileSystem should be configurable in HDFS connector

[jira] [Commented] (SQOOP-1620) Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185753#comment-14185753 ] ASF subversion and git services commented on SQOOP-1620: Commit

Re: Review Request 27137: SQOOP-1597: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread Veena Basavaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27137/ --- (Updated Oct. 27, 2014, 1:59 p.m.) Review request for Sqoop. Repository:

[jira] [Updated] (SQOOP-1509) Sqoop2: Sqoop2 Rest API refactoring

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1509: --- Attachment: SQOOP-1597.patch Sqoop2: Sqoop2 Rest API refactoring

Re: Review Request 27137: SQOOP-1597: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread Veena Basavaraj
On Oct. 25, 2014, 9:41 p.m., Qian Xu wrote: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java, line 20 https://reviews.apache.org/r/27137/diff/2/?file=732162#file732162line20 Looks good, only one suggestion: better expand

[jira] [Commented] (SQOOP-1620) Sqoop2: FileSystem should be configurable in HDFS connector

2014-10-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185803#comment-14185803 ] Hudson commented on SQOOP-1620: --- FAILURE: Integrated in Sqoop2-hadoop200 #562 (See

[jira] [Commented] (SQOOP-1605) Sqoop2: Misc From/to cleanups

2014-10-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185804#comment-14185804 ] Hudson commented on SQOOP-1605: --- FAILURE: Integrated in Sqoop2-hadoop200 #562 (See

[jira] [Updated] (SQOOP-1509) Sqoop2: Sqoop2 Rest API refactoring

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1509: --- Attachment: (was: SQOOP-1597.patch) Sqoop2: Sqoop2 Rest API refactoring

[jira] [Updated] (SQOOP-1597) Sqoop2: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1597: --- Attachment: SQOOP-1597.patch Sqoop2: Refactor DerbySchemaQuery into one for create/ update/

Re: Review Request 27137: SQOOP-1597: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread Jarek Cecho
On Oct. 26, 2014, 4:41 a.m., Qian Xu wrote: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java, line 20 https://reviews.apache.org/r/27137/diff/2/?file=732162#file732162line20 Better expand imports (this may require to change

Re: Review Request 27137: SQOOP-1597: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27137/#review58686 --- Ship it! Ship It! - Jarek Cecho On Oct. 27, 2014, 8:59 p.m.,

[jira] [Commented] (SQOOP-1597) Sqoop2: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185820#comment-14185820 ] ASF subversion and git services commented on SQOOP-1597: Commit

[jira] [Commented] (SQOOP-1597) Sqoop2: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185823#comment-14185823 ] Sqoop QA bot commented on SQOOP-1597: - Here are the results of testing the latest

Re: Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Jarek Cecho
On Oct. 14, 2014, 4:25 a.m., Veena Basavaraj wrote: common/src/main/java/org/apache/sqoop/model/ConfigUtils.java, line 236 https://reviews.apache.org/r/26609/diff/1/?file=719198#file719198line236 might be good to be consistent with getName to avoid names clashes ( different

[jira] [Updated] (SQOOP-1629) Add unique constraint on the Config table for name and type

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1629: --- Summary: Add unique constraint on the Config table for name and type (was: Add unique

[jira] [Updated] (SQOOP-1629) Add unique constraint on the Config table for names

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1629: --- Attachment: SQOOP-1629.patch Add unique constraint on the Config table for names

[jira] [Updated] (SQOOP-1629) Add unique constraint on the Config table for name and type

2014-10-27 Thread Veena Basavaraj (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veena Basavaraj updated SQOOP-1629: --- Description: this helps create top level config objects and use their names while creating

Re: Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26609/ --- (Updated Oct. 27, 2014, 9:57 p.m.) Review request for Sqoop. Changes ---

[jira] [Updated] (SQOOP-1576) Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-1576: -- Attachment: SQOOP-1576.patch Sqoop2: Validations: Migrate Repository upgrade to the

[jira] [Commented] (SQOOP-1597) Sqoop2: Refactor DerbySchemaQuery into one for create/ update/ and then CRUD operarations

2014-10-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185898#comment-14185898 ] Hudson commented on SQOOP-1597: --- FAILURE: Integrated in Sqoop2-hadoop200 #563 (See

[jira] [Commented] (SQOOP-1629) Add unique constraint on the Config table for name and type

2014-10-27 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185902#comment-14185902 ] Sqoop QA bot commented on SQOOP-1629: - Here are the results of testing the latest

[jira] [Commented] (SQOOP-1622) Copying from staging table should be in single transaction for pg_bulkload connector

2014-10-27 Thread Masahiro Yamaguchi (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185925#comment-14185925 ] Masahiro Yamaguchi commented on SQOOP-1622: --- +1 (non-binding) If there are 4

[jira] [Comment Edited] (SQOOP-1622) Copying from staging table should be in single transaction for pg_bulkload connector

2014-10-27 Thread Masahiro Yamaguchi (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185925#comment-14185925 ] Masahiro Yamaguchi edited comment on SQOOP-1622 at 10/27/14 10:18 PM:

Re: Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Veena Basavaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26609/#review58698 --- I have dropped comments on rev 1 since rev2 has changed

Re: Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26609/#review58699 ---

Re: Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Veena Basavaraj
On Oct. 13, 2014, 9:25 p.m., Veena Basavaraj wrote: common/src/main/java/org/apache/sqoop/model/ConfigUtils.java, line 236 https://reviews.apache.org/r/26609/diff/1/?file=719198#file719198line236 might be good to be consistent with getName to avoid names clashes ( different

Re: Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Veena Basavaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26609/#review58701 --- core/src/main/java/org/apache/sqoop/repository/Repository.java

Re: Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure

2014-10-27 Thread Veena Basavaraj
On Oct. 13, 2014, 9:25 p.m., Veena Basavaraj wrote: core/src/main/java/org/apache/sqoop/repository/Repository.java, line 487 https://reviews.apache.org/r/26609/diff/1/?file=719201#file719201line487 please move repeated code to a class Jarek Cecho wrote: I'm sorry, it seems

  1   2   >