Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

On Aug. 9, 2012, 7:08 a.m., Masatake Iwasaki wrote: > > Thank you very much for your time and effort. > > > > Jarcec Thanks for your reviews, too. - Masatake --- This is an automatically generated e-mail. To reply, visit: https://revie

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review10525 --- Ship it! Hi Masatake, please attach your patch to JIRA and I'll com

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/ --- (Updated Aug. 18, 2012, 8:41 a.m.) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review10415 --- Thank you sir for your updated patch. I believe we're almost at the e

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On Aug. 9, 2012, 7:08 a.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java, lines > > 85-90 > > > > > > I'm thinking here - is there a situation where the table will exists >

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/ --- (Updated Aug. 15, 2012, 6:14 p.m.) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review10059 --- Hi Masatake, thank you very much for your update. I believe that we'r

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 26, 2012, 9:13 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java, lines 215-216 > > > > > > I personally do not like this table searching. We might delete some > > tab

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/ --- (Updated Aug. 5, 2012, 6:56 p.m.) Review request for Sqoop. Changes --- 1

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 27, 2012, 4:34 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java, lines > > 82-86 > > > > > > Could add option to create those temporary tables in different database

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 26, 2012, 9:13 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java, lines 215-216 > > > > > > I personally do not like this table searching. We might delete some > > tab

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 27, 2012, 4:34 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java, lines > > 82-86 > > > > > > Could add option to create those temporary tables in different database

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 26, 2012, 9:13 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java, line 83 > > > > > > I'm thinking whether it would be beneficial here not to die > > immediately. F

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 27, 2012, 4:34 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java, lines > > 82-86 > > > > > > Could add option to create those temporary tables in different database

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 27, 2012, 4:34 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java, lines > > 82-86 > > > > > > Could add option to create those temporary tables in different database

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 26, 2012, 9:13 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java, line 83 > > > > > > I'm thinking whether it would be beneficial here not to die > > immediately. F

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On July 26, 2012, 9:13 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java, lines 34-35 > > > > > > I've notice that this class is to very hight extent identical to > > Sqoop's A

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review9540 --- Hi Masatake, I've finished reviewing this version. I was able to move

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review9514 --- Hi Masatake, I've read more carefully this time through your code and

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

On July 25, 2012, 11:15 p.m., Masatake Iwasaki wrote: > > Again, please accept my deep apology for not getting back to you for so > > long. > > > > Jarcec > > Masatake Iwasaki wrote: > Hi Jarek, > thanks for your comments. I updated the patch and tested it against > current svn trunk.

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

On July 25, 2012, 11:15 p.m., Masatake Iwasaki wrote: > > Again, please accept my deep apology for not getting back to you for so > > long. > > > > Jarcec Hi Jarek, thanks for your comments. I updated the patch and tested it against current svn trunk. Though I changed package name from com.cl

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/ --- (Updated July 26, 2012, 10:41 a.m.) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review9486 --- Hi Masatake, thank you very much for your effort in creating this conn

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/ --- (Updated 2012-04-02 02:30:05.378389) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On 2012-03-29 05:41:04, Cheolsoo Park wrote: > > Hello Masatake, I have a quick question about your patch. > > > > Since you're adding new tests to test/com/cloudera/sqoop/manager, "ant test > > -Dthirdparty=true" will fail unless the test requirements are not installed > > (PostgreSql 9.1,

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

> On 2012-03-29 05:41:04, Cheolsoo Park wrote: > > Hello Masatake, I have a quick question about your patch. > > > > Since you're adding new tests to test/com/cloudera/sqoop/manager, "ant test > > -Dthirdparty=true" will fail unless the test requirements are not installed > > (PostgreSql 9.1,

Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review6510 --- Hello Masatake, I have a quick question about your patch. Since you'r