Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-197000251
@revans2 @abhishekagarwal87 I was discussing with @harshach and for the
condition if it's time to poll or not, I am going to try to impose a byte limit
instead of a
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56041205
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutStreams.java
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r55889085
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,458 @@
+/*
+ * Licensed to the Apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r55889098
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,458 @@
+/*
+ * Licensed to the Apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r55886553
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaRecordTupleBuilder.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r55190400
--- Diff: pom.xml ---
@@ -836,14 +839,39 @@
test
- org.apache.calcite
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r55190214
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutStream.java
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r55189816
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,454 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54905188
--- Diff: external/storm-kafka-new-consumer-api/pom.xml ---
@@ -0,0 +1,91 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54905145
--- Diff: pom.xml ---
@@ -836,14 +839,39 @@
test
- org.apache.calcite
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54825460
--- Diff: external/storm-kafka-new-consumer-api/pom.xml ---
@@ -0,0 +1,91 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54822068
--- Diff: pom.xml ---
@@ -836,14 +839,39 @@
test
- org.apache.calcite
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-191002473
@knusbaum you must either create a uber jar or put
kafka-clients/0.9.0.0/kafka-clients-0.9.0.0.jar under extlib
---
If your project is set up for it, you can reply
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-190989626
@revans2 I have made enable.auto.commit default to false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661514
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661412
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661378
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661341
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661283
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661270
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661265
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54661279
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-190870605
@jianbzhou if tuples 1-5 have been emitted, if 3 fails, currently only 2 is
re-emitted. Offsets 1,2 are committed, and the offsets 3-5 are only committed
once 2 is acked
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-190868282
@knusbaum can you please let me know how you are trying to run it. I am
uploading shortly the changes addressing the code review. So, if you tell me
how you are trying to
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-189923836
@tgravescs @revans2 I have pushed the latest changes. Please let me know of
any feedback or further requirements you may have. Thanks.
---
If your project is set up for
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-189457987
@tgravescs @revans2 I am just finalizing some testing and I will push in
the patch after lunch.
---
If your project is set up for it, you can reply to this email and
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-188995178
@revans2 no worries. Concerning your code snippet suggestion, I agree with
most of it. We can definitely keep a lot of the state in the MessageId object.
I agree it is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54144192
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,457 @@
+/*
+ * Licensed to
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-188859042
@tgravescs probably there is a bit of miscommunication here. I didn't
complete the spout part yet because I have been waiting on getting answers to
some foll
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1145
Fix Log4j2.xml config to output the the timestamp in HH:mm:ss.SSS
Currently the -r option outputs the number of milliseconds elapsed from the
construction of the layout until the creation of the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r53724264
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,457 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r53724182
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,457 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r53723864
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,457 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r53723835
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,457 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r53723733
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,457 @@
+/*
+ * Licensed to
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1133#issuecomment-187365557
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-187284409
@tgravescs trident will be appended to this patch. In the meantime it would
be helpful if you could let me know of any other requirements that you may
have, and if this
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r53659580
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaRecordTupleBuilder.java
---
@@ -0,0 +1,34
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-186931043
@connieyang @jianbzhou @tgravescs patch is here:
https://github.com/apache/storm/pull/1131
---
If your project is set up for it, you can reply to this email and have
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1131
STORM-822: Kafka Spout New Consumer API
This patch is still under development and was uploaded at this moment for
early testing. Please read README.
There may be a bug in the offsets
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-185525450
@jianbzhou sorry it took me a bit longer. Trying my best to put it up
within the next few hours.
---
If your project is set up for it, you can reply to this email and have
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-184566399
@jianbzhou I am just finishing the final touches. I will uploaded it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-181721528
Hi @connieyang @jianbzhou apologies for not replying to you earlier. I was
sidetracked with a last minute release requirement that wasn't planned and that
got things
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-174599255
@connieyang I will try go have a patch for review by the end of this week.
I will also try to keep you posted on the progress. Thanks!
---
If your project is set up for it
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-173498063
@connieyang the goal of my patch is to entirely replace the existing kafka
spout; that includes the Trident API. In order to allow for a smooth migration,
as well as avoid
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-172962722
@tgravescs I am actively working on this and I am going to conclude my
implementation regardless of the status of the proposed patches. This task was
and still is my
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/977#issuecomment-171332402
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1001#issuecomment-170661183
@revans2 without this fix the command line option 'storm sql' is broken.
The reason it is broken is because prior to this change the method parameter
&#x
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/977#issuecomment-170373919
+1 LGTM
@vesense to solve the conflicts you can rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49267676
--- Diff: storm-core/src/jvm/backtype/storm/utils/TupleUtils.java ---
@@ -28,8 +35,21 @@ private TupleUtils() {
public static boolean isTick(Tuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49266446
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -59,16 +63,29 @@ public SolrUpdateBolt(SolrConfig solrConfig
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1001#issuecomment-170265013
@satishd @harshach Created the following JIRA to track creating unit tests
for Storm.py https://issues.apache.org/jira/browse/STORM-1461
---
If your project is set up for
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1001
Storm SQL - Storm.py 'storm sql' startup script is not working
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache STORM_S
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/931#discussion_r49259439
--- Diff: documentation/storm-sql.md ---
@@ -0,0 +1,96 @@
+---
+title: Storm SQL integration
+layout: documentation
+documentation: true
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/986#issuecomment-169910619
@Deepnekroz I am working on this. We wil make sure that all works well with
what you have.
---
If your project is set up for it, you can reply to this email and have your
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/977#issuecomment-169908195
+1 once the last few, minor, comments are addressed.
@vesense Thanks for the great work!
---
If your project is set up for it, you can reply to this email and have
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49161066
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/config/SolrConfig.java
---
@@ -39,4 +40,13 @@ public SolrConfig(String zkHostString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49160962
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -59,15 +63,24 @@ public SolrUpdateBolt(SolrConfig solrConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49160913
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -131,6 +150,21 @@ private void failQueuedTuples(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49160816
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -92,9 +108,12 @@ private void ack(Tuple tuple) throws
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49138053
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -59,16 +64,24 @@ public SolrUpdateBolt(SolrConfig solrConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49136662
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -131,6 +155,26 @@ private void failQueuedTuples(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49136481
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -92,9 +108,17 @@ private void ack(Tuple tuple) throws
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49136454
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -92,9 +108,17 @@ private void ack(Tuple tuple) throws
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/978#issuecomment-169828477
@vesense why is this change necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/977#issuecomment-169441633
@revans2 your points are valid, as there may be scenarios where we may end
up committing very small batches, which may cause some performance degradation,
but in my opinion
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/977#issuecomment-169438537
@HeartSaVioR All the tuples that have already been batched will still need
to be acked, therefore we cannot simply ignore the tick tuple. All I am doing
is that when
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/977#issuecomment-169436285
I would like to suggest that we address the tick tuples as follows:
![screen shot 2016-01-06 at 11 35 23
am](https://cloud.githubusercontent.com/assets/10284328
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/931#discussion_r48886268
--- Diff: documentation/storm-sql-internal.md ---
@@ -0,0 +1,55 @@
+---
+title: The Internals of Storm SQL
+layout: documentation
+documentation
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/960
STORM-1405: Add Maven 'all-tests' Profile to Travis Script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/936#discussion_r47847419
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/common/CmpFilesByModificationTime.java
---
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r47261403
--- Diff:
storm-core/test/jvm/backtype/storm/state/InMemoryKeyValueStateTest.java ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software
Github user hmcl commented on the pull request:
https://github.com/apache/storm/commit/99f4494439ef4ab9c8a056ea5742221da08065c8#commitcomment-14882740
In documentation/storm-sql.md:
In documentation/storm-sql.md on line 51:
Shouldn't the Kafka properties here be fo
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-163363035
Currently, by default no Java or Clojure integration tests get run when
executing `mvn clean install`. Only unit tests get executed. The user must run
maven with one of the
Github user hmcl commented on the pull request:
https://github.com/apache/storm/commit/99f4494439ef4ab9c8a056ea5742221da08065c8#commitcomment-14882118
In documentation/storm-sql.md:
In documentation/storm-sql.md on line 59:
... clauses regardless of the table being read-only
Github user hmcl commented on the pull request:
https://github.com/apache/storm/commit/99f4494439ef4ab9c8a056ea5742221da08065c8#commitcomment-14881223
In documentation/storm-sql.md:
In documentation/storm-sql.md on line 58:
ORDER shouldn't it be ORDERS
---
If your pr
Github user hmcl commented on the pull request:
https://github.com/apache/storm/commit/99f4494439ef4ab9c8a056ea5742221da08065c8#commitcomment-14881213
In documentation/storm-sql.md:
In documentation/storm-sql.md on line 58:
`ORDER` shouldn't it be `ORDERS`
---
If
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/930
Storm 1179
This patch has 3 commits.
- POM changes implementing profiles to separate integration tests and unit
tests
- Two separate commits that illustrate how to migrate existing tests
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/914#issuecomment-161718691
+1. Nice job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46579684
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/trident/state/TridentResultSetValuesMapper.java
---
@@ -0,0 +1,63
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46579509
--- Diff:
external/storm-cassandra/src/test/java/org/apache/storm/cassandra/trident/TridentTopologyTest.java
---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46579539
--- Diff:
external/storm-cassandra/src/test/java/org/apache/storm/cassandra/trident/TridentTopologyTest.java
---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46578817
--- Diff:
external/storm-cassandra/src/test/java/org/apache/storm/cassandra/DynamicStatementBuilderTest.java
---
@@ -116,15 +124,15 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46578459
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/trident/state/CassandraState.java
---
@@ -0,0 +1,149 @@
+/**
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46577559
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/trident/state/CassandraState.java
---
@@ -0,0 +1,149 @@
+/**
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46577241
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/trident/state/CassandraState.java
---
@@ -0,0 +1,149 @@
+/**
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/895#discussion_r45504842
--- Diff: storm-core/src/jvm/storm/trident/TridentTopology.java ---
@@ -127,7 +128,21 @@ public Stream newStream(String txId,
IPartitionedTridentSpout spout
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/895#issuecomment-158495768
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r45482446
--- Diff: storm-core/src/jvm/backtype/storm/windowing/TupleWindow.java ---
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/836#issuecomment-152676783
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/836#issuecomment-152646032
+1 LGTM. A few pinpoints only related with readability of the code that are
left to the discretion of the implementer.
---
If your project is set up for it, you can reply
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549539
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -248,8 +250,9 @@ public StormTopology buildTopology
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549404
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -233,8 +234,9 @@ public StormTopology buildTopology
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549300
--- Diff:
storm-core/src/jvm/storm/trident/spout/OpaquePartitionedTridentSpoutExecutor.java
---
@@ -162,9 +162,9 @@ public void commit(TransactionAttempt
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43548584
--- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java ---
@@ -30,18 +31,20 @@
private HashMap>> bundles =
new H
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43548241
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java ---
@@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/702#issuecomment-140458502
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928682
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928717
--- Diff: external/storm-solr/pom.xml ---
@@ -0,0 +1,106 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928692
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi
701 - 800 of 813 matches
Mail list logo
