Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
Also looking at the numbers from @HeartSaVioR. They also show the CPU
being higher, but not nearly as much as mine do 219 seconds for V2 vs 206
seconds for 1.2.0 or about a 6% difference
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
Here are my numbers, and no I didn't do it headless but I was not doing
anything on the laptop at the time it was running except looking at Activity
Monitor to be sure nothing else was using too
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz I think I just ran it with default options on my MBP. But I will
try and reproduce it again.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo thanks for the review you found a lot of bugs and made this a lot
better.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo I have fixed the issues you called out
@Ethanlm I fixed the issue you saw.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151700529
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -187,16 +199,21
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151699779
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/topology/MasterBatchCoordinator.java
---
@@ -308,7 +308,7 @@ public String toString
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151699527
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -129,23 +130,34
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151697850
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java ---
@@ -562,43 +560,54 @@ private void initCommon(String id, IComponent
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo I think I have addressed all of your comments. I also found a few
places were an NPE could happen, and one where the TopologyBuilder was not
setting the resource configs correctly. I fixed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151444918
--- Diff:
storm-client/src/jvm/org/apache/storm/drpc/LinearDRPCTopologyBuilder.java ---
@@ -53,12 +53,12 @@
// Trident subsumes the functionality
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151444375
--- Diff:
storm-client/src/jvm/org/apache/storm/coordination/BatchSubtopologyBuilder.java
---
@@ -84,24 +84,24 @@ private BoltDeclarer setBolt(String id
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2419
STORM-2805: Clean up confs in TopologyBuilders
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2805
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2417
STORM-2809: Always create the resources directory so we can check for it
The issue was actually a few lines below this. In the isFullyDownloaded
function. It would check if we wanted to extract
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2363
@srdo
3 mins would correspond to a timeout that we have when the supervisor gets
confused.
https://github.com/apache/storm/blob/7afd6fbe4603e35114a84e836b02484fe8cda660/storm
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2408
@jacobtolar because this is just a white space change I didn't wait the
usual 24 hours. Thanks for the patch and keep up the good work.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2385
@govind-menon could you please squash all of the commits?
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2396
Thanks @lawrencecraft I merged this into master and all of the 1.x release
lines.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149480035
--- Diff:
storm-client/src/jvm/org/apache/storm/utils/ShellCommandRunner.java ---
@@ -0,0 +1,63 @@
+/*
+ * Copyright 2017 The Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149480275
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java ---
@@ -432,47 +437,47 @@ private void setTimedOut
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2400
@jerrypeng yes I need to go follow up on my previous ask and see where the
lawyers are at with it.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2397
@HeartSaVioR I agree that we might miss some things and maintaining that
backwards compatibility long term is probably not ideal. But we have some
clusters that we need to migrate off of 0.10 so we
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149143172
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -241,6 +241,12 @@
public static final String TOPOLOGY_TASKS = "topology.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149161951
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -556,6 +605,9 @@ public boolean wouldFit
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149164076
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -129,41 +137,65 @@ public static String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149162901
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
@@ -289,17 +300,13 @@ public Double getTotalMemReqTask
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149162982
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
@@ -289,17 +300,13 @@ public Double getTotalMemReqTask
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149161531
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,43 +553,42 @@ public boolean wouldFit(
WorkerSlot ws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149162640
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
@@ -133,30 +136,31 @@ public StormTopology getTopology
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149164720
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -238,4 +277,57 @@ public static double sum(Collection
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149164027
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -129,41 +137,65 @@ public static String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149162183
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -993,6 +1045,31 @@ public WorkerResources getWorkerResources(WorkerSlot
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149162313
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -993,6 +1045,31 @@ public WorkerResources getWorkerResources(WorkerSlot
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149163670
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -57,7 +64,8 @@
if (topology.get_spouts
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149164648
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -238,4 +277,57 @@ public static double sum(Collection
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149163756
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -129,41 +137,65 @@ public static String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149140827
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java
---
@@ -430,37 +427,39 @@ public static void main(String[] args
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149160853
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
---
@@ -73,11 +75,23 @@ private SupervisorInfo
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149159775
--- Diff:
storm-client/src/jvm/org/apache/storm/transactional/TransactionalTopologyBuilder.java
---
@@ -534,9 +559,33 @@ public BoltDeclarer
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149159593
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java ---
@@ -576,10 +577,30 @@ public T addConfigurations(Map<String, Object>
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149159736
--- Diff:
storm-client/src/jvm/org/apache/storm/transactional/TransactionalTopologyBuilder.java
---
@@ -228,10 +229,34 @@ public SpoutDeclarer
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149144724
--- Diff:
storm-client/src/jvm/org/apache/storm/coordination/BatchSubtopologyBuilder.java
---
@@ -450,9 +456,33 @@ public BoltDeclarer addConfigurations
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149163179
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
@@ -479,6 +499,18 @@ private void addDefaultResforExec
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149148257
--- Diff:
storm-client/src/jvm/org/apache/storm/coordination/BatchSubtopologyBuilder.java
---
@@ -450,9 +456,33 @@ public BoltDeclarer addConfigurations
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149148502
--- Diff:
storm-client/src/jvm/org/apache/storm/coordination/BatchSubtopologyBuilder.java
---
@@ -450,9 +456,33 @@ public BoltDeclarer addConfigurations
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149160149
--- Diff: storm-client/src/storm.thrift ---
@@ -496,6 +496,8 @@ struct WorkerResources {
3: optional double cpu;
4: optional double
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149161667
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,43 +553,42 @@ public boolean wouldFit(
WorkerSlot ws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149161456
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,43 +553,42 @@ public boolean wouldFit(
WorkerSlot ws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149159863
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/topology/TridentTopologyBuilder.java
---
@@ -763,9 +787,33 @@ public BoltDeclarer addConfigurations
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149161816
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,43 +553,42 @@ public boolean wouldFit(
WorkerSlot ws
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2400
This is very long and I don't expect everyone to read the whole thing.
@jerrypeng your numbers are off for big vs small topologies. The scores
will be negative for your example
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2401
The changes look fine, but the test failure is something I have been seeing
quite a bit recently, but only on travis. I think it must be a race condition.
I am going to file a JIRA for it, but I
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148852931
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148852799
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148852532
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148852167
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148851660
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148850943
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148850301
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148849861
--- Diff: storm-client/pom.xml ---
@@ -193,6 +193,10 @@
org.hamcrest
java-hamcrest
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2400
STORM-2792: Remove RAS EvictionPolicy and cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2792
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148330545
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
---
@@ -249,6 +250,15 @@ public Object getState
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148327252
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -451,6 +451,12 @@
public static final String TOPOLOGY_METRICS_CONSUMER_REGISTER
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328987
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148329501
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148330111
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328743
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328916
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328186
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148330213
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
---
@@ -249,6 +250,15 @@ public Object getState
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148327705
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2398
STORM-2795: Fix race
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2795
Alternatively you can review and apply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
Currently ThriftClient will connect to the server itself in the
constructor. What we want to do is to optionally not do that, and instead let
the DRPCInvocationsClient do it in a location where
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2390#discussion_r147744419
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/authorizer/SimpleACLAuthorizer.java
---
@@ -80,6 +80,7 @@
}
protected
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2390#discussion_r147744518
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/FixedGroupsMapping.java ---
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2390#discussion_r147744169
--- Diff:
storm-client/src/jvm/org/apache/storm/blobstore/BlobStoreAclHandler.java ---
@@ -45,6 +47,7 @@
public class BlobStoreAclHandler
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2390#discussion_r147744795
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -159,14 +159,6 @@
public static final String
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2395
Still +1 this is just a squashed version of #2379 so I am not going to wait
the full 24 hours (because it is technically the same code)
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2379
@kevpeek yes the JVM can be very dumb when it comes to arrays vs Lists.
That sounds great if we can be within a few percentage points I would be
happy to merge this in.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
@liu-zhaokun You are correct I had forgotten the ThriftClient establishes
the connection then initializes the _protocol member and then finally the
Client itself is created which will read from
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2379
@kevpeek I agree that it might not be worth merging it right now. But
there is room for improvement.
The first thing I would do is to pre-allocate the possible return values as
lists. We
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2363
@HeartSaVioR I addressed your review comments. I didn't change the name of
shouldLogLeader, but I added javadocs to make it clear what it does.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2386
I am getting the UI crashing on startup, but with no stacktrace in the
logs. Could you look into it?
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236780
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -664,6 +722,9 @@ private double calculateSharedOffHeapMemory(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147237164
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
@@ -168,6 +172,15 @@ private void initResourceList
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147234270
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -240,6 +240,12 @@
public static final String TOPOLOGY_TASKS = "topology.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147234853
--- Diff: storm-client/src/jvm/org/apache/storm/Constants.java ---
@@ -56,5 +58,20 @@
public static final String STORM_ACTIVE_ATOM = "storm-a
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147235417
--- Diff:
storm-client/src/jvm/org/apache/storm/scheduler/SupervisorDetails.java ---
@@ -17,12 +17,10 @@
*/
package org.apache.storm.scheduler
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147233694
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java
---
@@ -430,37 +427,37 @@ public static void main(String[] args
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147235680
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java
---
@@ -79,8 +81,18 @@ public T setMemoryLoad(Number onHeap, Number
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147237442
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -189,13 +201,20 @@ private static void checkInitCpu(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236218
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,62 +553,70 @@ public boolean wouldFit(
WorkerSlot ws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236953
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -993,6 +1054,31 @@ public WorkerResources getWorkerResources(WorkerSlot
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147237298
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -18,22 +18,24 @@
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147235287
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/WorkerResources.java ---
@@ -1,21 +1,4 @@
/**
- * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236417
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,62 +553,70 @@ public boolean wouldFit(
WorkerSlot ws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147234354
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1272,6 +1278,12 @@
public static final String SUPERVISOR_CPU_CAPACITY
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236577
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,62 +553,70 @@ public boolean wouldFit(
WorkerSlot ws
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2382
@srdo could you take a look at https://github.com/apache/storm/pull/2383
too? it is like this, but for 1.x
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2382
@srdo I agree surprising. But I was looking into it. Each tuple that is
leaked is only about 120 bytes in 1.x and about 100 in 0.10 and below, in 2.x
it is 40 bytes. So in order to leak 1 MB in 1
601 - 700 of 3470 matches
Mail list logo
