Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168057328
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -22,19 +22,23 @@
import
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168046999
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -22,19 +22,23 @@
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168044307
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -22,19 +22,23 @@
import
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168037754
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -22,19 +22,23 @@
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168034925
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -22,19 +22,23 @@
import
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168033940
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -22,19 +22,23 @@
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168033466
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168032846
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -22,19 +22,23 @@
import
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r168026607
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167814459
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167807269
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -44,14 +48,15 @@
private final Boolean
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167800249
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/spout/RichSpoutBatchExecutor.java
---
@@ -194,7 +194,12 @@ public void reportError(Throwable t)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167625247
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
@@ -40,109 +40,117 @@
import org.apache.storm.nimbus.NimbusInfo;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167402753
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167388018
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167387844
--- Diff: pom.xml ---
@@ -259,6 +259,7 @@
1.11
4.3.3
0.2.4
+2.0.1
--- End diff --
I guess I
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167387808
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -44,14 +48,15 @@
private final Boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167387609
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167387629
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167385890
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167385590
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -44,14 +48,15 @@
private final Boolean
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167383283
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Acker.java ---
@@ -99,17 +100,19 @@ public void execute(Tuple input) {
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167381302
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
@@ -40,109 +40,117 @@
import org.apache.storm.nimbus.NimbusInfo;
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167379385
--- Diff: pom.xml ---
@@ -259,6 +259,7 @@
1.11
4.3.3
0.2.4
+2.0.1
--- End diff --
I dont
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167286165
--- Diff: pom.xml ---
@@ -259,6 +259,7 @@
1.11
4.3.3
0.2.4
+2.0.1
--- End diff --
Why does
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167328981
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -44,14 +48,15 @@
private final Boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167286543
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -890,30 +871,91 @@
public static final String TOPOLOGY_ISOLATED_MACHINES =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167325679
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerTransfer.java ---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167288058
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Acker.java ---
@@ -99,17 +100,19 @@ public void execute(Tuple input) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167286681
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -890,30 +871,91 @@
public static final String TOPOLOGY_ISOLATED_MACHINES =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167325584
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerTransfer.java ---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167282875
--- Diff: docs/Concepts.md ---
@@ -113,3 +113,8 @@ Topologies execute across one or more worker processes.
Each worker process is a
**Resources:**
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167287026
--- Diff: storm-client/src/jvm/org/apache/storm/StormTimer.java ---
@@ -97,6 +97,8 @@ public void run() {
// events.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167330523
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167331543
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/spout/RichSpoutBatchExecutor.java
---
@@ -194,7 +194,12 @@ public void reportError(Throwable t) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167326878
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -313,107 +330,74 @@ public void metricsTick(Task taskData, TupleImpl
tuple) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167293987
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -456,137 +450,135 @@ public void refreshStormActive(Runnable callback)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167287393
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
@@ -40,109 +40,117 @@
import org.apache.storm.nimbus.NimbusInfo;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167288382
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -362,6 +362,8 @@ public static void addSystemStreams(StormTopology
topology)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167285848
--- Diff:
flux/flux-core/src/test/java/org/apache/storm/flux/multilang/MultilangEnvironmentTest.java
---
@@ -18,6 +18,7 @@
package
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r167097905
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java ---
@@ -17,72 +17,124 @@
*/
package org.apache.storm.executor;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r164971328
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java
---
@@ -89,63 +107,80 @@ public void emitDirect(int taskId,
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r164956555
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java ---
@@ -17,72 +17,124 @@
*/
package org.apache.storm.executor;
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r164955129
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r163967849
--- Diff: storm-client/src/jvm/org/apache/storm/cluster/ClusterUtils.java
---
@@ -47,7 +47,6 @@
public static final String STORMS_ROOT =
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161361250
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ObjectReader.java ---
@@ -76,6 +76,32 @@ public static Integer getInt(Object o, Integer
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161361184
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java ---
@@ -24,50 +24,46 @@
import org.apache.storm.task.GeneralTopologyContext;
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161359459
--- Diff:
storm-client/src/jvm/org/apache/storm/serialization/SerializationFactory.java
---
@@ -20,6 +20,7 @@
import org.apache.storm.Config;
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161359446
--- Diff: storm-client/src/jvm/org/apache/storm/executor/TupleInfo.java ---
@@ -23,7 +23,7 @@
import java.io.Serializable;
import
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161358991
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161358833
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161358582
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -196,19 +197,21 @@ public static Executor mkExecutor(WorkerState
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161358493
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,159 @@ public void start() throws Exception {
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161358387
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/metrics/SpoutThrottlingMetrics.java
---
@@ -22,24 +22,25 @@
public class
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161357014
--- Diff: storm-client/src/jvm/org/apache/storm/StormTimer.java ---
@@ -193,6 +210,24 @@ public void run() {
});
}
+
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r161356532
--- Diff: docs/Performance.md ---
@@ -0,0 +1,132 @@
+---
--- End diff --
I am putting a link to this doc from Concepts.md. If you have
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r160066094
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -177,6 +195,35 @@ public BuiltinMetrics getBuiltInMetrics() {
return
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r160065976
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java ---
@@ -24,50 +24,46 @@
import org.apache.storm.task.GeneralTopologyContext;
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r160011014
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -177,6 +195,35 @@ public BuiltinMetrics getBuiltInMetrics() {
return
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r160010894
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -105,19 +134,16 @@ public void reportError(Throwable
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969475
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -328,20 +328,22 @@ public static boolean isSystemId(String id) {
* @return
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159962361
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java ---
@@ -17,72 +17,124 @@
*/
package org.apache.storm.executor;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969170
--- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java ---
@@ -0,0 +1,458 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159956952
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159968476
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ObjectReader.java ---
@@ -76,6 +76,32 @@ public static Integer getInt(Object o, Integer
defaultValue)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969789
--- Diff: storm-server/src/main/java/org/apache/storm/Testing.java ---
@@ -712,6 +712,6 @@ public static Tuple testTuple(List values,
MkTupleParam param) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159954152
--- Diff: storm-client/src/jvm/org/apache/storm/StormTimer.java ---
@@ -193,6 +210,24 @@ public void run() {
});
}
+/**
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159957697
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,159 @@ public void start() throws Exception {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969910
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -79,6 +79,7 @@
protected final long
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159954450
--- Diff: storm-client/src/jvm/org/apache/storm/cluster/ClusterUtils.java
---
@@ -47,7 +47,6 @@
public static final String STORMS_ROOT = "storms";
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159967636
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java ---
@@ -24,50 +24,46 @@
import org.apache.storm.task.GeneralTopologyContext;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159949952
--- Diff: docs/Performance.md ---
@@ -0,0 +1,132 @@
+---
--- End diff --
Great Documentation, but can we have some of the other docs link to
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159958378
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,159 @@ public void start() throws Exception {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159963018
--- Diff: storm-client/src/jvm/org/apache/storm/executor/TupleInfo.java ---
@@ -23,7 +23,7 @@
import java.io.Serializable;
import java.util.List;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159955584
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/metrics/SpoutThrottlingMetrics.java
---
@@ -22,24 +22,25 @@
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159960326
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
getExecutorType(WorkerTopologyContext
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159960500
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
getExecutorType(WorkerTopologyContext
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159966670
--- Diff:
storm-client/src/jvm/org/apache/storm/serialization/SerializationFactory.java
---
@@ -20,6 +20,7 @@
import org.apache.storm.Config;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159959648
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -196,19 +197,21 @@ public static Executor mkExecutor(WorkerState
workerState,
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159968772
--- Diff: storm-client/src/jvm/org/apache/storm/utils/RunningAvg.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
80 matches
Mail list logo
