GitHub user govind-menon reopened a pull request:
https://github.com/apache/storm/pull/2881
STORM-3259: NUMA Support for Storm
Only functional changes - putting up for review now and tests soon to
follow.
Have Done the following tests
1. Mixed cluster - numa
Github user govind-menon closed the pull request at:
https://github.com/apache/storm/pull/2881
---
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229883970
--- Diff:
storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java ---
@@ -414,6 +418,34 @@ public void validateInteger(String name,
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229880617
--- Diff:
storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java ---
@@ -414,6 +418,34 @@ public void validateInteger(String name, Object o)
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229879326
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -607,6 +608,27 @@ protected String javaCmd(String cmd) {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229876743
--- Diff:
storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java ---
@@ -414,6 +418,34 @@ public void validateInteger(String name, Object o)
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229878430
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -607,6 +608,27 @@ protected String javaCmd(String cmd) {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229875813
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1041,6 +1041,24 @@
@isPositiveNumber
@NotNull
public static
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229869065
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -622,22 +624,26 @@ public boolean areAllConnectionsReady() {
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229854058
--- Diff:
storm-server/src/test/java/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -319,7 +319,15 @@ public void testLaunch()
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229853904
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceOffer.java
---
@@ -81,6 +81,20 @@ public void
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228300609
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -121,11 +121,68 @@
private static String memoizedLocalHostnameString = null;
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228303554
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -87,7 +87,7 @@ public Slot(AsyncLocalizer localizer, Map
conf,
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228307991
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228298411
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228321490
--- Diff:
storm-server/src/test/java/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -319,7 +319,15 @@ public void testLaunch() throws
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228319880
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceOffer.java
---
@@ -81,6 +81,20 @@ public void
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228298658
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228301282
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -327,10 +396,12 @@ public static boolean isSystemId(String id) {
}
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228321712
--- Diff:
storm-server/src/test/java/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -390,6 +398,116 @@ public void testLaunch() throws
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228287958
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -607,6 +608,27 @@ protected String javaCmd(String cmd) {
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228287568
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -622,22 +624,26 @@ public boolean areAllConnectionsReady() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228266730
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SynchronizeAssignments.java
---
@@ -12,16 +12,24 @@
package
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228264081
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -77,6 +91,15 @@ public static BlobKeySequenceInfo
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228266466
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
---
@@ -17,14 +17,23 @@
import
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228227560
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1041,6 +1041,19 @@
@isPositiveNumber
@NotNull
public static
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228265639
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -607,6 +608,27 @@ protected String javaCmd(String cmd) {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228264226
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -101,7 +124,11 @@ public static BlobKeySequenceInfo
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227979286
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227972886
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227936615
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -155,6 +156,7 @@ public WorkerState(Map conf, IContext
mqContext, String
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227896771
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1041,6 +1041,19 @@
@isPositiveNumber
@NotNull
public static final
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227979722
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227976069
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227975023
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -121,11 +121,68 @@
private static String memoizedLocalHostnameString = null;
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227974287
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227413704
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1041,6 +1041,19 @@
@isPositiveNumber
@NotNull
public
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227146299
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -348,14 +350,27 @@ public void doExecutorHeartbeats() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226707991
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -820,8 +824,15 @@ private long
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226692517
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1041,6 +1041,19 @@
@isPositiveNumber
@NotNull
public static
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226707791
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -639,6 +639,10 @@ protected String javaCmd(String cmd) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226693412
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -348,14 +350,27 @@ public void doExecutorHeartbeats() {
if
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226082482
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -121,11 +121,68 @@
private static String memoizedLocalHostnameString =
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226082082
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -630,7 +632,7 @@ public boolean areAllConnectionsReady() {
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226081834
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -121,11 +121,68 @@
private static String memoizedLocalHostnameString =
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226060529
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -630,7 +632,7 @@ public boolean areAllConnectionsReady() {
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226065664
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -121,11 +121,68 @@
private static String memoizedLocalHostnameString = null;
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226065179
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -121,11 +121,68 @@
private static String memoizedLocalHostnameString = null;
GitHub user govind-menon opened a pull request:
https://github.com/apache/storm/pull/2881
STORM-3259: NUMA Support for Storm
Only functional changes - putting up for review now and tests soon to
follow.
Have Done the following tests
1. Mixed cluster - numa
49 matches
Mail list logo
