srdo commented on issue #2911: STORM-2720 : Add TIMESTAMP option for
FirstPollOffset for Kafka Trident spout
URL: https://github.com/apache/storm/pull/2911#issuecomment-489502927
1. The build is broken due to https://github.com/apache/storm/pull/3007.
Don't worry about it, once that one
janithkv commented on issue #2911: STORM-2720 : Add TIMESTAMP option for
FirstPollOffset for Kafka Trident spout
URL: https://github.com/apache/storm/pull/2911#issuecomment-489497940
@srdo @HeartSaVioR , Could you guys take a look.
1. Not sure how to make the PR build
2. Any
Ooops... just missed it... my +1 as well
Just finished verifying the foll:- spun up local cluster with binary dist-
checked single a 2 worker modes. with and without ackers in each mode- ran
SimplifiedWordCountTopo- did some quick perf verifications with
ConstSpoutNullBolt- basic checking of
Wow. This is a special occasion…
The 2.0 release has been a very long time in the making, I can’t begin to thank
all those who helped shepherd this branch to release quality.
To me this is an Apache project at it’s finest. We’ve seen core contributors
come and go. And when they go, we’ve seen
janithkv commented on a change in pull request #2911: STORM-2720 : Add
TIMESTAMP option for FirstPollOffset for Kafka Trident spout
URL: https://github.com/apache/storm/pull/2911#discussion_r281036445
##
File path:
janithkv commented on issue #2911: STORM-2720 : Add TIMESTAMP option for
FirstPollOffset for Kafka Trident spout
URL: https://github.com/apache/storm/pull/2911#issuecomment-489457197
@HeartSaVioR @srdo , This totally went out of my radar. Fixing it right now
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024769
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024798
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281025109
##
File path:
srdo commented on issue #2990: STORM-3372: Fix NPE when shutting down HFSSpout,
fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#issuecomment-489432697
Added as many comments as I could think of.
This is
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024862
##
File path: external/storm-hdfs/src/test/resources/log4j.properties
##
@@ -20,7
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024828
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024769
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024727
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024711
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024575
##
File path:
HeartSaVioR commented on issue #2911: STORM-2720 : Add TIMESTAMP option for
FirstPollOffset for Kafka Trident spout
URL: https://github.com/apache/storm/pull/2911#issuecomment-489431835
This is definitely a good feature to add. @janithkv Do you have any update?
I guess you didn't actually
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024485
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024452
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024458
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024458
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024422
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024422
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024342
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024326
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024273
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024077
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024104
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024077
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024022
##
File path:
srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024003
##
File path:
srdo commented on issue #2990: STORM-3372: Fix NPE when shutting down HFSSpout,
fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#issuecomment-489430470
Yes, will add some comments soon.
This is an
asfgit merged pull request #2996: STORM-3376: Set Server callback before
opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996
This is an automated message from the Apache Git Service.
To respond to
asfgit merged pull request #2998: STORM-3379: Fix intermittent NPE during
worker boot in local mode
URL: https://github.com/apache/storm/pull/2998
This is an automated message from the Apache Git Service.
To respond to
srdo commented on issue #2998: STORM-3379: Fix intermittent NPE during worker
boot in local mode
URL: https://github.com/apache/storm/pull/2998#issuecomment-489430151
Squashed and rebased on top of STORM-3376. Will merge shortly. Thanks for
the reviews.
srdo commented on issue #2996: STORM-3376: Set Server callback before opening
Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#issuecomment-489430101
Squashed. Will merge shortly.
This is an automated
srdo commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281023445
##
File path:
HeartSaVioR commented on issue #2998: STORM-3379: Fix intermittent NPE during
worker boot in local mode
URL: https://github.com/apache/storm/pull/2998#issuecomment-489428925
Will also put +1 once everything is sorted out in #2996.
HeartSaVioR commented on issue #2990: STORM-3372: Fix NPE when shutting down
HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#issuecomment-489428808
Could you kindly add some guide comments to understand the changes on tests?
Looks like refactor and actual
HeartSaVioR commented on issue #2996: STORM-3376: Set Server callback before
opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#issuecomment-489428378
Only one left.
This is an automated message
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281022695
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281022603
##
File path: storm-client/src/jvm/org/apache/storm/messaging/local/Context.java
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281022538
##
File path:
storm-client/src/jvm/org/apache/storm/security/auth/ThriftServer.java
HeartSaVioR commented on a change in pull request #2998: STORM-3379: Fix
intermittent NPE during worker boot in local mode
URL: https://github.com/apache/storm/pull/2998#discussion_r281021286
##
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java
srdo commented on a change in pull request #2998: STORM-3379: Fix intermittent
NPE during worker boot in local mode
URL: https://github.com/apache/storm/pull/2998#discussion_r281019939
##
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java
##
srdo opened a new pull request #3007: STORM-3390: Lock python test dependency
versions
URL: https://github.com/apache/storm/pull/3007
https://issues.apache.org/jira/browse/STORM-3390
This is an automated message from the
srdo commented on issue #2996: STORM-3376: Set Server callback before opening
Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#issuecomment-489420153
Addressed comments. Will squash once reviewed.
This
srdo commented on a change in pull request #2998: STORM-3379: Fix intermittent
NPE during worker boot in local mode
URL: https://github.com/apache/storm/pull/2998#discussion_r281017466
##
File path:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
srdo commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281017418
##
File path: storm-client/src/jvm/org/apache/storm/messaging/local/Context.java
##
HeartSaVioR commented on a change in pull request #2998: STORM-3379: Fix
intermittent NPE during worker boot in local mode
URL: https://github.com/apache/storm/pull/2998#discussion_r281017184
##
File path:
HeartSaVioR commented on a change in pull request #2998: STORM-3379: Fix
intermittent NPE during worker boot in local mode
URL: https://github.com/apache/storm/pull/2998#discussion_r281017058
##
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java
srdo commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281017137
##
File path:
srdo commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281017039
##
File path:
srdo commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281017001
##
File path:
storm-client/src/jvm/org/apache/storm/security/auth/ThriftServer.java
srdo commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281017011
##
File path:
srdo commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281016954
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281015621
##
File path:
storm-client/src/jvm/org/apache/storm/security/auth/ThriftServer.java
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281016125
##
File path: storm-client/src/jvm/org/apache/storm/messaging/local/Context.java
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r279687691
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r279687606
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r279687668
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r279687645
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r279687573
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281015782
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r279687711
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281015814
##
File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281015643
##
File path:
HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server
callback before opening Netty socket, so we do…
URL: https://github.com/apache/storm/pull/2996#discussion_r281015785
##
File path:
HeartSaVioR commented on a change in pull request #3005: [STORM-3385] Avoid two
threads reading from the same input stream of a process
URL: https://github.com/apache/storm/pull/3005#discussion_r281015058
##
File path:
asfgit merged pull request #2991: STORM-3373: Use Log4j BOM, align SLF4j
dependencies, upgrade SLF4j
URL: https://github.com/apache/storm/pull/2991
This is an automated message from the Apache Git Service.
To respond to the
asfgit merged pull request #2992: STORM-3371: Metrics v2 in Trident operations
URL: https://github.com/apache/storm/pull/2992
This is an automated message from the Apache Git Service.
To respond to the message, please log on
asfgit merged pull request #2989: STORM-3370: Make StormMetricRegistry
non-static, and supply it as a d…
URL: https://github.com/apache/storm/pull/2989
This is an automated message from the Apache Git Service.
To respond to
72 matches
Mail list logo
