Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1343#discussion_r60036656
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/CheckpointTupleForwarder.java ---
@@ -53,6 +53,10 @@
private long lastTxid
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1343#issuecomment-211524696
@HeartSaVioR refactored and extracted common logic to a common parent of
StatefulBoltExecutor and CheckpointTupleForwarder. Please review.
---
If your project is
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1339#issuecomment-213257503
updated the PR with the commit that fixes the issue found during test.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1360#issuecomment-214272514
@dsKarthick the change looks good. Can you also raise a jira (at
https://issues.apache.org/jira/browse/STORM) and update the PR title ?
This would likely
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1360#issuecomment-214962026
> Not sure why you say this. In my case for example, I using runit to start
storm components like nimbus, ui, etc and the problem is applicable to all
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1360#issuecomment-214998893
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1360#issuecomment-215622873
Thanks @dsKarthick merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1374#issuecomment-215623115
+1
@ptgoetz since you are cutting the 1.0.1 RC, should this wait to merge to
1.x branch?
---
If your project is set up for it, you can reply to this email
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1373#issuecomment-215623175
+1
@ptgoetz since you are cutting the 0.10.1 RC, should this wait to merge to
0.10.x branch?
---
If your project is set up for it, you can reply to this
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1336#issuecomment-218702333
@harshach @haohui can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1413
[STORM-1833] Simple equi-join in storm-sql standalone mode
Added support for simple equi-joins with single condition in storm-sql
standalone mode.
Note: this includes changes from
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1420
STORM-1841: Address a few minor issues in windowing and doc
1. Do not accept negative values for window length or sliding interval in
BaseWindowedBolt
2. Added static factories for Count
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1420#issuecomment-219516767
@harshach can you take a look ? This needs to be applied to 1.x branch as
well.
---
If your project is set up for it, you can reply to this email and have your
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220280889
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1435
[STORM-1851] Fix default nimbus impersonation authorizer config
"nimbus.impersonation.authorizer" is set to "ImpersonationAuthorizer" by
default and this causes issues
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1435#issuecomment-220376579
@harshach can you take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1437#issuecomment-220890249
@kosii Thanks for the patch, it looks good. Can you open a
[JIRA](https://issues.apache.org/jira/browse/STORM) and update the PR title to
include the JIRA ID
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220894358
Thanks @omallassi this is merged to master and 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220897907
@HeartSaVioR thanks for noticing. The changes are now merged to master,
1.x-branch and 1.0.x-branch.
@omallassi thanks for the patch. You may close this
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1437#issuecomment-220928223
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1435#issuecomment-221167394
@hmcl the details of setting up impersonation is documented in
https://github.com/apache/storm/blob/master/docs/SECURITY.md
Maybe I can explicitly mention the
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1435#issuecomment-221170903
@hmcl updated the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1435#issuecomment-221176923
@ptgoetz can you review and merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1437#issuecomment-221622376
Thanks @kosii merged to master, 1.x and 1.0.x branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1449
[STORM-1868] Modify TridentKafkaWordCount to run in distributed mode
@harshach @ptgoetz can you take a look ?
You can merge this pull request into a Git repository by running:
$ git pull
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65500717
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -268,8 +277,12 @@ public void execute(Tuple input
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65500709
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -1872,6 +1872,13 @@
@isString
public static final String
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65500739
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java ---
@@ -255,6 +255,17 @@ public BaseWindowedBolt withTimestampField
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1453
I have gone through the details and have left some comments. Can you update
the
[documentation](https://github.com/apache/storm/blob/master/docs/Windowing.md)
where it references late tuples
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r6185
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -1872,6 +1872,13 @@
@isString
public static final String
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1458
@sakanaou Thanks for the patch.
Can you also add an example flux topology with an IStatefulBolt similar to
to existing ones under
https://github.com/apache/storm/tree/master/external
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65573649
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java ---
@@ -255,6 +255,22 @@ public BaseWindowedBolt withTimestampField
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65574257
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -284,6 +298,10 @@ public void cleanup
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65573427
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java ---
@@ -255,6 +255,22 @@ public BaseWindowedBolt withTimestampField
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65659063
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -284,6 +298,10 @@ public void cleanup
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1437
@abhishej This will be part of the next release i.e. 1.0.2. If you want it
now, you could clone the 1.0.x branch (or the 1.0.1 tag and cherry-pick the
commit). You can build the distribution
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1458
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/939
@kosii Thanks for reporting. Yes the keys in `pendingPrepare` should have
priority. Typically this case does not happen since when a prepare fails, the
txn is rolled-back and retried (i.e a
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65863969
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -188,6 +189,10 @@ private void validate(Map stormConf, Count
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1464
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1458
Thanks @sakanaou merged to master, 1.x and 1.0.x branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1453
+1 Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1453
Thanks @kosii merged to master and 1.x-branch. I did not merge to
1.0.x-branch since this adds a new api and as @ptgoetz suggested it can be
targeted for 1.1.0 release.
---
If your project
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66784961
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -77,7 +81,8 @@ public RedisKeyValueState
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66784993
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -104,9 +109,11 @@ private void
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66784976
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -104,9 +109,11 @@ private void
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66785050
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -203,12 +237,14 @@ public void commit
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66785042
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -184,15 +216,17 @@ public void commit(long
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66785022
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -116,20 +123,30 @@ private void
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66785037
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -163,15 +190,20 @@ public void prepareCommit
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66785298
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +45,11 @@
* @return the value or defaultValue if no
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1470
@kosii the delete api is useful. Lets also try to see if we could handle
the deletes by maintaining an entry within the pendingPrepare itself and avoid
the extra hashsets and synchronized as
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1488
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r68537606
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -60,22 +64,23 @@ public RedisKeyValueState
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r68537628
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -60,22 +64,23 @@ public RedisKeyValueState
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r68537622
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -60,22 +64,23 @@ public RedisKeyValueState
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r68537734
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -161,7 +176,11 @@ public void prepareCommit
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1470
@kosii I have gone through the latest changes and left a few comments. The
idea of using tombstone looks nice and once the comments are addressed its good
to merge.
---
If your project is
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1528
@HeartSaVioR The changes looks good. May be you can add some comments in
sync-process and mk-synchronize-supervisor on what each is supposed to do.
In your comment where you rebalanced
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1528
@HeartSaVioR thanks for the clarification, it makes sense now. Can you also
check rebalance from 2 -> 3 workers ?
---
If your project is set up for it, you can reply to this email and h
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1528
Thanks @HeartSaVioR. It looks good.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r69395738
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -60,22 +64,23 @@ public RedisKeyValueState
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r69395744
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -161,7 +176,11 @@ public void prepareCommit
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r69395742
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -60,22 +64,23 @@ public RedisKeyValueState
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r69671675
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r69672262
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java ---
@@ -66,10 +66,14 @@ public String toString() {
* Holds
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r69672789
--- Diff:
storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java ---
@@ -26,10 +26,10 @@
* @param the type of event tracked by
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1527
@darionyaphet You need to make more changes,
1. you should use `longValue()` instead of the `intValue()` in the
`initWindowManager` where the values are read from storm conf.
2
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1413
@harshach @haohui could you please take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1552
@harshach the changes look good. May be you could also add a note about
this feature in the storm rest api docs. Since CORS is going to be on by
default, if it makes sense we could take a
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1552
@harshach May be for now we can document in the REST api doc and expose
configs in future if needed.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1557#discussion_r70657632
--- Diff: storm-core/src/clj/org/apache/storm/ui/helpers.clj ---
@@ -221,10 +221,7 @@
(defnk json-response
[data callback :serialize-fn to
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1557
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1563
[STORM-1968] Storm logviewer does not work for nimbus.log in secure cluster
logviewer invokes "get-log-user-group-whitelist" which tries to get the
worker metadata file by invokin
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1568
[STORM-1964] Unexpected behavior when using count window together with
timestamp extraction
Do not use timestamp to determine the event count in
WatermarkCountEvictionPolicy
when count
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r70955207
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r70955173
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r70955540
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java ---
@@ -66,10 +66,14 @@ public String toString() {
* Holds
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1527
Either you can use `@isNumber` or add a `@isLong` validator to decorate the
millisecond values, its not already available.
---
If your project is set up for it, you can reply to this email
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1577
[STORM-1987] Fix TridentKafkaWordCount arg handling in distributed mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1583#discussion_r72387042
--- Diff:
external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamState.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1628
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1630
[STORM-2042] Nimbus client connections not closed properly causing
connection leaks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1631
[STORM-2042] Nimbus client connections not closed properly causing
connection leaks
https://github.com/apache/storm/pull/1630 ported to master branch.
You can merge this pull request into a
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1631
@harshach this is the port of https://github.com/apache/storm/pull/1630
into master. Can you review and merge this well ?
---
If your project is set up for it, you can reply to this email and
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1636
[STORM-2047] Add note to add logviewer hosts to browser whitelist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1636#discussion_r75576234
--- Diff: docs/SECURITY.md ---
@@ -81,7 +81,9 @@ curl -i --negotiate -u:anyUser -b ~/cookiejar.txt -c
~/cookiejar.txt http://s
1. Firefox
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1635#discussion_r75822913
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/StormSqlImpl.java ---
@@ -137,18 +137,12 @@ public void submit
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1635#discussion_r75823827
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/backends/trident/TridentPostOrderRelNodeVisitor.java
---
@@ -0,0 +1,155
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1635#discussion_r75827034
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/backends/trident/TridentLogicalPlanCompiler.java
---
@@ -0,0 +1,344
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1635#discussion_r75828818
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/trident/operations/CountBy.java
---
@@ -0,0 +1,52
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1635#discussion_r75833225
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/trident/operations/CountBy.java
---
@@ -0,0 +1,52
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1635
@HeartSaVioR I have gone through the changes and left a few comments. Like
the idea of using Janino for compiling which results in cleaner code.
---
If your project is set up for it, you can
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1635#discussion_r75835366
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/backends/trident/TridentPostOrderRelNodeVisitor.java
---
@@ -0,0 +1,155
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1635#discussion_r75836816
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/trident/operations/CountBy.java
---
@@ -0,0 +1,52
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1645
[STORM-2042] Nimbus client connections not closed properly causing
connection leaks
Backport https://github.com/apache/storm/pull/1630 to 0.10.x branch
You can merge this pull request into a
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1635
@HeartSaVioR I have gone through your recent changes and it looks good.
In the logical plan you have posted, there are multiple processors just for
the project (before the aggregation
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1643
+1 looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2218
STORM-2614: Enhance stateful windowing to persist the window state
Right now the tuples in window are stored in memory. This limits the usage
to windows
that fit in memory. Also the
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2218
This builds on top of the existing state checkpointing mechanism
(documented here -
https://github.com/apache/storm/blob/master/docs/State-checkpointing.md).
Theres nothing extra added to the
1 - 100 of 846 matches
Mail list logo
