[jira] [Resolved] (THRIFT-2575) Thrift includes siginfo_t within apache::thrift::protocol namespace

2014-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2575. --- Resolution: Fixed Thrift includes siginfo_t within apache::thrift::protocol namespace

[jira] [Commented] (THRIFT-2575) Thrift includes siginfo_t within apache::thrift::protocol namespace

2014-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031057#comment-14031057 ] Ben Craig commented on THRIFT-2575: --- Latest version of the file:

[jira] [Commented] (THRIFT-2553) C++ linker error - transport/TSocket

2014-05-27 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010298#comment-14010298 ] Ben Craig commented on THRIFT-2553: --- Undefined symbols for architecture x86_64: I

[jira] [Commented] (THRIFT-2525) C# client connecting to C++ server via named pipe transport gets TTransportException

2014-05-15 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997566#comment-13997566 ] Ben Craig commented on THRIFT-2525: --- Sorry this didn't work out of the box for you

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-05-02 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988161#comment-13988161 ] Ben Craig commented on THRIFT-2457: --- I would argue for a warning like the following:

[jira] [Commented] (THRIFT-2492) test/cpp does not compile on mac

2014-04-25 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981042#comment-13981042 ] Ben Craig commented on THRIFT-2492: --- These extra changes look fine too. Haven't tested

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-04-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979794#comment-13979794 ] Ben Craig commented on THRIFT-2457: --- Hopefully it helps in that we can tell the person

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-04-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980240#comment-13980240 ] Ben Craig commented on THRIFT-2457: --- Here are some questions we need to explicitly

[jira] [Commented] (THRIFT-2492) test/cpp does not compile on mac

2014-04-23 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978417#comment-13978417 ] Ben Craig commented on THRIFT-2492: --- operator isn't intended to be code generated.

[jira] [Commented] (THRIFT-2492) test/cpp does not compile on mac

2014-04-23 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978437#comment-13978437 ] Ben Craig commented on THRIFT-2492: --- I have not tested these changes, but they look

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-23 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978567#comment-13978567 ] Ben Craig commented on THRIFT-2471: --- [~henrique] : There are some challenges with using

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-04-21 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976049#comment-13976049 ] Ben Craig commented on THRIFT-2457: --- Maybe scan the entire .thrift file for usages of

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974274#comment-13974274 ] Ben Craig commented on THRIFT-2471: --- I'd rather not try to fix cycles magically. MSRPC

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-04-17 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972925#comment-13972925 ] Ben Craig commented on THRIFT-2457: --- I do have a concern about adding new types. Say

[jira] [Commented] (THRIFT-2467) Unable to build contrib/fb303 on OSX 10.9.2

2014-04-14 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968355#comment-13968355 ] Ben Craig commented on THRIFT-2467: --- I'm guessing that contrib/fb303 isn't being built

[jira] [Commented] (THRIFT-2421) Tree/Recursive struct support in thrift

2014-04-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961832#comment-13961832 ] Ben Craig commented on THRIFT-2421: --- I don't have the time to personally test / commit

[jira] [Commented] (THRIFT-2421) Tree/Recursive struct support in thrift

2014-04-02 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958414#comment-13958414 ] Ben Craig commented on THRIFT-2421: --- original pull request + self assignment pull

[jira] [Commented] (THRIFT-2421) Tree/Recursive struct support in thrift

2014-03-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946006#comment-13946006 ] Ben Craig commented on THRIFT-2421: --- I set up a review (and some initial commentary)

[jira] [Commented] (THRIFT-2361) TNonBlockingServer: Provide ability to specify libevent priority

2014-03-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939182#comment-13939182 ] Ben Craig commented on THRIFT-2361: --- Caveat: I'm not an expert on libevent. I also

[jira] [Resolved] (THRIFT-2029) Port C++ tests to Windows

2014-02-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2029. --- Resolution: Fixed Port C++ tests to Windows - Key:

[jira] [Closed] (THRIFT-2029) Port C++ tests to Windows

2014-02-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2029. - Port C++ tests to Windows - Key: THRIFT-2029

[jira] [Commented] (THRIFT-2366) Running Thrift in a single process / as a foreign function interface

2014-02-17 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903278#comment-13903278 ] Ben Craig commented on THRIFT-2366: --- I think I would implement this at the transport

[jira] [Commented] (THRIFT-2029) Port C++ tests to Windows

2014-01-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865507#comment-13865507 ] Ben Craig commented on THRIFT-2029: --- Here's a possible fix that I have not tested...

[jira] [Commented] (THRIFT-2286) Failed to compile Thrift0.9.1 with boost1.55 by VS2010 if select Debug-mtx64 mode.

2013-12-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847517#comment-13847517 ] Ben Craig commented on THRIFT-2286: --- I believe the _wassert issue has been fixed in

[jira] [Reopened] (THRIFT-1944) Binding to zero port

2013-12-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reopened THRIFT-1944: --- Binding to zero port Key: THRIFT-1944 URL:

[jira] [Commented] (THRIFT-1944) Binding to zero port

2013-12-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841538#comment-13841538 ] Ben Craig commented on THRIFT-1944: --- Just to make sure this doesn't get lost, I will

[jira] [Commented] (THRIFT-2258) Add TLS v1.1/1.2 support to TSSLSocket.cpp

2013-12-04 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838913#comment-13838913 ] Ben Craig commented on THRIFT-2258: --- I apologize. I've been swamped at work, so I

[jira] [Closed] (THRIFT-2266) ThreadManager.h:24:10: fatal error: 'tr1/functional' file not found on Mac 10.9 (Mavericks)

2013-11-21 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2266. - Resolution: Duplicate ThreadManager.h:24:10: fatal error: 'tr1/functional' file not found on Mac

[jira] [Commented] (THRIFT-2266) ThreadManager.h:24:10: fatal error: 'tr1/functional' file not found on Mac 10.9 (Mavericks)

2013-11-21 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828953#comment-13828953 ] Ben Craig commented on THRIFT-2266: --- This particular issue has been resolved in 0.9.1.

[jira] [Commented] (THRIFT-2229) thrift failed to build on OSX 10.9 GM

2013-11-21 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829117#comment-13829117 ] Ben Craig commented on THRIFT-2229: --- That is fixed in master: THRIFT-2201 thrift

[jira] [Commented] (THRIFT-2229) thrift failed to build on OSX 10.9 GM

2013-11-12 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820346#comment-13820346 ] Ben Craig commented on THRIFT-2229: --- For legal / non-technical reasons, the patches

[jira] [Assigned] (THRIFT-1025) C++ ServerSocket should inherit from Socket with the necessary Ctor to listen on connections from a specific host (similar to perl library)

2013-11-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-1025: - Assignee: Ben Craig C++ ServerSocket should inherit from Socket with the necessary Ctor to

[jira] [Assigned] (THRIFT-2255) add Parent Class for generated Struct class

2013-11-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2255: - Assignee: Ben Craig add Parent Class for generated Struct class

[jira] [Assigned] (THRIFT-2258) Add TLS v1.1/1.2 support to TSSLSocket.cpp

2013-11-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2258: - Assignee: Ben Craig Add TLS v1.1/1.2 support to TSSLSocket.cpp

[jira] [Closed] (THRIFT-2214) System header sys/param.h is included inside the Thrift namespace

2013-11-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2214. - System header sys/param.h is included inside the Thrift namespace

[jira] [Commented] (THRIFT-2252) Optimize the overhead of the tag message of the request

2013-11-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815259#comment-13815259 ] Ben Craig commented on THRIFT-2252: --- On the C++ side, if we were to implement this,

[jira] [Commented] (THRIFT-2252) Optimize the overhead of the tag message of the request

2013-11-05 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814040#comment-13814040 ] Ben Craig commented on THRIFT-2252: --- This could be done, but it would need to be

[jira] [Resolved] (THRIFT-2214) System header sys/param.h is included inside the Thrift namespace

2013-11-05 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2214. --- Resolution: Fixed Fix Version/s: 0.9.2 Committed. Thanks Vladmir! System header

[jira] [Commented] (THRIFT-2243) TNonblockingServer in thrift crashes when TFramedTransport opens

2013-11-03 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812506#comment-13812506 ] Ben Craig commented on THRIFT-2243: --- I am confused about the client side. The code you

[jira] [Assigned] (THRIFT-2245) Allow Custom Prefix in Include Guards

2013-10-29 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2245: - Assignee: Ben Craig Allow Custom Prefix in Include Guards

[jira] [Commented] (THRIFT-579) Alternative ASIO based fully async client/server for C++

2013-10-29 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808673#comment-13808673 ] Ben Craig commented on THRIFT-579: -- I have made a first stab at the code review. After

[jira] [Commented] (THRIFT-2242) Generate C++11 code

2013-10-28 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806787#comment-13806787 ] Ben Craig commented on THRIFT-2242: --- It's probably going to be a while before we get to

[jira] [Commented] (THRIFT-2242) Generate C++11 code

2013-10-28 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806957#comment-13806957 ] Ben Craig commented on THRIFT-2242: --- As of 10/28/2013 (today), GCC's C++11 support is

[jira] [Commented] (THRIFT-2242) Generate C++11 code

2013-10-28 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807101#comment-13807101 ] Ben Craig commented on THRIFT-2242: --- If we were to make changes that broke source

[jira] [Commented] (THRIFT-579) Alternative ASIO based fully async client/server for C++

2013-10-27 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806513#comment-13806513 ] Ben Craig commented on THRIFT-579: -- I have set up a review at

[jira] [Assigned] (THRIFT-2229) thrift failed to build on OSX 10.9 GM

2013-10-21 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2229: - Assignee: Ben Craig thrift failed to build on OSX 10.9 GM

[jira] [Assigned] (THRIFT-2140) Error compiling cpp tutorials

2013-10-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2140: - Assignee: Ben Craig Error compiling cpp tutorials -

[jira] [Commented] (THRIFT-2230) Cannot Build on RHEL/Centos/Amazon Linux 6.x

2013-10-17 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798322#comment-13798322 ] Ben Craig commented on THRIFT-2230: --- If you're willing to create a patch to require a

[jira] [Commented] (THRIFT-2229) thrift failed to build on OSX 10.9 GM

2013-10-16 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797110#comment-13797110 ] Ben Craig commented on THRIFT-2229: --- I believe this is fixed already in master. Some

[jira] [Commented] (THRIFT-2229) thrift failed to build on OSX 10.9 GM

2013-10-16 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797207#comment-13797207 ] Ben Craig commented on THRIFT-2229: --- Not 100% sure on this, but probably by changing

[jira] [Resolved] (THRIFT-2026) Fix TCompactProtocol 64 bit builds

2013-10-14 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2026. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 Fix

[jira] [Resolved] (THRIFT-2034) Give developers' C++ code direct access to socket FDs on server side

2013-10-14 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2034. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 Give developers'

[jira] [Updated] (THRIFT-2028) Cleanup threading headers / libraries

2013-10-14 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2028: -- Attachment: thread_cleanup.patch Updated / rebased. Cleanup threading headers / libraries

[jira] [Updated] (THRIFT-2028) Cleanup threading headers / libraries

2013-10-14 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2028: -- Attachment: (was: thread_cleanup.patch) Cleanup threading headers / libraries

[jira] [Commented] (THRIFT-579) Alternative ASIO based fully async client/server for C++

2013-10-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793714#comment-13793714 ] Ben Craig commented on THRIFT-579: -- I will look at this for this release. It will

[jira] [Assigned] (THRIFT-579) Alternative ASIO based fully async client/server for C++

2013-10-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-579: Assignee: Ben Craig Alternative ASIO based fully async client/server for C++

[jira] [Commented] (THRIFT-2226) TServerSocket - keepAlive wrong initialization order

2013-10-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13792585#comment-13792585 ] Ben Craig commented on THRIFT-2226: --- hmm, I used to get that particular warning. I

[jira] [Resolved] (THRIFT-2226) TServerSocket - keepAlive wrong initialization order

2013-10-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2226. --- Resolution: Fixed Fix Version/s: 0.9.2 Assignee: Ben Craig Commited TServerSocket

[jira] [Closed] (THRIFT-2045) C++ compiler warning and build cleanup

2013-10-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2045. - C++ compiler warning and build cleanup -- Key:

[jira] [Closed] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2013-10-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-1750. - Make compiler build cleanly under visual studio 10 --

[jira] [Resolved] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2013-10-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-1750. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 Make compiler

[jira] [Closed] (THRIFT-2226) TServerSocket - keepAlive wrong initialization order

2013-10-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2226. - TServerSocket - keepAlive wrong initialization order

[jira] [Resolved] (THRIFT-1892) Socket timeouts are declared in milli-seconds, but are actually set in micro-seconds

2013-10-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-1892. --- Resolution: Fixed Fix Version/s: 0.9.2 Socket timeouts are declared in milli-seconds, but

[jira] [Closed] (THRIFT-1892) Socket timeouts are declared in milli-seconds, but are actually set in micro-seconds

2013-10-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-1892. - Socket timeouts are declared in milli-seconds, but are actually set in micro-seconds

[jira] [Assigned] (THRIFT-1712) Add TBase class for c++

2013-10-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-1712: - Assignee: Ben Craig Add TBase class for c++ --- Key:

[jira] [Assigned] (THRIFT-2214) System header sys/param.h is included inside the Thrift namespace

2013-10-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2214: - Assignee: Ben Craig System header sys/param.h is included inside the Thrift namespace

[jira] [Assigned] (THRIFT-2224) TSSLSocket.h and TSSLServerSocket.h should use the platfromsocket too

2013-10-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2224: - Assignee: Ben Craig TSSLSocket.h and TSSLServerSocket.h should use the platfromsocket too

[jira] [Assigned] (THRIFT-1819) Thrift has many unused #includes

2013-10-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-1819: - Assignee: Ben Craig Thrift has many unused #includes

[jira] [Assigned] (THRIFT-2216) Extraneous semicolon in TProtocolUtil.h makes clang mad

2013-10-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-2216: - Assignee: Ben Craig (was: Andrew McGeachie) Extraneous semicolon in TProtocolUtil.h makes

[jira] [Updated] (THRIFT-2031) Make SO_KEEPALIVE configurable for C++ lib

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2031: -- Attachment: (was: keep_alive2.patch) Make SO_KEEPALIVE configurable for C++ lib

[jira] [Updated] (THRIFT-2031) Make SO_KEEPALIVE configurable for C++ lib

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2031: -- Attachment: keep_alive3.patch Not real sure what I was thinking with that. I want to say I copy /

[jira] [Updated] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2027: -- Attachment: (was: misc_minor.patch) Minor 64-bit and NOMINMAX issues in C++ library

[jira] [Updated] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2027: -- Attachment: misc_minor.patch It's 2013, and the world is still dealing with EOL conflicts. Old patch

[jira] [Updated] (THRIFT-2045) C++ compiler warning and build cleanup

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2045: -- Attachment: windows_compiler_port.patch Once more... with feeling. Using config.h and guarding it

[jira] [Resolved] (THRIFT-2019) Writing on a disconnected socket on Mac causes SIG PIPE

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2019. --- Resolution: Fixed Writing on a disconnected socket on Mac causes SIG PIPE

[jira] [Closed] (THRIFT-2019) Writing on a disconnected socket on Mac causes SIG PIPE

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2019. - Writing on a disconnected socket on Mac causes SIG PIPE

[jira] [Closed] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2027. - Minor 64-bit and NOMINMAX issues in C++ library ---

[jira] [Resolved] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-1751. --- Resolution: Fixed definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not

[jira] [Resolved] (THRIFT-2031) Make SO_KEEPALIVE configurable for C++ lib

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2031. --- Resolution: Fixed Make SO_KEEPALIVE configurable for C++ lib

[jira] [Closed] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-1751. - definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

[jira] [Closed] (THRIFT-2031) Make SO_KEEPALIVE configurable for C++ lib

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2031. - Make SO_KEEPALIVE configurable for C++ lib --

[jira] [Closed] (THRIFT-2021) Improve large binary protocol string performance

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2021. - Improve large binary protocol string performance

[jira] [Resolved] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2027. --- Resolution: Fixed Minor 64-bit and NOMINMAX issues in C++ library

[jira] [Resolved] (THRIFT-2021) Improve large binary protocol string performance

2013-10-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2021. --- Resolution: Fixed Improve large binary protocol string performance

[jira] [Commented] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

2013-10-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789723#comment-13789723 ] Ben Craig commented on THRIFT-1751: --- I can do that. In either case, you will get an

[jira] [Commented] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2013-10-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789733#comment-13789733 ] Ben Craig commented on THRIFT-1750: --- Ack! In my June 2013 mega patch upload, this

[jira] [Commented] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2013-10-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789745#comment-13789745 ] Ben Craig commented on THRIFT-1750: --- As soon as 2045 is wrapped up, I'll close it as

[jira] [Resolved] (THRIFT-2045) C++ compiler warning and build cleanup

2013-10-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2045. --- Resolution: Fixed Changed MINGW - _WIN32 in the go generator and submitted (after a rebuild) C++

[jira] [Updated] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

2013-10-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1751: -- Attachment: (was: TServer_guard.patch) definition of increase_max_fds doesn't compile when

[jira] [Updated] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

2013-10-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1751: -- Attachment: TServer_guard2.patch Updated from svn patch, and now guarding the prototype definition

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2013-10-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788127#comment-13788127 ] Ben Craig commented on THRIFT-2221: --- This probably isn't happening for a while. See

[jira] [Commented] (THRIFT-1682) Multiple thread calling a Service function unsafely causes message corruption and terminates with Broken Pipe

2013-10-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788128#comment-13788128 ] Ben Craig commented on THRIFT-1682: --- C++ client objects are not intended to be thread

[jira] [Updated] (THRIFT-2045) C++ compiler warning and build cleanup

2013-10-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2045: -- Attachment: (was: windows_compiler_port.patch) C++ compiler warning and build cleanup

[jira] [Updated] (THRIFT-2045) C++ compiler warning and build cleanup

2013-10-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2045: -- Attachment: windows_compiler_port.patch updating from June, due to addition of cassert header. C++

[jira] [Updated] (THRIFT-2031) Make SO_KEEPALIVE configurable for C++ lib

2013-10-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2031: -- Attachment: keep_alive2.patch Updates to switch from -1 to macro Make SO_KEEPALIVE configurable for

[jira] [Updated] (THRIFT-2031) Make SO_KEEPALIVE configurable for C++ lib

2013-10-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2031: -- Attachment: (was: keep_alive2.patch) Make SO_KEEPALIVE configurable for C++ lib

[jira] [Commented] (THRIFT-2034) Give developers' C++ code direct access to socket FDs on server side

2013-10-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788536#comment-13788536 ] Ben Craig commented on THRIFT-2034: --- Processor events need to work for all transports,

[jira] [Resolved] (THRIFT-2139) MSVC 2012 Error - Cannot compile due to BoostThreadFactory

2013-09-27 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2139. --- Resolution: Fixed Fix Version/s: 0.9.2 Committed. Thanks Alex! Minor issue for future

[jira] [Commented] (THRIFT-2200) nested structs cause generate_fingerprint() to slow down at excessive CPU load

2013-09-23 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774545#comment-13774545 ] Ben Craig commented on THRIFT-2200: --- I have not tested the patch and I don't use

[jira] [Commented] (THRIFT-2139) MSVC 2012 Error - Cannot compile due to BoostThreadFactory

2013-09-23 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774735#comment-13774735 ] Ben Craig commented on THRIFT-2139: --- The patch looks reasonable, but I haven't had a

<    1   2   3   4   >