[
https://issues.apache.org/jira/browse/THRIFT-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2575.
---
Resolution: Fixed
Thrift includes siginfo_t within apache::thrift::protocol namespace
[
https://issues.apache.org/jira/browse/THRIFT-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031057#comment-14031057
]
Ben Craig commented on THRIFT-2575:
---
Latest version of the file:
[
https://issues.apache.org/jira/browse/THRIFT-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010298#comment-14010298
]
Ben Craig commented on THRIFT-2553:
---
Undefined symbols for architecture x86_64:
I
[
https://issues.apache.org/jira/browse/THRIFT-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997566#comment-13997566
]
Ben Craig commented on THRIFT-2525:
---
Sorry this didn't work out of the box for you
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988161#comment-13988161
]
Ben Craig commented on THRIFT-2457:
---
I would argue for a warning like the following:
[
https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981042#comment-13981042
]
Ben Craig commented on THRIFT-2492:
---
These extra changes look fine too. Haven't tested
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979794#comment-13979794
]
Ben Craig commented on THRIFT-2457:
---
Hopefully it helps in that we can tell the person
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980240#comment-13980240
]
Ben Craig commented on THRIFT-2457:
---
Here are some questions we need to explicitly
[
https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978417#comment-13978417
]
Ben Craig commented on THRIFT-2492:
---
operator isn't intended to be code generated.
[
https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978437#comment-13978437
]
Ben Craig commented on THRIFT-2492:
---
I have not tested these changes, but they look
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978567#comment-13978567
]
Ben Craig commented on THRIFT-2471:
---
[~henrique] : There are some challenges with using
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976049#comment-13976049
]
Ben Craig commented on THRIFT-2457:
---
Maybe scan the entire .thrift file for usages of
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974274#comment-13974274
]
Ben Craig commented on THRIFT-2471:
---
I'd rather not try to fix cycles magically. MSRPC
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972925#comment-13972925
]
Ben Craig commented on THRIFT-2457:
---
I do have a concern about adding new types. Say
[
https://issues.apache.org/jira/browse/THRIFT-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968355#comment-13968355
]
Ben Craig commented on THRIFT-2467:
---
I'm guessing that contrib/fb303 isn't being built
[
https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961832#comment-13961832
]
Ben Craig commented on THRIFT-2421:
---
I don't have the time to personally test / commit
[
https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958414#comment-13958414
]
Ben Craig commented on THRIFT-2421:
---
original pull request + self assignment pull
[
https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946006#comment-13946006
]
Ben Craig commented on THRIFT-2421:
---
I set up a review (and some initial commentary)
[
https://issues.apache.org/jira/browse/THRIFT-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939182#comment-13939182
]
Ben Craig commented on THRIFT-2361:
---
Caveat: I'm not an expert on libevent. I also
[
https://issues.apache.org/jira/browse/THRIFT-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2029.
---
Resolution: Fixed
Port C++ tests to Windows
-
Key:
[
https://issues.apache.org/jira/browse/THRIFT-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2029.
-
Port C++ tests to Windows
-
Key: THRIFT-2029
[
https://issues.apache.org/jira/browse/THRIFT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903278#comment-13903278
]
Ben Craig commented on THRIFT-2366:
---
I think I would implement this at the transport
[
https://issues.apache.org/jira/browse/THRIFT-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865507#comment-13865507
]
Ben Craig commented on THRIFT-2029:
---
Here's a possible fix that I have not tested...
[
https://issues.apache.org/jira/browse/THRIFT-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847517#comment-13847517
]
Ben Craig commented on THRIFT-2286:
---
I believe the _wassert issue has been fixed in
[
https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reopened THRIFT-1944:
---
Binding to zero port
Key: THRIFT-1944
URL:
[
https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841538#comment-13841538
]
Ben Craig commented on THRIFT-1944:
---
Just to make sure this doesn't get lost, I will
[
https://issues.apache.org/jira/browse/THRIFT-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838913#comment-13838913
]
Ben Craig commented on THRIFT-2258:
---
I apologize. I've been swamped at work, so I
[
https://issues.apache.org/jira/browse/THRIFT-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2266.
-
Resolution: Duplicate
ThreadManager.h:24:10: fatal error: 'tr1/functional' file not found on Mac
[
https://issues.apache.org/jira/browse/THRIFT-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828953#comment-13828953
]
Ben Craig commented on THRIFT-2266:
---
This particular issue has been resolved in 0.9.1.
[
https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829117#comment-13829117
]
Ben Craig commented on THRIFT-2229:
---
That is fixed in master: THRIFT-2201
thrift
[
https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820346#comment-13820346
]
Ben Craig commented on THRIFT-2229:
---
For legal / non-technical reasons, the patches
[
https://issues.apache.org/jira/browse/THRIFT-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-1025:
-
Assignee: Ben Craig
C++ ServerSocket should inherit from Socket with the necessary Ctor to
[
https://issues.apache.org/jira/browse/THRIFT-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2255:
-
Assignee: Ben Craig
add Parent Class for generated Struct class
[
https://issues.apache.org/jira/browse/THRIFT-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2258:
-
Assignee: Ben Craig
Add TLS v1.1/1.2 support to TSSLSocket.cpp
[
https://issues.apache.org/jira/browse/THRIFT-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2214.
-
System header sys/param.h is included inside the Thrift namespace
[
https://issues.apache.org/jira/browse/THRIFT-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815259#comment-13815259
]
Ben Craig commented on THRIFT-2252:
---
On the C++ side, if we were to implement this,
[
https://issues.apache.org/jira/browse/THRIFT-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814040#comment-13814040
]
Ben Craig commented on THRIFT-2252:
---
This could be done, but it would need to be
[
https://issues.apache.org/jira/browse/THRIFT-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2214.
---
Resolution: Fixed
Fix Version/s: 0.9.2
Committed.
Thanks Vladmir!
System header
[
https://issues.apache.org/jira/browse/THRIFT-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812506#comment-13812506
]
Ben Craig commented on THRIFT-2243:
---
I am confused about the client side. The code you
[
https://issues.apache.org/jira/browse/THRIFT-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2245:
-
Assignee: Ben Craig
Allow Custom Prefix in Include Guards
[
https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808673#comment-13808673
]
Ben Craig commented on THRIFT-579:
--
I have made a first stab at the code review. After
[
https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806787#comment-13806787
]
Ben Craig commented on THRIFT-2242:
---
It's probably going to be a while before we get to
[
https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806957#comment-13806957
]
Ben Craig commented on THRIFT-2242:
---
As of 10/28/2013 (today), GCC's C++11 support is
[
https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807101#comment-13807101
]
Ben Craig commented on THRIFT-2242:
---
If we were to make changes that broke source
[
https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806513#comment-13806513
]
Ben Craig commented on THRIFT-579:
--
I have set up a review at
[
https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2229:
-
Assignee: Ben Craig
thrift failed to build on OSX 10.9 GM
[
https://issues.apache.org/jira/browse/THRIFT-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2140:
-
Assignee: Ben Craig
Error compiling cpp tutorials
-
[
https://issues.apache.org/jira/browse/THRIFT-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798322#comment-13798322
]
Ben Craig commented on THRIFT-2230:
---
If you're willing to create a patch to require a
[
https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797110#comment-13797110
]
Ben Craig commented on THRIFT-2229:
---
I believe this is fixed already in master. Some
[
https://issues.apache.org/jira/browse/THRIFT-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797207#comment-13797207
]
Ben Craig commented on THRIFT-2229:
---
Not 100% sure on this, but probably by changing
[
https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2026.
---
Resolution: Fixed
Fix Version/s: (was: 1.0)
0.9.2
Fix
[
https://issues.apache.org/jira/browse/THRIFT-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2034.
---
Resolution: Fixed
Fix Version/s: (was: 1.0)
0.9.2
Give developers'
[
https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2028:
--
Attachment: thread_cleanup.patch
Updated / rebased.
Cleanup threading headers / libraries
[
https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2028:
--
Attachment: (was: thread_cleanup.patch)
Cleanup threading headers / libraries
[
https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793714#comment-13793714
]
Ben Craig commented on THRIFT-579:
--
I will look at this for this release. It will
[
https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-579:
Assignee: Ben Craig
Alternative ASIO based fully async client/server for C++
[
https://issues.apache.org/jira/browse/THRIFT-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13792585#comment-13792585
]
Ben Craig commented on THRIFT-2226:
---
hmm, I used to get that particular warning. I
[
https://issues.apache.org/jira/browse/THRIFT-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2226.
---
Resolution: Fixed
Fix Version/s: 0.9.2
Assignee: Ben Craig
Commited
TServerSocket
[
https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2045.
-
C++ compiler warning and build cleanup
--
Key:
[
https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-1750.
-
Make compiler build cleanly under visual studio 10
--
[
https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-1750.
---
Resolution: Fixed
Fix Version/s: (was: 1.0)
0.9.2
Make compiler
[
https://issues.apache.org/jira/browse/THRIFT-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2226.
-
TServerSocket - keepAlive wrong initialization order
[
https://issues.apache.org/jira/browse/THRIFT-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-1892.
---
Resolution: Fixed
Fix Version/s: 0.9.2
Socket timeouts are declared in milli-seconds, but
[
https://issues.apache.org/jira/browse/THRIFT-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-1892.
-
Socket timeouts are declared in milli-seconds, but are actually set in
micro-seconds
[
https://issues.apache.org/jira/browse/THRIFT-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-1712:
-
Assignee: Ben Craig
Add TBase class for c++
---
Key:
[
https://issues.apache.org/jira/browse/THRIFT-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2214:
-
Assignee: Ben Craig
System header sys/param.h is included inside the Thrift namespace
[
https://issues.apache.org/jira/browse/THRIFT-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2224:
-
Assignee: Ben Craig
TSSLSocket.h and TSSLServerSocket.h should use the platfromsocket too
[
https://issues.apache.org/jira/browse/THRIFT-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-1819:
-
Assignee: Ben Craig
Thrift has many unused #includes
[
https://issues.apache.org/jira/browse/THRIFT-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-2216:
-
Assignee: Ben Craig (was: Andrew McGeachie)
Extraneous semicolon in TProtocolUtil.h makes
[
https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2031:
--
Attachment: (was: keep_alive2.patch)
Make SO_KEEPALIVE configurable for C++ lib
[
https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2031:
--
Attachment: keep_alive3.patch
Not real sure what I was thinking with that. I want to say I copy /
[
https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2027:
--
Attachment: (was: misc_minor.patch)
Minor 64-bit and NOMINMAX issues in C++ library
[
https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2027:
--
Attachment: misc_minor.patch
It's 2013, and the world is still dealing with EOL conflicts.
Old patch
[
https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2045:
--
Attachment: windows_compiler_port.patch
Once more... with feeling.
Using config.h and guarding it
[
https://issues.apache.org/jira/browse/THRIFT-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2019.
---
Resolution: Fixed
Writing on a disconnected socket on Mac causes SIG PIPE
[
https://issues.apache.org/jira/browse/THRIFT-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2019.
-
Writing on a disconnected socket on Mac causes SIG PIPE
[
https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2027.
-
Minor 64-bit and NOMINMAX issues in C++ library
---
[
https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-1751.
---
Resolution: Fixed
definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is
not
[
https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2031.
---
Resolution: Fixed
Make SO_KEEPALIVE configurable for C++ lib
[
https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-1751.
-
definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is
not defined
[
https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2031.
-
Make SO_KEEPALIVE configurable for C++ lib
--
[
https://issues.apache.org/jira/browse/THRIFT-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2021.
-
Improve large binary protocol string performance
[
https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2027.
---
Resolution: Fixed
Minor 64-bit and NOMINMAX issues in C++ library
[
https://issues.apache.org/jira/browse/THRIFT-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2021.
---
Resolution: Fixed
Improve large binary protocol string performance
[
https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789723#comment-13789723
]
Ben Craig commented on THRIFT-1751:
---
I can do that. In either case, you will get an
[
https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789733#comment-13789733
]
Ben Craig commented on THRIFT-1750:
---
Ack! In my June 2013 mega patch upload, this
[
https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789745#comment-13789745
]
Ben Craig commented on THRIFT-1750:
---
As soon as 2045 is wrapped up, I'll close it as
[
https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2045.
---
Resolution: Fixed
Changed MINGW - _WIN32 in the go generator and submitted (after a rebuild)
C++
[
https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-1751:
--
Attachment: (was: TServer_guard.patch)
definition of increase_max_fds doesn't compile when
[
https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-1751:
--
Attachment: TServer_guard2.patch
Updated from svn patch, and now guarding the prototype
definition
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788127#comment-13788127
]
Ben Craig commented on THRIFT-2221:
---
This probably isn't happening for a while. See
[
https://issues.apache.org/jira/browse/THRIFT-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788128#comment-13788128
]
Ben Craig commented on THRIFT-1682:
---
C++ client objects are not intended to be thread
[
https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2045:
--
Attachment: (was: windows_compiler_port.patch)
C++ compiler warning and build cleanup
[
https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2045:
--
Attachment: windows_compiler_port.patch
updating from June, due to addition of cassert header.
C++
[
https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2031:
--
Attachment: keep_alive2.patch
Updates to switch from -1 to macro
Make SO_KEEPALIVE configurable for
[
https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2031:
--
Attachment: (was: keep_alive2.patch)
Make SO_KEEPALIVE configurable for C++ lib
[
https://issues.apache.org/jira/browse/THRIFT-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788536#comment-13788536
]
Ben Craig commented on THRIFT-2034:
---
Processor events need to work for all transports,
[
https://issues.apache.org/jira/browse/THRIFT-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2139.
---
Resolution: Fixed
Fix Version/s: 0.9.2
Committed. Thanks Alex!
Minor issue for future
[
https://issues.apache.org/jira/browse/THRIFT-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774545#comment-13774545
]
Ben Craig commented on THRIFT-2200:
---
I have not tested the patch and I don't use
[
https://issues.apache.org/jira/browse/THRIFT-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774735#comment-13774735
]
Ben Craig commented on THRIFT-2139:
---
The patch looks reasonable, but I haven't had a
101 - 200 of 377 matches
Mail list logo