RE: add isNull to org.umlg.sqlg.structure.Property

Hi, Since TinkerPop added `supportsNullPropertyValues` users need to call `property.isPresent() && property.value() != null` to do a null check. I propse adding a `isNull` to the Property interface to reduce the typing required. Regards Pieter

Re: Async capabilities to TinkerPop

the existing frameworks for async > functionality, then it will be much easier to add async queries > execution in TinkerPop instead of developing it from scratch and > managing our own event loop. > > Best regards, > Oleksandr > > > On Fri, Jul 29, 2022 at 4:27

Re: Async capabilities to TinkerPop

gt; > > won't solve the > > > > >> problem most likely. > > > > >> > > > > >> I guess it will require re-writing or extending all steps to > > > > be able to > > > > >> pass an async state instead of a sync state. > &

Re: Async capabilities to TinkerPop

t making some concrete decisions regarding TinkerPop 4. > > >> > > >> I see Marko A. Rodriguez started to work on RxJava back in 2019 > > here > > >> > > https://github.com/apache/tinkerpop/tree/4.0-dev/java/machine/processor/rxjava/src/main/java/org/apache

Re: Async capabilities to TinkerPop

Hi, Does this not imply a massive rewrite of TinkerPop? In particular the iterator chaining pattern of steps should follow a reactive style of coding? Cheers Pieter On Thu, 2022-07-28 at 15:18 +0100, Oleksandr Porunov wrote: > I'm interested in adding async capabilities to TinkerPop. > >

Re: A meta model for gremlin's property graph

> > > > > +1 > >   > > Here goes my understanding of what we are trying to achieve. > > > > 1: A property graph meta model. To describe exactly what kind of > > data structure the gremlin language operates on. > > > > > +1 >

Re: A meta model for gremlin's property graph

guage. As an aside, breaking user space should not even be considered. i.e. 99% backward compatibility should be guaranteed at all times. Thanks Pieter On Tue, 2022-01-11 at 10:47 -0800, Joshua Shinavier wrote: > Hey Pieter, > > Good to see some more motion on this front. Responses inline.

Re: A meta model for gremlin's property graph

;weight", "type", GremlinDataType.INTEGER.name()); knows.addEdge("properties", knowsWeightVertexProperty); Vertex created = modernModelGraph.addVertex(T.label, "EdgeLabel", "label", "created"); Vertex createdWeightVertexProperty = modern

A meta model for gremlin's property graph

Hi, I have done some work on defining a meta model for Gremlin's property graph. I am using the approach used in the modelling world, in particular as done by the OMG group when defining their various meta models and specifications. However where OMG uses a subset of the UML to define their meta

Re: [DISCUSS] Geo-Spatial support

Hi, I'd suggest having a look at Postgis (https://postgis.net/) for some inspiration. Its mature and rather sophisticated with a small army of functions. They have two types, 'geometry' for standard projection functions and 'geography' for 3D spherical maths functions. Postgis also has a JDBC

Re: code generation and RDF support in TinkerPop 4

ter On Thu, 2021-06-03 at 09:59 -0700, Joshua Shinavier wrote: > Hi Pieter, > > > On Thu, Jun 3, 2021 at 9:40 AM pieter gmail > wrote: > > Hi, > > > > Just to understand a bit better whats going on. > > > > Did you hand write the dragon yaml with

Re: code generation and RDF support in TinkerPop 4

Hi, Just to understand a bit better whats going on. Did you hand write the dragon yaml with the antlr grammar as input? Did you generate the java classes from the yaml using dragon or something else? Thanks Pieter On Thu, 2021-06-03 at 07:48 -0700, Joshua Shinavier wrote: > Hello all, > > I

Re: [DISCUSS] ANTLR and gremlin-script

gt; > > for > > > > > it. I've long wanted to unify our test framework (i.e. > > > > > deprecate the > > > JVM > > > > > process suite in favor of the GLV test suite). I was > > > > > experimenting > > > with > > > >

Re: [DISCUSS] Adding motif support to match()

+1 Cheers Pieter On Thu, 2021-02-04 at 17:15 -0800, Joshua Shinavier wrote: > Initial thought: if the ASCII art syntax is Cypher-like, why not make > it > openCypher proper? I.e. keep match() as it is, but generalize the > cypher() > step out of Neo4jGraph, with native Neo4j evaluation of Cypher

Re: [DISCUSS] ANTLR and gremlin-script

+1  I have often thought the language specification should be a project separate from the implementations, and done in a formal but plain English format similar to OMG or IETF specifications.  I suspect Sqlg's code base would have been fastly different if it had evolved from a grammer instead of

Re: Apply for Index Listing

Just had a look at HugeGraph but can't find any English documentation? CheersPieter On Wed, 2020-10-28 at 10:44 -0400, Stephen Mallette wrote: > I'm fine with adding this now +1 - any else have concerns? > > The project must have a high-resolution logo that can be used by > > Apache > TinkerPop. >

Re: [DISCUSS] Review Process

Hi, I feel like the project has become a bit too big and dispersed. A large portion of the emails, jira or otherwise are irrelevant to my interest/time/work. Perhaps for version 4, TinkerPop could be broken up into more focused projects with their own jira/email/process management.

Re: CustomId serialization

t CLASS to determine the deserializer to use and then hands your deserializer the contents of the rest of the JSON (which is all the deserializers needs once the right one is chosen). On Mon, Jun 25, 2018 at 8:08 AM pieter gmail wrote: Hi, Just manage to get it to work, but not really sure whats

Re: CustomId serialization

g test in TinkerPop to include a deserializer and see if you get a similar error for your efforts? Perhaps that would help yield a clue? On Mon, Jun 25, 2018 at 2:58 AM pieter gmail wrote: Hi, I am trying to upgrade Sqlg to 3.3.3 from 3.3.1. The only tests that are failing are the io tests for gr

RE: CustomId serialization

Hi, I am trying to upgrade Sqlg to 3.3.3 from 3.3.1. The only tests that are failing are the io tests for graphson V1. I see CustomId has a CustomIdJacksonSerializerV1d0 but not a deserializer. Looks like Jackson is using reflection to instantiate the CustomId and set its cluster and

Re: [DISCUSS] Depth First Repeat step

ith Lohnes <lohn...@gmail.com> wrote: Yeah, that's what I meant. The steps inside are replaced with some JanusGraph stuff. Cheers, Keith On Tue, Apr 24, 2018 at 1:52 PM pieter gmail <pieter.mar...@gmail.com> wrote: Nah, that looks to me like the RepeatStep survived. Just the nest

Re: [DISCUSS] Depth First Repeat step

ar").repeat(out()).emit().explain()` yields `[JanusGraphStep([],[foo.eq(bar)]), RepeatStep([JanusGraphVertexStep(OUT,vertex), RepeatEndStep],until(false),emit(true))]` On Tue, Apr 24, 2018 at 12:12 PM pieter gmail <pieter.mar...@gmail.com> wrote: Hi, Sqlg completely replaces TinkerPop's

Re: [DISCUSS] Depth First Repeat step

not terribly familiar with Sqlg, but I wonder if in the context of how DFS is implemented there, it may be less of a concern. Cheers, Keith On Thu, Apr 19, 2018 at 12:46 PM pieter gmail <pieter.mar...@gmail.com> wrote: Hi, Not really sure either what 'global' means technically with r

Re: [DISCUSS] Depth First Repeat step

.addEdge("e", v3) g = graph.traversal() g.V(v0).out().sideEffect{println(it)}.out().sideEffect{println(it)} ``` Prints: v[2] v[1] v[4] ==>v[4] v[3] ==>v[3] If this was OLTP the output would be: v[2] v[4] ==>v[4] v[1] v[3] ==>v[3] Cheers Michael On 18/04/18 02:58, pieter

Re: [DISCUSS] Depth First Repeat step

he docs say. And yes, it's easy to verify the default in the test suite, once we agreed on what the default should be. Cheers Michael On 17/04/18 04:40, pieter gmail wrote: Hi, I have not properly followed the previous thread. However I thought is going to be a way to set the default beh

Re: [DISCUSS] Depth First Repeat step

Hi, I have not properly followed the previous thread. However I thought is going to be a way to set the default behavior as apposed to needing to use barrier() Is this the case or not? For Sqlg at least it is possible to optimize BFS much more effectively than DFS so it will be nice to have

RE: GremlinPlugin

Hi, I am updating Sqlg's gremlin-console support. I have been upgrading Sqlg without testing the console and did not realize the changes that has been made there. So I got it to work again but am not quite sure about the ImportCustomizer. Previously there was no need to individually specify

Re: [VOTE] TinkerPop 3.3.1 Release

Hi, Tested Sqlg on 3.3.1. Custom, structured and process tests all pass. VOTE +1 Cheers Pieter On 17/12/2017 18:54, Stephen Mallette wrote: Hello, We are happy to announce that TinkerPop 3.3.1 is ready for release. The release artifacts can be found at this location:

Re: [DISCUSS] 3.3.1/3.2.7 December Release

Hi, Can you deploy 3.3.1-SNAPSHOT to the maven repository? The last entry https://repository.apache.org/content/groups/snapshots/org/apache/tinkerpop/gremlin-core/3.3.1-SNAPSHOT/ seems to be 2017/10/26 Thanks Pieter On 30/11/2017 14:52, Stephen Mallette wrote: I'd like to propose that we

Re: dropStep and BarrierStep

Hi, Any ideas about this one? Thanks Pieter On 22/11/2017 19:49, pieter gmail wrote: Hi, Whilst optimizing the DropStep in Sqlg I came across RepeatStep plus DropStep in a traversal going into a infinite loop. To test Sqlg I tested on TinkerPop's ComplexTest.playlistPath() changing

RE: dropStep and BarrierStep

Hi, Whilst optimizing the DropStep in Sqlg I came across RepeatStep plus DropStep in a traversal going into a infinite loop. To test Sqlg I tested on TinkerPop's ComplexTest.playlistPath() changing the gremlin to have a drop()     @Test     public void testDropPlaylist() {     final

Re: CountStrategy and TraversalHelper.replaceStep

i = stepIndex(removeStep, traversal));traversal.addStep(i, insertStep);} Cheers, Daniel On Mon, Oct 30, 2017 at 7:43 AM, pieter gmail <pieter.mar...@gmail.com> wrote: I am on the latest 3.3.1-SNAPSHOT, just pulled master again. The actual traversals and results are correct. H

Re: CountStrategy and TraversalHelper.replaceStep

0, 2017 at 7:43 AM, pieter gmail <pieter.mar...@gmail.com> wrote: I am on the latest 3.3.1-SNAPSHOT, just pulled master again. The actual traversals and results are correct. However after the CountStrategy the VertexStep(OUT,edge) previousStep pointer (AbstractStep.previousStep) is incorrec

Re: CountStrategy and TraversalHelper.replaceStep

until(outE().count().is(0)).values('name').iterate().toString() ==>[TinkerGraphStep(vertex,[1]), RepeatStep([VertexStep(OUT,vertex), RepeatEndStep],until([NotStep([VertexStep(OUT,edge)])]),emit(false)), PropertiesStep([name],value)] Cheers, Daniel On Mon, Oct 30, 2017 at 1:53 AM

CountStrategy and TraversalHelper.replaceStep

Hi, Whilst optimizing the NotStep I came across what looks to me like a bug in TraversalHelper.replaceStep or perhaps rather in CountStrategy. The test below shows the bug.     @Test     public void g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name() {     Graph graph =

Re: [jira] [Created] (TINKERPOP-1812) ProfileTest assumes that graph implementations will not add their own steps

In Sqlg many profile tests are ignored because of this. Including steps being removed. Back in the day no-one including myself had any interest in fixing it. Its not trivial by all accounts. Cheers Pieter On 26/10/2017 13:21, Bryn Cooke (JIRA) wrote: Bryn Cooke created TINKERPOP-1812:

Re: remove step

, pieter gmail <pieter.mar...@gmail.com> wrote: Hi, I was wondering if we can add a remove step. Currently to remove elements I iterate the traversal and call remove on each element. Adding a remove step will make it possible to optimize removals. Its probably less useful for Neo4j and Tinke

remove step

Hi, I was wondering if we can add a remove step. Currently to remove elements I iterate the traversal and call remove on each element. Adding a remove step will make it possible to optimize removals. Its probably less useful for Neo4j and TinkerGraph, not sure about Janus but for Sqlg,

Re: Sqlg's description

Thanks, Pieter On 25/10/2017 14:26, Stephen Mallette wrote: As there were no objections to making the change, I went ahead and published - it may take a few minutes for the changes to propogate. Thanks On Sun, Oct 22, 2017 at 12:35 PM, pieter gmail <pieter.mar...@gmail.com> wrote: Hi,

Sqlg's description

Hi, Can I request Sqlg's description on the homepage to be changed. Sqlg now supports more back-ends and changes are that it will support non RDBMS but SQL databases in the future. Can we change it to "OLTP implementation on SQL databases." Thanks Pieter

Re: Notes on TraverserSet and Sqlg optimizations

't get a speedup in sqlg though when bullking would be enacted though - only when bulking would have no effect - correct? On Fri, Oct 13, 2017 at 3:48 PM, pieter gmail <pieter.mar...@gmail.com> wrote: Hi, Doing step optimizations I am noticing a rather severe performance hit in TraverserSet

Re: Notes on TraverserSet and Sqlg optimizations

when bulking would have no effect - correct? On Fri, Oct 13, 2017 at 3:48 PM, pieter gmail <pieter.mar...@gmail.com> wrote: Hi, Doing step optimizations I am noticing a rather severe performance hit in TraverserSet. Sqlg does a secondary optimization on steps that it can not optimiz

Notes on TraverserSet and Sqlg optimizations

Hi, Doing step optimizations I am noticing a rather severe performance hit in TraverserSet. Sqlg does a secondary optimization on steps that it can not optimize from the GraphStep. Before the secondary optimization these steps will execute at least one query for each incoming start. The

Re: io and graphson-v3

similar to get the right registry in play? could you have a look and see if what i did helps? if that works then i'll issue a PR and we can get it reviewed/merged. On Tue, Sep 5, 2017 at 12:10 PM, pieter gmail <pieter.mar...@gmail.com> wrote: Ok, at present there is only one Simple

Re: io and graphson-v3

it reviewed/merged. On Tue, Sep 5, 2017 at 12:10 PM, pieter gmail <pieter.mar...@gmail.com> wrote: Ok, at present there is only one SimpleModule, the default. I can make it v2 or v3 but not both. Lets say I make the SimpleModule support V2. Then when calling IoEdgeTest for {"

Re: io and graphson-v3

ter On 05/09/2017 17:31, Stephen Mallette wrote: I guess I'm trying to understand why it matters for purpose of the test. If you mix/match versions I can't think of why the test would care one way or the other. does sqlg serialize its id to a JSON Map? On Tue, Sep 5, 2017 at 11:19 A

Re: io and graphson-v3

probably need a better system than this. IO is way too complicated and confusing. On Tue, Sep 5, 2017 at 9:52 AM, pieter gmail <pieter.mar...@gmail.com> wrote: Afraid I still don't quite get it. How do I register the different SimpleModules depending on the version. Currently it starts in Sql

Re: io and graphson-v3

ame SqlgSimpleModule. It's a naming convention that users will have to follow rather than something explicitly enforced through code. On Sun, Sep 3, 2017 at 3:20 PM, pieter gmail <pieter.mar...@gmail.com> wrote: Hi, I am getting IO tests failures on 3.3.0. Sqlg has a SimpleModule which add serializer

RE: io and graphson-v3

Hi, I am getting IO tests failures on 3.3.0. Sqlg has a SimpleModule which add serializers for its custom id.     SqlgSimpleModule() {     super("custom"); //    addSerializer(RecordId.class, new RecordId.RecordIdJacksonSerializerV2d0()); //    addDeserializer(RecordId.class, new

Re: [VOTE] TinkerPop 3.3.0 Release

Afraid I won't get time to refactor Sqlg's ChooseStep/OptionalStep optimizations to deal with the new OptionalStep  before the vote expires. So all tests are not passing but its a Sqlg problem. Apart from that all seems well. VOTE +1 Cheers Pieter On 24/08/2017 16:44, Stephen Mallette

Re: [VOTE] TinkerPop 3.2.6 Release

Ran Sqlg's own test suite and TinkerPop's structured and process test suites on Sqlg. All passes. VOTE +1 Cheers Pieter On 22/08/2017 20:29, Robert Dale wrote: VOTE +1 Robert Dale On Tue, Aug 22, 2017 at 10:33 AM, Daniel Kuppitz wrote: *Validating binary

Re: [VOTE] TinkerPop 3.2.5 Release

VOTE +1 Cheers Pieter On 15/06/2017 22:33, Stephen Mallette wrote: Hello (again), We are happy to announce (again) that TinkerPop 3.2.5 is ready for release. The release artifacts can be found at this location: https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.5/ The source

RE: gremlin-test and h2 database

Hi, I just noticed for the first time that gremlin-test has a dependency on h2 database. com.h2database h2 1.3.171 Where is it being used? Thanks Pieter

Re: [VOTE] TinkerPop 3.2.5 Release

Ran all Sqlg's custom tests and the structure and process test suites. All tests pass. VOTE +1 On 14/06/2017 03:36, David Brown wrote: Ran ./validate-distribution.sh 3.2.5 - all ok Installed gremlin-python 3.2.5 from source as aiogremlin dependency - successful Tested aiogremlin against

Re: TraversalHelper.anyStepRecursively bug

thTest that demonstrates the failure? Marko. On Jun 13, 2017, at 10:34 AM, pieter gmail <pieter.mar...@gmail.com> wrote: Hi, With 3.2.5 CyclicPathStep and SimplePathStep has been replaced with PathFilterStep. This is fine but whilst doing the refactor I noticed what appears

TraversalHelper.anyStepRecursively bug

Hi, With 3.2.5 CyclicPathStep and SimplePathStep has been replaced with PathFilterStep. This is fine but whilst doing the refactor I noticed what appears to be a bug in TraversalHelper.anyStepRecursively public static boolean anyStepRecursively(final Predicate predicate, final

RE: mutation visibility semantics

Hi, Testing Sqlg on 3.2.5 I am getting failures EventStrategyProcessTest.shouldDetachVertexPropertyWhenRemoved final GraphTraversalSource gts = create(eventStrategy); gts.V(v).properties("to-remove").drop().iterate(); tryCommit(graph); assertEquals(1,

RE: hasId

Hi, The following code illustrates my concern/confusion. @Test public void testHasId() { final TinkerGraph graph = TinkerGraph.open(); Vertex a = graph.addVertex(T.label, "A"); Vertex b = graph.addVertex(T.label, "B"); List vertices =

Re: [VOTE] TinkerPop 3.2.4 Release

lt;twil...@gmail.com> wrote: >>> >>>> Release and docs looks good to me. >>>> >>>> Validating source distribution >>>> >>>> * downloading Apache TinkerPop 3.2.4 (apache-tinkerpop-3.2.4-src. >> zip)... >>>>

Re: failing optional and order by gremlin

e wouldn't be a > single "ab" edge. If you want to take this into account, do: > > g.traversal().V(a1.id()).optional( > outE("ab").as("e").inV().optional( > outE("bc").as("e").inV())). > order().by(coalesce(select(first, &q

RE: failing optional and order by gremlin

Hi, The following query no longer works on 3.2.4 @Test public void testOptionalWithOrderBy() { final TinkerGraph g = TinkerGraph.open(); Vertex a1 = g.addVertex(T.label, "A", "name", "a1"); Vertex b1 = g.addVertex(T.label, "B", "name", "b1"); Vertex b2 =

Re: [VOTE] TinkerPop 3.2.4 Release

went in after >>> 2/2 that I can think of that would have any bearing for graph providers who >>> tested before/after that date would be the AutoCloseable stuff: >>> >>> https://github.com/apache/tinkerpop/pull/548 >>> >>> Your problems aren't rel

Re: [VOTE] TinkerPop 3.2.4 Release

at are they? Can you provide some > synopsis of where the problems lie? > > > > On Thu, Feb 9, 2017 at 2:47 PM, pieter-gmail <pieter.mar...@gmail.com> > wrote: > >> Hi, >> >> Some issues regarding the release process. >> >> On the 2/2/201

RE: static code in TinkerPop

Hi, I have recently found a bug in Sqlg related to the static nature of strategies. In particular it is happening for me on the PathRetractionStep but it probably a general issue. Sqlg supports running many graphs in one JVM. The staticness confuses the state of the strategies when they

Re: [VOTE] TinkerPop 3.2.4 Release

Hi, Some issues regarding the release process. On the 2/2/2017 the 3.2.4-SNAPSHOT was released. I then started testing and found almost no issues. However yesterday when the VOTE mail came I found many issues on 3.2.4. To understand the confusion I tested again on 3.2.4-SNAPSHOT and found the

Re: lazy iteration semantics

Ping! Any ideas on this. Thanks Pieter On 23/01/2017 19:00, pieter-gmail wrote: > Hi, > > Ran some more tests, seems all is not well. > > So the previous example always works (on TinkerPop and Neo4j) because > bothE is not seen as two queries but rather one and all is well. &g

Re: lazy iteration semantics

Does it make sense? Any ideas? Cheers Pieter On 23/01/2017 19:00, pieter-gmail wrote: > Hi, > > Ran some more tests, seems all is not well. > > So the previous example always works (on TinkerPop and Neo4j) because > bothE is not seen as two queries but rather one and all is

Re: lazy iteration semantics

iel > > > On Sat, Jan 21, 2017 at 7:30 PM, pieter-gmail <pieter.mar...@gmail.com> > wrote: > >> Hi, >> >> I need to clarify the expected semantics of gremlin's lazy iteration >> semantics. >> The following gremlin is what highlighted it. >>

RE: lazy iteration semantics

Hi, I need to clarify the expected semantics of gremlin's lazy iteration semantics. The following gremlin is what highlighted it. ``` @Test public void testLazy() { final TinkerGraph graph = TinkerGraph.open(); final Vertex a1 = graph.addVertex(T.label, "A");

Re: [TinkerPop] gremlin-x

er a layered approach where > gremlin is a simple query language of which an object-graph mapper, in > any domain model, could be built on top (like so many other query > languages). > > So I guess we'll just have to agree to disagree. > > > Robert Dale > > On Fri, De

Re: [TinkerPop] gremlin-x

that under this model and get it documented. > > On Fri, Dec 2, 2016 at 6:49 AM, pieter-gmail <pieter.mar...@gmail.com > <mailto:pieter.mar...@gmail.com>> wrote: > > Hi, > > Perhaps this is also the time to think about custom steps and some way >

Re: [TinkerPop] gremlin-x

ql/nosql datastores. > > So it's not just about becoming more like jdbc but more about a > low-level paradigm. To that I agree with you on one thing, the first > thing you should do is create a 'baby hibernate' because I don't think > gremlin should be an ORM (OGM?). > > >

Re: [TinkerPop] gremlin-x

Element.detachment() -> Detach enum > > > This way, users can always know what is available to them. Finally for > cleanliness: > > Element.detach(Detach) -> Element > Element.attach(Graph) -> Element (always a Detach.full element) > > >

Re: [TinkerPop] gremlin-x

Hi, "So with ReferenceElements, latency will be less too because it takes less time to construct the ReferenceVertex than it does to construct a DetachedVertex. Imagine a vertex with 100 properties and meta properties. ?!" But ReferencedElement does not have the properties so more round trips

Re: [TinkerPop] gremlin-x

cript. I think the >> ScriptEngine stuff should really just be used for those situations >> where you need a lambda. That's a nice, simple, easy-to-explain rule, >> whereas "do it if there is complex logic" is a bit more subjective >> (and potentially troublesome).

Re: [DISCUSS] Graph.addVertex(Map)

Hi, I saw this http://iteratrlearning.com/java9/2016/11/09/java9-collection-factory-methods Creating maps will become easier (less typing) in java 9. Cheers Pieter On 20/09/2016 18:49, Stephen Mallette wrote: > Anyone interested in seeing a Graph.addVertex(Map) overload? > >

Re: [jira] [Updated] (TINKERPOP-1541) Select should default to Pop.last semantics

I'd say no, if you wanted it once you would have selected it once no? in sql `select a.name, a.name from Person a` will return name twice because that's what you asked for. 5 cents Pieter On 08/11/2016 14:02, Marko A. Rodriguez (JIRA) wrote: > [ >

Re: [jira] [Commented] (TINKERPOP-1372) ImmutablePath should not use Java recursion (call stacks are wack)

Perused the code. Looks good. I noticed there is a travis failure on GroupCountTest however the same test passes on my machine on branch TINKERPOP-1372. VOTE +1 On 01/11/2016 16:41, ASF GitHub Bot (JIRA) wrote: > [ >

Re: path query optimization

ko. > > http://markorodriguez.com > > > >> On Nov 1, 2016, at 7:19 AM, pieter-gmail <pieter.mar...@gmail.com> wrote: >> >> Hi, >> >> Yes I am but afraid I do not have time at present to concentrate on it. >> I just noticed your ImmutablePath

Re: path query optimization

careful during code review and unit >>>>> testing because those bugs can be difficult to track down. The other nice >>>>> thing that the defensive copy gets us, particularly in the case of the >>>>> ImmutablePath, is that it isolates ImmutablePath from whatever the >

Re: PathRetractionStrategy and TraverserRequirement.PATH

ractionStrategy, then you know that > Sqlg is bugged. > > HTH, > Marko. > > http://markorodriguez.com > > > >> On Oct 24, 2016, at 2:21 PM, pieter-gmail <pieter.mar...@gmail.com> wrote: >> >> Ok apologies. I thought I spotted the difference and simpli

Re: PathRetractionStrategy and TraverserRequirement.PATH

qlg for the respective test > traversal? > > (I suspect the test is bad because group() pushes traversers through with > bulks and all so the test might just add to a collection without adding > respecting bulks. Probably should change that test regardless to do like a >

Re: [jira] [Commented] (TINKERPOP-1506) Optional/Coalesce should not allow sideEffect traversals.

Hi, `coalesce` was discussed way back when `optional` was first discussed. @Daniel's comment seems to show that `coalesce` was not what we wanted. @Marko's comment indicated "Ah smart. The reason choose works and coalesce doesn't is because one uses globalTraversals and the other uses

Re: [VOTE] TinkerPop 3.2.3 Release

All tests passes except for one but its a Sqlg bug. Vote +1 On 17/10/2016 23:21, Stephen Mallette wrote: > Hello, > > We are happy to announce that TinkerPop 3.2.3 is ready for release. > > The release artifacts can be found at this location: >

Re: [DISCUSS] Graph.addVertex(Map)

Perhaps to add some strength to my argument I can give some indication of our current graph's shape however. Currently we have about 14 000 tables and about 220 000 columns in the rdbms and it grows runtime as we support more and more vendors and technologies. This is in the telco space. 100% of

Re: Code Freeze 3.2.3/3.1.5

I just upgraded and things are looking good. Cheers Pieter On 14/10/2016 20:50, Stephen Mallette wrote: > It's been fairly quiet on this thread for this release for some reason. I > assume that can only mean that this is to be the best release ever! > > I just published the latest

Re: path query optimization

; this.currentLabels = currentLabels; //this.currentLabels.addAll(currentLabels); } Setting the collection directly as oppose to `addAll` Thanks Pieter On 05/08/2016 20:40, pieter-gmail wrote: > Hi, > > I have been optimizing Sqlg of late and eventually arrived at TinkerP

RE: path query optimization

Hi, I have been optimizing Sqlg of late and eventually arrived at TinkerPop code. The gremlin in particular that I am interested is path queries. Here is the test that I am running in jmh. //@Setup Vertex a = graph.addVertex(T.label, "A", "name", "a1"); for (int i = 1;

Re: [DISCUSS] interrupt

"It's not clear to me if the problem exists in HSQLDB, the test, or tail step" This had nothing to do with the TailStep bug. That one is resolved for the most part. For the rest, where the problem is, is itself part of the problem. Thread.interrupt() has rather weak semantics having many

Re: [DISCUSS] interrupt

all the ScriptEngine work I had in mind done until 3.3.x as > it must include some breaking changes to some public APIs to happen. > > > > > > On Thu, Jul 21, 2016 at 4:01 PM, pieter-gmail <pieter.mar...@gmail.com> > wrote: > >> Well no, the problem is Thread.inter

Re: [DISCUSS] interrupt

tter job with AbstractStep, please create a JIRA > (and/or submit a PR) so we don't forget to make some improvements there. > > On Thu, Jul 21, 2016 at 12:37 PM, pieter-gmail <pieter.mar...@gmail.com> > wrote: > >> I just did a global Intellij search in the Sqlg project. >>

Re: [DISCUSS] interrupt

remlin Server doesn't > have access to the Traversal to call interrupt on it. "t" is iterating via > toList() and there is no way to stop it. Not sure what we could do about > situations like that. > > On Wed, Jul 20, 2016 at 4:00 PM, pieter-gmail <pieter.mar...@g

[DISCUSS] interrupt

The current interrupt implementation is failing on Sqlg's HSQLDB implementation. The reason for this is that HSQLDB itself relies on Thread.interrupt() for its own internal logic. When TinkerPop interrupts the thread it thinks it has to do with its own logic and as a result the interrupt flag is

Re: [VOTE] TinkerPop 3.2.1 Release

Hi, Ran all Sqlg's tests and the process and structured test suites. But alas there are failures. TraversalInterruptionTest are failing on HSQLDB as the Thread.interrupt() is intercepted by them and the interrupt flag is reset. The TraversalInterruptionTest tests themselves suffers from this as

Re: RepeatStep

removed) throwing a FastNoSuchElementException and thus returning no elements. However I think we first need to understand what the expected semantics of a before times(0) is. I have a feeling that my previous passing tests were just getting lucky? Thanks Pieter On 16/07/2016 18:37, pieter-gmail

Re: RepeatStep

Hi, I am running the following tests on 3.2.1-SNAPSHOT @Test public void testRepeat() { final TinkerGraph g = TinkerGraph.open(); Vertex a1 = g.addVertex(T.label, "A", "name", "a1"); Vertex b1 = g.addVertex(T.label, "B", "name", "b1"); Vertex b2 =