[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132322898 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -239,14 +359,8 @@ protected void doStop() throws

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132322316 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -239,14 +359,8 @@ protected void doStop() throws

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132322087 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -181,19 +190,130 @@ public Reader getInput()

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132298929 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -193,7 +200,91 @@ private EventHandler

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132298585 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -193,7 +200,91 @@ private EventHandler

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132297954 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -401,6 +409,24 @@ void stopAll() { // When we

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132297305 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -193,7 +200,91 @@ private EventHandler

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132296875 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -193,7 +200,91 @@ private EventHandler

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132296480 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -193,7 +200,91 @@ private EventHandler

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132296198 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -193,7 +200,91 @@ private EventHandler

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132295847 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -181,7 +189,6 @@ public Reader getInput() throws

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132037568 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -221,7 +229,8 @@ protected void doStart() throws

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132038521 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -267,6 +280,14 @@ void stopByIdAndWait(String

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132038164 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -173,6 +183,9 @@ void start(String runnableName,

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132040768 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132040093 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -267,6 +280,14 @@ void stopByIdAndWait(String

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132029508 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132029465 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132029365 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762189 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -291,6 +300,24 @@ public void run() { //

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131761843 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java --- @@ -22,5 +22,9 @@ */ public interface EventHandlerContext {

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762593 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java --- @@ -85,13 +105,29 @@ public TimeoutAction launchTimeout(Iterable

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762365 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java --- @@ -22,5 +22,9 @@ */ public interface EventHandlerContext {

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762894 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java --- @@ -85,13 +105,29 @@ public TimeoutAction launchTimeout(Iterable

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131761787 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java --- @@ -22,5 +22,9 @@ */ public interface EventHandlerContext {

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131234842 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java --- @@ -124,6 +124,75 @@ public void initialize(EventHandlerContext context) { }

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131211956 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java --- @@ -79,12 +83,22 @@ public void initialize(EventHandlerContext

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131210382 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -291,6 +301,23 @@ public void run() { //

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131209163 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -135,6 +135,15 @@ private final Map

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131208560 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java --- @@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context) { }

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131210237 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -291,6 +301,23 @@ public void run() { //

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r130406951 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java --- @@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context) { }

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user sameetandpotatoes commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r129643121 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -267,6 +281,9 @@ void stopByIdAndWait(String

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user sameetandpotatoes commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r129643180 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -103,6 +105,8 @@ public Integer apply(BitSet

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

GitHub user maochf opened a pull request: https://github.com/apache/twill/pull/58 [TWILL-240] EventHandler Improvement https://issues.apache.org/jira/browse/TWILL-240 Add started, containerLaunched, containerStopped, completed, killed, aborted to EventHandler You can