mukulga commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1541477280
I'd like to create a branch xalan-j_xslt3.0 from xalan-test repos's master
branch (to help test xalan-java repos branch xalan-j_xslt3.0 codebase), before
this PR is merged to xalan-test repo
[
https://issues.apache.org/jira/browse/XALANJ-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Gandhi updated XALANJ-2646:
-
Attachment: xsl3_for_each_group_test_files.zip
> Implementation of xslt 3.0's xsl:for-each-group
[
https://issues.apache.org/jira/browse/XALANJ-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Gandhi updated XALANJ-2646:
-
Attachment: (was: xsl3_for_each_group_test_files.zip)
> Implementation of xslt 3.0's xsl:for
[
https://issues.apache.org/jira/browse/XALANJ-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721339#comment-17721339
]
Elliotte Rusty Harold commented on XALANJ-2651:
---
I don't seem to have perm
[
https://issues.apache.org/jira/browse/XALANJ-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated XALANJ-2651:
Issue Type: Improvement (was: Bug)
> Migrate build from Ant to Maven
> --
[
https://issues.apache.org/jira/browse/XALANJ-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721418#comment-17721418
]
Gary D. Gregory commented on XALANJ-2651:
-
I changed this ticket to an improveme
[
https://issues.apache.org/jira/browse/XALANJ-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Gandhi updated XALANJ-2646:
-
Attachment: (was: xsl3_for_each_group_test_files.zip)
> Implementation of xslt 3.0's xsl:for
[
https://issues.apache.org/jira/browse/XALANJ-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Gandhi updated XALANJ-2646:
-
Attachment: xsl3_for_each_group_test_files.zip
> Implementation of xslt 3.0's xsl:for-each-group
jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542580670
1. Historically, in this project, we have NOT used eight-space indentations;
I believe we started with four. When in doubt, follow project's existing
conventions. And your comment about lin
jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542587344
Speaking of nitpicking, I now think I'm *not* accepting the em-dash request
as a "friendly amendment". Coding is not typesetting. I'll accept the
preference for em-space in javadoc or othe
jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542593330
So, recognizing that the code-style comments are nitpicks and that code
style should be separated from functional change, can we get consensus that
this change set can be merged? If not, h
elharo commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542631630
I think we fundamentally agree. I'm fine with four space indents on
continuation lines, or whatever project conventions folks like, provided it's
written down somewhere. Are there code conven
elharo commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542639314
I'm OK with this being merged though formatting guidelines are one of many
things we should deal with sooner rather than later, and certainly in advance
of any significant feature work. I app
jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542682359
We (meaning the IBM group) used to have a shared Eclipse profile that
included some code style settings, which helped ensure some consistency.
Apparently that didn't get checked into the pr
jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542693920
Absolutely agree about squash merge. Especially since hit can squash as part
of the merge. Making each merge self-contained is clearly a win.
And, yeah, let the messages float with ju
15 matches
Mail list logo
