Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r186427922
--- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r186422920
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -950,6 +952,39 @@ server.3=zoo3:2888:3888
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r186415246
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -950,6 +952,39 @@ server.3=zoo3:2888:3888
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r183201618
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -106,10 +104,10 @@ public String toString() {
private final
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r183201663
--- Diff:
src/java/main/org/apache/zookeeper/server/command/StatCommand.java ---
@@ -64,8 +64,8 @@ public void commandRun
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r182332830
--- Diff:
src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java ---
@@ -75,9 +79,9 @@ public void commandRun() {
print
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r182325325
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,5 +74,19 @@ public void testOperationsAfterCnxnClose() throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r181829051
--- Diff: src/java/main/org/apache/zookeeper/server/admin/Commands.java ---
@@ -329,12 +329,20 @@ public CommandResponse run(ZooKeeperServer zkServer
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r181817033
--- Diff:
src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java ---
@@ -75,9 +79,9 @@ public void commandRun() {
print
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r181824379
--- Diff: src/java/main/org/apache/zookeeper/server/admin/Commands.java ---
@@ -329,12 +329,20 @@ public CommandResponse run(ZooKeeperServer zkServer
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r181822557
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,5 +74,19 @@ public void testOperationsAfterCnxnClose() throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r181823105
--- Diff:
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +92,17 @@ public void testSendCloseSession() throws Exception
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Good analysis and fix. Few minor comments,
- Please take care indentation in the tests. Presently, it uses tab.
- Please add comments in test as a quick reference
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/417#discussion_r153161187
--- Diff: ivy.xml ---
@@ -90,6 +90,69 @@
+
+
+
+
--- End diff --
Good work! Thanks
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/112
Thanks Michael for pushing this long standing issue.
+1 from me, I'm OK to commit this patch after creating an issue for the
code changes suggested previously.
---
If your project
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/112#discussion_r125264767
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -390,6 +391,7 @@ else if (qp.getType() == Leader.SNAP
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/112
@hanm, Thanks for the heads up. I will give my feedback soon, in a day or
two.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/285
@gosubpl , I've merged it and please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/285
Thanks @gosubpl
Thanks @hanm for the reviews. I'll merge this shortly.
I could see, this was pushed to `branch 3.5`+ via ZOOKEEPER-1975, nobody
might have noticed this in branch
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
Merged, please close the PR, @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
Thanks @afine for the updates.
+1, changes looks pretty good. I will merge this shortly.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/232
Merged, please close pr @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/232
+1 LGTM, I'll commit this shortly.
Thanks @afine for the good work.
Thanks @hanm for the reviews.
---
If your project is set up for it, you can reply to this email and have your
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/236
Merged, please close pr @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/236
Thanks @afine for the contribution.
+1 LGTM, I'll commit shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
+1 LGTM.
@afine, could you please rebase the patch on latest branch-3.4 code, there
are few conflicts due to `ZOOKEEPER-2732` commits.
---
If your project is set up for it, you can
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/239#discussion_r118267625
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -90,6 +90,16 @@
+
+
--- End diff
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/239#discussion_r117696607
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -90,6 +90,16 @@
+
+
--- End diff
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117673526
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -628,14 +628,7 @@ protected void pRequest(Request request) throws
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/258
+1 LGTM, Thanks @afine for the contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r117658709
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -96,21 +97,20 @@
/**
* This is a completely open ACL
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r117658774
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -96,21 +97,20 @@
/**
* This is a completely open ACL
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117279935
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -628,14 +628,7 @@ protected void pRequest(Request request) throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117287341
--- Diff: ivy.xml ---
@@ -49,6 +49,8 @@
+
--- End diff --
I'd prefer to exclude
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117280664
--- Diff: src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java ---
@@ -133,11 +133,17 @@ public boolean accept(File f
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117284290
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java ---
@@ -135,6 +135,8 @@ protected void processPacket(QuorumPacket qp) throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117232748
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -504,6 +504,8 @@ protected void pRequest2Txn(int type, long zxid
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117283048
--- Diff: src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java ---
@@ -133,11 +133,17 @@ public boolean accept(File f
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117284521
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Observer.java ---
@@ -125,6 +125,8 @@ protected void processPacket(QuorumPacket qp) throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117285488
--- Diff:
src/java/main/org/apache/zookeeper/server/upgrade/UpgradeMain.java ---
@@ -113,16 +113,18 @@ private void createAllDirs() throws IOException
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/231
+1 LGTM
Could you please rebase PR, as this has following conflict with the latest
code - ZOOKEEPER-2759.
`error: patch failed:
src/java/main/org/apache/zookeeper/server/quorum
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r117228583
--- Diff: src/java/main/org/apache/jute/compiler/JType.java ---
@@ -27,7 +27,7 @@
private String mCName;
private String mCppName
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/239#discussion_r117211921
--- Diff: ivy.xml ---
@@ -49,6 +49,8 @@
+
--- End diff --
Any alternative other than intro dependency
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116976191
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1054,6 +1054,8 @@ private void sendPing() {
private boolean
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/232
ZOOKEEPER-2722 commit is unrelated, please avoid that. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r112841400
--- Diff: src/java/main/org/apache/jute/compiler/JBuffer.java ---
@@ -41,6 +41,20 @@ public String genCppGetSet(String fname, int fIdx
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r112841388
--- Diff: src/java/main/org/apache/jute/compiler/JType.java ---
@@ -27,7 +27,7 @@
private String mCName;
private String mCppName
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/211#discussion_r110702056
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -87,6 +87,12 @@ public void close() {
LOG.debug("
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/211#discussion_r110080170
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -87,6 +87,12 @@ public void close() {
LOG.debug("
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/207
Thanks @hanm, +1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/181
Thank you @afine for the quick reply. +1 lgtm. I will merge this shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/201
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/181#discussion_r107370339
--- Diff: ivy.xml ---
@@ -58,7 +58,7 @@
-https://zookeeper.apache.org/doc/r3.4.9/zookeeperAdmin.html#sc_supportedPlatforms
Github user rakeshadr closed the pull request at:
https://github.com/apache/zookeeper/pull/200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/200
Thanks a lot @hanm for the useful comments, I will merge this changes
shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/200#discussion_r106797401
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java
---
@@ -87,7 +87,7 @@ public void testValidCredentials
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/200#discussion_r106797363
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java
---
@@ -83,7 +83,7 @@ public void testNullAuthLearnerServer
GitHub user rakeshadr opened a pull request:
https://github.com/apache/zookeeper/pull/200
ZOOKEEPER-2712: MiniKdc test case intermittently failing due to princâ¦
After long long analysis, I have observed concurrency issues at `ApacheDs
`(used for unit test) causing the trouble
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/187
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/183#discussion_r104572803
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1042,6 +1042,40 @@ server.3=zoo3:2888:3888
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/179
Thanks @hanm, +1 LGTM.
Hi @phunt, @arshadmohammad, do you have some cycle to review the final
patch, would be great to see another +1 votes as this is critical . Thanks!
---
If your
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r103139365
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -216,6 +216,10 @@ public static boolean isEnabled(String
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
As per the offline discussion with @afine, identified that `checkstyle ant
task` is not working in branch-3.4 and will be raising a new jira task to
correct this.
```
checkstyle.check
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
> I did not add the transitive="false" because we are not using it for the
default configuration on the previous line. If you feel strongly about it I
will add it.
As we
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101951840
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -267,10 +267,17 @@ private boolean checkFourLetterWord(final Channel
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/173
I'm really sorry, I didn't get much time on this work. I could see very
good discussions about this and I'm thinking you all are reaching to a pretty
good solution. My previous comment
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/173
Thanks a lot @JiangJiafu for the effort in driving this.
I'm not sure whether this is a blocker for 3.4.10 release. Is it good if
we just release 3.4.10 without this and make
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
Please add `transitive="false"` explicitly to checkstyle artifcat.
```
```
Otw, this is pulling the following dependencies to the `.classpath`, which
is no
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
>> I was able to run the unit tests within eclipse or idea (I used
WatcherTest as my example) using just the dependencies I added in the patch.
@afine , Probably, you c
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101582350
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1155,6 +1155,30 @@ server.3=zoo3:2888:3888
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101576900
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1155,6 +1155,30 @@ server.3=zoo3:2888:3888
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101489533
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1650,7 +1674,16 @@ server.3=zoo3:2888:3888
while "
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101492640
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101491680
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1155,6 +1155,30 @@ server.3=zoo3:2888:3888
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/176
+1 LGTM, I will merge this to branch-3.5 and master shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/176#discussion_r101259308
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -590,8 +590,8 @@ void lead() throws IOException, InterruptedException
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
Thanks @afine for reporting this. With newly added dependencies, the
compilation error will be resolved. But, I could see while running unit test
case in eclipse, it needed all the transitive
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/157
Thanks @revans2 for the useful results. I spend sometime going through the
changes and looks good to me. @hanm, please go ahead with merging this to
branch-3.4.
---
If your project is set up
Github user rakeshadr closed the pull request at:
https://github.com/apache/zookeeper/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/87
Please close this PR as this is merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/87
I'm merging this to branch-3.4.
Could you provide another PR for master/branch3.5 as this has minor
conflicts and not applying properly. Thanks!
---
If your project is set up for it, you
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/157
@hanm , mostly it makes sense to me as you all have done detailed code
reviews and there is no open comments now. I hope the code path is thoroughly
discussed/tested? I'd like to freeze
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/170#discussion_r100700701
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java ---
@@ -18,8 +18,8 @@
package
GitHub user rakeshadr opened a pull request:
https://github.com/apache/zookeeper/pull/170
ZOOKEEPER-2689: Fix Kerberos Authentication related test cases
Presently 'MiniKdc.java' uses Apache Kerby which has a build requirement of
jdk1.7+, http://directory.apache.org/kerby/developer
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/164
@arshadmohammad , its merged, could you close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/163
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/150
Thanks everyone for the great effort & time in pushing this issue. I could
see long discussions in the PR and I hope this work is nearing completion.
Could you please update the prog
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/87
@eribeiro sure, I will consider this to 3.4.10. Thanks @tmancill for the
contribution. Sorry for the delay in looking at this jira, could you please
create separate PR for {{master}} branch
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/156
Thanks @hanm , I've committed the changes to branch-3.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakeshadr closed the pull request at:
https://github.com/apache/zookeeper/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakeshadr closed the pull request at:
https://github.com/apache/zookeeper/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r98146418
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,4 +69,41 @@ public void testOperationsAfterCnxnClose() throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r97935895
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,4 +69,38 @@ public void testOperationsAfterCnxnClose() throws
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/137
@eribeiro, I have cherry picked the changes to branch-3.4 using #155 pull
request. Could you please verify the branch-3.4 changes once and close this PR.
Thanks!
---
If your project is set up
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/155
Thanks @eribeiro.
+1 LGTM, I will merge this shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/155#discussion_r97743121
--- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java ---
@@ -149,11 +150,9 @@ public static void main(String[] args
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r97716986
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,4 +74,38 @@ public void testOperationsAfterCnxnClose() throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r97716640
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,4 +74,38 @@ public void testOperationsAfterCnxnClose() throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r97717262
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,4 +74,38 @@ public void testOperationsAfterCnxnClose() throws
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r97716727
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -18,6 +18,12 @@
package org.apache.zookeeper.server
1 - 100 of 154 matches
Mail list logo
