Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 10:47 PM Emilio Cobos Álvarez wrote: > On 11/30/18 2:06 AM, Ehsan Akhgari wrote: > > On Thu, Nov 29, 2018 at 9:43 AM Emilio Cobos Álvarez > > wrote: > > > >> On 11/29/18 1:38 PM, Sylvestre Ledru wrote: > >>> This extension will automatically rebase the local changes to

Re: The upcoming C/C++ coding style change

On 11/30/18 2:06 AM, Ehsan Akhgari wrote: On Thu, Nov 29, 2018 at 9:43 AM Emilio Cobos Álvarez wrote: On 11/29/18 1:38 PM, Sylvestre Ledru wrote: This extension will automatically rebase the local changes to avoid conflicts. Is there a way to do the same for cinnabar users? Yes! Sorry

Intent to ship: window.event

Summary: Enable window.event which can access dispatching event from everywhere. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=218415 Link to standard: https://dom.spec.whatwg.org/#ref-for-dom-window-event Platform coverage: All Estimated or target release: 65 DevTools bug: (not sure)

Intent to ship: set keyCode or charCode of "keypress" event to the other's non-zero value

Summary: We'll set keyCode of "keypress" event to its charCode value if keyCode is 0, charCode of "keypress" event to its keyCode value if charCode is 0. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1479964 Link to standard: "conflated model" of

Intent to ship: stop dispatching "keypress" events when pressed key (key combination) does not introduce text input

Summary: We'll stop dispatching non-printable "keypress" events. "non-printable" means that key press or key combination does not introduce text input without IME. For example, arrow key press, Ctrl+A, etc. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=968056 Link to standard: For keys

Re: Intent to implement and ship: Unprefix -moz-user-select, unship mozilla-specific values.

On Thu, Nov 29, 2018 at 6:27 AM Emilio Cobos Álvarez wrote: > Sorry for the lag replying to this. > > On 11/13/18 4:35 PM, James Graham wrote: > > On 11/11/2018 17:57, Emilio Cobos Álvarez wrote: > > > >> web-platform-tests: Test coverage for all the values is pre-existing. > >> There's

Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 9:43 AM Emilio Cobos Álvarez wrote: > On 11/29/18 1:38 PM, Sylvestre Ledru wrote: > > This extension will automatically rebase the local changes to avoid > > conflicts. > > Is there a way to do the same for cinnabar users? > Yes! Sorry for the delay... Please check out

Intent to ship: dispatching "keydown" and "keyup" events during IME composition

Summary: We'll start to dispatch "keydown" and "keyup" events during IME composition. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=354358 Link to standard: https://w3c.github.io/uievents/#events-composition-key-events Platform coverage: All Estimated or target release: 65 DevTools

Re: Intent to unship xml:base

Sorry I forgot to link to the bug itself: https://bugzilla.mozilla.org/show_bug.cgi?id=903372 which hasn't changed from last time. On Thu, Nov 29, 2018 at 8:18 PM Jonathan Kingston wrote: > > Since the deprecation of this feature the usage of this feature has > reached near 0 numbers in our

Re: Intent to unship: -moz-prefixed CSS gradient functions

On Thursday, April 13, 2017 at 6:22:48 PM UTC-7, Xidorn Quan wrote: > In bug 1337655 [1], I'm going to disable -moz-prefixed CSS gradient > functions by default. This didn't stick (back in 2017), because it broke some buttons on gmail (which was filed as

Straw man mozilla-central node_modules policies; comments requested

[For those who have seen earlier iterations of this document, the security section now discusses the recent event-stream/flatmap-stream exploit specifically --dmose] I’ve drafted a set of straw man proposals for getting basic node_modules support in mozilla-central sooner rather than later.

Firefox Performance Profiling Workshop in Mozlando

(previously shared with firefox-dev. re-sending this to dev-platform) The Perf Tools team and friends are hosting a hands-on workshop and training session in Orlando. This is a great time to attend or invite your team to get

Intent to unship xml:base

Since the deprecation of this feature the usage of this feature has reached near 0 numbers in our usage counters[1]. 0.003% based on 64 beta [2] The specification has removed xml:base many years ago and this change has an advantage of code simplification and also reduces the need to compute base

Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 12:20 PM Boris Zbarsky wrote: > On 11/29/18 11:40 AM, Ehsan Akhgari wrote: > > Yes, that is true sadly. But to be fair here, old mq patches that do not > > apply due to age are already beyond saving with any kind of automated > > tooling, and they require manual work to

Re: The upcoming C/C++ coding style change

On 11/29/2018 04:38 AM, Sylvestre Ledru wrote: The experimentation with dom/media highlighted that we need an efficient way to automatically rebase patches before the merge. To achieve this, we updated the bootstrap process to include an extension called hg formatsource. This extension will

Re: The upcoming C/C++ coding style change

On 11/29/18 11:40 AM, Ehsan Akhgari wrote: Yes, that is true sadly. But to be fair here, old mq patches that do not apply due to age are already beyond saving with any kind of automated tooling, and they require manual work to get them applied first. :-/ Sure. That's not true.

Re: The upcoming C/C++ coding style change

On 11/29/18 11:40 AM, Ehsan Akhgari wrote: Yes, that is true sadly. But to be fair here, old mq patches that do not apply due to age are already beyond saving with any kind of automated tooling, and they require manual work to get them applied first. :-/ Sure. That's not true.

Re: The upcoming C/C++ coding style change

This short guide should be helpful for Mercurial users: https://docs.google.com/document/d/13AwAsvKMhH0mflDlfatBqn6LmZHiQih76oxM4zfrPl4 On Thu, Nov 29, 2018 at 11:49 AM Ehsan Akhgari wrote: > On Thu, Nov 29, 2018 at 11:44 AM Honza Bambas wrote: > >> On 2018-11-29 17:12, Ehsan Akhgari wrote: >>

Re: The upcoming C/C++ coding style change

On 2018-11-29 17:49, Ehsan Akhgari wrote: > No, I didn't.  :-)  That's exactly what the hg-formatsource extension does for you, it reformats your local changes on the fly as the rebase is in progress, so you will get no collisions. \o/ No, those are old days and long gone, my friend.  We

Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 8:44 AM Honza Bambas wrote: > OTOH, if the changes are only whitespace changes, maybe there is some > way `patch --ignore-whitespace --fuzz N` could apply the patches. Then > just re-format and your patches are OK. > The changes that clang-format makes include things

Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 11:44 AM Honza Bambas wrote: > On 2018-11-29 17:12, Ehsan Akhgari wrote: > > On Thu, Nov 29, 2018 at 8:00 AM Boris Zbarsky wrote: > > > >> On 11/29/18 7:38 AM, Sylvestre Ledru wrote: > >>> This extension will automatically rebase the local changes to avoid > >>>

Re: The upcoming C/C++ coding style change

On 2018-11-29 17:12, Ehsan Akhgari wrote: On Thu, Nov 29, 2018 at 8:00 AM Boris Zbarsky wrote: On 11/29/18 7:38 AM, Sylvestre Ledru wrote: This extension will automatically rebase the local changes to avoid conflicts. Sylvestre, Will it also update mq patches, or just in-repo commits? I

Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 11:30 AM Boris Zbarsky wrote: > On 11/29/18 11:12 AM, Ehsan Akhgari wrote: > >* Pull from a pre-reformat of the tree, run ./mach bootstrap to > install > > hg-formatsource. > >* Do a one-time translation of your mq queue to a set of commits. > >* Pull from

Re: Workflow Apropos!

James Graham wrote on 2018-11-28 13:20: On 28/11/2018 20:15, Mark Côté wrote: My team has pretty much nothing to do with the gecko GitHub clone; we need to keep our focus on the "standard" workflow. Sure, the problem is that it's an attractive nuisance for new contributors who find it and go

Re: The upcoming C/C++ coding style change

On 11/29/18 11:12 AM, Ehsan Akhgari wrote: * Pull from a pre-reformat of the tree, run ./mach bootstrap to install hg-formatsource. * Do a one-time translation of your mq queue to a set of commits. * Pull from hg.mozilla.org to pick up the reformat commit. * Do a one-time translation

Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 4:38 AM Sylvestre Ledru wrote: > The experimentation with dom/media highlighted that we need an efficient > way to automatically rebase patches before the merge. > To achieve this, we updated the bootstrap process to include an extension > called hg formatsource. > This

Re: The upcoming C/C++ coding style change

On Thu, Nov 29, 2018 at 8:00 AM Boris Zbarsky wrote: > On 11/29/18 7:38 AM, Sylvestre Ledru wrote: > > This extension will automatically rebase the local changes to avoid > > conflicts. > > Sylvestre, > > Will it also update mq patches, or just in-repo commits? > I don't think this extension is

Soft code freeze for Firefox 65 starts December 3

Hi all, On December 3, we will be merging Firefox 65 from mozilla-central to beta for the first time. In order to avoid invalidating the testing we get out of late Nightly and the early Developer Edition builds and to ensure that we can roll out Beta 65 to a wider audience with confidence, we'd

Re: The upcoming C/C++ coding style change

On 11/29/18 1:38 PM, Sylvestre Ledru wrote: This extension will automatically rebase the local changes to avoid conflicts. Is there a way to do the same for cinnabar users? -- Emilio ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: The upcoming C/C++ coding style change

On 11/29/18 7:38 AM, Sylvestre Ledru wrote: This extension will automatically rebase the local changes to avoid conflicts. Sylvestre, Will it also update mq patches, or just in-repo commits? -Boris ___ dev-platform mailing list

The upcoming C/C++ coding style change

Hello, As Ehsan announced recently, we are going to reformat Friday 30 November. In order to mitigate the impact on the uplifts process, we choose this date before the merge day. In term of execution, we will close the trees Friday around 8am Paris/Berlin time (11pm PST). We will then merge

Re: Intent to implement and ship: Unprefix -moz-user-select, unship mozilla-specific values.

Sorry for the lag replying to this. On 11/13/18 4:35 PM, James Graham wrote: On 11/11/2018 17:57, Emilio Cobos Álvarez wrote: web-platform-tests: Test coverage for all the values is pre-existing. There's unfortunately little coverage in WPT, but a lot in our selection and contenteditable