On 7/15/2015 3:23 AM, Benjamin Smedberg wrote:
Given that premise, we shouldn't just change aArgument; we should
adopt the Google C++ style guide wholesale:
* names_with_underscores
* members_with_trailing_
* no more ns prefix
I used this style in a personal project, and I quickly came to
On 7/14/2015 8:23 AM, Benjamin Smedberg wrote:
Aww, I was avoiding getting into this thread.
...
The argument I am most sympathetic to is that this convention is a
barrier to new contributors. Making new contributors productive, both
employees and volunteers, is a very good reason to choose
On Tue, Jul 14, 2015 at 9:17 PM, Nicholas Nethercote n.netherc...@gmail.com
wrote:
On Tue, Jul 14, 2015 at 8:06 PM, Bobby Holley bobbyhol...@gmail.com
wrote:
I'm not wild about this idea.
It's such a boil-the-ocean solution I honestly thought bsmedberg was
joking at first...
Well
The public source code for Firefox has existed for 17+ years (since ~April
1998). We can only assume it will be around for another 10+ years.
I believe you have to take the long view on the cost benefit analysis and
realize that a lot of pain in the short term (e.g. switching styles
entirely)
On 7/15/2015 5:47 PM, Andrew Sutherland wrote:
Would it be crazy for us to resort to a poll on these things?
A poll will not be useful for informing this decision.
--BDS
___
dev-platform mailing list
dev-platform@lists.mozilla.org
On Wed, Jul 15, 2015 at 2:26 PM, Gregory Szorc g...@mozilla.com wrote:
The public source code for Firefox has existed for 17+ years (since ~April
1998). We can only assume it will be around for another 10+ years.
I believe you have to take the long view on the cost benefit analysis and
Would it be crazy for us to resort to a poll on these things? I propose
abusing the mozillans.org skills field in profiles.
For example, I have created the following sets of skills on
mozillians.org by question, and which should autocomplete if you go to
the edit page for your profile at
On 7/8/2015 7:31 AM, Nathan Froyd wrote:
If somebody is willing to do the formatting, I'm willing to do the
review. I think the thread has reached the point of people repeating
ad nauseum what was already said earlier in the thread, so it's time
for a decision. Benjamin?
Aww, I was
On 7/14/2015 10:23 AM, Benjamin Smedberg wrote:
Given that premise, we shouldn't just change aArgument; we should
adopt the Google C++ style guide wholesale:
* names_with_underscores
The biggest problem here is that WebIDL and XPIDL codegen are heavily
geared towards camelCase names, as the
May I request that the major parts of this not happen until we have a
blame that can see through such changes.
Last I checked, gps had some ideas in that space but lacked time to
implement.
On Wed, Jul 15, 2015, at 03:23 AM, Benjamin Smedberg wrote:
On 7/8/2015 7:31 AM, Nathan Froyd wrote:
On Jul 14, 2015, at 8:23 AM, Benjamin Smedberg benja...@smedbergs.us wrote:
* no more ns prefix
Are people still creating new classes with an ’ns’ prefix? Surely this is
something we can drop right away, at least for new code. Much of the codebase
already does not use this style. We have
On Tue, Jul 14, 2015 at 9:06 AM, David Major dma...@mozilla.com wrote:
May I request that the major parts of this not happen until we have a
blame that can see through such changes.
Last I checked, gps had some ideas in that space but lacked time to
implement.
I spoke to a Mercurial
On Tue, Jul 14, 2015 at 10:06 AM, Gregory Szorc g...@mozilla.com wrote:
That being said, every other organizations in the world is using the same
or similar tools and is faced with similar challenges. Lack of a
commit-skipping feature doesn't hinder other organizations from performing
major
On Wed, Jul 15, 2015 at 3:40 AM, Joshua Cranmer pidgeo...@gmail.com
wrote:
The biggest problem here is that WebIDL and XPIDL codegen are heavily
geared towards camelCase names, as the IDL convention is camelCase.
C++ names matching WebIDL (or spec names in general) has value. We've
gotten
On 14 July 2015 at 08:23, Benjamin Smedberg benja...@smedbergs.us wrote:
The argument I am most sympathetic to is that this convention is a barrier
to new contributors. Making new contributors productive, both employees and
volunteers, is a very good reason to choose one style over another.
I'm not wild about this idea. Switching styles entirely would be several
times more churn and work than just making our existing codebase conform to
our existing style guide. Consistency with Google's style might be a nice
bonus, and there might be subjective arguments for one or the other, but
On Tue, Jul 14, 2015 at 8:06 PM, Bobby Holley bobbyhol...@gmail.com wrote:
I'm not wild about this idea.
It's such a boil-the-ocean solution I honestly thought bsmedberg was
joking at first...
Nick
___
dev-platform mailing list
On Tue, Jul 14, 2015 at 8:23 AM, Benjamin Smedberg benja...@smedbergs.us
wrote:
On 7/8/2015 7:31 AM, Nathan Froyd wrote:
If somebody is willing to do the formatting, I'm willing to do the
review. I think the thread has reached the point of people repeating ad
nauseum what was already said
On 07/14/2015 08:11 PM, Martin Thomson wrote:
On Tue, Jul 14, 2015 at 10:06 AM, Gregory Szorc g...@mozilla.com wrote:
That being said, every other organizations in the world is using the same
or similar tools and is faced with similar challenges. Lack of a
commit-skipping feature doesn't hinder
19 matches
Mail list logo
