Github user milleruntime closed the pull request at:
https://github.com/apache/accumulo/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108522828
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
---
@@ -89,4 +89,11 @@ public Value getTopValue() {
re
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108522399
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
---
@@ -89,4 +89,11 @@ public Value getTopValue() {
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108479204
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,21 @@
* if not su
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108475855
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,21 @@
* if not suppo
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108473678
--- Diff:
core/src/test/java/org/apache/accumulo/core/iterators/system/ColumnFamilySkippingIteratorTest.java
---
@@ -236,4 +237,45 @@ public void test3(
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108471232
--- Diff:
core/src/test/java/org/apache/accumulo/core/iterators/system/ColumnFamilySkippingIteratorTest.java
---
@@ -236,4 +237,45 @@ public void tes
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108464160
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
@@ -163,22 +163,22 @@ private static Path
createTmpDir(AccumuloCon
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108463656
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
---
@@ -89,4 +89,11 @@ public Value getTopValue() {
re
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108463479
--- Diff:
server/tserver/src/test/java/org/apache/accumulo/tserver/tablet/CompactorTest.java
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apach
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108462721
--- Diff: docs/src/main/asciidoc/chapters/iterator_design.txt ---
@@ -182,6 +182,12 @@ early programming assignments which implement their
own tree data
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108461701
--- Diff:
core/src/test/java/org/apache/accumulo/core/iterators/system/ColumnFamilySkippingIteratorTest.java
---
@@ -236,4 +237,45 @@ public void test3(
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88744008
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not suppor
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88742821
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not suppor
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88687963
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not suppor
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88679462
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not sup
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88652597
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not sup
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88543950
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not suppor
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88543835
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not suppor
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88512703
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java ---
@@ -61,39 +61,27 @@ public ScanBatch read() throws IOExcepti
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r87846993
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -1164,11 +1167,7 @@ private Reader(Reader r, boolean useSample) {
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r87409384
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/FileSKVIterator.java ---
@@ -35,5 +35,5 @@
void closeDeepCopies() throws IOException;
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r87281103
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/FileSKVIterator.java ---
@@ -35,5 +35,5 @@
void closeDeepCopies() throws IOException;
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84969204
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
@@ -162,6 +162,10 @@ private void readNext(boo
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84906761
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -219,8 +224,14 @@ public void seek(Range range, Collection
colu
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84902206
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -219,8 +224,14 @@ public void seek(Range range, Collection
colu
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84888931
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/MapFileIterator.java
---
@@ -152,8 +152,12 @@ public void closeDeepCopies() thr
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84888609
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/SequenceFileIterator.java
---
@@ -104,8 +104,12 @@ public void init(SortedKeyVa
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84888602
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
---
@@ -225,10 +225,18 @@ void close(boolean sawErrors)
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84888578
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
@@ -614,12 +614,15 @@ public DataSource getNewDataSource() {
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84783230
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
---
@@ -225,10 +225,18 @@ void close(boolean sawErrors)
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84768594
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/SequenceFileIterator.java
---
@@ -104,8 +104,12 @@ public void init(SortedKeyVa
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84777479
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -219,8 +224,14 @@ public void seek(Range range, Collection
colu
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84780524
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
@@ -361,6 +369,9 @@ public static double
estimatePercentageLTE(V
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84785055
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java ---
@@ -61,39 +61,27 @@ public ScanBatch read() throws IOExcepti
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84777320
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -219,8 +224,14 @@ public void seek(Range range, Collection
colu
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84765329
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/MapFileIterator.java
---
@@ -152,8 +152,12 @@ public void closeDeepCopies() thr
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84768859
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
@@ -614,12 +614,15 @@ public DataSource getNewDataSource() {
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84778064
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
@@ -162,6 +162,10 @@ private void readNext(boo
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84780608
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
@@ -253,6 +257,9 @@ public static double
estimatePercentageLTE(V
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84754335
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
@@ -162,6 +162,14 @@ private void readNext(boo
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84754214
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java
---
@@ -388,9 +389,10 @@ else if (env.getIteratorScope() == I
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84743890
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -1193,16 +1192,14 @@ public void close() throws IOException {
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84718204
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
@@ -163,15 +163,15 @@ private static Path
createTmpDir(AccumuloC
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84695600
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not sup
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84694760
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
@@ -257,26 +257,19 @@ public void setSource(final Scan
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r84332426
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
@@ -163,15 +163,15 @@ private static Path
createTmpDir(AccumuloConfi
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83735883
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not support
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83743192
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java
---
@@ -388,9 +389,10 @@ else if (env.getIteratorScope() == Itera
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83740194
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
@@ -162,6 +162,14 @@ private void readNext(boolean
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83739466
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -1193,16 +1192,14 @@ public void close() throws IOException {
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83736440
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
@@ -163,15 +163,15 @@ private static Path
createTmpDir(AccumuloConfi
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83739144
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -1164,11 +1167,7 @@ private Reader(Reader r, boolean useSample) {
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83743748
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java ---
@@ -120,16 +108,15 @@ public ScanBatch read() throws IOException
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83739603
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
---
@@ -89,4 +89,11 @@ public Value getTopValue() {
retu
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83737095
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
@@ -257,26 +257,19 @@ public void setSource(final Scanner
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83427576
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -249,4 +268,9 @@ final public boolean hasTop() {
public v
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83274406
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -249,4 +268,9 @@ final public boolean hasTop() {
public v
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83260389
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -80,6 +80,19 @@ public int compareTo(TermSource o) {
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83258841
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
@@ -257,26 +257,19 @@ public void setSource(final Scanner
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83249120
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
@@ -257,26 +257,19 @@ public void setSource(final Scanner
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83235234
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/user/IntersectingIterator.java
---
@@ -110,6 +111,19 @@ public TermSource(SortedKeyVal
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83234698
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -80,6 +80,19 @@ public int compareTo(TermSource o) {
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83235022
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
@@ -213,4 +221,13 @@ public void setInterruptF
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/159
ACCUMULO-1280: many changes for closing iterators
Looking for feedback on first round of changes and if there are more places
close can be called.
- made SortedKeyValueIterator extend Aut
65 matches
Mail list logo
