Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162105254
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
---
@@ -60,6 +60,24 @@
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1784
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1782
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162092404
--- Diff:
tests/compatibility-tests/src/main/resources/serial/jbmserial.groovy ---
@@ -49,6 +50,11 @@ if (method.equals("write")) {
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162103683
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/ServerMessageImpl.java
---
@@ -0,0 +1,192 @@
+/*
Team,
I am implementing runtime reloading of authorization map settings in
activemq.xml using following configuration,
(http://activemq.apache.org/runtime-configuration.html)
http://activemq.apache.org/schema/core; start="false" ... >
...
I performed test cases
Github user jostbg commented on the pull request:
https://github.com/apache/activemq-artemis/commit/9fb8c3c470eb9a27fccf286314f5083082c4ba89#commitcomment-26913676
In
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java:
In
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Any metrics to quantify the benefit and justify this change?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1783
@jmesnil @mtaylor what about adding ServerMessage as a class.. and only add
the methods that matter...
all these other methods would fail with a NotImplementedException...
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1784
ARTEMIS-1615 Duplicate TypedProperties::checkCreateProperties
TypedProperties::putByteProperty contains a duplicate
TypedProperties::checkCreateProperties: it needs to be removed
You
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162105330
--- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy
---
@@ -24,30 +24,40 @@ import
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162105397
--- Diff:
tests/compatibility-tests/src/main/resources/serial/jbmserial.groovy ---
@@ -49,6 +50,11 @@ if (method.equals("write")) {
Github user franz1981 commented on the pull request:
https://github.com/apache/activemq-artemis/commit/9fb8c3c470eb9a27fccf286314f5083082c4ba89#commitcomment-26913859
In
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java:
In
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162082434
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
---
@@ -60,6 +60,24 @@ boolean
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1782#discussion_r162100927
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -892,7 +892,7 @@
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1783
@clebertsuconic Martyn's is adding backwards compatibility by putting back
the exact types. That's the safest way to ensure backwards compatibility works.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162082757
--- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy
---
@@ -24,30 +24,40 @@ import
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162122543
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
@@ -622,8 +622,8
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1775
I could easily rebase this also.. but if you could rebase it later please
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162151931
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/LDAPLoginModule.java
---
@@ -105,12 +110,39 @@ public
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162153980
--- Diff: docs/user-manual/en/masking-passwords.md ---
@@ -18,12 +18,33 @@ Apache ActiveMQ Artemis provides a default password
encoder and
Github user gtully commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1759#discussion_r162113988
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162116039
--- Diff:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/SerializationTest.java
---
@@ -91,15
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162123685
--- Diff:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/SerializationTest.java
---
@@ -91,15
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162131538
--- Diff:
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162146958
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
@@ -622,8 +622,8 @@
Github user jostbg commented on the issue:
https://github.com/apache/activemq-artemis/pull/1773
@jbertram Could you please check if my
[observations](https://issues.apache.org/jira/browse/ARTEMIS-1589) and my
trivial fix are correct. Thanks in advance!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1778
@michaelandrepearce, I appreciate your reviews. They're consistently
valuable.
---
Github user gtully commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1759#discussion_r162117583
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
---
@@
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1759
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162116374
--- Diff:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/SerializationTest.java
---
@@ -91,15
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1780
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1773
@jostbg, I'm not terribly familiar with AMQP so I can't comment with
authority as to whether or not this is a good change. @tabish121, could you
perhaps take a look here?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@michaelandrepearce I promise I will get here by next week :)
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1786
Please do not merge it yet: I need to update all the commit messages adding
the JIRA.
The current PR has already passed the same OpenWire tests of master with
similar results, but
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1773
@jbertram @jostbg As far as I can see the patch looks correct, it would
seem to make more sense to return the remote container ID here than the locally
generated server side value as
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1744
I don't agree with changing the CoreMessage for this... but there's
something we can do at the Server's message.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1744
I will handle this...
---
GitHub user gtully opened a pull request:
https://github.com/apache/activemq-artemis/pull/1785
[ARTEMIS-1030] add support for mapping openwire virtual topic consumeâ¦
â¦r destinations to FQQN
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1786
ARTEMIS-1616 OpenWire improvements
It includes several improvements on OpenWire:
- Avoided copy of CoreMessage when not needed and cached lambda on hot path
- Refactored
Hi Everyone,
Happy New Year.
I have a progress update about the NMS AMQP API Rework. The work done in the
fork, https://github.com/cjwmorgan-sol-sys/nms-amqp, is close to being
finished. Duane and I have also signed the ICLA. I will follow what Tim
suggested by creating an NMS JIRA under the
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1783
ARTEMIS-1611 Added support for 1.x transformer API
I've added support for the old API back. There was no real need to remove
it other than some internal refactoring. I haven't written
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1753
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978201
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
---
@@ -60,6 +60,24 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978381
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -231,6 +239,16 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978353
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -231,6 +239,16 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978297
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -309,7 +338,7 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161979093
--- Diff:
tests/compatibility-tests/src/main/resources/serial/jbmserial.groovy ---
@@ -49,6 +50,11 @@ if (method.equals("write")) {
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978935
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQQueue.java
---
@@ -41,6 +41,10 @@ public
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161981000
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -277,6 +305,7 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@franz1981 will merge this, as seems no further feedback.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@clebertsuconic did you get a chance to possibly look at whats missing /
why those extra tests don't pass with this change, im still struggling to
figure it myself
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978819
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQTopic.java
---
@@ -40,8 +40,12 @@ public
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978767
--- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy
---
@@ -24,30 +24,40 @@ import
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161980690
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -244,22 +262,32 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161979210
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -244,22 +262,32 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@franz1981 you happy for this to merge?
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978616
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java
---
@@ -465,11
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1757
---
Github user jostbg commented on the issue:
https://github.com/apache/activemq-artemis/pull/1773
The java doc of getClientID says "Returns the Client ID associated with
this connection" which probably refers to the "client-side" ID. StompConnection
for example returns the ID set by
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1773
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Sure, using JMH to measure performance of the two AddressInfo
Implementations.
BenchmarkMode Cnt ScoreError
Units
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1759#discussion_r162047806
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
---
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1759#discussion_r162047648
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
---
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162048935
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162051266
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import
Github user shailendra14k commented on the issue:
https://github.com/apache/activemq-artemis/pull/1744
@clebertsuconic , I did some testing, with the changes
[#1787](https://github.com/apache/activemq-artemis/pull/1787), Address-settings
policies work as expected with the older
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1786#discussion_r162266546
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -361,13 +371,68 @@ public int
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162269947
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1787#discussion_r162261691
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1284,7 +1284,7 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1786#discussion_r162262393
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -361,13 +371,68 @@ public int
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1786#discussion_r162262699
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -361,13 +371,68 @@ public int
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1771
OK it's done.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1787#discussion_r162261502
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -736,11 +736,11 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162268544
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java
---
@@ -66,6 +66,11 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162269219
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/server/QueueQueryResult.java
---
@@ -55,13 +57,19 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162269523
--- Diff:
artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
@@ -2790,6 +2790,14 @@
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1744
if you could please close this PR?
#1787 superceedes this.. although this PR will be closed automagically when
#1787 is merged.
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1787
ARTEMIS-1577 Address-settings policies not working with older clients
This closes #1744
You can merge this pull request into a Git repository by running:
$ git pull
Github user shailendra14k commented on the issue:
https://github.com/apache/activemq-artemis/pull/1744
Thank you, Closing this PR
---
Github user shailendra14k closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1744
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162119392
--- Diff:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/SerializationTest.java
---
@@ -91,15 +91,15
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1778
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1744
If you could review the new one please ?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Thanks, @michaelandrepearce. Nice results!
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1771
@jbertram @clebertsuconic done!
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1771
@jbertram Please hold for a moment. I just found a change that may be wrong.
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162233948
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
@@ -622,8 +622,8 @@
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1780
@cshannon Forget that, I was looking at the link you posted instead of the
commit.
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1780
@cshannon Any chance you could add a unit test for this?
---
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162024692
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162028476
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1780
PR has been updated. Also inside WildcardAddressManager should we be
unlinking the addresses both was inside of removeAndUpdateAddressMap? The
current line has this:
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162015472
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
This looks good to me too
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@michaelandrepearce I'm looking at it locally right now :+1:
---
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1782
ARTEMIS-1612 Fix message redistribution for prefixed addresses
You can merge this pull request into a Git repository by running:
$ git pull
97 matches
Mail list logo
