+1 from my side as well. I also like the suggestion to revert a patch
causing new test failures instead of expecting the owner to fix the issues
in follow up jiras.
And I would also have a borderline "radical" suggestion.. if a flaky test
is failing and the committer isn't sure at a glance that th
Congratulations Anishek!
Rajesh Balamohan (időpont: 2017. szept. 30., Szo,
2:25) ezt írta:
> Congrats Anishek!!
>
> ~Rajesh.B
>
> On Sat, Sep 30, 2017 at 4:30 AM, Vaibhav Gumashta <
> vgumas...@hortonworks.com
> > wrote:
>
> > Congratulations Anishek!
> >
> >
> > On 9/29/17, 3:57 PM, "Thejas Nai
Congrats Sankar!
Rajesh Balamohan (időpont: 2017. szept. 30., Szo,
2:24) ezt írta:
> Congrats Sankar!!
>
> ~Rajesh.B
>
> On Sat, Sep 30, 2017 at 4:30 AM, Vaibhav Gumashta <
> vgumas...@hortonworks.com
> > wrote:
>
> > Congratulations Sankar!
> >
> > On 9/29/17, 3:58 PM, "Thejas Nair" wrote:
> >
-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java
03e773a803f1dc7edfb9be8d795aba32535bd433
Diff: https://reviews.apache.org/r/62748/diff/1/
Testing
---
Thanks,
Barna Zsombor Klara
che/hive/beeline/QFileBeeLineClient.java
Lines 80 (patched)
<https://reviews.apache.org/r/62782/#comment264082>
Please add javadoc for public APIs.
- Barna Zsombor Klara
On Oct. 5, 2017, 11:08 a.m., Peter Vary wrote:
>
> ---
> This
s://reviews.apache.org/r/62748/#review187167
---
On Oct. 3, 2017, 12:29 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62782/#review187240
---
Ship it!
Ship It!
- Barna Zsombor Klara
On Oct. 5, 2017, 4
/YetusPhase.java
Lines 72-85 (patched)
<https://reviews.apache.org/r/63144/#comment265693>
I agree that this could go into a shell script generated by a velocity
template. It would also make this a bit more testable.
- Barna Zsombor Klara
On okt. 19, 2017, 12:40 du, Adam Szita
y.java
Lines 162 (patched)
<https://reviews.apache.org/r/62810/#comment266731>
Same as before, please use a typed iterator if possible.
- Barna Zsombor Klara
On Oct. 6, 2017, 3:37 p.m., Peter Vary wrote:
>
> ---
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62810/#review189606
---
Ship it!
Ship It!
- Barna Zsombor Klara
On Oct. 30, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63486/#review189889
---
Ship it!
Ship It!
- Barna Zsombor Klara
On nov. 1, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63528/#review190166
---
Ship it!
Ship It!
- Barna Zsombor Klara
On Nov. 2, 2017, 10
rg/apache/hadoop/hive/ql/hooks/ATSHook.java (line 213)
<https://reviews.apache.org/r/55194/#comment231712>
Same as line 208. Should this be a warning instead?
Thanks for the patch. LGTM, just minor nits.
- Barna Zsombor Klara
On Jan. 5, 2017, 2:28
.
- Barna Zsombor Klara
On Jan. 5, 2017, 6:45 p.m., Jason Dere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
test should keep working.
- Barna Zsombor Klara
On Jan. 13, 2017, 11:58 a.m., Marta Kuczora wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
the error message of the failed test.
Checkout how multiple tests, all with failures, look on the console to make
sure that the results are still readeable/easy to follow.
Thanks,
Barna Zsombor Klara
that the results are still readeable/easy to follow.
Thanks,
Barna Zsombor Klara
bbc
Diff: https://reviews.apache.org/r/55932/diff/
Testing
---
Ran multiple queries and checked that they are still displayed correctly.
Thanks,
Barna Zsombor Klara
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55846/#review162795
---
On Jan. 25, 2017, 1:12 p.m., Barna Zsombor Klara wrote:
>
>
/files/2017/02/03/ea41fd61-d49a-49cd-b31f-4567186cfc16__Query_Lifecycle_Timing_Metrics.png
New metrics showing query success rate
https://reviews.apache.org/media/uploaded/files/2017/02/03/1d613941-5d49-438e-bac9-0b08db190e6b__Query_Success_Rate_Matrics.png
Thanks,
Barna Zsombor Klara
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_int96_timestamp.q PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
io/parquet/timestamp/TestNanoTimeUtils.java
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_int96_timestamp.q PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Th
t should be consistent. The timezone adjustment in NanoTimeUtils
should take care of it.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56334/#review164481
--
ATION
ql/src/test/queries/clientpositive/parquet_int96_timestamp.q PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
q PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
visit:
https://reviews.apache.org/r/56334/#review164773
-------
On Feb. 9, 2017, 5:23 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically genera
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56334/#review164773
---
On Feb. 9, 2017, 5:23 p.m., Barna Zsombor Klara
e should have already thrown an exception in
ParquetRecordReaderBase. I'm not sure when the timezone can be missing here.
Sergio do you maybe remember?
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https:/
reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56334/#review165133
-------
On Feb. 10, 2017, 1:41 p.m., Barna Zsombor Klara wrote:
>
> ---
E-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/parquet_timestamp_conversion.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
EATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
st/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/parquet_timestamp_conversion.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
sults/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/parquet_timestamp_conversion.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
eline/qfile/QFile.java
Lines 36 (patched)
<https://reviews.apache.org/r/57343/#comment240272>
Typo: Class vs. Cless
- Barna Zsombor Klara
On March 7, 2017, 3:14 p.m., Peter Vary wrote:
>
> ---
> This is an automatically generat
/r/57503/diff/1/
Testing
---
Tested locally and added qtests/unit tests.
Thanks,
Barna Zsombor Klara
still readeable/easy to follow.
Thanks,
Barna Zsombor Klara
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168942
---
On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
>
> -
ould be a
lot higher than the max number of partition objects.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168969
---------
---------
On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
>
/57503/diff/2/
Changes: https://reviews.apache.org/r/57503/diff/1-2/
Testing
---
Tested locally and added qtests/unit tests.
Thanks,
Barna Zsombor Klara
://reviews.apache.org/r/57728/diff/1/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
partitions
missing from the HMS.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review169324
-------
On M
3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba
Diff: https://reviews.apache.org/r/57503/diff/3/
Changes: https://reviews.apache.org/r/57503/diff/2-3/
Testing
---
Tested locally and added qtests/unit tests.
Thanks,
Barna Zsombor Klara
://reviews.apache.org/r/57728/diff/2/
Changes: https://reviews.apache.org/r/57728/diff/1-2/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
------
On March 21, 2017, 5:28 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57728/
> ---
5de2c3f1244b8340b97eb0547fe66e52d80fb065
Diff: https://reviews.apache.org/r/57728/diff/3/
Changes: https://reviews.apache.org/r/57728/diff/2-3/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
/3-4/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
- calling UDFs with the timestamp values
- where clause with a constant cast as timestamp
- test for HoS
Tested manually but no qtests:
- join between 3 tables all parquet but with different/no timezone property
- subselect in from/where clauses
- exists / union / no exists
Thanks,
Barna Zsombor
explicit timestamp conversions in insert clause
Tested manually but no qtests:
- join between 3 tables all parquet but with different/no timezone property
- subselect in from/where clauses
- exists / union / no exists
Thanks,
Barna Zsombor Klara
/no timezone property
- subselect in from/where clauses
- exists / union / no exists
Thanks,
Barna Zsombor Klara
/where clauses
- exists / union / no exists
Thanks,
Barna Zsombor Klara
--------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58501/#review173610
---
On May 3, 2017, 12:59 p.m., Barna Zsombor Klara wrote:
>
> ---
the table property, we may end up reading incorrect timestamp values
silently from the table.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58501/#review173857
-------
s://reviews.apache.org/r/58501/#review173747
---
On May 3, 2017, 12:59 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-mail.
parquet but with different/no timezone property
- subselect in from/where clauses
- exists / union / no exists
Thanks,
Barna Zsombor Klara
Is this side effect intended? It probably should be modified on the
queryConf.
- Barna Zsombor Klara
On May 9, 2017, 3:05 p.m., Peter Vary wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59096/#review174438
---
Ship it!
Ship It!
- Barna Zsombor Klara
On May 10, 2017, 9
mvnBuildArgs and
mvnTestArgs in PTest.
Arguments will be key value pairs separated by '='. The '-D' will be added
automatically.
Thanks,
Barna Zsombor Klara
columns are added or replaced in a partitioned
table.
Thanks,
Barna Zsombor Klara
PTestClient and JiraService.
Ran a test with a heavily dumbed down CloudExecutionContextProvider that would
create the drowns on the local machine isntead of a cloud povider to test
integration between PTestClient and the WebService.
Thanks,
Barna Zsombor Klara
848faf27af1ed8945d7013b6562bab544605e4bc
Diff: https://reviews.apache.org/r/60006/diff/1/
Testing
---
Manually tested the PTestClient with and without the branch argument.
Updated and ran the unit tests.
Thanks,
Barna Zsombor Klara
efault is a bit
difficult.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177720
---
On June 1
d the PTestClient with and without the branch argument.
Updated and ran the unit tests.
Thanks,
Barna Zsombor Klara
local machine isntead of a cloud povider to test
integration between PTestClient and the WebService.
Thanks,
Barna Zsombor Klara
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59629/#review177723
-------
On June 13, 2017, 3 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an au
/hive/ptest/execution/conf/TestTestConfiguration.java
848faf27af1ed8945d7013b6562bab544605e4bc
Diff: https://reviews.apache.org/r/60085/diff/1/
Testing
---
Manually tested PTestClient.
Updated unit tests for the code in TestConfiguration.
Thanks,
Barna Zsombor Klara
/60085/diff/1-2/
Testing
---
Manually tested PTestClient.
Updated unit tests for the code in TestConfiguration.
Thanks,
Barna Zsombor Klara
Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177910
---
On June 13, 2017, 2:28 p.m., Barna Zsombor Klara wrote:
&
replaced in a partitioned table.
Thanks,
Barna Zsombor Klara
gt;
nit: Should this be a warning instead of info?
- Barna Zsombor Klara
On June 22, 2017, 3:18 a.m., ZhangBing Lin wrote:
>
> ---
> This is an automatically generated e-mail
or replaced in a partitioned table.
Thanks,
Barna Zsombor Klara
on the *hive.blobstore.optimizations.enabled* could we
use the HiveConf object and check that value instead of introducing a boolean
instance variable?
- Barna Zsombor Klara
On June 26, 2017, 1:56 p.m., Marta Kuczora wrote:
>
> ---
> This is an automatica
/apache/hadoop/hive/ql/optimizer/TestGenMapRedUtilsCreateConditionalTask.java
68ccda9ef61744e369638ceec5c083c77524c2db
Diff: https://reviews.apache.org/r/60433/diff/1/
Testing
---
Thanks,
Barna Zsombor Klara
e executing getJarFile
- Exception occured during the execution of getJarFile
- getJarFile encountered an exception
Same on line 90.
- Barna Zsombor Klara
On June 23, 2017, 3:56 a.m., ZhangBing Lin wrote:
>
> ---
> This
ql/src/test/results/clientpositive/insert_overwrite_table.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/60589/diff/1/
Testing
---
Manual testing and qtests.
Thanks,
Barna Zsombor Klara
To reply, visit:
https://reviews.apache.org/r/60589/#review179680
---
On July 3, 2017, 9:05 a.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-mai
/TestGenMapRedUtilsCreateConditionalTask.java
68ccda9ef61744e369638ceec5c083c77524c2db
Diff: https://reviews.apache.org/r/60433/diff/2/
Changes: https://reviews.apache.org/r/60433/diff/1-2/
Testing
---
Thanks,
Barna Zsombor Klara
/TestGenMapRedUtilsCreateConditionalTask.java
Lines 57 (patched)
<https://reviews.apache.org/r/60433/#comment257014>
This is needed to prevent an NPE in GenMapRedUtils#mergeMovePaths. If the
Session is not initialized Session.get() will return null.
- Barna Zsombor Klara
On July 17, 2017, 2:08 p.m.,
sit:
https://reviews.apache.org/r/60433/#review181386
---
On July 17, 2017, 2:08 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-mail. To re
/TestTestConfiguration.java
848faf27af1ed8945d7013b6562bab544605e4bc
Diff: https://reviews.apache.org/r/60085/diff/3/
Changes: https://reviews.apache.org/r/60085/diff/2-3/
Testing (updated)
---
Added unit tests for the Context class.
Thanks,
Barna Zsombor Klara
testing framework.
Thanks,
Barna Zsombor Klara
,
Barna Zsombor Klara
il. To reply, visit:
https://reviews.apache.org/r/61380/#review182090
-------
On Aug. 2, 2017, 3:56 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-m
/MetaStoreListenerNotifier.java
37327f8bd2ebf3f883fb3bd408d63f776b26406e
metastore/src/java/org/apache/hadoop/hive/metastore/TransactionalMetaStoreEventListener.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61497/diff/1/
Testing
---
Thanks,
Barna Zsombor Klara
.
Thanks,
Barna Zsombor Klara
://reviews.apache.org/r/61497/diff/2/
Changes: https://reviews.apache.org/r/61497/diff/1-2/
Testing
---
Thanks,
Barna Zsombor Klara
checked that the current set of restricted variables will
not restrict any new ones due to the change in the check from equals to
contains.
Thanks,
Barna Zsombor Klara
/
Testing
---
Added unit tests and checked that the current set of restricted variables will
not restrict any new ones due to the change in the check from equals to
contains.
Thanks,
Barna Zsombor Klara
update the patch.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59402/#review181710
---
On May 19, 2017,
unit tests for the Context class.
Thanks,
Barna Zsombor Klara
://reviews.apache.org/r/61712/diff/1/
Testing
---
Thanks,
Barna Zsombor Klara
://reviews.apache.org/r/61712/diff/1-2/
Testing
---
Thanks,
Barna Zsombor Klara
/TestDataSourceProviderFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61712/diff/3/
Changes: https://reviews.apache.org/r/61712/diff/2-3/
Testing
---
Thanks,
Barna Zsombor Klara
/r/61851/diff/1/
Testing
---
Thanks,
Barna Zsombor Klara
---
Thanks,
Barna Zsombor Klara
,
Barna Zsombor Klara
Zsombor Klara
://reviews.apache.org/r/62152/diff/1/
Testing
---
Thanks,
Barna Zsombor Klara
---
Thanks,
Barna Zsombor Klara
1 - 100 of 196 matches
Mail list logo
