Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-10-24 Thread Amareshwari Sriramadasu
> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 89 > > <https://reviews.apache.org/r/39576/diff/2/?file=1103857#file1103857line89> > > > > Why is th

Re: Review Request 39394: LENS-830: Checkstyle version should be picked from project version

2015-10-24 Thread Amareshwari Sriramadasu
394/#comment162025> Can you verify mvn versions:set works without issues? Also verify mvn release:prepare --dry-run works without issues? - Amareshwari Sriramadasu On Oct. 16, 2015, 12:16 p.m., Rajat Khandelwal

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-10-24 Thread Amareshwari Sriramadasu
> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 89 > > <https://reviews.apache.org/r/39576/diff/2/?file=1103857#file1103857line89> > > > > Why is th

Re: Review Request 39439: LENS-835 : Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39439/#review103915 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 19, 2015

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

2015-10-24 Thread Amareshwari Sriramadasu
, reopened. Gabor, Do you still see errors on generated doc? Raju/Gabor, Is that resulting in build failure in java-8? - Amareshwari Sriramadasu On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote: > > --- > This is an automatically ge

Re: Review Request 39483: LENS-838 : Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39483/#review103914 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 20, 2015

Re: Review Request 39606: LENS-843 : Columns in having clause not getting push down

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39606/#review103912 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 23, 2015

Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39598/#review103913 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 23, 2015

Re: Review Request 39650: LENS-846: Not all filters on fact is getting push down

2015-10-26 Thread Amareshwari Sriramadasu
e ) <https://reviews.apache.org/r/39650/#comment162185> Can you add test with only filter being present on fact.time and it is not selected - Amareshwari Sriramadasu On Oct. 26, 2015, 11:22 a.m., Sushil M

Re: Review Request 39651: LENS-845: Take regex rename arguments in columnar sql rewriter

2015-10-26 Thread Amareshwari Sriramadasu
g/r/39651/#comment162183> Is this required? - Amareshwari Sriramadasu On Oct. 26, 2015, 11:16 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Amareshwari Sriramadasu
include unit test? - Amareshwari Sriramadasu On Oct. 27, 2015, 8:08 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Amareshwari Sriramadasu
/JDBCDriver.java (line 705) <https://reviews.apache.org/r/39680/#comment162442> JDBC_DB_URI is added twice and JDBC_DRIVER_CLASS is removed - Amareshwari Sriramadasu On Oct. 27, 2015, 12:38 p.m., Rajat Khandelwal

Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

2015-10-27 Thread Amareshwari Sriramadasu
Thanks, Amareshwari Sriramadasu

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Amareshwari Sriramadasu
/DataSourceConnectionProvider.java (line 195) <https://reviews.apache.org/r/39680/#comment162452> Seems a wrong property setting even earlier - Amareshwari Sriramadasu On Oct. 27, 2015, 2:53 p.m., Rajat Khandelwal

Re: Review Request 39651: LENS-845: Take regex rename arguments in columnar sql rewriter

2015-10-26 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39651/#review104001 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 26, 2015

Re: Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

2015-10-27 Thread Amareshwari Sriramadasu
/ Testing --- All lens-cube tests succeeded Thanks, Amareshwari Sriramadasu

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Amareshwari Sriramadasu
<https://reviews.apache.org/r/39680/#comment162444> Remove this - Amareshwari Sriramadasu On Oct. 27, 2015, 1:37 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-11-16 Thread Amareshwari Sriramadasu
> On Nov. 4, 2015, 3:51 p.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1249 > > > > > > What happens to skipped(open) sessions ? do we need to

Re: Review Request 39390: LENS-828: Add derived cube validation

2015-11-17 Thread Amareshwari Sriramadasu
tps://reviews.apache.org/r/39390/#comment165653> Let us start the numbers from 3100 or 3500, sothat query errors can be separated from metastore errors? - Amareshwari Sriramadasu On Nov. 10, 2015, 6:54 a.m., Rajat Khandelwal

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Amareshwari Sriramadasu
va/org/apache/lens/cube/parse/TestCubeRewriter.java (line 437) <https://reviews.apache.org/r/39895/#comment165649> Can you share cube query and expected union query in a comment, cannot make much from looking at testcase. - Amareshwari Sriramadasu On Nov. 9, 2015, 9:21 p.m.

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Amareshwari Sriramadasu
> On Nov. 17, 2015, 11:57 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 441 > > <https://reviews.apache.org/r/39895/diff/4/?file=1120739#file1120739line441> > > > > Can

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Amareshwari Sriramadasu
/SingleFactMultiStorageHQLContext.java (line 87) <https://reviews.apache.org/r/39895/#comment165687> Let us do union query writing enabled through a configuration. If not enabled, let us throw exception saying requires a union query and it is disabled. - Amareshwari Sriramadasu On Nov. 17, 2015

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

2015-11-01 Thread Amareshwari Sriramadasu
> On Oct. 25, 2015, 3:40 a.m., Amareshwari Sriramadasu wrote: > > I see the issue is still open, but review request is closed. So, reopened. > > > > Gabor, Do you still see errors on generated doc? > > Raju/Gabor, Is that resulting in build failure in java-8?

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

2015-11-01 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review104675 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 19, 2015

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Amareshwari Sriramadasu
hese changes for? - Amareshwari Sriramadasu On Oct. 30, 2015, 11:24 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39897: LENS-860 : Updating committer documentation

2015-11-03 Thread Amareshwari Sriramadasu
l. To reply, visit: > https://reviews.apache.org/r/39897/ > --- > > (Updated Nov. 3, 2015, 12:28 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Repository: lens > > > Desc

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-11-03 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review105035 --- Can you add unit test? - Amareshwari Sriramadasu On Nov. 3

Re: Review Request 39653: LENS-844: querying a measure with dim attributes not queryable with it gives wrong error

2015-10-30 Thread Amareshwari Sriramadasu
eviews.apache.org/r/39653/#comment162800> returning null ? lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java (line 272) <https://reviews.apache.org/r/39653/#comment162802> system.out ? Can we remove? - Amareshwari Sriramadasu On Oct. 26, 2015,

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

2015-10-30 Thread Amareshwari Sriramadasu
> On Oct. 25, 2015, 3:40 a.m., Amareshwari Sriramadasu wrote: > > I see the issue is still open, but review request is closed. So, reopened. > > > > Gabor, Do you still see errors on generated doc? > > Raju/Gabor, Is that resulting in build failure in java-8?

Re: Review Request 39390: LENS-828: Add derived cube validation

2015-11-05 Thread Amareshwari Sriramadasu
/DerivedCube.java (line 88) <https://reviews.apache.org/r/39390/#comment163929> Can we map the error with 403 error code and put error message in lens-errors.conf ? - Amareshwari Sriramadasu On Oct. 16, 2015, 11:51 a.m., Rajat Khandelwal

Re: Review Request 39897: LENS-860 : Updating committer documentation

2015-11-05 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39897/#review105360 --- Ship it! Ship It! - Amareshwari Sriramadasu On Nov. 4, 2015, 8

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-11-05 Thread Amareshwari Sriramadasu
o lens-errors.conf and add error to LensCommonErrorCode - Amareshwari Sriramadasu On Oct. 31, 2015, 12:24 a.m., Raju Bairishetti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-05 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review105366 --- Ship it! Ship It! - Amareshwari Sriramadasu On Nov. 2, 2015, 9

Re: Review Request 39896: LENS-859 Table component shows loader even if the metastore call fails

2015-11-06 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39896/#review105434 --- Ship it! Ship It! - Amareshwari Sriramadasu On Nov. 3, 2015

Re: Review Request 39894: LENS-858: Fixes no cubes available even when there are.

2015-11-06 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39894/#review105435 --- Ship it! Ship It! - Amareshwari Sriramadasu On Nov. 3, 2015

Re: Review Request 39842: Ability to load different instances of same driver class

2015-11-06 Thread Amareshwari Sriramadasu
trings or enum? - Amareshwari Sriramadasu On Nov. 2, 2015, 4:08 a.m., Puneet Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-04 Thread Amareshwari Sriramadasu
similar code in other methods also. Can be separated into another method ? - Amareshwari Sriramadasu On Nov. 3, 2015, 2 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-04 Thread Amareshwari Sriramadasu
, functions around selected fields (for dimattributes) ? - Amareshwari Sriramadasu On Nov. 3, 2015, 2 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39430: Create a single jar for shipping with hive queries

2015-10-18 Thread Amareshwari Sriramadasu
g/r/39430/#comment160983> Can we include open csv aswell, which is right now coming as transitive dependency from lens-query-lib? - Amareshwari Sriramadasu On Oct. 19, 2015, 4:46 a.m., Srikanth Sundarrajan

Re: Review Request 39394: LENS-830: Checkstyle version should be picked from project version

2015-10-19 Thread Amareshwari Sriramadasu
mvn release:prepare --dry-run works without issues? - Amareshwari Sriramadasu On Oct. 16, 2015, 12:16 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39161: LENS-292 : Query result retention policy

2015-10-19 Thread Amareshwari Sriramadasu
/QueryResultPurger.java (line 74) <https://reviews.apache.org/r/39161/#comment161064> Can we rename variable to QUERY_RESULT_PURGER_ERROR_COUNTER - Amareshwari Sriramadasu On Oct. 19, 2015, 11:33 a.m., Deepak Barr

Review Request 39434: LENS-832 : Fix recovery for Queued queries

2015-10-19 Thread Amareshwari Sriramadasu
/server/api/query/TestAbstractQueryContext.java 44978f2 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 7b15a3c Diff: https://reviews.apache.org/r/39434/diff/ Testing --- Thanks, Amareshwari Sriramadasu

Re: Review Request 39434: LENS-832 : Fix recovery for Queued queries

2015-10-19 Thread Amareshwari Sriramadasu
UTC 2015 [INFO] Final Memory: 187M/1611M [INFO] Thanks, Amareshwari Sriramadasu

Re: Review Request 38920: LENS-797: Improve CLI documentation to mention the helpful role of pressing tab while writing commands

2015-10-07 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38920/#review101870 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 7, 2015

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-08 Thread Amareshwari Sriramadasu
/QueryContext.java (line 429) <https://reviews.apache.org/r/39127/#comment159406> I feel instead of adding this public method, setting priority after deciding would have been better. Can we add a unit test ? - Amareshwari Sriramadasu On Oct. 8, 2015, 1:18 p.m., Rajat Khandelwal

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

2015-10-08 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/#review101900 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 8, 2015

Re: Review Request 39373: LENS-341: Update docs with java8 compatibility

2015-10-15 Thread Amareshwari Sriramadasu
373/#comment160682> This need not be specified in readme. as end users wont generate docs. Specifying this in contribute doc is enough. - Amareshwari Sriramadasu On Oct. 16, 2015, 2:49 a.m., Raju Bairishetti

Re: Review Request 39344: LENS-827:Expression pushdown for query optimisation in JDBC

2015-10-15 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39344/#review102862 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 15, 2015

Re: Review Request 39373: LENS-341: Update docs with java8 compatibility

2015-10-16 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39373/#review102873 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 16, 2015

Re: Review Request 39434: LENS-832 : Fix recovery for Queued queries

2015-10-20 Thread Amareshwari Sriramadasu
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39434/#review103221 --- On Oct. 19, 2015, 10:26 a.m., Amareshwari Sriramadasu wrote: > > --- > This is an

Re: Review Request 39161: LENS-292 : Query result retention policy

2015-10-16 Thread Amareshwari Sriramadasu
test to finish, can we change purge interval to 1 second for test and wait for 2 seconds? - Amareshwari Sriramadasu On Oct. 16, 2015, 7:43 p.m., Deepak Barr wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 39286: LENS-817 : No need to persist metadata class information in DB after LENS-576 fix

2015-10-14 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39286/#review102729 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 13, 2015

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-14 Thread Amareshwari Sriramadasu
> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 451 > > > > > > can you take care of the TODO? > > Gabor Liptak wrote: >

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-14 Thread Amareshwari Sriramadasu
/TestLensQueryCommands.java (line 183) <https://reviews.apache.org/r/39191/#comment160485> Can you reset hive.exec.driver.run.hooks to be empty string? - Amareshwari Sriramadasu On Oct. 14, 2015, 1:30 a.m., Gabor Liptak

Re: Review Request 39311: LENS-820: Add relative end time for facts

2015-10-14 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39311/#review102736 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 14, 2015

Re: Review Request 39315: LENS-821:Filters with comma in IN filters not replacing table alias properly

2015-10-14 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39315/#review102611 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 14, 2015

Re: Review Request 39161: LENS-292 : Query result retention policy

2015-10-14 Thread Amareshwari Sriramadasu
nal results. lens-server/src/main/resources/lensserver-default.xml (line 288) <https://reviews.apache.org/r/39161/#comment160483> Can you update apt files as well? - Amareshwari Sriramadasu On Oc

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-14 Thread Amareshwari Sriramadasu
re of the TODO? > > Gabor Liptak wrote: > Rajat, what is the recommended way to reset this value? This key might or > might not exists, the getConnectionParam() returns a List and there > doesn't seem to be a method to delete a key ... Thanks > > Amareshwari Srirama

Review Request 39221: LENS-533 : Update critical metrics on monitoring doc

2015-10-12 Thread Amareshwari Sriramadasu
/browse/LENS-533 Repository: lens Description --- Added critical metrics section Diffs - src/site/apt/admin/monitoring.apt 9429394 Diff: https://reviews.apache.org/r/39221/diff/ Testing --- Verified by running mvn site:run Thanks, Amareshwari Sriramadasu

Re: Review Request 39233: LENS-816: ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-12 Thread Amareshwari Sriramadasu
/constraint/MaxConcurrentDriverQueriesConstraintTest.java (line 46) <https://reviews.apache.org/r/39233/#comment159833> unnecessary changes? - Amareshwari Sriramadasu On Oct. 12, 2015, 2:48 p.m., Rajat Khandelwal

Review Request 39081: LENS-446 : Remove server params from session and driver configurations

2015-10-07 Thread Amareshwari Sriramadasu
at: Wed Oct 07 11:07:20 UTC 2015 [INFO] Final Memory: 195M/2046M [INFO] Thanks, Amareshwari Sriramadasu

Re: Review Request 39081: LENS-446 : Remove server params from session and driver configurations

2015-10-07 Thread Amareshwari Sriramadasu
drivers should not require any of them. - Amareshwari --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39081/#review101757 ----------- O

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-13 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39127/#review102412 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 12, 2015

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-13 Thread Amareshwari Sriramadasu
/QueryContext.java (line 207) <https://reviews.apache.org/r/39127/#comment160043> Can we avoid opening up the constructor? - Amareshwari Sriramadasu On Oct. 12, 2015, 8:22 a.m., Rajat Khandelwal wrote: > > --- > This is a

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-13 Thread Amareshwari Sriramadasu
/TestLensQueryCommands.java (line 69) <https://reviews.apache.org/r/39191/#comment160035> I think it should be @BeforeTest instead of @BeforeClass - Amareshwari Sriramadasu On Oct. 12, 2015, 11:27 p.m., Gabor Liptak wrote: > > --- > This is a

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

2015-10-06 Thread Amareshwari Sriramadasu
source filter and update version through variable. - Amareshwari Sriramadasu On Oct. 6, 2015, 6:06 a.m., Ankeet Maini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39039: LENS-792: StatusPoller logs are useless

2015-10-06 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39039/#review101618 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 6, 2015, 7

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

2015-10-06 Thread Amareshwari Sriramadasu
> On Oct. 6, 2015, 6:06 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/package.json, line 3 > > <https://reviews.apache.org/r/38758/diff/2/?file=1084763#file1084763line3> > > > > If the version is hardcoded this way, and not reading through

Re: Review Request 39158: LENS-803: Bump version in master to 2.5

2015-10-08 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39158/#review102005 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 9, 2015, 4

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-09 Thread Amareshwari Sriramadasu
/QueryContext.java (line 430) <https://reviews.apache.org/r/39127/#comment159578> Can you update unit test to assert on query context's priority? - Amareshwari Sriramadasu On Oct. 8, 2015, 1:18 p.m., Rajat Khandelwal

Re: Review Request 39131: LENS -750 : Handle SemanticException from HiveDriver instead of throwing 500 Internal Server Error

2015-10-09 Thread Amareshwari Sriramadasu
/HiveDriver.java (line 517) <https://reviews.apache.org/r/39131/#comment159579> Can you do the same changes for explain, estimate, executeAsync? Shall we have handleHiveSQLException method throws proper LensException? - Amareshwari Sriramadasu On Oct. 8, 2015, 1:45 p.m., Deepa

Re: Review Request 39233: LENS-816: ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-12 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39233/#review102385 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 12, 2015

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Amareshwari Sriramadasu
> On Nov. 17, 2015, 4:47 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java, > > line 87 > > <https://reviews.apache.org/r/39895/diff/5/?file=1128492#file1128492line87> > > >

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

2015-08-25 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37346/#review96493 --- Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 21, 2015

Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

2015-08-27 Thread Amareshwari Sriramadasu
what is queue number in driver status? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 618) https://reviews.apache.org/r/37716/#comment152310 why would a launched query have queue number? - Amareshwari Sriramadasu On Aug. 27, 2015, 1:34

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

2015-08-31 Thread Amareshwari Sriramadasu
/QueryExecutionServiceImpl.java (line 487) <https://reviews.apache.org/r/37346/#comment153095> One in-memory result that is not fetched should not block other queries to be purged. Can you check if that can happen? - Amareshwari Sriramadasu On Aug. 27, 2015, 12:47 p.m., Rajat Khandelwal

Re: Review Request 37530: LENS-629 - A new improved web client

2015-08-31 Thread Amareshwari Sriramadasu
> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/package.json, line 12 > > <https://reviews.apache.org/r/37530/diff/2/?file=1041996#file1041996line12> > > > > How are these dependencies downloaded? > > >

Re: Review Request 37530: LENS-629 - A new improved web client

2015-08-31 Thread Amareshwari Sriramadasu
> On Aug. 19, 2015, 5:38 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/app/adapters/AdhocQueryAdapter.js, line 9 > > <https://reviews.apache.org/r/37530/diff/2/?file=1041958#file1041958line9> > > > > Not accepting adhoc queries on dimensions? >

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

2015-09-07 Thread Amareshwari Sriramadasu
of that? - Amareshwari Sriramadasu On Sept. 4, 2015, 2:27 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

2015-09-07 Thread Amareshwari Sriramadasu
> On Sept. 7, 2015, 8:27 a.m., Amareshwari Sriramadasu wrote: > > I dont see the failing test commented. Can you please take care of that? Failing test is not related to the patch, so suggesting to comment testExplainFailure and should be fixed as part of LENS-769 - Am

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-07 Thread Amareshwari Sriramadasu
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java (line 105) <https://reviews.apache.org/r/37934/#comment154002> Please go ahead and remove @localhost, if it needs to be removed. lens-server/src/test/resources/lens-site.xml (lines 141 - 152) <http

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-07 Thread Amareshwari Sriramadasu
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java, > > line 31 > > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-07 Thread Amareshwari Sriramadasu
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java, > > line 31 > > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

2015-09-07 Thread Amareshwari Sriramadasu
/LensStatement.java (lines 148 - 154) <https://reviews.apache.org/r/37648/#comment154039> Remove commented code? - Amareshwari Sriramadasu On Sept. 7, 2015, 4:32 p.m., Sushil Mohanty wrote: > > --- > This is an automatically g

Re: Review Request 37434: LENS-710 : Allow column name mapping for few/all columns in underlying storage tables

2015-09-08 Thread Amareshwari Sriramadasu
at: Thu Aug 13 10:37:33 UTC 2015 [INFO] Final Memory: 193M/1835M [INFO] Thanks, Amareshwari Sriramadasu

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

2015-09-04 Thread Amareshwari Sriramadasu
g/r/37648/#comment153750> Error message construction is not changed to read from LensAPIException here. - Amareshwari Sriramadasu On Sept. 3, 2015, 6:26 a.m., Sushil Mohanty wrote: > > --- > This is an automatically gener

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-09 Thread Amareshwari Sriramadasu
Amruth Sampath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37934/ > --- > > (Updated Sept. 8, 2015, 6:11 p.m.) > > > Review request for l

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-09 Thread Amareshwari Sriramadasu
--- > > (Updated Sept. 8, 2015, 6:11 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat > Khandelwal, and sharad agarwal. > > > Repository: lens > > > Description > --- > > Refer

Re: Review Request 38402: LENS-752 : Support flattening of columns selected through bridge-tables(many-to-many relationships)

2015-09-15 Thread Amareshwari Sriramadasu
/JoinResolver.java (line 582) <https://reviews.apache.org/r/38402/#comment156075> We should make this function configurable and can pass different function names from drivers. - Amareshwari Sriramadasu On Sept. 15, 2015, 12:48 p.m., Amareshwari Sriramadasu

Re: Review Request 38402: LENS-752 : Support flattening of columns selected through bridge-tables(many-to-many relationships)

2015-09-15 Thread Amareshwari Sriramadasu
> On Sept. 15, 2015, 2 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, lines > > 586-587 > > <https://reviews.apache.org/r/38402/diff/1/?file=1073797#file1073797line586> > > > > only null che

Re: Review Request 38402: LENS-752 : Support flattening of columns selected through bridge-tables(many-to-many relationships)

2015-09-15 Thread Amareshwari Sriramadasu
or join to alist. If join needs to be converted to select from a bridge table - it becomes a full fledged query with select, from, groupby, filters and optionally more joins. - Amareshwari --- This is an automatically generated e-

Re: Review Request 38431: LENS-774 : Unable to override "lens.server.session.expiry.service.interval.secs" because of spelling mistake

2015-09-16 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38431/#review99210 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 16, 2015

Re: Review Request 38430: LENS-775 : NPE on closing HadoopFileFormatter

2015-09-16 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38430/#review99212 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 16, 2015

Re: Review Request 38212: LENS-392: Look ahead not working when not all process time partitions on lower granularity are present

2015-09-11 Thread Amareshwari Sriramadasu
yes, then we can remove compareQueries() and these asserts should be sufficient. - Amareshwari Sriramadasu On Sept. 11, 2015, 7:06 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-11 Thread Amareshwari Sriramadasu
ated e-mail. To reply, visit: > https://reviews.apache.org/r/37934/ > --- > > (Updated Sept. 11, 2015, 8:01 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat > Khandelwal, and sharad agarwal. > > > Repository: lens > > > Descr

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-11 Thread Amareshwari Sriramadasu
ove it? > > Amruth Sampath wrote: > There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited > to this. > > Rajat Khandelwal wrote: > syntax error was supposed to be for syntax errors in queries. But now > invalid queries are not accepted so I guess removing should be

Re: Review Request 38212: LENS-392: Look ahead not working when not all process time partitions on lower granularity are present

2015-09-15 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38212/#review99009 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 14, 2015

Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

2015-09-14 Thread Amareshwari Sriramadasu
/QueryExecutionServiceImpl.java (line 618) <https://reviews.apache.org/r/37716/#comment155424> Set queue number as null for launched queries? - Amareshwari Sriramadasu On Sept. 14, 2015, 7:42 a.m., Akshay Goyal

Review Request 38402: LENS-752 : Support flattening of columns selected through bridge-tables(many-to-many relationships)

2015-09-15 Thread Amareshwari Sriramadasu
. Thanks, Amareshwari Sriramadasu

Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

2015-09-14 Thread Amareshwari Sriramadasu
/collect/DefaultQueryCollectionTest.java (line 94) <https://reviews.apache.org/r/37716/#comment155434> Should the name of variable here be 'queuedQuery' ? - Amareshwari Sriramadasu On Sept. 14, 2015, 9:02 a.m., Akshay Goyal

  1   2   3   4   5   6   7   8   9   10   >