Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/100#issuecomment-218874359
+1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/98#issuecomment-218943841
I've updated this PR. Maybe you can check it again @LosD ?
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/101
Removed all deprecated API from MetaModel (ah)
This is a PR for the 5.x branch. I suggest getting rid of all the
deprecated methods of metamodel for that release.
You can merge this
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/102
METAMODEL-241: Fixed
This fix is implemented by further diving deep into the depths of OpenJDK.
I'm not really fond of going down that route, but it seems to be the way to go
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220177537
We could do it in master, but I guess it seems nicer to only do that sort
of thing when it aligns on a bigger release.
---
If your project is set up for it
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220355905
The most recent deprecations where introduced in MM 4.4 AFAIK. Those where
related to the split of FunctionType into AggregateFunction and ScalarFunction
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220359817
I agree Henry, that's why I wanted to put it on the 5.0 branch so that the
expectation is also managed a bit :-)
---
If your project is set up for it
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220440238
I'm not sure I understand what you mean Henry? 5.0 isn't out yet so I guess
no one will be depending on it yet?
---
If your project is set up for i
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220467674
Aha yes... Let's ask that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r64159697
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -31,156 +31,261 @@
* Reader capable of
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r64159744
--- Diff:
fixedwidth/src/test/java/org/apache/metamodel/fixedwidth/FixedWidthConfigurationTest.java
---
@@ -27,18 +27,18 @@
public void
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221043058
I feel a bit like I am missing a unit test for this kind of usage.
An I wonder if that will reveal a slight abstraction issue... The reader
today takes a
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/104#discussion_r64326605
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvDataContext.java ---
@@ -244,7 +227,7 @@ private static File
createFileFromInputStream
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221327239
+0
Code is acceptable from me, but I think it would be better to separate
"parser" from "reader" here. A reader is a stateful
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/106#issuecomment-221905863
+1 from me too.
A side-note: Have anyone checked if the same fix can be applied to e.g.
CouchDB or other data context implementations? I think a
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/106#issuecomment-221906499
Wait what ... Hmm I see that this is actually a fix that works
functionally, but will mean that if you use an alias then the query will not be
optimized at
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/106#issuecomment-19250
Great, +1 from me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/107#discussion_r65733579
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcMetadataLoader.java ---
@@ -92,20 +91,27 @@ public void loadTables(JdbcSchema schema
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/107#discussion_r65733820
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataSet.java ---
@@ -197,8 +197,12 @@ public void close() {
if (_closed
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/107
I read your JIRA issue description, and if you want to reproduce in a
unittest, you _could_ do that in the MySQL integration test maybe?
---
If your project is set up for it, you can
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/107#discussion_r65772935
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataSet.java ---
@@ -197,8 +197,12 @@ public void close() {
if (_closed
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/commit/8e2ff7167eeae456a1e307426407e262dd7297f8#commitcomment-17755108
In
service-webapp/src/main/java/org/apache/metamodel/service/controllers/TenantController.java:
In
service-webapp
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/commit/8e2ff7167eeae456a1e307426407e262dd7297f8#commitcomment-17763797
In
service-webapp/src/main/java/org/apache/metamodel/service/controllers/TenantController.java:
In
service-webapp
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/107
But travis seems to fail somehow now?
```
Tests in error:
MysqlTest.testCompiledQueries:417->AbstractJdbIntegrationTest.getConnection:104
û IllegalState
```
---
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/109#discussion_r66380066
--- Diff: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java ---
@@ -108,7 +108,9 @@ public static Workbook readWorkbook(Resource
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/109#discussion_r66380131
--- Diff: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java ---
@@ -153,20 +155,15 @@ public static Workbook readWorkbook
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/109
-1, I don't think these changes are viable. Please see review remark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/109#discussion_r66380163
--- Diff: full/src/main/java/org/apache/metamodel/DataContextFactory.java
---
@@ -571,6 +571,8 @@ public static UpdateableDataContext
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r66380408
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/104
Sorry for the long wait - I didn't realize that you had changed the branch
since my remark.
+1 and let's merge! :)
---
If your project is set up for it, you can rep
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/108
+1, let's merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r66470815
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/107
It would be nice yes. I know travis has support for various DBs like
CouchDB and so on (which we use). Maybe take a look if MySQL is also there. If
it is, let's make a story
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/107
I doubt that will be too bad. But anyways, will you create the issue, then
you have my LGTM on this PR :)
---
If your project is set up for it, you can reply to this email and have your
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/107
LGTM! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r66738122
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/110
Rest api - MetaModel-as-a-Service - draft application
Hi all,
This is my attempt at building a 'MetaModel-as-a-Service' webapp. Although
it is not yet as great as I
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/110
Seems it has kept your (somewhat old) remarks from the early commits @LosD.
Maybe you can do me a favor and delete them so we can have a fresh view on the
PR? The EOLs where fixed and
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/110
We do not allow UPDATE or INSERT in the query interface. It's literally
just a facade for `DataContext.executeQuery(String)` (which is just for SELECT
queries).
---
If your proje
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/111
Feature/5.x/swagger docs
This is a continuation of #110 which adds a Swagger definition file for the
REST endpoints. I'd like a review of the swagger.yaml file contents p
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/111
No but it has the other branch as it's parent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/111
But commit 0a82d13b19ea0f8aa3aabcd140caaf3274a8e5b4 is the only substantial
piece so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r67372450
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r67560331
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/105
OK let's merge this and maybe some day improve it as per my remarks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/112
Added support for postgresql's "json" and "jsonb" data types -> MAP
Hi all,
Here's a PR that adds MetaModel support for PostgreSQL's JSON
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/113
Dynamic DataContext factory (MM 1099)
This is my attempt at solving METAMODEL-1099. I've leveraged the standard
[ServiceLoader](https://docs.oracle.com/javase/7/docs/api/java
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/113
Ok I'm gonna continue down this path then ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/113
Added a JDBC factory too and fixed a bunch of the TODOs in the code. I
suggest taking the PR as a candidate for merging now as it is quite a lot of
work to make all the factories in one PR
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/113#discussion_r69839313
--- Diff: core/src/main/java/org/apache/metamodel/util/ResourceUtils.java
---
@@ -18,11 +18,31 @@
*/
package org.apache.metamodel.util
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/113#discussion_r70124653
--- Diff: core/src/main/java/org/apache/metamodel/util/ResourceUtils.java
---
@@ -18,11 +18,31 @@
*/
package org.apache.metamodel.util
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/113
Updated the ResourceUtils according to review feedback/discussion - added
javadocs to explain why/when the exception can be expected.
---
If your project is set up for it, you can reply
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/113
OK I will merge it in as per lazy consensus in terms of actual votes cast,
and positive feedback remarks.
---
If your project is set up for it, you can reply to this email and have your
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/110
This branch has now been updated with the new SPI provided in
METAMODEL-1099. Shall we merge this (into 5.x)? Please vote :)
---
If your project is set up for it, you can reply to this
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/112
Fixed unittest, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/114#discussion_r70295666
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthLineParser.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed to
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/114
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/115#discussion_r70456508
--- Diff: core/src/main/java/org/apache/metamodel/util/WildcardPattern.java
---
@@ -32,13 +32,15 @@
public final class WildcardPattern
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/115
I agree that this needs to be fixed and it seems like a good fix. Just a
remark that we should also support empty string operands. Probably worth a
unittest too :)
---
If your project is
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/115
LGTM. And I see you've created an issue for the underscore thing, so let's
merge this. Does _this_ PR have a issue though?
---
If your project is set up for it, you can rep
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/115
Ah, METAMODEL-1103 ... I'll merge then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/112
Merging based on lazy consensus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/116
Fixed File path and URI-based test
This is my suggested fix for METAMODEL-1104
(ResourceFactoryRegsitryImplTest broken on Windows).
You can merge this pull request into a Git repository
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/117
METAMODEL-1106: Added 'INDEX' (and other) keyword(s) to SqlKeywords
Proposed fix for METAMODEL-1106
You can merge this pull request into a Git repository by running:
$ git
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/118
METAMODEL-1099 elasticsearch factories
This PR adds some factories for the two ElasticSearch modules.
You can merge this pull request into a Git repository by running:
$ git pull
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/116
Merging as per lazy concensus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/118
Merging as per lazy concensus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/117
Merging as per lazy concensus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/103
Test failed on Travis, but it seems unrelated.
(Although quite interesting test failure that I'm gonna report into JIRA to
look at.)
---
If your project is set up for it, yo
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/103
+1 from me, let's merge soon so that we get this into the next release -
it's been dangling for too long :)
---
If your project is set up for it, you can reply to this email and
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/111
I'm merging this into the `feature/5.x/rest-api` branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/111
No wait, on second though I have a remark myself ... I don't like that this
PR bundles all of swagger-ui into the source code tree. It would be much better
to just download swagger
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/111
Closing this and #110 in order to create a new PR without all the
commit-bound remarks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/110
Closing this and #111 in order to create a new PR without all the
commit-bound remarks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kaspersorensen closed the pull request at:
https://github.com/apache/metamodel/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user kaspersorensen closed the pull request at:
https://github.com/apache/metamodel/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/119
RESTful MetaModel
Again an attempt to post a PR for a completely new webapp that offers
MetaModel as a RESTful API.
Previously posted as #110 and #111
You can merge this pull
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/119
Argh ... The old remarks are still being added. I will make a diff and make
a new single-commit branch.
---
If your project is set up for it, you can reply to this email and have your
Github user kaspersorensen closed the pull request at:
https://github.com/apache/metamodel/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/120
RESTful MetaModel service-webapp
Squashed all the commits of #110 and #111 to get the long review history
cleared.
You can merge this pull request into a Git repository by running
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r73817859
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -43,6 +47,7 @@
private final boolean
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/123
I wonder if this rule applies to all String-based data types in Oracle. Do
we have any documentation to back it up? I could find references of this
anomaly for `VARCHAR` and `VARCHAR2`, so
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/123
OK, let's merge this then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r74183535
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/EbcdicReader.java ---
@@ -26,13 +26,17 @@
*/
class EbcdicReader
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r74330944
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/EbcdicReader.java ---
@@ -26,13 +26,17 @@
*/
class EbcdicReader
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/124#discussion_r74863473
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java
---
@@ -116,6 +116,14 @@ public String
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/124
Hi Harris,
We will do it as quickly as possible, but not quicker than allowing us to
vet the change properly :-) And I would guess that you also would need us to
release the fix
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/124#discussion_r75043572
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java
---
@@ -116,6 +116,14 @@ public String
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/125
LGTM!
(ouch what a lame bug - I feel a bit silly for probably being the one who
introduced it)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/126
The build failure is unrelated and strange. The code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/127#discussion_r76639933
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java ---
@@ -58,6 +58,8 @@
KEYWORDS.add("D
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/127#discussion_r76874584
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java ---
@@ -58,6 +58,8 @@
KEYWORDS.add("D
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/128
Demonstrated issue with AVG function and fixed/adapted in JDBC module
I was looking at METAMODEL-193 because I found it a bit strange that it was
reported that e.g. `AVG(an-integer-column
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/128
Do you mean "not always a double type" (instead of integer)? Or else I
don't understand what you're saying?
Are you simply saying that "this is the rule of
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/129
Ouch, yes. LGTM. Would be good to have a small unittest (and that would be
easy to make here) though.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/128
Hmm it seems to me that it is just "a rule" but not always "the right
rule". For instance, MongoDB seems to return decimals when needed [1] which I
would personally
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/128
Hmm, so it appears to me that there are pros and cons of either way of
thinking about it. I am trying to juggle a few concerns: (1) consistency within
MetaModel and (2) meeting users
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/120
I've made a couple of changes to this PR today and to make it easier for
people to review the webapp not just from a code perspective, but also from a
user perspective, I've pu
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/129
Yes, let's merge this. If anyone also feels like making a tiny unittest
just to confirm the copyFilterItem behaviour I would applaude it :)
---
If your project is set up for it, yo
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/130
Added primary key lookup optimization for Apache Cassandra module
I think the PR title says it all ... I was working a bit with Cassandra and
found that it was easy (and really missing
1 - 100 of 806 matches
Mail list logo
