Re: [DISCUSS] Guideline for "professional support" Mentioning on Homepage

2020-01-26 Thread Justin Mclean
Hi, > as Lukas just opened up a discussion about mentioning commercial support on > the (new) PLC4X Homepage. > One Example where this is done is Apache Druid > (https://druid.apache.org/community/ see Getting Help). I dislike the Druid example as it shows who the committers are working for, t

Re: [DISCUSS] Guideline for "professional support" Mentioning on Homepage

2020-01-26 Thread Justin Mclean
Hi, See [1] and in particular [2]. Note also how druid is not in line with [3] Thanks, Justin 1. https://www.apache.org/foundation/marks/linking#projectthanks 2. https://www.apache.org/foundation/marks/linking#productsupport 3. https://www.apache.org/foundation/marks/linking#whoweare

Re: [VOTE] Apache PLC4X 0.6.0 RC2

2020-02-11 Thread Justin Mclean
Hi, Sorry but’s it -1 due to license. notice and licensing issues. May need a little discussion to sort out. I checked: - signatures and checksum fine - NOTICE mentions “This product includes software developed at The Milo project (https://github.com/eclipse/milo).” Why is this here? What cod

Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Justin Mclean
Hi, > However for the ConfigKeys and Config classes I think we could simply change > the header. If the contributors agree then you can change the headers, but this is not the major issue here, I’m more concerned by the Milo one. > As Dominik, from whom most of that code came in via PR, is no

Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Justin Mclean
Hi, > I just had a look ... I couldn't find any code taken from the Milo project. > All I found was usage of milo libraries. > So as we are releasing sources, do we have to mention the Milo project in the > NOTICE at all? N you do not. Thanks, Justin

Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Justin Mclean
Hi, > Do you still keep your -1 Justin under these circumstances? I can change my vote to a +1 (my -1 is not a veto btw) if you as release manager want to release this. If you prefer to fix the issues and make another RC that also fine by me, what do you want? Thanks,. Justin

Re: [GERMAN] PLC4X Webinar

2020-03-31 Thread Justin Mclean
Hi, > rather English Webinar (perhaps we have tot hink about timezones). > English subtitle on live video will be tough... don’t know if anybody here > can type that fast : D Well I’ve given talks that have been simultaneous;ly translated into another language live so it is possible. Thanks, J

Re: Add a list of companies using PLC4X without links back?

2020-05-01 Thread Justin Mclean
HI, > [1] https://github.com/apache/airflow#who-uses-apache-airflow Which as far as I can see doesn’t follow ASF policy - links need to be no-follow for starters. Thanks, Justin

Re: Add a list of companies using PLC4X without links back?

2020-05-01 Thread Justin Mclean
Hi, > Can you point to that policy? See [1] also see recent conversation re shardingshpere and trademarks/branding. Thanks, Justin 1. https://www.apache.org/foundation/marks/linking#projectthanks

Re: Add a list of companies using PLC4X without links back?

2020-05-01 Thread Justin Mclean
Hi, > But the text in the link actually says you have to be consistent ... not that > all links have to be no-follow. You need to rad elsewhere - see also this [1] Justin 1. https://lists.apache.org/thread.html/r68df1ac8c2895071ca81e5183ad181891c98bbe1e379488653568327%40%3Cprivate.incubator.a

Re: Add a list of companies using PLC4X without links back?

2020-05-01 Thread Justin Mclean
HI, > It would really make sense to have this documented somewhere where everyone > can read it. I believe it on trademarks list to do. Thanks, Justin

Re: [VOTE] Apache PLC4X 0.7.0 RC2

2020-05-20 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes are fine - LICENSE and NOTICE are good - All source files have ASF headers - No unexpected binary files - Can compile from source Thanks, Justin

Re: [RESULT] [VOTE] Apache PLC4X 0.7.0 RC2

2020-05-24 Thread Justin Mclean
Hi, Congrats on the releases. > Also I would like to thank Otto for that -1 for RC1. I know that voting -1 > sometimes requires overcoming but it's important. > I would also like to encourage others to vote -1 if you really feel the need > to do so. Welcome to the club Otto :-) Thanks, Justin

Re: [DISCUSS] Users page

2020-05-26 Thread Justin Mclean
Hi, Looks fine to me. Thanks, Justin

Re: [VOTE] Rename our "master" branch to "release"

2020-06-29 Thread Justin Mclean
+1 a much better description of that branch

Re: [GitHub] [plc4x] chrisdutz merged pull request #223: Updated Notice and License files.

2021-01-16 Thread Justin Mclean
Hi, I’ve nt taken a deep look at this but EPL licensed code isn’t allowed in a source release. [1] Thanks, Justin 1. https://www.apache.org/legal/resolved.html#weak-copyleft-licenses

Re: [VOTE] Apache PLC4X 0.9.0 RC2

2021-09-19 Thread Justin Mclean
Hi +1 (binding) I checked; - signatures and hashes are fine - LICENSE and NOTICE are good - No unexpected binary files - Source files have ASF headers - Can compile from source I also checked the download page links and all good. I think the README ned to be updated re versions of java you need

Re: Sebastian Rühl having troubles to create his Apache ID

2017-12-21 Thread Justin Mclean
Hi, I’ve sent an email off that should sort it out - it may take a fews days given the holiday period. Thanks, Justin

Re: Grant permissions to transition Jira issues

2017-12-21 Thread Justin Mclean
Hi, What’s your JIRA user name? Thanks, Justin

Re: No access to gitbox repo

2017-12-21 Thread Justin Mclean
Hi, Have you sent in you ICLA yet? Until you have a signed ICLA and an apache user name mentors can’t add you to the project. Thanks, Justin

Re: Who moderates private@p.a.o?

2017-12-21 Thread Justin Mclean
HI, Both Chris and I are currently moderators. Does anyone else on the PPMC want to be a moderator for that list and the others? Thanks, Justin

Re: No access to gitbox repo

2017-12-21 Thread Justin Mclean
Hi, Ah no need as you already have :-) It’s been fixed and you shovel be able to the commit now. Thanks, Justin

Re: Who moderates private@p.a.o?

2017-12-23 Thread Justin Mclean
Hi, > I can give a helping hand here. Thanks I’ve sent a request off. Thanks, Justin

Re: Grant permissions to transition Jira issues

2017-12-23 Thread Justin Mclean
Hi, > User name is britter. Done. Tell me if you run into any issues. Thanks, Justin

Re: [SCALA-API] Scala API branch pushed to gitbox repo

2017-12-23 Thread Justin Mclean
Hi, > I don’t think we have agreed on how to work with git yet. Do we want to > rebase the branch thereby potentially breaking peoples working copies or do > we simply merge master to the PLC4X-12 branch? Some projects do use rebase but there are some concerns raised at the ASF that history ca

PLC4X mentors

2017-12-23 Thread Justin Mclean
Hi, Can any of the mentors of the project who hasn’t please sign up to the dev and private lists. As a mailing list moderator I can add you manually but I don’t know what your preferred email address is. Thanks, Justin

PLC4X mentors

2017-12-23 Thread Justin Mclean
Hi, Can any of the mentors of the project who hasn’t please sign up to the dev and private lists. As a mailing list moderator I can add you manually but I don’t know what your preferred email address is. Thanks, Justin

S7 parameter and types unit tests

2017-12-23 Thread Justin Mclean
HI, I’ve just added some unit tests for the S7 parameters and types. Not checked in yet as I’m not somewhere with phone reception so setting up 2FA is a little hard. Just wondering if it’s worth the effort with the S7 types to check every enum value or just a couple to get the code coverage?

Re: Including AL 2.0 content?

2017-12-26 Thread Justin Mclean
Hi, > I was able to override this, by copying the original template from here: > https://github.com/andriusvelykis/reflow-maven-skin/blob/master/reflow-maven-skin/src/main/resources/META-INF/maven/site.vm > > To here: > https://gitbox.apache.org/repos/asf?p=incubator-plc4x.git;a=blob;f=src/site/t

New unit tests

2017-12-26 Thread Justin Mclean
Hi, Just checked in a few unit tests -nothing to existing mostly just for coverage, but I did discover 2 minor issues which I corrected [1][2]. If I’ve done anything wrong please feel free to modify, fix or revert if needed. Thanks, Justin 1. https://github.com/apache/incubator-plc4x/commit/a

Re: S7 parameter and types unit tests

2017-12-26 Thread Justin Mclean
Hi, > I’m a little bit lost. Can you provide some more context? Which class / > package are you referring to? I’ve just checked in some unit tests that should make it clearer take a look at this file [1] for instance. Thanks, Justin PS I currently only have a few hours of slow internet acces

decodeData in Plc4xS7Protocol

2017-12-27 Thread Justin Mclean
Hi, Looking at decodeData in Plc4XS7Protocol I’m not sure that it would work in that the for loop is increasing “i" but “i" is also modified in the body of the loop by the size of the datatype. Seems by a casual glance that each datatype is one byte too large? Also any reason why all the metho

Re: [DRAFT] First Podling Report PLC4X

2017-12-29 Thread Justin Mclean
Hi, Looking good to me there’a couple of things I would add. I’d add “Make our first release” as a point under "Most important issues to address while moving towards graduation” > Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: > > * Still not all members of the in

IsoTPProtocol tests

2017-12-29 Thread Justin Mclean
Hi, I just checked in some IsoTPProtocol tests and notice that he header size was off in one case. [1] Someone mind double checking for me as I’m not familiar with the protocol and was just going with what was in the code. Thanks, Justin 1. https://github.com/apache/incubator-plc4x/commit/290

Welcome PPMC members

2017-12-29 Thread Justin Mclean
] should also be of help. If you have any other questions about how the ASF works please ask on the dev list and one of the mentors or other ASF members will answer any questions you have. Welcome aboard! Justin Mclean (as PLC4X mentor) 1. http://www.apache.org/foundation/how-it-works.html 2. http

Re: [DRAFT] First Podling Report PLC4X

2017-12-29 Thread Justin Mclean
Hi, I’d also add that the software grant was submitted. Thanks, Justin

Re: Interest in a code-retreat architecture round, kickoff type of thing?

2017-12-30 Thread Justin Mclean
Hi, Great idea and I’m interested but it’s a long way to go and I’ll need a little more in the bank before eI could commit to it. :-) (However I may be able to make it on frequent flyer points depending on when it is.) Thanks, Justin

Re: [DRAFT] First Podling Report PLC4X

2017-12-30 Thread Justin Mclean
Hi, Looks good to me. It can be submitted here [1] (although only members and officials have access to do so) Thanks, Justin 1. https://whimsy.apache.org/board/agenda/2018-01-17/

Re: [DRAFT] First Podling Report PLC4X

2017-12-31 Thread Justin Mclean
Hi, Ah sorry my mistake only TLP currently use whimsy. It needs to be added here. [1] Infra seems to be having a few DNS issues at the moment I’ll submit when I get a chance later today. We have a few days before it needs to be submitted anywhere. Thanks, Justin 1. https://wiki.apache.org/i

IsoTPProtocol un-accessed private properties

2018-01-04 Thread Justin Mclean
Hi, IsoTPProtocol has these properties: private CalledTsapParameter calledTsapParameter; private TpduSizeParameter tpduSizeParameter; They are assigned but not accessed and could be local vars rather than fields. Is there any reason for that? I assume the code just not been completed yet? Than

Re: IsoTPProtocol un-accessed private properties

2018-01-05 Thread Justin Mclean
Hi, > They will be needed, I just haven't implemented that. All good. A suggestion perhaps a few TODO’s in the code where things are missing would help? Thanks, Justin

Re: Coverage reports

2018-01-05 Thread Justin Mclean
Hi, I've see you changed it so that running locally no longer works and it’s publishing to Apache builds. That’s great but how would I test my changes and run sonar locally before having to commit changes? Thanks, Justin

Re: Coverage reports

2018-01-06 Thread Justin Mclean
Hi, > clean install sonar:sonar -Dsonar.host.url=http://localhost:9000/ All good working for me as well. Thanks, Justin

parameter rack and slot encoding

2018-01-07 Thread Justin Mclean
Hi, Was just writing a test for parameter enough and notice an issue (sonar cube thought something was up as well): This line in IsoTPProtocol: out.writeByte((byte) ((tsap.getRackNumber() << 4) | (tsap.getSlotNumber(; I think should be: out.writeByte((byte) ((tsap.getRackNumber() << 4) | (t

Re: [incubator-plc4x] 06/06: Sort divided by a int is always an int no need to round up with Math.ceil

2018-01-07 Thread Justin Mclean
Hi, With this change here: > DataTransportSize dataTransportSize = > DataTransportSize.valueOf(userData.readByte()); > short length = (dataTransportSize.isSizeInBits()) ? > -(short) Math.ceil(userData.readShort() / 8) :

Re: parameter rack and slot encoding

2018-01-08 Thread Justin Mclean
Hi, > I was also thinking of changing the method signatures to int to avoid all the > casting needed when using the API. When doing that I would have provided some > Assertions that check the parameter values. May be a good idea to also do that with bytes (i.e. change to ints, mask and/or ass

Re: Coverage reports

2018-01-08 Thread Justin Mclean
Hi, > Also it would be helpful if DEVELOPMENT.md were updated to capture the “how > to run sonar locally” info below. I you use intelliJ you can use the sonar lint plugin, eclipse may have a similar plug in I’m not sure. To run sonar locally (if you just want occasional use) it just a matter o

Re: [incubator-plc4x] 06/06: Sort divided by a int is always an int no need to round up with Math.ceil

2018-01-08 Thread Justin Mclean
Hi, Ping? Justin

Re: [incubator-plc4x] 06/06: Sort divided by a int is always an int no need to round up with Math.ceil

2018-01-09 Thread Justin Mclean
Hi, > you are correct with your assumption. However as soon as at least one > floating point number is used in the equation, the result should be too, so > it should be enough to make 8 an 8.0 So this what I was thinking: (short) Math.ceil(userData.readShort() / 8.0) Thanks, Justin

Re: Using Github and Pull Requests

2018-01-09 Thread Justin Mclean
Hi, > Note if PLC4X were setup to have its GitHub repo as its main repo, not this > non-writeable mirror thing, merging a PR would involve a committer just > pushing the PR’s merge button. Also we could use Github Issues. With the current set up we can do both those things i.e. merge PRs and u

Re: [incubator-plc4x] 02/02: Add support for Stings

2018-01-09 Thread Justin Mclean
Hi, Strings not stings :-) But there is an sting in the tail here in that it’s only really going to work for a single string. If multiple strings are passed I think we would need to come up with some sort of terminating character so that the byte array can be broken up into multiple strings. W

Re: [incubator-plc4x] 02/02: Add support for Stings

2018-01-09 Thread Justin Mclean
Hi, And I just committed an implementation that uses a nul character to seperate the strings. May be a better way of doing this - feedback welcome. Thanks, Justin

null Tpdu codes

2018-01-13 Thread Justin Mclean
Hi, In writing a couple of bad code code I found that the the existing code would NPE when doing switch of a TdpuCode of null. In order to get around this I add a new enum of UNKNOWN and now have valueOF return that instead of null if the tpdu code is not in the enum map. Anyone think this is n

Re: [incubator-plc4x] branch master updated: Added missing Apache header

2018-01-15 Thread Justin Mclean
Hi, Whoops my fault.. Sorry about forgetting that and thanks for fixing it. Justin > On 15 Jan 2018, at 7:21 pm, cd...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > cdutz pushed a commit to branch master > in repository https://gitbox.apache.org/

Re: Interesting feedback from a potential user

2018-01-16 Thread Justin Mclean
Hi, > Also, it would be good if someone more familiar with reading legal texts > could have a look at the copyright notice at the bottom of this page (also > the root of the protocol spec): > https://infosys.beckhoff.com/english.php?content=../content/1033/tcadsamsspec/html/tcadsamsspec_intro.

Re: Interesting feedback from a potential user

2018-01-17 Thread Justin Mclean
Hi, > By the way … the link to ethercat. This is a different protocol. It’s more a > real-time protocol where the PLC communicates with Drives, IOs and stuff like > that. No problem I was just looking at random links. > I just contacted Beckhoff and simply asked them what we have to do in ord

Re: RawSockets

2018-01-21 Thread Justin Mclean
Hi, > Pcap4j is licensed with a MIT license: > https://github.com/kaitoy/pcap4j/#license Pcap4j is MIT with bit of BSD and Apache 2.0 all good. (And their logo is CC-BY-4.0 also ok) > So, I guess we can use that. As the library requires libpcap, the license of > that is the 3-clause BSD: > htt

Re: Interesting feedback from a potential user

2018-01-24 Thread Justin Mclean
Hi, > Hey, bringing OpenSource to PLC is a great idea, but there is no reason to > use Java to do it. There are lots of great OpenSource .NET software products > out there. > > I think it would make much more sense to start this whole project in Mono if > .NET itself is for some reason on the

Re: Is Junit5 the way to go?

2018-01-26 Thread Justin Mclean
Hi, > yesterday I had to jump quite a number of hoops in order to update the poms > because of the not really production ready support for Junit 5. > Also I recall that Dale had problems with Junit 5 tests in Eclipse. I also had issues setting it up but once it was working it seemed fine. > My

Re: Is Junit5 the way to go?

2018-01-26 Thread Justin Mclean
Hi, > Well the one thing I like with TestNG is the support for parametrized tests. > With JUnit 4 this sucks greatly and it very easy with TestNG. I do think that > we need parametrized tests as we do have a lot of options to test. There are some existing parametrised tests and I've used it in

Re: List of supporters on our website?

2018-02-02 Thread Justin Mclean
Hi, Care certainally needs to be taken but I think Chris is suggesting more of a product support page. [1] Thanks, Justin 1. http://www.apache.org/foundation/marks/linking#productsupport

Re: List of supporters on our website?

2018-02-02 Thread Justin Mclean
Hi, Either way the PPMC can review, provide feedback on, modify etc etc before it goes live. "Must not be advertisements” is the main thing. Thanks, Justin

Re: [VOTE] Switch to JUnit 4 as testing framework

2018-02-08 Thread Justin Mclean
Hi, Given the issues we’re currently seeing with Junit5 I’m +1 on this. But that doesn’t mean we can’t revisit in the future once it’s kinks are worked out. Thanks, Justin

Re: Is Junit5 the way to go?

2018-02-08 Thread Justin Mclean
Hi, BTW any reason you use assertThat form AssertJ rather than the one built into Junit 4? Just curious no strong views either way. You might want to fix a couple of your assertThat’s for instance this: assertThat(tpdu.getTpduCode() == TpduCode.CONNECTION_REQUEST); Isn’t probably doing what yo

Re: Is Junit5 the way to go?

2018-02-08 Thread Justin Mclean
…but it does make for a good test passing rate :-)

Re: Is Junit5 the way to go?

2018-02-09 Thread Justin Mclean
Hi, > thanks for finding that ... guess when porting all these thousands of > statements, I must have missed one or two "replace: ' == ' with > ').isEqualTo('” __ Yep I can imaging my brain zoning out when doing that :-) > Well the main reason was probably, that I wanted to replace the > "ass

Re: [DISCUSS] What assertion mechanism to use: JUnit, AssertJ or Hamcrest

2018-02-12 Thread Justin Mclean
Hi, > Even if I like the way AssertJ handles exceptions a bit more than the > Hamcrest way, I never was particularly fond of never-ending fluent > expressions. So I would opt for the Hamcrest version. No strong view either way as any tests are good to have :-) But I have used Hamcrest in the p

Does this seem odd to you?

2018-02-16 Thread Justin Mclean
Hi, It's a very minor thing I know but I just came access this: public static TpduSize valueForGivenSize(int pduSize) { if(pduSize < 0) { throw new IllegalArgumentException("PduSize has to be greater than 0"); } assert pduSize > 0; And have a few questions: -

WET vs DRY tests

2018-02-19 Thread Justin Mclean
Hi, Was just looking at some of the new tests and just wondering if they are trying to be a bit too clever? What do other people think? For instance this: @Test public void testOfWintime() throws Exception { assumeThat(clazz, isOneOf(TimeStamp.class)); { Method ofMethod = clazz.

tests and coverage

2018-02-19 Thread Justin Mclean
Hi, It looks to me that some of the tests are just here to increase coverage and we seem to be missing unit test for some of the more simple classes. Perhaps there’s a bit too much focus on the happy path and we’re not always checking boundary conditions and the like. Obviously this is a good s

Re: WET vs DRY tests

2018-02-19 Thread Justin Mclean
Hi, > Have to agree that I am having problems to understand what the thing does. > But that might be related to me not having had my first coffee if the day yet > ;-) Once you look at the code it’s testing it become clearer but the mental effort required seem a bit high for a simple test. Othe

Re: [incubator-plc4x] branch master updated: Fix the ByteValueTest

2018-02-21 Thread Justin Mclean
Hi, Perhaps my email wasn’t clear. The error is not in the test the error is in the code the test was showing that. :-) Thanks, Justin > On 22 Feb 2018, at 1:55 am, cd...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > cdutz pushed a commit to bra

Re: [incubator-plc4x] branch master updated: Fix the ByteValueTest

2018-02-22 Thread Justin Mclean
Hi, > Ok ... if the max value is outside the bounds and the code should have thrown > an error, then I apologize. No issue. Looking again at it I’m still not sure which bit or code or test is wrong or perhaps neither(?) but I think it should be consistent. Perhaps Sebastian has a better idea?

Re: tests and coverage

2018-02-22 Thread Justin Mclean
Hi, > I don’t think its a issue of focus rather than time and resources (at least > in my case) Fair enough and as I said we have tests (with reasonable coverage) and that's a good thing. > My intention was to bring the ADS branch to master a soon as possible to > encourage contribution (see

Re: [incubator-plc4x] branch master updated: Fix the ByteValueTest

2018-02-22 Thread Justin Mclean
Hi, > I extended the test with duplicated hex variants to better visualize the > boundaries: > @Test > public void checkUnsignedBoundsLongHex() { >// Hex representation to visualize valid bounds in bytes >ByteValue.checkUnsignedBounds(0x0_00_00, 2); >ByteValue.checkUnsignedBounds(0x0_

Re: 235 warnings

2018-02-24 Thread Justin Mclean
Hi, > On the current “master” branch, Eclipse 4.6.3 (with std Error/Warning > preference config) and java 1.8.0_161, Eclipse reports 235 warnings. The bulk > of these seem to be Raw type and Type safety warnings. Are there plans for > dealing with these? I guess you are project the only perso

Re: 235 warnings

2018-02-26 Thread Justin Mclean
Hi, > Sonar[1] reports 158 code smells but those don’t seem to include any of the > categories of the 235 noted below. Not sure what to make of that. It could be that some rules have been turned off? I’m also seeing some sonar cube one that are legitimate issues but nothing too serious. Some o

Re: 235 warnings

2018-02-26 Thread Justin Mclean
Hi, > I'd be inclined to do a bunch of the cleanup myself if I had some degree of > confidence that the project was committed to their elimination. A project > policy of not delivering code that adds more is sufficient IMO (not sure > tooling enforcement is necessary). Can IntelliJ be configur

Re: [DRAFT] February Podling Report PLC4X

2018-03-06 Thread Justin Mclean
Hi, Look good to me. Justin

Re: [DISCUSS] Thinking of a first release?

2018-03-06 Thread Justin Mclean
Hi, > not having implemented the PDU Fragmentation will cause problems with the > driver in real world scenarios (more than 15 addresses requested form the plc) How often would a user run into this in the real world? If that that frequent we may not need it for a 0.1 (or whatever we name it) r

Re: Podling Report Reminder - March 2018

2018-03-11 Thread Justin Mclean
Hi, > So just in case it wasn't submitted, this is the text that should have been > submitted Sorry I told Chis I was going to submit it and it fell off my plate, it’s submitted now. If the other Mentors could sign off on it that would be great. Thanks, Justin

Re: My Edgent and PLC4X Article on the Cover-Page

2018-03-23 Thread Justin Mclean
Hi, > today I bought the magazine with my Article and was totally amazed that it > has become one of the cover-page articles :-) They didn’t send you a free copy? :-) Congratulations, well done and keep up the good work, any chance of an english translation? Thanks, Justin

Re: [DRAFT] March Podling Report PLC4X

2018-04-04 Thread Justin Mclean
Hi, Yep I’ve been following along as well :-) Justin

Re: Test-Setup

2018-04-17 Thread Justin Mclean
Hi, Sound like a great idea to me. Thanks, Justin

Re: VPN access to PLC

2018-05-12 Thread Justin Mclean
Hi, > If you are interested in getting an account please respond to this thread. > I’ll order the accounts some time at the beginning of next week. Count me in! Justin

Re: [DRAFT] July Podling Report Apache PLC4X (incubating)

2018-06-28 Thread Justin Mclean
Looks good to me > On 29 Jun 2018, at 12:45 am, Christofer Dutz > wrote: > > Hope I didn’t miss anything … also hope this time I didn’t put in things the > board isn’t interested in. > > > --- > > Apache PLC

Re: Refactoring the PLC4X Subscription API?

2018-07-06 Thread Justin Mclean
Go for it On Fri., 6 Jul. 2018, 7:43 pm Christofer Dutz, wrote: > Ok, > > > > I am interpreting the silence as consent and will do the changes I > proposed. > > > > Chris > > > > > > Am 03.07.18, 13:57 schrieb "Christofer Dutz" : > > > > Hi all, > > > > now digging into the subscription

Re: Code-Retreat on Mallorca?

2018-08-02 Thread Justin Mclean
Hi, Can’t promise I’m make it at this point (given it’s the other side of the world) but it sounds like a fun idea. Thanks, Justin

Re: [VOTE] Change the format of the S7 Adresses

2018-08-07 Thread Justin Mclean
Hi, +1 I think lazy consensus could of work find here and there no need for a vote, but as it was called it seems a good idea to me. Thanks, Justin

Making your first release

2018-08-25 Thread Justin Mclean
Hi, While looking through the incubator reports it’s come to my attention that this podling hasn’t made a release yet and has been in the incubator for 250+ days. "Release early and release often” should be the guideline to follow. What is holding up this project making it first release? Remem

Re: ASF Slack

2018-08-28 Thread Justin Mclean
I could be mistaken but I think anyone can join or be invited On Wed., 29 Aug. 2018, 8:41 am Julian Feinauer, < j.feina...@pragmaticminds.de> wrote: > Hi Benedikt, > > > > I think ist a good idea to have a slack for communication but I agree that > its a bit inelegant to require an apache email a

Re: Recent additions to PLC4X (Goolge IoT cloud Example, Kafka-Connect integration, Test-Driver)

2018-09-07 Thread Justin Mclean
Hi, > Thank you two very much for these great additions. As Veronika and Andrey > both work for codecentric, they did this during their work hours and we have > a signed CCLA, I think there is no need for any ICLA signing on her side (is > that correct?) CCLA is more for the company not the co

Re: (PGP Key Signing) Re: Meetup in Nürtingen on 20.09.2018

2018-09-18 Thread Justin Mclean
Hi, > And I just noticed, when writing the release-documentation we should do > a PGP Keysigning session at the meetup. Good idea. > Apache Releases are built around PGP keys. However currently I would be the > only one able to do a release as I'm the only one who has a key signed by > o

Re: [DISCUSS] Apache PLC4X (Incubating) 0.1.0

2018-09-23 Thread Justin Mclean
Hi, Well strictly speaking it’s only the incubator PMC vote that are binding as you vote on it here first and then the IPMC votes on it. Once you graduate then there’s the PMC votes are binding. Thanks, Justin

Re: [VOTE] Apache PLC4X (Incubating) 0.1.0 RC2

2018-09-23 Thread Justin Mclean
Hi, +1 (binding) IMO There’s some license/notice issues that need to be fixed for the next release. I checked: - incubating in name - signatures and hashes good - DISCLAIMER exists - LICENSE and NOTICE need some work (see below) - No unexpected binary fines - All source files have ASF headers -

Re: [DISCUSS] Apache PLC4X (Incubating) 0.1.0

2018-09-24 Thread Justin Mclean
HI, > * do the RELEASE_NOTES require an incubation disclaimer? No that should be in DISCLAIMER and on the website, having it there as well wouldn’t hurt but it’s not required. Thanks, Justin

Re: [DISCUSS] Apache PLC4X (Incubating) 0.1.0

2018-09-24 Thread Justin Mclean
Hi, > * It looks as if plc4x-parent-0.1.0-rc2 was the git tag for the RC as it > matches the source zip (which misses the .gitignore but includes an > extra DEPDENDENCIES file, BTW). The name looks a little strange, is > this going to be "fixed" for the final release? As tags change be changed

Missing board report

2018-09-30 Thread Justin Mclean
Hi, The incubator PMC would appreciated if you could complete the podling report on time. It takes time to prepare the incubator report, have your mentors sign off the report and for the board to review it, in order for all that to happen the report is due on Wednesday. Thanks, Justin

Re: Missing board report

2018-09-30 Thread Justin Mclean
Dutz" : > > Yup ... I'm on it ... > > Just wanted to have the first release out the door and other things > done first. > Will take care of this in the next one or two days. > > Chris > > Am 30.09.18, 15:36 schrieb "Justin Mclean&qu

Re: [DRAFT] Oktober Podling Report Apache PLC4X (incubating)

2018-10-01 Thread Justin Mclean
Hi, All good by me, a couple of (very) minor things below. > Make our first release You done this so no need to list it? > While the community activity had been quite low since the beginning of the > project, things changed in August. > Then we noticed not only new names appearing on the list,

  1   2   >