Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/93#discussion_r95596711
--- Diff: proton-c/bindings/python/proton/utils.py ---
@@ -132,10 +132,12 @@ def __init__(self, connection, receiver, fetcher,
credit=1
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-dispatch/pull/138
Pre proactor cleanup
Purely clean-up: deleting dead code and making needlessly public
declarations more private to simplify replacing the existing driver with the
proton proactor.
You
Github user alanconway commented on the issue:
https://github.com/apache/qpid-dispatch/pull/138
Needs more testing, seeing some failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user alanconway commented on the issue:
https://github.com/apache/qpid-dispatch/pull/138
Fixed, had deleted on function called from python.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/101
Ship It! Wow, that's an obscure bug found by obscure means.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/101
Disagree. IMO it is good design for all return values of a failing call to
be set to known failure indicators provided a) there are such indicators, b)
it is not costly to do so, and c
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/a61f50e94ceb74ed81665192e1d3051ec8be0208#commitcomment-22036781
DOH! Embarassing. Fixed now on master.
---
If your project is set up for it, you can reply to this email and have your
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/105#discussion_r118509113
--- Diff: proton-c/bindings/cpp/src/handler.cpp ---
@@ -49,17 +50,33 @@ void messaging_handler::on_transport_error(transport
&t) { on_error(t.e
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/105
I'm still happy with this. I have some ideas about simplifying the
returned<>/thread_safe<> story but lets get this up on master as a starting
point.
---
If your project
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126156980
--- Diff: src/buffer.c ---
@@ -83,7 +86,28 @@ size_t qd_buffer_size(qd_buffer_t *buf)
void qd_buffer_insert(qd_buffer_t *buf, size_t len
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126155671
--- Diff: include/qpid/dispatch/buffer.h ---
@@ -32,10 +32,14 @@ typedef struct qd_buffer_t qd_buffer_t;
DEQ_DECLARE(qd_buffer_t
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126160704
--- Diff: src/message.c ---
@@ -975,11 +990,94 @@ void qd_message_set_ingress_annotation(qd_message_t
*in_msg, qd_composed_field_t
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126170901
--- Diff: src/message.c ---
@@ -1151,89 +1287,140 @@ void qd_message_send(qd_message_t *in_msg,
{
qd_message_pvt_t *msg
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126164203
--- Diff: src/message.c ---
@@ -1026,16 +1150,24 @@ qd_message_t *qd_message_receive(pn_delivery_t
*delivery)
// will only happen
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126168949
--- Diff: src/message.c ---
@@ -1151,89 +1287,140 @@ void qd_message_send(qd_message_t *in_msg,
{
qd_message_pvt_t *msg
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126158278
--- Diff: src/message_private.h ---
@@ -94,10 +94,19 @@ typedef struct {
unsigned char *parse_cursor;
qd_message_depth_t
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126161795
--- Diff: src/message.c ---
@@ -996,21 +1094,47 @@ qd_message_t *qd_message_receive(pn_delivery_t
*delivery
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126161603
--- Diff: src/message.c ---
@@ -996,21 +1094,47 @@ qd_message_t *qd_message_receive(pn_delivery_t
*delivery
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126155845
--- Diff: include/qpid/dispatch/message.h ---
@@ -203,9 +203,9 @@ int qd_message_get_phase_annotation(const qd_message_t
*msg);
void
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126163415
--- Diff: src/message.c ---
@@ -996,21 +1094,47 @@ qd_message_t *qd_message_receive(pn_delivery_t
*delivery
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126172968
--- Diff: src/router_core/forwarder.c ---
@@ -395,9 +415,22 @@ int qdr_forward_closest_CT(qdr_core_t *core,
// Forward to an in
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/109
Cpp drop thread safe
Make container::connect(), open_sender() etc. return void and remove
thread_safe<> and returned<>.
With the work_queue changes everything wor
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/111
I'd like to apply this fix - why did you close the PR? Did you find a
problem? Please respond on https://issues.apache.org/jira/browse/PROTON-1519
---
If your project is set up for it
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/116
Already in progress. The patch is basically correct but I want to rework
how initial-only configuration is passed to use "connection options" passed to
connect() rather than addi
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/116
Commit 36b64f73ffe7e9add93c32da622474d2ee29dce6 in qpid-proton's branch
refs/heads/master from Alan Conway
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=36
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/116
@gberginc I just this very minute pushed the fixes to the master branch you
can get it right away. It will be in the next source code release which is
planned for mid Sept. There isn
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/116
@gberginc we do indeed publish a gem https://rubygems.org/gems/qpid_proton/
- I'm not in charge of that but it should be updated as part of the upcoming
0.18 release, so sometime befor
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/116
On Wed, 2017-08-23 at 00:06 -0700, Gregor Berginc wrote:
> @alanconway initially, I was using the gem from the rubygems link you
mentioned, yes. I am looking forward to the new publis
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/29272ca3948233a417ebc04ba80dedaefc7a4104#commitcomment-24156365
In CMakeLists.txt:
In CMakeLists.txt on line 177:
On Thu, 2017-09-07 at 09:02 -0700, Andrew Stitcher wrote
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/29272ca3948233a417ebc04ba80dedaefc7a4104#commitcomment-24156580
In CMakeLists.txt:
In CMakeLists.txt on line 177:
On Thu, 2017-09-07 at 09:02 -0700, Andrew Stitcher wrote
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/116
Sorry if I overlooked you questions on the mailing list. It should be
updated as part of the next proton-c release (0.18) which is Coming Any
Time Now. Part of what needs to be
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/125
Steps to make openssl.c thread safe, marked with FIXME comments.
This is not a real PR, just for comments.
You can merge this pull request into a Git repository by running:
$ git pull
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/da7f5056a45528196be6733fc56a1f41bda58ded#commitcomment-25161035
In tests/python/proton_tests/utils.py:
In tests/python/proton_tests/utils.py on line 180:
Thanks, that test is
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-proton/pull/109
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/109
Issues discussed here were addressed by
f1ee2681 PROTON-1554: Remove thread-safe template, simplify returned
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/125
For discussion only, will be addressed by
PROTON-1665 | Â | Review locking - TLS / SSL thread safety with proactor
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-proton/pull/125
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/fe9069f9d9f5e27a8c3609eec366517ed8207b20#commitcomment-26254740
In tools/py/proctest.py:
In tools/py/proctest.py on line 10:
It was, fixed
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-dispatch/pull/240
Dispatch memory fixes
These are fixes for valgrind errors in the unit tests that I saw when
running tests on master. There are more to fix, in the system tests.
Requesting review
Github user alanconway commented on the issue:
https://github.com/apache/qpid-dispatch/pull/274
Why not simply make single-session the default and (for now) only
behaviour? I can't see any benefit to multiple sessions, in particular not
session-per-link - AMQP is designed o
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/279#discussion_r179509985
--- Diff: src/container.c ---
@@ -769,11 +777,12 @@ qd_link_t *qd_link(qd_node_t *node, qd_connection_t
*conn, qd_direction_t dir, c
link
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/279#discussion_r179510287
--- Diff: src/container.c ---
@@ -756,8 +756,16 @@ qd_link_t *qd_link(qd_node_t *node, qd_connection_t
*conn, qd_direction_t dir, c
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-cpp/pull/13
QPID-7926: [c++ broker] Windows build error "cannot convert from 'intâ¦
â¦' to 'qpid::sys::PODMutex'"
Renamed PODMutex as GlobalMutex. The important poin
Github user alanconway commented on the issue:
https://github.com/apache/qpid-cpp/pull/13
This patch cleas up a bit rather than working around the problem like pull
#11 (which would also work.)
---
-
To unsubscribe
Github user alanconway commented on the issue:
https://github.com/apache/qpid-cpp/pull/11
The fix would work but I'd prefer to get rid of the bogus assignment rather
than add a dummy constructor to hide it. I've put up pull request #13 that
Github user alanconway commented on the issue:
https://github.com/apache/qpid-cpp/pull/11
Thanks a lot for that! It helped clarify the problem.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/142
PROTON-1831: Incorrect open/close sequence for same link name.
Fixes the server side part of PROTON-1831 - transport error if a duplicate
link
name is attached instead of seg fault
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/142
On Fri, Apr 27, 2018 at 4:57 AM, Robbie Gemmell
wrote:
> The use of "invalid-field" for the error feels like it is maybe a little
> off. Its possible/likely
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/142
The commit makes things better than they were but is not the final fix, as
per comments from you and Gordon. Closing the PR as the JIRA has the comments -
I think they are valid, just
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/147
NO-JIRA: [cpp] add constants for standard AMQP condition names
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alanconway/qpid-proton
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-proton/pull/147
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-dispatch/pull/326
Logging
Some minor changes to dispatch logging based on experience debugging the
HTTP Envoy bridge.
See the commit comments for explanation.
One additional question: I was
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/151
Install tests
Tests can be executed from install for c, cpp, ruby.
Installed under INSTALL-PREFIX/share/proton-VERSION/examples.
Each examples/ subdir has a stand-alone `testme
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/145
I think this makes sense but it makes my head hurt a bit.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/326
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30480860
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
On Wed, Sep 12, 2018 at 10:07 AM, JiÅÃ DanÄk
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30481157
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
Fixed
Commit
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30481273
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
On Wed, Sep 12, 2018 at 10:32 AM, JiÅÃ DanÄk
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/157
WIP: extract connection_options_impl for tests and internal use
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alanconway/qpid-proton
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/157
I want to unit test connection_config::parse by parsing various configs
into connection_options, and then verifying that the connection_options
receives the correct values
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/157
On Fri, Sep 21, 2018 at 11:28 AM Andrew Stitcher
wrote:
> Honestly given the alternative, adding gets for the options seems fairly
> innocuous!
>
> To
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/159
PROTON-1940: [c] normalize encoding of multiple="true" fields
AMQP spec allows several ways to encode a "multiple" field, we allow all in
incoming data or pn_data_t v
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30626748
In ruby/lib/core/connection.rb:
In ruby/lib/core/connection.rb on line 117:
Try indenting by 2 spaces when you
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/159
Changes prompted by astitcher's comments:
- better explanation of mulitple fields, corrected AMQP spec links
- added block comment for vfill format letters
- factore
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/160
WIP: option version of connection_options getters
This is the template approach to option getters - memory safe.
Needs to be extended to all the _options classes, but I want agreement on
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/157
Dropped this approch, see #160 for a public API using proton::option
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-proton/pull/157
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/142
Merged, see JIRA
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-proton/pull/142
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/159
Merged, if there are still objections to using a vfill code lets open a new
issue
---
-
To unsubscribe, e-mail: dev
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/151
Merged: 393f8a67 * PROTON-1798: [c, cpp, ruby] Installable tests for proton
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user alanconway closed the pull request at:
https://github.com/apache/qpid-proton/pull/151
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/160
> Perhaps we could have a C++11 only explicit bool conversion as well as
is_set(). However we would need to experiment a bit as some of the options
themselves are also bools so this might
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/160
Here's the final version, I'll hold off till after release to take a bit of
time to consider API impact. @astitc
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/168
PROTON-1887: [c] Convert C tests to use Catch2 harness.
Convert c/tests from home-baked test macros to the Catch2 test harness.
We are using version 1.x until we can move on from
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/169
Clang format
Format command: clang-format -i $(git ls-files -- *.cpp *.hpp *.c *.h)
Style file is /.clang-format, with the following contents:
Language: Cpp
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/169
On Wed, Nov 28, 2018 at 12:29 PM Andrew Stitcher
wrote:
> *I 100% support having a consistent automated format for the proton
> codebase(s)*
>
> Howev
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/170
PROTON-1959 [cpp] Binary compatible reconnect
The previous commit f53c7683d7e90363 added virtual functions to
messaging_handler
which is a binary incompatible change.
Modify
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/commit/972925477b6f88c230120935e40868a0be0cef9b#commitcomment-17240564
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/83#discussion_r68114202
--- Diff: python/qpid_dispatch_internal/tools/command.py ---
@@ -83,6 +83,11 @@ def connection_options(options, title="Connection
Op
Github user alanconway commented on the issue:
https://github.com/apache/qpid-dispatch/pull/96
I would wrap this (with inline functions or macros to avoid function call
overhead) so that the impl details can be changed by platform. I think these
ops are gcc specific, they definitely
Github user alanconway commented on the issue:
https://github.com/apache/qpid-dispatch/pull/96
Yep - this looks great, I approve.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/81
OOps no: I don't like that this is not allowed ":1234" becase it *is*
allowed by the go URL parser and is correctly interpreted as "listen on all
interfaces" or &quo
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/81
You're right, godoc takes a host:port not a URL. Ship It.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/83#discussion_r83019429
--- Diff: proton-c/bindings/go/src/qpid.apache.org/proton/handlers.go ---
@@ -308,7 +316,7 @@ func (d *MessagingAdapter) HandleEvent(e Event
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/83
Add module tests to proton_test.go. As you can see right now it is empty
which is not ideal (!) The actual tests are in electron/electron_tests.go and
the examples are also auto-tested by
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/87
On Mon, 2016-11-14 at 09:47 -0800, Andrew Stitcher wrote:
> @gemmellr I've been rebasing continually, so it's a surprise the
> dates are so long ago - I'll res
88 matches
Mail list logo
